Bug#451380: tasksel-data: Please stop installing acpi-support and hibernate (in the laptop/desktop task)

2008-03-17 Thread Bart Samwel

Hi STeve,

Steve Langasek wrote:

On Sun, Mar 16, 2008 at 02:47:34PM +0100, Bart Samwel wrote:
doing the same for Ubuntu.  I think we're all agreed that the resume/suspend
code should come out of acpi-support, it's just a question of doing the work
to make it go away gracefully.


[Adding Matthew to the CC list.]

Migrating the quirks might be a bitch. And of course there's the fact 
that pretty much all of acpi-support is configuration files, so it's 
pretty easy to break *someone's* system when you remove the suspend 
support. :-/



but I'll then adapt that so that it translates them into pm-utils calls or
some such.


Sorry, what do you mean?  Currently, /etc/acpi/hibernatebtn.sh just
generates 'acpi_fakekey $KEY_SUSPEND' - surely that's appropriately generic
for all purposes, and doing anything that's more directly tied to pm-utils
would be a regression?


Yeah, it should be "some such" rather than "pm-utils calls". :-) I find 
it interesting that this generates a suspend button and not a hibernate 
button. Maybe the key code is a misnomer? Hmmm I'm not at my own PC 
so I can't check it right now.



I would suggest at least to remove hibernate from the equation.
acpi-support provides hibernation and suspend itself, and maps the
hibernate/suspend keys to its own hibernate and suspend support. It does
not use hibernate. Well, unless you tell it to -- but that option is only
available in version 0.105-1, which is pending upload.


Ok, on closer look I do see that /etc/acpi/events/sleepbtn points at
/etc/acpi/sleep.sh, unlike the various "hibernate" buttons which just
generate a keypress...  I'm not sure why that inconsistency exists in the
first place?


Matthew can probably tell you more about this, but I guess this is so 
that suspend works always, and not only when you're not running 
gnome-power-manager or a similar power management daemon. In these 
situations, acpi-support usually takes the approach of generating a key 
press if gnome-power-manager or klaptopdaemon are running, and DIY if 
they aren't. It's probably wrong if it doesn't do that in this 
particular case -- but there may have been some reason. Matthew?


Cheers,
Bart



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#471172: Please add nvclock and toshset to laptop task

2008-03-16 Thread Bart Samwel
On Sun, March 16, 2008 14:37, Frans Pop wrote:
> On Sunday 16 March 2008, Bart Samwel wrote:
>> The acpi-support package has received numerous requests (see #410918,
>> #434566, #457387, #438665, #445900) to move nvclock and toshset from the
>> Depends list to the Recommends list. As these packages are actually
>> required to make specific laptops function (and the goal of the
>> acpi-support package is to make all laptops "just work"), this is only
>> possible if these packages are installed by default by the laptop task.
>> When this is done, acpi-support will move these dependencies to the
>> Recommends list, so that people may remove these packages at will.
>
> This should preferably not be done in the laptop task, but in the "new"
> discover, which supports installing packages based on specific PCI IDs.
>
> Help to get that in a state where it can be used by default in
> installations would be much appreciated.

I appreciate your concern over this. When the "new" discover is up for it,
of course I wouldn't mind dropping them again from the laptop task.

But until that time, I'd like them to be included in the laptop task, just
so that I can make acpi-support a little bit more sane. And to make
*support* of acpi-support a little bit more sane as well: I'm getting a
new request to reduce the dependencies about once a month, and purely
defending the fact that I'm not fixing it has taken up more time than you
can imagine.

Regarding help with the "discover" package: normally I would love to help,
but I'm already submerged up to my ears in work right now. And I'm
expecting to become a dad somewhere in the next two weeks, so I don't
think it will get any better any time soon. :-)

Cheers,
Bart




Bug#451380: tasksel-data: Please stop installing acpi-support and hibernate (in the laptop/desktop task)

2008-03-16 Thread Bart Samwel
Hi people,

I just want to add my EUR 0.02 to this discussion.

It wouldn't really work if acpi-support was removed from the laptop task,
as pm-utils doesn't handle the keyboard things AFAIK.

I wouldn't mind removing the suspend/hibernate stuff from acpi-support
though, if there is consensus that this should be handled by pm-utils or
some other framework. In that case I'll just rip the whole thing out. What
I'll have to keep is the stuff that handles suspend/hibernate keys, but
I'll then adapt that so that it translates them into pm-utils calls or
some such.

I would suggest at least to remove hibernate from the equation.
acpi-support provides hibernation and suspend itself, and maps the
hibernate/suspend keys to its own hibernate and suspend support. It does
not use hibernate. Well, unless you tell it to -- but that option is only
available in version 0.105-1, which is pending upload.

Cheers,
Bart




Bug#471172: Please add nvclock and toshset to laptop task

2008-03-16 Thread Bart Samwel
Package: tasksel-data
Version: 2.73-1
Severity: normal
Tags: patch

Hi there,

The acpi-support package has received numerous requests (see #410918,
#434566, #457387, #438665, #445900) to move nvclock and toshset from the
Depends list to the Recommends list. As these packages are actually
required to make specific laptops function (and the goal of the
acpi-support package is to make all laptops "just work"), this is only
possible if these packages are installed by default by the laptop task.
When this is done, acpi-support will move these dependencies to the
Recommends list, so that people may remove these packages at will.

A patch is attached.

Cheers,
Bart--- tasks/laptop-old	2008-03-16 15:00:35.0 +0100
+++ tasks/laptop	2008-03-16 15:12:56.0 +0100
@@ -14,6 +14,11 @@
  apmd
  acpi
  acpi-support
+# nvclock and toshset are Recommended by acpi-support, but should be installed
+# by the laptop task because they are needed to make nv and toshset laptops
+# "just work".
+ nvclock
+ toshset
  pcmciautils
  wireless-tools
  wpasupplicant