Re: [PATCH] Keep Linux modules.builtin file in the initrd

2014-09-28 Thread Cyril Brulebois
Ben Hutchings  (2014-09-28):
> modules.builtin is generated at kernel build time and can't be
> regenerated from the installed kernel or modules.  If it's missing
> when depmod runs again within the installer, depmod will generate an
> empty modules.builtin.bin and issue a warning.  modprobe will also
> fail noisily if asked to load a module that is actually built-in.
> ---
> I've pushed this already; hope that's OK.

Easy enough to revert if it causes any issues. Thanks for the
report/patch/heads-up.

Mraw,
KiBi.


signature.asc
Description: Digital signature


[PATCH] Keep Linux modules.builtin file in the initrd

2014-09-28 Thread Ben Hutchings
modules.builtin is generated at kernel build time and can't be
regenerated from the installed kernel or modules.  If it's missing
when depmod runs again within the installer, depmod will generate an
empty modules.builtin.bin and issue a warning.  modprobe will also
fail noisily if asked to load a module that is actually built-in.
---
I've pushed this already; hope that's OK.

Ben.

 build/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build/Makefile b/build/Makefile
index 225afb1..6310226 100644
--- a/build/Makefile
+++ b/build/Makefile
@@ -424,6 +424,7 @@ ifdef KERNELVERSION
 
# These files depmod makes are used by udev.
find $(TREE)/lib/modules/ -maxdepth 2 -name 'modules*.bin' \
+   -not -name 'modules.builtin.bin' \
-not -type d | while read f; do rm -f $${f%.bin}; done
 
# These files are used to build special kernel images for some

-- 
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.


signature.asc
Description: This is a digitally signed message part