Re: Backport fix for #789600?

[Cyril Brulebois]

Steve McIntyre  (2015-11-29):
> And I can see you've got that fixed. Checking a build from today, it
> looks like it's picked up the part_gpt module just fine. I've
> experimented with the kind of setup as suggested in #789600 (just
> copying all the files from the ISO onto a GPT-partitioned USB stick)
> and everything just worked.
> 
> So yes please - let's backport this for the next Jessie point release.

I've added a changelog entry and pushed the two cherry-picks to the
jessie branch.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Re: Backport fix for #789600?

[Steve McIntyre]

On Fri, Nov 27, 2015 at 08:07:52PM +0100, Cyril Brulebois wrote:
>Steve McIntyre  (2015-11-27):
>> Yup, makes sense. I'll double-check the latest daily later on when I'm
>> home.
>
>Except daily builds are missing; investigating.

And I can see you've got that fixed. Checking a build from today, it
looks like it's picked up the part_gpt module just fine. I've
experimented with the kind of setup as suggested in #789600 (just
copying all the files from the ISO onto a GPT-partitioned USB stick)
and everything just worked.

So yes please - let's backport this for the next Jessie point release.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
  Getting a SCSI chain working is perfectly simple if you remember that there
  must be exactly three terminations: one on one end of the cable, one on the
  far end, and the goat, terminated over the SCSI chain with a silver-handled
  knife whilst burning *black* candles. --- Anthony DeBoer

Re: Backport fix for #789600?

[Cyril Brulebois]

Steve McIntyre  (2015-11-27):
> Yup, makes sense. I'll double-check the latest daily later on when I'm
> home.

Except daily builds are missing; investigating.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Re: Backport fix for #789600?

[Cyril Brulebois]

Steve McIntyre  (2015-11-27):
> AFAICS it should just work (TM) - the existing code there is just
> listing on the grub-mkimage command line the modules that we want
> built-in. As we're already clearly using part_msdos, part_gpt is built
> at the same level so should get picked up in the same way.

OK. Would still love to see a confirmation that it's actually working
before pushing this to the jessie branch.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Re: Backport fix for #789600?

[Steve McIntyre]

On Fri, Nov 27, 2015 at 01:57:28AM +0100, Cyril Brulebois wrote:
>Steve McIntyre  (2015-11-26):
>> I've pushed a trivial fix for this today, so new unstable/testing
>> d-i builds should be more useful for folks on GPT media. What do you
>> think about adding this for new Jessie builds? (And how's the best way
>> to do that?)
>
>Ah, I initially looked at debian-cd, but that's just debian-installer.
>Apart from a missing changelog entry, I'm happy to cherry-pick the said
>commit into the jessie branch for a later upload for a point release:
>| commit c9e26e4e97b72fefd6c1ea894aba33750fdded53
>| Author: Steve McIntyre 
>| Date:   Thu Nov 26 16:20:37 2015 +
>| 
>| Add the part_gpt module into the core grub image
>| 
>| Make it easier for users doing slightly different things with our
>| images; include support for GPT partition tables as well as msdos
>| Closes: #789600
>| 
>
>I'm not familiar with this area. Is it sufficient to add it to some
>search command to make it available? I mean: will the grub module be
>where it's expected, or is some pre-existing copy step needed for that
>to work? (I see it's available in various grub-* packages, and a
>suitable grub-* package will likely be installed at this point, so I
>suppose the addition to the search command might be sufficient, but
>let's be sure.)

AFAICS it should just work (TM) - the existing code there is just
listing on the grub-mkimage command line the modules that we want
built-in. As we're already clearly using part_msdos, part_gpt is built
at the same level so should get picked up in the same way.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"When C++ is your hammer, everything looks like a thumb." -- Steven M. Haflich

Re: Backport fix for #789600?

[Steve McIntyre]

On Fri, Nov 27, 2015 at 05:34:58PM +0100, Cyril Brulebois wrote:
>Steve McIntyre  (2015-11-27):
>> AFAICS it should just work (TM) - the existing code there is just
>> listing on the grub-mkimage command line the modules that we want
>> built-in. As we're already clearly using part_msdos, part_gpt is built
>> at the same level so should get picked up in the same way.
>
>OK. Would still love to see a confirmation that it's actually working
>before pushing this to the jessie branch.

Yup, makes sense. I'll double-check the latest daily later on when I'm
home.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"Because heaters aren't purple!" -- Catherine Pitt

Backport fix for #789600?

[Steve McIntyre]

I've pushed a trivial fix for this today, so new unstable/testing
d-i builds should be more useful for folks on GPT media. What do you
think about adding this for new Jessie builds? (And how's the best way
to do that?)

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
You raise the blade, you make the change... You re-arrange me 'til I'm sane...

Re: Backport fix for #789600?

[Cyril Brulebois]

Steve McIntyre  (2015-11-26):
> I've pushed a trivial fix for this today, so new unstable/testing
> d-i builds should be more useful for folks on GPT media. What do you
> think about adding this for new Jessie builds? (And how's the best way
> to do that?)

Ah, I initially looked at debian-cd, but that's just debian-installer.
Apart from a missing changelog entry, I'm happy to cherry-pick the said
commit into the jessie branch for a later upload for a point release:
| commit c9e26e4e97b72fefd6c1ea894aba33750fdded53
| Author: Steve McIntyre 
| Date:   Thu Nov 26 16:20:37 2015 +
| 
| Add the part_gpt module into the core grub image
| 
| Make it easier for users doing slightly different things with our
| images; include support for GPT partition tables as well as msdos
| Closes: #789600
| 

I'm not familiar with this area. Is it sufficient to add it to some
search command to make it available? I mean: will the grub module be
where it's expected, or is some pre-existing copy step needed for that
to work? (I see it's available in various grub-* packages, and a
suitable grub-* package will likely be installed at this point, so I
suppose the addition to the search command might be sufficient, but
let's be sure.)

Mraw,
KiBi.


signature.asc
Description: Digital signature