Re: Branched languagechooser
Christian Perrier wrote: No, the code is not optimal at all. The sourcing is copied from languagechooser as well as the program being a standalone program. Clean code is far from being my best quality, even for sheel scripts, which are the only ones I'm really able to write. So, making all this cleaner is really needed, but I would appreciate if someone does it : otherwise, I would lose a lot of time trying to do so, without real efficiency. So, I will currently only fix the errors aboveat least for today. I've done some cleanup.. I don't understand the use of COUNTRYCODE_LANGUAGECHOOSER. It seems that is the selected country is the same as the default country as set in this variable, then LOCALE will not be set, and debian-installer/locale will be set to . Is there a reason to have countrychooser/default-country? Nothing currently uses it. -- see shy jo signature.asc Description: Digital signature
Re: Branched languagechooser
Quoting Joey Hess ([EMAIL PROTECTED]): I gave it a try. I really like the new language chooser, it feels clean and simple. I don't know whether the country codes on the left column (and especially the C) will puzzle users who are not familiar with that convention. This came from some threads here about how to sort the screen. The conclusion I had was using the ISO codes. The one who suggested this (no more idea who it was) just mentioned that this way, users will have little more chance to know their own country code. The C is a trick. I wanted to keep English at the top of the list, so using the default locale convention was a good way to do this. This may be a bit confusing as this does not trigger the C locale but indeed en as language code and US as default country (before countrychooser) countrychooser does not support backing up, and if I choose English, I get Andorra as a default country, which is not the best default. If I hit u for US, it goes down one line the the UAE. I hit it again and it jumped all the way down to the rest of the u's. Minor outlying islands of the US are listed before the main country. For some reason, after choosing United States, kbd-chooser defaulted me to a Bulgarian keyboard. Why? Well, in the shell, debconf-get debian-installer/country says UM. Not US. I'm sure I did not pick the outlying islands; I went back and tried it again and still got UM. Probably a substring match bug. Of course I doubt that residents of the Midway Islands use Bulgarian keyboards either.. ;-) There is some bad coding there, as far as I have seen while testing. I wanted to clean this up a bit yesterday but some discussions about timezones as wellas several contacts with translators prevented me to do so. In the code: Is sourcing these countrycodemap, countrymap, programs really necessary? I would write these as subroutines. It would also save space to move the countrychooser program into the package's postinst. No, the code is not optimal at all. The sourcing is copied from languagechooser as well as the program being a standalone program. Clean code is far from being my best quality, even for sheel scripts, which are the only ones I'm really able to write. So, making all this cleaner is really needed, but I would appreciate if someone does it : otherwise, I would lose a lot of time trying to do so, without real efficiency. So, I will currently only fix the errors aboveat least for today. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Branched languagechooser
As some of you may have noticed, and as suggested by Joey and Steve Langasek, I created a languagechooser_ng branch in languagechooser (I did so two days ago but forgot to announce it here). This will allow those who want to test out my languagechooser proposal along with the new countrychooser to give them a look. May someone explain me how I can merge in possible changes made to languagechooser HEAD into the languagechooser_ng branch? As I already told, my CVS knowledge is a bit crude and empiric..:-) For instance, I stupidely made my branching on some versions of files other than those who were in CVS at the moment I branched out. The changes were easy to manually merge in, however -- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Branched languagechooser
Christian Perrier wrote: As some of you may have noticed, and as suggested by Joey and Steve Langasek, I created a languagechooser_ng branch in languagechooser (I did so two days ago but forgot to announce it here). This will allow those who want to test out my languagechooser proposal along with the new countrychooser to give them a look. I gave it a try. I really like the new language chooser, it feels clean and simple. I don't know whether the country codes on the left column (and especially the C) will puzzle users who are not familiar with that convention. countrychooser does not support backing up, and if I choose English, I get Andorra as a default country, which is not the best default. If I hit u for US, it goes down one line the the UAE. I hit it again and it jumped all the way down to the rest of the u's. Minor outlying islands of the US are listed before the main country. For some reason, after choosing United States, kbd-chooser defaulted me to a Bulgarian keyboard. Why? Well, in the shell, debconf-get debian-installer/country says UM. Not US. I'm sure I did not pick the outlying islands; I went back and tried it again and still got UM. Probably a substring match bug. Of course I doubt that residents of the Midway Islands use Bulgarian keyboards either.. ;-) In the code: Is sourcing these countrycodemap, countrymap, programs really necessary? I would write these as subroutines. It would also save space to move the countrychooser program into the package's postinst. -- see shy jo signature.asc Description: Digital signature
