Bug#488494: cdebconf: Make the dark theme even more readable
On Thursday 17 July 2008, Samuel Thibault wrote: Ok, so for coherency we should probably go with the black on gray. Here is a patch that fixes the progression bar too. Committed in SVN. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
Hello, Frans Pop, le Fri 18 Jul 2008 08:05:17 +0200, a écrit : On Thursday 17 July 2008, Samuel Thibault wrote: Ok, so for coherency we should probably go with the black on gray. Here is a patch that fixes the progression bar too. Committed in SVN. Thanks, however slang was written by american people, so the UK orthography is not recognized, it has to be lightgray, see attached patch. Samuel Index: src/modules/frontend/newt/newt.c === --- src/modules/frontend/newt/newt.c(r�vision 54429) +++ src/modules/frontend/newt/newt.c(copie de travail) @@ -90,7 +90,7 @@ gray, brightred,/* active button fg, bg */ white, gray,/* checkbox fg, bg */ /*yellow, brown,*/ /* active checkbox fg, bg */ - black, lightgrey, /* active checkbox fg, bg */ + black, lightgray, /* active checkbox fg, bg */ /*yellow, blue,*/ /* entry box fg, bg */ white, black, /* entry box fg, bg */ /*blue, lightgray,*//* label fg, bg */
Bug#488494: cdebconf: Make the dark theme even more readable
On Friday 18 July 2008, Samuel Thibault wrote: Thanks, however slang was written by american people, so the UK orthography is not recognized, it has to be lightgray, see attached patch. Fixed. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
Richard Rafalski, le Thu 17 Jul 2008 17:08:07 +0200, a écrit : I've put an image doing this on http://brl.thefreecat.org/mini.iso And an image using white on blue as you suggested on http://brl.thefreecat.org/mini-blue.iso Thank you for the images. Both look good. It is ok to use the black asterisk an the gray background. Ok, so for coherency we should probably go with the black on gray. Here is a patch that fixes the progression bar too. Samuel Index: src/modules/frontend/newt/newt.c === --- src/modules/frontend/newt/newt.c(r�vision 54394) +++ src/modules/frontend/newt/newt.c(copie de travail) @@ -89,7 +89,8 @@ black, lightgray, /* button fg, bg */ gray, brightred,/* active button fg, bg */ white, gray,/* checkbox fg, bg */ - yellow, brown, /* active checkbox fg, bg */ + /*yellow, brown,*/ /* active checkbox fg, bg */ + black, lightgray, /* active checkbox fg, bg */ /*yellow, blue,*/ /* entry box fg, bg */ white, black, /* entry box fg, bg */ /*blue, lightgray,*//* label fg, bg */ @@ -104,9 +105,9 @@ white, black, /* help line */ yellow, blue, /* root text */ /*blue,*/ /* scale full */ - gray, /* scale full */ + black,/* scale full */ /*red,*/ /* scale empty */ - lightgray,/* scale empty */ + blue, /* scale empty */ blue, lightgray,/* disabled entry fg, bg */ /*black, lightgray,*/ /* compact button fg, bg */ white, black, /* compact button fg, bg */
Bug#488494: cdebconf: Make the dark theme even more readable
On Monday 30 June 2008, Samuel Thibault wrote: Oops, I should have explained indeed: I just meant that we won't get bright colors (e.g. real white) in bterm until bogl gets fixed, i.e. even if the cdebconf part is fixed, the result will be hindered by the bug of bogl. OK, but that means that it does not actually block the change in cdebconf. That can be uploaded as is. I've just tested the new dark theme as I was testing other things anyway and I must say the new colors look much nicer to me. Basically just plain, quiet blackwite with minor accents. There is one thing that I noticed. If you tab from a selected item in a list to the GoBack button, the selected item gets a blue background. This does not seem to really fit with the theme as a whole. Some (distinguishable) color difference should be preserved though. In the default theme the background of the selected item changes from red to blue (against a white window background). Could you have a look at that Samuel? Cheers, FJP -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
Frans Pop, le Tue 15 Jul 2008 12:58:02 +0200, a écrit : On Monday 30 June 2008, Samuel Thibault wrote: Oops, I should have explained indeed: I just meant that we won't get bright colors (e.g. real white) in bterm until bogl gets fixed, i.e. even if the cdebconf part is fixed, the result will be hindered by the bug of bogl. OK, but that means that it does not actually block the change in cdebconf. That can be uploaded as is. Ah, yes. The comment on http://www.debian.org/Bugs/server-control.en.html could probably be more clear on that. There is one thing that I noticed. If you tab from a selected item in a list to the GoBack button, the selected item gets a blue background. This does not seem to really fit with the theme as a whole. Some (distinguishable) color difference should be preserved though. In the default theme the background of the selected item changes from red to blue (against a white window background). Could you have a look at that Samuel? I had already actually. The problem is that the background color is technically limited to the dark palette, i.e. black, gray, and dark colors. Setting the background of the selection to black is obviously not correct unless we change the foreground color, but I'm afraid only changing the foreground color does not provide enough contrast. Leaving it gray provides confusion about what currently has keyboard focus. That's why I left it blue, which lets the user know which element is selected, but still be different from gray, for less confusion. I don't know if another color would fit better, anybody on the list would have an idea? To test, just boot the mini-ISO on http://brl.thefreecat.org/mini.iso press tab, and type theme=dark Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
On Tuesday 15 July 2008, Samuel Thibault wrote: I had already actually. The problem is that the background color is OK :-) technically limited to the dark palette, i.e. black, gray, and dark colors. Setting the background of the selection to black is obviously not correct unless we change the foreground color, but I'm afraid only changing the foreground color does not provide enough contrast. Leaving it gray provides confusion about what currently has keyboard focus. That's why I left it blue, which lets the user know which element is selected, but still be different from gray, for less confusion. I don't know if another color would fit better, anybody on the list would have an idea? Are there any colors that are bad because they look like grey to some colorblind users? If not, I think I'd personally prefer dark red over dark blue with dark grey. Another thing you could look at is to make this extra color appear a bit more in the theme than it does now, for example as the background color around the border or for the border itself. That would make it look a bit less random. In the end it's probably just a question of trying a few things and finding something that looks decent. Leaving it as it is now is also an option of course. Basically I just noticed it and it struck me as illogical. Cheers, FJP -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
Frans Pop, le Tue 15 Jul 2008 18:17:16 +0200, a écrit : I don't know if another color would fit better, anybody on the list would have an idea? Are there any colors that are bad because they look like grey to some colorblind users? I've no idea, that's why I ask for people on debian-accessibility to test :) Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
Frans Pop, le Tue 15 Jul 2008 18:17:16 +0200, a écrit : Are there any colors that are bad because they look like grey to some colorblind users? If not, I think I'd personally prefer dark red over dark blue with dark grey. For people on the list to test it, I've put a second mini.iso on http://brl.thefreecat.org/mini-red.iso Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
Package: cdebconf
Severity: minor
Tags: patch
Hello,
The current dark theme of newt does not use bright colors, and sometimes
uses background colors for no real use, leading to less readability.
The attached patch makes a few fixes.
The current text frontend does not have a dark theme, this adds one for
the linux and bterm console cases.
Samuel
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'oldstable'), (500, 'unstable'), (500,
'stable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.25
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash
--
Samuel
And the next time you consider complaining that running Lucid Emacs
19.05 via NFS from a remote Linux machine in Paraguay doesn't seem to
get the background colors right, you'll know who to thank.
(By Matt Welsh)
diff -ur /tmp/cdebconf-0.131/src/modules/frontend/newt/newt.c
cdebconf-0.131-mine/src/modules/frontend/newt/newt.c
--- /tmp/cdebconf-0.131/src/modules/frontend/newt/newt.c2008-05-06
21:32:47.0 +0100
+++ cdebconf-0.131-mine/src/modules/frontend/newt/newt.c2008-06-29
11:43:45.0 +0100
@@ -75,24 +75,27 @@
};
struct newtColors newtAltColorPalette = {
- white, blue,/* root fg, bg */
+ /*white, blue,*//* root fg, bg */
+ white, black, /* root fg, bg */
/*black, lightgray,*/ /* border fg, bg */
white, black, /* border fg, bg */
/*black, lightgray,*/ /* window fg, bg */
white, black, /* window fg, bg */
/*white, black,*/ /* shadow fg, bg */
- white, blue,/* shadow fg, bg */
+ white, black, /* shadow fg, bg */
/*red, lightgray,*/ /* title fg, bg */
yellow, black, /* title fg, bg */
- brightred, gray,/* button fg, bg */
+ /*brightred, gray,*//* button fg, bg */
+ black, lightgray, /* button fg, bg */
gray, brightred,/* active button fg, bg */
white, gray,/* checkbox fg, bg */
yellow, brown, /* active checkbox fg, bg */
- yellow, blue, /* entry box fg, bg */
+ /*yellow, blue,*/ /* entry box fg, bg */
+ white, black, /* entry box fg, bg */
/*blue, lightgray,*//* label fg, bg */
brightred, black, /* label fg, bg */
/*black, lightgray,*/ /* listbox fg, bg */
- lightgray, black, /* listbox fg, bg */
+ white, black, /* listbox fg, bg */
yellow, blue, /* active listbox fg, bg */
/*black, lightgray,*/ /* textbox fg, bg */
white, black, /* textbox fg, bg */
@@ -100,12 +103,14 @@
/*white, blue,*//* help line */
white, black, /* help line */
yellow, blue, /* root text */
- blue, /* scale full */
- red, /* scale empty */
+ /*blue,*/ /* scale full */
+ gray, /* scale full */
+ /*red,*/ /* scale empty */
+ lightgray,/* scale empty */
blue, lightgray,/* disabled entry fg, bg */
/*black, lightgray,*/ /* compact button fg,
bg */
- lightgray, black, /* compact button fg, bg */
- yellow, gray, /* active sel listbox */
+ white, black, /* compact button fg, bg */
+ black, lightgray, /* active sel listbox */
black, brown/* selected listbox */
};
diff -ur /tmp/cdebconf-0.131/src/modules/frontend/text/text.c
cdebconf-0.131-mine/src/modules/frontend/text/text.c
--- /tmp/cdebconf-0.131/src/modules/frontend/text/text.c2008-04-09
17:34:02.0 +0100
+++ cdebconf-0.131-mine/src/modules/frontend/text/text.c2008-06-29
11:34:22.0 +0100
@@ -751,10 +751,18 @@
static int text_initialize(struct frontend *obj, struct configuration *conf)
{
struct frontend_data *data = NEW(struct frontend_data);
+ char *term = getenv(TERM);
+ char *palette = getenv(FRONTEND_BACKGROUND);
data-previous_title = NULL;
obj-data = data;
obj-interactive =
Processed: Re: Bug#488494: cdebconf: Make the dark theme even more readable
Processing commands for [EMAIL PROTECTED]: tag 488494 + pending Bug#488494: cdebconf: Make the dark theme even more readable Tags were: patch Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
tag 488494 + pending thanks On Sunday 29 June 2008, Samuel Thibault wrote: The current dark theme of newt does not use bright colors, and sometimes uses background colors for no real use, leading to less readability. The attached patch makes a few fixes. The current text frontend does not have a dark theme, this adds one for the linux and bterm console cases. Committed. Thx. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#488494: cdebconf: Make the dark theme even more readable
On Sunday 29 June 2008, Debian Bug Tracking System wrote: Processing commands for [EMAIL PROTECTED]: # Automatically generated email from bts, devscripts version 2.10.30 block 488494 with 486933 Bug#486933: bogl: should support enter_bold_mode Bug#488494: cdebconf: Make the dark theme even more readable Was blocked by: 488493 Blocking bugs of 488494 added: 486933 Eh... Samuel, what does this mean? That I should revert the commit to cdebconf because that bogl BR needs to be implemented first? signature.asc Description: This is a digitally signed message part.
Re: Bug#488494: cdebconf: Make the dark theme even more readable
Frans Pop, le Mon 30 Jun 2008 00:13:12 +0200, a écrit : On Sunday 29 June 2008, Debian Bug Tracking System wrote: Processing commands for [EMAIL PROTECTED]: # Automatically generated email from bts, devscripts version 2.10.30 block 488494 with 486933 Bug#486933: bogl: should support enter_bold_mode Bug#488494: cdebconf: Make the dark theme even more readable Was blocked by: 488493 Blocking bugs of 488494 added: 486933 Samuel, what does this mean? That I should revert the commit to cdebconf because that bogl BR needs to be implemented first? Oops, I should have explained indeed: I just meant that we won't get bright colors (e.g. real white) in bterm until bogl gets fixed, i.e. even if the cdebconf part is fixed, the result will be hindered by the bug of bogl. Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
