Re: Bug#661056: please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
On Wed, Jan 02, 2013 at 07:47:00PM +0100, Cyril Brulebois wrote: Control: tag -1 moreinfo ... netcfg has the following finish-install script: ,---[ finish-install.d/97release-dhcp-lease ]--- | #!/bin/sh | | set -e | | pid=$(pidof udhcpc) || true | [ -n $pid ] kill -USR2 $pid | | if [ $(pidof dhclient || true) ]; then | dhclient -r || true | dhclient -6 -r || true | fi `--- which seems to match what you proposed in #610553: | Solution - please send SIGUSR2 to the udhcpc process at end of | installation (menu items: finish up the installation, or abort the | installation). AFAICT, $(pidof udhcpc) works, and the script quoted above looks reasonable. From a quick strace, it looks like udhcpc is properly releasing the lease on SIGUSR2. Any chance you could catch a network trace during the end of installation, and one on normal shutdown? To make sure DHCPRELEASE happens properly, you could also compare to a network trace when calling “kill -USR2 $(pidof udhcpc)” from a console after you obtained a lease. Hi Cyril, I recently installed wheezy-7.0.0, for the following versions of Debian, and the results for this are, GNU/Linux amd64 - this bug is still occurring (install was completed). GNU/kfreebsd amd64 - this bug did not occur after network had been detected successfully, (install aborted by C-A-Delete - couldn't get past recognize disks). Note - I think that GNU/kfreebsd maybe uses dhclient rather than udhcpc. perhaps something weird is happening with the kill -USR2 $pid. Since I had to do something to get my internet connection up after installing GNU/Linux amd64, here is what I did to have udhcpc release the lease, udhcpc -n -q -R -r ipv4-address on my production wheezy system. Then I just ran ifup eth0 and my internet access had been restored. As far as a network trace is concerned, I reget that I cannot do this for you, as I have just a single PC to work with. I *know* that the lease is released after I ran udhcpc -n -q -R -r ipv4-address, because udhcpc says so - actually udhcpc first (re)acquires the lease for the specified ipv4-address, and then immediately releases it. If the lease had not been outstanding, then udhcpc would not have been able to (re)acquire it, because this policy is strictly enforced by my ISP. I am not familiar with the D-I environment under which busybox udhcpc is being run, so I cannot comment on the code snippet that you provided. I do have udhcpc package installed on my production system, it may be running different up / down scripts then those that are being run in the D-I environment. In closing, I am able to reliably reproduce this reported bug at will. Can't you just print something like ip addr show *after* netcfg has been called in order to see what is happening here? Thanks, -- Jeffrey Sheinberg -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130520203136.ga13...@l2.bsrd.net
Re: Bug#661056: please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
On 05/01/13 20:53, Jeffrey Sheinberg wrote: Here is the tail of the installer log: Dec 28 12:49:56 finish-install: info: Running /usr/lib/finish-install.d/20final- message Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/30hw-det ect Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/50config-target-network Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/55netcfg-network-manager Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/60cleanup Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/65partman-md Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/90base-installer Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/90console Dec 28 12:50:13 finish-install: info: Running /usr/lib/finish-install.d/94save-logs Did you retrieve that log after reboot? If so, there was probably a little more happened after the log was saved... For comparison, here is my own log using today's wheezy d-i installer image - I redirected this over a serial console though to make sure I got all of it: Jan 5 22:38:11 finish-install: info: Running /usr/lib/finish-install.d/90base-installer Jan 5 22:38:12 finish-install: info: Running /usr/lib/finish-install.d/90console Jan 5 22:38:12 finish-install: info: Running /usr/lib/finish-install.d/94save-logs Jan 5 22:38:34 finish-install: info: Running /usr/lib/finish-install.d/95umount Jan 5 22:38:40 finish-install: umount: can't umount /dev: Device or resource busy Jan 5 22:38:40 finish-install: umount: can't umount /dev: Device or resource busy Jan 5 22:38:40 finish-install: umount: can't umount /: Invalid argument Jan 5 22:38:40 finish-install: info: Running /usr/lib/finish-install.d/97release-dhcp-lease So in my case release-dhcp-lease was actually run, after save-logs. If you have a serial console, you can probably syslog on it by dropping to a shell and: $ sed -ie s/tty3/ttyS0/ /etc/inittab kill -HUP 1 Or you can even set preseed/early_command to that command line (putting the whole thing in quotes; you need to send SIGHUP to init to reload the inittab). Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50e8ae1a.2020...@pyro.eu.org
Re: Bug#661056: please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Control: tag -1 moreinfo Hi Jeffrey, Jeffrey Sheinberg j...@bsrd.net (28/12/2012): Likewise, this bug is still occuring in wheezy, I used: debian-wheezy-DI-b4-amd64-CD-1.iso to make this determination. I am cc-ing debian-boot, in the hope that someone there will be motivated to take some interest in fixing this bug. netcfg has the following finish-install script: ,---[ finish-install.d/97release-dhcp-lease ]--- | #!/bin/sh | | set -e | | pid=$(pidof udhcpc) || true | [ -n $pid ] kill -USR2 $pid | | if [ $(pidof dhclient || true) ]; then | dhclient -r || true | dhclient -6 -r || true | fi `--- which seems to match what you proposed in #610553: | Solution - please send SIGUSR2 to the udhcpc process at end of | installation (menu items: finish up the installation, or abort the | installation). AFAICT, $(pidof udhcpc) works, and the script quoted above looks reasonable. From a quick strace, it looks like udhcpc is properly releasing the lease on SIGUSR2. Any chance you could catch a network trace during the end of installation, and one on normal shutdown? To make sure DHCPRELEASE happens properly, you could also compare to a network trace when calling “kill -USR2 $(pidof udhcpc)” from a console after you obtained a lease. Mraw, KiBi. signature.asc Description: Digital signature
Processed: Re: Bug#661056: please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Processing control commands: tag -1 moreinfo Bug #661056 [installation-reports] please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP Added tag(s) moreinfo. -- 661056: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661056 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.b661056.135715242316157.transcr...@bugs.debian.org
Re: Bug#661056: please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Hi, This bug was never fixed in squeeze, as far as I can tell. Likewise, this bug is still occuring in wheezy, I used: debian-wheezy-DI-b4-amd64-CD-1.iso to make this determination. I am cc-ing debian-boot, in the hope that someone there will be motivated to take some interest in fixing this bug. Thanks, -- Jeffrey Sheinberg -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121228191845.ga11...@l2.bsrd.net
Bug#661056: please re-open Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Package: installation-reports Severity: normal Hi, Please refer to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610553 for details of the original bug report. Basically, this bug still persists with squeeze: 6.0.0, 6.0.4, and for wheezy: 20120206-04:56, for both i386 and amd64. Details of my testing method follow below. On Sun, Feb 06, 2011 at 09:42:21AM +, Debian Bug Tracking System wrote: This is an automatic notification regarding your Bug report which was filed against the netcfg package: #610553: installation-reports: does not cleanly deconfigure network configured with DHCP It has been closed by Matt Palmer mpal...@debian.org. Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Matt Palmer mpal...@debian.org by replying to this email. I just ran a few tests, and it seems that this bug is still occuring. I did my test by booting from a CD-ROM that I burned from the downloaded iso image from the official Debian CD website. I tried each of these images, and they all were all unable to bring up the eth0 / dhcp interface after the first reboot, since it had never been released by the installation procedure. 'Debian GNU/Linux 6.0.0 Squeeze - Official i386 CD Binary-1 20110205-17:27 (20110205)' 'Debian GNU/Linux 6.0.4 Squeeze - Official amd64 CD Binary-1 20120128-13:42 (20120128)' 'Debian GNU/Linux testing Wheezy - Official Snapshot amd64 CD Binary-1 20120206-04:56 (20120206)' Each test consisted of a complete new install of the basic debian system, which included successfully bringing up of the network (eth0 via dhcp) as part of the installation procedure, followed by a reboot into the new system. The network did not come up successfully on the newly installed system, see bug#610553 for details. On the newly installed system, using the ip address that was in the installer log, I was able to manually obtain the lease using busybox udhcpc, and then manually bring it up using ifconfig / route. This demonstrates that the impediment to bringing up of eth0 via dhcp was due to debian-installer not releasing the lease prior to shutting down and rebooting into the newly installed system. -- Thanks, Jeffrey Sheinberg -- System Information: Debian Release: 6.0.4 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'stable') Architecture: i386 (x86_64) Kernel: Linux 3.2.0-0.bpo.1-amd64 (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120223201155.10720.74024.report...@l2.bsrd.net
Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Matthew Palmer wrote: Yeah, I thought about that, but it appears as though finish-install wants to own all those sorts of things itself. I would have expected 50config-target-network to be in netcfg, but it's not. On the other hand, if that's more of a historical screwup That's not a screwup, and it's not in netcfg for good reason: That is a fallback to ensure the files are present in the event that netcfg was not used in the installation at all. Numerous packages *do* install finish-install hooks. I count at least 16 such. -- see shy jo signature.asc Description: Digital signature
Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
reassign 610553 netcfg thanks On Thu, Jan 20, 2011 at 12:29:29PM -0400, Joey Hess wrote: Matthew Palmer wrote: Yeah, I thought about that, but it appears as though finish-install wants to own all those sorts of things itself. I would have expected 50config-target-network to be in netcfg, but it's not. On the other hand, if that's more of a historical screwup That's not a screwup, and it's not in netcfg for good reason: That is a fallback to ensure the files are present in the event that netcfg was not used in the installation at all. To my mind, it would seem to be cleaner that whatever does whatever network configuration is done is required to persist it's own changes. (I'm thinking of a hypothetical NetworkManager-enabled installer, for example). Hence why having that hook in finish-install made no sense to me. Numerous packages *do* install finish-install hooks. I count at least 16 such. Righto. In netcfg it goes. - Matt -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110120224438.ge3...@hezmatt.org
Processed: Re: Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Processing commands for cont...@bugs.debian.org: reassign 610553 netcfg Bug #610553 [finish-install] installation-reports: does not cleanly deconfigure network configured with DHCP Bug reassigned from package 'finish-install' to 'netcfg'. thanks Stopping processing here. Please contact me if you need assistance. -- 610553: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610553 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.12955635433846.transcr...@bugs.debian.org
Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Package: installation-reports Severity: normal Hi, Install of squeeze-rc1 (expert mode, non-graphical) from *.iso - works great except the network is not cleanly deconfigured for DHCP. Solution - please send SIGUSR2 to the udhcpc process at end of installation (menu items: finish up the installation, or abort the installation). Discussion - after the installation completes successfully, the computer reboots into the new installation, however, the network configuration via DHCP fails in the new installation. This is because my ISP's DHCP server already has handed out a lease to my computer and this lease is still active. This active lease was obtained during the installation process, however, the installation process did not release the DCHP lease before it terminated the installation. Why hasn't this problem been reported before? Answer - most routers will just re-offer an active DHCP lease to the same MAC address that had originally obtained the lease. However, my ISP's DHCP servers will only re-offer an active leave when the requested ip-address matches the ip-address that was provided with the original lease. Note that on my other production Debian lenny and squeeze systems, the DHCP lease is always released when the network is deconfigured. Thanks, Jeffrey Sheinberg -- System Information: Debian Release: 6.0 APT prefers proposed-updates APT policy: (500, 'proposed-updates'), (500, 'testing'), (500, 'stable') Architecture: i386 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110119203259.7361.16680.report...@l2.bsrd.net
Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
clone 610553 reassign 610553 finish-install reassign -1 di-utils-reboot thanks On Wed, Jan 19, 2011 at 03:32:59PM -0500, Jeffrey Sheinberg wrote: Install of squeeze-rc1 (expert mode, non-graphical) from *.iso - works great except the network is not cleanly deconfigured for DHCP. Solution - please send SIGUSR2 to the udhcpc process at end of installation (menu items: finish up the installation, or abort the installation). That can probably be arranged. It covers two separate packages, so I'm going to clone out this report to get it fixed everywhere (finish-install for regular completion, and di-utils-reboot for Abort the installation). di-utils-exit-installer (Exit the installer) is only used in installer demos, apparently, so that probably doesn't need to be changed. (Note to implementors: example code for wiping out the DHCP client is in netcfg/killall.sh; only minor adaptations should be required, although it appears that different DHCP clients use different methods to signal release, so that'll complicate matters) However... This is because my ISP's DHCP server already has handed out a lease to my computer and this lease is still active. This active lease was obtained during the installation process, however, the installation process did not release the DCHP lease before it terminated the installation. Why hasn't this problem been reported before? Answer - most routers will just re-offer an active DHCP lease to the same MAC address that had originally obtained the lease. However, my ISP's DHCP servers will only re-offer an active leave when the requested ip-address matches the ip-address that was provided with the original lease. That must make life *really* entertaining for the ISP's support staff after an area-wide power outage. It also appears to be in contravention of a quick skim of RFC2131, since there's no requirement for clients to send a DHCPRELEASE. Section 4.4.6 states, Note that the correct operation of DHCP does not depend on the transmission of DHCPRELEASE messages. I wonder what other brokenness your ISP is hiding... - Matt -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110120014025.gt3...@hezmatt.org
Processed (with 2 errors): Re: Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Processing commands for cont...@bugs.debian.org:
clone 610553
Unknown command or malformed arguments to command.
reassign 610553 finish-install
Bug #610553 [installation-reports] installation-reports: does not cleanly
deconfigure network configured with DHCP
Bug reassigned from package 'installation-reports' to 'finish-install'.
reassign -1 di-utils-reboot
Failed to clear fixed versions and reopen on -1: The 'bug' parameter (-1) to
Debbugs::Control::set_package did not pass regex check
Debbugs::Control::set_package('transcript',
'IO::Scalar=GLOB(0x1e55230)', 'requester', 'Matthew Palmer
mpal...@debian.org', 'request_addr', 'cont...@bugs.debian.org',
'request_msgid', '20110120014025.gt3...@hezmatt.org', 'request_subject', ...)
called at /usr/lib/debbugs/service line 556
eval {...} called at /usr/lib/debbugs/service line 555
thanks
Stopping processing here.
Please contact me if you need assistance.
--
-1: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=-1
610553: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610553
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.129548768825917.transcr...@bugs.debian.org
Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
Quoting Matthew Palmer (mpal...@debian.org): clone 610553 reassign 610553 finish-install reassign -1 di-utils-reboot thanks On Wed, Jan 19, 2011 at 03:32:59PM -0500, Jeffrey Sheinberg wrote: Install of squeeze-rc1 (expert mode, non-graphical) from *.iso - works great except the network is not cleanly deconfigured for DHCP. Solution - please send SIGUSR2 to the udhcpc process at end of installation (menu items: finish up the installation, or abort the installation). That can probably be arranged. It covers two separate packages, so I'm going to clone out this report to get it fixed everywhere (finish-install for regular completion, and di-utils-reboot for Abort the installation). I'd say that the first bug should be dealt in netcfgwhich should provide the appropriate finish-install.d hook signature.asc Description: Digital signature
Bug#610553: installation-reports: does not cleanly deconfigure network configured with DHCP
On Thu, Jan 20, 2011 at 06:00:51AM +0100, Christian PERRIER wrote: Quoting Matthew Palmer (mpal...@debian.org): clone 610553 reassign 610553 finish-install reassign -1 di-utils-reboot thanks On Wed, Jan 19, 2011 at 03:32:59PM -0500, Jeffrey Sheinberg wrote: Install of squeeze-rc1 (expert mode, non-graphical) from *.iso - works great except the network is not cleanly deconfigured for DHCP. Solution - please send SIGUSR2 to the udhcpc process at end of installation (menu items: finish up the installation, or abort the installation). That can probably be arranged. It covers two separate packages, so I'm going to clone out this report to get it fixed everywhere (finish-install for regular completion, and di-utils-reboot for Abort the installation). I'd say that the first bug should be dealt in netcfgwhich should provide the appropriate finish-install.d hook Yeah, I thought about that, but it appears as though finish-install wants to own all those sorts of things itself. I would have expected 50config-target-network to be in netcfg, but it's not. On the other hand, if that's more of a historical screwup, moving it (and the currently-hypothetical release-dhcp-lease) to netcfg isn't something I'm philosophically opposed to). - Matt -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110120052420.gw3...@hezmatt.org
