Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
On Wed, Feb 06, 2013 at 04:59:04PM +0100, Michael Stapelberg wrote: > On Sun, 2 Dec 2012 23:47:37 + > Roger Leigh wrote: > > Please don't apply it just yet--we'll presumably need to get > > approval from the release team to change this in initscripts > > at the same time. I'll have a patch for initscripts shortly; > > might be a bit later in the week to allow for comprehensive > > testing. > What’s the status on this? It’s been 2 months :-). I did send a mail to -release a week or so back, but haven't seen a response yet. Doing the change in initscripts is fairly trivial, but introducing a configuration file change at this point is probably not a great idea. If it's needed, I'll be happy to do it though. While editing a conffile isn't a good idea in general, the actual impact here is very low, and it's limited to ARM users, so if the consensus is that it's ignorable for wheezy, I'll be equally happy to postpone this for jessie and we can do the needed changes early in the jessie release cycle. Bottom line: I'll be happy to do whatever is needed. Just need some feedback on what is acceptable here. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130206163445.ga21...@codelibre.net
Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
On Sun, 2 Dec 2012 23:47:37 + Roger Leigh wrote: > Please don't apply it just yet--we'll presumably need to get > approval from the release team to change this in initscripts > at the same time. I'll have a patch for initscripts shortly; > might be a bit later in the week to allow for comprehensive > testing. What’s the status on this? It’s been 2 months :-). Thanks! -- Best regards, Michael -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130206165904.77ef5...@midna.rag.lan
Re: Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
On Mon, Dec 03, 2012 at 01:20:50PM +, Ben Hutchings wrote: > On Mon, 2012-12-03 at 00:44 +, Roger Leigh wrote: > > On Sun, Dec 02, 2012 at 11:49:44PM +, Roger Leigh wrote: > > > On Sun, Dec 02, 2012 at 11:47:37PM +, Roger Leigh wrote: > > > > clone 694928 -1 > > > > reassign -1 initscripts > > > > thanks > > > > > > > > On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote: > > > > > > > > Please find attached an example patch for flash-kernel to > > > > support old and new (rcS and fsck) locations for FSCKFIX > > > > as discussed on #debian-devel earlier. > > > > > > Hmm, actually attached now. > > > > Slight update to cope with commented-out lines (as provided > > by default). > > This should really be the default for everyone... how many people know > their filesystem well enough to answer fsck prompts intelligently? I would personally be happy with it being set by default. However, the few times this has been brought up, there have been a number of examples where this might result in filesystem corruption. I think the main argument was that the admin might want to take an image before fsck ran, in case fsck caused further problems. I'd have to check, but IIRC other issues included checking parts of unreconstructed RAID arrays and/or LVM PVs, but I don't think this is very likely. I'd be tempted to enable it by default across the board, and require admins who want this extra safety to explicitly disable checking. The vast majority of users will benefit from this, since they can't intelligently answer the prompts as you say. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121203135743.gz14...@codelibre.net
Re: Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
On Mon, 2012-12-03 at 00:44 +, Roger Leigh wrote: > On Sun, Dec 02, 2012 at 11:49:44PM +, Roger Leigh wrote: > > On Sun, Dec 02, 2012 at 11:47:37PM +, Roger Leigh wrote: > > > clone 694928 -1 > > > reassign -1 initscripts > > > thanks > > > > > > On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote: > > > > > > Please find attached an example patch for flash-kernel to > > > support old and new (rcS and fsck) locations for FSCKFIX > > > as discussed on #debian-devel earlier. > > > > Hmm, actually attached now. > > Slight update to cope with commented-out lines (as provided > by default). This should really be the default for everyone... how many people know their filesystem well enough to answer fsck prompts intelligently? Ben. -- Ben Hutchings Always try to do things in chronological order; it's less confusing that way. signature.asc Description: This is a digitally signed message part
Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
On Sun, Dec 02, 2012 at 11:49:44PM +, Roger Leigh wrote: > On Sun, Dec 02, 2012 at 11:47:37PM +, Roger Leigh wrote: > > clone 694928 -1 > > reassign -1 initscripts > > thanks > > > > On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote: > > > > Please find attached an example patch for flash-kernel to > > support old and new (rcS and fsck) locations for FSCKFIX > > as discussed on #debian-devel earlier. > > Hmm, actually attached now. Slight update to cope with commented-out lines (as provided by default). -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 >From 4db3a50a7bd6b11f3a4fa425e5e2c9b7cf1c9673 Mon Sep 17 00:00:00 2001 From: Roger Leigh Date: Sun, 2 Dec 2012 23:34:57 + Subject: [PATCH] debian: Update /etc/default/fsck in flash-kernel-installer postinst --- debian/changelog | 10 ++ debian/flash-kernel-installer.postinst |7 ++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 68c673b..526f1ec 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +flash-kernel (3.4) UNRELEASED; urgency=low + + [ Roger Leigh ] + * flash-kernel-installer postinst: Update FSCKFIX in +/etc/default/fsck as well as /etc/default/rcS for backward +compatibility. The purpose is to use /etc/default/fsck for +new installations. + + -- Roger Leigh Sun, 02 Dec 2012 23:33:24 + + flash-kernel (3.3) unstable; urgency=low * Replace XC-Package-Type by Package-Type diff --git a/debian/flash-kernel-installer.postinst b/debian/flash-kernel-installer.postinst index c07dee5..e9b88c7 100755 --- a/debian/flash-kernel-installer.postinst +++ b/debian/flash-kernel-installer.postinst @@ -35,7 +35,12 @@ db_progress INFO flash-kernel-installer/prepare # Stop fsck from prompting the user for input since most users don't # have a serial console. -sed -i "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/rcS || true +if [ -e /target/etc/default/rcS ]; then + sed -i -e "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/rcS || true +fi +if [ -e /target/etc/default/fsck ]; then + sed -i -e "s/^#FSCKFIX=no$/FSCKFIX=yes/" -e "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/fsck || true +fi if ! apt-install flash-kernel; then error "apt-install flash-kernel failed" -- 1.7.10.4
Processed: Re: Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
Processing commands for cont...@bugs.debian.org: > clone 694928 -1 Bug #694928 [flash-kernel] flash-kernel: postinst modifies /etc/default/rcS Bug 694928 cloned as bug 694986 > reassign -1 initscripts Bug #694986 [flash-kernel] flash-kernel: postinst modifies /etc/default/rcS Bug reassigned from package 'flash-kernel' to 'initscripts'. No longer marked as found in versions flash-kernel/3.3. Ignoring request to alter fixed versions of bug #694986 to the same values previously set > thanks Stopping processing here. Please contact me if you need assistance. -- 694928: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=694928 694986: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=694986 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.13544920594988.transcr...@bugs.debian.org
Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
On Sun, Dec 02, 2012 at 11:47:37PM +, Roger Leigh wrote: > clone 694928 -1 > reassign -1 initscripts > thanks > > On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote: > > Please find attached an example patch for flash-kernel to > support old and new (rcS and fsck) locations for FSCKFIX > as discussed on #debian-devel earlier. Hmm, actually attached now. -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 >From 300eb0dcd6abc4ced0596f87a33d3165d46779e5 Mon Sep 17 00:00:00 2001 From: Roger Leigh Date: Sun, 2 Dec 2012 23:34:57 + Subject: [PATCH] debian: Update /etc/default/fsck in flash-kernel-installer postinst --- debian/changelog | 10 ++ debian/flash-kernel-installer.postinst |7 ++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 68c673b..526f1ec 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +flash-kernel (3.4) UNRELEASED; urgency=low + + [ Roger Leigh ] + * flash-kernel-installer postinst: Update FSCKFIX in +/etc/default/fsck as well as /etc/default/rcS for backward +compatibility. The purpose is to use /etc/default/fsck for +new installations. + + -- Roger Leigh Sun, 02 Dec 2012 23:33:24 + + flash-kernel (3.3) unstable; urgency=low * Replace XC-Package-Type by Package-Type diff --git a/debian/flash-kernel-installer.postinst b/debian/flash-kernel-installer.postinst index c07dee5..311615d 100755 --- a/debian/flash-kernel-installer.postinst +++ b/debian/flash-kernel-installer.postinst @@ -35,7 +35,12 @@ db_progress INFO flash-kernel-installer/prepare # Stop fsck from prompting the user for input since most users don't # have a serial console. -sed -i "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/rcS || true +if [ -e /target/etc/default/rcS ]; then + sed -i -e "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/rcS || true +fi +if [ -e /target/etc/default/fsck ]; then + sed -i -e "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/fsck || true +fi if ! apt-install flash-kernel; then error "apt-install flash-kernel failed" -- 1.7.10.4
Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change
clone 694928 -1 reassign -1 initscripts thanks On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote: Please find attached an example patch for flash-kernel to support old and new (rcS and fsck) locations for FSCKFIX as discussed on #debian-devel earlier. Please don't apply it just yet--we'll presumably need to get approval from the release team to change this in initscripts at the same time. I'll have a patch for initscripts shortly; might be a bit later in the week to allow for comprehensive testing. Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121202234737.gt14...@codelibre.net
