Bug#697675: debootstrap: please report package version-revision (patch)

[Hector Oron]

Hello,

On Mon, Jan 28, 2013 at 03:04:59AM +0100, Cyril Brulebois wrote:
> Hector Oron  (08/01/2013):
> > On Tue, Jan 08, 2013 at 11:02:19AM +0100, Hector Oron wrote:

> > >   When using debootstrap to create a given environment, it would
> > >   be nice to output version-revision information to keep track of
> > >   which software version components are installed.
 
> > Please review and consider following patch: […]
 
> looks like a nice idea, but a bit late for wheezy, so that might wait
> until the jessie release cycle.

As release has already happened, I'll go ahead and push the patch into 
debootstrap, unless someone complains loud.

Regards
-- 
  Hector Oron


signature.asc
Description: Digital signature

Bug#697675: debootstrap: please report package version-revision (patch)

[Cyril Brulebois]

Hi Hector,

Hector Oron  (08/01/2013):
> On Tue, Jan 08, 2013 at 11:02:19AM +0100, Hector Oron wrote:
> >   When using debootstrap to create a given environment, it would
> >   be nice to output version-revision information to keep track of
> >   which software version components are installed.
> 
> Please review and consider following patch: […]

looks like a nice idea, but a bit late for wheezy, so that might wait
until the jessie release cycle.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#697675: debootstrap: please report package version-revision (patch)

[Hector Oron]

On Tue, Jan 08, 2013 at 11:02:19AM +0100, Hector Oron wrote:
> Package: debootstrap
> Version: 1.0.44
> Severity: wishlist
 
>   When using debootstrap to create a given environment, it would be nice to 
> output version-revision information to keep track of which software version 
> components are installed.

Please review and consider following patch:


diff -Nru debootstrap-1.0.46/debian/changelog 
debootstrap-1.0.47/debian/changelog
--- debootstrap-1.0.46/debian/changelog 2012-12-27 15:51:54.0 +0100
+++ debootstrap-1.0.47/debian/changelog 2013-01-08 11:25:06.0 +0100
@@ -1,3 +1,10 @@
+debootstrap (1.0.47) UNRELEASED; urgency=low
+
+  * Report package version information on package retrieve and validation.
+Closes: #697675
+
+ -- Hector Oron   Tue, 08 Jan 2013 11:23:46 +0100
+
 debootstrap (1.0.46) unstable; urgency=low
 
   * Team upload.
diff -Nru debootstrap-1.0.46/functions debootstrap-1.0.47/functions
--- debootstrap-1.0.46/functions2012-12-27 15:36:47.0 +0100
+++ debootstrap-1.0.47/functions2013-01-08 11:23:38.0 +0100
@@ -276,8 +276,10 @@
# args: from dest 'nocache'
# args: from dest [checksum size] [alt {checksum size type}]
local displayname
+   local versionname
if [ "${2%.deb}" != "$2" ]; then
displayname="$(echo "$2" | sed 's,^.*/,,;s,_.*$,,')"
+   versionname="$(echo "$2" | sed 's,^.*/,,' | cut -d_ -f2)"
else
displayname="$(echo "$1" | sed 's,^.*/,,')"
fi
@@ -288,7 +290,7 @@
elif [ "$3" = nocache ]; then
rm -f "$2"
else
-   info VALIDATING "Validating %s" "$displayname"
+   info VALIDATING "Validating %s %s" "$displayname" 
"$versionname"
if verify_checksum "$2" "$3" "$4"; then
return 0
else
@@ -332,10 +334,10 @@
fi
 
while [ "$iters" -lt 10 ]; do
-   info RETRIEVING "Retrieving %s" "$displayname"
+   info RETRIEVING "Retrieving %s %s" "$displayname" 
"$versionname"
if ! just_get "$from" "$dest2"; then continue 2; fi
if [ "$checksum" != "" ]; then
-   info VALIDATING "Validating %s" "$displayname"
+   info VALIDATING "Validating %s %s" 
"$displayname" "$versionname"
if verify_checksum "$dest2" "$checksum" "$siz"; 
then
checksum=""
fi

-- 
  Hector Oron


signature.asc
Description: Digital signature