Bug#739006: Switch to mkdosfs instead of libparted
On Fri, Feb 14, 2014 at 03:49:56PM -0500, Phillip Susi wrote:
> diff -Nru partman-efi-39/commit.d/format_efi
> partman-efi-40/commit.d/format_efi
> --- partman-efi-39/commit.d/format_efi2012-09-20 10:45:15.0
> -0400
> +++ partman-efi-40/commit.d/format_efi2014-02-14 15:40:50.0
> -0500
> @@ -54,10 +54,13 @@
> db_subst $template PARTITION "$num"
> db_subst $template DEVICE $(humandev $(cat device))
> name_progress_bar $template
> - open_dialog CREATE_FILE_SYSTEM $id $new_efi_fs
> - read_line status
> - close_dialog
> - sync
> + if log-output -t partman --pass-stdout \
> + mkfs.vfat -F 32 $device >/dev/null; then
> + status=OK
> + else
> + status=failed
> + fi
> + db_progress STOP
>
> if [ "$status" != OK ]; then
> db_subst partman-basicfilesystems/create_failed
> TYPE efi
This has the same kind of problem I noted in #738922; you have
unbalanced db_progress calls, and you should probably drop the
now-useless name_progress_bar call and explicitly create a progress bar.
You've silently dropped a sync call, which seems an unwise thing to
bundle into this already fairly complex transition; I would suggest
keeping it at least in the case when mkfs.vfat returns successfully.
The top of format_efi selects fat32 or fat16 depending on the
architecture, but you ignore that here. I'd recommend using -F
"${new_efi_fs#fat}" instead of hardcoding 32.
> diff -Nru partman-efi-39/debian/changelog partman-efi-40/debian/changelog
> --- partman-efi-39/debian/changelog 2013-09-08 10:29:40.0 -0400
> +++ partman-efi-40/debian/changelog 2014-02-14 15:45:19.0 -0500
> @@ -1,3 +1,9 @@
> +partman-efi (40) unstable; urgency=low
> +
> + * Switch to using mkdosfs instead of libparted
> +
> + -- Phillip Susi Fri, 14 Feb 2014 15:44:22 -0500
> +
> partman-efi (39) unstable; urgency=low
>
>[ Updated translations ]
Just as general good practice, it's a good idea to submit changelog
patches with the distribution set to "UNRELEASED" rather than
"unstable"; we only set it to "unstable" when tagging and releasing. Or
you can even just supply the changelog entry separately without the
header/trailer lines and let the committer fill that in, to reduce the
probability of conflicts.
--
Colin Watson [cjwat...@debian.org]
--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140312134543.ga7...@riva.ucam.org
Bug#739006: Switch to mkdosfs instead of libparted
On Wed, Feb 19, 2014 at 10:48:19AM -0500, Phillip Susi wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >On 2/19/2014 10:14 AM, Steve McIntyre wrote: >> This *looks* sane enough to me, but I've not had a chance to test >> it directly yet. What testing have you done, please? > >None yet. I guess I could figure out how to get qemu to emulate an >efi system. On the other hand, it is a trivial change that is >identical to the patch I submitted for partman-basicfilesystems, and >that one I have tested. No problem. I'll try to find the time to test this myself - I've got a local qemu test config anyway. I was just wondering if you'd already done this, that's all. :-) -- Steve McIntyre, Cambridge, UK.st...@einval.com "When C++ is your hammer, everything looks like a thumb." -- Steven M. Haflich -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20140219155315.gg9...@einval.com
Bug#739006: Switch to mkdosfs instead of libparted
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/19/2014 10:14 AM, Steve McIntyre wrote: > This *looks* sane enough to me, but I've not had a chance to test > it directly yet. What testing have you done, please? None yet. I guess I could figure out how to get qemu to emulate an efi system. On the other hand, it is a trivial change that is identical to the patch I submitted for partman-basicfilesystems, and that one I have tested. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTBNJDAAoJEI5FoCIzSKrwOTwIAIUHh83eNBMxJx6JfYtlDc7W 7bLF3Rh8CaDkULn32vBYz+6ra/pgWfXEjh5LwiRVS+HlLwldfmXS5erP2hl0/DeQ jxWFbfHHhmab1rzH4kWw24Jr4kYQUe7QiEABRrweIkhWayeR+6sCzD35UStY6tl4 U4L3SNAWj5h54/78ofrUF+BPJ6ssDmPPDLi3PAPjkaWCJxYfAN/JpUzNTQR4Kqtb RtRk7SrBpi6CxkDZf5sWZ86p6vUBZGfUR3peWpSQurwKjdl/CVQj441sptqo4rwv C+Obuj3l05Caj15g8aGVLwppOARC3u8f/t2tkV9mTYn5V/kqZ0nzqP/H5IT8bvQ= =+RBr -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5304d243.5070...@ubuntu.com
Bug#739006: Switch to mkdosfs instead of libparted
Hi Phillip, On Fri, Feb 14, 2014 at 03:49:56PM -0500, Phillip Susi wrote: >Package: partman-efi >Tags: patch > >The attached patch switches partman-efi to use mkdosfs instead of >libparted to format the efi system partition, in preparation for the >parted3 transition. This *looks* sane enough to me, but I've not had a chance to test it directly yet. What testing have you done, please? -- Steve McIntyre, Cambridge, UK.st...@einval.com "Because heaters aren't purple!" -- Catherine Pitt -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20140219151417.gd9...@einval.com
Bug#739006: Switch to mkdosfs instead of libparted
Package: partman-efi
Tags: patch
The attached patch switches partman-efi to use mkdosfs instead of
libparted to format the efi system partition, in preparation for the
parted3 transition.
diff -Nru partman-efi-39/commit.d/format_efi partman-efi-40/commit.d/format_efi
--- partman-efi-39/commit.d/format_efi 2012-09-20 10:45:15.0 -0400
+++ partman-efi-40/commit.d/format_efi 2014-02-14 15:40:50.0 -0500
@@ -54,10 +54,13 @@
db_subst $template PARTITION "$num"
db_subst $template DEVICE $(humandev $(cat device))
name_progress_bar $template
- open_dialog CREATE_FILE_SYSTEM $id $new_efi_fs
- read_line status
- close_dialog
- sync
+ if log-output -t partman --pass-stdout \
+ mkfs.vfat -F 32 $device >/dev/null; then
+ status=OK
+ else
+ status=failed
+ fi
+ db_progress STOP
if [ "$status" != OK ]; then
db_subst partman-basicfilesystems/create_failed
TYPE efi
diff -Nru partman-efi-39/debian/changelog partman-efi-40/debian/changelog
--- partman-efi-39/debian/changelog 2013-09-08 10:29:40.0 -0400
+++ partman-efi-40/debian/changelog 2014-02-14 15:45:19.0 -0500
@@ -1,3 +1,9 @@
+partman-efi (40) unstable; urgency=low
+
+ * Switch to using mkdosfs instead of libparted
+
+ -- Phillip Susi Fri, 14 Feb 2014 15:44:22 -0500
+
partman-efi (39) unstable; urgency=low
[ Updated translations ]
diff -Nru partman-efi-39/debian/control partman-efi-40/debian/control
--- partman-efi-39/debian/control 2013-07-13 04:36:55.0 -0400
+++ partman-efi-40/debian/control 2014-02-14 15:46:30.0 -0500
@@ -10,5 +10,5 @@
Package: partman-efi
Package-Type: udeb
Architecture: i386 ia64 amd64
-Depends: partman-base (>= 114), efi-modules, ${misc:Depends}
+Depends: partman-base (>= 114), efi-modules, dosfstools-udeb, ${misc:Depends}
Description: Add to partman support for EFI boot partitions
signature.asc
Description: OpenPGP digital signature
