Bug#771576: tasksel: tasks=mate still also installs gnome
Christian PERRIER (2015-01-04): > Quoting Christian PERRIER (bubu...@debian.org): > > > That's what I was about to do (mails are coming one by one right now..:-)) > > Cyril and Samuel added. Thanks so much Christian, have a safe landing. ;) Mraw, KiBi. signature.asc Description: Digital signature
Bug#771576: tasksel: tasks=mate still also installs gnome
Quoting Christian PERRIER (bubu...@debian.org): > That's what I was about to do (mails are coming one by one right now..:-)) Cyril and Samuel added. -- signature.asc Description: Digital signature
Bug#771576: tasksel: tasks=mate still also installs gnome
Quoting Cyril Brulebois (k...@debian.org): > Samuel Thibault (2015-01-04): > > Cyril Brulebois, le Sun 04 Jan 2015 18:12:23 +0100, a écrit : > > > Samuel Thibault (2015-01-04): > > > > I believe this is a really important issue: all preseeded > > > > non-gnome-desktop-enabled-installations will be hit by this. > > > > > > I'm not sure why you're not pushing the patch you've tested. > > > > Simply because tasksel is not in d-i, I don't have commit rights there. > > Then mention that and get that fixed? > > Christian, can you please add Samuel to tasksel's alioth group, and > maybe add me as an extra admin if that makes sense to you? Thanks! That's what I was about to do (mails are coming one by one right now..:-)) signature.asc Description: Digital signature
Bug#771576: tasksel: tasks=mate still also installs gnome
Quoting Samuel Thibault (sthiba...@debian.org): > Cyril Brulebois, le Sun 04 Jan 2015 18:12:23 +0100, a écrit : > > Samuel Thibault (2015-01-04): > > > I believe this is a really important issue: all preseeded > > > non-gnome-desktop-enabled-installations will be hit by this. > > > > I'm not sure why you're not pushing the patch you've tested. > > Simply because tasksel is not in d-i, I don't have commit rights there. That's probably easy to solve..:-) I'm trying to add you to tasksel right now, through an airport Wifi *from the airplane*, which is kindaslooow. In case I didn't succeed now, I'll add you tomorrow morning. signature.asc Description: Digital signature
Bug#771576: tasksel: tasks=mate still also installs gnome
Samuel Thibault (2015-01-04): > Cyril Brulebois, le Sun 04 Jan 2015 18:12:23 +0100, a écrit : > > Samuel Thibault (2015-01-04): > > > I believe this is a really important issue: all preseeded > > > non-gnome-desktop-enabled-installations will be hit by this. > > > > I'm not sure why you're not pushing the patch you've tested. > > Simply because tasksel is not in d-i, I don't have commit rights there. Then mention that and get that fixed? Christian, can you please add Samuel to tasksel's alioth group, and maybe add me as an extra admin if that makes sense to you? Thanks! Mraw, KiBi. signature.asc Description: Digital signature
Bug#771576: tasksel: tasks=mate still also installs gnome
Cyril Brulebois, le Sun 04 Jan 2015 18:12:23 +0100, a écrit : > Samuel Thibault (2015-01-04): > > I believe this is a really important issue: all preseeded > > non-gnome-desktop-enabled-installations will be hit by this. > > I'm not sure why you're not pushing the patch you've tested. Simply because tasksel is not in d-i, I don't have commit rights there. Samuel -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150104171645.gy25...@type.youpi.perso.aquilenet.fr
Bug#771576: tasksel: tasks=mate still also installs gnome
Samuel Thibault (2015-01-04): > Hello, > > I believe this is a really important issue: all preseeded > non-gnome-desktop-enabled-installations will be hit by this. I'm not sure why you're not pushing the patch you've tested. Mraw, KiBi. signature.asc Description: Digital signature
Bug#771576: tasksel: tasks=mate still also installs gnome
Hello, I believe this is a really important issue: all preseeded non-gnome-desktop-enabled-installations will be hit by this. Samuel -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150104152223.gu25...@type.youpi.perso.aquilenet.fr
Bug#771576: tasksel: tasks=mate still also installs gnome
Control: tags -1 + patch
Hello,
Here is a tested patch.
Samuel
commit ada61ef5b9fb3c89e415c824837883fee87625b0
Author: Samuel Thibault
Date: Mon Dec 8 01:03:30 2014 +0100
When a desktop is preseeded, only enable that desktop.
diff --git a/debian/changelog b/debian/changelog
index 1abc6ed..cc59469 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,11 +1,15 @@
tasksel (3.30) UNRELEASED; urgency=medium
+ [ Joey Hess ]
* Remove pm-utils from laptop and desktop tasks. It was only added because
hal needed it, hal doesn't exist anymore, and systemctl is used for
command-line suspend/hibernate now.
* Remove libgl1-mesa-dri from the desktop task list. xorg depends on it,
so it does not need to be explicitly listed.
+ [ Samuel Thibault ]
+ * When a desktop is preseeded, only enable that desktop. Closes: #771576.
+
-- Joey Hess Thu, 30 Oct 2014 15:58:02 -0400
tasksel (3.29) unstable; urgency=high
diff --git a/tests/default-desktop b/tests/default-desktop
index 10d4a44..2b6a3b8 100755
--- a/tests/default-desktop
+++ b/tests/default-desktop
@@ -27,8 +27,10 @@ check_desktop_wanted() {
fi
}
-if db_get "tasksel/desktop" && echo "$RET" | grep -q "$DESKTOPNAME"; then
- check_desktop_wanted
+if db_get "tasksel/desktop"; then
+ if echo "$RET" | grep -q "$DESKTOPNAME"; then
+ check_desktop_wanted
+ fi
else
if [ "$DESKTOPNAME" = "$(default_desktop_for_arch $(dpkg
--print-architecture))" ]; then
check_desktop_wanted
Processed: Re: Bug#771576: tasksel: tasks=mate still also installs gnome
Processing control commands: > tags -1 + patch Bug #771576 [tasksel] tasksel: tasks=mate still also installs gnome Added tag(s) patch. -- 771576: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771576 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b771576.14179972449979.transcr...@bugs.debian.org
Bug#771576: tasksel: tasks=mate still also installs gnome
Package: tasksel Version: 3.29 Severity: important Hello, I wanted to make brltty and speakup auto-preseed tasks=mate so as to automatically install the most accessible desktop by default, but while doing so indeed enables installation of the mate desktop, the gnome desktop also gets installed: when using tasks=mate, both gnome and mate choices get ticked by default, and then the user session will default to the (lesser accessible) gnome desktop. Apparently this comes from the logic in the default-desktop script: if db_get "tasksel/desktop" && echo "$RET" | grep -q "$DESKTOPNAME"; then check_desktop_wanted else if [ "$DESKTOPNAME" = "$(default_desktop_for_arch $(dpkg --print-architecture))" ]; then check_desktop_wanted fi fi AIUI, this will make the gnome case skip the "then" part (since grep will fail), and since it's the default desktop for the amd64 arch, check_desktop_wanted will get called, and thus gnome always get ticked. Shouldn't it be rather the following? At least in my tests it works as I would expect: only tick the preseeded desktop choice. if db_get "tasksel/desktop" ; then if echo "$RET" | grep -q "$DESKTOPNAME"; then check_desktop_wanted fi else if [ "$DESKTOPNAME" = "$(default_desktop_for_arch $(dpkg --print-architecture))" ]; then check_desktop_wanted fi fi With some preseeding, the mate case will enter the first "then" and the second "then", and thus get ticked, while the gnome case will enter the first "then", but not the second "then". Without preseeding, all cases will enter the first "else", and then only the default desktop for the arch will enter the corresponding "then". Samuel -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17.0 (SMP w/8 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages tasksel depends on: ii apt 1.0.9.3 ii cdebconf [debconf-2.0] 0.192 ii debconf [debconf-2.0] 1.5.53 ii liblocale-gettext-perl 1.05-8+b1 ii perl-base 5.20.1-3 ii tasksel-data3.29 tasksel recommends no packages. tasksel suggests no packages. -- debconf information excluded -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141130202740.ga26...@type.youpi.perso.aquilenet.fr
