Bug#778617: grub-install often breaks in UEFI mode

2015-02-18 Thread Phillip Susi 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 2/17/2015 5:51 PM, Steve McIntyre wrote:
> On Tue, Feb 17, 2015 at 09:32:56AM -0500, Phillip Susi wrote:
>> Package: grub-installer Version: 1.110
>> 
>> I'm forwarding this patch from Ubuntu:
>> 
>> https://launchpad.net/bugs/1303790
>> 
>> On EFI, the boot disk argument given to grub-install is a dummy
>> and is often the wrong disk or a non existent disk.  Grub is
>> still installed to the correct place since it goes through the
>> filesystem to /boot/EFI, but the function make_active_partition
>> tries to look at the partition table on the dummy disk and throws
>> an error.  Hence, I wrote the attached patch to disable the
>> function on EFI.
> 
> Hi Phillip,
> 
> The logic looks ok, I guess, but I'd check more explicitly for 
> grub-efi-* instead of !grub-pc. There's several other
> architectures that may use grub, and I'm not sure if/how they may
> need special handling for active partitions...

Sounds good to me if you want to switch it when you apply the patch.


-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJU5KcwAAoJENRVrw2cjl5R48YH/isp8MR/2Ps4F0v7fzpxpgkb
Oe2e/s+ziB14mhKQ1dNHb8KcIeFfg60cCTSNw8kmb05Zk+v+GsaAHpKX0Dk62i5T
gy+9HXPlyUqZTzCe24mQnSAgSbrgm8B9OD0VRgr6fEzAbW2/+co9wI4l1NQHKifK
fPls70SKQBZyqZDpr4F0uBEBDfB16kOTJr8P+a9MEhdzkwxA0CyuQObwaIC5V0xd
DpQqmiE+g5v9zpJgBZDVV/c1t+mBAzSTnORg+/1J8qXf48yHOtA2Or0nJb/VxvBM
U6B32fsy7g+4hnZVq1U3Q+JlrNIB4BdyyEoatg68i2TnjS5b/aDXCVPBR0TpsoY=
=igUq
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/54e4a730.2060...@ubuntu.com

Bug#778617: grub-install often breaks in UEFI mode

2015-02-17 Thread Steve McIntyre 
On Tue, Feb 17, 2015 at 09:32:56AM -0500, Phillip Susi wrote:
>Package: grub-installer
>Version: 1.110
>
>I'm forwarding this patch from Ubuntu:
>
>https://launchpad.net/bugs/1303790
>
>On EFI, the boot disk argument given to grub-install is a dummy and is
>often the wrong disk or a non existent disk.  Grub is still installed to
>the correct place since it goes through the filesystem to /boot/EFI, but
>the function make_active_partition tries to look at the partition table
>on the dummy disk and throws an error.  Hence, I wrote the attached
>patch to disable the function on EFI.

Hi Phillip,

The logic looks ok, I guess, but I'd check more explicitly for
grub-efi-* instead of !grub-pc. There's several other architectures
that may use grub, and I'm not sure if/how they may need special
handling for active partitions...

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
  Armed with "Valor": "Centurion" represents quality of Discipline,
  Honor, Integrity and Loyalty. Now you don't have to be a Caesar to
  concord the digital world while feeling safe and proud.


-- 
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150217225131.gf5...@einval.com

Bug#778617: grub-install often breaks in UEFI mode

2015-02-17 Thread Phillip Susi 
Package: grub-installer
Version: 1.110

I'm forwarding this patch from Ubuntu:

https://launchpad.net/bugs/1303790

On EFI, the boot disk argument given to grub-install is a dummy and is
often the wrong disk or a non existent disk.  Grub is still installed to
the correct place since it goes through the filesystem to /boot/EFI, but
the function make_active_partition tries to look at the partition table
on the dummy disk and throws an error.  Hence, I wrote the attached
patch to disable the function on EFI.


revno: 121
committer: Phillip Susi 
branch nick: grub-installer
timestamp: Tue 2015-02-17 09:15:44 -0500
message:
  Don't try to mark a partition as active, except on grub-pc.
  This was causing failures for grub-efi (LP: #1303790).
diff:
=== modified file 'debian/changelog'
--- debian/changelog2014-10-06 18:29:15 +
+++ debian/changelog2015-02-17 14:15:44 +
@@ -1,3 +1,10 @@
+grub-installer (1.78ubuntu24) vivid; urgency=medium
+
+  * Don't try to mark a partition as active, except on grub-pc.
+This was causing failures for grub-efi (LP: #1303790).
+
+ -- Phillip Susi   Tue, 27 Jan 2015 15:51:09 -0500
+
 grub-installer (1.78ubuntu23) utopic; urgency=medium
 
   * On ppc64el, wipe the PReP partition before installing grub-ieee1275,

=== modified file 'grub-installer'
--- grub-installer  2014-10-06 18:29:15 +
+++ grub-installer  2015-02-17 14:15:44 +
@@ -1006,6 +1006,12 @@
 }
 
 make_active_partition () {
+   if [ "$grub_package" != "grub-pc" ]; then
+   # only do this for grub-pc since on EFI $bootdev is a dummy argument
+   # and looking for a partition table on the wrong or non existing disk
+   # crashes the installer LP:#1303790
+   return
+   fi
bootdisk=
bootpart=
case $bootdev in


signature.asc
Description: OpenPGP digital signature