Bug#798562: debootstrap: Support "scripts" sharing code with Debian but with different default_mirror and keyring

[Hideki Yamane]

On Sat, 24 Feb 2018 21:11:53 +0100
Raphael Hertzog  wrote:
> >  I've made a PoC patch for this issue
> >  - relocate scripts files to each distro directroy
> 
> I think this is not a good idea. The location of the scripts file is part
> of the public interface since debootstrap takes a script file
> as 4th parameter.

 It is only in source package, all scripts files are put into same
 /usr/share/debootstrap/scripts directory. It'd be nice to add another
 distro to add scripts directory in the future. Not necessary but nice,
 IMO.


> Or maybe it's a good idea because we are going to have collisions one day
> between codenames of the various distributions but then you have to keep
> the current files for a little longer and you probably should consider
> further changes so that we can pass "debian/sid" or "kali/kali-rolling"
> as 1st parameter (suite).

 It would break current usage of debootstrap, so I would like to avoid it.


> But this is also not required to implement this:
> 
> >  - split code from scripts/debian/sid
> 
> This part looks fine from a cursory review.

 Thanks, it is also good for archived Debian releases like squeeze.


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Bug#798562: debootstrap: Support "scripts" sharing code with Debian but with different default_mirror and keyring

[Raphael Hertzog]

Hi,

On Sat, 24 Feb 2018, Hideki Yamane wrote:
> On Thu, 10 Sep 2015 16:22:25 +0200 =?utf-8?q?Rapha=C3=ABl_Hertzog?= 
>  wrote:
> > It might be possible to just move the code out in some separate
> > files that can be sourced from all the "script" files?
> 
>  I've made a PoC patch for this issue
>  - relocate scripts files to each distro directroy

I think this is not a good idea. The location of the scripts file is part
of the public interface since debootstrap takes a script file
as 4th parameter.

Or maybe it's a good idea because we are going to have collisions one day
between codenames of the various distributions but then you have to keep
the current files for a little longer and you probably should consider
further changes so that we can pass "debian/sid" or "kali/kali-rolling"
as 1st parameter (suite).

But this is also not required to implement this:

>  - split code from scripts/debian/sid

This part looks fine from a cursory review.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#798562: debootstrap: Support "scripts" sharing code with Debian but with different default_mirror and keyring

[Raphaël Hertzog]

Package: debootstrap
Version: 1.0.72
Severity: wishlist
User: de...@kali.org
Usertags: origin-kali

I would like to add a /u/s/debootstrap/scripts/kali file that behaves
exactly like Debian's one except that it would have different
meta-information at the top... in particular default_mirror and
keyring.

But the code to bootstrap the distribution is exactly the same
and I would like it to be shared with Debian (so that we get
fixes and improvements too). I don't think there's a way to achieve
this right now.

It might be possible to just move the code out in some separate
files that can be sourced from all the "script" files?

Cheers,
  Raphaël.