Re: Bug#861729: unblock: win32-loader/0.8.3
Didier 'OdyX' Raboud (2017-05-04):
> Le mercredi, 3 mai 2017, 11.54:16 h CEST Cyril Brulebois a écrit :
> > A couple of things (feel free to follow up only to debian-boot and me):
> > - debian/files is left over after building a source package; while I
> >know mostly nothing about dpkg-genbuildinfo, it feels a bit weird
> >compared to all other d-i packages which leave a clean git tree after
> >a source build;
>
> This seems like a bug in dpkg-genbuildinfo to me, as I'm not doing anything
> spethial in win32-loader with regards to this. I noticed this 'debian/files'
> leftover in plenty of my packages, but didn't find time to properly
> investigate.
This might be, yeah. If it's really needed to create the source package,
I think it'd be fair to get rid of it afterwards…
> > - does it make sense to force bzip2 for the source tarball? It dates
> >back to 2011, so was probably an improvement over gz, but now that we
> >have xz, just using that would probably make sense?
>
> Oh yes, absolutely. Is it a change we want in stretch?
I have no idea whether this could affect by-hand processing (I can't
see why but I occasionally lack some imagination), but using standard
compression everywhere would look reasonable to me;
(All I see in dak.git is scripts/debian/byhand-win32-loader with a
check on win32-loader_*.{exe,txt})
KiBi.
signature.asc
Description: Digital signature
Re: Bug#861729: unblock: win32-loader/0.8.3
(Dropping the bug, only writing to d-boot) Le mercredi, 3 mai 2017, 11.54:16 h CEST Cyril Brulebois a écrit : > A couple of things (feel free to follow up only to debian-boot and me): > - debian/files is left over after building a source package; while I >know mostly nothing about dpkg-genbuildinfo, it feels a bit weird >compared to all other d-i packages which leave a clean git tree after >a source build; This seems like a bug in dpkg-genbuildinfo to me, as I'm not doing anything spethial in win32-loader with regards to this. I noticed this 'debian/files' leftover in plenty of my packages, but didn't find time to properly investigate. > - does it make sense to force bzip2 for the source tarball? It dates >back to 2011, so was probably an improvement over gz, but now that we >have xz, just using that would probably make sense? Oh yes, absolutely. Is it a change we want in stretch? Cheers, OdyX signature.asc Description: This is a digitally signed message part.
Re: Bug#861729: unblock: win32-loader/0.8.3
Didier 'OdyX' Raboud (2017-05-03): > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock :) > Please unblock-udeb package win32-loader 0.8.3 as it fixes an FTBFS on > i386 in stretch (and is always blocked because of the manual migration > to be done by ftpmasters): > > > * Fix FTBFS on i386: use gawk to prepare README file (Closes: #860695) > > (This is a bug in mawk, reported as #860751) Thanks for filing it. > debdiff is attached. > > ftpmaster: please copy debian/tools/win32-loader/unstable into …/testing > > unblock-udeb win32-loader/0.8.3 No objections. A couple of things (feel free to follow up only to debian-boot and me): - debian/files is left over after building a source package; while I know mostly nothing about dpkg-genbuildinfo, it feels a bit weird compared to all other d-i packages which leave a clean git tree after a source build; - does it make sense to force bzip2 for the source tarball? It dates back to 2011, so was probably an improvement over gz, but now that we have xz, just using that would probably make sense? KiBi. signature.asc Description: Digital signature
Bug#861729: unblock: win32-loader/0.8.3
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock-udeb package win32-loader 0.8.3 as it fixes an FTBFS
on i386 in stretch (and is always blocked because of the manual migration to
be done by ftpmasters):
> * Fix FTBFS on i386: use gawk to prepare README file (Closes: #860695)
(This is a bug in mawk, reported as #860751)
debdiff is attached.
ftpmaster: please copy debian/tools/win32-loader/unstable into …/testing
unblock-udeb win32-loader/0.8.3
Cheers, OdyX
diff -Nru win32-loader-0.8.2/debian/changelog
win32-loader-0.8.3/debian/changelog
--- win32-loader-0.8.2/debian/changelog 2017-03-20 21:23:59.0 +0100
+++ win32-loader-0.8.3/debian/changelog 2017-04-19 18:03:11.0 +0200
@@ -1,3 +1,11 @@
+win32-loader (0.8.3) unstable; urgency=low
+
+ * The « Pippita » release
+
+ * Fix FTBFS on i386: use gawk to prepare README file (Closes: #860695)
+
+ -- Didier Raboud Wed, 19 Apr 2017 18:03:11 +0200
+
win32-loader (0.8.2) unstable; urgency=medium
* The « Iao » release
diff -Nru win32-loader-0.8.2/debian/control win32-loader-0.8.3/debian/control
--- win32-loader-0.8.2/debian/control 2017-03-20 21:12:00.0 +0100
+++ win32-loader-0.8.3/debian/control 2017-04-19 18:03:11.0 +0200
@@ -10,6 +10,7 @@
mingw-w64,
libgcrypt-mingw-w64-dev, libgpg-error-mingw-w64-dev,
librsvg2-bin, icoutils,
+ gawk,
gettext,
grub-pc-bin (>= 1.99~rc1-3),
imagemagick,
diff -Nru win32-loader-0.8.2/debian/rules win32-loader-0.8.3/debian/rules
--- win32-loader-0.8.2/debian/rules 2017-03-20 21:10:08.0 +0100
+++ win32-loader-0.8.3/debian/rules 2017-04-19 18:03:11.0 +0200
@@ -39,9 +39,9 @@
dh_auto_build
# Prepare the README file
- awk '{sub(/@PACKAGES_LIST@/,"$(PACKAGES_LIST)")}1 \
- {sub(/@NSIS_VERSION@/,"$(NSIS_VERSION)")}1 \
- {sub(/@W32_VERSION@/,"$(W32_VERSION)")}1' \
+ gawk '{sub(/@PACKAGES_LIST@/,"$(PACKAGES_LIST)")}1 \
+ {sub(/@NSIS_VERSION@/,"$(NSIS_VERSION)")}1 \
+ {sub(/@W32_VERSION@/,"$(W32_VERSION)")}1' \
debian/win32-loader_doc.txt > $(W32_BYHAND_NAME).txt
cat debian/copyright >> $(W32_BYHAND_NAME).txt
endif
