Re: Bug#872598: udev-udeb: no input in graphical installer

[Raphael Hertzog]

Hi,

On Thu, 24 Aug 2017, Cyril Brulebois wrote:
> > The attached patch seems to do the trick, will upload after a full build
> > inside sbuild, then open a bug report as you suggested on IRC, so that
> > you think about reverting this when the gcc-7 bug is fixed.
> 
> I initially meant to add g++ and CXX and should have, but it seemed
> not to be needed… until it failed on buildds since there are checks
> building in c++ mode; which I didn't catch locally because the wrong
> chroot has been used while build testing… Sorry for that.

I had a similar problem for shiboken and Adrian Bunk pointed out on
#debian-mips that this also works around the failure:
DEB_CXXFLAGS_MAINT_APPEND = -mno-lra
DEB_CFLAGS_MAINT_APPEND = -mno-lra

Apparently that's the broken feature in gcc-7 on mips64el.

For the record, when updating systemd, I also had other tests failures on
armel in Kali due to test-hash failing... but that test is skipped in
Debian due to the kernel not supporting the feature apparently. But with a
kernel provided by my hosting provider (scaleway.com), it did fail. I
built my package somewhere else to work around this.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Re: Bug#872598: udev-udeb: no input in graphical installer

[Cyril Brulebois]

.oO( Third time is the charm? )

Cyril Brulebois  (2017-08-24):
> Michael Biebl  (2017-08-24):
> > Am 23.08.2017 um 23:57 schrieb Cyril Brulebois:
> > 
> > > My NMU FTBFSes on mips64el:
> > >   
> > > https://buildd.debian.org/status/fetch.php?pkg=systemd=mips64el=234-2.1=1503523165=0
> > > 
> > > James Cowgill mentioned this gcc bug report:
> > >   https://bugs.debian.org/871514
> > > 
> > > so I think I might duplicate the rules file in src:debian-installer and
> > > work around the missing file by putting it into place manually, which is
> > > somewhat ugly but means we're no longer blocking on the systemd update.
> > 
> > I wouldn't mind if you forced the compiler to be GCC 6 in src:systemd
> > until this bug is fixed.
> 
> The attached patch seems to do the trick, will upload after a full build
> inside sbuild, then open a bug report as you suggested on IRC, so that
> you think about reverting this when the gcc-7 bug is fixed.

I initially meant to add g++ and CXX and should have, but it seemed
not to be needed… until it failed on buildds since there are checks
building in c++ mode; which I didn't catch locally because the wrong
chroot has been used while build testing… Sorry for that.

Hopefully attaching the last debdiff…


KiBi.
diff -Nru systemd-234/debian/changelog systemd-234/debian/changelog
--- systemd-234/debian/changelog	2017-08-24 00:53:09.0 +0200
+++ systemd-234/debian/changelog	2017-08-24 02:45:13.0 +0200
@@ -1,3 +1,12 @@
+systemd (234-2.3) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Also switch to g++-6 temporarily (needed for some tests):
+- Add g++-6 to Build-Depends
+- Export CXX = g++-6
+
+ -- Cyril Brulebois   Thu, 24 Aug 2017 02:40:53 +0200
+
 systemd (234-2.2) unstable; urgency=high
 
   * Non-maintainer upload.
diff -Nru systemd-234/debian/control systemd-234/debian/control
--- systemd-234/debian/control	2017-08-24 00:45:38.0 +0200
+++ systemd-234/debian/control	2017-08-24 02:27:16.0 +0200
@@ -54,6 +54,7 @@
libcap2-bin ,
iproute2 ,
gcc-6,
+   g++-6,
 
 Package: systemd
 Architecture: linux-any
diff -Nru systemd-234/debian/rules systemd-234/debian/rules
--- systemd-234/debian/rules	2017-08-24 00:45:44.0 +0200
+++ systemd-234/debian/rules	2017-08-24 02:28:10.0 +0200
@@ -5,6 +5,7 @@
 
 export LC_ALL = C.UTF-8
 export CC = gcc-6
+export CXX = g++-6
 
 include /usr/share/dpkg/default.mk
 


signature.asc
Description: Digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Cyril Brulebois]

Michael Biebl  (2017-08-24):
> Am 23.08.2017 um 23:57 schrieb Cyril Brulebois:
> 
> > My NMU FTBFSes on mips64el:
> >   
> > https://buildd.debian.org/status/fetch.php?pkg=systemd=mips64el=234-2.1=1503523165=0
> > 
> > James Cowgill mentioned this gcc bug report:
> >   https://bugs.debian.org/871514
> > 
> > so I think I might duplicate the rules file in src:debian-installer and
> > work around the missing file by putting it into place manually, which is
> > somewhat ugly but means we're no longer blocking on the systemd update.
> 
> I wouldn't mind if you forced the compiler to be GCC 6 in src:systemd
> until this bug is fixed.

The attached patch seems to do the trick, will upload after a full build
inside sbuild, then open a bug report as you suggested on IRC, so that
you think about reverting this when the gcc-7 bug is fixed.


KiBi.
diff -Nru systemd-234/debian/changelog systemd-234/debian/changelog
--- systemd-234/debian/changelog	2017-08-23 18:41:34.0 +
+++ systemd-234/debian/changelog	2017-08-23 22:53:09.0 +
@@ -1,3 +1,13 @@
+systemd (234-2.2) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Switch to gcc-6 on all architectures, working around an FTBFS on mips64el,
+apparently due to a gcc-7 bug (See: #871514):
+- Add gcc-6 to Build-Depends in debian/control
+- Export CC = gcc-6 in debian/rules
+
+ -- Cyril Brulebois   Wed, 23 Aug 2017 22:53:09 +
+
 systemd (234-2.1) unstable; urgency=high
 
   * Non-maintainer upload.
diff -Nru systemd-234/debian/control systemd-234/debian/control
--- systemd-234/debian/control	2017-07-20 13:13:42.0 +
+++ systemd-234/debian/control	2017-08-23 22:45:38.0 +
@@ -53,6 +53,7 @@
tzdata ,
libcap2-bin ,
iproute2 ,
+   gcc-6,
 
 Package: systemd
 Architecture: linux-any
diff -Nru systemd-234/debian/rules systemd-234/debian/rules
--- systemd-234/debian/rules	2017-07-20 13:13:42.0 +
+++ systemd-234/debian/rules	2017-08-23 22:45:44.0 +
@@ -4,6 +4,7 @@
 #export DEB_BUILD_OPTIONS = nostrip
 
 export LC_ALL = C.UTF-8
+export CC = gcc-6
 
 include /usr/share/dpkg/default.mk
 


signature.asc
Description: Digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Michael Biebl]

Am 23.08.2017 um 23:57 schrieb Cyril Brulebois:

> My NMU FTBFSes on mips64el:
>   
> https://buildd.debian.org/status/fetch.php?pkg=systemd=mips64el=234-2.1=1503523165=0
> 
> James Cowgill mentioned this gcc bug report:
>   https://bugs.debian.org/871514
> 
> so I think I might duplicate the rules file in src:debian-installer and
> work around the missing file by putting it into place manually, which is
> somewhat ugly but means we're no longer blocking on the systemd update.

I wouldn't mind if you forced the compiler to be GCC 6 in src:systemd
until this bug is fixed.

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Cyril Brulebois]

Hi,

Cyril Brulebois  (2017-08-23):
> Michael Biebl  (2017-08-23):
> > Am 23.08.2017 um 10:08 schrieb Cyril Brulebois:
> > > Would you be OK with a minimal NMU to fix the missing file? This issue has
> > > been blocking the D-I Buster Alpha 1 release for weeks already (even if it
> > > hadn't been diagnosed and reported against udev-udeb until recently), and
> > > I'd be happy to get a release out the door ASAP, since I won't have much
> > > time in the following weeks.
> > 
> > Felipe has already looked into this issue a bit and discovered more
> > inconsistencies between the deb and udeb build for udev. This will
> > probably need some more time to review/investigate properly, so feel
> > free to go ahead with the NMU!
> 
> Thanks!
> 
> Attached is the NMU diff.

My NMU FTBFSes on mips64el:
  
https://buildd.debian.org/status/fetch.php?pkg=systemd=mips64el=234-2.1=1503523165=0

James Cowgill mentioned this gcc bug report:
  https://bugs.debian.org/871514

so I think I might duplicate the rules file in src:debian-installer and
work around the missing file by putting it into place manually, which is
somewhat ugly but means we're no longer blocking on the systemd update.


KiBi.


signature.asc
Description: Digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Cyril Brulebois]

Control: tag -1 patch pending

Michael Biebl  (2017-08-23):
> Am 23.08.2017 um 10:08 schrieb Cyril Brulebois:
> > Would you be OK with a minimal NMU to fix the missing file? This issue has
> > been blocking the D-I Buster Alpha 1 release for weeks already (even if it
> > hadn't been diagnosed and reported against udev-udeb until recently), and
> > I'd be happy to get a release out the door ASAP, since I won't have much
> > time in the following weeks.
> 
> Felipe has already looked into this issue a bit and discovered more
> inconsistencies between the deb and udeb build for udev. This will
> probably need some more time to review/investigate properly, so feel
> free to go ahead with the NMU!

Thanks!

Attached is the NMU diff.


KiBi.
diff -Nru systemd-234/debian/changelog systemd-234/debian/changelog
--- systemd-234/debian/changelog	2017-07-20 15:13:42.0 +0200
+++ systemd-234/debian/changelog	2017-08-23 20:41:34.0 +0200
@@ -1,3 +1,12 @@
+systemd (234-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Fix missing 60-input-id.rules in udev-udeb, which breaks the graphical
+version of the Debian Installer, as no key presses or mouse events get
+processed (Closes: #872598).
+
+ -- Cyril Brulebois   Wed, 23 Aug 2017 20:41:33 +0200
+
 systemd (234-2) unstable; urgency=medium
 
   [ Martin Pitt ]
diff -Nru systemd-234/debian/udev-udeb.install systemd-234/debian/udev-udeb.install
--- systemd-234/debian/udev-udeb.install	2017-07-20 15:13:42.0 +0200
+++ systemd-234/debian/udev-udeb.install	2017-08-23 20:41:25.0 +0200
@@ -6,6 +6,7 @@
 lib/udev/cdrom_id
 lib/udev/rules.d/50-udev-default.rules
 lib/udev/rules.d/60-cdrom_id.rules
+lib/udev/rules.d/60-input-id.rules
 lib/udev/rules.d/60-persistent-input.rules
 lib/udev/rules.d/60-persistent-storage.rules
 lib/udev/rules.d/64-btrfs.rules


signature.asc
Description: Digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Michael Biebl]

Hi KiBi

Am 23.08.2017 um 10:08 schrieb Cyril Brulebois:
> Would you be OK with a minimal NMU to fix the missing file? This issue has
> been blocking the D-I Buster Alpha 1 release for weeks already (even if it
> hadn't been diagnosed and reported against udev-udeb until recently), and
> I'd be happy to get a release out the door ASAP, since I won't have much
> time in the following weeks.

Felipe has already looked into this issue a bit and discovered more
inconsistencies between the deb and udeb build for udev. This will
probably need some more time to review/investigate properly, so feel
free to go ahead with the NMU!

Regards,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Cyril Brulebois]

Hi,

Michael Biebl  (2017-08-19):
> Am 19.08.2017 um 14:38 schrieb Cyril Brulebois:
> 
> > A timely fix would be appreciated, the breakage(s) in the graphical
> > installer prevented us from releasing debian-installer over the past few
> > weeks, and it would be great not to wait too long before we're able to do
> > so, esp. with linux 4.12.6-1 having reached testing lately.
> 
> I might have time for that mid next week.

Would you be OK with a minimal NMU to fix the missing file? This issue has
been blocking the D-I Buster Alpha 1 release for weeks already (even if it
hadn't been diagnosed and reported against udev-udeb until recently), and
I'd be happy to get a release out the door ASAP, since I won't have much
time in the following weeks.


KiBi.


signature.asc
Description: Digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Felipe Sateler]

On Sat, Aug 19, 2017 at 9:38 AM, Cyril Brulebois  wrote:
> Control: tag -1 patch
>
> Hi,
>
> (Again, please keep debian-boot@ in copy.)
>
> Raphael Hertzog  (2017-08-19):
>> > I've only quickly glanced at the contents of both packages, and
>> > debdiff mentions no obvious issues (file lists are the same).
>>
>> I believe this is precisely the problem. The new udev-udeb should
>> include a new file:
>> diff --git a/debian/udev-udeb.install b/debian/udev-udeb.install
>> index 6a8e2108f..6758fef06 100644
>> --- a/debian/udev-udeb.install
>> +++ b/debian/udev-udeb.install
>> @@ -5,6 +5,7 @@ lib/udev/ata_id
>>  lib/udev/scsi_id
>>  lib/udev/cdrom_id
>>  lib/udev/rules.d/50-udev-default.rules
>> +lib/udev/rules.d/60-input-id.rules
>>  lib/udev/rules.d/60-cdrom_id.rules
>>  lib/udev/rules.d/60-persistent-input.rules
>>  lib/udev/rules.d/60-persistent-storage.rules
>>
>> I won't have the time to test this now but I believe it's the problem.
>
> That's absolutely correct. I've started by copying the file manually into
> the netboot-gtk mini.iso, and confirmed the fix. To be extra sure, I've
> rebuilt a systemd package with your change, and used the new udev udebs
> for a clean build, and that works as well.
>
> A timely fix would be appreciated, the breakage(s) in the graphical
> installer prevented us from releasing debian-installer over the past few
> weeks, and it would be great not to wait too long before we're able to do
> so, esp. with linux 4.12.6-1 having reached testing lately.
>
> Thinking about this, I'll check with debian-release@ and I might just
> freeze all udeb-producing packages right away. Winter has come.
>
>
>> It would be nice to have a fixed udev soon. Thank you Cyril for the
>> investigation!
>>
>> I wonder if it would be possible to have autopkgtest tests covering
>> udev-udeb...
>
> I'm still new to the whole autopkgtest thing, but from where I stand, the
> fact d-i is broken has been known for quite a while; the core issue is
> that nobody investigated this before I found some time. An easy way to be
> more proactive on the systemd side would be to make sure that new (and/or
> deleted) files in the udev and libudev1 binaries are detected by
> maintainers (esp. since udev.install uses wildcards for rules files, while
> udev-udeb.rules uses a static list), so that the update can be propagated
> to the udebs if relevant.

--fail-missing is broken on the udeb builds at the moment, so it is
not enabled. I'll try to fix this and enable it. This should help
catch these sort of issues in the future.

-- 

Saludos,
Felipe Sateler

Re: Bug#872598: udev-udeb: no input in graphical installer

[Michael Biebl]

Am 19.08.2017 um 14:38 schrieb Cyril Brulebois:

> A timely fix would be appreciated, the breakage(s) in the graphical
> installer prevented us from releasing debian-installer over the past few
> weeks, and it would be great not to wait too long before we're able to do
> so, esp. with linux 4.12.6-1 having reached testing lately.

I might have time for that mid next week.

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Cyril Brulebois]

Control: tag -1 patch

Hi,

(Again, please keep debian-boot@ in copy.)

Raphael Hertzog  (2017-08-19):
> > I've only quickly glanced at the contents of both packages, and
> > debdiff mentions no obvious issues (file lists are the same).
> 
> I believe this is precisely the problem. The new udev-udeb should
> include a new file:
> diff --git a/debian/udev-udeb.install b/debian/udev-udeb.install
> index 6a8e2108f..6758fef06 100644
> --- a/debian/udev-udeb.install
> +++ b/debian/udev-udeb.install
> @@ -5,6 +5,7 @@ lib/udev/ata_id
>  lib/udev/scsi_id
>  lib/udev/cdrom_id
>  lib/udev/rules.d/50-udev-default.rules
> +lib/udev/rules.d/60-input-id.rules
>  lib/udev/rules.d/60-cdrom_id.rules
>  lib/udev/rules.d/60-persistent-input.rules
>  lib/udev/rules.d/60-persistent-storage.rules
> 
> I won't have the time to test this now but I believe it's the problem.

That's absolutely correct. I've started by copying the file manually into
the netboot-gtk mini.iso, and confirmed the fix. To be extra sure, I've
rebuilt a systemd package with your change, and used the new udev udebs
for a clean build, and that works as well.

A timely fix would be appreciated, the breakage(s) in the graphical
installer prevented us from releasing debian-installer over the past few
weeks, and it would be great not to wait too long before we're able to do
so, esp. with linux 4.12.6-1 having reached testing lately.

Thinking about this, I'll check with debian-release@ and I might just
freeze all udeb-producing packages right away. Winter has come.


> It would be nice to have a fixed udev soon. Thank you Cyril for the
> investigation!
> 
> I wonder if it would be possible to have autopkgtest tests covering
> udev-udeb...

I'm still new to the whole autopkgtest thing, but from where I stand, the
fact d-i is broken has been known for quite a while; the core issue is
that nobody investigated this before I found some time. An easy way to be
more proactive on the systemd side would be to make sure that new (and/or
deleted) files in the udev and libudev1 binaries are detected by
maintainers (esp. since udev.install uses wildcards for rules files, while
udev-udeb.rules uses a static list), so that the update can be propagated
to the udebs if relevant.

I'm fine with setting up a check through a cron job on d-i.debian.org so
as to avoid putting the burden on systemd maintainers. The feedback loop
might take a few hours/days after an upload with such a change, but that
would make it obvious that something “important” changed, and would speed
up understanding such regressions.


KiBi.


signature.asc
Description: Digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Michael Biebl]

Am 19.08.2017 um 10:14 schrieb Raphael Hertzog:

> I wonder if it would be possible to have autopkgtest tests covering
> udev-udeb...

We'd be happy to ship such an autopkgtest. Help in that regard would be
much appreciated.

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Michael Biebl]

Am 19.08.2017 um 10:19 schrieb Michael Biebl:
> Am 19.08.2017 um 04:59 schrieb Cyril Brulebois:
>>
>> I haven't looked into the changelog and actual changes (yet), but I'd be
>> happy to get some input (no pun intended) from systemd maintainers.
>>
> 
> Maybe this is related:
> https://github.com/systemd/systemd/commit/43af16c99c800afdfc4b6913ea7596aaddd0395d
> 
> I.e., could you apply this upstream patch, make sure the udev rule is in
> the udeb and try again?

Urgh, I missed that this patch is already part of v234, sorry for the
confusion.
So all that's missing seems to be the installation in the udev-udeb.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Re: Bug#872598: udev-udeb: no input in graphical installer

[Michael Biebl]

Am 19.08.2017 um 04:59 schrieb Cyril Brulebois:
> 
> I haven't looked into the changelog and actual changes (yet), but I'd be
> happy to get some input (no pun intended) from systemd maintainers.
> 

Maybe this is related:
https://github.com/systemd/systemd/commit/43af16c99c800afdfc4b6913ea7596aaddd0395d

I.e., could you apply this upstream patch, make sure the udev rule is in
the udeb and try again?

If that doesn't help, we will need log files to debug this further.
A Xorg log from a working/non-working installer would be a start.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature