Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Hideki Yamane]

On Sun, 3 Mar 2019 17:20:30 +0100
Cyril Brulebois  wrote:
> I'd rather avoid testing more things at this stage.

 ;-(

 Okay, when the window will be opened for it, then? I'm curious.


-- 
Hideki Yamane 

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Cyril Brulebois]

Hi,

Hideki Yamane  (2019-03-03):
> On Sat, 16 Feb 2019 20:30:00 +0900
> Hideki Yamane  wrote:
> >  Sorry for the delay, I've made and tested new patch for it as
> >  https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2
> 
>  Can someone review it? > -boot

I'd rather avoid testing more things at this stage.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Hideki Yamane]

On Sat, 16 Feb 2019 20:30:00 +0900
Hideki Yamane  wrote:
>  Sorry for the delay, I've made and tested new patch for it as
>  https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2

 Can someone review it? > -boot


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Hideki Yamane]

Hi Steve,

On Wed, 13 Feb 2019 18:00:36 +
Steve McIntyre  wrote:
> >I'm afraid your fix in choose_partition/lvm/do_option is broken. It's
> >causing problems for other people trying to use LVM in d-i. See
> >#922100, which I've just confirmed locally.
> 
> I've reverted your change for now - we've already had 2 bug
> reports. Please test and fix as/when you can.

 Sorry for the delay, I've made and tested new patch for it as
 https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2

 Could you check it, please?


-- 
Hideki Yamane 

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Steve McIntyre]

Hi Hideki,

On Tue, Feb 12, 2019 at 02:16:30AM +, Steve McIntyre wrote:
>Control: reopen -1
>
>Hi Hideki,
>
>I'm afraid your fix in choose_partition/lvm/do_option is broken. It's
>causing problems for other people trying to use LVM in d-i. See
>#922100, which I've just confirmed locally.

I've reverted your change for now - we've already had 2 bug
reports. Please test and fix as/when you can.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
  Getting a SCSI chain working is perfectly simple if you remember that there
  must be exactly three terminations: one on one end of the cable, one on the
  far end, and the goat, terminated over the SCSI chain with a silver-handled
  knife whilst burning *black* candles. --- Anthony DeBoer

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Steve McIntyre]

Control: reopen -1

Hi Hideki,

I'm afraid your fix in choose_partition/lvm/do_option is broken. It's
causing problems for other people trying to use LVM in d-i. See
#922100, which I've just confirmed locally.

Code:

--- a/choose_partition/lvm/do_option
+++ b/choose_partition/lvm/do_option
@@ -471,7 +471,9 @@ do_lv_delete() {
db_subst partman-lvm/text/lvdelete_invg VG "$vg"
db_metaget partman-lvm/text/lvdelete_invg description
lv_get_info "$vg" "$lv"
-   output=$(printf "%-30s (%sMB - %s)" "$lv" "$SIZE" "$RET")
+   # In non-latin locale environment, $RET contains extra 
characters
+   # clean it as valid ascii characters name
+   output=$(printf "%-30s (%sMB - %s)" "$lv" "$SIZE" "$(echo $RET 
| sed -e 's/^VG//' -e 's/[^-+_\.[:alnum:]]//g')")
lvs="${lvs:+$lvs, }$output"
done

In my test VM, I've added debug to see what $RET is before the sed
acts on it. I'm seeing that $RET is "in VG debian-vg", and after your
sed code it's "inVGdebian-vg". Maybe it should look something more
like:

  "$(echo $RET | sed -e 's/^.*VG//' -e 's/[^-+_\.[:alnum:]]//g')"

?? Please test this some more and see if you can fix it?

On Tue, Oct 16, 2018 at 12:38:30PM +0900, Hideki Yamane wrote:
>Hi,
>
> Here's a step to reproduce this bug
>---
>1. boot from d-i media and start installer
>2. create encrypted LVM volume
>3. select "go back" and "Change language" to "Japanese" 
>   (or other multi-byte locale)
>4. select "論理ボリュームマネージャーの設定 (Configure the Logical Volume Manager)"
>-> "論理ボリュームの削除 (Delete logical volue)" and any volume
>5. Got error
>6. select "戻る (go back) and "言語の選択/Change language" to "English"
>7. select "Configure the Logical Volume Manager"
>   -> "Delete logical volume" and any volume
>8. you can delete it without error!
>
>
>-- 
>Hideki Yamane 
>
>
-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"Arguing that you don't care about the right to privacy because you have
 nothing to hide is no different than saying you don't care about free
 speech because you have nothing to say."
   -- Edward Snowden

Processed: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Debian Bug Tracking System]

Processing control commands:

> reopen -1
Bug #911036 {Done: Holger Wansing } [partman-lvm] 
partman-lvm:  Volume group name "■" has invalid characters, and cannot removed
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions partman-lvm/125.

-- 
911036: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911036
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Debian Bug Tracking System]

Processing control commands:

> tags -1 +patch
Bug #911036 [partman-lvm] partman-lvm:  Volume group name "■" has invalid 
characters, and cannot removed
Added tag(s) patch.

-- 
911036: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911036
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Hideki Yamane]

control: tags -1 +patch

On Tue, 16 Oct 2018 12:38:30 +0900
Hideki Yamane  wrote:
>  Here's a step to reproduce this bug

 And here's a proposed patch, please review it.
 https://salsa.debian.org/installer-team/partman-lvm/merge_requests/1


-- 
Hideki Yamane 

Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

[Hideki Yamane]

Hi,

 Here's a step to reproduce this bug
---
1. boot from d-i media and start installer
2. create encrypted LVM volume
3. select "go back" and "Change language" to "Japanese" 
   (or other multi-byte locale)
4. select "論理ボリュームマネージャーの設定 (Configure the Logical Volume Manager)"
-> "論理ボリュームの削除 (Delete logical volue)" and any volume
5. Got error
6. select "戻る (go back) and "言語の選択/Change language" to "English"
7. select "Configure the Logical Volume Manager"
   -> "Delete logical volume" and any volume
8. you can delete it without error!


-- 
Hideki Yamane