Re: Hardcoding of ext3 as partman's default filesystem
On Wed, Jan 28, 2009 at 11:24:57AM +, Colin Watson wrote:
How about a partman/default_filesystem template in partman-base,
defaulting to ext3, and then a $default expansion in the filesystem
field in partitioning recipes? That would make it a matter of a boot
parameter to change the default filesystem, and would make the code a
bit more elegant IMO.
I've committed this to trunk. I settled on $default_filesystem as the
recipe substitution; I also added an internal specifier
$default_filesystem{ }, since I didn't like the idea of interpreting
substitutions inside filesystem{ }.
--
Colin Watson [cjwat...@debian.org]
--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Hardcoding of ext3 as partman's default filesystem
On Wed, Jan 28, 2009 at 01:38:01PM +0100, Jérémy Bobbio wrote: On Wed, Jan 28, 2009 at 11:24:57AM +, Colin Watson wrote: How about a partman/default_filesystem template in partman-base, defaulting to ext3, and then a $default expansion in the filesystem field in partitioning recipes? That would make it a matter of a boot parameter to change the default filesystem, and would make the code a bit more elegant IMO. Sounds like a good plan. I am unsure on how you plan to write the expansion, but it might be better to have a $default_fs or $default_filesystem instead of an unspecific $default. I actually initially thought $default_fs but then went for brevity. $default_fs is fine with me if that's what people prefer. -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Hardcoding of ext3 as partman's default filesystem
On Wed, Jan 28, 2009 at 01:13:10PM -0500, Rick Thomas wrote:
On Wed, Jan 28, 2009 at 11:24:57AM +, Colin Watson wrote:
How about a partman/default_filesystem template in partman-base,
defaulting to ext3, and then a $default expansion in the filesystem
field in partitioning recipes? That would make it a matter of a boot
parameter to change the default filesystem, and would make the code a
bit more elegant IMO.
Great idea!
Wishlist request from a user: Please take care to not restrict it to
ext3/ext4 only.
I certainly had no intention of limiting it that way; that would be more
effort than not doing so. :-)
For example, in the embedded computing market, it might be nice to be
able to default to jffs2.
I can only cope with filesystems that partman already supports; it
doesn't support jffs2 yet.
Or, if your chosen mass-storage media is a thumb flash-drive, the
default could be ext2 with the relatime option.
I'm not sure how to deal with options there, unless it's just by the
general /lib/partman/mountoptions/${fs}_defaults file (not supported
yet, will be shortly).
Or, for some other kinds of application environments, XFS or reiser,
etc.
That would be straightforward since those are well-supported.
--
Colin Watson [cjwat...@debian.org]
--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Hardcoding of ext3 as partman's default filesystem
On Fri, Jan 30, 2009 at 11:49:54AM +, Colin Watson wrote:
On Wed, Jan 28, 2009 at 01:13:10PM -0500, Rick Thomas wrote:
Or, if your chosen mass-storage media is a thumb flash-drive, the
default could be ext2 with the relatime option.
I'm not sure how to deal with options there, unless it's just by the
general /lib/partman/mountoptions/${fs}_defaults file (not supported
yet, will be shortly).
Err, except for the way it *is* supported as of partman-basicmethods 40
and partman-partitioning 60 (i.e. six months ago or so). Sorry, I was
looking at the wrong tree.
--
Colin Watson [cjwat...@debian.org]
--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Hardcoding of ext3 as partman's default filesystem
There are a number of places in partman where the default filesystem is
currently hardcoded:
partman-auto-lvm/lib/auto-lvm.sh:17:echo $scheme${NL}100 1000 -1 ext3
\$primary{ } method{ $method }
partman-crypto/init.d/crypto:108: filesystem=ext3
partman-crypto/init.d/crypto:131: ext3)
partman-partitioning/free_space/new/do_option:148: if [ $id ] [ -f
../../ext3 ]; then
partman-partitioning/free_space/new/do_option:154: echo ext3
$id/filesystem
partman-partitioning/free_space/new/do_option:156: if [ -f
/lib/partman/mountoptions/ext3_defaults ]; then
partman-partitioning/free_space/new/do_option:157: for
op in $(cat /lib/partman/mountoptions/ext3_defaults); do
partman-partitioning/free_space/new/do_option:188:
menudir_default_choice /lib/partman/active_partition ext3 mountpoint || true
... and of course all the recipes in partman-auto. Particularly with the
advent of ext4 (where I'd like to be able to offer an easy way to
autopartition with ext4 without having to go through manual
partitioning, until such time as it's made the default), I was wondering
about abstracting this a bit.
How about a partman/default_filesystem template in partman-base,
defaulting to ext3, and then a $default expansion in the filesystem
field in partitioning recipes? That would make it a matter of a boot
parameter to change the default filesystem, and would make the code a
bit more elegant IMO.
(I'm happy to implement this after consensus, obviously.)
--
Colin Watson [cjwat...@debian.org]
--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Hardcoding of ext3 as partman's default filesystem
On Wed, Jan 28, 2009 at 11:24:57AM +, Colin Watson wrote: How about a partman/default_filesystem template in partman-base, defaulting to ext3, and then a $default expansion in the filesystem field in partitioning recipes? That would make it a matter of a boot parameter to change the default filesystem, and would make the code a bit more elegant IMO. Sounds like a good plan. I am unsure on how you plan to write the expansion, but it might be better to have a $default_fs or $default_filesystem instead of an unspecific $default. Cheers, -- Jérémy Bobbio.''`. lu...@debian.org: :Ⓐ : # apt-get install anarchism `. `'` `- signature.asc Description: Digital signature
Re: Hardcoding of ext3 as partman's default filesystem
Jérémy Bobbio lu...@debian.org writes: On Wed, Jan 28, 2009 at 11:24:57AM +, Colin Watson wrote: How about a partman/default_filesystem template in partman-base, defaulting to ext3, and then a $default expansion in the filesystem field in partitioning recipes? That would make it a matter of a boot parameter to change the default filesystem, and would make the code a bit more elegant IMO. Sounds like a good plan. I am unsure on how you plan to write the expansion, but it might be better to have a $default_fs or $default_filesystem instead of an unspecific $default. I fully agree. This makes the whole thing easier to change even more for blends. -- O T A V I OS A L V A D O R - E-mail: ota...@debian.org UIN: 5906116 GNU/Linux User: 239058 GPG ID: 49A5F855 Home Page: http://otavio.ossystems.com.br - Microsoft sells you Windows ... Linux gives you the whole house. -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Hardcoding of ext3 as partman's default filesystem
On Wed, Jan 28, 2009 at 11:24:57AM +, Colin Watson wrote: How about a partman/default_filesystem template in partman-base, defaulting to ext3, and then a $default expansion in the filesystem field in partitioning recipes? That would make it a matter of a boot parameter to change the default filesystem, and would make the code a bit more elegant IMO. Great idea! Wishlist request from a user: Please take care to not restrict it to ext3/ext4 only. For example, in the embedded computing market, it might be nice to be able to default to jffs2. Or, if your chosen mass- storage media is a thumb flash-drive, the default could be ext2 with the relatime option. Or, for some other kinds of application environments, XFS or reiser, etc. I realize this has greater implications in more than than just the spots that Colin pointed out. Fully implementing complete flexibility will probably not be possible. But at least, don't let the proposed changes close off the potential. Thanks! Rick -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
