Re: Last 2 commits in cdrom-checker
Christian PERRIER (29/01/2013): > cdrom-checker built and uploaded. Added to my list of packages to potentially unblock for rc1, thank you. Mraw, KiBi. signature.asc Description: Digital signature
Re: Last 2 commits in cdrom-checker
Quoting Cyril Brulebois (k...@debian.org): > > > > I suspect e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0 to be safe and a > > > > good idea.I have however no idea for > > > > 1ec13c5a378076c10988237972d4df0f1eefafd3, given my own C-fu..:-) > > > > > > It made the jenkins build stable and was non-intrusive enough that I > > > didn't think it was necessary to put it on a jessie branch. > > > > OK, so unless Cyril objects, I will upload a version with these fixes. > > > > Christian, still hunting pending stuff in master branches..:-) > > no objection, I really do hope such things don't trigger nasty runtime > bugs. :D cdrom-checker built and uploaded. signature.asc Description: Digital signature
Re: Last 2 commits in cdrom-checker
Hi, Christian PERRIER (11/01/2013): > Quoting Colin Watson (cjwat...@debian.org): > > > > I suspect e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0 to be safe and a > > > good idea.I have however no idea for > > > 1ec13c5a378076c10988237972d4df0f1eefafd3, given my own C-fu..:-) > > > > It made the jenkins build stable and was non-intrusive enough that I > > didn't think it was necessary to put it on a jessie branch. > > OK, so unless Cyril objects, I will upload a version with these fixes. > > Christian, still hunting pending stuff in master branches..:-) no objection, I really do hope such things don't trigger nasty runtime bugs. :D Mraw, KiBi. signature.asc Description: Digital signature
Re: Last 2 commits in cdrom-checker
Quoting Colin Watson (cjwat...@debian.org): > > I suspect e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0 to be safe and a > > good idea.I have however no idea for > > 1ec13c5a378076c10988237972d4df0f1eefafd3, given my own C-fu..:-) > > It made the jenkins build stable and was non-intrusive enough that I > didn't think it was necessary to put it on a jessie branch. OK, so unless Cyril objects, I will upload a version with these fixes. Christian, still hunting pending stuff in master branches..:-) signature.asc Description: Digital signature
Re: Last 2 commits in cdrom-checker
On Fri, Jan 11, 2013 at 07:12:49AM +0100, Christian PERRIER wrote: > Do you target wheezy for the last 2 commits your made in cdrom > -checker? There's no pressing urgency to have them in wheezy, but they're also entirely harmless and can ride along with translation updates or whatever without causing any problems. If there are no more uploads of cdrom-checker before wheezy, then they can just stay on master and be uploaded later. > I suspect e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0 to be safe and a > good idea.I have however no idea for > 1ec13c5a378076c10988237972d4df0f1eefafd3, given my own C-fu..:-) It made the jenkins build stable and was non-intrusive enough that I didn't think it was necessary to put it on a jessie branch. -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2013001916.gn21...@riva.dynamic.greenend.org.uk
Re: Last 2 commits in cdrom-checker
Christian PERRIER, le Fri 11 Jan 2013 07:12:49 +0100, a écrit : > Hi Colin, > > Do you target wheezy for the last 2 commits your made in cdrom > -checker? > > I suspect e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0 to be safe and a > good idea.I have however no idea for > 1ec13c5a378076c10988237972d4df0f1eefafd3, given my own C-fu..:-) It's completely harmless. Samuel -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130111095420.ga7...@type.bordeaux.inria.fr
Last 2 commits in cdrom-checker
Hi Colin,
Do you target wheezy for the last 2 commits your made in cdrom
-checker?
I suspect e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0 to be safe and a
good idea.I have however no idea for
1ec13c5a378076c10988237972d4df0f1eefafd3, given my own C-fu..:-)
commit 1ec13c5a378076c10988237972d4df0f1eefafd3
Author: Colin Watson
Date: Wed Jan 9 12:11:09 2013 +
Mark argc parameter to main as unused.
diff --git a/debian/changelog b/debian/changelog
index 29db03b..14fdbfa 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,7 @@
cdrom-checker (1.24) UNRELEASED; urgency=low
* Fix "LDLFAGS" typo in Makefile.
+ * Mark argc parameter to main as unused.
-- Colin Watson Wed, 09 Jan 2013 12:05:27 +
diff --git a/main.c b/main.c
index a1b1b80..4a1409f 100644
--- a/main.c
+++ b/main.c
@@ -159,7 +159,7 @@ int check_cdrom() {
return(status);
}
-int main(int argc, char **argv) {
+int main(int argc __attribute__ ((unused)), char **argv) {
di_system_init(basename(argv[0]));
/* initialize the debconf frontend */
debconf = debconfclient_new();
commit e8ae8876bcea30cc45bcba25ed1e9ea2a317aff0
Author: Colin Watson
Date: Wed Jan 9 12:05:52 2013 +
Fix "LDLFAGS" typo in Makefile.
diff --git a/Makefile b/Makefile
index 05232a2..47bf892 100644
--- a/Makefile
+++ b/Makefile
@@ -20,7 +20,7 @@
CC = gcc
CFLAGS = -W -Wall -Os -fomit-frame-pointer
LD = gcc
-LDLFAGS =
+LDFLAGS =
LDLIBS = -ldebconfclient -ldebian-installer
APP = cdrom-checker
diff --git a/debian/changelog b/debian/changelog
index edc9806..29db03b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+cdrom-checker (1.24) UNRELEASED; urgency=low
+
+ * Fix "LDLFAGS" typo in Makefile.
+
+ -- Colin Watson Wed, 09 Jan 2013 12:05:27 +
+
cdrom-checker (1.23) unstable; urgency=low
[ Updated translations ]
--
signature.asc
Description: Digital signature
