Re: r51611 - in trunk/packages/partman/partman-base: debian init.d lib

2008-02-29 Thread Colin Watson
On Fri, Feb 29, 2008 at 09:23:25AM -0300, Otavio Salvador wrote:
 Guido Guenther [EMAIL PROTECTED] writes:
  +Template: partman/text/multipath_partition
  +Type: text
  +_Description: Multipath %s partition #%s
  +
 
 Wrong.

Don't you think that was a little unnecessarily abrupt for a comment
about a missing comma?

Cheers,

-- 
Colin Watson   [EMAIL PROTECTED]


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: r51611 - in trunk/packages/partman/partman-base: debian init.d lib

2008-02-29 Thread Otavio Salvador
Guido Guenther [EMAIL PROTECTED] writes:

 Modified: trunk/packages/partman/partman-base/debian/partman-base.templates
 ==
 --- trunk/packages/partman/partman-base/debian/partman-base.templates 
 (original)
 +++ trunk/packages/partman/partman-base/debian/partman-base.templates Fri Feb 
 29 11:48:30 2008
 @@ -295,6 +295,14 @@
  # :sl3:
  _Description: Serial ATA RAID %s (partition #%s)
  
 +Template: partman/text/multipath
 +Type: text
 +_Description: Multipath %s (WWID %s)
 +
 +Template: partman/text/multipath_partition
 +Type: text
 +_Description: Multipath %s partition #%s
 +
  Template: partman/text/lvm_lv
  Type: text
  # :sl3:

Wrong.

_Description: Multipath %s, partition #%s
  ^ here

-- 
O T A V I OS A L V A D O R
-
 E-mail: [EMAIL PROTECTED]  UIN: 5906116
 GNU/Linux User: 239058 GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
-
Microsoft sells you Windows ... Linux gives
 you the whole house.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: r51611 - in trunk/packages/partman/partman-base: debian init.d lib

2008-02-29 Thread Frans Pop
On Friday 29 February 2008, Otavio Salvador wrote:
 Guido Guenther [EMAIL PROTECTED] writes:
  +Template: partman/text/multipath_partition
  +Type: text
  +_Description: Multipath %s partition #%s
  +

 Wrong.

 _Description: Multipath %s, partition #%s
   ^ here

I have changed this to:
_Description: Multipath %s (partition #%s)

This is consistent with the existing template for ATA RAID.


signature.asc
Description: This is a digitally signed message part.


Re: r51611 - in trunk/packages/partman/partman-base: debian init.d lib

2008-02-29 Thread Otavio Salvador
Colin Watson [EMAIL PROTECTED] writes:

 On Fri, Feb 29, 2008 at 09:23:25AM -0300, Otavio Salvador wrote:
 Guido Guenther [EMAIL PROTECTED] writes:
  +Template: partman/text/multipath_partition
  +Type: text
  +_Description: Multipath %s partition #%s
  +
 
 Wrong.

 Don't you think that was a little unnecessarily abrupt for a comment
 about a missing comma?

Hehe ... this wasn't suppose to look like this. It was suggested on
the review mail and he has forgot it. Just sent a mail to remeber him
about it.

Guido, if it looked abrupt, sorry. It wasn't my intention.

-- 
O T A V I OS A L V A D O R
-
 E-mail: [EMAIL PROTECTED]  UIN: 5906116
 GNU/Linux User: 239058 GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
-
Microsoft sells you Windows ... Linux gives
 you the whole house.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]