Re: Bug#697032: rcpp: FTBFS[kfreebsd]: #error Rcpp::Timer not supported by your OS.

2012-12-31 Thread Steven Chamberlain 
Hi,

On 31/12/12 06:47, Rainer Hurling wrote:
 I just tried to build Rcpp with __FreeBSD_kernel__ on a recent FreeBSD
 10.0-CURRENT (newest developer version) and it does not resolve. On
 'pure' FreeBSD there is only __FreeBSD__ defined, not a kernel specific
 version.

Which compiler were you using?

It's still defined in 10.0-CURRENT at least in sys/param.h:

http://svnweb.freebsd.org/base/head/sys/sys/param.h?view=annotate#l77

 I think there are much more 'pure' FreeBSD systems than linux ones with
 FreeBSD kernel, so it would be nice, if you would pick up at least the
 __FreeBSD__ symbol.

You are right, I see in the comments describing __FreeBSD_kernel__, that
__FreeBSD__ should be tested for as well, for the benefit of older
FreeBSD versions, 3rd party compilers.

So Dirk, I think we now have this horror:

#elif defined(linux) || defined(__linux) || defined(__FreeBSD__) ||
defined(__FreeBSD_kernel__) || defined(__NetBSD__) ||
defined(__OpenBSD__) || defined(__DragonFly__)

I'm not sure what (__linux) refers to and may not be needed.

Some others might be:

defined(__APPLE__) for Mach, or Mac OS X
defined(__GNU__) for GNU/Hurd

Yet more examples:

http://codesearch.debian.net/search?q=BSD.*BSD_kernel.*BSD

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50e1bef1.9010...@pyro.eu.org

Re: Bug#697032: rcpp: FTBFS[kfreebsd]: #error Rcpp::Timer not supported by your OS.

2012-12-31 Thread Dirk Eddelbuettel 

On 31 December 2012 at 16:36, Steven Chamberlain wrote:
| So Dirk, I think we now have this horror:
| 
| #elif defined(linux) || defined(__linux) || defined(__FreeBSD__) ||
| defined(__FreeBSD_kernel__) || defined(__NetBSD__) ||
| defined(__OpenBSD__) || defined(__DragonFly__)
 
Which is pretty much what I had committed -- modulo DragonFly.  What is that 
for?

https://r-forge.r-project.org/scm/viewvc.php/pkg/Rcpp/src/Timer.cpp?root=rcppr1=4182r2=4181pathrev=4182
(running a plain Debian install of FusionForge, slightly rebranded for R :)

As this is about the Rcpp project, we already test in another spot for
known/supported compilers (mostly to get rid of Visual Studio idiots -- R on
Windows very much depends on MinGW whether they understand it or not).

Dirk
-- 
Dirk Eddelbuettel | e...@debian.org | http://dirk.eddelbuettel.com  


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20705.50686.100568.628...@max.nulle.part