Re: Bug#757986: kfreebsd: multiple "inappropriate ioctl for device" prompts

2014-09-19 Thread Colin Watson
On Fri, Sep 19, 2014 at 02:57:06PM +0100, Steven Chamberlain wrote:
> I was able to review Jeff Epler's original patch for this issue, make
> sure I properly understood it, clean it up and test it again in a full
> d-i image.  I can now happily sign off on this as a correct fix.
> 
> I've attached it in the form of a commit for parted packaging Git.  It
> updates the existing kfreebsd-gnu.patch with Jeff's new code, and
> refreshes the others.

Thanks!  Applied in spirit (i.e. git-dpm checkout-patched, git rebase -i
upstream, edit kfreebsd-gnu.patch, applied the same delta, git rebase
--continue, git-dpm update-patches, and amended that commit with the
changelog).  I'll upload shortly.

-- 
Colin Watson   [cjwat...@debian.org]


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140919144539.gd5...@riva.ucam.org



Re: Bug#757986: kfreebsd: multiple "inappropriate ioctl for device" prompts

2014-09-19 Thread Steven Chamberlain
tags 757986 + patch
thanks

(p.s. KiBi - perhaps we could fix this in time for d-i Beta 2?  if linux
is waiting for up to 5 more days)

Hi,

I was able to review Jeff Epler's original patch for this issue, make
sure I properly understood it, clean it up and test it again in a full
d-i image.  I can now happily sign off on this as a correct fix.

I've attached it in the form of a commit for parted packaging Git.  It
updates the existing kfreebsd-gnu.patch with Jeff's new code, and
refreshes the others.

Thank you,
Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org
diff --git a/debian/changelog b/debian/changelog
index 6b45fda..cf56fd1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,18 @@
+parted (3.2-5) UNRELEASED; urgency=low
+
+  [ Steven Chamberlain ]
+  * kfreebsd-gnu.patch: (Thanks, Jeff Epler!)
+- Fix detection of /dev/ada as a SCSI disk type (Closes: #693510,
+  #757986)
+- Implement detection of drive model, logical and physical sector
+  sizes for SCSI disks
+  * Refresh patches
+- freebsd-zvol.patch
+- freebsd-geli.patch
+- kfreebsd_lvm.patch
+
+ -- Parted Maintainer Team   Wed, 13 Aug 2014 20:24:11 +0100
+
 parted (3.2-4) unstable; urgency=high
 
   * Probe LVM logical volumes even when their physical volumes are on
diff --git a/debian/patches/freebsd-geli.patch b/debian/patches/freebsd-geli.patch
index b1003be..594632b 100644
--- a/debian/patches/freebsd-geli.patch
+++ b/debian/patches/freebsd-geli.patch
@@ -1,4 +1,4 @@
-From cc549a70b496cb4f9cdbd5de03a864922cd5c991 Mon Sep 17 00:00:00 2001
+From 4f1d7a475db350cc2b11d22ed54be6eff472e2f3 Mon Sep 17 00:00:00 2001
 From: Robert Millan 
 Date: Fri, 28 Mar 2014 17:09:51 +
 Subject: Detection of GEOM encryption devices (GELI)
@@ -12,11 +12,9 @@ Patch-Name: freebsd-geli.patch
  libparted/arch/freebsd.c | 6 ++
  1 file changed, 6 insertions(+)
 
-diff --git a/libparted/arch/freebsd.c b/libparted/arch/freebsd.c
-index a53eadc..b3f23c3 100644
 --- a/libparted/arch/freebsd.c
 +++ b/libparted/arch/freebsd.c
-@@ -1058,6 +1058,8 @@ _probe_kern_disks ()
+@@ -1096,6 +1096,8 @@
  {
  	size_t listsize;
  	char *disklist, *pdisklist, *psave;
@@ -25,7 +23,7 @@ index a53eadc..b3f23c3 100644
  
  	if (sysctlbyname("kern.disks", NULL, &listsize, NULL, 0) != 0) {
  		ped_exception_throw (
-@@ -1091,6 +1093,10 @@ _probe_kern_disks ()
+@@ -1129,6 +1131,10 @@
  		strncat (dev_name, token, sizeof(dev_name) - strlen(_PATH_DEV) - 1);
  		dev_name[sizeof(dev_name) - 1] = '\0';
  		_ped_device_probe (dev_name);
diff --git a/debian/patches/freebsd-zvol.patch b/debian/patches/freebsd-zvol.patch
index 1da84bc..3906fa2 100644
--- a/debian/patches/freebsd-zvol.patch
+++ b/debian/patches/freebsd-zvol.patch
@@ -1,4 +1,4 @@
-From 78e2648ee6767ac54aa24d21646920b00de8e302 Mon Sep 17 00:00:00 2001
+From b62fecc10deaa9b84af44192ce52e84c1280a4a9 Mon Sep 17 00:00:00 2001
 From: Robert Millan 
 Date: Fri, 28 Mar 2014 17:09:50 +
 Subject: Detection of ZFS volumes (ZVOL)
@@ -17,8 +17,6 @@ Patch-Name: freebsd-zvol.patch
  libparted/arch/freebsd.c | 40 
  1 file changed, 40 insertions(+)
 
-diff --git a/libparted/arch/freebsd.c b/libparted/arch/freebsd.c
-index 52f5293..a53eadc 100644
 --- a/libparted/arch/freebsd.c
 +++ b/libparted/arch/freebsd.c
 @@ -23,6 +23,7 @@
@@ -29,7 +27,7 @@ index 52f5293..a53eadc 100644
  #include 
  #include 
  #include 
-@@ -1096,12 +1097,51 @@ _probe_kern_disks ()
+@@ -1134,12 +1135,51 @@
  	return 1;
  }
  
diff --git a/debian/patches/kfreebsd-gnu.patch b/debian/patches/kfreebsd-gnu.patch
index 957aa6b..4d07fac 100644
--- a/debian/patches/kfreebsd-gnu.patch
+++ b/debian/patches/kfreebsd-gnu.patch
@@ -21,11 +21,9 @@ Patch-Name: kfreebsd-gnu.patch
  7 files changed, 1272 insertions(+), 4 deletions(-)
  create mode 100644 libparted/arch/freebsd.c
 
-diff --git a/configure.ac b/configure.ac
-index 436d0e2..038ebdc 100644
 --- a/configure.ac
 +++ b/configure.ac
-@@ -61,6 +61,7 @@ case "$host_os" in
+@@ -61,6 +61,7 @@
  	linux*) OS=linux ;;
  	gnu*)	OS=gnu ;;
  	beos*)	OS=beos ;;
@@ -33,7 +31,7 @@ index 436d0e2..038ebdc 100644
  	*)	AC_MSG_ERROR([Unknown or unsupported OS "$host_os".  Only "linux", "gnu" and "beos" are supported in this version of GNU Parted.]) ;;
  esac
  AC_SUBST([OS])
-@@ -273,6 +274,7 @@ AC_CHECK_SIZEOF([off_t], [64], [
+@@ -273,6 +274,7 @@
  	#include 
  	#include 
  ])
@@ -41,7 +39,7 @@ index 436d0e2..038ebdc 100644
  
  AM_ENABLE_SHARED
  if test "$OS" = linux && test $ac_cv_sizeof_off_t -lt 8; then
-@@ -511,7 +513,7 @@ If you can't find one try:
+@@ -511,7 +513,7 @@
  http://web.mit.edu/tytso/www/linux/e2fsprogs.html])]
  )
  
@@ -50,7 +48,7 @@ index 436d0e2..038ebdc 100644
  AC_CHECK_HEADERS([linux/ext2_fs.h])
  
  dnl required for libparted/llseek.c  (TODO: make linux-x86 only)
-@@ -570,7 +572,9 @@ AC_C_CONST
+@@ -570,7 +572,9 @@
  AC_C_RESTRICT
  
  dnl Checks for library functions.
@@ -61,11 +59,9 @@ index 436d0e2..038ebdc 100644
  AC_CHECK

Re: Bug#757986: kfreebsd: multiple "inappropriate ioctl for device" prompts

2014-08-19 Thread Steven Chamberlain
Taking a very critical view to kfreebsd's available time and resources,
we might leave this totally unaddressed for jessie and leave it as an
errata again.  Yes that's shoddy, but it is a mostly cosmetic issue.

It happens due to CAM changes in kfreebsd-9 and later.  I think the only
serious effect is that it can't show a disk's vendor/serial in partman.
 (Or determine the sector size, but AFAIK that won't affect partman
which uses 1MiB alignments anyway).

Jeff Epler's patch is very good but not perfect (even has a code comment
to that effect).  It basically implements a new CAM mechanism to do the
above.  I tried already but failed to condense it into a smaller change.

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org



signature.asc
Description: OpenPGP digital signature


Re: Bug#757986: kfreebsd: multiple "inappropriate ioctl for device" prompts

2014-08-14 Thread Cyril Brulebois
Control: affects -1 debian-installer

Steven Chamberlain  (2014-08-13):
> forcemerge 757986 693510
> reassign 757986 src:parted
> found 757986 parted/2.3-11
> tags 757986 + patch
> thanks
> 
> Merging with an older bug report where this issue was primarily
> discussed.  I tried Jeff Epler's patch at the time but seem to
> remember there were problems with it, so it ought to be checked again.

“Affecting” debian-installer so that's it's easier to remember it's been
reported already while checking the bug list displayed by reportbug.

(I knew such a bug report existed -- I commented on it -- but I was a
bit too lazy/busy doing testing and reporting to search for it at the
time.)

Mraw,
KiBi.


signature.asc
Description: Digital signature


Re: Bug#757986: kfreebsd: multiple "inappropriate ioctl for device" prompts

2014-08-13 Thread Steven Chamberlain
forcemerge 757986 693510
reassign 757986 src:parted
found 757986 parted/2.3-11
tags 757986 + patch
thanks

Merging with an older bug report where this issue was primarily
discussed.  I tried Jeff Epler's patch at the time but seem to remember
there were problems with it, so it ought to be checked again.

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53eb5030@pyro.eu.org



Bug#757986: kfreebsd: multiple "inappropriate ioctl for device" prompts

2014-08-12 Thread Cyril Brulebois
Package: debian-installer
Version: 20140802
Severity: important
User: debian-bsd@lists.debian.org
Usertags: kfreebsd

Hi,

it seems the following warning still hasn't been decided upon (harmless,
should go away; or important, should stay), and it pops up multiple
times:
| Could not get identity of device /dev/ada0 - Inappropriate ioctl for
| device
| 
| Warning!
| 
|   Ignore
|   Cancel
|
|   

Please investigate and take a decision.

Thanks for your time.

Mraw,
KiBi.


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/20140813015557.22518.72789.report...@wodi.home.mraw.org