Bug#764157: lsh-utils: [kfreebsd] testsuite fails sometimes
Package: src:lsh-utils Version: 2.1-4 Severity: important User: debian-bsd@lists.debian.org Usertags: kfreebsd Hi, lsh-utils sometimes fails to run the testsuite on the kfreebsd buildds: * 2.1-4 on kfreebsd-i386 https://buildd.debian.org/status/fetch.php?pkg=lsh-utils&arch=kfreebsd-i386&ver=2.1-4&stamp=1412538954 | Testing /«PKGBUILDDIR»/src/testsuite/rapid7-ssh-pdu/431.pdu | tcpconnect: shutdown failed: Connection reset by peer | Connect failed | FAIL: rapid7-lshd * 2.1-3 on kfreebsd-amd64 https://buildd.debian.org/status/fetch.php?pkg=lsh-utils&arch=kfreebsd-amd64&ver=2.1-3&stamp=1409537875 | Testing /«PKGBUILDDIR»/src/testsuite/rapid7-ssh-pdu/207.pdu | tcpconnect: shutdown failed: Connection reset by peer | Connect failed | FAIL: rapid7-lshd But on other build attempts it works fine. Thanks. -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'stable') Architecture: kfreebsd-amd64 (x86_64) Kernel: kFreeBSD 9.0-2-amd64-xenhvm-ipsec Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141005211731.44062.52518.report...@sid.kfreebsd-amd64.pyro.eu.org
Re: Bug#764157: lsh-utils: [kfreebsd] testsuite fails sometimes
Hi Niels, At 10:26, Niels Möller wrote: > Steven Chamberlain writes: > > https://buildd.debian.org/status/fetch.php?pkg=lsh-utils&arch=kfreebsd-i386&ver=2.1-4&stamp=1412538954 > > | Testing /«PKGBUILDDIR»/src/testsuite/rapid7-ssh-pdu/431.pdu > > | tcpconnect: shutdown failed: Connection reset by peer > > | Connect failed > > | FAIL: rapid7-lshd > Now, my guesss is that there's a race condition, the client (tcpconnect) > calls shutdown on the socket after it has sent its data. If I understand > this correctly, the server responds with a TCP reset in case that socket > has been closed before the client's TCP fin arrives. Does that make > sense? Yes, probably something like that. The FreeBSD kernel may allow things to happen in a different order sometimes, whereas Linux may have different locking or order of processing. > The linux man page for shutdown(2) doesn't list ECONNRESET as a possible > error, only ENOTCONN. So it seems bsd and linux uses different errno > values for this TCP error case? FreeBSD seems to use ENOTCONN only to mean "never connected" and ECONNRESET to mean "was connected, but peer has disconnected", whereas the shutdown code for Linux doesn't distinguish between. > Can you try the below patch for tcpconnect (located in > lsh/src/testsuite)? Yes. Without the patch, I could reproduce the bug 1 in 3 occasions. With the patch it doesn't seem to happen any more. Thanks! Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141006175932.ga25...@squeeze.pyro.eu.org
Re: Bug#764157: lsh-utils: [kfreebsd] testsuite fails sometimes
måndagen den 6 oktober 2014 18.59.32 skrev Steven Chamberlain: > Hi Niels, > > At 10:26, Niels Möller wrote: > > Can you try the below patch for tcpconnect (located in > > lsh/src/testsuite)? > > Yes. Without the patch, I could reproduce the bug 1 in 3 occasions. > With the patch it doesn't seem to happen any more. Thanks! Good, I've tried to reproduce the bug (on falla.debian.org) but make check seems to succeed every time. I'll include the patch in the package then. -- Magnus Holmgrenholmg...@debian.org Debian Developer signature.asc Description: This is a digitally signed message part.
