Bug#965346: qbittorrent-nox: Web UI password is silently reset to the default during upgrade from buster to bullseye

2020-07-19 Thread Chris Kuehl
Package: qbittorrent-nox
Version: 4.2.5-0.1
Severity: normal

Hi maintainer,

When upgrading qbittorrent from the version in buster (4.1.5-1+deb10u1)
to the version in bullseye (4.2.5-0.1), the password for the web
interface is automatically reset back to the default ("adminadmin")
without any warning to the user.

I believe this is due to a change in qbittorrent 4.2.0 which switched to
using PBKDF2 for storing web UI and GUI lock passwords [0], causing any
password set using old versions of qbittorrent to be ignored completely.

This is dangerous because qbittorrent may be exposed to the internet or
other untrusted traffic (e.g. via [1]). After an upgrade, the user's
qbittorrent instance will be accessible using the default, easily
guessable credentials. This will allow an attacker to view private
information, execute arbitrary scripts as the user running qbittorrent,
etc.

Reproduction steps:

1. Starting from buster, install qbittorrent-nox:

root@host:~$ apt-get install qbittorrent-nox=4.1.5-1+deb10u1

2. Run qbittorrent-nox:

root@host:~$ qbittorrent-nox

 Information 
To control qBittorrent, access the Web UI at http://localhost:8080
The Web UI administrator user name is: admin
The Web UI administrator password is still the default one: adminadmin
This is a security risk, please consider changing your password from 
program preferences.

3. Log in to the web UI at http://localhost:8080 with the default
   credentials (admin:adminadmin) and change the password from the
   "Settings" menu. You can test by clearing your cookies that the
   default username and password no longer work.

4. Stop qbittorrent-nox (e.g. Ctrl-C).

5. Upgrade your system from buster to bullseye, which brings in
   qbittorrent-nox=4.2.5-0.1. (You can also reproduce this by manually
   backporting just the qbittorrent-nox package and installing on a
   buster host.)

6. Run qbittorrent-nox again:

root@host:~$ qbittorrent-nox

 Information 
To control qBittorrent, access the Web UI at http://localhost:8080
The Web UI administrator username is: admin
The Web UI administrator password is still the default one: adminadmin
This is a security risk, please consider changing your password from 
program preferences.

   Note that it indicates that the web UI password is at the default. You
   can also verify at http://localhost:8080 that you can log in with the
   default credentials (admin:adminadmin) again.


[0]: https://www.qbittorrent.org/news.php
[1]: 
https://github.com/qbittorrent/qBittorrent/wiki/NGINX-Reverse-Proxy-for-Web-UI



Bug#915311: dumb-init FTBFS on mips*: test failures

2018-12-02 Thread Chris Kuehl
Hi Adrian,

Thanks for filing this. I can't be certain, but I have a strong
suspicion that this is caused by a bug that we fixed upstream with
dumb-init 1.2.2 which was causing flakiness in the test suite on
certain environments and architectures.

The bug was: https://github.com/Yelp/dumb-init/issues/136
The patch was: https://github.com/Yelp/dumb-init/pull/174

If possible, I would suggest packaging the latest version of dumb-init
(currently 1.2.2) as the easiest way to fix this.

Please let me know if there's any way we can help from the upstream side.

On Sun, Dec 2, 2018 at 9:39 AM Adrian Bunk  wrote:
>
> Source: dumb-init
> Version: 1.2.0-1
> Severity: serious
> Tags: ftbfs
>
> https://buildd.debian.org/status/package.php?p=dumb-init
>
> ...
> === FAILURES 
> ===
> _ test_all_processes_receive_term_on_exit_if_setsid[1] 
> _
>
> @pytest.mark.usefixtures('both_debug_modes', 'setsid_enabled')
> def test_all_processes_receive_term_on_exit_if_setsid():
> """If the child exits for some reason, dumb-init should send TERM to 
> all
> processes in its session if setsid mode is enabled."""
> >   child_pid, child_stdout = spawn_process_which_dies_with_children()
>
> tests/child_processes_test.py:109:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _
>
> def spawn_process_which_dies_with_children():
> """Spawn a process which spawns some children and then dies without
> signaling them, wrapped in dumb-init.
>
> Returns a tuple (child pid, child stdout pipe), where the child is
> print_signals. This is useful because you can signal the PID and see 
> if
> anything gets printed onto the stdout pipe.
> """
> proc = Popen(
> (
> 'dumb-init',
> 'sh', '-c',
>
> # we need to sleep before the shell exits, or dumb-init might 
> send
> # TERM to print_signals before it has had time to register 
> custom
> # signal handlers
> '{python} -m testing.print_signals & sleep 0.1'.format(
> python=sys.executable,
> ),
> ),
> stdout=PIPE,
> )
> proc.wait()
> assert proc.returncode == 0
>
> # read a line from print_signals, figure out its pid
> line = proc.stdout.readline()
> match = re.match(b'ready \(pid: ([0-9]+)\)\n', line)
> >   assert match, line
> E   AssertionError:
> E   assert None
>
> tests/child_processes_test.py:95: AssertionError
> - Captured stderr call 
> -
> [dumb-init] Running in debug mode.
> [dumb-init] Unable to detach from controlling tty (errno=25 Inappropriate 
> ioctl for device).
> [dumb-init] Child spawned with PID 7035.
> [dumb-init] Unable to attach to controlling tty (errno=25 Inappropriate ioctl 
> for device).
> [dumb-init] setsid complete.
> [dumb-init] Received signal 18.
> [dumb-init] A child with PID 7035 exited with exit status 0.
> [dumb-init] Forwarded signal 15 to children.
> [dumb-init] Child exited with status 0. Goodbye.
> _ test_all_processes_receive_term_on_exit_if_setsid[0] 
> _
>
> @pytest.mark.usefixtures('both_debug_modes', 'setsid_enabled')
> def test_all_processes_receive_term_on_exit_if_setsid():
> """If the child exits for some reason, dumb-init should send TERM to 
> all
> processes in its session if setsid mode is enabled."""
> >   child_pid, child_stdout = spawn_process_which_dies_with_children()
>
> tests/child_processes_test.py:109:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _
>
> def spawn_process_which_dies_with_children():
> """Spawn a process which spawns some children and then dies without
> signaling them, wrapped in dumb-init.
>
> Returns a tuple (child pid, child stdout pipe), where the child is
> print_signals. This is useful because you can signal the PID and see 
> if
> anything gets printed onto the stdout pipe.
> """
> proc = Popen(
> (
> 'dumb-init',
> 'sh', '-c',
>
> # we need to sleep before the shell exits, or dumb-init might 
> send
> # TERM to print_signals before it has had time to register 
> custom
> # signal handlers
> '{python} -m testing.print_signals & sleep 0.1'.format(
> python=sys.executable,
> ),
> ),
> stdout=PIPE,
> )
> proc.wait()
> assert proc.returncode == 0
>
> # read a line from print_signals, figure out its pid
> line = proc.stdout.readline()
> match = re.match(b'ready \(pid: ([0-9]+)\)\n', l

Bug#837373: mpd: cannot play m4a files

2016-09-10 Thread Chris Kuehl
Package: mpd
Version: 0.19.18-1+b1
Severity: important
Tags: upstream, fixed-upstream

Hi maintainer,

mpd 0.19.18 has a bug which prevents it from playing m4a files.

This is documented in their bug tracker:
https://bugs.musicpd.org/view.php?id=4564

The fix is released as part of mpd 0.19.19:
https://www.musicpd.org/news/2016/08/mpd-0-19-19-released/

I've confirmed that the new upstream version fixes the issue.
Please consider packaging the latest version for Debian.

Many thanks!
Chris

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mpd depends on:
ii  adduser   3.115
ii  init-system-helpers   1.42
ii  libadplug-2.2.1-0v5   2.2.1+dfsg3-0.3
ii  libao41.1.0-3
ii  libasound21.1.2-1
ii  libaudiofile1 0.3.6-3
ii  libavahi-client3  0.6.32-1
ii  libavahi-common3  0.6.32-1
ii  libavcodec57  7:3.1.3-1+b3
ii  libavformat57 7:3.1.3-1+b3
ii  libavutil55   7:3.1.3-1+b3
ii  libbz2-1.01.0.6-8
ii  libc6 2.23-5
ii  libcdio-cdda1 0.83-4.2+b1
ii  libcdio-paranoia1 0.83-4.2+b1
ii  libcdio13 0.83-4.2+b1
ii  libcurl3-gnutls   7.50.1-1
ii  libdbus-1-3   1.10.10-1
ii  libexpat1 2.2.0-1
ii  libfaad2  2.8.0~cvs20150510-1
ii  libflac8  1.3.1-4
ii  libfluidsynth11.1.6-3
ii  libglib2.0-0  2.49.6-1
ii  libgme0   0.6.0-3
ii  libicu57  57.1-4
ii  libid3tag00.15.1b-12
ii  libiso9660-8  0.83-4.2+b1
ii  libjack-jackd2-0 [libjack-0.116]  1.9.10+20150825git1ed50c92~dfsg-2
ii  libmad0   0.15.1b-8
ii  libmikmod33.3.10-1
ii  libmms0   0.6.4-2
ii  libmodplug1   1:0.8.8.5-2
ii  libmp3lame0   3.99.5+repack1-9+b1
ii  libmpcdec62:0.1~r475-2
ii  libmpdclient2 2.9-1
ii  libmpg123-0   1.22.4-1
ii  libnfs8   1.9.8-1
ii  libogg0   1.3.2-1
ii  libopenal11:1.17.2-1
ii  libopus0  1.1.2-1
ii  libpulse0 9.0-3
ii  libroar2  1.0~beta11-8
ii  libsamplerate00.1.8-8
ii  libshout3 2.3.1-3
ii  libsidplayfp4 1.8.6-1
ii  libsmbclient  2:4.4.5+dfsg-2
ii  libsndfile1   1.0.25-10
ii  libsoxr0  0.1.2-1
ii  libsqlite3-0  3.14.1-1
ii  libstdc++66.1.1-11
ii  libsystemd0   231-4
ii  libupnp6  1:1.6.19+git20160116-1
ii  libvorbis0a   1.3.5-3
ii  libvorbisenc2 1.3.5-3
ii  libvorbisfile31.3.5-3
ii  libwavpack1   4.80.0-1
ii  libwildmidi2  0.4.0-1
ii  libwrap0  7.6.q-25
ii  libyajl2  2.1.0-2
ii  libzzip-0-13  0.13.62-3
ii  lsb-base  9.20160629
ii  zlib1g1:1.2.8.dfsg-2+b1

mpd recommends no packages.

Versions of packages mpd suggests:
ii  avahi-daemon  0.6.32-1
ii  gmpc [mpd-client] 11.8.16-10
pn  icecast2  
ii  mpc [mpd-client]  0.28-1
ii  ncmpcpp [mpd-client]  0.7.4-1+b1
ii  pulseaudio9.0-3



Bug#823382: mirror listing update for mirrors.ocf.berkeley.edu

2016-05-03 Thread Chris Kuehl
Package: mirrors
Severity: minor
User: mirr...@packages.debian.org
Usertags: mirror-list

Submission-Type: update
Site: mirrors.ocf.berkeley.edu
Type: leaf
Archive-architecture: ALL amd64 arm64 armel armhf hurd-i386 i386 kfreebsd-amd64 
kfreebsd-i386 mips mips64el mipsel powerpc ppc64el s390x 
Archive-ftp: /debian/
Archive-http: /debian/
Archive-rsync: debian/
CDImage-ftp: /debian-cd/
CDImage-http: /debian-cd/
CDImage-rsync: debian-cd/
IPv6: yes
Archive-upstream: mirrors.kernel.org
CDImage-upstream: mirrors.kernel.org
Updates: four
Maintainer: Chris Kuehl 
Country: US United States
Location: Berkeley, CA
Sponsor: Open Computing Facility https://www.ocf.berkeley.edu/
Comment: Hi,
 
 Could you please change "IPv6: no" to "IPv6: yes" for the 
mirrors.ocf.berkeley.edu mirror? We have recently added support for it.
 
 Thank you!
 Chris



Bug#810586: ITP: dumb-init -- minimal init system for Linux containers

2016-03-04 Thread Chris Kuehl
Hi Dmitry and ChangZhuo,

Really excited to see the work on this. Please let me know if there's
anything I can do to help with the packaging effort here or at upstream
to make your lives easier.

I'd be happy to help with packaging future versions as well if one of
you are willing to sponsor uploads.

On Sun, Jan 10, 2016 at 06:59:55AM +0100, Marco d'Itri wrote:
> While I can see how distributing statically-linked binaries fits in the
> sad culture of ignorance that programmers improvising themselves
> sysadmins have developed over the last few years (AKA "devops"), I do
> not think that it would be appropriate for Debian (euphemism, see Policy
> 10.1): the program should be linked with glibc as usual.

Yes, I also agree that it should be dynamically-linked as usual for Debian.

On Mon, Feb 29, 2016 at 01:21:53PM +1100, Dmitry Smirnov wrote:
> I pushed dumb-init repository to collab-maint:
> 
> https://anonscm.debian.org/cgit/collab-maint/dumb-init.git

I built and tested this locally, and it looks great to me.

Thanks,
Chris



Bug#788062: os-prober corrupts LVs/partitions while being mounted inside a VM

2016-01-19 Thread Chris Kuehl
Hi,

If this can't be fixed quickly, would it make sense to push an update
which disables os-prober on jessie in cases which are known to (even
possibly) lead to data loss?

I hate to post a "me too" message, but it's a little disheartening to
know that a bug that causes pretty bad data loss in fairly common
scenarios has been known about since June without being patched in
stable.

We just spent a lot of time and effort pinpointing and recovering from
this bug ourselves. I wish we could help others who are yet to hit this
bug, as surely more people are going to lose data until we patch this.

A simple reproduction:

- on the host, run
while :; do os-prober; done
- on a guest, perform some disk IO, e.g.
dd if=/dev/zero of=/test

On our systems, this reproduces the issue very quickly. The guest runs
under KVM and the guest's disk is an LVM logical volume. The filesystem
is ext4.

Thanks for your work on Debian!

Chris



Bug#747909: WIP adt-virt-docker

2015-08-28 Thread Chris Kuehl
Howdy there Mathieu and Martin,

Thanks for your work on this! This is pretty cool.

Out of curiosity, has any progress been made on this patch/bug?

If you'd like some help, I'd be happy to lend a hand to addressing the
comments in Martin's review -- would really like to use this feature
myself :-)

Many thanks!
Chris



Bug#789871: unscd: installs /usr/sbin/nscd binary without corresponding man page

2015-08-15 Thread Chris Kuehl
Hi maintainer,

I've attached a patch that adds a simple manpage based on help2man. Note
that nscd.man is meant to be a symlink to unscd.man (this gets lost in
the patch, but the target in debian/rules would create it properly).

I've also put a diff of the unscd package which also adds a systemd unit
file (#795621) and upgrades to 0.52 (#795618) in addition to adding the
manpage here just in case that's helpful:
https://gist.github.com/chriskuehl/028df2a1b6ee183d104d

Obviously feel free to ignore my patches, just including in case they
are helpful.

Cheers,
Chris

On Wed, Jun 24, 2015 at 05:29:23PM -0700, Chris Kuehl wrote:
> Package: unscd
> Version: 0.51-1+b2
> Severity: wishlist
> 
> Howdy maintainer,
> 
> unscd provides the binary /usr/sbin/nscd but does not appear to provide
> a corresponding man page. It's my understanding from policy [1] that
> this warrants a bug.
> 
> Happy Wednesday, and thanks for your work on Debian!
> Chris
> 
> [1] https://www.debian.org/doc/debian-policy/ch-docs.html#s12.1
> 
> -- System Information:
> Debian Release: 8.1
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages unscd depends on:
> ii  libc6  2.19-18
> 
> unscd recommends no packages.
> 
> unscd suggests no packages.
> 
> -- Configuration Files:
> /etc/nscd.conf changed [not included]
> 
> -- no debconf information
diff -Nru unscd-0.51/debian/help2man unscd-0.52/debian/help2man
--- unscd-0.51/debian/help2man	1969-12-31 16:00:00.0 -0800
+++ unscd-0.52/debian/help2man	2015-08-15 13:49:59.0 -0700
@@ -0,0 +1,3 @@
+[authors]
+.B unscd
+was written primarily by Denys Vlasenko.
diff -Nru unscd-0.51/debian/manpages unscd-0.52/debian/manpages
--- unscd-0.51/debian/manpages	1969-12-31 16:00:00.0 -0800
+++ unscd-0.52/debian/manpages	2015-08-15 13:53:29.0 -0700
@@ -0,0 +1,2 @@
+debian/nscd.man
+debian/unscd.man
diff -Nru unscd-0.51/debian/nscd.man unscd-0.52/debian/nscd.man
--- unscd-0.51/debian/nscd.man	1969-12-31 16:00:00.0 -0800
+++ unscd-0.52/debian/nscd.man	2015-08-15 13:59:16.0 -0700
@@ -0,0 +1,29 @@
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.46.4.
+.TH UNSCD "1" "August 2015" "unscd - nscd which does not hang, v.0.52" "User Commands"
+.SH NAME
+unscd \- nscd which does not hang
+.SH SYNOPSIS
+.B nscd
+[\fI\,OPTION\/\fR...]
+.SH DESCRIPTION
+Name Service Cache Daemon
+.TP
+\fB\-d\fR,\-\-debug
+Do not daemonize; log to stderr (\fB\-dd\fR: more verbosity)
+.HP
+\fB\-f\fR,\-\-config\-file File to read configuration from
+.TP
+\fB\-i\fR,\-\-invalidate
+Invalidate cache
+.TP
+\fB\-K\fR,\-\-shutdown
+Shut the server down
+.TP
+\fB\-t\fR,\-\-nthreads
+Serve N requests in parallel
+.TP
+\fB\-V\fR,\-\-version
+Version
+.SH AUTHORS
+.B unscd
+was written primarily by Denys Vlasenko.
diff -Nru unscd-0.51/debian/rules unscd-0.52/debian/rules
--- unscd-0.51/debian/rules	2013-10-21 17:05:19.0 -0700
+++ unscd-0.52/debian/rules	2015-08-15 14:13:30.0 -0700
@@ -15,3 +15,10 @@
 	install -t debian/unscd/usr/sbin/ nscd
 	install -d debian/unscd/etc/
 	install -m644 -t debian/unscd/etc/ debian/nscd.conf
+
+manpage:
+	help2man --name 'nscd which does not hang' \
+		--include debian/help2man \
+		--no-info \
+		debian/unscd/usr/sbin/nscd > debian/unscd.man
+	ln -fs unscd.man debian/nscd.man
diff -Nru unscd-0.51/debian/unscd.man unscd-0.52/debian/unscd.man
--- unscd-0.51/debian/unscd.man	1969-12-31 16:00:00.0 -0800
+++ unscd-0.52/debian/unscd.man	2015-08-15 13:59:16.0 -0700
@@ -0,0 +1,29 @@
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.46.4.
+.TH UNSCD "1" "August 2015" "unscd - nscd which does not hang, v.0.52" "User Commands"
+.SH NAME
+unscd \- nscd which does not hang
+.SH SYNOPSIS
+.B nscd
+[\fI\,OPTION\/\fR...]
+.SH DESCRIPTION
+Name Service Cache Daemon
+.TP
+\fB\-d\fR,\-\-debug
+Do not daemonize; log to stderr (\fB\-dd\fR: more verbosity)
+.HP
+\fB\-f\fR,\-\-config\-file File to read configuration from
+.TP
+\fB\-i\fR,\-\-invalidate
+Invalidate cache
+.TP
+\fB\-K\fR,\-\-shutdown
+Shut the server down
+.TP
+\fB\-t\fR,\-\-nthreads
+Serve N requests in parallel
+.TP
+\fB\-V\fR,\-\-version
+Version
+.SH AUTHORS
+.B unscd
+was written primarily by Denys Vlasenko.


Bug#795618: unscd sometimes segfaults, please consider packaging latest upstream version 0.52

2015-08-15 Thread Chris Kuehl
Hi maintainer,

I've attached a patch to the package that we're using to update to 0.52.
It seems to work nicely for us.

I've also put a diff of the unscd package which also adds a systemd unit
file (#795621) and adds a manpage (#789871) in addition to adding the
unit file here just in case that's helpful:
https://gist.github.com/chriskuehl/028df2a1b6ee183d104d

Obviously feel free to ignore my patches, just including in case they
are helpful.

Thanks for your work on Debian!
Chris

On Sat, Aug 15, 2015 at 01:42:13PM -0700, Chris Kuehl wrote:
> Package: unscd
> Version: 0.51-1+b2
> Severity: normal
> Tags: upstream
> 
> Howdy maintainer,
> 
> Happy Saturday!
> 
> We are seeing unscd segfaulting in what appears to be random situations
> shortly after startup.
> 
> https://gist.github.com/chriskuehl/0e16f6d87459eb693a66#file-gistfile1-txt-L6
> 
> Based on testing, it feels related to racing between our LDAP server
> startup and unscd, but we are not at all certain about that yet.
> 
> We're still trying to determine the exact cause and a reliable way to
> reproduce it, but in the mean time, we have found that upgrading to the
> latest upstream, version 0.52, seems to resolve these problems.
> 
> The diff between versions 0.51 and 0.52 is tiny:
> https://gist.github.com/chriskuehl/81b66552c14165aa55d4
> 
> Thanks for your work on Debian!
> Chris
> 
> 
> -- System Information:
> Debian Release: 8.1
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages unscd depends on:
> ii  libc6  2.19-18
> 
> unscd recommends no packages.
> 
> unscd suggests no packages.
> 
> -- Configuration Files:
> /etc/nscd.conf changed:
> debug-level 0
> enable-cache passwd yes
> positive-time-to-live passwd 3600
> negative-time-to-live passwd 20
> check-files passwd yes
> enable-cache group yes
> positive-time-to-live group 3600
> negative-time-to-live group 60
> check-files group yes
> enable-cache hosts yes
> positive-time-to-live hosts 30
> negative-time-to-live hosts 30
> check-files hosts yes
> 
> 
> -- no debconf information
diff -Nru unscd-0.51/debian/changelog unscd-0.52/debian/changelog
--- unscd-0.51/debian/changelog	2013-10-21 17:02:22.0 -0700
+++ unscd-0.52/debian/changelog	2015-08-15 16:45:41.204890882 -0700
@@ -1,3 +1,10 @@
+unscd (0.52-1ocf1) unstable; urgency=medium
+
+  * New upstream release (Closes: #795618)
+  * Update Debian standards version
+
+ -- Chris Kuehl   Sat, 15 Aug 2015 13:24:33 -0700
+
 unscd (0.51-1) unstable; urgency=low
 
   * New upstream release
diff -Nru unscd-0.51/debian/control unscd-0.52/debian/control
--- unscd-0.51/debian/control	2013-10-21 15:41:49.0 -0700
+++ unscd-0.52/debian/control	2015-08-15 16:45:53.604439452 -0700
@@ -1,7 +1,7 @@
 Source: unscd
 Section: admin
 Priority: extra
-Standards-Version: 3.9.3
+Standards-Version: 3.9.6
 Build-Depends: debhelper (>= 9), groff-base
 Maintainer: Don Armstrong 
 Vcs-Browser: http://git.donarmstrong.com/unscd.git
diff -Nru unscd-0.51/nscd.c unscd-0.52/nscd.c
--- unscd-0.51/nscd.c	2013-10-21 15:37:00.0 -0700
+++ unscd-0.52/nscd.c	2015-08-15 13:31:30.0 -0700
@@ -144,8 +144,9 @@
  * 0.49   minor tweaks to messages
  * 0.50   add more files to watch for changes
  * 0.51   fix a case where we forget to refcount-- the cached entry
+ * 0.52   make free_refcounted_ureq() tolerant to pointers to NULLs
  */
-#define PROGRAM_VERSION "0.51"
+#define PROGRAM_VERSION "0.52"
 
 #define DEBUG_BUILD 1
 
@@ -1213,6 +1214,10 @@
 {
 	user_req *ureq = *ureqp;
 
+	/* (when exactly can this happen?) */
+	if (ureq == NULL)
+		return;
+
 	if (!CACHED_ENTRY(ureq))
 		return;
 


Bug#795621: unscd: Please consider providing a systemd unit file

2015-08-15 Thread Chris Kuehl
Hi again maintainer,

I've attached a patch that adds a systemd unit file in the hopes that
it's helpful. It's working nicely on our ~100 systems running jessie.

I've also put a diff of the unscd package which also packages the newest
upstream (#795618) and adds a manpage (#789871) in addition to adding
the unit file here just in case that's helpful:
https://gist.github.com/chriskuehl/028df2a1b6ee183d104d

Obviously feel free to ignore my patches, just including in case they
are helpful.

Thanks!
Chris

On Sat, Aug 15, 2015 at 02:19:03PM -0700, Chris Kuehl wrote:
> Package: unscd
> Version: 0.51-1+b2
> Severity: wishlist
> 
> Howdy maintainer,
> 
> It would be convenient to provide a systemd unit file; this would make
> it a little easier to manage and check the status of the running daemon,
> and would allow it to be restarted automatically by systemd if it were
> to crash.
> 
> Many thanks for your work!
> Chris
> 
> 
> -- System Information:
> Debian Release: 8.1
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages unscd depends on:
> ii  libc6  2.19-18
> 
> unscd recommends no packages.
> 
> unscd suggests no packages.
> 
> -- Configuration Files:
> /etc/nscd.conf changed:
> debug-level 0
> enable-cache passwd yes
> positive-time-to-live passwd 3600
> negative-time-to-live passwd 20
> check-files passwd yes
> enable-cache group yes
> positive-time-to-live group 3600
> negative-time-to-live group 60
> check-files group yes
> enable-cache hosts yes
> positive-time-to-live hosts 30
> negative-time-to-live hosts 30
> check-files hosts yes
> 
> 
> -- no debconf information
--- unscd-0.51/debian/control	2013-10-21 15:41:49.0 -0700
+++ unscd-0.52/debian/control	2015-08-15 14:02:26.0 -0700
@@ -1,8 +1,8 @@
 Source: unscd
 Section: admin
 Priority: extra
 Standards-Version: 3.9.3
-Build-Depends: debhelper (>= 9), groff-base
+Build-Depends: debhelper (>= 9), groff-base, dh-systemd
 Maintainer: Don Armstrong 
 Vcs-Browser: http://git.donarmstrong.com/unscd.git
 Vcs-Git: git://git.donarmstrong.com/unscd.git
diff -Nru unscd-0.51/debian/help2man unscd-0.52/debian/help2man
diff -Nru unscd-0.51/debian/rules unscd-0.52/debian/rules
--- unscd-0.51/debian/rules	2013-10-21 17:05:19.0 -0700
+++ unscd-0.52/debian/rules	2015-08-15 14:13:30.0 -0700
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 %:
-	dh $@
+	dh $@ --with systemd
 
 override_dh_auto_clean:
 	rm -f nscd
diff -Nru unscd-0.51/debian/service unscd-0.52/debian/service
--- unscd-0.51/debian/service	1969-12-31 16:00:00.0 -0800
+++ unscd-0.52/debian/service	2015-08-15 14:12:34.0 -0700
@@ -0,0 +1,10 @@
+[Unit]
+Description=Name Service Cache Daemon
+
+[Service]
+User=root
+ExecStart=/usr/sbin/nscd -d
+Restart=always
+
+[Install]
+WantedBy=multi-user.target


Bug#795622: nodeenv: package should depend on either (build dependencies of nodejs | nodejs)

2015-08-15 Thread Chris Kuehl
Package: nodeenv
Version: 0.13.3-1
Severity: normal

There are two modes for the virtual environments created by nodeenv:

  1) Download and compile from source an available version of node.js
 into the virtual environment. This requires python2, gcc, g++, and
 libssl-dev. This is the default mode of operation.

  2) Use the system nodejs interpreter. This doesn't require the
 packages listed under "Recommends:", but does require the "nodejs"
 package to be installed. This can be selected by passing `system`
 as the desired version, but is not the default.

If the user chooses to install the package with
`--no-install-recommends` and has not already installed these
dependencies, the package will be unusable.

It would probably sense to do something like:

Depends: (gcc (>= 4:4.9.1), g++ (>= 4:4.9.1), libssl-dev, python) | nodejs

Chris


-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages nodeenv depends on:
ii  make   4.0-8.1
ii  python33.4.2-2
ii  python3-pkg-resources  18.0.1-1~ocf1
pn  python3:any

Versions of packages nodeenv recommends:
ii  g++ 4:4.9.2-2
ii  gcc 4:4.9.2-2
ii  libssl-dev  1.0.1k-3+deb8u1
ii  python  2.7.9-1

Versions of packages nodeenv suggests:
ii  nodejs  0.10.29~dfsg-2

-- no debconf information



Bug#795621: unscd: Please consider providing a systemd unit file

2015-08-15 Thread Chris Kuehl
Package: unscd
Version: 0.51-1+b2
Severity: wishlist

Howdy maintainer,

It would be convenient to provide a systemd unit file; this would make
it a little easier to manage and check the status of the running daemon,
and would allow it to be restarted automatically by systemd if it were
to crash.

Many thanks for your work!
Chris


-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages unscd depends on:
ii  libc6  2.19-18

unscd recommends no packages.

unscd suggests no packages.

-- Configuration Files:
/etc/nscd.conf changed:
debug-level 0
enable-cache passwd yes
positive-time-to-live passwd 3600
negative-time-to-live passwd 20
check-files passwd yes
enable-cache group yes
positive-time-to-live group 3600
negative-time-to-live group 60
check-files group yes
enable-cache hosts yes
positive-time-to-live hosts 30
negative-time-to-live hosts 30
check-files hosts yes


-- no debconf information



Bug#795618: unscd sometimes segfaults, please consider packaging latest upstream version 0.52

2015-08-15 Thread Chris Kuehl
Package: unscd
Version: 0.51-1+b2
Severity: normal
Tags: upstream

Howdy maintainer,

Happy Saturday!

We are seeing unscd segfaulting in what appears to be random situations
shortly after startup.

https://gist.github.com/chriskuehl/0e16f6d87459eb693a66#file-gistfile1-txt-L6

Based on testing, it feels related to racing between our LDAP server
startup and unscd, but we are not at all certain about that yet.

We're still trying to determine the exact cause and a reliable way to
reproduce it, but in the mean time, we have found that upgrading to the
latest upstream, version 0.52, seems to resolve these problems.

The diff between versions 0.51 and 0.52 is tiny:
https://gist.github.com/chriskuehl/81b66552c14165aa55d4

Thanks for your work on Debian!
Chris


-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages unscd depends on:
ii  libc6  2.19-18

unscd recommends no packages.

unscd suggests no packages.

-- Configuration Files:
/etc/nscd.conf changed:
debug-level 0
enable-cache passwd yes
positive-time-to-live passwd 3600
negative-time-to-live passwd 20
check-files passwd yes
enable-cache group yes
positive-time-to-live group 3600
negative-time-to-live group 60
check-files group yes
enable-cache hosts yes
positive-time-to-live hosts 30
negative-time-to-live hosts 30
check-files hosts yes


-- no debconf information



Bug#794437: redis-server: systemd ExecStop is incorrect if port is changed

2015-08-02 Thread Chris Kuehl
Package: redis-server
Version: 2:3.0.3-2
Severity: normal

Howdy maintainer,

If I change the port Redis listens on (e.g. to listen only on a UNIX
socket), the ExecStop line in redis-server (which calls redis-cli
shutdown) is then incorrect. When I try to stop redis-server, syslog
shows:

Aug  2 17:42:53 anthrax systemd[1]: Stopping Advanced key-value store...
Aug  2 17:42:53 anthrax redis-cli[4099]: Could not connect to Redis at 
127.0.0.1:6379: Connection refused
Aug  2 17:42:53 anthrax systemd[1]: redis-server.service: Control process 
exited, code=exited status=1
Aug  2 17:42:53 anthrax systemd[1]: Stopped Advanced key-value store.
Aug  2 17:42:53 anthrax systemd[1]: redis-server.service: Unit entered 
failed state.
Aug  2 17:42:53 anthrax systemd[1]: redis-server.service: Failed with 
result 'exit-code'.

Simply removing the ExecStop line fixes this (presumably systemd sends a
SIGTERM or something to the process). This seems like a reasonable fix
(looks like it's basically what `/etc/init.d/redis-server` does).

Many thanks!
Chris


Here is a diff of my config file:

  --- /etc/redis/redis.conf.old  2015-08-02 17:41:21.752303689 -0700
  +++ /etc/redis/redis.conf  2015-08-02 17:41:54.624572316 -0700
  @@ -42,7 +42,7 @@
  
   # Accept connections on the specified port, default is 6379.
   # If port 0 is specified Redis will not listen on a TCP socket.
  -port 6379
  +port 0
  
   # TCP listen() backlog.
   #
  @@ -67,8 +67,8 @@
   # incoming connections. There is no default, so Redis will not listen
   # on a unix socket when not specified.
   #
  -# unixsocket /tmp/redis.sock
  -# unixsocketperm 700
  +unixsocket /tmp/redis.sock
  +unixsocketperm 700
  
   # Close the connection after a client is idle for N seconds (0 to disable)
   timeout 0


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'testing-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.0.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages redis-server depends on:
ii  adduser  3.113+nmu3
ii  init-system-helpers  1.23
ii  libc62.19-18
ii  libjemalloc1 3.6.0-3
ii  redis-tools  2:3.0.3-2

redis-server recommends no packages.

redis-server suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#793444: apt: jessie-backports non-free i386 packages causes "Falling back to normal index file acquire" error

2015-07-27 Thread Chris Kuehl
Hi David,

On Mon, Jul 27, 2015 at 11:35:39AM +0200, David Kalnischkies wrote:
> If apt detects that downloading the patches would be too wasteful
> compared to just downloading the entire index (e.g. all patches needed
> are combined bigger than the index itself) or that there are in fact no
> patches to apply as it already has the latest file it will "fail" pdiff
> and falls back to the normal index file acquire.

Thanks so much for your detailed response -- this is super helpful.

It looks like a simple workaround for the time being (assuming you don't
mind sacrificing pdiffs) is:

echo 'Acquire::PDiffs "false";' > /etc/apt/apt.conf.d/99local

This has silenced all of our machines :)

Thanks for your work on Debian!
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#793656: ITP: aspy.yaml -- extensions to pyyaml

2015-07-26 Thread Chris Kuehl
Oops, typo.

On Sat, Jul 25, 2015 at 9:30 PM, Chris Kuehl  wrote:
> * Package name : python-pyyaml

This should read "aspy.yaml" not "python-pyyaml".

Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#793656: ITP: aspy.yaml -- extensions to pyyaml

2015-07-25 Thread Chris Kuehl
Package: wnpp
Severity: wishlist
Owner: Chris Kuehl 

Howdy folks,

I hope to package and maintain aspy.yaml, a set of extensions to the Python
module pyyaml.

* Package name : python-pyyaml
  Version  : 0.2.1
  Upstream Author  : Anthony Sottile
* URL  : https://github.com/asottile/aspy.yaml
* License  : Expat
  Programming Lang : Python
  Description  : a set of extensions to pyyaml

aspy.yaml adds some interesting extensions to pyyaml such as ordered
loading/saving of YAML, which is useful for modifying hand-written YAML without
clobbering formatting or shuffling keys.

It is a dependency of neat projects such as pre-commit [1].

Cheers,
Chris

[1] http://pre-commit.com/


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#793655: ITP: pre-commit -- a multi-language package manager for git pre-commit hooks

2015-07-25 Thread Chris Kuehl
Package: wnpp
Severity: wishlist
Owner: Chris Kuehl 

Howdy folks,

I hope to package and maintain pre-commit, a multi-language package manager for
git pre-commit hooks.

* Package name : pre-commit
  Version  : 0.5.4
  Upstream Author  : Anthony Sottile, Ken Struys
* URL  : http://pre-commit.com/
* License  : Expat
  Programming Lang : Python
  Description  : a multi-language package manager for git pre-commit hooks

Cheers,
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#793444: apt: jessie-backports non-free i386 packages causes "Falling back to normal index file acquire" error

2015-07-23 Thread Chris Kuehl
Package: apt
Version: 1.0.9.8
Severity: normal

Howdy maintainers,

I've found what I believe to be a strange bug, either with apt or with
the current Debian apt repository.

We are seeing strange lines in our stderr when we run `apt-get update`:

Falling back to normal index file acquire

This has been happening since July 15 and never before.

I found a way to reproduce the problem on our machines:

$ rm 
/var/lib/apt/lists/mirrors.ocf.berkeley.edu_debian_dists_jessie-backports_non-free_binary-i386_Packages
$ apt-get update > /dev/null  # no complaints
$ apt-get update > /dev/null  # complains again!

I confirmed that our copy of the Packages file matches
http://ftp.us.debian.org/debian/dists/jessie-backports/non-free/binary-i386/Packages.gz
(currently SHA1 of 59fa80b71ee5c40948bb7f2a97e209b9eb97b443 un-gzipped)

This can be replicated in a clean jessie VM like so:

  1. dpkg --add-architecture i386
  2. echo 'deb http://ftp.us.debian.org/debian/ jessie-backports non-free' >> 
/etc/apt/sources.list
  3. apt-get update > /dev/null  # this one works
  4. apt-get update > /dev/null  # now we get a complaint to stderr

(Your apt config must not store Packages files gzipped. If you're
testing with the "official" Debian Docker images, you'll want to run
`rm /etc/apt/apt.conf.d/docker*` first.)

I can't find any immediate problems with the Packages file, so I'm not
sure where this bug is happening. Hopefully you can direct this to the
right place if it's not a bug in apt.

Many thanks!
Chris


-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages apt depends on:
ii  debian-archive-keyring  2014.3
ii  gnupg   1.4.18-7
ii  libapt-pkg4.12  1.0.9.8
ii  libc6   2.19-18
ii  libgcc1 1:4.9.2-10
ii  libstdc++6  4.9.2-10

apt recommends no packages.

Versions of packages apt suggests:
pn  apt-doc 
ii  aptitude0.6.11-1+b1
ii  dpkg-dev1.17.25
ii  python-apt  0.9.3.11

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#792010: ITP: nodeenv -- Node.js virtual environment builder

2015-07-09 Thread Chris Kuehl
Package: wnpp
Severity: wishlist

Howdy folks,

I hope to package and maintain nodeenv, a tool to create isolated
node.js environments.

* Package name : nodeenv
  Version  : 0.13.2
  Upstream Author  : Eugene Kalinin
* URL  : https://ekalinin.github.io/nodeenv/
* License  : BSD-3-clause
  Programming Lang : Python
  Description  : Node.js virtual environment builder

Cheers,
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#789871: unscd: installs /usr/sbin/nscd binary without corresponding man page

2015-06-24 Thread Chris Kuehl
Package: unscd
Version: 0.51-1+b2
Severity: wishlist

Howdy maintainer,

unscd provides the binary /usr/sbin/nscd but does not appear to provide
a corresponding man page. It's my understanding from policy [1] that
this warrants a bug.

Happy Wednesday, and thanks for your work on Debian!
Chris

[1] https://www.debian.org/doc/debian-policy/ch-docs.html#s12.1

-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages unscd depends on:
ii  libc6  2.19-18

unscd recommends no packages.

unscd suggests no packages.

-- Configuration Files:
/etc/nscd.conf changed [not included]

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#786854: Incorrect quote handling breaks "--rsync-path" option in rsync_long_args

2015-05-25 Thread Chris Kuehl
tag 786854 + fixed-upstream patch
found 786854 1.3.1-4
found 786854 1.3.1-6
found 786854 1.3.1-7
thanks

Hi again,

It looks like this was fixed upstream by this change:
https://github.com/rsnapshot/sourceforge-issues/issues/23

I confirmed that the latest version of upstream rsnapshot (from the
GitHub repo) does not have the problem.

I've attached a patch that applies the fix to the latest version of the
Debian package, and confirmed it fixed the issue. It is also available
in a git repo for convenience:
https://github.com/ocf/rsnapshot/commit/81e1f15f53017a99aeb5ab4fb7f314797bff1faf

Hope this is helpful -- I'd be more than happy to help with testing of
any changes!

Many thanks, and happy Monday!
Chris
>From 2a4f78351d9dcedad6e1780429452b0eb3472b59 Mon Sep 17 00:00:00 2001
From: Chris Kuehl 
Date: Mon, 25 May 2015 22:38:41 -0700
Subject: [PATCH] Fix handling of rsync_long_args

---
 debian/changelog |  7 +++
 debian/patches/20_split_long_args_remove_quotes.diff | 19 +++
 debian/patches/series|  1 +
 3 files changed, 27 insertions(+)
 create mode 100644 debian/patches/20_split_long_args_remove_quotes.diff

diff --git a/debian/changelog b/debian/changelog
index 60633b3..24b22cb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+rsnapshot (1.3.1-7ocf1) UNRELEASED; urgency=medium
+
+  * Add debian/patches/20_split_long_args_remove_quotes.diff to fix handling on
+rsync_long_args.
+
+ -- Chris Kuehl   Mon, 25 May 2015 22:18:54 -0700
+
 rsnapshot (1.3.1-7) unstable; urgency=medium
 
   * Remove obsolete conffiles anacron scripts (Closes: #767124)
diff --git a/debian/patches/20_split_long_args_remove_quotes.diff b/debian/patches/20_split_long_args_remove_quotes.diff
new file mode 100644
index 000..695b535
--- /dev/null
+++ b/debian/patches/20_split_long_args_remove_quotes.diff
@@ -0,0 +1,19 @@
+From: Matt McCutchen 
+Subject: Implement quote removal in split_long_args_with_quotes
+Forwarded: yes, https://github.com/rsnapshot/rsnapshot/pull/23
+Bug-Debian: https://bugs.debian.org/786854
+
+--- a/rsnapshot-program.pl
 b/rsnapshot-program.pl
+@@ -3778,8 +3778,9 @@
+ # in quotes and got a close quote
+ 	} elsif($thischar eq $inquotes) {
+ 	$inquotes = '';
+-}
+-	$stack[-1] .= $thischar;
++} else {
++	$stack[-1] .= $thischar;
++	}
+ 	}
+ 	if($inquotes) {
+ 	print_err("Unbalanced quotes in $argname", 1);
diff --git a/debian/patches/series b/debian/patches/series
index b1b69f1..4a9fb12 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -14,3 +14,4 @@
 17_linux_lvm_cmd_lvremove_silenced.diff
 18_rsnapreport_rsync_output.diff
 19_cmd_postexec_umount.diff
+20_split_long_args_remove_quotes.diff
-- 
1.9.1



Bug#786854: Incorrect quote handling breaks "--rsync-path" option in rsync_long_args

2015-05-25 Thread Chris Kuehl
Subject: rsnapshot: Incorrect quote handling breaks "--rsync-path" option in 
rsync_long_args
Package: rsnapshot
Version: 1.3.1-7
Severity: normal
Tags: upstream

Hi maintainer,

rsnapshot on jessie and sid (versions 1.3.1-4, 1.3.1-6, and 1.3.1-7) appear to
handle quotes in rsync_long_args incorrectly, preventing passing arguments
like:

--rsync-path="sudo rsync"

...which makes many backup scenarios much harder.

I have attached an rsnapshot.conf which exhibits the problem. For
simplicity of testing, it tries to use --rsync-path="env rsync".

To test, change the backup point at the bottom to some server you have
access to and run `rsnapshot -v -c rsnapshot.conf sync`. Output should
be similar to:

$ rsnapshot -vc rsnapshot.conf sync
echo 4160 > /tmp/rsnapshot.pid
/usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \
--rsync-path="env rsync" --rsh=/usr/bin/ssh ckuehl@supernova:~/bin \
/tmp/backup/.sync/test/
zsh:1: command not found: env rsync
rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
rsync error: error in rsync protocol data stream (code 12) at io.c(226) 
[Receiver=3.1.1]

rsnapshot encountered an error! The program was invoked with these options:
/usr/bin/rsnapshot -vc rsnapshot.conf sync

ERROR: /usr/bin/rsync returned 12 while processing ckuehl@supernova:~/bin
touch /tmp/backup/.sync/
rm -f /tmp/rsnapshot.pid

The "zsh:1: command not found: env rsync" suggests over-quoting (the same
appears when using bash or dash as the shell).

The test case works fine in wheezy (version 1.3.1-3).

Many thanks!
Chris


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages rsnapshot depends on:
ii  liblchown-perl  1.01-2+b1
ii  logrotate   3.8.7-2
ii  perl5.20.2-6
ii  rsync   3.1.1-3

Versions of packages rsnapshot recommends:
ii  openssh-client [ssh-client]  1:6.7p1-6

rsnapshot suggests no packages.

-- no debconf information
config_version  1.2

cmd_cp  /bin/cp
cmd_rm  /bin/rm
cmd_rsync   /usr/bin/rsync
cmd_ssh /usr/bin/ssh
cmd_logger  /usr/bin/logger

rsync_long_args --delete --numeric-ids --relative --delete-excluded 
--rsync-path="env rsync"

sync_first  1

lockfile/tmp/rsnapshot.pid

# backup root directory
snapshot_root   /tmp/backup/

# backup intervals (must be in ascending order)
retain  daily   7
retain  weekly  4
retain  monthly 6

# backup points/scripts
backup  ckuehl@supernova:~/bin  test/


Bug#744145: your mail

2015-03-11 Thread Chris Kuehl
Hi again,

On Wed, Feb 25, 2015 at 04:41:36PM -0500, Barry Warsaw wrote:
> I have committed a fix for this to python-pip's svn and sent a message with
> the relevant details to debian-python@.  The bug and its fix are pretty
> simple.  Instead of only putting the .whl files early on sys.path when inside
> a venv, we should be doing that in all cases.  The only inside/outside
> difference is the location of the wheel files.

Awesome, thanks so much for getting this fix into jessie; it's been very
helpful for us.

I'm sure you're aware of this, but just adding a little info in case
someone stumbles across this bug and wonders why it isn't working for
them: wheel files aren't normally installed, so the fix will only work
if you've installed the -whl packages needed. In our case, installing
python-requests-whl fixed the problem (but maybe as time goes on, more
could become necessary if modules' APIs change in newer versions).

Happy Wednesday,
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#768133: evince won't print landscape PDFs

2015-03-05 Thread Chris Kuehl
Hi Samuel,

On Thu, Mar 05, 2015 at 04:14:35PM +0100, Samuel Wolf wrote:
> is your patch against Evince 3.14.1-1?
> I will build my one Evince version with your patch.
> 
> Need only this one, true?
> https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=65;filename=evince-768133.debdiff;att=1;bug=768133

Yes, that's correct. The debdiff is against the current source package
(3.14.1-1) and applies the same fix (namely, reverting a commit which
broke the printing) that upstream already applied.

You can also find binary packages on apt.ocf.berkeley.edu, if that would
be helpful (version 3.14.1-1ocf2).

Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#750586: Problem continues to exist

2015-02-16 Thread Chris Kuehl
Hi again,

On Sun, Feb 15, 2015 at 03:21:49PM +0100, Cyril Brulebois wrote:
> It would be helpful if either of you could try and figure out what's
> going on/why Ron's patch is insufficient/what needs to be changed to
> get your usecase to work. At least Chris Kuehl (cc'd) was happy with
> the change.

Indeed, we have had no problems in the past few months.

I also just tested both the latest daily as well as the RC1 netboot
images on i386 and amd64 and can't replicate the problem on any
combination.

Thanks for your work on Debian.

Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#765577: (no subject)

2015-02-06 Thread Chris Kuehl
Hi Christof,

On Fri, Feb 06, 2015 at 08:30:58AM +0100, Christof Böckler wrote:
> Maybe it is has to do with the presence of a second networking device?

The devices I tested on (which had a 100% reproducibility rate) all had
a single network card. So maybe it's possible that's the reason you
don't see the same level of occurrence.

Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#768133: evince won't print landscape PDFs

2015-02-04 Thread Chris Kuehl
Control: severity -1 grave

Hi again,

I'm going to raise this bug severity, as PDF printing is one of evince's
main features. I think that if we release jessie without PDF printing in
the default desktop, it should be because of a deliberate decision,
rather than because this bug flew under the radar.

Please see my previous mail above for a short summary of the bug. We can
fix it by reverting a single commit, which has already been done by
upstream and Fedora. I provided a debdiff in my last mail.

Many thanks,
Chris


On Mon, Feb 02, 2015 at 05:52:23PM -0800, Chris Kuehl wrote:
> [4] Fedora bug report:
> https://git.gnome.org/browse/evince/commit/?id=69b474fce1a87a0839e1f541f1297492e47c7c31

Sorry, wrong link. Try this one:
https://bugzilla.redhat.com/show_bug.cgi?id=1173832


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#768133: evince won't print landscape PDFs

2015-02-02 Thread Chris Kuehl
Hi all,

Just wanted to provide some additional context on this bug.

The current version of evince in jessie/sid will not print landscape
PDFs (at least, none that I've tried). Instead, the pages print blank.

It's possible to print the pages by un-checking ``Auto-rotate and
center'' (which is checked by default), but as expected, the page will
be oriented and positioned incorrectly, making the print basically
unusable. I haven't found a way to workaround the bug without resorting
to something like Okular or command-line tools.

An evince developer (Carlos Garcia Campos) states on 2015-01-28 in the
upstream bug [1] [2] [3]:
> Having a proper fix for this is taking more time than I expected, so
> I've just reverted the patch that introduced this regression in both
> branches until we find a proper solution in both Evince and GTK+. This
> is now fixed, use bug #734788 for new discussions or patches to the
> centering option when having a manual scale.

There is also a Fedora bug report [4], where the maintainer reverted the
commit which caused it.

So, it seems the best step forward is to follow upstream and Fedora, and
revert this commit. I've attached a debdiff which reverts it, and tested
it in our busy computer lab for the past few days successfully.

Is there any opposition to marking this bug as release-critical? I know
it's late in the freeze, but I think PDF printing using the default PDF
viewer on the default DE with the default settings should not be broken
in jessie, especially since we have an easy fix by reverting the commit
which caused it. I'm not sure the current severity is appropriate?

I'm happy to help with additional testing.

Many thanks,
Chris

P.S. An easy way to test is to install `printer-driver-cups-pdf`, which
will show the behavior. ``Print to PDF'' in Evince seems to not. There
is a PDF attached to Samuel's first email in this thread which can be
used as a test case.


[1] Upstream bug report
https://bugzilla.gnome.org/show_bug.cgi?id=739723

[2] Upstream revert commit:
https://git.gnome.org/browse/evince/commit/?id=69b474fce1a87a0839e1f541f1297492e47c7c31

[3] Commit which was blamed and reverted by upstream and Fedora:
https://git.gnome.org/browse/evince/commit/?id=ae7a5715131613955a37419b5da1d6d9f3c1cb1d

[4] Fedora bug report:
https://git.gnome.org/browse/evince/commit/?id=69b474fce1a87a0839e1f541f1297492e47c7c31
diff -Nru evince-3.14.1/debian/changelog evince-3.14.1/debian/changelog
--- evince-3.14.1/debian/changelog
+++ evince-3.14.1/debian/changelog
@@ -1,3 +1,10 @@
+evince (3.14.1-1ocf2) UNRELEASED; urgency=medium
+
+  * Add debian/patches/revert-69b474fce1.patch (Closes: #768133)
+    - from upstream git, reverts commit which broke landscape printing
+
+ -- Chris Kuehl   Fri, 30 Jan 2015 16:56:46 -0800
+
 evince (3.14.1-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru evince-3.14.1/debian/patches/revert-69b474fce1.patch 
evince-3.14.1/debian/patches/revert-69b474fce1.patch
--- evince-3.14.1/debian/patches/revert-69b474fce1.patch
+++ evince-3.14.1/debian/patches/revert-69b474fce1.patch
@@ -0,0 +1,116 @@
+From: Carlos Garcia Campos 
+Date: Wed, 28 Jan 2015 09:27:17 +0100
+Subject: Revert "print-operation: Fix centering of documents when printing 
+ with a manual scale"
+
+This reverts commit ae7a5715131613955a37419b5da1d6d9f3c1cb1d.
+
+Fixed the centering of documents when using a manual scale, but it broke
+landscape printing, so reverting until we find a proper fix in both
+Evince and GTK+.
+
+Origin: upstream, https://git.gnome.org/browse/evince/commit/?id=69b474fce1a87a
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=739723
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768133
+
+--- a/libview/ev-print-operation.c
 b/libview/ev-print-operation.c
+@@ -1825,27 +1825,6 @@ _print_context_get_hard_margins (GtkPrin
+ }
+ 
+ static void
+-ev_print_operation_print_get_scaled_page_size (EvPrintOperationPrint *print,
+-   gint   page,
+-   gdouble   *width,
+-   gdouble   *height)
+-{
+-GtkPrintSettings *settings;
+-gdouble   manual_scale;
+-
+-ev_document_get_page_size (EV_PRINT_OPERATION (print)->document,
+-   page, width, height);
+-
+-settings = gtk_print_operation_get_print_settings (print->op);
+-manual_scale = gtk_print_settings_get_scale (settings) / 100.0;
+-if (manual_scale == 1.0)
+-return;
+-
+-*width *= manual_scale;
+-*height *= manual_scale;
+-}
+-
+-static void
+ ev_print_operation_print_draw_page (EvPrintOperationPrint *print,
+   GtkPrintContext   *context,
+   

Bug#744145: [Python-modules-team] Bug#744145: pip3 breaks after upgrading requests

2015-01-26 Thread Chris Kuehl
Hi Stefano,

On Mon, Jan 26, 2015 at 05:12:42AM +0200, Stefano Rivera wrote:
> I don't think I consider this bug to be RC. Debian packages have
> declared dependencies on other Debian packages. Replacing one with
> something newer from upstream, is quite likely to break things.

Thanks for responding. I do understand your reasoning behind not
considering the bug for jessie.

For the sake of documenting this bug better, I probably should have
explained my reasoning a bit clearer. I'm afraid that the impact of the
bug, particularly on upgrades, is likely to be pretty widespread:

* On wheezy, if someone installs requests to system site-packages, pip
  will work fine. After an upgrade to jessie, pip is broken and cannot
  be fixed without rm-ing the appropriate directory (pip uninstall won't
  work, either).

* As far as I'm aware, vendorizing (and on Debian, de-vendorizing) is
  new with the version of pip included with jessie, so the behavior that
  installing a different requests version (or some other devendorized
  library, such as colorama) can permanently break pip is new.

* The default option is to install system-wide (i.e. --user is not
  implicit for non root, #725848), and site-packages installs are still
  very common, especially when one desires to have a Python binary
  packaged on PyPI installed system-wide.

It's very easy for a user to back themselves into a corner, especially
given that once requests has been installed, there is no easy or
obvious way to fix pip.

I wonder whether such a change should at least be documented in the
release notes, even if we can't address it because of the freeze?

> "sudo pip" on a Debian box is dangerous, don't do that, and rather use
> virtualenvs, if you need to go off the beaten track.

I agree with this, but I'm afraid that it's still a very common
practice. It's not hard to find articles advising users to run `pip` as
root, and I suspect that such recommendations will be the first result
when an unsuspecting user searches pip errors on Google.

Thanks and happy Monday,
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#744145: pip3 breaks after upgrading requests

2015-01-23 Thread Chris Kuehl
Hi again maintainer,

As Yannick suggests, this seems to have been caused by this change to requests
back in July:
https://github.com/kennethreitz/requests/commit/47d0517d66e8cf5832768262221f0357ae134ad1

Now that requests.compat no longer imports IncompleteRead, it won't be
available for pip to use.

There are two sequential commits in pip which remove its use of
IncompleteRead:

https://github.com/pypa/pip/commit/53eab2357e4425436b51e109bfaedcb9f3772072
https://github.com/pypa/pip/commit/e77c0c573c059bb4a86b2c5c06835f57e4af6c47

These were merged as part of the PR: https://github.com/pypa/pip/pull/2024

Unfortunately, the commits themselves don't contain much context for the
change. It looks like it was perhaps made to satisfy CI warnings?

On Tue, Oct 21, 2014 at 10:14:49PM +0200, Yannick Roehlly wrote:
> A quick fix would be to use "from httplib import IncompleteRead" in the
> de-vendorize.patch (even if the IncompleteRead will not be raised by requests
> any more).

I've attached a patch that does this (with a minor change to support Python3),
and tested that it works.

I've also attached a patch which backports the two pip commits into the current
python-pip source package.

Both of these fix the current problem, and allow pip to work with both the
version of requests the Debian package, and the current version from PyPI,
which is likely to be installed by users. I'm not sure which is preferable, so
I've included both (only one should be applied, of course).

> Note that there may be other problems with pip using the upgraded requests.

This is probably also worth reiterating. I wonder how hard it would be to
change system pip to always use system versions of libraries. There's no
guarantee that a change to the internals of requests doesn't break pip again
tomorrow.

Thanks again!
Chris


On Fri, Jan 23, 2015 at 01:34:16AM -0800, Chris Kuehl wrote:
> Hi maintainer,
> 
> I am able to reproduce this reliably.
> 
> On a clean jessie or sid system (does not happen on wheezy):
> 
> root# apt-get install python3 python3-pip
> root# pip3 install --upgrade requests
> 
> After this, every invocation of pip3 fails:
> 
> root# pip3
> Traceback (most recent call last):
>   File "/usr/bin/pip3", line 9, in 
> load_entry_point('pip==1.5.6', 'console_scripts', 'pip3')()
>   File "/usr/lib/python3/dist-packages/pkg_resources.py", line 356, in 
> load_entry_point
> return get_distribution(dist).load_entry_point(group, name)
>   File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2476, in 
> load_entry_point
> return ep.load()
>   File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2190, in 
> load
> ['__name__'])
>   File "/usr/lib/python3/dist-packages/pip/__init__.py", line 61, in 
> 
> from pip.vcs import git, mercurial, subversion, bazaar  # noqa
>   File "/usr/lib/python3/dist-packages/pip/vcs/mercurial.py", line 9, in 
> 
> from pip.download import path_to_url
>   File "/usr/lib/python3/dist-packages/pip/download.py", line 25, in 
> 
> from requests.compat import IncompleteRead
> ImportError: cannot import name 'IncompleteRead'
> 
> The version of requests which the upgrade installs is currently 2.5.1.
> 
> This renders pip unusable for many cases, and can break not just pip but
> also other Python packages. In particular, any Python package that
> depends on requests which you upgrade using system pip will permanently
> break pip.
> 
> Thanks for looking into this -- I'm more than happy to help with testing
> any fixes!
> 
> Happy Friday,
> Chris
From: Chris Kuehl 
Date: Fri, 23 Jan 2015 14:54:24 -0800
Subject: [PATCH] Don't raise IncompleteRead if response reads fails

This is a backport of the following commits onto the python-pip package.

https://github.com/pypa/pip/commit/53eab2357e4425436b51e109bfaedcb9f3772072
https://github.com/pypa/pip/commit/e77c0c573c059bb4a86b2c5c06835f57e4af6c47

This fixes Debian bug#744145 by allowing pip to continue to work with
upgraded versions of the requests library.
---
 pip/download.py | 35 +++
 1 file changed, 27 insertions(+), 8 deletions(-)

diff --git a/pip/download.py b/pip/download.py
index adff2ec..768e7ba 100644
--- a/pip/download.py
+++ b/pip/download.py
@@ -22,8 +22,7 @@ from pip.log import logger
 import requests, six
 from requests.adapters import BaseAdapter
 from requests.auth import AuthBase, HTTPBasicAuth
-from requests.compat import IncompleteRead
-from requests.exceptions import InvalidURL, ChunkedEncodingError
+from requests.exceptions import InvalidUR

Bug#744145: pip3 breaks after upgrading requests

2015-01-23 Thread Chris Kuehl
Hi maintainer,

I am able to reproduce this reliably.

On a clean jessie or sid system (does not happen on wheezy):

root# apt-get install python3 python3-pip
root# pip3 install --upgrade requests

After this, every invocation of pip3 fails:

root# pip3
Traceback (most recent call last):
  File "/usr/bin/pip3", line 9, in 
load_entry_point('pip==1.5.6', 'console_scripts', 'pip3')()
  File "/usr/lib/python3/dist-packages/pkg_resources.py", line 356, in 
load_entry_point
return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2476, in 
load_entry_point
return ep.load()
  File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2190, in load
['__name__'])
  File "/usr/lib/python3/dist-packages/pip/__init__.py", line 61, in 

from pip.vcs import git, mercurial, subversion, bazaar  # noqa
  File "/usr/lib/python3/dist-packages/pip/vcs/mercurial.py", line 9, in 

from pip.download import path_to_url
  File "/usr/lib/python3/dist-packages/pip/download.py", line 25, in 

from requests.compat import IncompleteRead
ImportError: cannot import name 'IncompleteRead'

The version of requests which the upgrade installs is currently 2.5.1.

This renders pip unusable for many cases, and can break not just pip but
also other Python packages. In particular, any Python package that
depends on requests which you upgrade using system pip will permanently
break pip.

Thanks for looking into this -- I'm more than happy to help with testing
any fixes!

Happy Friday,
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#773927: nss-updatedb: fix minor typo in man page

2014-12-25 Thread Chris Kuehl
Package: nss-updatedb
Version: 10-3+b1
Severity: minor

Howdy maintainer,

There is a minor typo in the man page; Berkeley is spelled without its
second e!

I've attached a patch to fix it.

Cheers and many thanks!

Chris Kuehl
Open Computing Facility
University of California, Berkeley :-)


-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages nss-updatedb depends on:
ii  libc6 2.19-13
ii  libdb5.3  5.3.28-7~deb8u1

Versions of packages nss-updatedb recommends:
ii  libnss-db  2.2.3pre1-5+b3

nss-updatedb suggests no packages.

-- no debconf information
From: Chris Kuehl 
Date: Thu, 25 Dec 2014 11:46:49 -0800
Subject: [PATCH] Fix misspelled "Berkeley" in man page

---
 nss_updatedb.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nss_updatedb.8 b/nss_updatedb.8
index 4cb744d..a34ca92 100644
--- a/nss_updatedb.8
+++ b/nss_updatedb.8
@@ -179,7 +179,7 @@ nss_updatedb \- cache name service directories in DB format
 \fBnss_updatedb\fR \fInameservice\fR [\fIpasswd\fR|\fIgroup\fR]
 .SH "DESCRIPTION"
 The \fInss_updatedb\fR program gathers entries from the specified
-\fInameservice\fR and stores it into a local database in Berkley DB format. It
+\fInameservice\fR and stores it into a local database in Berkeley DB format. It
 can store \fIpasswd\fR and \fIgroup\fR information.
 .SH "AUTHOR"
 \fInss_updatedb\fR was written by Luke Howard 
-- 
2.1.3



Bug#772598: steam: install fails if debconf selections are already set

2014-12-08 Thread Chris Kuehl
Package: steam
Version: 1.0.0.49-1
Severity: normal
Tags: patch

Hi maintainer,

I'm trying to automate the installation of the steam package by
preseeding the debconf selections needed to accept the license
agreement. The installation fails every time I try:

root@eruption:~# cat selections
steam   steam/question  select  I AGREE
steam   steam/license   note
root@eruption:~# debconf-set-selections < selections
root@eruption:~# apt-get install steam
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  steam:i386
0 upgraded, 1 newly installed, 0 to remove and 149 not upgraded.
Need to get 0 B/835 kB of archives.
After this operation, 2,689 kB of additional disk space will be used.
Preconfiguring packages ...
Selecting previously unselected package steam.
(Reading database ... 260307 files and directories currently installed.)
Preparing to unpack .../steam_1.0.0.49-1_i386.deb ...
dpkg: error processing archive 
/var/cache/apt/archives/steam_1.0.0.49-1_i386.deb (--unpack):
 subprocess new pre-installation script returned error exit status 30
Installation terminated: Steam License Agreement was DECLINED.
Errors were encountered while processing:
 /var/cache/apt/archives/steam_1.0.0.49-1_i386.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

I'm not prompted to accept the license agreement; the install just fails
immediately.

Bug #757524 had a similar issue, but I believe the resolution ("You have
two spaces between select and I") was incorrect, as using a single space
doesn't fix the problem. Additionally, I generated the selections from
debconf-get-selections, so the formatting should be correct.

My understanding of debconf might be flawed, but I believe this is
because the db_input prompts will fail if the selection has already been
preseeded (or if the user can't be prompted).

The ``Debconf Programmer's Tutorial'' [1] uses `|| true` after each
invocation of db_input. I've attached a patch that updates the steam
package source to do this.

With the patch applied, I am able to install steam both normally (no
preseeds) and with the preseeded selections.

Many thanks!
Chris

[1] http://www.fifi.org/doc/debconf-doc/tutorial.html



-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages steam depends on:
ii  debconf [debconf-2.0] 1.5.54
ii  libc6 2.19-13
ii  libgl1-mesa-dri   10.3.2-1
ii  libgl1-mesa-glx   10.3.2-1
ii  libstdc++64.9.1-19
ii  libtxc-dxtn-s2tc0 [libtxc-dxtn0]  0~git20131104-1.1
ii  libudev1  215-7
ii  libx11-6  2:1.6.2-3
ii  libxinerama1  2:1.1.3-1+b1
ii  xfce4-terminal [x-terminal-emulator]  0.6.3-1+b1
ii  xterm [x-terminal-emulator]   312-1
ii  xz-utils  5.1.1alpha+20120614-2+b2

Versions of packages steam recommends:
ii  fonts-liberation  1.07.4-1
ii  zenity3.14.0-1

steam suggests no packages.

-- debconf information:
* steam/question: I AGREE
  steam/purge:
* steam/license:
From: Chris Kuehl 
Date: Mon, 8 Dec 2014 14:58:01 -0800
Subject: [PATCH] Allow dh_input to fail without aborting install

dh_input will fail if the user has already preseeded debconf selections,
or if the user can't be prompted during installation.

Rather than fail the install script (since we set -e), we should proceed
normally and allow the "I AGREE" check to fail (in case the user really
couldn't be prompted).

Without this change, preseeding debconf selections results in the
install failing immediately every time.
---
 debian/postrm  | 2 +-
 debian/preinst | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/postrm b/debian/postrm
index 9b38aec..2440320 100644
--- a/debian/postrm
+++ b/debian/postrm
@@ -10,7 +10,7 @@ if [ "$1" = "abort-install" ]; then
 fi
 
 if [ "$1" = "purge" ]; then
-db_input high steam/purge
+db_input high steam/purge || true
 db_go
 fi
 
diff --git a/debian/preinst b/debian/preinst
index e8479e6..36a330a 100644
--- a/debian/preinst
+++ b/debian/preinst
@@ -4,8 +4,8 @@ set -e
 . /usr/share/debconf/confmodule
 
 if [ "$1" = "install" ]; then
-db_input high steam/license
-db_input high steam/question
+db_input high steam/license || true
+db_input high steam/question || true
 db_go
 db_get steam/question
 test "$RET" = "I AGREE"
-- 
2.1.3



Bug#765577: udev-udeb: Write dupliate entries into 70-persistent-net.rules

2014-11-17 Thread Chris Kuehl
Hi all,

Petter and Michael, thanks for your work on this!

I'm able to reproduce this bug consistently (100% of the time, having
run ~40 installations in the past week that exhibit it) with the
following steps:

1. PXE boot a jessie netboot image (latest daily build, for example)
2. Add auto=true to the install menu option and run it.
3. Stop the installation (or switch to another TTY) and look at
   /etc/udev/rules.d/70-persistent-net.rules (in the installer
   environment, not under /target). The duplicate entry is present
   already, and will make its way into the target system during
   installation.

The entry always appears for me when I use auto=true. I have not seen it
appear without this option, but I haven't tested non-auto installs
extensively.

It happens even if we temporarily disable d-i preseeding from our DHCP
server.

On Tue, Oct 21, 2014 at 11:07:51AM +0200, Petter Reinholdtsen wrote:
> Perhaps it only happen on fairly quick machines?  I experience it on a
> Thinkpad X200 and X300, but not on a 10 year old Latitude D505. :(

It's possible that all of the hardware I'm testing on is too fast, but
having performed many installs, I'm yet to see this not happen when
auto=true is set.

I've tested jessie installs on about 20 different systems (mix of ~15
new and old desktops, plus some KVM and VirtualBox guests), and seen
this happen reliably on all of them.

I wasn't able to narrow down the source of the duplicate entries in the
code, despite some attempts at bisecting what I was hoping might be
relevent parts of d-i.

CCing debian-boot and adding the d-i tag, as I believe there's a good
chance it is relevant to this bug. Apologies if that's unnecessary!

Thanks and happy Monday,
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#759737: debian-installer: Need preseed entry to select default grub device

2014-11-17 Thread Chris Kuehl
Hi all,

Andrew's patch looks very reasonable to me, as it would allow sysadmins
to fully automate installs without further complicating the issues
raised in #712907 (which mostly affect interactive installs).

I've spent a few hours attempting to test the patch, but can't seem to
properly integrate my locally-built grub-installer udeb into a netboot
build (either via localudebs or by downloading and unpacking the udeb
manually from the installer shell). I strongly suspect my own
incompetence is to blame, though, and not the patch.

I might be missing something, but we can't seem to find any other way to
fully automate jessie installs via preseeding, like we could with
wheezy. (For context, our physical machines are split between using
/dev/sda and /dev/sde for the first hard drive, while VirtualBox uses
/dev/sda and KVM /dev/vda.)

I wonder whether the severity of this bug should be raised to important?
I suspect that automating installs is an important feature for many
other d-i users, so I'm not sure wishlist is appropriate for this bug.

I'm going to continue attempting to test the patch, and report back if I
have any luck.

Many thanks!
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#768133: evince print only blank page / okular work with the same pdf

2014-11-15 Thread Chris Kuehl
Hi maintainer,

We also experience this bug (exact same symptoms as Samuel) with evince
3.14.1-1 on jessie. All PDFs that I have tested fail to print when "Auto
Rotate & Center" is checked in the print settings.

On Fri, Nov 14, 2014 at 10:55:56PM +0100, Samuel Wolf wrote:
> there is a possible patch [1] for this issue:
> https://bugzilla.gnome.org/show_bug.cgi?id=739723

I tested applying this patch from Samuel's bug report:
https://bug739723.bugzilla-attachments.gnome.org/attachment.cgi?id=290722

It applies cleanly. After rebuilding and installing the package locally,
the issue appears to be fixed, and printing seems to be working reliably
across our ~15 jessie workstations (which print many hundreds of PDFs).

Is there anything I could do to help get this bug patched? We'd be happy
to help with any additional testing.

Many thanks!
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#769621: puppet: USR1 fails to trigger agent run

2014-11-14 Thread Chris Kuehl
Package: puppet
Version: 3.7.2-1
Severity: normal
Tags: upstream

Hi maintainer,

We normally use `kill -USR1` on the puppet agent process to trigger an agent
run without restarting the process.

When attempting this on jessie (rather than wheezy), a run is not triggered,
and the following is logged to syslog:

> Nov 14 21:10:48 eruption puppet-agent[21975]: Caught USR1; calling reload
> Nov 14 21:10:48 eruption puppet-agent[12969]: Could not autoload 
> puppet/indirector/node/rest: current thread not owner
> Nov 14 21:10:48 eruption puppet-agent[12969]: Unable to fetch my node 
> definition, but the agent run will continue:
> Nov 14 21:10:48 eruption puppet-agent[12969]: Could not autoload 
> puppet/indirector/node/rest: current thread not owner
> Nov 14 21:10:48 eruption puppet-agent[12969]: Could not autoload 
> puppet/feature/external_facts: current thread not owner
> Nov 14 21:10:48 eruption puppet-agent[12969]: Failed to apply catalog: Could 
> not autoload puppet/feature/external_facts: current thread not owner

This is upstream bug PUP-1635:
https://tickets.puppetlabs.com/browse/PUP-1635

The bug is also present when we use the Puppetlabs APT repository (rather than
the Debian jessie archive), which contains version 3.7.3-1puppetlabs1 of
puppet.

Many thanks,
Chris



-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages puppet depends on:
ii  init-system-helpers 1.21
ii  puppet-common   3.7.2-1
ii  ruby1:2.1.0.4
ii  ruby2.1 [ruby-interpreter]  2.1.4-1

puppet recommends no packages.

Versions of packages puppet suggests:
pn  etckeeper   
pn  puppet-el   
pn  vim-puppet  

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#767576: lightdm-gtk-greeter: user supplied default-user-image does not display properly in lightdm-gtk-greeter

2014-11-01 Thread Chris Kuehl
Package: lightdm-gtk-greeter
Version: 1.8.5-1
Severity: normal

Hi maintainer,

Specifying a default-user-image in /etc/lightdm/lightdm-gtk-greeter.conf has no
effect when greeter-hide-users=true is set in /etc/lightdm/lightdm.conf.

The no-name default user image still shows in the greeter, even though I have
specified an alternative image in the config file to be shown.

This was reported on Launchpad:
https://bugs.launchpad.net/ubuntu/+source/lightdm-gtk-greeter/+bug/1317236

and has been fixed upstream:
http://bazaar.launchpad.net/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk/revision/281

Upstream version 1.9.0 should contain the fix.

Many thanks,
Chris


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lightdm-gtk-greeter depends on:
ii  libc6   2.19-12
ii  libcairo2   1.12.16-5
ii  libgdk-pixbuf2.0-0  2.31.1-2+b1
ii  libglib2.0-02.42.0-2
ii  libgtk-3-0  3.14.3-1
ii  liblightdm-gobject-1-0  1.10.3-1
ii  libx11-62:1.6.2-3

Versions of packages lightdm-gtk-greeter recommends:
ii  desktop-base   7.0.3
ii  gnome-icon-theme-symbolic  3.12.0-1
ii  gnome-themes-standard  3.14.0-1
ii  policykit-10.105-7

lightdm-gtk-greeter suggests no packages.

-- Configuration Files:
/etc/lightdm/lightdm-gtk-greeter.conf changed [not included]

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#750586: Bug#756275: debian-installer: [PATCH] Fix lib location and search path for syslinux >= 5

2014-09-21 Thread Chris Kuehl
On Sun, Sep 21, 2014 at 01:57:55PM +0200, Cyril Brulebois wrote:
> Looks like I could just blindly apply both patches, squashing them and
> crediting both of you then?

Yup, I think that would do it.

I can do additional sanity testing of the daily build after the patches
are applied, but already did pretty extensive testing on the netboot
image yesterday with the patches applied.

Thanks!
Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#750586: Bug#756275: debian-installer: [PATCH] Fix lib location and search path for syslinux >= 5

2014-09-20 Thread Chris Kuehl
Hi all,

Thanks for your work on this -- we're also experiencing this bug in both
jessie and sid daily netboot images in our PXE boot environment.

On Thu, Aug 07, 2014 at 01:46:06PM +0200, Cyril Brulebois wrote:
> I could apply it blindly but it'd be nice if someone else would confirm
> it works fine. I've got other things cooking, but I might end up testing
> it myself it nobody steps up.

I might be building the image wrong, but after applying Ron's patch, I
get a symlink like the following in my netboot tarball:

ldlinux.c32 -> 
debian-installer/amd64/debian-installer/amd64/boot-screens//ldlinux.c32

Note that ``d-i/$arch'' is duplicated, and there is an extra slash
before ``ldlinux.c32''.

During my build, the relevant vars were:

NETBOOT_PATH=debian-installer/amd64
BOOT_SCREEN_DIR=debian-installer/amd64/boot-screens/

I've attached a small patch (intended to be applied after Ron's) which
fixes the target path of the symlink on my sid build.

With these two patches applied, the sid netboot image boots and installs
successfully in our environment. I'd be more than happy to help test any
additional work on this issue.

Thanks!
Chris
>From 89f74fdc2893a68d2baba8d13cff4846d92840e8 Mon Sep 17 00:00:00 2001
From: Chris Kuehl 
Date: Sat, 20 Sep 2014 21:00:11 +
Subject: [PATCH] Fix ldlinux.c32 symlink path

The existing symlink creates a target path like:
debian-installer/amd64/debian-installer/amd64/boot-screens//ldlinux.c32

(note the duplicate of "d-i/amd64/" and the double slash after boot-screens)
---
 build/config/x86.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/config/x86.cfg b/build/config/x86.cfg
index 07f99b8..0bcd2a9 100644
--- a/build/config/x86.cfg
+++ b/build/config/x86.cfg
@@ -393,7 +393,7 @@ arch_netboot_dir: x86_syslinux
 	ln -sf $(NETBOOT_PATH)/pxelinux.0 $(TEMP_NETBOOT_DIR)/pxelinux.0
 	# This link is required because pxelinux only looks in the tftp root
 	# for this library (it does a PATH search for any others).
-	ln -sf $(NETBOOT_PATH)/$(BOOT_SCREEN_DIR)/ldlinux.c32 $(TEMP_NETBOOT_DIR)/ldlinux.c32
+	ln -sf $(BOOT_SCREEN_DIR)ldlinux.c32 $(TEMP_NETBOOT_DIR)/ldlinux.c32
 
 	set -e; \
 	$(foreach file,$(wildcard $(TEMP_BOOT_SCREENS)/*.txt), \
-- 
2.1.0



Bug#757899: mirror listing update for mirrors.ocf.berkeley.edu

2014-08-11 Thread Chris Kuehl
Package: mirrors
Severity: minor

Submission-Type: update
Site: mirrors.ocf.berkeley.edu
Type: leaf
Archive-architecture: ALL amd64 armel armhf hurd-i386 i386 kfreebsd-amd64 
kfreebsd-i386 mips mipsel powerpc s390x sparc 
Archive-ftp: /debian/
Archive-http: /debian/
Archive-rsync: debian/
CDImage-ftp: /debian-cd/
CDImage-http: /debian-cd/
CDImage-rsync: debian-cd/
IPv6: no
Archive-upstream: mirrors.kernel.org
CDImage-upstream: mirrors.kernel.org
Updates: four
Maintainer: Chris Kuehl 
Country: US United States
Location: Berkeley, California
Sponsor: Open Computing Facility http://ocf.berkeley.edu/
Comment: Adding debian-cd to existing mirror


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#742390:

2014-03-22 Thread Chris Kuehl
Hi,

> Backports-ftp: /debian/
> Backports-http: /debian/
> Backports-rsync: debian/

Sorry, this is incorrect. We only mirror the main archive, not
backports. Please disregard this.

Available bandwidth is 1Gbps.

Chris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#742390: mirror submission for mirrors.ocf.berkeley.edu

2014-03-22 Thread Chris Kuehl
Package: mirrors
Severity: wishlist

Submission-Type: new
Site: mirrors.ocf.berkeley.edu
Type: leaf
Archive-architecture: ALL amd64 armel armhf hurd-i386 i386 ia64 kfreebsd-amd64 
kfreebsd-i386 mips mipsel powerpc s390x sparc 
Archive-ftp: /debian/
Archive-http: /debian/
Archive-rsync: debian/
Backports-ftp: /debian/
Backports-http: /debian/
Backports-rsync: debian/
IPv6: no
Archive-upstream: mirrors.kernel.org
Backports-upstream: mirrors.kernel.org
Updates: four
Maintainer: Chris Kuehl 
Country: US United States
Location: Berkeley, California
Sponsor: Open Computing Facility http://ocf.berkeley.edu/


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org