Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP
Okay, I have now [after a busy week] added a watch file and uploaded the package again. The mentors page now shows that the package is the latest upstream version. Dan. On 19/10/15 20:36, Gianfranco Costamagna wrote: mmm you need one anyway... I can help you writing one, or you can just look at the uscan manpage (or debian wiki for uscan) and you will find many examples. you might stop being interested in the debian packaging (or find it too difficult to maintain), you might become MIA... people might adopt the package if being orphaned, so having a watch file will guarantee the continuity of the project (Debian side) cheers, G. Sent from Yahoo Mail on Android <https://overview.mail.yahoo.com/mobile/?.src=Android> *From*:"Daniel Bailey" *Date*:Mon, 19 Oct, 2015 at 21:15 *Subject*:Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP Okay, I have added a homepage. I see there is also a watch file warning. Do I need to have a watch file? As I am both the developer and the package maintainer, I suppose I don't need one? Dan. On 19/10/15 13:04, Gianfranco Costamagna wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hi Daniel, > > sorry for the late answer, I guess the package is ready, but I found a > little issue > > P: webdeploy: no-homepage-field > N: > N:This non-native package lacks a Homepage field. If the package > has an > N:upstream home page that contains useful information or resources > for the > N:end user, consider adding a Homepage control field to > debian/control. > N: > N:Refer to Debian Policy Manual section 5.6.23 (Homepage) for detail > s. > N: > N:Severity: pedantic, Certainty: possible > N: > N:Check: fields, Type: binary, udeb, source > N: > > > can you please add the Homepage field to control file? > > we have no watch file, no homepage in control/copyright files, seems > that people won't be able to find updates and find the upstream website. > > cheers, > > G. > -BEGIN PGP SIGNATURE- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJWJNxSAAoJEPNPCXROn13ZGdsQAMuXXbTwzWmme9h+vD1OWaCA > mvJ5CEVCxBWd8xQvrbMvDU/nePbT0swCyUU4ZFt7acaTVu1Ku23DMVwWxSoIgRWK > ljECs/KO6TDohDW6aoPg7t9oCSYTcrb4mMnYg/PzFhB0H/tm2irWPbbY0QamBOhe > ZvfZFUMvwrYdSS3gcJMJ1vmgjdVC6OJBEXOwNOOo2JA0VcFEAaygYaNuy55O5/6o > sGXdr68kuDO62ZDr/3djXsFtj5yASZuVFFHmePmHXs5Yu7mK4RhTmnlchHkzzvta > FzKaaw5OGZ5qbsC1c4sFV2vkfl8PeYfaC3HwnEUsgT2DkM4eWc1D/iRCCj3TaMg8 > NkcactOANCy3I/okpBaxrzLUZ92esASNHfbEp4u8nhHEbaYg0KEzepIvQpNURmMW > d14AM3lGCsia7Ehc1eL69uJkrTHtUjP3qMswlHMwDWlHrlyuxspD9xxRUGp4tUIm > DHJ7ofqNxk8Q+9+gu4b55Xi9MIC2ZWZTanl3w/4Ng4WbaZEDmZtJHp3OUghi7xZU > 0VoHD3EOixHZFSD9ZQ20jhKy2jG1sw/xLs8cTenULJkzk13Lm7UwqZzytjW6XsjY > CNDROZhc2fqqZO/RNX0D5rfInjVfEjWIu0iZRxh2m1Y3IcIMIrZH7n0lSZ+lbjJW > Wf/i7dNgblKzLViC2Kju > =pkiP > -END PGP SIGNATURE- > >
Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP
Okay, I have added a homepage. I see there is also a watch file warning. Do I need to have a watch file? As I am both the developer and the package maintainer, I suppose I don't need one? Dan. On 19/10/15 13:04, Gianfranco Costamagna wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Daniel, sorry for the late answer, I guess the package is ready, but I found a little issue P: webdeploy: no-homepage-field N: N:This non-native package lacks a Homepage field. If the package has an N:upstream home page that contains useful information or resources for the N:end user, consider adding a Homepage control field to debian/control. N: N:Refer to Debian Policy Manual section 5.6.23 (Homepage) for detail s. N: N:Severity: pedantic, Certainty: possible N: N:Check: fields, Type: binary, udeb, source N: can you please add the Homepage field to control file? we have no watch file, no homepage in control/copyright files, seems that people won't be able to find updates and find the upstream website. cheers, G. -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWJNxSAAoJEPNPCXROn13ZGdsQAMuXXbTwzWmme9h+vD1OWaCA mvJ5CEVCxBWd8xQvrbMvDU/nePbT0swCyUU4ZFt7acaTVu1Ku23DMVwWxSoIgRWK ljECs/KO6TDohDW6aoPg7t9oCSYTcrb4mMnYg/PzFhB0H/tm2irWPbbY0QamBOhe ZvfZFUMvwrYdSS3gcJMJ1vmgjdVC6OJBEXOwNOOo2JA0VcFEAaygYaNuy55O5/6o sGXdr68kuDO62ZDr/3djXsFtj5yASZuVFFHmePmHXs5Yu7mK4RhTmnlchHkzzvta FzKaaw5OGZ5qbsC1c4sFV2vkfl8PeYfaC3HwnEUsgT2DkM4eWc1D/iRCCj3TaMg8 NkcactOANCy3I/okpBaxrzLUZ92esASNHfbEp4u8nhHEbaYg0KEzepIvQpNURmMW d14AM3lGCsia7Ehc1eL69uJkrTHtUjP3qMswlHMwDWlHrlyuxspD9xxRUGp4tUIm DHJ7ofqNxk8Q+9+gu4b55Xi9MIC2ZWZTanl3w/4Ng4WbaZEDmZtJHp3OUghi7xZU 0VoHD3EOixHZFSD9ZQ20jhKy2jG1sw/xLs8cTenULJkzk13Lm7UwqZzytjW6XsjY CNDROZhc2fqqZO/RNX0D5rfInjVfEjWIu0iZRxh2m1Y3IcIMIrZH7n0lSZ+lbjJW Wf/i7dNgblKzLViC2Kju =pkiP -END PGP SIGNATURE-
Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP
Ah, okay, no problem. Fixed it. Dan. On 10/10/15 20:29, Gianfranco Costamagna wrote: Hi, nack :) gpl-3+ is different from GPL-3+ It might be a nitpick but I didn't find any other program with that syntax search on codesearch.debian.net GPL-3+ path:/copyright$ vs gpl-3+ path:/copyright$ cheers, G. Il Sabato 10 Ottobre 2015 20:45, Daniel Bailey ha scritto: On 10/10/15 19:06, Gianfranco Costamagna wrote: That was a (sfortunate) issue due to the line wrapping. I thought it would be something like that so, now please use tab instead of spaces in the dh_auto_install target, Oops, my mistake, my editor converted the tab, I've fixed it now. set the distribution to unstable from UNRELEASED Done. update your copyright to a more complete version (you can take example from there) https://sources.debian.net/src/debomatic/0.21-1/debian/copyright/ Done. and we might be good to go. cheers, G. I hope that's everything complete, Thanks for all the help. Dan.
Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP
On 10/10/15 19:06, Gianfranco Costamagna wrote: That was a (sfortunate) issue due to the line wrapping. I thought it would be something like that so, now please use tab instead of spaces in the dh_auto_install target, Oops, my mistake, my editor converted the tab, I've fixed it now. set the distribution to unstable from UNRELEASED Done. update your copyright to a more complete version (you can take example from there) https://sources.debian.net/src/debomatic/0.21-1/debian/copyright/ Done. and we might be good to go. cheers, G. I hope that's everything complete, Thanks for all the help. Dan.
Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP
Okay, I've update the upstream makefile and the rules file as per you suggestion except for the change to the pod2man command which removes the end of the line, that change would break the makefile. Is this is a mistake or is there something I have missed? Thanks, Dan. On 27/09/15 16:48, Gianfranco Costamagna wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Control: owner -1 ! Hi Daniel, I'm not sure what's wrong here, the upstream makefile contains this install rule which installs the script and the man page, have I done something wrong?: install: all install webdeploy $(DESTDIR)$(bindir) install -m 0644 webdeploy.1 $(DESTDIR)$(man1dir) well, it might be good, just I don't like custom makefiles :) 5) install the manpage too. (see above) 6) use debian/dirs to create directories, or fix the Makefile :) Sorry, once again, complete beginner, what is wrong with the makefile here? I'm not sure about perl:Depends, since there is no perl in build dependencies. (also shlibs:depends and so on, because you don't have any shared library) I think this was the result of using dh_perl. I expected it to find the libterm-readkey-perl Requirement but it didn't, It did however add perl as a dependancy. Also, perl is in the build-depends in the control file as it contains the pod2man program for generating the man page. Is there anything I need to change here? Should I remove the shlibs:depends from the control file? I'm not sure about this but well, seems good! Last issues: this is how I would patch the Makefile: - --- webdeploy-1.0.orig/Makefile +++ webdeploy-1.0/Makefile @@ -13,6 +13,7 @@ webdeploy.1: webdeploy pod2man --name=WebDeploy -c"WebDeploy - Deploy files via FTP" - --section=1 --release="Version $(VERSION)" $< > $@ install: all + install -d $(DESTDIR)$(bindir) $(DESTDIR)$(man1dir) install webdeploy $(DESTDIR)$(bindir) install -m 0644 webdeploy.1 $(DESTDIR)$(man1dir) removing the debian/webdeploy.dirs and how I would use the install override: override_dh_auto_install: dh_auto_install -- prefix=/usr what do you think about? cheers, Gianfranco -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWCA+2AAoJEPNPCXROn13ZYYwQAJXA4lKw5y7Wh8IQhCxZStVk PrsdmTDbFN9sSXd0ddy3QVP75IIiZJl0A9mDE8I4UO7NKV4XXh0baw8dsNfgPg6d OxODzMaWPGU7s0POrDVD6FoywKYpnLnvGWvXumBLGQNhKDHP+PU923gVgQ7taXyd EonBLSoorD9iLnR1yH+oNennAaCA2TkQkmMRUrWXbbAZN9cZWYH07k26/qZ8uehA 0adUM67HVaGgCvd4CJ7zYT40h/AqzdnPi9Th1rjfwaEEPOWGARKfpoALN/XeB6OH pazQUmV6MAzTA26kGWAKbZwpwB5t/VsRfF0M+uk3rCucJNedLwp1fj3HT8LIJOyK QQr7NGtWVmt07lZjEBHj0j8hbCOkBCf9/O3DZjABrQKUr/I6bHLOPrVueQdDThpq s5aPLhx9gwj+gEsyP+zSYCZNMWvRqcI/itMlM5mDOOe9y5zMOtlSeUyQ2GvSBCyV ED4QUXSAwPLlYCF0FNG7xNDovVXgYwX73xkn8EgjzAjtBx181dg3Zq8YZboss75b I+P0kCXeE0e5edufRM7IGLV1a+q4ON7K9yv1N0mpwtCcAPtxjEFw6l0KCdU0hOmb ye5ATyuaut8c0D/mXCXHVDERq+jJc0RMprXz5owg8r+n/gBGlg9Lz6ThKVf745cD yLMKglEmjkXvIfUQgEPo =i5qg -END PGP SIGNATURE-
Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP
Thanks for the response, I've fixed some things and was confused by some other things, see inline texts. On 15/09/15 12:06, Gianfranco Costamagna wrote: Hi Daniel, (please upload on mentors.debian.net next time) I was getting some SSL error on mentors.debian.net, I have since got this done. It is now here: https://mentors.debian.net/package/webdeploy 1) changelog: you need to open an ITP bug and set the target distribution to unstable. I've added the "closes ITP bug" info to the changelog 2) control: std-version should be 3.9.6 Done 3) copyright should be in dep5 format https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and include the license. Done 4) rules: please use a debian/install file for installing the binary and build documentation at runtime (or fix the upstream Makefile) I'm not sure what's wrong here, the upstream makefile contains this install rule which installs the script and the man page, have I done something wrong?: install: all install webdeploy $(DESTDIR)$(bindir) install -m 0644 webdeploy.1 $(DESTDIR)$(man1dir) 5) install the manpage too. (see above) 6) use debian/dirs to create directories, or fix the Makefile :) Sorry, once again, complete beginner, what is wrong with the makefile here? I'm not sure about perl:Depends, since there is no perl in build dependencies. (also shlibs:depends and so on, because you don't have any shared library) I think this was the result of using dh_perl. I expected it to find the libterm-readkey-perl Requirement but it didn't, It did however add perl as a dependancy. Also, perl is in the build-depends in the control file as it contains the pod2man program for generating the man page. Is there anything I need to change here? Should I remove the shlibs:depends from the control file? Thanks. Dan. cheers, Gianfranco
