Bug#524175: Acknowledgement (proftpd ignores 'TYPE I' from client, and transfers files as 'ASCII' with resulting data corruption)
Attached is a little diff that fixes the problem, it boils down to this:
if (!opt_STAT) {
// don't change session flags: session.sf_flags |= SF_ASCII_OVERRIDE;
// because if pr_data_open fails, we don't clean up after ourselves and
cause
// side effects to appear
if (pr_data_open(NULL, file list, PR_NETIO_IO_WR, 0) 0)
return -1;
session.sf_flags |= SF_ASCII_OVERRIDE;// instead, change session flags
AFTER pr_data_open
}
--
Dariush Pietrzak,
Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9
--- mod_ls.c.orig 2009-04-16 21:52:12.0 +0200
+++ mod_ls.c2009-04-16 21:52:47.0 +0200
@@ -1408,9 +1408,9 @@
/* Open data connection */
if (!opt_STAT) {
- session.sf_flags |= SF_ASCII_OVERRIDE;
if (pr_data_open(NULL, file list, PR_NETIO_IO_WR, 0) 0)
return -1;
+ session.sf_flags |= SF_ASCII_OVERRIDE;
}
/* If there are no globbing characters in the given target,
@@ -1587,9 +1587,9 @@
/* Open data connection */
if (!opt_STAT) {
- session.sf_flags |= SF_ASCII_OVERRIDE;
if (pr_data_open(NULL, file list, PR_NETIO_IO_WR, 0) 0)
return -1;
+ session.sf_flags |= SF_ASCII_OVERRIDE;
}
if (ls_perms_full(cmd-tmp_pool, cmd, ., NULL)) {
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
You are using kernel patch 1.2.11-rc1? This patch is only for 2.4 kernels, and 2.4 kernels are not supported in etch. Woa, this is new..and huge, AFAIK only 2.2 support is supposed to be dropped from etch: support for 2.2 kernels has been dropped (except for m68k). libc will refuse to be installed on 2.2 kernels, the solution is to install a 2.4 (or a 2.6) kernel before the upgrade. http://wiki.debian.org/NewInEtch If you're right then this is huge and turns debian into desktop distribution, i really hope you have mistaken 2.4 with 2.2. If you make a new kernel using the latest kernel patches, do it work better for you? this is the latest patch. This is *not* the latest patch. This patch is very old. The latest patches are for the 2.6 kernels. I'm not interested in development patches. I'm interested in my machines working reliably. Your 0.30.204 packages are working fine. Can you provide some more details about what doesn't work? vserver-stat doesn't work, you can't start/stop/enter any of running vservers. -- Dariush Pietrzak, Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
Hello,
According to #vserver folks:
13:39 daniel_hozac however, distro packages really ought to build with
--enable-apis=NOLEGACY.
13:39 daniel_hozac (which ironically means to enable the legacy APIs :))
this should fix the problem.
--- debian/rules.orig 2006-09-30 13:42:09.0 +0200
+++ debian/rules2006-09-30 13:42:15.0 +0200
@@ -83,6 +83,7 @@
--infodir=\$${prefix}/share/info \
--sysconfdir=/etc --enable-dietlibc \
--localstatedir=/var \
+ --enable-apis=NOLEGACY \
--with-vrootdir=/var/lib/vservers
build: patch build-stamp
regards,
--
Dariush Pietrzak,
Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
I have made a test build that I want you to test. I have placed it at: http://debian.opal.dhs.org/util-vserver_0.30.210-11_i386.deb It works OK, thanks. just one tiny thing: Setting up util-vserver (0.30.210-11) ... Installing new version of config file /etc/init.d/util-vserver ... /etc/init.d/util-vserver: line 26: [: /etc/vservers/lan.conf: binary operator expected Vserver capability not detected in kernel. this test in util-vserver: if [ -f /etc/vservers/*.conf ] seems to cause error message when there is more then one legacy config active. -- Dariush Pietrzak, Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
quite a large number of debian servers, all running 2.6 fine. However, If you're uninterested and uneffected by the bug #389720( which by the way, has already been fixed) why are you trolling and wasting my and Ola's time? -- Dariush Pietrzak, Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
tags 389720 + unreproducible moreinfo help You seem to have problem with the kernel part. What is the version of the kernel patch that you used for the kernel build? 1.2.11-rc1, If you make a new kernel using the latest kernel patches, do it work better for you? this is the latest patch. Your 0.30.204 packages are working fine. -- Dariush Pietrzak, Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
Hi Your 0.30.204 packages are working fine. I'll see what I can do. Great, thanks. -- Dariush Pietrzak, Key fingerprint = 40D0 9FFB 9939 7320 8294 05E0 BCC7 02C4 75CC 50D9 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#389720: util-vserver stops working after 0.30.204-0.30.210 upgrade
Subject: Complete and unexpected failure after util-vserver upgrade Package: util-vserver Version: 0.30.210-10 Severity: critical Justification: breaks the whole system Here's the snippet: Setting up util-vserver (0.30.210-10) ... Stopping the reboot manager /etc/init.d/rebootmgr: line 37: kill: (1152) - No such process Starting Vservers... Starting the virtual server lan can not change context: migrate kernel feature missing and 'compat' API disabled: Function not implemented Server lan is not running chbind: kernel does not provide network virtualization Vserver capability not detected in kernel. rtr:/home/eyck# vserver-stat can not change context: migrate kernel feature missing and 'compat' API disabled: Function not implemented rtr:/home/eyck# dpkg -i /var/cache/apt/archives/util-vserver_0.30.204-5sarge3_i386.deb dpkg - warning: downgrading util-vserver from 0.30.210-10 to 0.30.204-5sarge3. (Reading database ... 24482 files and directories currently installed.) Preparing to replace util-vserver 0.30.210-10 (using .../util-vserver_0.30.204-5sarge3_i386.deb) ... Unpacking replacement util-vserver ... dpkg: warning - unable to delete old directory `/etc/vservers/.distributions/fc4/apt': Directory not empty dpkg: warning - unable to delete old directory `/etc/vservers/.distributions/fc4': Directory not empty dpkg: warning - unable to delete old directory `/etc/vservers/.distributions/fc3/apt': Directory not empty dpkg: warning - unable to delete old directory `/etc/vservers/.distributions/fc3': Directory not empty Setting up util-vserver (0.30.204-5sarge3) ... rtr:/home/eyck# vserver-stat CTX PROCVSZRSS userTIME sysTIMEUPTIME NAME 0 60 1.7G 61.9K 3h32m05 23m57s44 34d59h50 root server 10180 38 384.7M31K 1h36m35 12m36s00 34d59h49 [lan] rtr:/home/eyck# echo util-vserver hold|dpkg --set-selections I was lucky that I were doing this on less-important machine first, and that I had older, still working util-vserver in cache. -- System Information: Debian Release: testing/unstable APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.4.32-bsd32e Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) Versions of packages util-vserver depends on: ii iproute 20041019-3 Professional tools to control the ii libc62.3.6.ds1-4 GNU C Library: Shared libraries ii libgcc1 1:4.1.1-13 GCC support library ii libstdc++5 1:3.3.6-13 The GNU Standard C++ Library v3 ii net-tools1.60-17 The NET-3 networking toolkit util-vserver recommends no packages. -- debconf information: * util-vserver/start_on_boot: true util-vserver/prerm_stop_running_vservers: true util-vserver/postrm_remove_vserver_configs: false -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
