Bug#883408: tz-converter: Package is using PySide. This needs to be updated to PyQt5
Package: tz-converter Version: 1.0.0-1 Severity: normal Package is currently using Pyside. As this is being removed, migrating this package over to PyQt5. -- System Information: Debian Release: 9.2 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-3-amd64 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages tz-converter depends on: ii python3 3.5.3-1 ii python3-dateutil 2.5.3-2 ii python3-pyside1.2.2-2 ii python3-tz2016.7-0.3 tz-converter recommends no packages. tz-converter suggests no packages. -- no debconf information
Bug#775509: Seeking Mentor for Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter
Hello Paul, Thanks again for the review! I have made further changes, as well in how the upstream file is made. Using the setup.py, this is much simpler! I do have a few comments below: 1.The License lines in debian/copyright are incorrect, please use the right ones from the copyright-format spec. I am a little confused. I checked the link, and it looks like it matches the examples. Is there a specific area that does not match the license format? 2. Could you explain what debian/source/options is for? By having '--extend-diff-ignore' set in this file, I was telling dpkg-source to ignore python generated egg-info. But if this will be done with setup.py sdist, this should not be needed. 3. I added a metadata file, but it might be a little sparse. I was a little confused, as a lot of the data looks to be related to publications? Is any of this needed for this project? I have uploaded the current changes back to Debian Mentors: https://mentors.debian.net/package/tz-converter Please let me know if any further changes are needed. Thanks again for the help! - Dave On 金, 2015-04-24 at 11:11 +0800, Paul Wise wrote: On Fri, 2015-04-24 at 00:30 +0900, Dave Maiorino wrote: If possible, could I get a further review on these changes? If there is anything else that needs to be fixed, please let me know. A further review: Your upstream tarball contains build artefacts (build/ dir). You should only ever use `./setup.py sdist` to create upstream tarballs. The upstream tarball created by that has a debian/ directory in it (that is missing some files) but it should not have that, please fix setup.py. The version in setup.py and PKG-INFO contains both the upstream version (1.0.0) and the Debian version suffix (the -1) but it should only contain the upstream version, the Debian version suffix lives only in debian/changelog. data_files in setup.py hard-codes /usr as the prefix. The default for upstream setup.py should be to use the prefix chosen by the person doing the install, defaulting to /usr/local. icon_path in scripts/tz-converter and tz_converter/main_widget.py hard-codes /usr as the prefix but it should be using whatever prefix was passed to setup.py, otherwise no icons will be shown when people install manually instead of via a Debian package. I don't know enough about Python upstream stuff, but this looks weird: Platform: UNKNOWN The Depends in debian/control contains this python-dateutil, shouldn't it be python3-dateutil since this is a Python 3 program? The Section: python in debian/control is incorrect (this is for Python modules), please choose one of these, maybe utils or misc? https://packages.debian.org/sid/ I would suggest upgrading debian/compat to 9 since you have a build-dep on debhelper 9. Please add a debian/upstream/metadata file: https://wiki.debian.org/UpstreamMetadata The License lines in debian/copyright are incorrect, please use the right ones from the copyright-format spec: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ I'd suggest wrapping debian/watch on the whitespace. I don't think the comment in debian/rules is needed any more. debian/rules uses --buildsystem=python_distutils but the upstream setup.py is using setuputils instead. Are you sure the override_dh_* in debian/rules are needed? dh should be able to do all of the things you've overridden automatically. The recommended tool for building Python packages these days is pybuild: https://wiki.debian.org/Python/Pybuild Could you explain what debian/source/options is for? Build warnings: package init file 'tz_converter/__init__.py' not found (or not a regular file) dh_pysupport: This program is deprecated, you should use dh_python2 instead. Migration guide: http://deb.li/dhs2p Automatic checks: https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git $ pep8 --ignore W191 . lots of whitespace issues $ pyflakes3 . ./tz_converter/main_widget.py:3: 'sys' imported but unused ./tz_converter/main_widget.py:4: 'os' imported but unused -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#775509: Seeking Mentor for Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter
Hello Paul, Thank you very much for you in-depth review and comments. Sorry for delay in the reply, I needed to go back and review the current build based on these comments. As suggested, I found using the python commands to be much easier in creating this package. With the revisions completed, I have updated the result back to the mentors repo: https://mentors.debian.net/package/tz-converter If possible, could I get a further review on these changes? If there is anything else that needs to be fixed, please let me know. Thanks again for the help! - Dave On 月, 2015-03-30 at 14:12 +0800, Paul Wise wrote: On Sat, 2015-03-28 at 14:10 +0900, Dave Maiorino wrote: For the copyright file, I have gone back and added a source for Saki-NuoveXT-Apps-world-clock.ico. As for the icon gnome-set-time.png, I have grabbed this from the system, which looks to belong from the package gnome-desktop licensed under GNU. As a result, I have added the copyright owners of this package for the file icons/gnome-set-time.png. Please let me know if this needs to be further reviewed. Please add this information to the upstream AUTHORS file too. The License lines in debian/copyright are incorrect, please use the right ones from the copyright-format spec: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Sorry for the PEP errors. main_widget.py is giving PEP-8 warnings too. For the build dir and the changelog.Debian.gz issues, not quite sure how those got in there ;) Might have been from an older upload that I did not fixed. Corrected these now. You should use `python setup.py sdist` to create your upstream tarballs but if I use that some files are missing so you'll need to fix setup.py. I have taken all of these changes, and reposted to mentors.debian.net. Please let me know if there is anything else, or how I can catch a sponsor. I have been using Debian for almost 10 years, and want to be able to contribute back :) Could you explain what debian/source/options is for? debian/tz-converter.1.gz is a compressed copy of the upstream manual page. I would suggest removing it. debian/upstream-signing-key.pgp is at a deprecated path, it should be converted to an ASCII-armoured key at debian/upstream/signing-key.asc debian/source/include-binaries can be removed after the above fixes. debian/patches is empty and can be removed. Downloading the upstream tarball with uscan fails, missing sigs: uscan --download-current-version --verbose --destdir . The upstream tarball from uscan is different to the one on mentors. The upstream setup.py should install the manual page instead of the Debian packaging including debian/tz-converter.manpages. Same for debian/tz-converter.desktop and debian/install Same for /usr/bin/tz-converter and debian/links Same for the icons and debian/install Are you sure the override_dh_* in debian/rules are needed? Please wrap and sort the debian meta-data using this (from devscripts): wrap-and-sort -sa I'd suggest wrapping debian/watch on the whitespace. You might want to look at this wiki page: https://wiki.debian.org/debian/watch Why is there a copy of debian/changelog in the upstream tarball here? tz-converter/changelog.gz Your OpenPGP key is using SHA-1 self-signatures and never expires, you might want to update your configuration and set a expiry date using a self-signature with a stronger hash algorithm. Please also read through the rest of the OpenPGP best practices: https://help.riseup.net/en/security/message-security/openpgp/best-practices#self-signatures-should-not-use-sha1 https://help.riseup.net/en/security/message-security/openpgp/best-practices#use-an-expiration-date-less-than-two-years -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#775509: Seeking Mentor for Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter
Hello Harlan, Thank you very much for your reply and the advice. For the copyright file, I have gone back and added a source for Saki-NuoveXT-Apps-world-clock.ico. As for the icon gnome-set-time.png, I have grabbed this from the system, which looks to belong from the package gnome-desktop licensed under GNU. As a result, I have added the copyright owners of this package for the file icons/gnome-set-time.png. Please let me know if this needs to be further reviewed. Sorry for the PEP errors. I have the checks running with PyCharm, but looks like I did not do a final run through before uploading. Made fixes for the white spacing now. For the build dir and the changelog.Debian.gz issues, not quite sure how those got in there ;) Might have been from an older upload that I did not fixed. Corrected these now. I have taken all of these changes, and reposted to mentors.debian.net. Please let me know if there is anything else, or how I can catch a sponsor. I have been using Debian for almost 10 years, and want to be able to contribute back :) - Dave On 金, 2015-03-27 at 14:59 -0400, Harlan Lieberman-Berg wrote: マイリノデイヴィッド maiorinoda...@gmail.com writes: Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter Hello Dave! Thank you for your contribution to Debian. I'm not able to sponsor your package, but I took a look at it to see if there were things you could fix while you wait. (Some of these problems would traditionally be forwarded upstream and patched in Debian, but since you are also the upstream maintainer, a new release might be easier.) The most pressing concern to me is that the source for the two images included as icons is unclear. While the .ico file is referenced in d/copyright, including its source as a note is probably a good idea. The gnome-set-time.png icon has no listed license and should probably include the vector version if it is supplied by upstream - as the vector is the preferred form of modification. This must be fixed before someone will sponsor it. The build directory should be removed from the upstream tarball. It's just duplicate code, and it gets removed by debhelper when the build is actually run anyway. pep8 shows a bunch of code formatting errors - mostly lines being too long and a couple of whitespace errors. You may be able to use a tool like autopep8 to correct the errors, though I suggest looking through the diff that it produces in case it does something wonky. Because you are both upstream and the Debian maintainer for the package, you should install the changelog file as changelog.gz, rather than changelog.Debian.gz. Take a look at Debian Policy 12.7 for more information. Thank you again for your contributions to Debian; I'm happy to take a second look after you have fixed these problems. Sincerely, -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter - An application for converting the time across time zones
Package: sponsorship-requests Severity: wishlist Dear Mentors, I am looking for a sponsor for my package tz-converter: * Package name: tz-converter Version : 1.0.0 Upstream Author : David Maiorino URL :https://github.com/DMaiorino/tz-converter License : GPL-3+ Section : python It builds the following application: tz-converter - An application for converting the time across time zones To access further information about this package, please visit the following URL: https://mentors.debian.net/package/tz-converter Alternatively, one can download the package with dget using this command: dget -xhttp://mentors.debian.net/debian/pool/main/t/tz-converter/tz-converter_1.0.0.dsc More information about hello can be obtained fromhttps://github.com/DMaiorino/tz-converter. Changes since the last upload: tz-converter (1.0.0-1) unstable; urgency=low * Initial release (closes: #754287) -- David Maiorino (Dave) maiorinoda...@gmail.com Thu, 01 Jan 2015 00:29:23 +0900 Just one note, but there is also a 1.0.0-4.dsc version sitting in the the Debian pool. Please ignore that version as it was incorrectly added a few weeks back. If any further changes need to be made, please let me know. Thank you for the help! - David Maiorino (Dave) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
