Bug#965046: PATCH

2020-09-25 Thread David Lechner

The upstream fix can be found at 
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5258/diffs



Bug#965046: cmake: compiler_id_detection fails for armhf when using QEMU user-mode emulation

2020-07-14 Thread David Lechner
Package: cmake
Version: 3.16.3-1ubuntu1
Severity: normal

Dear Maintainer,


   * What led up to the situation? Trying to build a package using pbuilder and
qemu on travis-ci.org
   * What exactly did you do (or not do) that was effective (or
 ineffective)? Works for nativie arcitecture but fails when run using qemu
   * What was the outcome of this action? https://travis-
ci.org/github/ev3dev/ev3devKit/jobs/708160450
   * What outcome did you expect instead? Building should complete without
error as with previous versions of cmake


This is likely caused by upstream bug
https://gitlab.kitware.com/cmake/cmake/-/issues/20568 (regrission introduced in
cmake 3.15)


This can probably be fixed by adding something similar to this in debian/rules:

export CFLAGS="-D_FILE_OFFSET_BITS=64"
export CXXFLAGS="-D_FILE_OFFSET_BITS=64"




-- System Information:
Debian Release: bullseye/sid
  APT prefers focal-updates
  APT policy: (500, 'focal-updates'), (500, 'focal-security'), (500, 
'focal-backports'), (500, 'focal')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.4.0-39-generic (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages cmake depends on:
ii  cmake-data3.16.3-1ubuntu1
ii  libarchive13  3.4.0-2ubuntu1
ii  libc6 2.31-0ubuntu9
ii  libcurl4  7.68.0-1ubuntu2.1
ii  libexpat1 2.2.9-1build1
ii  libgcc-s1 10-20200411-0ubuntu1
ii  libjsoncpp1   1.7.4-3.1ubuntu2
ii  librhash0 1.3.9-1
ii  libstdc++610-20200411-0ubuntu1
ii  libuv11.34.2-1ubuntu1
ii  procps2:3.3.16-1ubuntu2
ii  zlib1g1:1.2.11.dfsg-2ubuntu1

Versions of packages cmake recommends:
ii  gcc   4:9.3.0-1ubuntu2
ii  make  4.2.1-1.2

Versions of packages cmake suggests:
pn  cmake-doc
ii  ninja-build  1.10.0-1build1

-- no debconf information



Bug#890817: [PATCH] Set may-sync-config := 0 in kernel_version.mk

2019-03-12 Thread David Lechner
This is a hack to prevent `make syncconfig` from being called in the
Linux kernel Makefile, which overwrites the .config file.
---

Thanks to the hint from Nick, I added one more cludge to get things working.

 kernel/ruleset/kernel_version.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/ruleset/kernel_version.mk b/kernel/ruleset/kernel_version.mk
index 8b4055c..fe4a8e3 100644
--- a/kernel/ruleset/kernel_version.mk
+++ b/kernel/ruleset/kernel_version.mk
@@ -39,8 +39,10 @@ MFLAGS:=$(filter-out -w,$(FLAGS))
 
 # Include the kernel makefile
 override dot-config := 1
+override may-sync-config := 0
 include Makefile
 dot-config := 1
+may-sync-config := 0
 
 .PHONY: debian_VERSION debian_PATCHLEVEL debian_SUBLEVEL
 .PHONY: debian_EXTRAVERSION debian_LOCALVERSION debian_TOPDIR
-- 
2.17.1



Bug#890817: kernel-package: make-kpkg stalls indefinitely on linux-4.16-rc* in silentoldconfig stage

2019-03-03 Thread David Lechner

FWIW, I've tried the patches suggested so far. While they fix the lock up, my 
.config still gets written over at some point (see below), so make-kpkg is 
still broken for me (using 4.19 kernel source).


== making target debian/stamp/conf/kernel-conf [new prereqs: ]==
make 
CROSS_COMPILE=/usr/lib/x86_64-linux-gnu/gcc-linaro-6.4.1-2017.11-x86_64_arm-linux-gnueabihf/bin/arm-linux-gnueabihf-
 ARCH=arm \
    oldconfig;
make[2]: Entering directory 
'/home/david/work/ev3dev-dpkg/ev3dev-kpkg/ev3-kernel'
scripts/kconfig/conf  --oldconfig Kconfig
#
# configuration written to .config
#



Bug#896905: [PATCH] Build python3 package

2018-06-27 Thread David Lechner
This builds a python3 package for libiio
---
 debian/control| 14 +-
 debian/python3-libiio.install |  2 ++
 debian/rules  |  8 
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 debian/python3-libiio.install

diff --git a/debian/control b/debian/control
index 9c595f9..70323d2 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,8 @@ Build-Depends: bison,
   libusb-1.0-0-dev [linux-any],
   libusb2-dev [kfreebsd-any],
   libxml2-dev,
-   python-dev
+   python-dev,
+   python3-dev
 Standards-Version: 4.1.4
 Homepage: https://github.com/analogdevicesinc/libiio
 Vcs-Browser: https://github.com/ev3dev/libiio
@@ -78,6 +79,17 @@ Description: Python bindings for libiio
  .
  This package contains the Python bindings for libiio.
 
+Package: python3-libiio
+Section: python
+Architecture: all
+Depends: libiio0 (>= ${binary:Version}), ${misc:Depends}, ${python3:Depends}
+Description: Python bindings for libiio
+ Libiio is a library that has been conceived to ease the development of
+ applications interfacing Industrial Input/Output (IIO) devices through
+ the IIO subsystem of the Linux kernel.
+ .
+ This package contains the Python bindings for libiio.
+
 Package: libiio0-doc
 Section: doc
 Architecture: all
diff --git a/debian/python3-libiio.install b/debian/python3-libiio.install
new file mode 100644
index 000..4755228
--- /dev/null
+++ b/debian/python3-libiio.install
@@ -0,0 +1,2 @@
+usr/lib/python3.5/site-packages/*.egg-info usr/lib/python3/dist-packages
+usr/lib/python3.5/site-packages/*.py usr/lib/python3/dist-packages
diff --git a/debian/rules b/debian/rules
index 8c01998..67010ea 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,14 @@ DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture 
-qDEB_HOST_MULTIARCH)
 override_dh_auto_configure:
dh_auto_configure -- -DINSTALL_LIB_DIR=/usr/lib/$(DEB_HOST_MULTIARCH)
 
+override_dh_auto_build:
+   dh_auto_build
+   python3 obj-$(DEB_HOST_MULTIARCH)/bindings/python/setup.py build
+
+override_dh_auto_install:
+   dh_auto_install
+   python3 obj-$(DEB_HOST_MULTIARCH)/bindings/python/setup.py install 
--root=debian/tmp/ --prefix=/usr
+
 override_dh_compress:
dh_compress -X.c -X.C
 
-- 
2.17.1



Bug#858801: [PATCH] Install default main.conf

2017-03-26 Thread David Lechner
Package: connman
Version: 1.33-3
Severity: normal
Tags: patch

The connman source package provides a default main.conf file with explanations.
Let's install it to make it easier for users to modify without having to
consult the man page for everything.
---
 debian/connman.install | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/connman.install b/debian/connman.install
index 98670fa..d61b29a 100644
--- a/debian/connman.install
+++ b/debian/connman.install
@@ -1,3 +1,4 @@
+src/main.conf /etc/connman/
 etc/dbus-1/system.d/connman.conf
 lib/systemd/system/connman.service
 lib/systemd/system/connman-wait-online.service
-- 
2.7.4



Bug#858799: [PATCH] Install connmanctl in /usr/bin/

2017-03-26 Thread David Lechner
connmanctl does not require root privlidges, therefore is should be
installed in /usr/bin/ instead of /usr/sbin/
---

I missed the lintian overrides in the first patch.

 debian/connman.install   | 2 +-
 debian/connman.lintian-overrides | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/connman.install b/debian/connman.install
index 0385537..98670fa 100644
--- a/debian/connman.install
+++ b/debian/connman.install
@@ -4,7 +4,7 @@ lib/systemd/system/connman-wait-online.service
 
 usr/share/man
 usr/share/polkit-1/actions/net.connman.policy
-usr/bin/connmanctl /usr/sbin
+usr/bin/connmanctl
 usr/lib/tmpfiles.d/connman_resolvconf.conf
 usr/sbin/connmand
 usr/sbin/connmand-wait-online
diff --git a/debian/connman.lintian-overrides b/debian/connman.lintian-overrides
index 11e2c51..397215e 100644
--- a/debian/connman.lintian-overrides
+++ b/debian/connman.lintian-overrides
@@ -1,5 +1,5 @@
 # known bug, won't fix
-connman: spelling-error-in-binary usr/sbin/connmanctl prefered preferred
+connman: spelling-error-in-binary usr/bin/connmanctl prefered preferred
 connman: spelling-error-in-binary usr/sbin/connmand prefered preferred
 
 # false positive - man connman is the manpage for connmand
-- 
2.7.4



Bug#858799: connmanctl should be installed in /usr/bin/, not /usr/sbin/

2017-03-26 Thread David Lechner
Package: connman
Version: 1.33-3
Severity: normal
Tags: patch

Dear Maintainer,


   * What led up to the situation?

tried to run connmanctl as normal user

   * What was the outcome of this action?

received command not found error. found that connmanctl is installed in
/usr/sbin, so it is only in the $PATH for root.

   * What outcome did you expect instead?

any user should be able to run commanctl 



-- System Information:
Distributor ID: Raspbian
Description:Raspbian GNU/Linux testing (stretch)
Release:testing
Codename:   stretch
Architecture: armv6l

Kernel: Linux 4.4.47-19-ev3dev-rpi+
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages connman depends on:
ii  dbus 1.10.16-1
ii  init-system-helpers  1.47
ii  iptables 1.6.0+snapshot20161117-5
ii  libc62.24-9
ii  libdbus-1-3  1.10.16-1
ii  libglib2.0-0 2.50.3-1
ii  libgnutls30  3.5.8-3
ii  libreadline7 7.0-2
ii  libxtables12 1.6.0+snapshot20161117-5
ii  lsb-base 9.20161125+rpi1

Versions of packages connman recommends:
ii  bluez  5.43-2
pn  ofono  
ii  wpasupplicant  2:2.4-1

Versions of packages connman suggests:
pn  connman-vpn  

-- no debconf information
>From d40d5cd7ad474f60c74ccbef67e54be445654044 Mon Sep 17 00:00:00 2001
From: David Lechner 
Date: Sun, 26 Mar 2017 17:06:38 -0500
Subject: [PATCH] Install connmanctl in /usr/bin/

connmanctl does not require root privlidges, therefore is should be
installed in /usr/bin/ instead of /usr/sbin/
---
 debian/connman.install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/connman.install b/debian/connman.install
index 0385537..98670fa 100644
--- a/debian/connman.install
+++ b/debian/connman.install
@@ -4,7 +4,7 @@ lib/systemd/system/connman-wait-online.service
 
 usr/share/man
 usr/share/polkit-1/actions/net.connman.policy
-usr/bin/connmanctl /usr/sbin
+usr/bin/connmanctl
 usr/lib/tmpfiles.d/connman_resolvconf.conf
 usr/sbin/connmand
 usr/sbin/connmand-wait-online
-- 
2.7.4



Bug#848837: [PATCH] Create Plugins directory during install

2016-12-19 Thread David Lechner
KeePass now requires that plugins are installed in a "Plugins" directory
that is a sibling to KeePass.exe. KeePass will create this directory
automatically on first run, but there are a couple reasons to create it
during package install. Users may want to install plugins before they run
keepass2 for the first time. Also, since KeePass is a Windows application,
there are issues with case sensitivity along with the directory name. Some
plugins expect to be installed in "plugins" rather than "Plugins", so we
create a symlink (plugins->Plugins) to accommodate any case sensitivity
issues.
---
 debian/dirs  | 1 +
 debian/links | 1 +
 2 files changed, 2 insertions(+)
 create mode 100644 debian/dirs

diff --git a/debian/dirs b/debian/dirs
new file mode 100644
index 000..82459fb
--- /dev/null
+++ b/debian/dirs
@@ -0,0 +1 @@
+usr/lib/keepass2/Plugins
diff --git a/debian/links b/debian/links
index e7660b7..3b9d0fe 100644
--- a/debian/links
+++ b/debian/links
@@ -1 +1,2 @@
 usr/share/icons/hicolor/32x32/apps/keepass2.png usr/share/pixmaps/keepass2.png
+usr/lib/keepass2/Plugins usr/lib/keepass2/plugins
-- 
2.7.4



Bug#848837: [PATCH] Create symlink Plugins->plugins

2016-12-19 Thread David Lechner
Since KeePass is a Windows application, there are issues with case
sensitivity and the plugins directory. Creating a symlink from
/usr/lib/keepass2/Plugins->/usr/lib/keepass2/plugins will work around
this.

In fact, there are known plugins that expect a lower-case plugins directory.
---

Please disregard my other patch. I did not realize that the Plugins directory
was being created already in debian/rules.

 debian/links | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/links b/debian/links
index e7660b7..3b9d0fe 100644
--- a/debian/links
+++ b/debian/links
@@ -1 +1,2 @@
 usr/share/icons/hicolor/32x32/apps/keepass2.png usr/share/pixmaps/keepass2.png
+usr/lib/keepass2/Plugins usr/lib/keepass2/plugins
-- 
2.7.4



Bug#845507: closed by Julian Andres Klode (Re: Bug#845507: having gnupg as Recommends instead of Depends breaks apt-key and tools that use apt-key)

2016-11-28 Thread David Lechner

On 11/25/2016 04:57 AM, David Kalnischkies wrote:

On Thu, Nov 24, 2016 at 10:47:00AM -0600, David Lechner wrote:

Your suggestion is not entirely clear to me though. When you say:


Report it to them. They are the ones doing it wrong. There has been

a better replacement for years.

I assume that "they" means people/projects using apt-key. And, I assume
"doing it wrong" means using the apt-key command. What is this "better
replacement" for apt-key?


You don't need apt-key to add a key to the trusted set. You just drop
a keyring file into /etc/apt/trusted.gpg.d/whatever-you-like.gpg and be
happy.

That is not only easier for you to add and for us to deal with, but its
also easier for you to remove if you ever need to. Hardly any keyring
package performed a proper cleanup because its hard…


Nowadays apt-key is really a tool which should only be used by a 'real'
user – and 99% of users will never need it (or at least shouldn't be
forced by 6+ years outdated advice to use it).


Best regards

David Kalnischkies




Thanks! I have seen exactly zero blogs/stackexchange answers/wiki pages 
that suggest using /etc/apt/trusted.gpg.d/ vs. many, many pages that 
suggest using apt-key. I will do what I can to change that.




Bug#683593: Multiarch improvements for glib2.0

2016-11-28 Thread David Lechner

On 11/28/2016 07:40 AM, W. Martin Borgert wrote:

Hi all,

is there any progress on the issue?
What are the blocking points?
Is there anything wrong with Simons suggestion to assume,


that we can execute the foreign
architecture's binaries without issues


?

TIA!




The problem is not simply just getting the foreign architecture binary 
to run. The real question that has yet to be answered is "do these 
binaries produce the same output on all architectures?"


Reiterating a previous comment:

> Do foreign architectures' glib-genmarshal always produce the same 
output as the native version?


> gobject-query is purely informational, so it *probably* isn't a
build-dependency for anything.

> gtester is a test-runner; can tests run successfully under a foreign
gtester? 
suggests that d-conf/unstable would be a good test-case, although you
would have to enable build-time checks.

> There are other binaries mentioned in the patch on the merged bug
#648621. Do those all produce architecture-independent results?

If someone can take the time to answer these questions, then this bug 
can move forward.




Bug#845507: closed by Julian Andres Klode (Re: Bug#845507: having gnupg as Recommends instead of Depends breaks apt-key and tools that use apt-key)

2016-11-24 Thread David Lechner
I apologize for my ignorance. I can see that it severely annoys you. I 
have no opinion on the use of gnupg and I am perfectly happy to become 
your ally in not using it.


Your suggestion is not entirely clear to me though. When you say:

> Report it to them. They are the ones doing it wrong. There has been
a better replacement for years.

I assume that "they" means people/projects using apt-key. And, I assume 
"doing it wrong" means using the apt-key command. What is this "better 
replacement" for apt-key?




Bug#845507: having gnupg as Recommends instead of Depends breaks apt-key and tools that use apt-key

2016-11-23 Thread David Lechner

Package: apt
Version: 1.3.1

In apt (1.3~exp1), the following change was made:

  * move gnupg|gnupg2 from apt Depends to Recommends


This breaks the apt-key command, which is part of the apt package.

Example:

$ apt-key list
Error: gnupg, gnupg2 and gnupg1 do not seem to be installed,
Error: but apt-key requires gnupg, gnupg2 or gnupg1 for this operation.


This also breaks tools like pbuilder which uses apt-key to add keyrings.

Example:

$ pbuilder 
Creating /home/david/pbuilder-ev3dev/debian/base-stretch-armhf.tgz
...
I: adding apt key file /usr/share/keyrings/ev3dev-archive-keyring.gpg.
Error: gnupg, gnupg2 and gnupg1 do not seem to be installed,
Error: but apt-key requires gnupg, gnupg2 or gnupg1 for this operation.


Please change gnupg|gnupg2 back to Depends



Bug#787850: [PATCH] Build python3 package

2016-09-28 Thread David Lechner

---

Here is a patch for python 3 support. However there is another bug that the 
0.22 debian
package uses upstream 0.18 and python3 support doesn't really work until 
upstream 0.21.

 debian/control | 19 ++-
 debian/rules   |  9 +++--
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index bdead3a..d4f8461 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,13 @@ Section: python
 Priority: optional
 Maintainer: Debian Bluetooth Maintainers 

 Uploaders: Albert Huang 
-Build-Depends: debhelper (>= 5.0.37.2), python-all-dev (>= 2.6.6-3~), 
libbluetooth-dev
+Build-Depends: debhelper (>= 5.0.37.2)
+ , dh-python
+ , python-all-dev (>= 2.6.6-3~)
+ , python-setuptools
+ , python3-all-dev
+ , python3-setuptools
+ , libbluetooth-dev
 Vcs-Svn: svn://svn.debian.org/pkg-bluetooth/packages/pybluez/trunk
 Vcs-Browser: http://svn.debian.org/wsvn/pkg-bluetooth/packages/pybluez/trunk
 Homepage: https://karulis.github.io/pybluez/
@@ -19,3 +25,14 @@ Description: Python wrappers around BlueZ for rapid 
bluetooth development
  running the GNU/Linux operating system and the bluez bluetooth stack.
  .
  This package provides the "bluetooth" Python module.
+
+Package: python3-bluez
+Architecture: any
+Depends: ${python3:Depends}, ${shlibs:Depends}, ${misc:Depends}
+Provides: python-bluetooth, ${python3:Provides}
+Description: Python wrappers around BlueZ for rapid bluetooth development
+ PyBluez is an effort to create Python wrappers around BlueZ to allow Python
+ developers to use system bluetooth resources. PyBluez works on machines
+ running the GNU/Linux operating system and the bluez bluetooth stack.
+ .
+ This package provides the "bluetooth" Python 3 module.
diff --git a/debian/rules b/debian/rules
index b6ffd3f..0fbdac6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,6 +10,7 @@
 #export DH_VERBOSE=1
 
 PYVERS=$(shell pyversions -r debian/control)

+PY3VERS=$(shell py3versions -r debian/control)
 
 CFLAGS = -Wall -g
 
@@ -27,7 +28,7 @@ build-indep: build-stamp
 
 build-stamp:

dh_testdir
-   for python in $(PYVERS); do \
+   for python in $(PYVERS) $(PY3VERS); do \
  $$python setup.py build; \
done
touch build-stamp
@@ -37,7 +38,7 @@ clean:
dh_testroot
-rm -f build-stamp
 
-	for python in $(PYVERS); do \

+   for python in $(PYVERS) $(PY3VERS); do \
  $$python setup.py clean; \
done
 
@@ -59,12 +60,16 @@ binary-arch: build install

for python in $(PYVERS); do \
  $$python setup.py install --root=debian/python-bluez; \
done
+   for python in $(PY3VERS); do \
+ $$python setup.py install --root=debian/python3-bluez; \
+   done
 
 	dh_installdocs

dh_strip
dh_compress
dh_fixperms
dh_python2
+   dh_python3
dh_installdeb
dh_shlibdeps
dh_gencontrol



Bug#839100: python-bluez: debian pybluez package version 0.22-1 uses upstream source code version 0.18

2016-09-28 Thread David Lechner
Package: python-bluez
Version: 0.22-1
Severity: normal

Dear Maintainer,

I have noticed that the source code was not actually updated to upstream
version 0.22 as stated in the debian changelog.

The 0.22-1 package still uses the upstream v0.18 source code.

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-36-generic (SMP w/6 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect

Versions of packages python-bluez depends on:
ii  libbluetooth3  5.36-1+b2
ii  libc6  2.23-5
ii  python 2.7.11-2

python-bluez recommends no packages.

python-bluez suggests no packages.

-- no debconf information



Bug#827643: other bug reports

2016-06-19 Thread David Lechner

Here are some related bug reports:

https://bugs.launchpad.net/debian/+source/imagemagick/+bug/1594060
https://github.com/ImageMagick/ImageMagick/pull/223



Bug#827643: Acknowledgement (imagemagick: writing to rgf format aborts)

2016-06-18 Thread David Lechner

Description: Fix abort when writing to rgf format
 The rgf format (LEGO MINDSTORMS EV3 images) caused a software abort 
because
 exception == NULL. When WriteRGFImage is called from WriteImage, it is 
only

 passed two parameters, not three. So, removed the extra parameter and use
 image->exception instead as in other coders.

Author: David Lechner 
Bug-Debian: https://bugs.debian.org/827643

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: , 
Bug: 
Bug-Debian: https://bugs.debian.org/
Bug-Ubuntu: https://launchpad.net/bugs/
Forwarded: 
Reviewed-By: 
Last-Update: 

--- a/coders/rgf.c
+++ b/coders/rgf.c
@@ -68,7 +68,7 @@
   Forward declarations.
 */
 static MagickBooleanType
-  WriteRGFImage(const ImageInfo *,Image *,ExceptionInfo *);
+  WriteRGFImage(const ImageInfo *,Image *);
 
 /*

%%%
@@ -301,7 +301,7 @@
 %  The format of the WriteRGFImage method is:
 %
 %  MagickBooleanType WriteRGFImage(const ImageInfo *image_info,
-%Image *image,ExceptionInfo *exception)
+%Image *image)
 %
 %  A description of each parameter follows.
 %
@@ -312,8 +312,7 @@
 %o exception: return any errors or warnings in this structure.
 %
 */
-static MagickBooleanType WriteRGFImage(const ImageInfo 
*image_info,Image *image,

-  ExceptionInfo *exception)
+static MagickBooleanType WriteRGFImage(const ImageInfo 
*image_info,Image *image)

 {
   MagickBooleanType
 status;
@@ -342,9 +341,8 @@
   assert(image->signature == MagickSignature);
   if (image->debug != MagickFalse)
 (void) 
LogMagickEvent(TraceEvent,GetMagickModule(),"%s",image->filename);

-  assert(exception != (ExceptionInfo *) NULL);
-  assert(exception->signature == MagickSignature);
-  status=OpenBlob(image_info,image,WriteBinaryBlobMode,exception);
+  assert(image->exception.signature == MagickSignature);
+  status=OpenBlob(image_info,image,WriteBinaryBlobMode,&image->exception);
   if (status == MagickFalse)
 return(status);
   (void) TransformImageColorspace(image,sRGBColorspace);
@@ -363,7 +361,7 @@
   y=0;
   for (y=0; y < (ssize_t) image->rows; y++)
   {
-p=GetVirtualPixels(image,0,y,image->columns,1,exception);
+p=GetVirtualPixels(image,0,y,image->columns,1,&image->exception);
 if (p == (const PixelPacket *) NULL)
   break;
 bit=0;



Bug#827643: imagemagick: writing to rgf format aborts

2016-06-18 Thread David Lechner
Package: imagemagick
Version: 8:6.8.9.9-5+deb8u2
Severity: normal

Dear Maintainer,


   * What led up to the situation?

trying to convert a file to rgf format

   * What exactly did you do (or not do) that was effective (or
 ineffective)?

convert mindstorms.bmp mindstorms.rgf

   * What was the outcome of this action?

the program aborts (crashes) with WriteRGFImage: Assertion `exception != 
(ExceptionInfo *) NULL' failed.

   * What outcome did you expect instead?

the file mindstorms.rgf should be created and the program should not crash



-- Package-specific info:
ImageMagick program version
---
animate:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
compare:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
convert:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
composite:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
conjure:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
display:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
identify:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
import:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
mogrify:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
montage:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org
stream:  ImageMagick 6.8.9-9 Q16 arm 2016-05-16 http://www.imagemagick.org

-- System Information:
Distributor ID: ev3dev
Description:ev3dev GNU/Linux 8.0 (jessie)
Release:8.0
Codename:   jessie
Architecture: armv7l

Kernel: Linux 4.4.9-ti-rt-r25-11-ev3dev-bb.org (SMP w/1 CPU core; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages imagemagick depends on:
ii  imagemagick-6.q16  8:6.8.9.9-5+deb8u2

imagemagick recommends no packages.

imagemagick suggests no packages.

-- no debconf information



Bug#813621: [PATCH] Add check for chroot before modifying /dev/cuse

2016-06-14 Thread David Lechner
If this package is installed in a chroot environment, then we
should not be touching anything in /dev/ because it will belong
to the host os rather than the chroot.

chrooted() comes from mount.preinst in the util-linux package.

Fixes #813621
---
 debian/fuse.postinst | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/debian/fuse.postinst b/debian/fuse.postinst
index 1eb08b8..639fc62 100644
--- a/debian/fuse.postinst
+++ b/debian/fuse.postinst
@@ -2,9 +2,19 @@
 
 set -e
 
+chrooted() {
+   if [ "$(stat -c %d/%i /)" = "$(stat -Lc %d/%i /proc/1/root 
2>/dev/null)" ]; then
+   # the devicenumber/inode pair of / is the same as that of
+   # /sbin/init's root, so we're *not* in a chroot and hence
+   # return false.
+   return 1
+   fi
+   return 0
+}
+
 case "${1}" in
configure)
-   if [ -c /dev/cuse ]
+   if [ -c /dev/cuse ] && ! chrooted
then
chmod 0600 /dev/cuse > /dev/null 2>&1
fi
-- 
2.7.4



Bug#813621: fuse: Package configuration fails in chroot

2016-02-03 Thread David Lechner
Package: fuse
Version: 2.9.3-15+deb8u2
Severity: normal

Dear Maintainer,


   * What led up to the situation?

Trying to install fuse in a chroot environment as non-root user.

   * What exactly did you do (or not do) that was effective (or
 ineffective)?

sudo apt-get install fuse

   * What was the outcome of this action?

Installation failed with no error message when running the fuse.postinst script.

   * What outcome did you expect instead?

The package should install successfully.

   * Further information

This bug was introduced with the recent security fix. The postinst script now
calls chmod 0600 /dev/cuse > /dev/null 2>&1 which fails because I have /dev
from my host system mounted in the chroot and I am not running as root. If I
was running as root, I would still not want this script to change /dev on my
host system.

Other packages such as udev and mount have functions to detect if they are
running in a chroot environment before touching anything in /dev. I think that
would be appropriate here too.

-- System Information:
Distributor ID: ev3dev
Description:ev3dev GNU/Linux 8.0 (jessie)
Release:8.0
Codename:   jessie
Architecture: armv7l

Kernel: Linux 3.19.0-43-generic (SMP w/6 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages fuse depends on:
ii  adduser   3.113+nmu3
ii  libc6 2.19-18+deb8u2
ii  libfuse2  2.9.3-15+deb8u2
ii  mount 2.25.2-6
ii  sed   4.2.2-4
ii  udev  215-17+deb8u3

fuse recommends no packages.

fuse suggests no packages.

-- no debconf information



Bug#783278: patch v2

2015-05-03 Thread David Lechner

Yes, you guessed correctly. The v2 patch is the "good" one.

On 05/03/2015 03:19 AM, Ian Campbell wrote:

Hi David,

On Fri, 2015-04-24 at 21:25 -0500, David Lechner wrote:

Tags: patch

I botched the first patch. This one fixes it correctly.

Thanks for the patch(es). The buglog at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783278 has somehow
ended up with the message ordering confused.

I'm pretty certain that the patch which should be correct is this one
labelled in the subject as v2 at Message #10 and not what I suppose is
v1 which for some reason didn't arrive until  Message #15. The date
headers match this interpretation.

I suppose the first mail got delayed somehow on its way to the BTS so
they appear in the opposite order in the log.

I thought I ought to double check!

Ian.




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#783278: patch

2015-04-24 Thread David Lechner
Here is how I have fixed the problem (attached patch). There was an if 
statement with a TODO that was not implemented, so I just took it out.
>From 20cea9a9506575a40a439766fb3e9d4bbb7587cb Mon Sep 17 00:00:00 2001
From: David Lechner 
Date: Fri, 24 Apr 2015 19:13:00 -0500
Subject: [PATCH] remove kernel != kfile check in boot_kernel_path handler.

This only applies to Method: generic.

Old behavior:

If the db entry specifies Boot-Kernel-Path, one of Dtb-Append, Machine-Id
or U-Boot-Kernel-Address must be specified which changes the value of $kernel.
When checking what to do wht Boot-Kernel-Path, the script checks to see if
$kernel was changed from the original value ($kfile). If it did not change,
it does nothing. There is a TODO comment about handling symlinks, but this
does not make sense since this is the generic method, not the symlink method.

New behavior:

The check to see if $kernel changed is removed. As long as Boot-Kernel-Path
is specified, flash-kernel will copy the kernel to the specified path.

Use case:

On Raspberry Pi, the boot loader uses the vmlinux-* file directly, but it
needs to be renamed to kernel.img, which flash-kernel should be doing.
---
 functions | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/functions b/functions
index a7ff6de..34e7536 100644
--- a/functions
+++ b/functions
@@ -684,13 +684,7 @@ case "$method" in
 		if [ -n "$boot_kernel_path" ]; then
 			boot_kernel_path="$boot_mnt_dir/$boot_kernel_path"
 			# don't mv the original kernel
-			if [ "$kernel" != "$kfile" ]; then
-backup_and_install "$kernel" \
-	"$boot_kernel_path"
-			else
-# TODO add support for kernel symlink
-:
-			fi
+			backup_and_install "$kernel" "$boot_kernel_path"
 		elif [ -n "$kmtd" ]; then
 			flash_kernel "$tmpdir/uImage" "$kmtd" ""
 			rm -f "$tmpdir/uImage"
-- 
1.9.1



Bug#783278: patch v2

2015-04-24 Thread David Lechner

Tags: patch

I botched the first patch. This one fixes it correctly.
>From 6eb082b42ad9a7c22f08ecb9f18fab7f8891be95 Mon Sep 17 00:00:00 2001
From: David Lechner 
Date: Fri, 24 Apr 2015 19:13:00 -0500
Subject: [PATCH] Handle case when kernel == kfile check in boot_kernel_path
 handler.

This only applies to Method: generic.

Old behavior:

If the db entry specifies Boot-Kernel-Path, one of Dtb-Append, Machine-Id
or U-Boot-Kernel-Address must be specified which changes the value of $kernel.
When checking what to do wht Boot-Kernel-Path, the script checks to see if
$kernel was changed from the original value ($kfile). If it did not change,
it does nothing. There is a TODO comment about handling symlinks, but this
does not make sense since this is the generic method, not the symlink method.

New behavior:

If $kernel was not changed, copy it to a temporary file before calling
backup_and_install. backup_and_install moves the temporary file, effectivly
deleting it. Also applied same fix to initrd.

Use case:

On Raspberry Pi, the boot loader uses the vmlinux-* file directly, but it
needs to be renamed to kernel.img, which flash-kernel should be doing.
---
 functions | 20 
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/functions b/functions
index a7ff6de..6579b18 100644
--- a/functions
+++ b/functions
@@ -684,13 +684,11 @@ case "$method" in
 		if [ -n "$boot_kernel_path" ]; then
 			boot_kernel_path="$boot_mnt_dir/$boot_kernel_path"
 			# don't mv the original kernel
-			if [ "$kernel" != "$kfile" ]; then
-backup_and_install "$kernel" \
-	"$boot_kernel_path"
-			else
-# TODO add support for kernel symlink
-:
+			if [ "$kernel" = "$kfile" ]; then
+cp "$kernel" "$tmpdir/kernel"
+kernel="$tmpdir/kernel"
 			fi
+			backup_and_install "$kernel" "$boot_kernel_path"
 		elif [ -n "$kmtd" ]; then
 			flash_kernel "$tmpdir/uImage" "$kmtd" ""
 			rm -f "$tmpdir/uImage"
@@ -706,13 +704,11 @@ case "$method" in
 		if [ -n "$boot_initrd_path" ]; then
 			boot_initrd_path="$boot_mnt_dir/$boot_initrd_path"
 			# don't mv the original initrd
-			if [ "$initrd" != "$ifile" ]; then
-backup_and_install "$initrd" \
-	"$boot_initrd_path"
-			else
-# TODO add support for initrd symlink
-:
+			if [ "$initrd" = "$ifile" ]; then
+cp "$initrd" "$tmpdir/initrd"
+initrd="$tmpdir/initrd"
 			fi
+			backup_and_install "$initrd" "$boot_initrd_path"
 		elif [ -n "$imtd" ]; then
 			ipad=0
 			# padding isn't needed for U-Boot images
-- 
1.9.1



Bug#783278: flash-kernel: Specifying Boot-Kernel-Image does nothing unless Dtb-Append, Machine-Id or U-Boot-Kernel-Address is also specified

2015-04-24 Thread David Lechner
Package: flash-kernel
Version: 3.35
Severity: normal

Dear Maintainer,


   * What led up to the situation?

trying to use flash-kernel with a Raspberry Pi.

   * What exactly did you do (or not do) that was effective (or
 ineffective)?

Created a .db file with:

Machine: BCM2708
Boot-Kernel-Path: /boot/flash/kernel.img

Then ran flash-kernel

   * What was the outcome of this action?

flash-kernel should have copied the kernel, but instead did nothing and 
returned successfully.

   * What outcome did you expect instead?

The kernel at /boot/vmlinuz- should have been copied to 
/boot/flash/kernel.img



-- System Information:
Distributor ID: ev3dev
Description:ev3dev GNU/Linux testing (jessie)
Release:testing
Codename:   jessie
Architecture: armv6l

Kernel: Linux 3.18.11-dlech+ (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages flash-kernel depends on:
ii  debconf [debconf-2.0]  1.5.56
ii  devio  1.2-1+b1
ii  initramfs-tools0.120
ii  linux-base 3.5
ii  ucf3.0030

Versions of packages flash-kernel recommends:
ii  u-boot-tools  2014.10+dfsg1-5

flash-kernel suggests no packages.

-- Configuration Files:
/etc/flash-kernel/db changed:
Machine: Raspberry Pi


-- debconf information:
* flash-kernel/linux_cmdline:


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#770281: dh-systemd: dh_systemd_enable --no-enable not working as expected

2014-12-26 Thread David Lechner

As you wrote, systemclt status says:

>Loaded: loaded (/lib/systemd/system/spamassassin.service; disabled)

So, the service is "disabled" as expected. I think what you want in 
addition to "dh_systemd_enable --no-enable" is "dh_systemd_start 
--no-start" so that the service does not start when it is installed.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#751636: openssh-server: ssh sessions are not cleanly termined on shutdown/restart with systemd

2014-10-10 Thread David Lechner
I have found that using ssh.socket instead of ssh.service makes clients 
shut down cleanly most of the time (sometimes they will still hang, but 
it is rare).


systemctl disable ssh.service
systemctl enable ssh.socket


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#742408: (no subject)

2014-10-06 Thread David Lechner

Any chance of updating before the package freeze in November?


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#749865: (no subject)

2014-10-06 Thread David Lechner
It would be really nice to have this updated before the package freeze 
in November.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#757142: plymouthd crashes when trying to use framebuffer renderer

2014-08-05 Thread David Lechner
Package: plymouth
Version: 0.9.0-6
Severity: normal

Dear Maintainer,

   * What led up to the situation?

 I am trying to use plymouth on an embedded system with a framebuffer video 
driver.

   * What exactly did you do (or not do) that was effective (or
 ineffective)?

 I followed the many tutorials availible for this kind of setup, but none 
worked.

   * What was the outcome of this action?

 It turns out plymouthd is crashing with a SEGV

   * What outcome did you expect instead?

 plymouthd should not crash.


This has a preliminay fix upstream 


I have ported the patch there to quilt if you want it. The patch prevents the 
crash, however there are still many other thing broken in framebuffer mode. 
Keyboard does not work in framebuffer mode. Also plymouth-quit.service fails 
(times out). A better patch would fix these issues as well.


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: armel (armv5tejl)

Kernel: Linux 3.14.7-2-ev3dev-pre2-dlech+ (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages plymouth depends on:
ii  initramfs-tools0.115
ii  libc6  2.19-7
ii  libdrm22.4.54-1
ii  libpng12-0 1.2.50-2
ii  libudev1   208-6
ii  multiarch-support  2.19-7

plymouth recommends no packages.

Versions of packages plymouth suggests:
pn  desktop-base 
ii  plymouth-themes  0.9.0-6

-- Configuration Files:
/etc/plymouth/plymouthd.conf changed:
[Daemon]
Theme=spinfinity


-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#742408: Please update the connman package

2014-07-13 Thread David Lechner
I have need of the same feature requested by the original reporter. I 
have packaged the upstream 1.24 version and it seems to be working so 
far. It would be better if I did not have to maintain my own package. 
Thanks.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753059: flash-kernel: Change introduced in #721485 breaks automated package installation

2014-06-28 Thread David Lechner
Package: flash-kernel
Version: 3.19
Severity: important

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?

Bootstrapping embedded system with multistrap.

   * What exactly did you do (or not do) that was effective (or
 ineffective)?

DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true are set so that 
packages are installed automatically (without user input).

   * What was the outcome of this action?

flash-kernel stops the installation becuase it is waiting for user input.

   * What outcome did you expect instead?

flash-kernel package should install without user input

   * Additional info:

breaking change is git commit a0a4261de83c90c9b7ffeb27d390e90019620a6a

   * Patch:

>From 5c7fbb6b9e616c8aca47bcf7554cb91407e11e30 Mon Sep 17 00:00:00 2001
From: David Lechner 
Date: Sat, 28 Jun 2014 15:06:20 -0500
Subject: [PATCH] Fix breakage caused by a0a4261

---
 initramfs-tools/hooks/flash_kernel_set_root | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/initramfs-tools/hooks/flash_kernel_set_root 
b/initramfs-tools/hooks/flash_kernel_set_root
index f157731..799112c 100755
--- a/initramfs-tools/hooks/flash_kernel_set_root
+++ b/initramfs-tools/hooks/flash_kernel_set_root
@@ -34,7 +34,7 @@ pause_error() {
# If debconf appears to be running then it is important that
# we do not block on stdin since this would hang the
# installer.
-   if [ "$DEBIAN_HAS_FRONTEND" ]; then
+   if [ "$DEBIAN_HAS_FRONTEND" ] || [ "$DEBIAN_FRONTEND" = 
"noninteractive" ]; then
echo "Unable to abort; system will probably be broken!" >&2
else
echo "Press Ctrl-C to abort build, or Enter to continue" >&2
-- 
1.8.3.2



-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: armel (armv7l)

Kernel: Linux 2.6.32 (SMP w/6 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash

Versions of packages flash-kernel depends on:
ii  devio1.2-1+b1
ii  initramfs-tools  0.115
ii  linux-base   3.5

flash-kernel recommends no packages.

Versions of packages flash-kernel suggests:
ii  u-boot-tools  2014.04+dfsg1-1

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#749865: please update so v0.4 can be packaged

2014-06-14 Thread David Lechner
Upstream has released a new version that I am using. It would be nice to 
get this updated so that I don't have to maintain my own package.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org