Bug#859808: composite: Composite not ready for being qualified package of Debian yet.
Hi all, I'm the developer of Composite. In my humble opinion, Composite should never have been added to Debian. It was not ready. While it did offer a little bit of useful functionality (the hydrogen drumkits as an LV2 plugin), it overall was the beginnings of a new project, and Debian added it before it even developed a character of its own. It was never intended that it would detract from or cause confusion with the original Hydrogen project. The only reason why it looks like an old version of Hydrogen is that I had not yet gotten around to a useable replacement UI. And while I would love to go back to work on the project, for all intents and purposes it's dead. I don't have time to work on it. And as compiler changes and libraries move forward, I don't think the Debian devs should bother maintaining this package. Whoever added it to Debian I'm sure had good intentions, perhaps thinking it would help the project. However, it did not help the project. I support the removal of Composite from Debian. -gabe
Bug#634070: composite sampler segfault
On 07/20/2011 07:47 AM, Gabriel Beddingfield wrote: I have a fix in Git (maint-0.006 branch), but it crashed for Benoit on his first try. If others could test, I would appreciate it. I tested the fix in debian sid with lv2_jack_host (slv2) and zynjacku, and it resolves the issue. I'm releasing Composite 0.006.2 today to resolve this bug. Thanks, Gabriel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#634070: composite sampler segfault
On 07/16/2011 10:01 AM, Benoît Delcour wrote: Package: composite Version: 0.006-5 Severity: important The lv2 sampler plugin v 0.006.1-1 segfaults at load time with zynjacku and lv2_jack_host. Update: Nedko told me that the crash with zynjacku is fixed in Git in rev 97b9097d087dff0fa924165dda8ea263fd7e7841. drobilla has no plans to make another SLV2 release (lv2_jack_host), but admits that this is an ugly bug. (SLV2 has been deprecated in favor of LILV.) I have a fix in Git (maint-0.006 branch), but it crashed for Benoit on his first try. If others could test, I would appreciate it. -gabriel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#634070: composite sampler segfault
On 07/16/2011 11:58 PM, Gabriel Beddingfield wrote: I built SLV2 with debug symbols, and here's what I get for a backtrace. Long story short: this is an SLV2 bug. [snip] The docs for the uri-map extension clearly say that the `map` parameter may be null.[1] However, if you pass a null to strcmp it will segfault. Looks like checking for (map == 0) is the fix. While the segfault is a definately bug with SLV2 and zynjacku... Composite should not have passed a NULL for the 2nd parameter for what it was trying to do. I've posted a fix to Git, and it should resolve your issue. I'd like to make a release on Wednesday for this bug. If you could test it, I would appreciate it. Gitorious page: https://gitorious.org/composite/composite The fix is the maint-0.006 branch. Send me an e-mail if you need instructions. Thanks, Gabriel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#634070: composite sampler segfault
On 07/16/2011 10:01 AM, Benoît Delcour wrote:
lv2_jack_host http://gabe.is-a-geek.org/composite/plugins/sampler/1
URI:http://gabe.is-a-geek.org/composite/plugins/sampler/1
Plugin Name:Composite Sampler
JACK Name: Composite Sampler
Connected to JACK.
Successfully instantiated plugin.
Erreur de segmentation
I built SLV2 with debug symbols, and here's what I get for a backtrace.
Long story short: this is an SLV2 bug.
(Edited for brevity)
$ gdb /usr/bin/lv2_jack_host
(gdb) set args http://gabe.is-a-geek.org/composite/plugins/sampler/1
(gdb) run
Starting program: /usr/bin/lv2_jack_host
http://gabe.is-a-geek.org/composite/plugins/sampler/1
[Thread debugging using libthread_db enabled]
URI:http://gabe.is-a-geek.org/composite/plugins/sampler/1
Plugin Name:Composite Sampler
JACK Name: Composite Sampler
[New Thread 0xb7fdfb70 (LWP 14386)]
Connected to JACK.
[New Thread 0xb75a4b70 (LWP 14389)]
Successfully instantiated plugin.
Set volume to 1.00
[New Thread 0xb6bffb70 (LWP 14390)]
Program received signal SIGSEGV, Segmentation fault.
0x0804937a in uri_to_id (callback_data=0x0, map=0x0, uri=0xa51980
"http://lv2plug.in/ns/ext/midi#MidiEvent";)
at ../hosts/lv2_jack_host.c:80
80 if (!strcmp(map, LV2_EVENT_URI) && !strcmp(uri,
SLV2_EVENT_CLASS_MIDI))
(gdb) bt
#0 0x0804937a in uri_to_id (callback_data=0x0, map=0x0, uri=0xa51980
"http://lv2plug.in/ns/ext/midi#MidiEvent";)
at ../hosts/lv2_jack_host.c:80
#1 0x00a4fc12 in Composite::Plugin::EngineLv2::_activate (this=0x80b5920)
at /home/gabriel/code/composite/composite/src/sampler/EngineLv2.cpp:173
#2 0x00a5028d in Composite::Plugin::EngineLv2::activate
(instance=0x80b5920)
at /home/gabriel/code/composite/composite/src/sampler/EngineLv2.cpp:77
#3 0x08049bb5 in slv2_instance_activate (argc=2, argv=0xb004) at
../slv2/plugininstance.h:128
#4 main (argc=2, argv=0xb004) at ../hosts/lv2_jack_host.c:203
(gdb) list
75 uint32_t
76 uri_to_id(LV2_URI_Map_Callback_Data callback_data,
77const char* map,
78const char* uri)
79 {
80 if (!strcmp(map, LV2_EVENT_URI) && !strcmp(uri,
SLV2_EVENT_CLASS_MIDI))
81 return MIDI_EVENT_ID;
82 else
83 return 0; // no id for you!
84 }
(gdb)
The docs for the uri-map extension clearly say that the `map` parameter
may be null.[1] However, if you pass a null to strcmp it will segfault.
Looks like checking for (map == 0) is the fix.
Thanks,
Gabriel
[1] http://lv2plug.in/ns/ext/uri-map/ (see uri-map.h)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
