Bug#635748: [pgadmin3] Does not respect system background colors in "Object browser"

2016-09-18 Thread Guillaume Lelarge 
2016-09-17 20:30 GMT+02:00 Rimas Kudelis <r...@akl.lt>:

> Hi,
>
> 2016-09-17 20:52, Guillaume Lelarge rašė:
> > You're right on the issue. Unfortunately, there won't be any more
> > pgadmin3 releases. The dev team is working on pgadmin4 right now,
> > which is a complete rewrite of pgAdmin. A GA release should be
> > available at the end of September if all goes according to plan.
> >
> > But still, thank you for your patch and your attention to this kind of
> > details. They are important to us. I'd have been happy to apply it if
> > there would be another release of pgadmin3.
> >
>
> Yeah, I saw that pgadmin4 is on the way. However, perhaps it would make
> sense to apply this at least as a Debian patch, since I doubt that
> pgadmin4 will become available in official Debian or Ubuntu repositories
> anytime soon. Or will it?
>
>
No idea. I don't maintain the Debian package.


-- 
Guillaume.
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com

Bug#635748: [pgadmin3] Does not respect system background colors in "Object browser"

2016-09-17 Thread Guillaume Lelarge 
Le 17 sept. 2016 7:44 PM, "Rimas Kudelis"  a écrit :
>
> Hi Guillaume,
>
> I just want to say that your patch doesn't quite work as expected.
Instead of just using system default colour unless custom colour is set,
Pgadmin actually stores that default colour in server configuration, and
always sets it explicitly. This isn't a problem until you change the theme
you use, but once you do (like I switched from light to dark theme), all
your servers are suddently using a colour that is no longer the default.
>
> I think the correct behavior would be not to store colour in the
configuration unless the user sets it explicitly. This way, even if PgAdmin
stores the default upon initial creation, the user could clear that setting
manually and it would then always be treated as empty instead of being
reset to the default colour on first run. Ideally, it would even be
possible to disable custom colour via a checkbox or something like that.
>
> I made a small patch, which prevents storing the empty setting. However,
it is incomplete due to the server dialog now erring upon load, because it
actually expects a colour value. I believe this should be easy to fix for
someone familiar with the code though.
>
> I'm attaching this half-baked patch. Feel free to apply it if PgAdmin is
still to be supported for some time.
>

You're right on the issue. Unfortunately, there won't be any more pgadmin3
releases. The dev team is working on pgadmin4 right now, which is a
complete rewrite of pgAdmin. A GA release should be available at the end of
September if all goes according to plan.

But still, thank you for your patch and your attention to this kind of
details. They are important to us. I'd have been happy to apply it if there
would be another release of pgadmin3.

Regards.

Bug#635748: [pgadmin3] Does not respect system background colors in "Object browser"

2016-01-20 Thread Guillaume Lelarge 
2016-01-17 14:55 GMT+01:00 Denis Briand <deb...@denis-briand.fr>:

> On Sun, Jan 17, 2016 at 11:48:51AM +0100, Guillaume Lelarge wrote:
> > Le 17 janv. 2016 10:12 AM, "Denis Briand" <deb...@denis-briand.fr> a
> écrit :
> > > Hello Guillaume,
> > >
> > > Is this patch applied?
> > > I don't found entry about that on the changelog.
> > >
> >
> > For a patch to be applied, there needs to be a patch. As far as I know,
> there's
> > no such patch for this feature.
> >
>
> On Sat, 06 Aug 2011 18:33:06 +0200 Guillaume Lelarge <
> guilla...@lelarge.info> wrote:
> > Actually, I just applied the patch for 1.14 branch and the development
> > branch.
>
> That's what you said :)
>
>
Oops, you're right. Commit c559ff958fbe6a049f381714a249a4c382cade07, pushed
in 2011. Which might explain why I didn't remember it :)


-- 
Guillaume.
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com

Bug#635748: [pgadmin3] Does not respect system background colors in "Object browser"

2016-01-17 Thread Guillaume Lelarge 
Le 17 janv. 2016 10:12 AM, "Denis Briand" <deb...@denis-briand.fr> a écrit :
>
> tags 635748 moreinfo
> thanks
>
> On Sat, 2011-08-06 at 18:04 +0200, Guillaume Lelarge wrote:
> > On Thu, 2011-07-28 at 16:15 +0200, Yuri D'Elia wrote:
> > > Package: pgadmin3
> > > Version: 1.12.3-1
> > > Severity: normal
> > >
> > > The object browser doesn't always seem to respect the system
> > > background color
> > > for the nodes. Apparently, all nodes beyond "Servers" have a white
> > > background,
> > > while the text color is still taken from the system settings. This
> > > looks like
> > > a bug.
> > >
> > > I'm using a reversed GTK theme, and this is making reading the
> > > text almost
> > > impossible. I'm attaching a screenshot.
> > >
> >
> > By default, the treeview respects the system background color for
> > its
> > own background color. The server color node (and its subnodes) is
> > white
> > by default. So you need to change it in the server's properties.
> >
> > Rather than default to white for the server background color node,
> > we
> > should go to the system default background color. This will be done
> > in a
> > future release.
> >
>
> Hello Guillaume,
>
> Is this patch applied?
> I don't found entry about that on the changelog.
>

For a patch to be applied, there needs to be a patch. As far as I know,
there's no such patch for this feature.

Bug#723676: pgadmin3-data: pgadmin3 shows es_CA (Catalan) texts when running in es_ES locale

2013-11-01 Thread Guillaume Lelarge 
On Fri, 2013-11-01 at 19:04 +0100, Christoph Berg wrote:
 Re: Guillaume Lelarge 2013-09-21 
 1379772200.2418.14.camel@localhost.localdomain
  This is an upstream issue. I commited on the wrong directory. This is
  now fixed in git.
 
 Hi Guillaume,
 
 now es_ES is missing, along with several others:
 
 552c0696090c28c27d4d103b476484cfe92b1695:
 
 -PUB_TX = af_ZA ca_ES cs_CZ de_DE es_ES fr_FR it_IT ja_JP ko_KR lv_LV pl_PL 
 pt_PT ru_RU sr_RS zh_CN zh_TW
 +PUB_TX = ca_ES cs_CZ de_DE fr_FR ja_JP lv_LV pl_PL ru_RU sr_RS zh_CN
 
 Is it really intended that so many languages got removed?
 

Yes, they all are under 85% translated, so are considered obsolete by
the project. We don't remove them from the git repository so that, if
someone wants to continue the work, they could use the old .po file. But
they aren't published anymore.


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#723676: pgadmin3-data: pgadmin3 shows es_CA (Catalan) texts when running in es_ES locale

2013-09-21 Thread Guillaume Lelarge 
This is an upstream issue. I commited on the wrong directory. This is
now fixed in git.

Thanks for reporting the issue.


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#690917: [pgadmin3] Unable to assign privileges to login role

2012-10-20 Thread Guillaume Lelarge 
On Fri, 2012-10-19 at 04:57 +0200, Ivan Mincik wrote:
 Package: pgadmin3
 Version: 1.14.2-2
 Severity: normal
 
 --- Please enter the report below this line. ---
 There is no possibility to assign privileges of database table to 
 'Login Roles' in 'Properties - Privileges' dialog because only 
 'Group Roles' are visible in 'Role' select box.
 
 Database server version: 8.3
 

See the options dialog, and check the Show users for privileges
checkbox. It should work afterwards.


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#646454: pgadmin3: FTBFS: ../pgadmin/include/utils/sysLogger.h:62:1: error: expected initializer before 'ATTRIBUTE_PRINTF_1'

2011-12-04 Thread Guillaume Lelarge 
On Sat, 2011-11-26 at 14:21 +1300, Olly Betts wrote:
 On Mon, Oct 24, 2011 at 01:13:05PM +0200, Mònica Ramírez Arceda wrote:
  During a rebuild of all packages in sid, your package failed to build on
  amd64.
  
  Relevant part:
   x86_64-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I..  
   -DDATA_DIR=\/usr/share/pgadmin3/\ -I../pgadmin/include   
   -I/usr/include/postgresql/9.1/server -I/usr/include/postgresql 
   -I/usr/include/postgresql/9.1/server -I/usr/include/postgresql -DSSL 
   -DHAVE_CONNINFO_PARSE -I/usr/lib/wx/include/gtk2-unicode-release-2.8 
   -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ 
   -DEMBED_XRC -I/usr/include/libxml2 -I/usr/include/libxml2  -Wall -O2 -c 
   -o ctlCheckTreeView.o `test -f './ctl/ctlCheckTreeView.cpp' || echo 
   './'`./ctl/ctlCheckTreeView.cpp
   In file included from ../pgadmin/include/utils/sysSettings.h:15:0,
from ../pgadmin/include/pgAdmin3.h:37,
from ./agent/pgaStep.cpp:16:
   ../pgadmin/include/utils/sysLogger.h:62:1: error: expected initializer 
   before 'ATTRIBUTE_PRINTF_1'
 
 This is due to this patch which I recently applied to wxwidgets2.8:
 
 http://patch-tracker.debian.org/patch/series/view/wxwidgets2.8/2.8.12.1-3/fix-macro-namespace-pollution.patch
 
 The bug motivating this change is here:
 
 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521924
 
 My take on this is that the ATTRIBUTE_PRINTF* macros weren't intended to
 be used outside of the wx headers - there aren't publicly documented
 anywhere, and wx upstream has renamed them in 2.9 without mentioning the
 fact in docs/changes.txt (which is intended to document all wx API
 changes).
 
 So I would say it's a bug in pgadmin that it makes use of these macros -
 it should define them itself if it needs them (and to avoid clashes with
 everyone else who carelessly defines them without thinking through the
 implications, it ought to define something like PG_ATTRIBUTE_PRINTF*
 instead of ATTRIBUTE_PRINTF*).
 
 These macros expand to GCC attributes which allow printf format
 checking, which allow the compiler to perform more checks but don't
 matter for correct compilation.  So a crude workaround to address this
 in the short-term would be to just define them to be empty if not
 already defined, for example:
 
 #ifndef ATTRIBUTE_PRINTF_1
 # define ATTRIBUTE_PRINTF_1
 #endif
 

Here is the patch applied upstream:
http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commitdiff;h=41ed1ae4f177e60e770e326b75ae3160a4041efc

Regards.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#635748: Does not respect system background colors in Object browser

2011-08-06 Thread Guillaume Lelarge 
On Thu, 2011-07-28 at 16:15 +0200, Yuri D'Elia wrote:
 Package: pgadmin3
 Version: 1.12.3-1
 Severity: normal
 
 The object browser doesn't always seem to respect the system background color
 for the nodes. Apparently, all nodes beyond Servers have a white background,
 while the text color is still taken from the system settings. This looks like
 a bug.
 
 I'm using a reversed GTK theme, and this is making reading the text almost
 impossible. I'm attaching a screenshot.
 

By default, the treeview respects the system background color for its
own background color. The server color node (and its subnodes) is white
by default. So you need to change it in the server's properties.

Rather than default to white for the server background color node, we
should go to the system default background color. This will be done in a
future release.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#635748: Does not respect system background colors in Object browser

2011-08-06 Thread Guillaume Lelarge 
On Sat, 2011-08-06 at 18:04 +0200, Guillaume Lelarge wrote:
 On Thu, 2011-07-28 at 16:15 +0200, Yuri D'Elia wrote:
  Package: pgadmin3
  Version: 1.12.3-1
  Severity: normal
  
  The object browser doesn't always seem to respect the system background 
  color
  for the nodes. Apparently, all nodes beyond Servers have a white 
  background,
  while the text color is still taken from the system settings. This looks 
  like
  a bug.
  
  I'm using a reversed GTK theme, and this is making reading the text almost
  impossible. I'm attaching a screenshot.
  
 
 By default, the treeview respects the system background color for its
 own background color. The server color node (and its subnodes) is white
 by default. So you need to change it in the server's properties.
 
 Rather than default to white for the server background color node, we
 should go to the system default background color. This will be done in a
 future release.
 

Actually, I just applied the patch for 1.14 branch and the development
branch.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#597291: pgadmin3: popup menu items shows an underline before the shortcut character

2010-09-18 Thread Guillaume Lelarge 
Le 18/09/2010 15:43, Luca Arzeni a écrit :
 Package: pgadmin3
 Version: 1.8.4-3
 Severity: minor
 
 When I right click on the object browser (for example on a server to connect 
 to it, but problem arise with any other object on the tree), the popup menu 
 items are wrong.
 They shows an underline character BEFORE of the shortcut, instead they should 
 show the shortcut character with an underline UNDER it.
 I tried with different LC_ALL settings, (C, en_US, en...@utf8) but it seems 
 that the problem is not related to this setting.
 
 Note that I can see the main menu' items properly underlined, problem affects 
 only popup menu items. May be this is an issue of wx windows?
 

This is an issue caused by an old wxWidgets release. I think you need at
least 2.8.8 to fix this.


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#597286: pgadmin: cannot change ownership of db object on a schema other than public

2010-09-18 Thread Guillaume Lelarge 
Le 18/09/2010 15:20, Luca Arzeni a écrit :
 Package: pgadmin3
 Version: 1.8.4-3
 Severity: normal
 File: pgadmin
 
 I log-in into a DB server as supaeruser (postgres, I mean).
 I open a database, and point an object THAT IS NOT ON PUBLIC SCHEMA (for 
 example a table my_table on the schema my_schema).
 I right-click on it and try to change owner (let's say that the original 
 owner was my_owner and I try to set to other_owner).
 
 If my_schema is not on search_path of postgres user, pgadmin complains that 
 my_table doesn't exists.
 
 I guess that, when working with objects out of search path, pgadmin shoud 
 prefix them with schema name, that is, it should not issue the command:
 
 ALTER TABLE my_table OWNER TO other_owner; (it fails because my_table is out 
 of search path)
 
 but
 
 ALTER TABLE my_schema.my_table OWNER TO other_owner; (it works, since it was 
 specified table full path)
 
 Note that the first command works fine if issued from a sql window, because 
 (I guess) it changes search_path before opening the session.
 
 Quick hack: alter search path of postgres user setting it to my_schema, then 
 logout and login again. Now the command works. Remember to set back the 
 search path of postgres user before quitting.
 

I don't know when it was really fixed. 1.10.5 and 1.12.0 (to be released
next monday) are fixed. It would be great if you could use an uptodate
release (at least 1.10.5).


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#594593: All files should be *, not *.*

2010-08-27 Thread Guillaume Lelarge 
Le 27/08/2010 15:46, Evgeni Golov a écrit :
 Package: pgadmin3
 Version: 1.10.5-1
 Severity: minor
 
 Severity should be annoyance actually :)
 
 When trying to restore a database via right-click→restore, the File Open 
 dialog
 offers either *.backup files or All Files. However All Files is intepreted 
 as
 *.* = all files that have an extension. As I am lazy, not all my files have 
 one
 while they are still valid (backup) files.
 
 Thus All Files should glob for *, not for *.* to list really *all* files :)
 

This is already fixed in 1.12. Which will be in RC1 next week.


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#576342: pgadmin3: won't use IPv6-only server

2010-04-03 Thread Guillaume Lelarge 
Le 03/04/2010 17:45, Gerfried Fuchs a écrit :
 tags 576342 - patch + upstream
 thanks
 
 * Bjoern Buerger debian.b...@penguin.de [2010-04-03 15:59:38 CEST]:
 When adding the -only fqdn of a new server to pgadmin3, I get the 
 following error:

 An error has occurred:
 Could not resolve hostname my.host.with.aaa.only

 A literal IPv6 address doesn't work either.


 This Bug seems to be fixed in newer versions of pgadmin3, 
 see http://code.pgadmin.org/trac/changeset/8156 for details.
 
  That changeset seems to have got reverted later, 1.10.2 was released
 after that change so I expect that there have been issues with it.
 Removed the patch tag thus.
 

No, it was not reverted. It was never applied to the 1.10 branch.

It only applies to trunk, so the fix will be available for the next
release (1.12).


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#451038: upstream answer for #451038

2009-10-24 Thread Guillaume Lelarge 
Hi,

Thanks for your report. I worked on this, and I fixed the issue. It is 
fixed upstream, so it will be available in 1.10.1.

Regards.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#547940: upstream answer for #547940

2009-09-24 Thread Guillaume Lelarge 
Hi,

Thanks for your report. I worked on this, and I fixed the issue. The problem 
was that the code didn't handle default values for INOUT parameters. It is 
fixed upstream, so it will be available in 1.10.1.

Regards.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#540625: pgfouine: 1.1 release is available from upstream

2009-08-09 Thread Guillaume Lelarge 
Package: pgfouine
Version: 1.1-1.0
Severity: wishlist

pgfouine 1.1 is available since 2009-04-26. It offers quite interesting new
features. Please upgrade to this new version.

http://pgfoundry.org/frs/download.php/2178/pgfouine-1.1.tar.gz

-- System Information:
Debian Release: 5.0
  APT prefers jaunty-updates
  APT policy: (500, 'jaunty-updates'), (500, 'jaunty-security'), (500, 
'jaunty-backports'), (500, 'jaunty')
Architecture: i386 (i686)

Kernel: Linux 2.6.28-14-generic (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pgfouine depends on:
ii  php-geshi1.0.8.1-1   Generic Syntax Highlighter
ii  php5-cli 5.2.6.dfsg.1-3ubuntu4.1 command-line interpreter for the p
ii  php5-gd  5.2.6.dfsg.1-3ubuntu4.1 GD module for php5
ii  ttf-bitstream-ve 1.10-7  The Bitstream Vera family of free 

pgfouine recommends no packages.

pgfouine suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org