Bug#1078262: nginx: Consider adding nginx.tmpfiles for /var/*/nginx

2024-08-09 Thread Gylstorff Quirin
Source: nginx
Version: 1.26.0-1
Severity: wishlist

Dear Maintainer,

if the system starts with a empty /var directory, nginx fails to start
with the following error message:

Aug 09 08:57:08 ie-test systemd[1]: Starting nginx.service - A high performance 
web server and a reverse proxy server...
Aug 09 08:57:08 ie-test nginx[961]: 2024/08/09 08:57:08 [emerg] 961#961: 
mkdir() "/var/lib/nginx/body" failed (2: No such file or directory)

An possible solution is to create nginx.tmpfiles with the following
content:

d var/lib/nginx
d var/log/nginx

Best regards
Quirin

-- System Information:
Debian Release: trixie/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf

Kernel: Linux 6.9.10-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_USER
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled



Bug#1072962: efibootguard kernel stub fails to boot

2024-06-11 Thread Gylstorff Quirin

Hi,

i build it isar-cip-core on bookworm as build enviroment
and efibootguard boots. will test it on trixie.

Best regards
Quirin

On 6/11/24 10:17 AM, Christopher Obbard wrote:

Hi Jan,

On Tue, 2024-06-11 at 07:10 +0200, Jan Kiszka wrote:

Chris, you could check if already the vanilla stub fails to run as EFI
binary. It should at least print "Unified kernel stub (EFI Boot Guard
v0.17)" and "Missing .kernel section" when there is no kernel linked to
it. This is to rule out potential problems of the bg_gen_unified_kernel
script.


Launching the kernel stub binary directly in qemu (v8.2.4) using the command
in my original message, the stub seems to attempt to print something to the
EFI console, but it ends up showing as many characters of whitespace and
simply quitting after 5s.

I guess this shows the bg_gen_unified_kernel script is OK and the issue falls
in the stub?

For the record, the efibootguard binary itself seems to work just fine.





Thanks

Chris




Bug#1070038: python3-kconfiglib: The package does not support the Linux >= 6.1

2024-04-29 Thread Gylstorff Quirin
Package: python3-kconfiglib
Version: 14.1.0-3
Severity: wishlist
Tags: upstream

Dear Maintainer,

>From https://github.com/ulfalizer/Kconfiglib/pull/119:

In linux commit 6dd85ff178cd76851e2184b13e545f5a88d1be30, Linux Torvalds
changed "option modules" to plain "modules" since it was the only option
left. kconfiglib does not have much support for either besides parsing
it and suppressing warnings when it is applied to the 'MODULES' symbol.
Mirror this behaviour for the newer "modules" property.

Should we add the patch to the Debian package?

Kind regards
Quirin

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf

Kernel: Linux 6.6.15-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_USER
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages python3-kconfiglib depends on:
ii  python3  3.11.6-1

python3-kconfiglib recommends no packages.

python3-kconfiglib suggests no packages.

-- no debconf information



Bug#1068234: efibootguard upstream

2024-04-22 Thread Gylstorff Quirin



This is a upstream bug.

Thanks for reporting

Quirin

forwarded 1068234 efibootguard-...@googlegroups.com

--
Quirin Gylstorff

Siemens AG
Technology



Bug#1069372: efibootguard: FTBFS on arm64: kernel-stub/fdt.c:169:49: error: passing argument 2 of ‘CopyMem’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]

2024-04-22 Thread Gylstorff Quirin

This is a upstream bug.
Thanks for reporting,
Quirin

forwarded 1069372 efibootguard-...@googlegroups.com

On 4/20/24 2:01 PM, Lucas Nussbaum wrote:

Source: efibootguard
Version: 0.16-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240420 ftbfs-trixie ftbfs-t64-arm64

Hi,

During a rebuild of all packages in sid, your package failed to build
on arm64.


Relevant part (hopefully):

make[2]: Entering directory '/<>'
make --no-print-directory all-recursive
Making all in .
set -e; echo '  CHK  version.h'; mkdir -p ./;   ./gen_version_h ./ < Makefile.in 
> version.h.tmp; if [ -r version.h ] && cmp -s version.h version.h.tmp; then rm -f 
version.h.tmp; else echo '  UPD  version.h'; mv -f version.h.tmp version.h; fi
   CHK  version.h
/usr/bin/mkdir -p completion/bash; PYTHONPATH=./completion/shtab:./completion 
/usr/bin/python3 -m shtab -u --shell=bash bg_setenv.cli.bg_setenv 
>completion/bash/bg_setenv.bash
   UPD  version.h
/usr/bin/mkdir -p completion/bash; PYTHONPATH=./completion/shtab:./completion 
/usr/bin/python3 -m shtab -u --shell=bash bg_printenv.cli.bg_printenv 
>completion/bash/bg_printenv.bash
/usr/bin/mkdir -p drivers/watchdog/; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -fno-stack-protector  -c drivers/watchdog/init_array_start.S 
-o drivers/watchdog/init_array_start.o
/usr/bin/mkdir -p drivers/watchdog/; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -fno-stack-protector  -c drivers/watchdog/init_array_end.S -o 
drivers/watchdog/init_array_end.o
/usr/bin/mkdir -p env/; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -fno-stack-protector  -c env/syspart.c -o env/syspart.o
/usr/bin/mkdir -p env/; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -fno-stack-protector  -c env/fatvars.c -o env/fatvars.o
/usr/bin/mkdir -p ./; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -fno-stack-protector  -c utils.c -o utils.o
/usr/bin/mkdir -p ./; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -fno-stack-protector  -c loader_interface.c -o 
loader_interface.o
/usr/bin/mkdir -p ./; gcc -I. -include config.h -I./include -I/usr/include 
-I/usr/include/efi -I/usr/include/efi/aarch64 -I/usr/include/aarch64-linux-gnu  -Wall 
-Wextra -std=gnu99 -ggdb -O0 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing 
-Wsign-compare -DGNU_EFI_USE_MS_ABI -Werror -mgeneral-regs-only -g -O2 
-Werror=implicit-function-declaration -ffile-

Bug#1060884: efibootguard: add support for loongarch64

2024-01-16 Thread Gylstorff Quirin

Dear Dandan Zhang,

Could you please post that patch in the upstream mailing list 
efibootguard-...@googlegroups.com .



Thanks
Quirin Gylstorff

On 1/16/24 04:28, zhangdandan wrote:

Source: efibootguard
Version: 0.15-1
Severity: wishlist
Tags: patch
User: debian-loonga...@lists.debian.org
Usertags: loong64

Dear maintainers,

Maybe we need to add loongarch64 support in configure.ac.
Please consider the patch I have attached.

I would like to remind you that the compilation dependency of 
efibootguard is not yet satisfied. Depends on the gnu-efi package when 
compiling efibootguard.
We hope that the gnu-efi source package can support the loongarch 
architecture (LoongArch patch has been merged in upstream).
We have submitted the Bug request to Debian BTS, please see 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025787.


If you have any questions, you can contact me at any time.

thanks,
Dandan Zhang





Bug#1029143: liburiparser-dev: Add uriparser-config.cmake to support cmake based builds

2023-01-18 Thread Gylstorff Quirin
Package: liburiparser-dev
Version: 0.9.7+dfsg-1
Severity: wishlist
Tags: patch

Dear Maintainer,

I have a project which uses find_package(uriparser) in a CMakefile.txt.
Currently it fails on Debian as it liburiparser-dev does not include the
cmake related files.

Best Regards
Quirin Gylstorff


-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf

Kernel: Linux 6.0.0-6-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_USER, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages liburiparser-dev depends on:
pn  liburiparser1  

liburiparser-dev recommends no packages.

liburiparser-dev suggests no packages.



Bug#1026068: efibootguard: build fails if tests are disabled

2022-12-14 Thread Gylstorff Quirin

Thanks for the reporting,

as efibootguard uses the fff test framework which is not available the 
intention was to disable all test. This should fix it:


-# do not run the tests until fff is available in Debian
-override_dh_auto_test:
+override_dh_auto_build:
+   dh_auto_build
help2man -N -o bg_setenv.1   -n bg_setenv   ./bg_setenv
help2man -N -o bg_printenv.1 -n bg_printenv ./bg_printenv
 	help2man -N -o bg_gen_unified_kernel.1 
--version-string=v$(DEB_VERSION_UPSTREAM) tools/bg_gen_unified_kernel

+
+# do not run the tests until fff is available in Debian
+override_dh_auto_test:
+   true


Quirin

On 12/14/22 09:26, Gianfranco Costamagna wrote:

Source: efibootguard
Version: 0.12-1
Severity: serious
tags: patch

Hello, it looks like you are using dh_auto_test to create manpages used 
during dh_auto_install target.
This is a bad thing to do, because if the user overrides the testsuite 
the build will fail.


The correct approach is to probably override dh auto build to create 
manpages (or even dh_auto_install)


and keep auto_test disabled, if you intend to do so.


The proposed patch is:
diff -Nru efibootguard-0.12/debian/changelog 
efibootguard-0.12/debian/changelog
--- efibootguard-0.12/debian/changelog    2022-09-01 08:50:34.0 
+
+++ efibootguard-0.12/debian/changelog    2022-12-14 08:23:29.0 
+

@@ -1,3 +1,10 @@
+efibootguard (0.12-1.1) unstable; urgency=medium
+
+  * Don't create manpages on test target, otherwise build
+    fails if nocheck=true (Closes: #-1)
+
+ -- Gianfranco Costamagna   Wed, 14 Dec 2022 
09:23:29 +0100

+
  efibootguard (0.12-1) unstable; urgency=medium

    * Initial release (Closes: #1001214)
diff -Nru efibootguard-0.12/debian/rules efibootguard-0.12/debian/rules
--- efibootguard-0.12/debian/rules    2022-09-01 08:50:34.0 +
+++ efibootguard-0.12/debian/rules    2022-12-14 08:23:27.0 +
@@ -9,6 +9,9 @@

  # do not run the tests until fff is available in Debian
  override_dh_auto_test:
+
+override_dh_auto_build:
+    dh_auto_build
  help2man -N -o bg_setenv.1   -n bg_setenv   ./bg_setenv
  help2man -N -o bg_printenv.1 -n bg_printenv ./bg_printenv
  help2man -N -o bg_gen_unified_kernel.1 
--version-string=v$(DEB_VERSION_UPSTREAM) tools/bg_gen_unified_kernel




Bug#1001214: Getting EFI Boot Guard into Debian

2022-08-01 Thread Gylstorff Quirin

Control: retitle -1 ITP: efibootguard -- UEFI-based bootloader
Control: owner -1 Quirin Gylstorff 




After an internal discuss I would step up as the Maintainer for 
efibootguard.


Thanks,
Quirin



Bug#1001214: Getting EFI Boot Guard into Debian

2022-07-26 Thread Gylstorff Quirin




On 7/26/22 00:04, Bastian Germann wrote:

Am 24.07.22 um 16:09 schrieb Jan Kiszka:

Hi all,

it would be really great to have EBG as an official package in bookworm.
There is the initial work done by Bastian with contributions by Quirin
already [1], but EBG moved on since then and needs some more work to
support 0.12. Likely, we will need patches from current next as bookworm
is broken with that release. Some bits to account for structural changes
in the latest releases is in [2], possibly not in Debian shape yet.

Bastian, do you have the time to support this? What is needed from your
perspective, what should we contribute?


I have updated the package to build v0.12 but run into:
./configure: line 14997: syntax error near unexpected token 
`-mgeneral-regs-only,'

./configure: line 14997: `AX_CHECK_COMPILE_FLAG(-mgeneral-regs-only,'

Full log at https://salsa.debian.org/debian/efibootguard/-/jobs/3036697

The suggested "next" changes do not fix this.



I create an MR on salsa with the necessary fixes.

Quirin


So if you could provide a patch for this I can hand in the package.
I would prefer not to be responsible for it and can hand over 
maintainership to
somebody who actually uses the software. I can grant git access for that 
person with

a salsa (Gitlab) username provided.

Whoever wants to be the package maintainer please make #1001214 an ITP 
(retitle and own the bug).









Thanks,
Jan

[1] https://salsa.debian.org/debian/efibootguard/
[2]
https://gitlab.com/cip-project/cip-core/isar-cip-core/-/tree/master/recipes-bsp/efibootguard 





Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-20 Thread Gylstorff Quirin

Hi,

...



This package is not provided in stable, so the bug severity will not
be set in serious. I change to important.
Could you check this patch in unstable environment as well?
If everything is okay, I will apply.



I tested it with pbuilder on sid an it builds for me. Attached is the log.

Kind regards
Quirin



Kind regards
Quirin


Best regards,
   Nobuhiro


--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6



dh clean
   dh_clean
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building libubootenv using existing ./libubootenv_0.2.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: building libubootenv in libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: building libubootenv in libubootenv_0.2-1.dsc
I: Generating source changes file for original dsc
dpkg-genchanges: info: including full source code in upload
dpkg-source: info: unapplying 0004-Add-the-static-library-for-installation.patch
dpkg-source: info: unapplying 0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: unapplying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: unapplying 0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
D: cmdline: build --buildresult /var/cache/pbuilder/debian-sid-amd64/result/ --debbuildopts  --debbuildopts  ../libubootenv_0.2-1.dsc
W: cgroups are not available on the host, not using them.
I: pbuilder: network access will be disabled during build
I: Current time: Wed Aug 19 16:23:55 CEST 2020
I: pbuilder-time-stamp: 1597847035
I: Building the build Environment
I: extracting base tarball [/var/cache/pbuilder/debian-sid-amd64-base.tgz]
I: copying local configuration
W: hookdir /var/cache/pbuilder/hook.d/ does not exist, skipping
I: mounting /proc filesystem
I: mounting /sys filesystem
I: creating /{dev,run}/shm
I: mounting /dev/pts filesystem
I: redirecting /dev/ptmx to /dev/pts/ptmx
I: policy-rc.d already exists
D: no hooks of type H found -- ignoring
I: Obtaining the cached apt archive contents
I: Copying source file
I: copying [../libubootenv_0.2-1.dsc]
I: copying [../libubootenv_0.2.orig.tar.gz]
I: copying [../libubootenv_0.2-1.debian.tar.xz]
I: Extracting source
dpkg-source: warning: extracting unsigned source package (libubootenv_0.2-1.dsc)
dpkg-source: info: extracting libubootenv in libubootenv-0.2
dpkg-source: info: unpacking libubootenv_0.2.orig.tar.gz
dpkg-source: info: unpacking libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
dpkg-source: info: applying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: applying 0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: applying 0004-Add-the-static-library-for-installation.patch
I: using fakeroot in build.
I: Installing the build-deps
D: no hooks of type D found -- ignoring
 -> Attempting to satisfy build-dependencies
 -> Creating pbuilder-satisfydepends-dummy package
Package: pbuilder-satisfydepends-dummy
Version: 0.invalid.0
Architecture: amd64
Maintainer: Debian Pbuilder Team 
Description: Dummy package to satisfy dependencies with aptitude - created by pbuilder
 This package was created automatically by pbuilder to satisfy the
 build-dependencies of the package being currently built.
Depends: debhelper (>= 11), cmake, zlib1g-dev, graphviz, doxygen
dpkg-deb: building package 'pbuilder-satisfydepends-dummy' in '/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'.
Selecting previously unselected package pbuilder-satisfydepends-dummy.
(Reading database ... 12389 files and directories currently installed.)
Preparing to unpack .../pbuilder-satisfydepends-dummy.deb ...
Unpacking pbuilder-satisfydepends-dummy (0.invalid.0) ...
dpkg: pbuilder-satisfydepends-dummy: dependency problems, but configuring anyway as you requested:
 pbuilder-satisfydepends-dummy depends on debhelper (>= 11); however:
  Package debhelper is not installed.
 pbuilder-satisfydepends-dummy depends on cmake; however:
  Package cmake is not installed.
 pbuilder-satisfydepends-dummy depends on zlib1g-dev; however:
  Package zlib1g-dev is not installed.
 pbuilder-satisfydepends-dummy depends on graphviz; however:
  Package graphviz is not installed.
 pbuilder-satisfydepends-dummy depends on doxygen; however:
  Package doxygen is not installed.

Setting up pbuilder-satisfydepends-dummy (0.invalid.0) ...
Reading package lists...
Building dependency tree...
Reading state information...
Initializing package states...
Writing extended state information...
Building tag database...
pbuilder-satisfydepends-dummy is already installed at the reques

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-20 Thread Gylstorff Quirin

Hi,

Hi,

2020年8月17日(月) 17:15 Gylstorff Quirin :





On 8/12/20 4:29 AM, Nobuhiro Iwamatsu wrote:

Hi,

Thanks for your report.

2020年8月4日(火) 19:50 Gylstorff Quirin :


Package: libubootenv-tool
Version: 0.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

Dear Maintainer,

I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
error
did occur:
```
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
install TARGETS given no RUNTIME DESTINATION for executable target
"fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
install TARGETS given no RUNTIME DESTINATION for executable target
"fw_setenv".
```


Hmm, I checked this on unstable but didn't reproduce it.
I attached a build log.
Could you tell me the environment you have confirmed?



Sure, I tried to build it on stable(Debian 10.5) with  cmake version 3.13.4.

Attached is the complete log.


This package is not provided in stable, so the bug severity will not
be set in serious. I change to important.
Could you check this patch in unstable environment as well?
If everything is okay, I will apply.


I tested it with pbuilder on sid an it builds for me. Attached is the log.

Kind regards
Quirin




Kind regards
Quirin


Best regards,
   Nobuhiro


--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6

dh clean
   dh_clean
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building libubootenv using existing ./libubootenv_0.2.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: building libubootenv in libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: building libubootenv in libubootenv_0.2-1.dsc
I: Generating source changes file for original dsc
dpkg-genchanges: info: including full source code in upload
dpkg-source: info: unapplying 0004-Add-the-static-library-for-installation.patch
dpkg-source: info: unapplying 0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: unapplying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: unapplying 0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
D: cmdline: build --buildresult /var/cache/pbuilder/debian-sid-amd64/result/ --debbuildopts  --debbuildopts  ../libubootenv_0.2-1.dsc
W: cgroups are not available on the host, not using them.
I: pbuilder: network access will be disabled during build
I: Current time: Wed Aug 19 16:23:55 CEST 2020
I: pbuilder-time-stamp: 1597847035
I: Building the build Environment
I: extracting base tarball [/var/cache/pbuilder/debian-sid-amd64-base.tgz]
I: copying local configuration
W: hookdir /var/cache/pbuilder/hook.d/ does not exist, skipping
I: mounting /proc filesystem
I: mounting /sys filesystem
I: creating /{dev,run}/shm
I: mounting /dev/pts filesystem
I: redirecting /dev/ptmx to /dev/pts/ptmx
I: policy-rc.d already exists
D: no hooks of type H found -- ignoring
I: Obtaining the cached apt archive contents
I: Copying source file
I: copying [../libubootenv_0.2-1.dsc]
I: copying [../libubootenv_0.2.orig.tar.gz]
I: copying [../libubootenv_0.2-1.debian.tar.xz]
I: Extracting source
dpkg-source: warning: extracting unsigned source package (libubootenv_0.2-1.dsc)
dpkg-source: info: extracting libubootenv in libubootenv-0.2
dpkg-source: info: unpacking libubootenv_0.2.orig.tar.gz
dpkg-source: info: unpacking libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
dpkg-source: info: applying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: applying 0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: applying 0004-Add-the-static-library-for-installation.patch
I: using fakeroot in build.
I: Installing the build-deps
D: no hooks of type D found -- ignoring
 -> Attempting to satisfy build-dependencies
 -> Creating pbuilder-satisfydepends-dummy package
Package: pbuilder-satisfydepends-dummy
Version: 0.invalid.0
Architecture: amd64
Maintainer: Debian Pbuilder Team 
Description: Dummy package to satisfy dependencies with aptitude - created by pbuilder
 This package was created automatically by pbuilder to satisfy the
 build-dependencies of the package being currently built.
Depends: debhelper (>= 11), cmake, zlib1g-dev, graphviz, doxygen
dpkg-deb: building package 'pbuilder-satisfydepends-dummy' in '/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'.
Selecting previously unselected package pbuilder-satisfydepends-dummy.
(Reading database ... 12389 files and directories curre

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-19 Thread Gylstorff Quirin



On 8/18/20 1:15 AM, Nobuhiro Iwamatsu wrote:

severity 967487 important
thanks

Hi,

2020年8月17日(月) 17:15 Gylstorff Quirin :





On 8/12/20 4:29 AM, Nobuhiro Iwamatsu wrote:

Hi,

Thanks for your report.

2020年8月4日(火) 19:50 Gylstorff Quirin :


Package: libubootenv-tool
Version: 0.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

Dear Maintainer,

I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
error
did occur:
```
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
install TARGETS given no RUNTIME DESTINATION for executable target
"fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
install TARGETS given no RUNTIME DESTINATION for executable target
"fw_setenv".
```


Hmm, I checked this on unstable but didn't reproduce it.
I attached a build log.
Could you tell me the environment you have confirmed?



Sure, I tried to build it on stable(Debian 10.5) with  cmake version 3.13.4.

Attached is the complete log.


This package is not provided in stable, so the bug severity will not
be set in serious. I change to important.
Could you check this patch in unstable environment as well?
If everything is okay, I will apply.



I rebuild the package with the patch in unstable with pbuilder. The log 
is attached.




Kind regards
Quirin


Best regards,
   Nobuhiro


--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6



--
Quirin
dh clean
   dh_clean
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building libubootenv using existing ./libubootenv_0.2.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: building libubootenv in libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: building libubootenv in libubootenv_0.2-1.dsc
I: Generating source changes file for original dsc
dpkg-genchanges: info: including full source code in upload
dpkg-source: info: unapplying 0004-Add-the-static-library-for-installation.patch
dpkg-source: info: unapplying 0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: unapplying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: unapplying 0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
D: cmdline: build --buildresult /var/cache/pbuilder/debian-sid-amd64/result/ --debbuildopts  --debbuildopts  ../libubootenv_0.2-1.dsc
W: cgroups are not available on the host, not using them.
I: pbuilder: network access will be disabled during build
I: Current time: Wed Aug 19 16:23:55 CEST 2020
I: pbuilder-time-stamp: 1597847035
I: Building the build Environment
I: extracting base tarball [/var/cache/pbuilder/debian-sid-amd64-base.tgz]
I: copying local configuration
W: hookdir /var/cache/pbuilder/hook.d/ does not exist, skipping
I: mounting /proc filesystem
I: mounting /sys filesystem
I: creating /{dev,run}/shm
I: mounting /dev/pts filesystem
I: redirecting /dev/ptmx to /dev/pts/ptmx
I: policy-rc.d already exists
D: no hooks of type H found -- ignoring
I: Obtaining the cached apt archive contents
I: Copying source file
I: copying [../libubootenv_0.2-1.dsc]
I: copying [../libubootenv_0.2.orig.tar.gz]
I: copying [../libubootenv_0.2-1.debian.tar.xz]
I: Extracting source
dpkg-source: warning: extracting unsigned source package (libubootenv_0.2-1.dsc)
dpkg-source: info: extracting libubootenv in libubootenv-0.2
dpkg-source: info: unpacking libubootenv_0.2.orig.tar.gz
dpkg-source: info: unpacking libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
dpkg-source: info: applying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: applying 0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: applying 0004-Add-the-static-library-for-installation.patch
I: using fakeroot in build.
I: Installing the build-deps
D: no hooks of type D found -- ignoring
 -> Attempting to satisfy build-dependencies
 -> Creating pbuilder-satisfydepends-dummy package
Package: pbuilder-satisfydepends-dummy
Version: 0.invalid.0
Architecture: amd64
Maintainer: Debian Pbuilder Team 
Description: Dummy package to satisfy dependencies with aptitude - created by pbuilder
 This package was created automatically by pbuilder to satisfy the
 build-dependencies of the package being currently built.
Depends: debhelper (>= 11), cmake, zlib1g-dev, graphviz, doxygen
dpkg-deb: building package 'pbuilder-satisfydepends-dummy' in '/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'.
Selecting previously unselected package pbui

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-17 Thread Gylstorff Quirin



On 8/12/20 4:29 AM, Nobuhiro Iwamatsu wrote:

Hi,

Thanks for your report.

2020年8月4日(火) 19:50 Gylstorff Quirin :


Package: libubootenv-tool
Version: 0.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

Dear Maintainer,

I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
error
did occur:
```
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
   install TARGETS given no RUNTIME DESTINATION for executable target
   "fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
   install TARGETS given no RUNTIME DESTINATION for executable target
   "fw_setenv".
```


Hmm, I checked this on unstable but didn't reproduce it.
I attached a build log.
Could you tell me the environment you have confirmed?



Sure, I tried to build it on stable(Debian 10.5) with  cmake version 3.13.4.

Attached is the complete log.

Kind regards
Quirin



I fix the build error by moving the
```
include("GNUInstallDirs")
```
from Subject: [PATCH 2/4] Add support GNUInstallDirs
before
```
  add_subdirectory (src)
```



I see.
Indeed, this will fix your issue.


Best regards,
Quirin


Best regards,
   Nobuhiro


-- System Information:
Debian Release: 10.5
   APT prefers stable
   APT policy: (800, 'stable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-10-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled






dpkg-buildpackage: info: source package libubootenv
dpkg-buildpackage: info: source version 0.2-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Nobuhiro Iwamatsu 

 dpkg-source -I --before-build .
dpkg-buildpackage: info: host architecture armhf
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 
0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
dpkg-source: info: applying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: applying 
0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: applying 0004-Add-the-static-library-for-installation.patch
 fakeroot debian/rules clean
dh clean
   dh_clean
 dpkg-source -I -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building libubootenv using existing 
./libubootenv_0.2.orig.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: building libubootenv in libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: building libubootenv in libubootenv_0.2-1.dsc
 debian/rules build
dh build
   dh_update_autotools_config
   dh_autoreconf
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/home/builder/libubootenv/git'
dh_auto_configure \
-- -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_C_FLAGS_RELEASE="-g -O2 
-fdebug-prefix-map=/home/builder/libubootenv/git=. -fstack-protector-strong 
-Wformat -Werror=format-security" 
-DCMAKE_EXE_LINKER_FLAGS_RELEASE="-Wl,-z,relro" -DBUILD_DOCS=ON 
-DCMAKE_INSTALL_INCLUDEDIR="include/arm-linux-gnueabihf" \
-DCMAKE_SHARED_LINKER_FLAGS_RELEASE="-Wl,-z,relro"
cd obj-arm-linux-gnueabihf && cmake -DCMAKE_INSTALL_PREFIX=/usr 
-DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc 
-DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON 
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run 
"-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_INSTALL_LIBDIR=lib/arm-linux-gnueabihf -DCMAKE_VERBOSE_MAKEFILE=ON 
"-DCMAKE_C_FLAGS_RELEASE=-g -O2 
-fdebug-prefix-map=/home/builder/libubootenv/git=. -fstack-protector-strong 
-Wformat -Werror=format-security" -DCMAKE_EXE_LINKER_FLAGS_RELEASE=-Wl,-z,relro 
-DBUILD_DOCS=ON -DCMAKE_INSTALL_INCLUDEDIR=include/arm-linux-gnueabihf 
-DCMAKE_SHARED_LINKER_FLAGS_RELEASE=-Wl,-z,relro ..
-- The C compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_setenv".


-- Found Doxygen: /usr/bin/doxygen (found version "1.8.13") found components:  
doxygen dot 
Doxygen build started
-- Configuring in

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-04 Thread Gylstorff Quirin
Package: libubootenv-tool
Version: 0.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

Dear Maintainer,

I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
error
did occur:
```
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_setenv".
```

I fix the build error by moving the 
```
include("GNUInstallDirs")
```
from Subject: [PATCH 2/4] Add support GNUInstallDirs
before
```
 add_subdirectory (src)
```

Best regards,
Quirin

-- System Information:
Debian Release: 10.5
  APT prefers stable
  APT policy: (800, 'stable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-10-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
>From c0ada30c985cda300c94ab243944b5e70df40bc1 Mon Sep 17 00:00:00 2001
From: Quirin Gylstorff 
Date: Mon, 3 Aug 2020 18:04:03 +0200
Subject: [PATCH] libubootenv: Change possition of include

Cmake modules should be included before the usage of variables or
function from the module.

Signed-off-by: Quirin Gylstorff 
---
 .../0002-Add-support-GNUInstallDirs.patch | 19 ++-
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/debian/patches/0002-Add-support-GNUInstallDirs.patch 
b/debian/patches/0002-Add-support-GNUInstallDirs.patch
index abe9b93..41c3bbe 100644
--- a/debian/patches/0002-Add-support-GNUInstallDirs.patch
+++ b/debian/patches/0002-Add-support-GNUInstallDirs.patch
@@ -1,4 +1,4 @@
-From b17d194bd8285a19382a902a0bec9e5e042df064 Mon Sep 17 00:00:00 2001
+From 6e8ce00347b276a336bb3006f2fccce81d150fc6 Mon Sep 17 00:00:00 2001
 From: Nobuhiro Iwamatsu 
 Date: Tue, 16 Apr 2019 08:52:01 +0900
 Subject: [PATCH 2/4] Add support GNUInstallDirs
@@ -9,24 +9,25 @@ installation compatible with GNU.
 https://cmake.org/cmake/help/v3.14/module/GNUInstallDirs.html
 
 Signed-off-by: Nobuhiro Iwamatsu 
+Signed-off-by: Quirin Gylstorff 
 ---
  CMakeLists.txt | 2 ++
  src/CMakeLists.txt | 8 
  2 files changed, 6 insertions(+), 4 deletions(-)
 
 diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 104969e..1d66f60 100644
+index 104969e..57477fc 100644
 --- a/CMakeLists.txt
 +++ b/CMakeLists.txt
-@@ -14,6 +14,8 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99")
- include_directories ("${PROJECT_SOURCE_DIR}/src")
- add_subdirectory (src)
+@@ -10,6 +10,8 @@ add_definitions(-DVERSION="${VERSION}")
+ 
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99")
  
 +include("GNUInstallDirs")
 +
- # first we can indicate the documentation build as an option and set it to ON 
by default
- option(BUILD_DOC "Build documentation" ON)
- 
+ #set(CMAKE_C_FLAGS_DEBUG "-g")
+ include_directories ("${PROJECT_SOURCE_DIR}/src")
+ add_subdirectory (src)
 diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
 index ea5979c..d97f221 100644
 --- a/src/CMakeLists.txt
@@ -44,5 +45,5 @@ index ea5979c..d97f221 100644
 +install (TARGETS fw_printenv DESTINATION "${CMAKE_INSTALL_BINDIR}")
 +install (TARGETS fw_setenv DESTINATION "${CMAKE_INSTALL_BINDIR}")
 -- 
-2.24.0
+2.20.1
 
-- 
2.20.1

>From c0ada30c985cda300c94ab243944b5e70df40bc1 Mon Sep 17 00:00:00 2001
From: Quirin Gylstorff 
Date: Mon, 3 Aug 2020 18:04:03 +0200
Subject: [PATCH] libubootenv: Change possition of include

Cmake modules should be included before the usage of variables or
function from the module.

Signed-off-by: Quirin Gylstorff 
---
 .../0002-Add-support-GNUInstallDirs.patch | 19 ++-
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/debian/patches/0002-Add-support-GNUInstallDirs.patch 
b/debian/patches/0002-Add-support-GNUInstallDirs.patch
index abe9b93..41c3bbe 100644
--- a/debian/patches/0002-Add-support-GNUInstallDirs.patch
+++ b/debian/patches/0002-Add-support-GNUInstallDirs.patch
@@ -1,4 +1,4 @@
-From b17d194bd8285a19382a902a0bec9e5e042df064 Mon Sep 17 00:00:00 2001
+From 6e8ce00347b276a336bb3006f2fccce81d150fc6 Mon Sep 17 00:00:00 2001
 From: Nobuhiro Iwamatsu 
 Date: Tue, 16 Apr 2019 08:52:01 +0900
 Subject: [PATCH 2/4] Add support GNUInstallDirs
@@ -9,24 +9,25 @@ installation compatible with GNU.
 https://cmake.org/cmake/help/v3.14/module/GNUInstallDirs.html
 
 Signed-off-by: Nobuhiro Iwamatsu 
+Signed-off-by: Quirin Gylstorff 
 ---
  CMakeLists.txt | 2 ++
  src/CMakeLists.txt | 8 
  2 files changed, 6 insertions(+), 4 deletions(-)
 
 diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 104969e..1d66f60 100644
+index 104969e..57477fc 100644
 --- a/CMakeLists.txt

Bug#934234: e2fsprogs: Copying file > 4G with opt -d corrupts data

2019-08-08 Thread Gylstorff Quirin
Package: e2fsprogs
Version: 1.44.5-1
Severity: normal
Tags: lfs

Dear Maintainer,

I created a rootfs containing a file with a size greater than 5G. I 
used mkfs to apply the rootfs on an image. If I applied the Image the 
file had changed (verified with md5sum). This bug is fixed upstream[1] with 
version 1.44.6. The fixing commit is 1eec7413677ee15182470928c7236969d32d8426.
[1] git://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git


Steps to reproduce:
mkdir rootfs
dd if=/dev/urandom of=rootfs/bigfile bs=4M count=1280
dd if=/dev/zero of=image bs=4M count=2000
mkfs.ext4 image -d rootfs
mount -o loop,ro image /mnt
md5sum rootfs/bigfile /mnt/bigfile


Kind regards
Quirin

-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages e2fsprogs depends on:
ii  libblkid12.33.1-0.1
ii  libc62.28-10
ii  libcom-err2  1.44.5-1
ii  libext2fs2   1.44.5-1
ii  libss2   1.44.5-1
ii  libuuid1 2.33.1-0.1

Versions of packages e2fsprogs recommends:
pn  e2fsprogs-l10n  

Versions of packages e2fsprogs suggests:
pn  e2fsck-static  
pn  fuse2fs
pn  gpart  
ii  parted 3.2-25

-- no debconf information