Bug#962806: RFS: cwm/6.6-2 -- lightweight and efficient window manager for X11
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "cwm" * Package name: cwm Version : 6.6-2 Upstream Author : Leah Neukirchen * URL : https://github.com/leahneukirchen/cwm * License : ISC * Vcs : https://github.com/jamesmcdonald/cwm Section : x11 It builds those binary packages: cwm - lightweight and efficient window manager for X11 To access further information about this package, please visit the following URL: https://mentors.debian.net/package/cwm Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/c/cwm/cwm_6.6-2.dsc Changes since the last upload: * Allow override of pkg-config location to support cross-platform builds (Closes: #960512) * Add VCS fields to debian/control * Update standards version to 4.5.0 * Update debhelper compat to 13 Regards, -- James McDonald
Bug#960319: RFS: cowsay/3.03+dfsg2-8 -- configurable talking cow
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "cowsay" * Package name: cowsay Version : 3.03+dfsg2-8 Upstream Author : Tony Monroe * URL : https://web.archive.org/web/20120527202447/http://www.nog.net/~tony/warez/cowsay.shtml * License : COWSAY * Vcs : https://salsa.debian.org/debian/cowsay Section : games It builds those binary packages: cowsay - configurable talking cow cowsay-off - configurable talking cow (offensive cows) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/cowsay Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/c/cowsay/cowsay_3.03+dfsg2-8.dsc Changes since the last upload: * Fix capitalization of man page title as per man-pages(7) * Bump Standards-Version to 4.5.0 * Bump debhelper compat to 13 * Clear up various lintian errors Regards, -- James McDonald
Bug#960252: RFS: cwm/6.6-1 -- lightweight and efficient window manager for X11
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "cwm" * Package name: cwm Version : 6.6-1 Upstream Author : Leah Neukirchen * URL : https://github.com/leahneukirchen/cwm * License : ISC * Vcs : None Section : x11 It builds those binary packages: cwm - lightweight and efficient window manager for X11 To access further information about this package, please visit the following URL: https://mentors.debian.net/package/cwm Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/c/cwm/cwm_6.6-1.dsc Changes since the last upload: * Import upstream 6.6 sources * Update Debian patches to track 6.6 changes * Update metadata to reflect new upstream locations Regards, -- James McDonald
Bug#943730: RFS: cowsay/3.03+dfsg2-7 [ITA] -- configurable talking cow
On Tue, Oct 29, 2019 at 11:00:28AM +0100, Stephen Kitt wrote: Thanks for preparing this! I’ll gladly help you get your package into the archive. Great, thanks! I’ve reviewed the changes, and they look good to me, apart from the debhelper 12 bump: could you follow the manpage’s recommendation, and use debhelper-compat instead of debian/compat? Aha, I didn't notice that had changed. I've pushed an updated version now. Also, do you have access to the repository on Salsa? Nope, only read access. I've pushed my repo to https://gitlab.com/jamesmcdonald/cowsay for the moment, but I wasn't sure whether I should update the Vcs fields or see about getting access to Salsa. -- James McDonald signature.asc Description: PGP signature
Bug#943730: RFS: cowsay/3.03+dfsg2-7 [ITA] -- configurable talking cow
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "cowsay" * Package name: cowsay Version : 3.03+dfsg2-7 Upstream Author : Tony Monroe * URL : https://web.archive.org/web/20120527202447/http://www.nog.net/~tony/warez/cowsay.shtml * License : COWSAY * Vcs : https://salsa.debian.org/debian/cowsay Section : games It builds those binary packages: cowsay - configurable talking cow cowsay-off - configurable talking cow (offensive cows) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/cowsay Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/c/cowsay/cowsay_3.03+dfsg2-7.dsc Changes since the last upload: * New maintainer (closes: #910035) * Fix lintian warning about spelling of 'balloons' in patch * Add fox cow (closes: #888229) * Bump Standards-Version to 4.4.1 * Bump debhelper compat to 12 Regards, -- James McDonald
Bug#910035: ITA cowsay
Control: retitle -1 ITA: cowsay -- configurable talking cow I would like to adopt this package. I'll build it and look for a sponsor. -- James McDonald
Bug#914132: RFS: cwm/6.3-1 -- lightweight and efficient window manager for X11
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "cwm": * Package name: cwm Version : 6.3-1 Upstream Author : Marius Aamodt Eriksen , various others, see debian/copyright * URL : https://github.com/chneukirchen/cwm * License : ISC/BSD-2-clause/BSD-3-clause Section : x11 It builds those binary packages: cwm -- lightweight and efficient window manager for X11 To access further information about this package, please visit the following URL: https://mentors.debian.net/package/cwm Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/c/cwm/cwm_6.3-1.dsc More information about cwm can be obtained from https://github.com/chneukirchen/cwm. The Debian packaging fork is maintained at https://github.com/jamesmcdonald/cwm. Changes since the last upload: * Import upstream 6.3 sources (Closes: #913992) * Update Debian patches to track 6.3 changes * Update standards version to 4.2.1 * Update debhelper compat to 11 * Enable hardening build flags in debian/rules * Update debian/copyright for changes in files * Added migrate-config.pl script to doc/examples, which can be used to convert config from cwm 5.x to the new format * Update README.Debian with information about migrate-config.pl Regards, -- James McDonald signature.asc Description: PGP signature
Bug#849308: Backport of wireguard
Would it make sense to create stretch-backports packages of wireguard? That way it would be installable on machines running stable with the same apt-get override, but without requiring special pinning configuration or having the unstable repo available. -- James McDonald signature.asc Description: PGP signature
Bug#783884: jessie-pu: package cwm/5.5-1
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu
This is a backport of a patch to fix lookups on XFS and other
filesystems which don't populate d_type in struct dirent. The effect of
this bug is that using the 'exec' or 'wm' functions in cwm can't search
for executables. The fix is to add a test using lstat() where the
existing test fails. The debdiff is attached.
-- System Information:
Debian Release: 8.0
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru cwm-5.5/debian/changelog cwm-5.5/debian/changelog
--- cwm-5.5/debian/changelog 2015-04-30 23:04:09.0 +0200
+++ cwm-5.5/debian/changelog 2015-04-30 23:04:47.0 +0200
@@ -1,3 +1,10 @@
+cwm (5.5-1+deb8u1) stable; urgency=low
+
+ * Fix "Lookups for 'exec' and 'wm' fail on XFS" by adding an extra check
+ using lstat() if the d_type check fails (Closes: #783588)
+
+ -- James McDonald Thu, 30 Apr 2015 08:05:25 +0200
+
cwm (5.5-1) unstable; urgency=low
* Initial release (Closes: #505924)
diff -Nru cwm-5.5/debian/patches/lstat-check cwm-5.5/debian/patches/lstat-check
--- cwm-5.5/debian/patches/lstat-check 1970-01-01 01:00:00.0 +0100
+++ cwm-5.5/debian/patches/lstat-check 2015-04-30 23:04:47.0 +0200
@@ -0,0 +1,39 @@
+From: James McDonald
+Description: Fix 'exec' lookups for filesystems which don't support d_type.
+ Lookups in kbfunc_exec fail on filesystems where the d_type field of
+ struct dirent is not populated, such as XFS. This patch adds an additional
+ test with lstat(2) if the initial test fails.
+--- a/kbfunc.c
b/kbfunc.c
+@@ -236,6 +236,7 @@
+ struct menu *mi;
+ struct menu_q menuq;
+ int l, i, cmd = arg->i;
++ struct stat sb;
+
+ switch (cmd) {
+ case CWM_EXEC_PROGRAM:
+@@ -266,15 +267,20 @@
+ continue;
+
+ while ((dp = readdir(dirp)) != NULL) {
+- /* skip everything but regular files and symlinks */
+- if (dp->d_type != DT_REG && dp->d_type != DT_LNK)
+-continue;
+ (void)memset(tpath, '\0', sizeof(tpath));
+ l = snprintf(tpath, sizeof(tpath), "%s/%s", paths[i],
+ dp->d_name);
+ /* check for truncation etc */
+ if (l == -1 || l >= (int)sizeof(tpath))
+ continue;
++ /* skip everything but regular files and symlinks */
++ if (dp->d_type != DT_REG && dp->d_type != DT_LNK) {
++/* use an additional stat-based check in case d_type isn't supported */
++if (lstat(tpath, &sb) < 0)
++ continue;
++if (!S_ISREG(sb.st_mode) && !S_ISLNK(sb.st_mode))
++ continue;
++ }
+ if (access(tpath, X_OK) == 0)
+ menuq_add(&menuq, NULL, "%s", dp->d_name);
+ }
diff -Nru cwm-5.5/debian/patches/series cwm-5.5/debian/patches/series
--- cwm-5.5/debian/patches/series 2015-04-30 23:04:09.0 +0200
+++ cwm-5.5/debian/patches/series 2015-04-30 23:04:47.0 +0200
@@ -3,3 +3,4 @@
support-external-cflags
rename-cwm
change-default-binaries
+lstat-check
Bug#783588: cwm: Lookups for 'exec' and 'wm' fail on XFS
Package: cwm Version: 5.6-1 Severity: normal On the XFS filesystem, lookups in the 'exec' (M-?) and 'wm' (CM-w) popups don't work. It is still possible to run commands by typing their full name, but the menu does not get populated. This is caused by the check relying on d_type being populated in the struct dirent, which XFS does not do. -- System Information: Debian Release: 8.0 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages cwm depends on: ii libc6 2.19-18 ii libfontconfig1 2.11.0-6.3 ii libx11-62:1.6.2-3 ii libxft2 2.3.2-1 ii libxinerama12:1.1.3-1+b1 ii libxrandr2 2:1.4.2-1+b1 Versions of packages cwm recommends: pn xscreensaver cwm suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#782418: cwm: FTBFS on kfreebsd: kbfunc.c:327:18: error: 'HOST_NAME_MAX' undeclared
On Sat, Apr 18, 2015 at 08:37:00PM +0200, Jakub Wilk wrote: The patch itself looks good to me, but the patch header is no longer accurate. Fixed. -- James McDonald signature.asc Description: Digital signature
Bug#782418: cwm: FTBFS on kfreebsd: kbfunc.c:327:18: error: 'HOST_NAME_MAX' undeclared
On Thu, Apr 16, 2015 at 10:42:37PM +0200, Jakub Wilk wrote: I don't think this is correct. At least on FreeBSD 9.0, sysconf(_SC_HOST_NAME_MAX) returns always -1 (which means that there is no limit), so the size of hostbuf is 0. Ahh, that's unfortunate. I tested on FreeBSD 10.0 which was a poor choice. The comments in the FreeBSD syslimits.h implied that sysconf() was the way to go. Portability is complicated! How about falling back to _POSIX_HOST_NAME_MAX (which is 255, which should hopefully be enough for everybody) if HOST_NAME_MAX is not defined? That's a sensible alternative. In fact, I discovered upstream have applied that exact solution for the upcoming version to allow building on MacOS X which is BSDish. I have modified the patch and tested building and using the related SSH functionality on Debian GNU/kFreeBSD stable, where it now works fine. Thanks for the sanity checking. The updated package is on mentors. -- James McDonald signature.asc Description: Digital signature
Bug#782418: cwm: FTBFS on kfreebsd: kbfunc.c:327:18: error: 'HOST_NAME_MAX' undeclared
On Mon, Apr 13, 2015 at 06:31:38PM +0200, Jakub Wilk wrote: * James McDonald , 2015-04-12, 09:18: I have prepared 5.6-2 with a patch for this which builds on both Linux and kFreeBSD. Where can I get this new version? I can't see anything on mentors.d.n. It is indeed on mentors in the usual place: http://mentors.debian.net/package/cwm or directly at: http://mentors.debian.net/debian/pool/main/c/cwm/cwm_5.6-2.dsc -- James McDonald -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#782418: cwm: FTBFS on kfreebsd: kbfunc.c:327:18: error: 'HOST_NAME_MAX' undeclared
On Sat, Apr 11, 2015 at 11:50:05PM +0200, Jakub Wilk wrote: | kbfunc.c:327:18: error: 'HOST_NAME_MAX' undeclared (first use in this function) It looks like FreeBSD forces people to call sysconf() to get the value using _SC_HOST_NAME_MAX instead of defining HOST_NAME_MAX itself. Fortunately this approach appears to be portable to Linux (and other BSDs). I have prepared 5.6-2 with a patch for this which builds on both Linux and kFreeBSD. -- James McDonald signature.asc Description: Digital signature
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On Tue, Apr 29, 2014 at 11:02:00AM +0200, Jakub Wilk wrote: * James McDonald , 2014-04-29, 08:57: There were some more, like group.c, Hmm, groups.c seems to have * Copyright (c) 2004 Andy Adamson * Copyright (c) 2004,2005 Marius Aamodt Eriksen and the ISC license, which is exactly what was in the previous copyright file. Am I missing something? I added it, so it should all be fine. Just ignore me :) I went through each file and I think I have them all now. Looks good now. Great! Could you bump date in debian/changelog, so that it's closer to the present? :) Haha, yes, done! -- James signature.asc Description: Digital signature
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On Mon, Apr 28, 2014 at 11:32:57PM +0200, Jakub Wilk wrote: * Jakub Wilk , 2014-04-27, 20:25: License of queue.h is not documented in the copyright file. Copyright holders for the following files are documented in the copyright file: There were some more, like group.c, which were also missing details. I went through each file and I think I have them all now. -- James signature.asc Description: Digital signature
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On Sun, Apr 27, 2014 at 08:25:54PM +0200, Jakub Wilk wrote: * James McDonald , 2014-04-14, 16:52: I also added 'openbsd-cwm', as it is no longer cleaned after a signed build because the Makefile changes get reverted during signing. I don't think I understand. What do you mean by “signed build” and “during signing”? Sorry, that wasn't very clear. When I run debuild, it reverses the patches at the end of the build to perform the signing. After that happens, the Makefile is reverted, so a clean will no longer remove openbsd-cwm; it will try to remove cwm instead. Adding the output binary to debian/clean fixes this. It would be nice to fix these dpkg-shlibdeps warnings: dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/cwm/usr/bin/openbsd-cwm was not linked against libfontconfig.so.1 (it uses none of the library's symbols) dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/cwm/usr/bin/openbsd-cwm was not linked against libfreetype.so.6 (it uses none of the library's symbols) That struck me as well. I will ask upstream about this. But that's neither very important nor urgent. I think I can upload the package as-is if you prefer so. If you could, that would be fantastic. I will continue to try to improve the packaging either way. -- James signature.asc Description: Digital signature
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On 14 April 2014 16:01, Jakub Wilk wrote: > * James McDonald , 2014-04-10, 20:46: >> I have added a simple patch to fix this for the time being. > > Great. Now that all *FLAGS from environment are honoured, there should be > need to pass CFLAGS explicitly in debian/rules; just calling dh_auto_build > should be enough. Fixed. > You could avoid the dh_auto_clean override by adding “changelog” to > debian/clean. Good plan. I also added 'openbsd-cwm', as it is no longer cleaned after a signed build because the Makefile changes get reverted during signing. >> haven't modified the contents of the man pages. Should I do so? > > I think so. > >> If so, just where the binary name is referenced, or globally? > > The former. Done. > The default locking program is “xlock”. But we don't have “xlock” in Debian, > so it's probably not the best choice… I have changed the default to "xscreensaver-command -lock", and added information in README.Debian explaining that xscreensaver has to be running for that to work. I also added a Recommends: xscreensaver. > The default terminal emulator is “xterm”. I think that “x-terminal-emulator” > (see policy §11.8.3) would be a better choice. Quite right. I have made that change. > (But if you choose to keep > xterm as the default, then please add “xterm” to Recommends. I didn't have > xterm installed, and not being able to spawn a terminal was rather > unpleasant experience.) Indeed. Furthermore, it means customisation of alternatives will be properly reflected by the default window manager configuration. > Was the priority of the x-window-manager alternative computed in accordance > with Policy §11.8.4? (I don't think it was, but I could be wrong.) No, it wasn't. So many policies to learn! I have fixed it now. -- James -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On 14 March 2014 22:14, Jakub Wilk wrote: > * James McDonald , 2014-03-14, 12:01: > > An unintended side-effect of passing CFLAGS to make is that now warnings > (except -Wformat) are no longer enabled. :/ > > Perhaps upstream could fix their makefile, so that they honour CFLAGS from > environment? It's a bit odd that they do it with CPPFLAGS and LDFLAGS, but > not with CFLAGS. I have added a simple patch to fix this for the time being. The next upstream tagged release will not be until shortly before OpenBSD 5.6 is released. >> I replaced it with a binary key. I had called it .php with an armoured key >> because that made lintian happy. > > Nice typo! *giggle* Doh! >> I will speak to upstream and try to resolve this. To my mind something >> like openbsd-cwm or calmwm would make sense. > > Great, thanks. I have modified the package to rename the binary, manual page and .desktop file to openbsd-cwm, and added a README.Debian to note this change. I haven't modified the contents of the man pages. Should I do so? If so, just where the binary name is referenced, or globally? > I wonder if extracting upstream changelog automatically from README wouldn't > be a better strategy than manually maintaining a patch. Good idea. I put the generation in debian/rules. > I'd prefer if Debian changelog for initial release contained only a single > entry. Done. Cheers, James -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
I have packaged the new version of cwm, 5.5, available at: dget -x http://mentors.debian.net/debian/pool/main/c/cwm/cwm_5.5-1.dsc It may be necessary to modify this bug to reflect that. On 24 February 2014 14:09, Jakub Wilk wrote: > It would be better to use dpkg-buildflags instead of hardcoding the flags in > debian/rules. Done, thanks for the tip. > gpg doesn't grok ASCII-armored keyrings. uscan can unarmor them, but it does > it only if the extension is ".asc". So now the verification fails: I replaced it with a binary key. I had called it .php with an armoured key because that made lintian happy. It doesn't seem to like a .asc file. > FWIW, you could use this in the override instead: > dh_auto_install -- PREFIX=/usr Done, thanks. > The whole EXAMPLE CONFIGURATION section looks like something that should be > copy-pasteable, so it should use minuses. > > These two needs fixing, too: > * "The modifier keys come first, followed by a ‘‐’." > * "The ‘‐’ should be followed by either a keysym name," The new version has a modified manual page, so I've updated the patch for that. I think I replaced all of them. >> As regards the name /usr/bin/cwm, is there a reference for the correct or >> recommended way to rename files in the event of such collisions? > > I'm not sure if you ask about politics or technicalities. I'll assume it's > about both. :) The politics more than the technicalities :) I will speak to upstream and try to resolve this. To my mind something like openbsd-cwm or calmwm would make sense. > Use mv(1). :P Thanks :P Cheers, James -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
On 17 February 2014 23:11, Jakub Wilk wrote: > > * James McDonald , 2014-02-15, 14:46: >> >> http://mentors.debian.net/debian/pool/main/c/cwm/cwm_5.1-1.dsc Thanks for taking the time to review this package. I've attempted to fix some of these problems, but I also have some questions. I have pushed the latest package to mentors. > blhc says that at least some parts of the package were built without > hardening: > >> CFLAGS missing (-fstack-protector --param=ssp-buffer-size=4 -Wformat >> -Werror=format-security): cc -c -Wall -O2 -g -D_FORTIFY_SOURCE=2 `pkg-config >> --cflags fontconfig x11 xft xinerama xrandr` calmwm.c I have modified debian/rules to override CFLAGS and include these additions. > The compiler warns about use of a deprecated function: > >> menu.c:469:2: warning: 'XKeycodeToKeysym' is deprecated (declared at >> /usr/include/X11/Xlib.h:1699) [-Wdeprecated-declarations] > > > ...and about implicit function declaration: > >> parse.y:92:4: warning: implicit declaration of function 'asprintf' >> [-Wimplicit-function-declaration] These problems have been fixed in the upstream HEAD, but not yet in a tagged release. I have spoken to the maintainers, and they expect a release including these changes in about a month. I will apply my packaging to that new version, which should fix these issues. > Upstream PGP-signed his tarball, so you may want to enable signature checking > in d/watch. Done. The lintian on mentors doesn't seem to like the new debian/upstream/signing-key.asc yet, so I've put the key in debian/upstream-signing-key.pgp for the moment. > Any reason add-changelog is not included in d/patches/series? PEBKAC. Fixed. > I'd rather not patch upstream makefile to change PREFIX, but override it in > debian/rules instead. I have made this change. That does make more sense. > fix-man-hyphens is not complete. There are more places where hyphen is used > as minus sign, although likely Lintian is not smart enough to detect them. I'm not sure exactly which of them to fix. Should I just mark up the hyphens in the 'bind' and 'mousebind' sections of the description, or should all the hyphens in the example configuration also count as minus signs? > Typo in the package description: > "etc" -> "etc." > > The description is oddly wrapped. The line ending with "virtual desktop" > could be two words longer. Both fixed. > Enumerated lists in d/copyright are not formatted correctly. Please see bug > #700970. Good point. I've added spaces as per your example. > Upstream embeds a few BSD-specific functions (fgetln, strlcat, strlcpy, > strtonum). It would be nice if Debian package could link to libbsd instead of > using these embedded copies. I have not included this patch, but I am now running it on my desktop. The upstream porter wasn't keen to add a dependency on libbsd as it doesn't seem to be used a lot. It might affect portability to some Linux distributions or potentially compatibility with the OpenBSD original. > Typo in client.c: > cant -> can't Added a patch to fix this. As regards the name /usr/bin/cwm, is there a reference for the correct or recommended way to rename files in the event of such collisions? Cheers, James -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#739056: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "cwm". This is a resubmission after #677935 was closed when I couldn't find a sponsor. * Package name: cwm Version : 5.1-1 Upstream Author : Christian Neukirchen * URL : https://github.com/chneukirchen/cwm * License : ISC Section : x11 It builds those binary packages: cwm - Lightweight and efficient window manager for X11 To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cwm Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cwm/cwm_5.1-1.dsc More information about cwm can be obtained from https://en.wikipedia.org/wiki/Cwm_(window_manager). It is one of the default window managers available in OpenBSD. Changes since the last upload: Initial release (Closes: #505924) Regards, James McDonald -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#505924: cwm
On 08/04/2013 20:18, Nicholas Bamber wrote: I have to apologize but I have been overwhelmed by stuff and I have to cut back. I am sure you will find someone else to sponsor this. I know the feeling all too well! Thanks for all your advice; it helped a lot in getting the package into shape. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#505924: cwm
On 26 Nov 2012, at 21:37, Nicholas Bamber wrote: > 1.) I didn't notice it first time but the last paragraph of the long > description is a bit like advertising. I see what you mean. I've removed some of it and reworded the rest. Does that look OK now? > 2.) The upstream changelog issue is still there. I seem to recall > suggesting some solutions but at the least there should be a lintian > override. As this is the first Linux release of cwm, I've just copied the 'initial release' changelog from the README file. For future releases (hopefully coming soon) I'll make sure there is a more detailed log of changes based on the OpenBSD logs. > 3.) I am suspicious of cwm.postinst. I could look into what is required > a bit more, but let me know what you think about that. This was derived from the behaviour of various other windows managers, including blackbox, openbox and fvwm. It's in line with the DPM as well: http://www.debian.org/doc/debian-policy/ap-pkg-alternatives.html Cheers, Jame
Bug#505924: cwm
Hi Nicholas, Finally found some time to implement these changes! On 21 Sep 2012, at 01:56, Nicholas Bamber wrote: > I followed your advice and it works. I can see the attraction of using > cwm this way. However it might just be a step too far for me as copy and > paste seems not to work. That might depend on which software you're using. For example, xterm will only support select-to-copy, middleclick-to-paste whereas eg gnome-terminal supports copy and paste in the Gnome/KDE fashion as well. The window manager itself doesn't restrict this but I know I've had similar frustrations mixing apps from different toolkits. > then indeed I do get cwm. However the key bindings (as documented in the > man page) do not work. However I also notice that even under > LXDE/openbox the xterm key bindings do not work. So I suspect it might > be an LXDE issue. I'll try and follow up with the LXDE people. That's interesting. I haven't had a chance to experiment with LXDE but that does sound like something else in its session is trapping key bindings. > Actually I can fairly easily sponsor you to get access to collab-maint > and I've done so for people before. On the other hand github is fine and > I use it for some of my packages. If you really want to own the > packaging then go for github or equivalent. If you're happy to let DD's > step in and fix problems directly in the repository then go for > collab-maint. Getting access to collab-maint would be great. I have actually pushed my changes to github at https://github.com/jamesmcdonald/cwm/tree/v5.1-debian but I've still not set it up to use git-buildpackage. It's really just so I can track my own changes at this point. I intend to set cwm up for git-based builds in the future, even if just so I can learn how to do that. > On 20/09/12 15:29, James McDonald wrote: >> >> Recommendation might make sense, but not dependency as it's possible to run >> a window manager on one host for an X server on a remote host. I will look >> at what some other simple window managers do. > > Could be Suggests as well. I've investigated several other window managers and it looks like they don't make any recommendation/suggestion about having X itself installed. They only recommend associated projects, like metacity recommends gnome-session. On that basis, I should probably omit this. > I was really hoping that this would be a drop in replacement for > openbox. I am not clear if this is doable. I am sure that the > README.Debian should document this (and similar) experiments. In theory it should be possible to use it like that. Unfortunately it depends on the restrictions imposed by the environment (LXDE, Gnome etc). I shall set up a machine to experiment with this, but I guess it will be a while before I have any coherent documentation. I agree that it would be nice to be able to provide some tips for this sort of usage. Do you feel this is necessary before the package is uploaded? > Anyway the package seems to do what it says on the tin. So I think there > is a good chance I should be able to upload your next build. I've uploaded the latest version to mentors; here's a log from git of the changes I've made: Fixed double spaces in package description. Changed debhelper dependency from >=9.0.0 to >=9 Removed references to 9wm from the package description. Added Provides: x-window-manager Added scripts to handle x-window-manager alternative Please let me know what you think. Cheers, James -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#505924: cwm
On 16 Sep 2012, at 14:18, Nicholas Bamber wrote: Hi Nicholas, Thanks for your comments! > So here are some stupid questions for starters: > 1,) I'm running LXDE and openbox and I know nothing about X11. How do I > get cwm working? Could I have that in a README.Debian file please? It should simply be a case of selecting 'cwm' from your X login manager or adding it to your .xsession if you use one. The environment with cwm is very simple; it doesn't display anything by default, so you'll just get a blank screen. You can press eg Ctrl-Alt-Enter to spawn a terminal. The keybindings, behaviour and config are thoroughly documented in the man pages. I could put in a README.Debian referring the user to those, but I didn't think that was enough information to merit an extra file. > 2.) Why doesn't the package have a "Provides: x-window-manager" clause > like openbox does? Good point, it should have! I will add this. > 3.) What steps have you taken to check that cwm will fit into the Debian > environment? Have you looked at say > http://wiki.debian.org/WindowManager? Compared with openbox? I did set it up to be selectable as a window manager from KDM/GDM, but it should also be possible to set up as an x-window-manager via alternatives. I'll figure out how to do that and make sure it works. > Then there are issues I picked up on myself but found reiterated in the > existing bug report: > > 4.) "I would remove the last sentence of the first > paragraph though (about the code that used to come from 9wm), as it > doesn't seem very relevant anymore." > More generally I feel your long description should answer the following > questions: What is cwm?; Why might I want to use cwm? Why might I not > want want to use cwm? > > I think you're almost there but as it stands the bits about .cwmrc and > virtual desktops seem out of place. You may want that information in > there but I would suggest thinking about it again. The object was to try to give people an overview of where this window manager comes from and the sort of experience it gives with some of the text taken from the upstream description. It could possibly do with some tidying. > 5.) "And if you don't use a VCS for your packaging, you should remove > those commented-out lines." > Have you considered using collab-maint as a repository? > http://wiki.debian.org/Alioth/PackagingProject?highlight=%28CategoryAlioth%29 I don't think I can use that without being a Debian developer/maintainer. I am considering moving the packaging into a git repository, possibly tracking from upstream, but I haven't had the time to experiment with this. The changes are very small at present, so they are quite easy to maintain without. > 6.) "There is no upstream changelog as there is none > provided." "The README doesn't contain useful information for end-users, > so you shouldn't install it." > Actually the README contains the upstream changelog. So you should > install the README as the upstream changelog. [More strategically you > could ask upstream to generate a report from the Openbsd repository to > get an upstream changelog. Or you could do that yourself perhaps.] Good ideas, thanks. > For completeness I'll also reiterate the comments from Benoit Knecht: > 7.) In debian/control, the debhelper version dependency should simply be >">= 9" instead of ">= 9.0.0". Will fix. > > 8.) And in the same file, the long description contains a few >double-spaces. Text from upstream! I'll fix that too. > 9.) "But prehaps you should consider Depending on xserver-xorg (or at > least Recommend it, if that makes more sense). You could also Suggest > xinit, as it seems like a nice way to start such a minimalistic window > manager." [7 & 8 seem sensible to me. I cannot comment on this one.] Recommendation might make sense, but not dependency as it's possible to run a window manager on one host for an X server on a remote host. I will look at what some other simple window managers do. I will make some changes as soon as I can! It might take a few days though, as I'm rather busy at the moment. Cheers, James -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#677935: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
Hi Benoît, On Mon, Jun 25, 2012 at 05:05:50PM +0200, Benoît Knecht wrote: > I took a look at your package, here are a few comments: Thanks for your detailed review! Your remarks are very helpful. > - lintian reports the following warnings: > > P: cwm source: unversioned-copyright-format-uri > http://dep.debian.net/deps/dep5 > I: cwm source: debian-watch-file-is-missing > P: cwm: no-upstream-changelog > P: cwm: no-homepage-field > I: cwm: hyphen-used-as-minus-sign usr/share/man/man5/cwmrc.5.gz:231 > I: cwm: hyphen-used-as-minus-sign usr/share/man/man5/cwmrc.5.gz:245 I have fixed most of these. There is no upstream changelog as there is none provided. I have set the homepage to the github page of the port which is probably the most useful place for a user to find out about it. There isn't an actual site for cwm itself. > - In debian/copyright, fgetln.c is licensed under the BSD-2-clause > license; and instead of repeating the ISC twice, you could factor it > out in its own standalone paragraph. Thanks, I had missed that. I have updated debian/copyright as you suggest. > Also, the Source header should not point to one particular version. > Use the directory where all the tarballs are stored; but if you got > it from github, use that URL instead. Done. The package is indeed based on the tarball release. > - In debian/control, why do you depend on dpkg-dev? The package seems > to build just fine without it. This was a side-effect of the hardening options in debian/rules. They caused lintian to complain that dpkg-dev was required. It isn't, and this is now fixed. > You should also run wrap-and-sort from devscripts to get the > Build-Depends field wrapped and sorted. Done. > And if you don't use a VCS for your packaging, you should remove > those commented-out lines. Done. > Your long description repeats information provided by the short > description; see [1] for best practices. It could also be expanded a > bit. I had in fact just repeated the summary from the manpage. I have read the reference and a few examples and tried to make it more useful. What do you think? > [1] > http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-desc > > - You could use debhelper compat 9, that should take care of the > hardening flags for you. Done. As above, this fixed the dpkg-dev problem. It also removed the need for one of the patches. > And in debian/rules, you should remove the template comments. Done. > - The README doesn't contain useful information for end-users, so you > shouldn't install it. Removed. Thanks again for taking the time to review this package. It is appreciated! Cheers, -- James McDonald -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#677935: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "cwm" * Package name: cwm Version : 5.1-1 Upstream Author : Christian Neukirchen * URL : https://github.com/chneukirchen/cwm * License : ISC Section : x11 It builds those binary packages: cwm - Lightweight and efficient window manager for X11 To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cwm Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cwm/cwm_5.1-1.dsc More information about cwm can be obtained from https://en.wikipedia.org/wiki/Cwm_(window_manager). It is one of the default window managers available in OpenBSD. Changes since the last upload: Initial release (Closes: #505924) Regards, James McDonald -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#505924: Basic cwm package created
I've created a basic package and uploaded it to http://mentors.debian.net/package/cwm I will work to improve the packaging and try to find a sponsor. -- James McDonald -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
