Bug#544018: Minimal fix (actually implement what the documentation says :) )
The manpage states "Lines starting with ‘#’ and empty lines are interpreted as
comments."
So comments should not start in the middle of a word / line.
attached is a minimal patch.
(the freebsd patch also works and cleans a lot, but IMHO the (char)NULL should
be patched separately and their pointer arithmetic is weird and unneeded)
diff --git a/ssmtp.c b/ssmtp.c
index af4d1e5..3ab3b4d 100644
--- a/ssmtp.c
+++ b/ssmtp.c
@@ -874,14 +874,12 @@ bool_t read_config()
while(fgets(buf, sizeof(buf), fp)) {
char *begin=buf;
char *rightside;
- /* Make comments invisible */
- if((p = strchr(buf, '#'))) {
- *p = (char)NULL;
- }
/* Ignore malformed lines and comments */
+ if(*strip_pre_ws(buf) == '#') continue;
if(strchr(buf, '=') == (char *)NULL) continue;
+
/* Parse out keywords */
p=firsttok(&begin, "= \t\n");
if(p){
OpenPGP_signature
Description: OpenPGP digital signature
Bug#948691: MOZ_APP_LAUNCHER
Thanks for the reply. Could you please explain, why Thunderbird should not set it? And do you know the intended use of the variable? On Fedora, Thunderbird and Firefox each set it.
Bug#898926: I think firefox is to blame
this could be the same issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=948691
Bug#948691: MOZ_APP_LAUNCHER
Also removing the environment variable from thunderbird via gdb before clicking a link in an email will make firefox behave correctly, and starting firefox by env MOZ_APP_LAUNCHER=/usr/bin/pluma firefox will make firefox want to set pluma.desktop as default browser :)
Bug#948691: MOZ_APP_LAUNCHER
I have this behavior on firefox 94 from sid, I suspect the MOZ_APP_LAUNCHER environment variable, which is set by thunderbird and evaluated in browser/components/shell/nsGNOMEShellService.cpp:135 (Filtered) environment of firefox, when started through thunderbird (this wants thunderbird.desktop as default browser): We have thunderbird in $MOZ_APP_LAUNCHER and firefox in $GIO_LAUNCHED_DESKTOP_FILE DESKTOP_SESSION=mate GDM_LANG=de_DE.utf8 GIO_LAUNCHED_DESKTOP_FILE=/usr/share/applications/firefox.desktop GIO_LAUNCHED_DESKTOP_FILE_PID=3669595 HOME=/home/j LANG=C.UTF-8 LC_MEASUREMENT=en_DK.UTF-8 LC_PAPER=en_DK.UTF-8 LC_TIME=en_DK.UTF-8 LD_LIBRARY_PATH=/usr/lib/firefox LD_PRELOAD=libmozsandbox.so LOGNAME=j MATE_DESKTOP_SESSION_ID=this-is-deprecated MOZ_APP_LAUNCHER=/usr/bin/thunderbird MOZ_APP_SILENT_START= MOZ_ASSUME_USER_NS=1 MOZ_CRASHREPORTER_[...] MOZ_LAUNCHED_CHILD= MOZ_PROFILER_STARTUP= MOZ_SANDBOXED=1 MOZ_SANDBOX_USE_CHROOT=1402653184 TB_FAIL=0 TB_HELP=0 TB_VERBOSE=0 XDG_CURRENT_DESKTOP=MATE XDG_[...] XDG_SESSION_TYPE=x11 (Filtered) environment when started through MATE-Panel: (this wants firefox.desktop as default browser) GIO_LAUNCHED_DESKTOP_FILE=/usr/share/applications/firefox.desktop GIO_LAUNCHED_DESKTOP_FILE_PID=3674365 LD_LIBRARY_PATH=/usr/lib/firefox LD_PRELOAD=libmozsandbox.so MOZ_APP_SILENT_START= MOZ_ASSUME_USER_NS=1 MOZ_CRASHREPORTER_[...] MOZ_HEADLESS=1 MOZ_LAUNCHED_CHILD= MOZ_PROFILER_STARTUP= MOZ_SANDBOXED=1 MOZ_SANDBOX_USE_CHROOT=11476395008 PATH=/home/j/.cargo/bin:/home/j/config/bin:/home/j/.local/bin:/home/j/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/snap/bin:/sbin:/usr/sbin PWD=/home/j XDG_SESSION_DESKTOP=mate XDG_SESSION_TYPE=x11
Bug#974133: sipwitch: /etc/cron.hourly calls "sipwitch", this does not exist
Package: sipwitch Version: 1.9.15-3+b1 Severity: important Dear Maintainer, * What led up to the situation? I installed the package sipwitch * What was the outcome of this action? Every hour, I get an email from a failed cron job * What outcome did you expect instead? nothing :) /etc/cron.hourly contains: if test -p /var/run/sipwitch/control ; then sipwitch period 60 ; fi but the "sipwitch" executable does not exist, there is only "sipw", but this does not take the argument "periode". -- System Information: Debian Release: 10.6 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable'), (400, 'oldstable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-10-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages sipwitch depends on: ii adduser 3.118 ii libavahi-client3 0.7-4+b1 ii libavahi-common3 0.7-4+b1 ii libc6 2.28-10 ii libexosip2-11 4.1.0-2.1 ii libgcc1 1:8.3.0-6 ii libgnutls30 3.6.7-4+deb10u5 ii libosip2-11 4.1.0-2.1 ii libsipwitch1 1.9.15-3+b1 ii libstdc++68.3.0-6 ii libucommon8 7.0.0-16 Versions of packages sipwitch recommends: ii cron 3.0pl1-134+deb10u1 ii logrotate 3.14.0-4 Versions of packages sipwitch suggests: pn sipwitch-cgi -- Configuration Files: /etc/default/sipwitch changed [not included] /etc/sipwitch.conf changed [not included] /etc/sipwitch.d/lab.xml-example [Errno 2] No such file or directory: '/etc/sipwitch.d/lab.xml-example' /etc/sipwitch.d/tests.xml [Errno 2] No such file or directory: '/etc/sipwitch.d/tests.xml' -- no debconf information
Bug#959111: libpam-ssh-agent-auth: new ecdsa-sk key type not supported
Package: libpam-ssh-agent-auth Version: 0.10.3-3 Severity: wishlist Dear Maintainer, *** Reporter, please consider answering these questions, where appropriate *** * What led up to the situation? i wanted to use an u2f token for remote sudo authentication * What exactly did you do (or not do) that was effective (or ineffective)? on the client (device with u2f token attached): ssh-keygen -f ~/.ssh/id_sudo ssh-agent -a ~/.ssh/sudo_agent ssh -o ForwardAgent=~/.ssh/sudo_agent jonny@alexandria on the server (where sudo should shoudl use pam_ssh_agent_auth) - in /etc/pam.d/sudo prepend auth sufficient pam_ssh_agent_auth.so file=/etc/security/authorized_keys debug - in /etc/security/authorized_keys i added my ecdsa-sk key sk-ecdsa-sha2-nistp...@openssh.com AAA...oOg== j@io with ssh-agent -L | sudo tee -a /etc/security/authorized_keys - clear sudo cache (sudo -k) or relogin - try sudo -s * What was the outcome of this action? - sudo asked for my password - in /var/log/auth.log: Apr 29 14:56:24 alexandria sudo[624016]: pam_ssh_agent_auth: key_type_from_name: unknown key type 'sk-ecdsa-sha2-nistp...@openssh.com' Apr 29 14:56:24 alexandria sudo[624016]: pam_ssh_agent_auth: error: key_from_blob: remaining bytes in key blob 89 * What outcome did you expect instead? getting asked to touch my u2f token -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 5.5.0-2-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages libpam-ssh-agent-auth depends on: ii libc6 2.30-4 ii libpam0g 1.3.1-5 ii libssl1.1 1.1.1g-1 libpam-ssh-agent-auth recommends no packages. libpam-ssh-agent-auth suggests no packages. -- no debconf information
Bug#931004: mate-menu: duplicate files in package
Package: mate-menu Version: 18.04.3-3 Severity: normal Dear Maintainer, * What led up to the situation? While trying to implement input grabbing, I noticed that the plugin source files are duplicated: - once in /usr/share/mate-menu/plugins - once in /usr/lib/python2.7/dist-packages/mate_menu/plugins. The ones in the python directory are used. * What was the outcome of this action? I was confused :) * What outcome did you expect instead? changing the code of a plugin changes it's behavior -- System Information: Debian Release: 10.0 APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages mate-menu depends on: ii dconf-gsettings-backend [gsettings-backend] 0.30.1-2 ii gir1.2-gtk-3.0 3.24.5-1 ii gir1.2-mate-panel1.20.5-1 ii gir1.2-matedesktop-2.0 1.20.4-2 ii libglib2.0-bin 2.58.3-2 ii mate-menus 1.20.2-1 ii mozo 1.20.2-1 ii python 2.7.16-1 ii python-configobj 5.0.6-3 ii python-mate-menu 1.20.2-1 ii python-pkg-resources 40.8.0-1 ii python-setproctitle 1.1.10-1+b2 ii python-xdg 0.25-5 ii python-xlib 0.23-2 ii xdg-utils1.1.3-1 mate-menu recommends no packages. Versions of packages mate-menu suggests: pn software-center ii synaptic 0.84.6 -- no debconf information
Bug#877039: ":80" is appended to socket file name
Package: lighttpd
Version: 1.4.45-1
If the server is bound to a socket in file system, three characters :80 are
appended to the file path, breaking my reverse proxy setup.
Minimal example:
jonny@heron:/var/tmp/ltest$ lighttpd -D -f config &
[1] 30888
jonny@heron:/var/tmp/ltest$ 2017-09-28 00:26:22: (log.c.217) server started
jonny@heron:/var/tmp/ltest$ ls
config lighty.pid lighty.sock:80
jonny@heron:/var/tmp/ltest$ cat config
server.document-root = "/var/tmp/ltest/"
index-file.names = ( "index.html", "index.lighttpd.html" )
server.bind = "/var/tmp/ltest/lighty.sock"
server.errorlog = "/dev/tty"
server.pid-file = "/var/tmp/ltest/lighty.pid"
dir-listing.activate = "enable"
# -- end of lighttpd config.
expected: a socket "lighty.sock" without :80
jonny@heron:~$ dpkg -s libc6 | grep ^Version
Version: 2.24-17
jonny@heron:~$ uname -a
Linux heron 4.11.0-1-amd64 #1 SMP Debian 4.11.6-1 (2017-06-19) x86_64 GNU/Linux
I think the source lines appending the port are src/network.c,
buffer_copy_buffer(b, srv->srvconf.bindhost);
buffer_append_string_len(b, CONST_STR_LEN(":"));
buffer_append_int(b, srv->srvconf.port);
I remember my setup to work some time ago (jessie or something older)
Bug#615173: closed by Ben Hutchings (Re: Bug#615173: linux-image-2.6.32-5-686: rt73usb wlan doesn't work)
Thanks On Sat, 26 Feb 2011 12:21:08 +0100, Debian Bug Tracking System wrote: This is an automatic notification regarding your Bug report which was filed against the linux-2.6 package: #615173: linux-image-2.6.32-5-686: rt73usb wlan doesn't work It has been closed by Ben Hutchings . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Ben Hutchings by replying to this email. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#615173: linux-image-2.6.32-5-686: rt73usb wlan doesn't work
Package: linux-2.6 Version: 2.6.32-30 Severity: normal Tags: upstream hope it's the right location for the bug report if i plug in my "PLANEX GW-US54Mini2" (lsusb says that) wlan adapter, the rt73usb driver loads, the wlan0 interface appears - but NetworkManager says "device not ready". modprobe doesn't complain (exit status 0 when loading or removing) === root@jtkpc-debian:~# ifconfig wlan0 up SIOCSIFFLAGS: No such file or directory [exit status: 255] root@jtkpc-debian:~# iwconfig wlan0 wlan0 IEEE 802.11bg ESSID:off/any Mode:Managed Access Point: Not-Associated Tx-Power=0 dBm Retry long limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:on root@jtkpc-debian:~# dmesg |tail -20 [ 4964.325878] Registered led device: rt73usb-phy0::quality [ 4964.326600] usbcore: registered new interface driver rt73usb [ 5039.999665] usbcore: deregistering interface driver rt73usb [ 5058.464149] cfg80211: Using static regulatory domain info [ 5058.464166] cfg80211: Regulatory domain: US [ 5058.464181] (start_freq - end_freq @ bandwidth), (max_antenna_gain, max_eirp) [ 5058.464198] (2402000 KHz - 2472000 KHz @ 4 KHz), (600 mBi, 2700 mBm) [ 5058.464214] (517 KHz - 519 KHz @ 4 KHz), (600 mBi, 2300 mBm) [ 5058.464225] (519 KHz - 521 KHz @ 4 KHz), (600 mBi, 2300 mBm) [ 5058.464240] (521 KHz - 523 KHz @ 4 KHz), (600 mBi, 2300 mBm) [ 5058.464256] (523 KHz - 533 KHz @ 4 KHz), (600 mBi, 2300 mBm) [ 5058.464266] (5735000 KHz - 5835000 KHz @ 4 KHz), (600 mBi, 3000 mBm) [ 5058.466040] cfg80211: Calling CRDA for country: US [ 5058.926970] phy0: Selected rate control algorithm 'minstrel' [ 5058.944191] Registered led device: rt73usb-phy0::radio [ 5058.953029] Registered led device: rt73usb-phy0::assoc [ 5058.955721] Registered led device: rt73usb-phy0::quality [ 5058.957327] usbcore: registered new interface driver rt73usb [ 5105.924355] rt73usb 1-7:1.0: firmware: requesting rt73.bin [ 5105.970179] phy0 -> rt2x00lib_request_firmware: Error - Failed to request Firmware. === the device works correctly on fedora with kernel 2.6.35.11-83.fc14.i686 and Ubuntu with 2.6.32-28-generic. -- Package-specific info: ** Version: Linux version 2.6.32-5-686 (Debian 2.6.32-30) (b...@decadent.org.uk) (gcc version 4.3.5 (Debian 4.3.5-4) ) #1 SMP Wed Jan 12 04:01:41 UTC 2011 ** Command line: BOOT_IMAGE=/boot/vmlinuz-2.6.32-5-686 root=UUID=1dfd6396-aa94-498f-8959-e8af6e25cb4a ro quiet ** Tainted: P (1) * Proprietary module has been loaded. ** Kernel log: [ 3229.422046] ata_piix :00:1f.2: PCI INT B disabled [ 3229.422116] ata2: port disabled. ignoring. [ 3229.422164] ata_piix :00:1f.1: PCI INT A disabled [ 3229.524062] HDA Intel :00:1b.0: PCI INT A disabled [ 3229.524106] ACPI handle has no context! [ 3229.540516] ACPI: Preparing to enter system sleep state S4 [ 3229.540890] PM: Saving platform NVS memory [ 3229.543948] Disabling non-boot CPUs ... [ 3229.544002] Extended CMOS year: 2000 [ 3229.544002] PM: Creating hibernation image: [ 3229.544002] PM: Need to copy 100729 pages [ 3229.544002] PM: Normal pages needed: 12349 + 1024, available pages: 213805 [ 3229.544002] PM: Restoring platform NVS memory [ 3229.544002] CPU0: Thermal monitoring enabled (TM2) [ 3229.544002] Extended CMOS year: 2000 [ 3229.544002] Force enabled HPET at resume [ 3229.544157] ACPI: Waking up from system sleep state S4 [ 3229.544956] HDA Intel :00:1b.0: restoring config space at offset 0x1 (was 0x100106, writing 0x100102) [ 3229.545374] ata_piix :00:1f.1: restoring config space at offset 0x1 (was 0x2880001, writing 0x2880005) [ 3229.545403] ata_piix :00:1f.2: restoring config space at offset 0x1 (was 0x2b1, writing 0x2b5) [ 3229.545466] nvidia :01:00.0: restoring config space at offset 0x3 (was 0x8, writing 0x0) [ 3229.545521] tg3 :05:00.0: restoring config space at offset 0xc (was 0x0, writing 0x3f7f) [ 3229.580059] HDA Intel :00:1b.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18 [ 3229.580067] HDA Intel :00:1b.0: setting latency timer to 64 [ 3229.676144] uhci_hcd :00:1d.0: setting latency timer to 64 [ 3229.676180] usb usb2: root hub lost power or was reset [ 3229.676201] uhci_hcd :00:1d.1: setting latency timer to 64 [ 3229.676235] usb usb3: root hub lost power or was reset [ 3229.676258] uhci_hcd :00:1d.2: setting latency timer to 64 [ 3229.676292] usb usb4: root hub lost power or was reset [ 3229.676312] uhci_hcd :00:1d.3: setting latency timer to 64 [ 3229.676345] usb usb5: root hub lost power or was reset [ 3229.676364] ehci_hcd :00:1d.7: setting latency timer to 64 [ 3229.676369] usb usb1: root hub lost power or was reset [ 3229.680241] ehci_hcd :00:1d.7: cache line size of 128 is not supported [ 3229.680262] pci :00:1e.0: setting latency timer to 64 [ 3229.680276] ata_piix
