Bug#1037279: Angelfish built-in ad blocker not built due to missing Rust Build-Depends (Corrosion etc.)

[Kevin Kofler]

Package: angelfish
Version: 22.11-1+b2

Angelfish has a built-in ad blocker based on the Rust adblock crate from 
the Brave developers. This feature is missing from the Debian package 
because Corrosion and other build-time dependencies are not Build-Depended. 
(They may need to be added to Debian first.)


Just check your build logs, e.g.:
https://buildd.debian.org/status/fetch.php?pkg=angelfish&arch=arm64&ver=22.11-1%2Bb2&stamp=1679750090&raw=0

Actual Results:  

-- The following RECOMMENDED packages have not been found:

 * Corrosion, CMake scripts to seamlessly build and link to targets using cargo, 

   Required to build the builtin adblocker


Expected Results:  
The ad blocker is built.


In addition to Corrosion, you will need cargo (though Corrosion should 
already be requiring it), rust-adblock, rust-cxx-build, and rust-cxx. You 
may also need to hack things up so that it can build offline.


See also https://bugzilla.redhat.com/show_bug.cgi?id=2213926 for the exact 
same issue in the Fedora package.

Bug#494090: ksensors: Confuses sensors with same name - re the patch

[Kevin Kofler]

Hi,

I'm the Fedora packager for KSensors. I have been asked to apply the patch 
Michael Schuele posted here, so I've had a look at it. The patch is indeed 
needed to fix coretemp sensors on multi-core or multi-CPU machines getting 
mixed up, I have this problem too on my Core 2 Duo notebook. There are, 
however, 2 issues I found with it, one trivial, one not so much:

* setDescription takes a const QString &, so there's no need to .latin1()
  your QString when passing it there. (I can easily fix this, and yes, I see
  the existing code did that in one place, that's a bug. :-) )

* I think doing things this way will require existing users to reconfigure
  everything, as it'll change all their sensor IDs. :-( I think it'd be nicer
  if we could use the full ID only if the short one is ambiguous, that way
  we'd keep existing configuration working as much as possible.

Kevin Kofler



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org