Bug#1066836: libcamera: ftbfs with 64-bit time_t
Hi Steve, do you also plan to submit this to the libcamera-devel mailing list? -- Kieran Quoting Steve Langasek (2024-03-14 05:35:04) > Package: libcamera > Version: 0.2.0-1 > Severity: serious > Tags: patch > Justification: ftbfs > User: ubuntu-de...@lists.ubuntu.com > Usertags: origin-ubuntu noble ubuntu-patch > > Dear maintainers, > > libcamera fails to build from source on 32-bit architectures under 64-bit > time_t, because it has a module that legitimately un-sets _FILE_OFFSET_BITS > for building but this is not allowed without also unsetting _TIME_BITS: > > [...] > [267/430] c++ -Isrc/v4l2/v4l2-compat.so.p -Isrc/v4l2 -I../src/v4l2 -Iinclude > -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera > -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -Werror -std=c++17 > -Wno-redundant-move -Wno-psabi -Wshadow -include > /<>/obj-arm-linux-gnueabihf/config.h -g -O2 > -ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat > -Werror=format-security -fno-stack-clash-protection > -fdebug-prefix-map=/<>=/usr/src/libcamera-0.2.0-1ubuntu3 > -Wno-error -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 > -Wdate-time -D_FORTIFY_SOURCE=3 -fPIC -DLIBCAMERA_BASE_PRIVATE > -U_FILE_OFFSET_BITS -D_FILE_OFFSET_BITS=32 -D_LARGEFILE64_SOURCE > -fvisibility=hidden -MD -MQ src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -MF > src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o.d -o > src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -c ../src/v4l2/v4l2_camera.cpp > FAILED: src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o > c++ -Isrc/v4l2/v4l2-compat.so.p -Isrc/v4l2 -I../src/v4l2 -Iinclude > -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera > -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -Werror -std=c++17 > -Wno-redundant-move -Wno-psabi -Wshadow -include > /<>/obj-arm-linux-gnueabihf/config.h -g -O2 > -ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat > -Werror=format-security -fno-stack-clash-protection > -fdebug-prefix-map=/<>=/usr/src/libcamera-0.2.0-1ubuntu3 > -Wno-error -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 > -Wdate-time -D_FORTIFY_SOURCE=3 -fPIC -DLIBCAMERA_BASE_PRIVATE > -U_FILE_OFFSET_BITS -D_FILE_OFFSET_BITS=32 -D_LARGEFILE64_SOURCE > -fvisibility=hidden -MD -MQ src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -MF > src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o.d -o > src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -c ../src/v4l2/v4l2_camera.cpp > In file included from /usr/include/features.h:394, > from > /usr/include/arm-linux-gnueabihf/c++/13/bits/os_defines.h:39, > from > /usr/include/arm-linux-gnueabihf/c++/13/bits/c++config.h:679, > from /usr/include/c++/13/bits/requires_hosted.h:31, > from /usr/include/c++/13/deque:60, > from ../src/v4l2/v4l2_camera.h:10, > from ../src/v4l2/v4l2_camera.cpp:8: > /usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed > only with _FILE_OFFSET_BITS=64" >26 | # error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64" > | ^ > [...] > > > (https://launchpad.net/ubuntu/+source/libcamera/0.2.0-1ubuntu3/+build/27902670) > > Since this is a legitimate un-setting of _FILE_OFFSET_BITS in order to get > access to the necessary libc6 prototypes and macros, and since the functions > being intercepted are not sensitive to time_t, the simplest solution is to > also unset _TIME_BITS. > > Please see the attached patch, which has been uploaded to Ubuntu to fix this > build failure. > > Thanks for considering, > -- > Steve Langasek Give me a lever long enough and a Free OS > Debian Developer to set it on, and I can move the world. > Ubuntu Developer https://www.debian.org/ > slanga...@ubuntu.com vor...@debian.org
Bug#1024782: Doesn't run tests as part of of the build
Hi Sebastien, Quoting Sebastien Bacher (2022-11-24 20:41:37) > Package: libcamera > Version: 0.0.1-4 > > I'm working on getting libcamera promoted to main in Ubuntu, one of the > requirements is to have tests (build and autopkgtest). The package > currently override the dh_auto_test target to ignore those, it seems an > old change and isn't really documented and I'm wondering if the rational > still stands? Having tests as part of the build (and as autopkgtests) > would also benefit Debian. > > I'm attaching a trivial patch to enable the tests as part of the build. > Doing that on Ubuntu is leading to 3 failures (seems to be due to the > env, it fails on the builders or in a pbuilder env but not in a lxc > container) so that's an issue to sort out before uploading. I expect it was related to this https://patchwork.libcamera.org/patch/9330/ -- Kieran > I've reported the issue upstream on > https://bugs.libcamera.org/show_bug.cgi?id=173 as a start point. I will > update the report once there is a fix (or maybe skip those 3 tests to > start?) > > Cheers, >
Bug#917629: RFS: xhk/1.0-1
Hi Dmitry, On 21/01/2019 20:23, Dmitry Bogatov wrote: > > [2019-01-20 18:39] Kieran Bingham >> This log shows you have pushed then released the space before pressing >> the next key to mirror. [...] > > Yes. This way it works. Great, glad that solved your issue. > But documentation still have to be improved -- manpage is almost > unreadable and refers to non-existent info manual. I think in current > state this package is not ready for upload. I thought Kentaro had already updated this ? He's handling the packaging so I'll let him continue. -- Regards -- Kieran
Bug#917629: RFS: xhk/1.0-1
Hi Dmitry,
On Sat, 19 Jan 2019, 19:36 Dmitry Bogatov
> [2019-01-04 12:29] Kentaro Hayashi
> > On Fri, 4 Jan 2019 02:17:57 +0100 Adam Borowski
> wrote:
> > > Am I holding it wrong?
> >
> > step 1. launch xhk
> > step 2. press "j" key, then "j" is typed
> > step 3. press space and "j" key, then "f" is typed.
>
To clarify the above, push and *hold* the space bar, while typing the next
key to invert.
>
> > If xhk works as above, it is OK (expected behavior).
>
> It does not work for me like this to me. Here is log (-d):
>
> -- HalfKey Xorg Driver Utility 1.0 --
> SetPriority call failed : -1
> Process Priority set at 0
> XOpenDisplay(":0")
> XI Version 2.0
> Device Virtual core XTEST keyboard (id: 5) is a slave keyboard
> Device is attached to/paired with 3
> Device Power Button (id: 6) is a slave keyboard
> Device is attached to/paired with 3
> Device Video Bus (id: 7) is a slave keyboard
> Device is attached to/paired with 3
> Device Power Button (id: 8) is a slave keyboard
> Device is attached to/paired with 3
> Device Sleep Button (id: 9) is a slave keyboard
> Device is attached to/paired with 3
> Device Apple Inc. Apple Internal Keyboard / Trackpad (id: 10) is a
> slave keyboard
> Device is attached to/paired with 3
> Device FaceTime Camera (Built-in): Fac (id: 12) is a slave keyboard
> Device is attached to/paired with 3
> Floating device ID 10
> Keyrelease 36 (Return), keycode = 36 (Return) time=385249722
>
> Keypress 44 (j), keycode = 44 (j) time=385251136
>
> jKeyrelease 44 (j), keycode = 44 (j) time=385251264
>
> Keypress 65 (space), keycode = -1 ((null)) time=385251704
> Keyrelease 65 (space), keycode = 65 (space) time=385251808
>
This log shows you have pushed then released the space before pressing the
next key to mirror.
Think of the side bar like a shift key which mirrors the keyboard. Except
if you press space and release it, it still presses space.
Regards
Kieran
> Keypress 44 (j), keycode = 44 (j) time=385252784
>
> jKeyrelease 44 (j), keycode = 44 (j) time=385252936
>
> Keypress 65 (space), keycode = -1 ((null)) time=385253024
> Keyrelease 65 (space), keycode = 65 (space) time=385253192
>
> Keypress 66 (Control_L), keycode = 66 (Control_L) time=385253568
>
> Keypress 54 (c), keycode = 54 (c) time=385256208
>
> cKeyrelease 54 (c), keycode = 54 (c) time=385256368
>
> Keyrelease 66 (Control_L), keycode = 66 (Control_L) time=385256376
>
> Keypress 111 (Up), keycode = 111 (Up) time=385256528
>
> ^[[AKeyrelease 111 (Up), keycode = 111 (Up) time=385256704
>
> Keypress 66 (Control_L), keycode = 66 (Control_L) time=385257192
>
> --
> To unsubscribe, send mail to 917629-unsubscr...@bugs.debian.org.
>
