Bug#1039883: [PATCH] ext4: don't track ranges in fast_commit if inode has inlined data

[Luis Henriques]

On Wed 19 Jun 2024 12:30:38 AM +02, Ben Hutchings wrote;

> On Tue, 2024-06-18 at 15:43 +0100, Luis Henriques (SUSE) wrote:
>> When fast-commit needs to track ranges, it has to handle inodes that have
>> inlined data in a different way because ext4_fc_write_inode_data(), in the
>> actual commit path, will attempt to map the required blocks for the range.
>> However, inodes that have inlined data will have it's data stored in
>> inode->i_block and, eventually, in the extended attribute space.
>> 
>> Unfortunately, because fast commit doesn't currently support extended
>> attributes, the solution is to mark this commit as ineligible.
>> 
>> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883
>> Signed-off-by: Luis Henriques (SUSE) 
>
> Reported-by: Hervé Werner 
> Tested-by: Ben Hutchings 
>

Thanks a lot, Ben.

> I think this should also have:
>
> Fixes: 9725958bb75c ("ext4: fast commit may miss tracking unwritten range 
> during ftruncate")
>
> unless you think the problem is even older than that.

If my understanding is correct (hopefully someone will confirm that!), I
think the problem goes further back.  That commit just makes it more
likely to be visible, but handling of inlined data is incorrect since the
fast_commit merge.  So, I guess that's better to simply add:

Cc: sta...@vger.kernel.org

Cheers,
-- 
Luís


>
> Ben.
>
>> ---
>>  fs/ext4/fast_commit.c | 6 ++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
>> index 87c009e0c59a..d3a67bc06d10 100644
>> --- a/fs/ext4/fast_commit.c
>> +++ b/fs/ext4/fast_commit.c
>> @@ -649,6 +649,12 @@ void ext4_fc_track_range(handle_t *handle, struct inode 
>> *inode, ext4_lblk_t star
>>  if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
>>  return;
>>  
>> +if (ext4_has_inline_data(inode)) {
>> +ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_XATTR,
>> +handle);
>> +return;
>> +}
>> +
>>  args.start = start;
>>  args.end = end;
>>  
>
> -- 
> Ben Hutchings
> For every complex problem
> there is a solution that is simple, neat, and wrong.
>

Bug#1039883: [PATCH] ext4: don't track ranges in fast_commit if inode has inlined data

[Luis Henriques (SUSE)]

When fast-commit needs to track ranges, it has to handle inodes that have
inlined data in a different way because ext4_fc_write_inode_data(), in the
actual commit path, will attempt to map the required blocks for the range.
However, inodes that have inlined data will have it's data stored in
inode->i_block and, eventually, in the extended attribute space.

Unfortunately, because fast commit doesn't currently support extended
attributes, the solution is to mark this commit as ineligible.

Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883
Signed-off-by: Luis Henriques (SUSE) 
---
 fs/ext4/fast_commit.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 87c009e0c59a..d3a67bc06d10 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -649,6 +649,12 @@ void ext4_fc_track_range(handle_t *handle, struct inode 
*inode, ext4_lblk_t star
if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
return;
 
+   if (ext4_has_inline_data(inode)) {
+   ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_XATTR,
+   handle);
+   return;
+   }
+
args.start = start;
args.end = end;
 

Bug#1039883: linux: ext4 corruption with symlinks

[Luis Henriques]

On Tue 18 Jun 2024 10:52:55 AM +01, Luis Henriques wrote;

> On Fri 14 Jun 2024 05:18:45 PM +01, Luis Henriques wrote;
> [...}
>>>
>>> I can also reproduce this error message using the above script and:
>>>
>>> - Linux 6.10-rc2
>>> - A 2 GiB loopback devic instead of /dev/sdb
>>>
>>> I bisected this back to:
>>>
>>> commit 9725958bb75cdfa10f2ec11526fdb23e7485e8e4
>>> Author: Xin Yin 
>>> Date:   Thu Dec 23 11:23:37 2021 +0800
>>>  
>>> ext4: fast commit may miss tracking unwritten range during ftruncate
>>>
>>> It is still possible to cleanly revert that commit from 6.10-rc2, and
>>> doing so removes the error message.
>>
>> Because I recently fixed an issue in the fast commit code[1] I was hoping
>> that you were hitting the same bug.  I've executed the reproducer with the
>> fix (which hasn't been merged yet) and realised it's definitely a
>> different problem.
>>
>> Debugged the issue a bit, it seems to be related with the fact that
>> ext4_fc_write_inode_data() isn't able to cope with the fact that
>> 'ei->i_fc_lblk_len' is set to EXT_MAX_BLOCKS.
>
> OK, I've looked into this again.  And something I didn't pay attention
> before was that the filesystem was created with both fast_commit *and*
> inline_data features.  And after some more debugging, I _think_ the patch
> bellow should be the fix for this bug.
>
> If I understand it correctly, when an inode has inlined data it means that
> there's no inode data to be written and this case should be handled as if
> the inode length was zero.
>
> I'll send out a patch later after running a few more tests just to make
> sure it doesn't break something else.  But it would awesome if you could
> test it too.

Hmm... looking closer, this patch seems to work with this specific test
script, but only because file data is probably small enough to fit in
inode->i_block.  However, it may actually truncate files that have inlined
data if the file data is also stored in the extended attribute space
(i.e. > 60 bytes).

So, the correct fix is probably something like the below patch (which I'll
send out soon).

Cheers,
-- 
Luís

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 87c009e0c59a..d3a67bc06d10 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -649,6 +649,12 @@ void ext4_fc_track_range(handle_t *handle, struct inode 
*inode, ext4_lblk_t star
if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
return;
 
+   if (ext4_has_inline_data(inode)) {
+   ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_XATTR,
+   handle);
+   return;
+   }
+
args.start = start;
args.end = end;
 

Bug#1039883: linux: ext4 corruption with symlinks

[Luis Henriques]

On Fri 14 Jun 2024 05:18:45 PM +01, Luis Henriques wrote;
[...}
>>
>> I can also reproduce this error message using the above script and:
>>
>> - Linux 6.10-rc2
>> - A 2 GiB loopback devic instead of /dev/sdb
>>
>> I bisected this back to:
>>
>> commit 9725958bb75cdfa10f2ec11526fdb23e7485e8e4
>> Author: Xin Yin 
>> Date:   Thu Dec 23 11:23:37 2021 +0800
>>  
>> ext4: fast commit may miss tracking unwritten range during ftruncate
>>
>> It is still possible to cleanly revert that commit from 6.10-rc2, and
>> doing so removes the error message.
>
> Because I recently fixed an issue in the fast commit code[1] I was hoping
> that you were hitting the same bug.  I've executed the reproducer with the
> fix (which hasn't been merged yet) and realised it's definitely a
> different problem.
>
> Debugged the issue a bit, it seems to be related with the fact that
> ext4_fc_write_inode_data() isn't able to cope with the fact that
> 'ei->i_fc_lblk_len' is set to EXT_MAX_BLOCKS.

OK, I've looked into this again.  And something I didn't pay attention
before was that the filesystem was created with both fast_commit *and*
inline_data features.  And after some more debugging, I _think_ the patch
bellow should be the fix for this bug.

If I understand it correctly, when an inode has inlined data it means that
there's no inode data to be written and this case should be handled as if
the inode length was zero.

I'll send out a patch later after running a few more tests just to make
sure it doesn't break something else.  But it would awesome if you could
test it too.

Cheers,
-- 
Luís

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 87c009e0c59a..c56b39a51865 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -897,7 +897,7 @@ static int ext4_fc_write_inode_data(struct inode *inode, 
u32 *crc)
int ret;
 
mutex_lock(&ei->i_fc_lock);
-   if (ei->i_fc_lblk_len == 0) {
+   if ((ei->i_fc_lblk_len == 0) || (ext4_has_inline_data(inode))) {
mutex_unlock(&ei->i_fc_lock);
return 0;
}

Bug#1039883: linux: ext4 corruption with symlinks

[Luis Henriques]

On Mon 10 Jun 2024 06:03:58 PM +02, Ben Hutchings wrote;

> On Sun, 5 Nov 2023 16:12:41 + Hervé Werner 
> wrote:
>> Hello
>> 
>> I'm sorry for the delay.
>> 
>> > Are you able to reliably preoeduce the issue and can bisect it to
>> > the introducing commit?
>> I faced this issue on real data but I struggled to find a reliable
>> scenario to reproduce it. Here is what I just came up with:
>>   sudo mkfs -t ext4 -O fast_commit,inline_data /dev/sdb
>>   sudo mount /dev/sdb /mnt/
>>   sudo install -d -o myuser /mnt/annex
>>   cd /mnt/annex
>>   git init && git annex init
>>   for i in {1..2}; do
>> for i in {1..1}; do
>>   dd if=/dev/urandom of=file-${i} bs=1K count=1 2>/dev/null
>> done
>> git annex add -J cpus . >/dev/null && git annex sync -J cpus && git 
>>annex fsck -J cpus >/dev/null
>> git rm * && git annex sync  && git annex dropunused all
>>   done
>> 
>> Then at some point the following error appears:
>>   EXT4-fs error (device sdb): ext4_map_blocks:577: inode #3942343: block 4: 
>>comm git-annex:w: lblock 1 mapped to illegal pblock 4 (length 1)
> [...]
>
> I can also reproduce this error message using the above script and:
>
> - Linux 6.10-rc2
> - A 2 GiB loopback devic instead of /dev/sdb
>
> I bisected this back to:
>
> commit 9725958bb75cdfa10f2ec11526fdb23e7485e8e4
> Author: Xin Yin 
> Date:   Thu Dec 23 11:23:37 2021 +0800
>  
> ext4: fast commit may miss tracking unwritten range during ftruncate
>
> It is still possible to cleanly revert that commit from 6.10-rc2, and
> doing so removes the error message.

Because I recently fixed an issue in the fast commit code[1] I was hoping
that you were hitting the same bug.  I've executed the reproducer with the
fix (which hasn't been merged yet) and realised it's definitely a
different problem.

Debugged the issue a bit, it seems to be related with the fact that
ext4_fc_write_inode_data() isn't able to cope with the fact that
'ei->i_fc_lblk_len' is set to EXT_MAX_BLOCKS.

I'm CC'ing Harshad, maybe he has some idea.

[1] https://lore.kernel.org/all/20240529092030.9557-2-luis.henriq...@linux.dev

Cheers,
-- 
Luís

Bug#866663: python3-cairo: It seems to conflict with debconf

[Luis Henriques]

On Fri, 30 Jun 2017 18:50:34 +0200 =?utf-8?q?Manolo_D=C3=ADaz?=
 wrote:
> Package: python3-cairo
> Version: 1.10.0+dfsg-5+b2
> Severity: serious
> Justification: Policy 7.4
> 
> Dear Maintainer,
> 
> This happens when I try to upgrade python3-cairo:
> 
> (Reading database ... 254270 files and directories currently installed.)
> Preparing to unpack .../python3-cairo_1.10.0+dfsg-5+b2_amd64.deb ...
> Unpacking python3-cairo (1.10.0+dfsg-5+b2) over (1.10.0+dfsg-5+b1) ...
> dpkg: error processing archive
/var/cache/apt/archives/python3-cairo_1.10.0+dfsg-5+b2_amd64.deb (--unpack):
>  trying to overwrite '/usr/lib/python2.7/dist-packages/debconf.py',
which is also in package debconf 1.5.61
> dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
> Errors were encountered while processing:
>  /var/cache/apt/archives/python3-cairo_1.10.0+dfsg-5+b2_amd64.deb
> E: Sub-process /usr/bin/dpkg returned an error code (1)
> 

I can confirm this bug -- I'm seeing exactly the same conflict.

Cheers,
-- 
Luis

> 
> Kind Regards,
> Manolo D
-az
> 
> -- System Information:
> Debian Release: 9.0
>   APT prefers testing
>   APT policy: (500, 'testing')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.11.8 (SMP w/2 CPU cores)
> Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8),
> LANGUAGE=es_ES.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked
> to /usr/bin/dash Init: systemd (via /run/systemd/system)
> 
> Versions of packages python3-cairo depends on:
> ii  libc6  2.24-12
> ii  libcairo2  1.14.8-1
> ii  python33.5.3-1
> 
> python3-cairo recommends no packages.
> 
> python3-cairo suggests no packages.
> 
> -- no debconf information

Bug#802885: [3.16] xfs: allow inode allocations in post-growfs disk space

[Luis Henriques]

On Mon, Dec 14, 2015 at 11:42:26AM +1100, Dave Chinner wrote:
> On Sun, Dec 13, 2015 at 12:27:39AM +, Ben Hutchings wrote:
> > Per the FAQ at
> > ,
> > I think the following commit should be cherry-picked for 3.16-ckt:
> > 
> > commit 9de67c3ba9ea961ba420573d56479d09d33a7587
> > Author: Eric Sandeen 
> > Date:   Thu Jul 24 20:51:54 2014 +1000
> > 
> > xfs: allow inode allocations in post-growfs disk space
> 
> Acked-by: Dave Chinner 
> 

Thanks, I'm queuing this for the next 3.16 release.

Cheers,
--
Luís

Bug#797023: Linux kernel FTBFS error for ARCH=s390, CONFIG_SMP=n, and CONFIG_DYNAMIC_DEBUG=y

[Luis Henriques]

On Mon, Aug 31, 2015 at 06:47:01PM -0400, Stephen Powell wrote:
> 
> On Thu, 27 Aug 2015 18:06:49 -0400 (EDT), Ben Hutchings wrote:
> > 
> > On Wed, 2015-08-26 at 21:33 -0400, Stephen Powell wrote:
> >> 
> >> The Linux kernel in jessie fails to build from source for
> >> the combination ARCH=s390, CONFIG_SMP=n, and CONFIG_DYNAMIC_DEBUG=y.
> >> Compilation of drivers/s390/char/sclp_early.c fails with a number
> >> of undefined symbols.
> >> 
> >> The problem also exists in the stretch and sid kernels at the time
> >> of this writing.  The following patch fixes the problem for all three
> >> kernel versions:
> >> 
> >> https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/patch/?id=a313bdc5310dd807655d3ca3eb2219cd65dfe45a
> > 
> > Please mail sta...@vger.kernel.org to request that this is included in
> > the relevant stable branches.
> 
> Hello, sta...@vger.kernel.org.  Per the above, please include the
> above-referenced git commit in the relevant stable branches.

Thanks Stephen, I believe this is applicable to stable kernels >= 3.13
containing:

commit acf6a004e6a35dad17032e3b7c5a046c29957e65
Author: Michael Holzheu 
Date:   Wed Nov 13 10:38:27 2013 +0100

s390/sclp: Move early code from sclp_cmd.c to sclp_early.c

I'm queuing this for the next 3.16 kernel release.

Cheers,
--
Luís

Bug#782515: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

[Luis Henriques]

On Wed, Apr 15, 2015 at 07:00:32PM +0100, Ben Hutchings wrote:
> Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly")
> changed tcp_send_syn_data() to perform an open-coded copy of the 'syn'
> skb rather than using skb_copy_expand().
> 
> The open-coded copy does not cover the skb_shared_info::gso_segs
> field, so in the new skb it is left set to 0.  When this commit was
> backported into stable branches between 3.10.y and 3.16.7-ckty
> inclusive, it triggered the BUG() in tcp_transmit_skb().
> 
> Since Linux 3.18 the GSO segment count is kept in the
> tcp_skb_cb::tcp_gso_segs field and tcp_send_syn_data() does copy the
> tcp_skb_cb structure to the new skb, so mainline and newer stable
> branches are not affected.
> 
> Set skb_shared_info::gso_segs to the correct value of 1.
> 
> Signed-off-by: Ben Hutchings 

Thanks a lot, Ben.  I'll queue this for the next 3.16 kernel release.

Cheers,
--
Luís

> ---
>  net/ipv4/tcp_output.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index d5457e4..1ea0a07 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -2992,6 +2992,7 @@ static int tcp_send_syn_data(struct sock *sk, struct 
> sk_buff *syn)
>   goto fallback;
>   syn_data->ip_summed = CHECKSUM_PARTIAL;
>   memcpy(syn_data->cb, syn->cb, sizeof(syn->cb));
> + skb_shinfo(syn_data)->gso_segs = 1;
>   if (unlikely(memcpy_fromiovecend(skb_put(syn_data, space),
>fo->data->msg_iov, 0, space))) {
>   kfree_skb(syn_data);
> 
> -- 
> Ben Hutchings
> Editing code like this is akin to sticking plasters on the bleeding stump
> of a severed limb. - me, 29 June 1999


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#769576: linux: Btrfs goes forced readonly when qgroup already exists

[Luis Henriques]

Hi Sebastiann,

On Mon, Jan 05, 2015 at 12:01:06AM +, Andy Whitcroft wrote:
> On Sun, Jan 04, 2015 at 07:05:24PM +0100, Sebastiaan L. Zoutendijk wrote:
> > Control: submitter -1 !
> > 
> > Hello Joe,
> > 
> > On Sat  3 Jan 2015 at 16:02:12 -0500, Joseph Salisbury wrote:
> > > Would it be possible for you to also open a bug in Launchpad for
> > > this?  It can be done by running the following from a terminal:
> > > 
> > > ubuntu-bug linux
> > 
> > Thank you for your directions, but I fear I wasn't clear enough in my
> > previous mail.  This is not a bug specific to Ubuntu (I am not even
> > using Ubuntu), this is a bug in the Extended Stable 3.16 kernel [1], the
> > upstream for both Ubuntu and Debian.  The wiki page [2] told me to send
> > a mail to this address.
> > 
> >   [1] 
> > http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.16.y
> >   [2] https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
> > 
> > If I still should file a Launchpad bug, where should I file it?  Not at
> > the Ubuntu package, I'd think?  But I can't find a Launchpad project for
> > the Extended Stable kernel.
> > 
> > Sorry for the confusion,
> 
> Kamal, Henrix, one to consider.
> 
> -apw
> 
> -- 
> kernel-team mailing list
> kernel-t...@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Thank you for reporting this issue (and sorry for the delay in my
reply!).  I am queuing this commit for the next 3.16 kernel release.

Cheers,
--
Luís


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#757176: RFS: xombrero/2:1.6.3-1 -- Minimalist's web browser

[Luis Henriques]

On Sun, Aug 17, 2014 at 06:58:15PM -0300, Eriberto wrote:
> 2014-08-17 17:27 GMT-03:00 Luis Henriques :
> > Hi Eriberto,
> 
> 
> Hi!!!
> 
> 
> > On Wed, Aug 13, 2014 at 08:32:55PM -0300, Eriberto wrote:
> >> Hi Luis,
> >>
> >> Sorry for my delay and congratulations for your work. I agree with
> >> your considerations.
> >
> > Again, thanks a *lot* for reviewing my xombrero package!
> 
> 
> You are welcome. :-)
> 
> 
> 
> > For example, in your example above, I would interpret it as having file
> > 'xombrero.css' copyrighted by all those authors, even if the real copyright
> > owner is only Josh Rickmar; the same is true for the xombrero.1 file: the
> > only copyright owners are Marco Peereboom, Jason McIntyre and Josh
> > Rickmar.
> >
> > My debian/copyright contains more detailed information, that allows to
> > know exactly who owns the copyright for each file individually.  Of course
> > I do group some of the files, but the copyrights are so different between
> > different files that I decided not to use the 'Files: *' pattern (although
> > I use the 'Files: debian/*' pattern).
> 
> 
> If you and I write a book, our names will be put on the cover without
> a distinction. So, when three people write a program, all are
> upstreams. So, is uncommon separate the upstreams. A split in several
> paragraphs will make the maintaining of this package hard. I can
> upload your package. However, I never saw it and, maybe, the
> FTP-Master can reject. (your package will be NEW because it doesn't
> exist on Debian)
> 
> Please, read these itens:
> 
> 1. Item Copyright in
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#fields
> 
> 2. Example 4 in
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#fields
> 
> A conclusion: I understand your idea but it is no usual.
> 
> 

Ok, got it and I'm convinced :-)  Thanks for your patience.

> > Anyway, I'm OK following the approach you're suggesting -- I just want to
> > confirm that my understanding is correct and this is exactly what you want
> > me to do.
> >
> > 
> >
> >>
> >> I have two doubts:
> >>
> >> Where you saw that the files style.css, *.png, tordisabled.ico and
> >> torenabled.ico are using the CC-BY-SA license?
> >>
> >
> > The license for the style.css is mentioned in the xombrero website
> > (https://opensource.conformal.com/wiki/xombrero).
> 
> Ok. It is a common problem with CC, GPL and others. From CC site[1]:
> 
> "You must include a copy of, or the Uniform Resource Identifier (URI)
> for, this License with every copy of the Work You Distribute or
> Publicly Perform."
> 
> So, the license needs to be put inside the tarball. If not, you can't
> refer to this license and, consequently, the png will use the same
> license of the main source code.
> 

OK, that makes sense perfect.

Unfortunately, I'm afraid I can't afford spending any more time with the
xombrero package at the moment.  And having to deal with upstream to fix
this particular issue isn't something particularly interesting  (it hasn't
been particularly... "pleasant" to deal with the xombrero developers in the
past ;-) ).

Anyway, if someone else volunteers to fix the remaining issues with the
xombrero package, I'm more than happy to share what I've at the moment.

Again, thanks a lot for your reviews Eriberto!

Cheers,
-- 
Luis


> [1] http://creativecommons.org/licenses/by-sa/3.0/legalcode
> 
> >
> > Regarding the tor icons, they are reused from the tor project and the
> > terms and license we're taken from the project website
> > (https://www.torproject.org/).
> 
> 
> The same problem. The upstream failed when reused a code and didn't
> describe the original license and credits (copyright notice).
> Consequently: he can be prosecuted and you can't put a not explicit
> license in d/copyright.
> 
> 
> > Finally, the *png files licenses were confirmed in private emails with the
> > xombrero project developers (iirc, when I first packaged xxxterm there was
> > not public mailing list yet).
> 
> 
> Can you guess what I will say you?
> 
> 
> >> Where you found *.xpm files?
> >>
> >
> > Ah, this one is generated my me in debian/rules from the xpm files.
> 
> 
> 
> Ah, ok. They are derivated from *.png. The same problem with the license.
> 
> Feel free to ask me about my explanation and thaks for your work and interest.
> 
> Cheers,
> 
> Eriberto


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#757176: RFS: xombrero/2:1.6.3-1 -- Minimalist's web browser

[Luis Henriques]

Hi Eriberto,

On Wed, Aug 13, 2014 at 08:32:55PM -0300, Eriberto wrote:
> Hi Luis,
> 
> Sorry for my delay and congratulations for your work. I agree with
> your considerations.

Again, thanks a *lot* for reviewing my xombrero package!

> However, I didn't see the general licensing in
> your d/copyright.

Right, I've actually updated a few things in the copyright file but looks
like I didn't quite understood the approach you were suggesting:

> 
> The common situation is put 'Files: *' and 'Files: debian/*' to refer
> to general licenses and add, if necessary, special cases. You can see
> a simple example at
> http://metadata.ftp-master.debian.org/changelogs/main/h/heartbleeder/unstable_copyright
> 
> You needn't list all files and its licenses. You can quote the main
> authors and the range of years in 'Files: *'; after this you must list
> the exceptions. So, the xombrero.{1,c,conf,css,desktop,h}  (main
> files) have a list of the authors and some years. So, I expected to
> see something as this text in your d/copyright:
> 
> Files: *
> Copyright: 2010-2012  Marco Peereboom 
>  Edd Barrett 
> 2011  Conformal Systems LLC 
>  Jason McIntyre 
>  Michal Mazurek 
>  Raphael Graf 
>  Stevan Andjelkovic 
> 
>  Todd T. Fries 
> 2012-2013  Josh Rickmar 
> 2013  David Hill 
> License: ISC
> 

Ok, so you're suggesting that I should group most of the names/years in
the same copyright '*' pattern.  I tried to follow a completely different
approach (which I used for the xxxterm package), that provides (imho) more
accurate information.

For example, in your example above, I would interpret it as having file
'xombrero.css' copyrighted by all those authors, even if the real copyright
owner is only Josh Rickmar; the same is true for the xombrero.1 file: the
only copyright owners are Marco Peereboom, Jason McIntyre and Josh
Rickmar.

My debian/copyright contains more detailed information, that allows to
know exactly who owns the copyright for each file individually.  Of course
I do group some of the files, but the copyrights are so different between
different files that I decided not to use the 'Files: *' pattern (although
I use the 'Files: debian/*' pattern).

Anyway, I'm OK following the approach you're suggesting -- I just want to
confirm that my understanding is correct and this is exactly what you want
me to do.



> 
> I have two doubts:
> 
> Where you saw that the files style.css, *.png, tordisabled.ico and
> torenabled.ico are using the CC-BY-SA license?
> 

The license for the style.css is mentioned in the xombrero website
(https://opensource.conformal.com/wiki/xombrero).

Regarding the tor icons, they are reused from the tor project and the
terms and license we're taken from the project website
(https://www.torproject.org/).

Finally, the *png files licenses were confirmed in private emails with the
xombrero project developers (iirc, when I first packaged xxxterm there was
not public mailing list yet).

> Where you found *.xpm files?
> 

Ah, this one is generated my me in debian/rules from the xpm files.

Cheers,
-- 
Luis


> Cheers,
> 
> Eriberto
> 
> 
> 2014-08-11 17:54 GMT-03:00 Luis Henriques :
> > Hi Eriberto,
> > On Wed, Aug 06, 2014 at 05:19:31PM -0300, Eriberto Mota wrote:
> >> tags 757176 moreinfo
> >> thanks
> >>
> >> Hi Luis Henriques,
> >>
> >> Please:
> >>
> >
> > First of all, thank you a lot for your review.  I've already gone through
> > all your comments and I've uploaded a new xombrero package into
> > mentors.debian.net that contains most of your comments implemented.
> >
> > Comments inline below:
> >
> >> 1. d/control, in package xxxterm:
> >>
> >> - Change the section from oldlibs to web.
> >> - Change priority extra to optional.
> >
> > According to the Debian Developer's Reference, section 6.7.7. ("Make
> > transition packages deborphan compliant"):
> >
> >   "Also, it is recommended to adjust its section to oldlibs and its
> >priority to extra in order to ease deborphan's job."
> >
> > Also, if I implement these 2 changes, I get additional lintian warnings
> > such as transitional-package-should-be-oldlibs-extra:
> >
> >  The package appears to be a transitional package, but it is not priority
> >  extra and in the oldlibs sect

Bug#757176: RFS: xombrero/2:1.6.3-1 -- Minimalist's web browser

[Luis Henriques]

Hi Eriberto,
On Wed, Aug 06, 2014 at 05:19:31PM -0300, Eriberto Mota wrote:
> tags 757176 moreinfo
> thanks
> 
> Hi Luis Henriques,
> 
> Please:
> 

First of all, thank you a lot for your review.  I've already gone through
all your comments and I've uploaded a new xombrero package into
mentors.debian.net that contains most of your comments implemented.

Comments inline below:

> 1. d/control, in package xxxterm:
> 
> - Change the section from oldlibs to web.
> - Change priority extra to optional.

According to the Debian Developer's Reference, section 6.7.7. ("Make
transition packages deborphan compliant"):

  "Also, it is recommended to adjust its section to oldlibs and its
   priority to extra in order to ease deborphan's job."

Also, if I implement these 2 changes, I get additional lintian warnings
such as transitional-package-should-be-oldlibs-extra:

 The package appears to be a transitional package, but it is not priority
 extra and in the oldlibs section.

 Using oldlibs/extra assists package managers in handling the transition
 package correctly.

 Refer to http://bugs.debian.org/645438 and Debian Developer's Reference
 section 6.7.7 (Make transition packages deborphan compliant) for
 details.

So, I've decided not to include these 2 fields changed in the
debian/control file.  Please let me know if you disagree with my position.

> - In short description, remove the word 'rename'.
>  As long description, use only:
> 
>  This is a transitional dummy package to xombrero. It can safely be removed.
> 
> The last change is to discourage the install of the xxxterm. So, the
> text needs to be short and direct.
> 

Done!

> 2. d/copyright: update all information, even the packaging years. In
> the upstream code, you need to check file by file. Please, fix the
> line that says "Copyright (c) 2013 David Hill ".
> 

Done.

> 3. I think that d/docs can be removed, because all relevant
> information are in manpage.
> 

Done.

> 4. In d/news, please, remove the header.
> 

Actually, I've renamed the NEWS file with a NEWS.Debian file -- which was
what I meant in the first place.  Thus, I've kept the header as per the
example in the Debian Developer's Reference, section 6.3.4.
("Supplementing changelogs with NEWS.Debian files").

> 5. d/rules: remove useless lines '# debian/rules makefile that uses
> debhelper.' and '# Uncomment this to turn on verbose mode.'.
> 

Done.

> 6. d/rules: after the 'export DH_VERBOSE=1' line, put:
> 
> export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
> 
> It will fix this situation:
> 
> dpkg-shlibdeps: warning: package could avoid a useless dependency if
> debian/xombrero/usr/bin/xombrero was not linked against
> libcairo-gobject.so.2 (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency if
> debian/xombrero/usr/bin/xombrero was not linked against libX11.so.6
> (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency if
> debian/xombrero/usr/bin/xombrero was not linked against
> libatk-1.0.so.0 (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency if
> debian/xombrero/usr/bin/xombrero was not linked against
> libpangocairo-1.0.so.0 (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency if
> debian/xombrero/usr/bin/xombrero was not linked against libcairo.so.2
> (it uses none of the library's symbols)
> 

Done.

> 7. You have several bugs not treated[1]. Please, try to solve and
> close some bugs. The bug #695874 is easy and mandatory to be closed by
> your package.
> 

Done, I've include several bugs in the changelog.  I also plan to ping the
reporters of the other open xxxterm bugs to check if they still experience
those issues with newer versions of the package (xombrero).

Now, the problem is that I see the following in mentors.debian.net:

 Package closes bugs in a wrong way

 Errors:
  - Bug #695874 does not belong to this package
  - Bug #752313 does not belong to this package

 xxxterm:
   #695874 (normal): xxxterm renamed to xombrero, new versions available
   #752313 (normal): xxxterm: Please build against libgnutls28-dev


Since lintian didn't actually complained, I'm not sure if this is an issue
or not.

> Thanks for your work. I will wait you.
> 

Again, thanks a *lot* for reviewing my package!

Cheers,
--
Luis

> Cheers,
> 
> Eriberto
> 
> [1] https://bugs.debian.org/cgi-bin/pkgreport.cgi?repeatmerged=no&src=xxxterm
> [2]
> 
> 
> 2014-08-05 20:40 GMT-03:00 Luis Henriques :
> >
&g

Bug#695874: xombrero: status inquery

[Luis Henriques]

Hi Chrysn,

On Thu, Sep 12, 2013 at 02:01:53PM +0200, chrysn wrote:
> hello henrix,
> 
> what is the current status of new versions of xxxterm / xombrero in
> debian?
> 
> your RFS was 693514 closed in what seemed to be a successful upload at
> that time, but there's still no xombrero package in debian. were there
> objections from ftpmasters?
> 
> i've just built and installed your xombrero (2:1.6.1-1) package from
> mentors, and things look good.
> 
> as this also goes to the RFS bug, i'll mention where i think the package
> can be enhanced:
> 
> * the lintian override is not required, just increase the debhelper
>   version in the depends field of debian/control
> * wouldn't the name change be a chance to get rid of the epoch?
> 
> please keep trying to get it uploaded.
> 
> best regards
> chrysn

Just FYI, I've just uploaded another xombrero package into
mentors.debian.net and have bug #757176 open.  Let's see if I'm lucky with
sponsoring :)

Cheers,
-- 
Luis


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#757176: RFS: xombrero/2:1.6.3-1 -- Minimalist's web browser

[Luis Henriques]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "xombrero"

* Package name: xombrero
  Version : 2:1.6.3-1
  Upstream Author : Marco Peereboom  (and several others)
* URL : http://opensource.conformal.com/wiki/xombrero
* License : ISC, MIT, BSD-4-clause, BSD-3-clause, BSD-2-clause, CC-BY-SA
  Section : web

It builds those binary packages:

 xombrero   - Minimalist's web browser
 xxxterm- transitional package for xxxterm rename

To access further information about this package, please visit the
following URL:

 http://mentors.debian.net/package/xombrero


Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/main/x/xombrero/xombrero_1.6.3-1.dsc

More information about hello can be obtained from http://www.example.com.

Changes since the last upload:

   * New upstream release
   * Changed source and binary package name to xombrero in order to be
 consistent with upstream's new naming
 - New package now 'replaces' and 'Breaks' the obsolete xxxterm package
   * Updated debian/control file:
 - Description field to match the new package description
 - libwebkitgtk-3.0-dev dependency
 - Added xxxterm dummy package
   * Updated debian/copyright file to match the file renames
   * Fixed licenses for *.png and *.css files
   * Renamed debian/xxxterm.upstream-changelog to
 debian/xombrero.upstream-changelog
   * Modified all other control files according to the renaming:
 - debian/examples
 - debian/install
 - debian/menu
 - debian/postinst
 - debian/prerm
 - debian/rules
 - debian/watch
   * Added NEWS file
   * Moved to debhelper v9, to handle hardening flags
   * Prevent dh from running dh_auto_test by adding override_dh_auto_test
 to debian/rules
   * Updated Standards-Version to latest version (3.9.5)
   * Updated debian/menu icon path to use full path instead of relative
 path
   * Added debian/docs file to install README.md
   * Dropped 0003-Unnecessary-lib-directory-installation patch as it is not
 required anymore.
   * Added new patch to add "Keywords" to .desktop file
   * Added lintian-overrides file to ignore a typo in a quote


  Regards,
   Luis Henriques


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#751417: linux-image-3.2.0-4-5kc-malta: no SIGKILL after prctl(PR_SET_SECCOMP, 1, ...) on MIPS

[Luis Henriques]

On Thu, Jun 12, 2014 at 09:21:41PM +0100, Ben Hutchings wrote:
> On Thu, 2014-06-12 at 20:36 +0100, Ben Hutchings wrote:
> > Control: tag -1 security upstream patch moreinfo
> > Control: severity -1 grave
> > Control: found -1 3.14.5-1
> 
> Aurelien Jarno pointed out this appears to be fixed upstream in 3.15:
> 
> commit 137f7df8cead00688524c82360930845396b8a21
> Author: Markos Chandras 
> Date:   Wed Jan 22 14:40:00 2014 +
> 
> MIPS: asm: thread_info: Add _TIF_SECCOMP flag
> 
> It looks like this can be cherry-picked cleanly onto stable branches for
> 3.13 and 3.14.  For 3.11 and 3.12, it will need trivial adjustment.
> 
> For branches older than 3.11, this needs to be cherry-picked first:
> 
> commit e7f3b48af7be9f8007a224663a5b91340626fed5
> Author: Ralf Baechle 
> Date:   Wed May 29 01:02:18 2013 +0200
> 
> MIPS: Cleanup flags in syscall flags handlers.
> 
> Ben.
>

Thank you, I'm queuing this for the 3.11 kernel.

Cheers,
--
Luís

> > On Thu, 2014-06-12 at 16:19 +, Plamen Alexandrov wrote:
> > > Package: src:linux
> > > Version: 3.2.51-1
> > > Severity: normal
> > > 
> > > Under MIPS the system call prctl(PR_SET_SECCOMP, 1, ...) does not behave 
> > > as expected.
> > > According to the manual page, after calling it with 1 as a second 
> > > argument, any consecutive system calls other than read(), write(), 
> > > _exit() and sigreturn() should result in the delivery of SIGKILL. 
> > > However, under MIPS any consecutive system call behaves as if 
> > > prctl(PR_SET_SECCOMP, 1, ...) was never called.
> > > 
> > > Here is a simple example that can be used to reproduce the bug:
> > > 
> > > plamen@debian-mips:/tmp$ id
> > > uid=1000(plamen) gid=1000(user) groups=1000(user)
> > > plamen@debian-mips:/tmp$ cat prctl.c 
> > > #include 
> > > #include 
> > > #include 
> > > 
> > > int main(void)
> > > {
> > >   if (prctl(PR_SET_SECCOMP, 1, 0, 0, 0) != 0)
> > >   return 0;
> > >   uid_t uid = getuid();
> > >   printf("%u\n", (unsigned)uid);
> > >   return 0;
> > > }
> > > plamen@debian-mips:/tmp$ gcc prctl.c -o prctl
> > > plamen@debian-mips:/tmp$ ./prctl 
> > > 1000
> > > 
> > > There is no change if I replace
> > >   if (prctl(PR_SET_SECCOMP, 1, 0, 0, 0) != 0)
> > > with
> > >   if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_STRICT, 0, 0, 0) != 0)
> > > and I add #include 
> > 
> > Indeed, I see no check for seccomp on the MIPS syscall 'fast path'.  The
> > seccomp check appears to be done on the 'slow path' which is used only
> > if tracing or audit is also enabled for the task.  If I run the above
> > program under strace, it is killed as expected.
> > 
> > Could you test whether the attached patches fix this?  (Instructions for
> > rebuilding the Debian kernel package with patches can be found at
> > .
> >   These patches apply to 'wheezy'.)
> > 
> > Ben.
> > 
> 
> -- 
> Ben Hutchings
> The program is absolutely right; therefore, the computer must be wrong.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#648155: [stable] SUNRPC handle EKEYEXPIRED in call_refreshresult

[Luis Henriques]

On Thu, Nov 21, 2013 at 04:16:48AM +, Ben Hutchings wrote:
> On Tue, 2013-11-05 at 21:20 +0100, Bastian Blank wrote:
> > On Tue, Nov 05, 2013 at 05:36:12PM +0100, Per Olofsson wrote:
> > > Seems that maybe they reverted to the old behavior after all:
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=eb96d5c97b0825d542e9c4ba5e0a22b519355166
> 
> This is 'SUNRPC handle EKEYEXPIRED in call_refreshresult'.
> 
> > Okay.
> > 
> > Ben: can we fix that via longterm? The patch is a bit long.
> 
> Looks OK to me, though it needed some massaging (attaching my version).
> Maybe I should also apply commit f1ff0c27fd99 ('SUNRPC: don't map
> EKEYEXPIRED to EACCES in call_refreshresult')?
> 
> And if so, these should also go to the other relevant stable branches (<
> 3.8 for the first, < 3.12 for the second).
> 

Thanks Ben, I'm queuing eb96d5c ("SUNRPC handle EKEYEXPIRED in
call_refreshresult") to the 3.5 kernel for now, although f1ff0c27fd99
seems to also be applicable.

Cheers,
--
Luis


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#695874: xombrero: status inquery

[Luis Henriques]

Hi Chrysn,

chrysn  writes:

> hello henrix,
>
> what is the current status of new versions of xxxterm / xombrero in
> debian?
>
> your RFS was 693514 closed in what seemed to be a successful upload at
> that time, but there's still no xombrero package in debian. were there
> objections from ftpmasters?

Yep, there were some issues with the licensing of some of the files.
I've solve those issues but haven't yet managed to re-work on the
package.

>
> i've just built and installed your xombrero (2:1.6.1-1) package from
> mentors, and things look good.

Great!  Thanks for testing.

>
> as this also goes to the RFS bug, i'll mention where i think the
>package
> can be enhanced:
>
> * the lintian override is not required, just increase the debhelper
>   version in the depends field of debian/control
> * wouldn't the name change be a chance to get rid of the epoch?

Thanks for the suggestions, I'll try to incorporate them in my next
attempt to have xombrero uploaded into debian.

>
> please keep trying to get it uploaded.

I will! :-)

I'll see if I can get some time this week to have another package
ready in mentors.

Cheers,
--
Luis


signature.asc
Description: PGP signature

Bug#714295: [PATCH libata/for-3.11-fixes] libata: make it clear that sata_inic162x is experimental

[Luis Henriques]

Tejun Heo  writes:

> Hello, Greg.
>
> I think the following commit should go into -stable but forgot to cc
> stable.  It's now in Linus' tree.  Can you please include it in
> -stable?
>
> Thanks!
>
> On Mon, Jul 22, 2013 at 05:13:07PM -0400, Tejun Heo wrote:
>> From bb9696192826a7d9279caf872e95b41bc26c7eff Mon Sep 17 00:00:00 2001
>> From: Tejun Heo 
>> Date: Mon, 22 Jul 2013 16:53:36 -0400
>> 
>> sata_inic162x never reached a state where it's reliable enough for
>> production use and data corruption is a relatively common occurrence.
>> Make the driver generate warning about the issues and mark the Kconfig
>> option as experimental.
>> 
>> If the situation doesn't improve, we'd be better off making it depend
>> on CONFIG_BROKEN.  Let's wait for several cycles and see if the kernel
>> message draws any attention.
>> 
>> Signed-off-by: Tejun Heo 
>> Reported-by: Martin Braure de Calignon 
>> Reported-by: Ben Hutchings 
>> Reported-by: risc4...@yahoo.com
>> ---
>>  drivers/ata/Kconfig |  2 +-
>>  drivers/ata/sata_inic162x.c | 14 ++
>>  2 files changed, 15 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 80dc988..5cddaf8 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -107,7 +107,7 @@ config SATA_FSL
>>If unsure, say N.
>>  
>>  config SATA_INIC162X
>> -tristate "Initio 162x SATA support"
>> +tristate "Initio 162x SATA support (Very Experimental)"
>>  depends on PCI
>>  help
>>This option enables support for Initio 162x Serial ATA.
>> diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
>> index e451317..5c54d95 100644
>> --- a/drivers/ata/sata_inic162x.c
>> +++ b/drivers/ata/sata_inic162x.c
>> @@ -6,6 +6,18 @@
>>   *
>>   * This file is released under GPL v2.
>>   *
>> + *  WARNING 
>> + *
>> + * This driver never worked properly and unfortunately data corruption is
>> + * relatively common.  There isn't anyone working on the driver and there's
>> + * no support from the vendor.  Do not use this driver in any production
>> + * environment.
>> + *
>> + * 
>> http://thread.gmane.org/gmane.linux.debian.devel.bugs.rc/378525/focus=54491
>> + * https://bugzilla.kernel.org/show_bug.cgi?id=60565
>> + *
>> + * *
>> + *
>>   * This controller is eccentric and easily locks up if something isn't
>>   * right.  Documentation is available at initio's website but it only
>>   * documents registers (not programming model).
>> @@ -807,6 +819,8 @@ static int inic_init_one(struct pci_dev *pdev, const 
>> struct pci_device_id *ent)
>>  
>>  ata_print_version_once(&pdev->dev, DRV_VERSION);
>>  
>> +dev_alert(&pdev->dev, "inic162x support is broken with common data 
>> corruption issues and will be disabled by default, contact 
>> linux-...@vger.kernel.org if in production use\n");
>> +
>>  /* alloc host */
>>  host = ata_host_alloc_pinfo(&pdev->dev, ppi, NR_PORTS);
>>  hpriv = devm_kzalloc(&pdev->dev, sizeof(*hpriv), GFP_KERNEL);
>> -- 
>> 1.8.3.1
>> 

I'm queuing this for the 3.5 kernel as well.

Cheers,
-- 
Luis


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#709647: [PATCH 14/98] genirq: Fix can_request_irq() for IRQs without an action

[Luis Henriques]

3.5.7.17 -stable review patch.  If anyone has any objections, please let me 
know.

--

From: Ben Hutchings 

commit 2779db8d37d4b542d9ca2575f5f178dbeaca6c86 upstream.

Commit 02725e7471b8 ('genirq: Use irq_get/put functions'),
inadvertently changed can_request_irq() to return 0 for IRQs that have
no action.  This causes pcibios_lookup_irq() to select only IRQs that
already have an action with IRQF_SHARED set, or to fail if there are
none.  Change can_request_irq() to return 1 for IRQs that have no
action (if the first two conditions are met).

Reported-by: Bjarni Ingi Gislason 
Tested-by: Bjarni Ingi Gislason  (against 3.2)
Signed-off-by: Ben Hutchings 
Cc: 709...@bugs.debian.org
Link: http://bugs.debian.org/709647
Link: 
http://lkml.kernel.org/r/1372383630.23847.40.ca...@deadeye.wl.decadent.org.uk
Signed-off-by: Thomas Gleixner 
Signed-off-by: Luis Henriques 
---
 kernel/irq/manage.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index b4c6385..a561ed3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -554,9 +554,9 @@ int can_request_irq(unsigned int irq, unsigned long 
irqflags)
return 0;
 
if (irq_settings_can_request(desc)) {
-   if (desc->action)
-   if (irqflags & desc->action->flags & IRQF_SHARED)
-   canrequest =1;
+   if (!desc->action ||
+   irqflags & desc->action->flags & IRQF_SHARED)
+   canrequest = 1;
}
irq_put_desc_unlock(desc, flags);
return canrequest;
-- 
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#709647: [ 3.8.y.z extended stable ] Patch "genirq: Fix can_request_irq() for IRQs without an action" has been added to staging queue

[Luis Henriques]

This is a note to let you know that I have just added a patch titled

genirq: Fix can_request_irq() for IRQs without an action

to the linux-3.8.y-queue branch of the 3.8.y.z extended stable tree 
which can be found at:

 
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.8.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.8.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

--

>From 30ce4c8b736af2edc52017fe0f70e11748b19442 Mon Sep 17 00:00:00 2001
From: Ben Hutchings 
Date: Fri, 28 Jun 2013 02:40:30 +0100
Subject: [PATCH] genirq: Fix can_request_irq() for IRQs without an action

commit 2779db8d37d4b542d9ca2575f5f178dbeaca6c86 upstream.

Commit 02725e7471b8 ('genirq: Use irq_get/put functions'),
inadvertently changed can_request_irq() to return 0 for IRQs that have
no action.  This causes pcibios_lookup_irq() to select only IRQs that
already have an action with IRQF_SHARED set, or to fail if there are
none.  Change can_request_irq() to return 1 for IRQs that have no
action (if the first two conditions are met).

Reported-by: Bjarni Ingi Gislason 
Tested-by: Bjarni Ingi Gislason  (against 3.2)
Signed-off-by: Ben Hutchings 
Cc: 709...@bugs.debian.org
Link: http://bugs.debian.org/709647
Link: 
http://lkml.kernel.org/r/1372383630.23847.40.ca...@deadeye.wl.decadent.org.uk
Signed-off-by: Thomas Gleixner 
Signed-off-by: Luis Henriques 
---
 kernel/irq/manage.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index e49a288..a9302d0 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -554,9 +554,9 @@ int can_request_irq(unsigned int irq, unsigned long 
irqflags)
return 0;

if (irq_settings_can_request(desc)) {
-   if (desc->action)
-   if (irqflags & desc->action->flags & IRQF_SHARED)
-   canrequest =1;
+   if (!desc->action ||
+   irqflags & desc->action->flags & IRQF_SHARED)
+   canrequest = 1;
}
irq_put_desc_unlock(desc, flags);
return canrequest;
--
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#709647: [ 3.5.y.z extended stable ] Patch "genirq: Fix can_request_irq() for IRQs without an action" has been added to staging queue

[Luis Henriques]

This is a note to let you know that I have just added a patch titled

genirq: Fix can_request_irq() for IRQs without an action

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

--

>From 7ab45bf3f906dafa5e94937435433dda7f1c49a6 Mon Sep 17 00:00:00 2001
From: Ben Hutchings 
Date: Fri, 28 Jun 2013 02:40:30 +0100
Subject: [PATCH] genirq: Fix can_request_irq() for IRQs without an action

commit 2779db8d37d4b542d9ca2575f5f178dbeaca6c86 upstream.

Commit 02725e7471b8 ('genirq: Use irq_get/put functions'),
inadvertently changed can_request_irq() to return 0 for IRQs that have
no action.  This causes pcibios_lookup_irq() to select only IRQs that
already have an action with IRQF_SHARED set, or to fail if there are
none.  Change can_request_irq() to return 1 for IRQs that have no
action (if the first two conditions are met).

Reported-by: Bjarni Ingi Gislason 
Tested-by: Bjarni Ingi Gislason  (against 3.2)
Signed-off-by: Ben Hutchings 
Cc: 709...@bugs.debian.org
Link: http://bugs.debian.org/709647
Link: 
http://lkml.kernel.org/r/1372383630.23847.40.ca...@deadeye.wl.decadent.org.uk
Signed-off-by: Thomas Gleixner 
Signed-off-by: Luis Henriques 
---
 kernel/irq/manage.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index b4c6385..a561ed3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -554,9 +554,9 @@ int can_request_irq(unsigned int irq, unsigned long 
irqflags)
return 0;

if (irq_settings_can_request(desc)) {
-   if (desc->action)
-   if (irqflags & desc->action->flags & IRQF_SHARED)
-   canrequest =1;
+   if (!desc->action ||
+   irqflags & desc->action->flags & IRQF_SHARED)
+   canrequest = 1;
}
irq_put_desc_unlock(desc, flags);
return canrequest;
--
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#700333: [PATCH 102/118] clockevents: Set dummy handler on CPU_DEAD shutdown

[Luis Henriques]

3.5.7.12 -stable review patch.  If anyone has any objections, please let me 
know.

--

From: Thomas Gleixner 

commit 6f7a05d7018de222e40ca003721037a530979974 upstream.

Vitaliy reported that a per cpu HPET timer interrupt crashes the
system during hibernation. What happens is that the per cpu HPET timer
gets shut down when the nonboot cpus are stopped. When the nonboot
cpus are onlined again the HPET code sets up the MSI interrupt which
fires before the clock event device is registered. The event handler
is still set to hrtimer_interrupt, which then crashes the machine due
to highres mode not being active.

See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700333

There is no real good way to avoid that in the HPET code. The HPET
code alrady has a mechanism to detect spurious interrupts when event
handler == NULL for a similar reason.

We can handle that in the clockevent/tick layer and replace the
previous functional handler with a dummy handler like we do in
tick_setup_new_device().

The original clockevents code did this in clockevents_exchange_device(),
but that got removed by commit 7c1e76897 (clockevents: prevent
clockevent event_handler ending up handler_noop) which forgot to fix
it up in tick_shutdown(). Same issue with the broadcast device.

Reported-by: Vitaliy Fillipov 
Cc: Ben Hutchings 
Cc: 700...@bugs.debian.org
Signed-off-by: Thomas Gleixner 
[ luis: adjust context ]
Signed-off-by: Luis Henriques 
---
 kernel/time/tick-broadcast.c | 4 
 kernel/time/tick-common.c| 1 +
 2 files changed, 5 insertions(+)

diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index a13987a..239a323 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -66,6 +66,8 @@ static void tick_broadcast_start_periodic(struct 
clock_event_device *bc)
  */
 int tick_check_broadcast_device(struct clock_event_device *dev)
 {
+   struct clock_event_device *cur = tick_broadcast_device.evtdev;
+
if ((dev->features & CLOCK_EVT_FEAT_DUMMY) ||
(tick_broadcast_device.evtdev &&
 tick_broadcast_device.evtdev->rating >= dev->rating) ||
@@ -73,6 +75,8 @@ int tick_check_broadcast_device(struct clock_event_device 
*dev)
return 0;
 
clockevents_exchange_device(tick_broadcast_device.evtdev, dev);
+   if (cur)
+   cur->event_handler = clockevents_handle_noop;
tick_broadcast_device.evtdev = dev;
if (!cpumask_empty(tick_get_broadcast_mask()))
tick_broadcast_start_periodic(dev);
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index da6c9ec..ead79bc 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -323,6 +323,7 @@ static void tick_shutdown(unsigned int *cpup)
 */
dev->mode = CLOCK_EVT_MODE_UNUSED;
clockevents_exchange_device(dev, NULL);
+   dev->event_handler = clockevents_handle_noop;
td->evtdev = NULL;
}
raw_spin_unlock_irqrestore(&tick_device_lock, flags);
-- 
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#700333: [ 3.5.y.z extended stable ] Patch "clockevents: Set dummy handler on CPU_DEAD shutdown" has been added to staging queue

[Luis Henriques]

This is a note to let you know that I have just added a patch titled

clockevents: Set dummy handler on CPU_DEAD shutdown

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

--

>From 286b8c6a68ace04e9cc8748e8f4681da9f4a42ff Mon Sep 17 00:00:00 2001
From: Thomas Gleixner 
Date: Thu, 25 Apr 2013 11:45:53 +0200
Subject: [PATCH] clockevents: Set dummy handler on CPU_DEAD shutdown

commit 6f7a05d7018de222e40ca003721037a530979974 upstream.

Vitaliy reported that a per cpu HPET timer interrupt crashes the
system during hibernation. What happens is that the per cpu HPET timer
gets shut down when the nonboot cpus are stopped. When the nonboot
cpus are onlined again the HPET code sets up the MSI interrupt which
fires before the clock event device is registered. The event handler
is still set to hrtimer_interrupt, which then crashes the machine due
to highres mode not being active.

See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700333

There is no real good way to avoid that in the HPET code. The HPET
code alrady has a mechanism to detect spurious interrupts when event
handler == NULL for a similar reason.

We can handle that in the clockevent/tick layer and replace the
previous functional handler with a dummy handler like we do in
tick_setup_new_device().

The original clockevents code did this in clockevents_exchange_device(),
but that got removed by commit 7c1e76897 (clockevents: prevent
clockevent event_handler ending up handler_noop) which forgot to fix
it up in tick_shutdown(). Same issue with the broadcast device.

Reported-by: Vitaliy Fillipov 
Cc: Ben Hutchings 
Cc: 700...@bugs.debian.org
Signed-off-by: Thomas Gleixner 
[ luis: adjust context ]
Signed-off-by: Luis Henriques 
---
 kernel/time/tick-broadcast.c | 4 
 kernel/time/tick-common.c| 1 +
 2 files changed, 5 insertions(+)

diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index a13987a..239a323 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -66,6 +66,8 @@ static void tick_broadcast_start_periodic(struct 
clock_event_device *bc)
  */
 int tick_check_broadcast_device(struct clock_event_device *dev)
 {
+   struct clock_event_device *cur = tick_broadcast_device.evtdev;
+
if ((dev->features & CLOCK_EVT_FEAT_DUMMY) ||
(tick_broadcast_device.evtdev &&
 tick_broadcast_device.evtdev->rating >= dev->rating) ||
@@ -73,6 +75,8 @@ int tick_check_broadcast_device(struct clock_event_device 
*dev)
return 0;

clockevents_exchange_device(tick_broadcast_device.evtdev, dev);
+   if (cur)
+   cur->event_handler = clockevents_handle_noop;
tick_broadcast_device.evtdev = dev;
if (!cpumask_empty(tick_get_broadcast_mask()))
tick_broadcast_start_periodic(dev);
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index da6c9ec..ead79bc 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -323,6 +323,7 @@ static void tick_shutdown(unsigned int *cpup)
 */
dev->mode = CLOCK_EVT_MODE_UNUSED;
clockevents_exchange_device(dev, NULL);
+   dev->event_handler = clockevents_handle_noop;
td->evtdev = NULL;
}
raw_spin_unlock_irqrestore(&tick_device_lock, flags);
--
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#704933: [stable] fbcon: fix locking harder

[Luis Henriques]

On Mon, Apr 22, 2013 at 02:26:07AM +0100, Ben Hutchings wrote:
> On Mon, 2013-04-15 at 02:24 +0100, Ben Hutchings wrote:
> > On Sat, 2013-04-13 at 03:28 +0400, Stepan Golosunov wrote:
> > [...]
> > > The relevant changes in 3.2.40 (
> > > fb: rework locking to fix lock ordering on takeover,
> > > fb: Yet another band-aid for fixing lockdep mess;
> > > described in
> > > http://lists.freedesktop.org/archives/dri-devel/2013-January/033976.html)
> > > appear to be missing from debian/changelog.
> > 
> > Yes, maybe I should make it more clear that not all commits are listed
> > in the Debian changelog (there are just too many).  I try to list
> > everything that looks like it could be release-critical - data loss,
> > security vulnerabilities, and major regressions.
> > 
> > > And the missing fix (fbcon: fix locking harder) was discussed in
> > > http://lists.freedesktop.org/archives/dri-devel/2013-January/033980.html.
> > > 
> > > Any of the two attached patches makes 3.2.41-2 bootable here.
> > 
> > I think we should move forward rather than back.  So that's:
> > 
> > commit 054430e773c9a1e26f38e30156eff02dedfffc17
> > Author: Dave Airlie 
> > Date:   Fri Jan 25 11:38:56 2013 +1000
> > 
> > fbcon: fix locking harder
> [...]
> 
> So I've queued this up for 3.2, but I think it belongs in 3.0 and 3.4 as
> well.

Yep, makes sense to me.  Its on 3.5 already.  Thanks Ben.

Cheers,
--
Luis


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#693514: RFS: xombrero/2:1.3.1-1 [TIP]

[Luis Henriques]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "xombrero"

 * Package name: xombrero
   Version : 2:1.3.1-1
   Upstream Author : Several (Marco Peereboom )
 * URL : http://opensource.conformal.com/wiki/xombrero
 * License : ISC, MIT, BSD-4-clause, BSD-3-clause, BSD-2-clause, 
CC-BY-SA
   Section : web

It builds those binary packages:

  xombrero   - Minimalist's web browser

To access further information about this package, please visit the following 
URL:

 http://mentors.debian.net/package/xombrero


Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/main/x/xombrero/xombrero_1.3.1-1.dsc

More information about hello can be obtained from http://www.example.com.

Changes since the last upload:

  * New upstream release
  * Changed source and binary package name to xombrero in order to be
consistent with upstream's new naming
- New package now replace, provide and conflict with the obsolete
  xxxterm package
  * Updated debian/control file:
- Description field to match the new package description
- libwebkitgtk-3.0-dev dependency
  * Updated debian/copyright file
  * Renamed debian/xxxterm.upstream-changelog to
debian/xombrero.upstream-changelog
  * Modified all other control files according to the renaming:
- debian/examples
- debian/install
- debian/menu
- debian/postinst
- debian/prerm
- debian/rules
- debian/watch
  * Added NEWS file
  * Moved to debhelper v9, to handle hardening flags
- Had to add a lintian overridden as this is experimental.

Regards,
 Luis Henriques


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#684441: [PATCH v2] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

[Luis Henriques]

On Tue, Aug 28, 2012 at 10:09:55AM -0700, Ben Hutchings wrote:
> On Tue, 2012-08-28 at 12:44 +0100, Luis Henriques wrote:
> > On Mon, Aug 20, 2012 at 12:32:27AM +0100, Ben Hutchings wrote:
> > > ite_dev::rdev is currently initialised in ite_probe() after
> > > rc_register_device() returns.  If a newly registered device is opened
> > > quickly enough, we may enable interrupts and try to use ite_dev::rdev
> > > before it has been initialised.  Move it up to the earliest point we
> > > can, right after calling rc_allocate_device().
> > 
> > I believe this is the same bug:
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=46391
> > 
> > And the bug is present in other IR devices as well.
> > 
> > I've sent a proposed fix:
> > 
> > http://marc.info/?l=linux-kernel&m=134590803109050&w=2
> 
> It might be a worthwhile fix.  But it doesn't fix this bug - after that
> patch, the driver will still enable its IRQ before initialising
> ite_dev::rdev.

You're absolutely right, sorry for the noise.  I should have taken a
closer look at your patch.

Cheers,
--
Luis

> 
> Ben.
> 
> > Cheers,
> > --
> > Luis
> > 
> > > 
> > > References: http://bugs.debian.org/684441 Reported-and-tested-by:
> > > YunQiang Su  Signed-off-by: Ben Hutchings
> > >  Cc: sta...@vger.kernel.org --- Unlike the
> > > previous version, this will apply cleanly to the media
> > > staging/for_v3.6 branch.
> > > 
> > > Ben.
> > > 
> > >  drivers/media/rc/ite-cir.c |2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
> > > index 36fe5a3..24c77a4 100644
> > > --- a/drivers/media/rc/ite-cir.c
> > > +++ b/drivers/media/rc/ite-cir.c
> > > @@ -1473,6 +1473,7 @@ static int ite_probe(struct pnp_dev *pdev, const 
> > > struct pnp_device_id
> > >   rdev = rc_allocate_device();
> > >   if (!rdev)
> > >   goto failure;
> > > + itdev->rdev = rdev;
> > >  
> > >   ret = -ENODEV;
> > >  
> > > @@ -1604,7 +1605,6 @@ static int ite_probe(struct pnp_dev *pdev, const 
> > > struct pnp_device_id
> > >   if (ret)
> > >   goto failure3;
> > >  
> > > - itdev->rdev = rdev;
> > >   ite_pr(KERN_NOTICE, "driver has been successfully loaded\n");
> > >  
> > >   return 0;
> > > 
> > 
> 
> -- 
> Ben Hutchings
> It is a miracle that curiosity survives formal education. - Albert Einstein


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#684441: [PATCH v2] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

[Luis Henriques]

On Mon, Aug 20, 2012 at 12:32:27AM +0100, Ben Hutchings wrote:
> ite_dev::rdev is currently initialised in ite_probe() after
> rc_register_device() returns.  If a newly registered device is opened
> quickly enough, we may enable interrupts and try to use ite_dev::rdev
> before it has been initialised.  Move it up to the earliest point we
> can, right after calling rc_allocate_device().

I believe this is the same bug:

https://bugzilla.kernel.org/show_bug.cgi?id=46391

And the bug is present in other IR devices as well.

I've sent a proposed fix:

http://marc.info/?l=linux-kernel&m=134590803109050&w=2

Cheers,
--
Luis

> 
> References: http://bugs.debian.org/684441 Reported-and-tested-by:
> YunQiang Su  Signed-off-by: Ben Hutchings
>  Cc: sta...@vger.kernel.org --- Unlike the
> previous version, this will apply cleanly to the media
> staging/for_v3.6 branch.
> 
> Ben.
> 
>  drivers/media/rc/ite-cir.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
> index 36fe5a3..24c77a4 100644
> --- a/drivers/media/rc/ite-cir.c
> +++ b/drivers/media/rc/ite-cir.c
> @@ -1473,6 +1473,7 @@ static int ite_probe(struct pnp_dev *pdev, const struct 
> pnp_device_id
>   rdev = rc_allocate_device();
>   if (!rdev)
>   goto failure;
> + itdev->rdev = rdev;
>  
>   ret = -ENODEV;
>  
> @@ -1604,7 +1605,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct 
> pnp_device_id
>   if (ret)
>   goto failure3;
>  
> - itdev->rdev = rdev;
>   ite_pr(KERN_NOTICE, "driver has been successfully loaded\n");
>  
>   return 0;
> 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#662188: RFS: xxxterm/1:1.11.3-1

[Luis Henriques]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "xxxterm"

 * Package name: xxxterm
   Version : 1:1.11.3-1
   Upstream Author : Several (Marco Peereboom )
 * URL : http://opensource.conformal.com/wiki/XXXTerm
 * License : ISC, MIT, BSD-4-clause, BSD-3-clause, BSD-2-clause, CC-BY, 
MPL-1.1
   Section : web

It builds those binary packages:

  xxxterm- Minimalist's web browser

To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/xxxterm


Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/x/xxxterm/xxxterm_1.11.3-1.dsc

More information about hello can be obtained from http://www.example.com.

Changes since the last upload:
  * New upstream release
  * Updated copyright file with new files in package
  * Added postinst and prerm to add/remove x-www-browser alternative
(Closes: #660331)
  * Updated Standards-Version to latest version (3.9.3)

Regards,
--
Luis Henriques


signature.asc
Description: Digital signature

Bug#655217: pino fails to start

[Luis Henriques]

On Mon, Jan 09, 2012 at 08:22:19PM +0100, Julien Valroff wrote:
> Le lundi 09 janv. 2012 à 12:27:58 (+0100 CET), Luis Henriques a écrit :
> > Package: pino
> > Version: 0.2.11+dfsg-1
> > Severity: important
> > 
> > Hi,
> > 
> > I just installed pino on sid, and I am not able to start it.  When I run 
> > pino I
> > get the following errors on console:
> > 
> > ** (pino:11756): CRITICAL **: file
> > /tmp/buildd/pino-0.2.11+dfsg/obj-x86_64-linux-gnu/src/main_window.c: line
> > 1310: uncaught error: Couldn't recognise the image file format for file
> > '/usr/share/icons/hicolor/scalable/apps/pino.svg' (gdk-pixbuf-error-quark,
> > 3)
> > 
> > (pino:11756): GLib-GObject-CRITICAL **: g_object_ref_sink: assertion
> > `G_IS_OBJECT (object)' failed
> > 
> > (pino:11756): Unique-CRITICAL **: unique_app_watch_window: assertion
> > `GTK_IS_WINDOW (window)' failed
> > 
> > and then it just hangs there and I get no window.
> 
> Would you please check that librsvg2-common is installed on your system?
> 
> If no, I think you have pointed out to a missing dependency.

No, I didn't.  After installing it, pino seems to start OK.

Thanks.
--
Luis Henriques




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#655217: pino fails to start

[Luis Henriques]

Package: pino
Version: 0.2.11+dfsg-1
Severity: important

Hi,

I just installed pino on sid, and I am not able to start it.  When I run pino I
get the following errors on console:

** (pino:11756): CRITICAL **: file 
/tmp/buildd/pino-0.2.11+dfsg/obj-x86_64-linux-gnu/src/main_window.c: line 1310: 
uncaught error: Couldn't recognise the image file format for file 
'/usr/share/icons/hicolor/scalable/apps/pino.svg' (gdk-pixbuf-error-quark, 3)

(pino:11756): GLib-GObject-CRITICAL **: g_object_ref_sink: assertion 
`G_IS_OBJECT (object)' failed

(pino:11756): Unique-CRITICAL **: unique_app_watch_window: assertion 
`GTK_IS_WINDOW (window)' failed

and then it just hangs there and I get no window.

Thanks!

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pino depends on:
ii  libc6   2.13-24
ii  libgdk-pixbuf2.0-0  2.24.0-2
ii  libgee2 0.6.1-3
ii  libglib2.0-02.30.2-4
ii  libgtk2.0-0 2.24.8-2
ii  libgtkspell02.0.16-1
ii  libnotify4  0.7.4-1
ii  libsoup2.4-12.36.1-1
ii  libunique-1.0-0 1.1.6-4
ii  libwebkitgtk-1.0-0  1.6.1-5+b1
ii  libxml2 2.7.8.dfsg-5.1

pino recommends no packages.

pino suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#646465: xxxterm: FTBFS: libjavascriptcoregtk-1.0.so.0: could not read symbols: Invalid operation

[Luis Henriques]

Hi Monica,

On Mon, Oct 24, 2011 at 01:52:39PM +0200, Mònica Ramírez Arceda wrote:
> Source: xxxterm
> Version: 1.518-1
> Severity: serious
> Tags: wheezy sid
> User: debian...@lists.debian.org
> Usertags: qa-ftbfs-20111022 qa-ftbfs
> Justification: FTBFS on amd64
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
> 
> Relevant part:
> > /usr/bin/ld: note: 'JSEvaluateScript' is defined in DSO 
> > /usr/lib/libjavascriptcoregtk-1.0.so.0 so try adding it to the linker 
> > command line
> > /usr/lib/libjavascriptcoregtk-1.0.so.0: could not read symbols: Invalid 
> > operation
> > collect2: ld returned 1 exit status
> 
> The full build log is available from:
>
> http://people.debian.org/~lucas/logs/2011/10/22/xxxterm_1.518-1_lsid64.buildlog
> 
> A list of current common problems and possible solutions is available at 
> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
> 
> About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
> of the Grid'5000 platform, using a clean chroot.  Internet was not
> accessible from the build systems.

Thank you for the bug report.  I just uploaded a new version of this
package into mentors.  You can get it using:

dget -x 
http://mentors.debian.net/debian/pool/main/x/xxxterm/xxxterm_1.7.0-0.1.dsc

or visiting

http://mentors.debian.net/package/xxxterm

Would you be able to test this new version, and verify whether if builds
OK?  I was not able to reproduce the failure with this package, so I would
assume it has been solved.

Cheers,
--
Luis Henriques



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#636804: aewm++: Broken link to homepage

[Luis Henriques]

Package: aewm++
Severity: important

It looks like the link to the project homepage is broken:

http://code.google.com/p/aewmpp

And I was not able to actually find a new one.  Is the upstream project dead?

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#635314: honours GTK theme foreground but ignores GTK theme background in URL bar

[Luis Henriques]

Package: xxxterm
Version: 1.471-1
Followup-For: Bug #635314


Hi,

Could you please tell me on which package I can get this
HighContrastLargePrintInverse theme?  I installed gtk2-engines (sid) but
couldn't find it there...

And thanks for reporting!



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#634761: xxxterm should use more recent webkit for improved javascript performance

[Luis Henriques]

On Wed, Jul 20, 2011 at 02:16:15AM +0530, shirish wrote:
> Hi all,
>  As of right now, xxxterm depends on somewhat an ancient webkit 1.0.2
> . It would be much nicer if it would use the latest webkit (1.4.2)
> which is there in SID .
> http://lists.alioth.debian.org/pipermail/pkg-webkit-maintainers/2011-July/002103.html
> 
> Javascript performance would be better. Just my 2 paise.

xxxterm 1.425-2, available in sid, is already using a more recent version
of webkit.  See also bug #635433.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#634084: Changelog of xxxterm 1.425

[Luis Henriques]

On 7/18/11, shirish शिरीष  wrote:
> Hi there,
>  Just found out the changelog of xxxterm 1.425
>
> http://opensource.conformal.com/fluxbb/viewtopic.php?id=154
>
> * add GTK3 support
> * add workaround for clipboard issues
> * add HTML5 local storage option
> * add spell check option
> * add command and status bar font option
> * add :ls and :buffers widget to select active tabs
> * add option to whitelist JS and cookie in one click/keystroke
> * add webkit 1.4 support and use it for favicon when available
> * downloads no longer overwrite files by default
> * fiddle with ulimit to prevent file descriptor starvation
> * fix couple of focus issues
>
> Having gtk3 support is important, nice.

Hi,

I will take a look at the new version and eventually try to get a
package out of it soon (next weekend, maybe).

Also, thanks for pointing me to the changelog.  It is not available on
the snapshots tarball but I guess I could include it on the package.

Cheers,
--
Luis Henriques



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#625839: (no subject)

[Luis Henriques]

I took a look at the code and the following patch solved the problem.  Not sure
if that's the best solution, though.  I haven't spent too much time trying to
understand the whole code.

I guess next step would be to check if upstream has same issue (or if it has
been solved already).

--- accounts.py.backup  2011-07-12 22:03:12.807410246 +0100
+++ accounts.py 2011-07-12 22:03:42.206040653 +0100
@@ -356,6 +356,8 @@ class GwibberAccountManager(object):
   self.account_widget = aw
 if not is_new:
   self.ui.get_object('vbox_create').hide()
+else:
+  self.ui.get_object('vbox_create').show()
 
   def on_accounts_dialog_destroy(self, widget, data=None):
 gtk.main_quit()



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#542343: evilwm Debian package

[Luis Henriques]

Hi,

I would like to ask the maintainer (and author!) of this package whether
there are any plans for uploading a new version.

thanks,
-- 
Luis Henriques



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#552647: or recommend acpi and iostat

[Luis Henriques]

Package: scrotwm
Version: 0.9.20-1
Followup-For: Bug #552647

I agree with the maintainer position, and I would be OK event without the
README.Debian file.  Anyway, I believe its now time to close this bug.  It's
been more than an year now, and no progress has been made.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-rc6 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages scrotwm depends on:
ii  libc6 2.13-7 Embedded GNU C Library: Shared lib
ii  libx11-6  2:1.4.3-2  X11 client-side library
ii  libxrandr22:1.3.1-2  X11 RandR extension library

Versions of packages scrotwm recommends:
ii  dwm-tools 35-1   simple commands for minimalistic w
ii  xfonts-terminus   4.30-2 Fixed-width fonts for fast reading
ii  xterm [x-terminal-emulator]   270-1  X terminal emulator

scrotwm suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#631655: ITP: xxxterm -- XXXTerm is a minimalists web browser

[Luis Henriques]

Package: wnpp
Severity: wishlist
Owner: Luis Henriques 

* Package name: xxxterm
  Version : 1.399
  Upstream Author : Marco Peereboom , Stevan Andjelkovic 
, Edd Barrett , Todd T. Fries 

* URL : http://opensource.conformal.com/wiki/xxxterm
* License : ISC
  Programming Lang: C
  Description : XXXTerm is a minimalists web browser

 XXXTerm is a minimalists web browser.  It strives to be vi-like for
 heavy keyboard users while maintaining traditional web browser behavior.
 .
 Major features include:
 * Tabbed browsing
 * Cookie support
 * Cookie white list
 * JavaScript white list
 * JavaScript runtime toggle
 * History
 * Download manager
 * vim keybindings
 * Text based config file
 * Search engine entry box
 * Search on page
 * Basic MIME support
 * Favorites
 * Print, including to pdf
 * Mouse-less browsing



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#612818: emacs documentation (emacs manual, elisp manual) does not appear in the 'info' list

[Luis Henriques]

Package: emacs23
Version: 23.3+1-1
Followup-For: Bug #612818

Actually, this is not a bug.  Take a look at [1] -- Debian considers Emacs
documentation to be non-free.

Anyway, you can install the documentation by adding the 'non-free'
component to your sources.list and installing the emacs23-common-non-dfsg 
package.

I guess this bug can be closed...?

[1] http://people.debian.org/~srivasta/Position_Statement.xhtml



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#627928: qemu-system: Missing support for common machines such as ARM beagleboard

[Luis Henriques]

Package: qemu-system
Version: 0.14.0+dfsg-5.1
Severity: wishlist

Ubuntu provides already a more interesting set of machines for the ARM 
emulation.
I believe they are shipping the Linaro QEMU version.  The list of machines
available on Ubuntu are:

$ qemu-system-arm -M ?
Supported machines are:
vexpress-a9 ARM Versatile Express for Cortex-A9
syborg Syborg (Symbian Virtual Platform)
musicpal   Marvell 88w8618 / MusicPal (ARM926EJ-S)
mainstone  Mainstone II (PXA27x)
n800   Nokia N800 tablet aka. RX-34 (OMAP2420)
n810   Nokia N810 tablet aka. RX-44 (OMAP2420)
n900   Nokia N900 (OMAP3)
cheetahPalm Tungsten|E aka. Cheetah PDA (OMAP310)
sx1Siemens SX1 (OMAP310) V2
sx1-v1 Siemens SX1 (OMAP310) V1
beagle Beagle board (OMAP3530)
beaglexm   Beagle board XM (OMAP3630)
tosa   Tosa PDA (PXA255)
akita  Akita PDA (PXA270)
spitz  Spitz PDA (PXA270)
borzoi Borzoi PDA (PXA270)
terrierTerrier PDA (PXA270)
connex Gumstix Connex (PXA255)
verdex Gumstix Verdex (PXA270)
lm3s811evb Stellaris LM3S811EVB
lm3s6965evb Stellaris LM3S6965EVB
realview-eb ARM RealView Emulation Baseboard (ARM926EJ-S)
realview-eb-mpcore ARM RealView Emulation Baseboard (ARM11MPCore)
realview-pb-a8 ARM RealView Platform Baseboard for Cortex-A8
realview-pbx-a9 ARM RealView Platform Baseboard Explore for Cortex-A9
versatilepb ARM Versatile/PB (ARM926EJ-S)
versatileab ARM Versatile/AB (ARM926EJ-S)
integratorcp ARM Integrator/CP (ARM926EJ-S) (default)

Any plans for including a more recent (and complete) qemu-system version
on Debian?

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages qemu-system depends on:
ii  etherboot-qemu  5.4.4-9  Bootstrapping for various network 
ii  libaio1 0.3.109-1Linux kernel AIO access library - 
ii  libasound2  1.0.23-4 shared library for ALSA applicatio
ii  libattr11:2.4.44-2   Extended attribute shared library
ii  libbluetooth3   4.91-1   Library to use the BlueZ Linux Blu
ii  libbrlapi0.54.2-7braille display access via BRLTTY 
ii  libc6   2.13-4   Embedded GNU C Library: Shared lib
ii  libcurl3-gnutls 7.21.6-1 Multi-protocol file transfer libra
ii  libesd0 0.2.41-9 Enlightened Sound Daemon - Shared 
ii  libgnutls26 2.10.5-1+b1  the GNU TLS library - runtime libr
ii  libjpeg62   6b1-1The Independent JPEG Group's JPEG 
ii  libncurses5 5.9-1shared libraries for terminal hand
ii  libpng12-0  1.2.44-2 PNG library - runtime
ii  libpulse0   0.9.21-4 PulseAudio client libraries
ii  libsasl2-2  2.1.23.dfsg1-8   Cyrus SASL - authentication abstra
ii  libsdl1.2debian 1.2.14-6.3   Simple DirectMedia Layer
ii  libuuid12.17.2-9.1   Universally Unique ID library
ii  libvdeplug2 2.2.3-3+b1   Virtual Distributed Ethernet - Plu
ii  libx11-62:1.4.3-1X11 client-side library
ii  openbios-ppc1.0+svn1018-1PowerPC Open Firmware
ii  openbios-sparc  1.0+svn1018-1SPARC Open Firmware
ii  openhackware0.4.1-4  OpenFirmware emulator for PowerPC
ii  qemu-keymaps0.14.0+dfsg-5.1  QEMU keyboard maps
ii  seabios 0.6.1.2-2Legacy BIOS implementation
ii  vgabios 0.6c-3   VGA BIOS software for the Bochs an
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages qemu-system recommends:
ii  qemu-utils   0.14.0+dfsg-5.1 QEMU utilities
ii  vde2 2.2.3-3+b1  Virtual Distributed Ethernet

Versions of packages qemu-system suggests:
pn  samba  (no description available)

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org