Bug#966106: missing desc

[Seyeong Kim]

v2.36-rc2 has fix.

Bug#966106: rename.ul refuses to rename links that don't resolve

[Seyeong Kim]

Package: util-ilnux
Version: 2.35.2-8

rename.ul refuses to rename links that don't resolve.

Test Steps

Before:

  $ touch file-found
  $ ln -s file-found symlink-1
  $ ./rename sym symbolic- symlink-1 # XPASS.
  $ echo $?
  0

  $ ln -s file-not-found symlink-2
  $ ./rename sym symbolic- symlink-2 # FAIL! REGRESSION.
  rename: symlink-2: not accessible: No such file or directory
  $ echo $?
  1

  $ ./rename sym symbolic- symlink-3 # XFAIL.
  rename: symlink-3: not accessible: No such file or directory
  $ echo $?
  1

  $ touch file-found
  $ ./rename found existing file-found # XPASS.
  $ echo $?
  0

  $ ./rename found existing file-not-found # XFAIL.
  rename: file-not-found: not accessible: No such file or directory
  $ echo $?
  1

After:

  $ touch file-found
  $ ln -s file-found symlink-1
  $ ./rename sym symbolic- symlink-1 # XPASS.
  $ echo $?
  0

  $ ln -s file-not-found symlink-2
  $ ./rename sym symbolic- symlink-2 # PASS! REGRESSION FIXED.
  $ echo $?
  0

  $ ./rename sym symbolic- symlink-3 # XFAIL.
  rename: symlink-3: not accessible: No such file or directory
  $ echo $?
  1

  $ touch file-found
  $ ./rename found existing file-found # XPASS.
  $ echo $?
  0

  $ ./rename found existing file-not-found # XFAIL.
  rename: file-not-found: not accessible: No such file or directory
  $ echo $?
  1

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Yes. Im considering all but leave them last chance.

ok  I’ll have discussion with team based on this thread

Thanks :)

On 16 May 2018, 8:01 PM +0900, Niels Thykier , wrote:
>
>
> As I understand it, if we do that we might as well remove the #TMPFILES#
> marker in the shell script (as it would be simpler and probably faster
> than implementing the same code in shell). But then we are back to the
> place that Michael recom

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Hello

I noticed that tmpfiles are built based on systemd source directory not local 
machine /

e.g debian/systemd/usr/lib/tmpfiles.d/x11.conf

so 00rsyslog.conf file ( from rsyslog pkg, in /usr/lib/tmpfiles.d/ ) is not 
there

I checked this with dh_installinit —no-start

I understand override feature(actually i misunderstood it )

no way to do this based on installed tmpfiles?( or not recommended ? )

## dh_installinit

        if (!$dh{NOSCRIPTS}) {
                # Include postinst-init-tmpfiles if the package ships any files
                # in /usr/lib/tmpfiles.d or /etc/tmpfiles.d
                my @tmpfiles;
                find({
                        wanted => sub {
                                my $name = $File::Find::name;
                                return unless -f $name;
                                print "Seyeong1 : ".$name."\n";
                                $name =~ s/^\Q$tmp\E//g;
                                print "Seyeong2 : ".$name."\n";
                                if ($name =~ m,^/usr/lib/tmpfiles\.d/, ||
                                        $name =~ m,^/etc/tmpfiles\.d/,) {
                                        print "Seyeong3 : ".$name."\n";
                                        push @tmpfiles, $name;
                                }
                        },
                        no_chdir => 1,
                }, $tmp);
                if (@tmpfiles > 0) {
                        autoscript($package,"postinst", 
"postinst-init-tmpfiles",
                                "s,#TMPFILES#," . join(" ", sort 
@tmpfiles).",g");
                }
        }


generated postinst.debhelper
echo part is what i added

# Automatically added by dh_installinit
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = 
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
        # In case this system is running systemd, we need to ensure that all
        # necessary tmpfiles (if any) are created before starting.
        if [ -d /run/systemd/system ] ; then
                echo /usr/lib/tmpfiles.d/debian.conf 
/usr/lib/tmpfiles.d/home.conf /usr/lib/tmpfiles.d/journal-nocow.conf 
/usr/lib/tmpfiles.d/legacy.conf /usr/lib/tmpfiles.d/systemd-nologin.conf 
/usr/lib/tmpfiles.d/systemd.conf /usr/lib/tmpfiles.d/tmp.conf 
/usr/lib/tmpfiles.d/var.conf /usr/lib/tmpfiles.d/x11.conf
                systemd-tmpfiles --create /usr/lib/tmpfiles.d/debian.conf 
/usr/lib/tmpfiles.d/home.conf /usr/lib/tmpfiles.d/journal-nocow.conf 
/usr/lib/tmpfiles.d/legacy.conf /usr/lib/tmpfiles.d/systemd-nologin.conf 
/usr/lib/tmpfiles.d/systemd.conf /usr/lib/tmpfiles.d/tmp.conf 
/usr/lib/tmpfiles.d/var.conf /usr/lib/tmpfiles.d/x11.conf >/dev/null || true
        fi
fi
# End automatically added section
# Automatically added by dh_installdeb
dpkg-maintscript-helper rm_conffile 
/etc/bash_completion.d/systemctl-bash-completion.sh 204-1~ -- "$@"
# End automatically added section
# Automatically added by dh_installdeb
dpkg-maintscript-helper rm_conffile 
/etc/bash_completion.d/systemd-bash-completion.sh 204-1~ -- "$@"
# End automatically added section
# Automatically added by dh_installdeb
dpkg-maintscript-helper mv_conffile /etc/systemd/systemd-logind.conf 
/etc/systemd/logind.conf 204-1~ -- "$@"
# End automatically added section
# Automatically added by dh_installdeb
dpkg-maintscript-helper mv_conffile /etc/systemd/systemd-journald.conf 
/etc/systemd/journald.conf 204-1~ -- "$@"
# End automatically added section
# Automatically added by dh_installdeb
dpkg-maintscript-helper rm_conffile 
/etc/dbus-1/system.d/org.freedesktop.machine1.conf 228-5~ -- "$@"
# End automatically added section
# Automatically added by dh_installdeb
dpkg-maintscript-helper rm_conffile /etc/X11/xinit/xinitrc.d/50-systemd-user.sh 
228-3~ -- "$@"
# End automatically added section





On 12 May 2018, 2:41 AM +0900, Niels Thykier <ni...@thykier.net>, wrote:
> Seyeong Kim:
> > Hello
> >
> > I tested them but symptom is still there
> >
> > so I put “print “#TMPFILES#” on autoscripts/postinst-init-tmpfiles like 
> > below
> >
> > ###
> > if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ]; then
> > # In case this system is running systemd, we need to ensure that all
> > # necessary tmpfiles (if any) are created before starting.
> > if [ -d /run/systemd/system ] ; then
> >                 print "#TMPFILES#"
> > systemd-tmpfiles --create #TMPFILES# >/dev/null || true
> > fi
> > fi
> > ###
> >
> > and built systemd with this deb helper
> >
> &

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Hello

I tested them but symptom is still there

so I put “print “#TMPFILES#” on autoscripts/postinst-init-tmpfiles like below

###
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ]; then
# In case this system is running systemd, we need to ensure that all
# necessary tmpfiles (if any) are created before starting.
if [ -d /run/systemd/system ] ; then
                print "#TMPFILES#"
systemd-tmpfiles --create #TMPFILES# >/dev/null || true
fi
fi
###

and built systemd with this deb helper

When installing systemd after build, i got below string ( installed 
00rsyslog.conf in /usr/lib/tmpfiles.d/ and copied to /etc/tmpfiles.d/ )

###
Error: no such file "debian.conf home.conf journal-nocow.conf legacy.conf 
systemd-nologin.conf systemd.conf tmp.conf var.conf x11.conf"

###

I wanted to see TMPFILES list and there is no 00rsyslog.conf so.. 
00rsyslog.conf can't override var.conf

maybe this need to be analyzed more?

Thanks


On 11 May 2018, 4:30 PM +0900, Seyeong Kim <seyeong@canonical.com>, wrote:
> exactly what i wanted.
>
> Thanks all!!
>
> On 11 May 2018, 4:24 PM +0900, Niels Thykier <ni...@thykier.net>, wrote:
> > Seyeong Kim:
> > > Thanks a lot
> > >
> > > Can i get git repo url you mentioned?
> > >
> > > [...]
> > >
> >
> > Certainly. The repo is at:
> >
> > https://salsa.debian.org/debian/debhelper/
> >
> > The commit is at:
> >
> > https://salsa.debian.org/debian/debhelper/commit/d24b1734a7a8b1069426fbb8ce80328959560ea9
> >
> > In case you want to cherry-pick it.
> >
> >
> > Thanks,
> > ~Niels

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

exactly what i wanted.

Thanks all!!

On 11 May 2018, 4:24 PM +0900, Niels Thykier <ni...@thykier.net>, wrote:
> Seyeong Kim:
> > Thanks a lot
> >
> > Can i get git repo url you mentioned?
> >
> > [...]
> >
>
> Certainly. The repo is at:
>
> https://salsa.debian.org/debian/debhelper/
>
> The commit is at:
>
> https://salsa.debian.org/debian/debhelper/commit/d24b1734a7a8b1069426fbb8ce80328959560ea9
>
> In case you want to cherry-pick it.
>
>
> Thanks,
> ~Niels

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Thanks a lot

Can i get git repo url you mentioned?

On 11 May 2018, 4:09 PM +0900, Niels Thykier , wrote:
> Michael Biebl:
> > Am 04.05.2018 um 13:47 schrieb Michael Biebl:
> > > Dropping #TMPFILES# means, systemd-tmpfiles will act on all tmpfiles.
> > > This would be a bit like if upgrading rsyslog would restart all system
> > > services (including rsyslog). That doesn't feel right.
> > > So I don't think dropping #TMPFILES# is the right approach.
> >
> > [...]
> >
> > One valid use cases this touches though is, that overriding tmpfiles in
> > /etc/tmpfiles.d should be supported. I.e. if there is a
> > /usr/lib/tmpfiles.d/dbus.conf and an admin wants to tweak that by
> > shipping a /etc/tmpfiles.d/dbus.conf, I don't think the package should
> > override that.
> > Afaics, this could easily be fixed by only using the name of the .conf
> > file, not the full path, so dh_installsystemd/dh_installinit would have
> > to generate
> > systemd-tmpfiles --create dbus.conf
> > instead of
> > systemd-tmpfiles --create /usr/lib/tmpfiles.d/dbus.conf
> >
> > Felipe et al, what do you think?
> >
> > (CC pkg-systemd-maintainers to have more eyes on this)
> >
> > Michael
> >
>
> Hi,
>
> After a short chat with Felipe yesterday, I have updated the debhelper
> tooling (in git master) to generate "systemd-tmpfiles --create
> dbus.conf" instead of "systemd-tmpfiles --create
> /usr/lib/tmpfiles.d/dbus.conf". This solves one half of the issue
> (namely that package provided tmpfiles configs could not be overridden
> at all).
>
> On the other part of the issue, I will follow Michael's recommendation
> of keeping #TMPFILES# in the postinst. As I understand it, this
> effectively makes that part "wontfix".
>
> Thanks,
> ~Niels

Bug#894510: [debhelper-devel] Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Could somebody check this issue if you have time?

I would really appreciate it.

Thanks

On 11 Apr 2018, 2:17 PM +0900, Seyeong Kim <seyeong@canonical.com>, wrote:
> Right. Missed it.
>
> Thanks!
>
> > 2018. 4. 11. 오후 2:13, Niels Thykier <ni...@thykier.net> 작성:
> >
> > Seyeong Kim:
> > > Please take a look this if you have time.
> > >
> > > Thanks
> > >
> > > [...]
> > Hi Seyeong,
> >
> > Please remember to Cc Felipe and Michael on this bug if you want them to
> > see the follow ups. :)
> >
> > Thanks,
> > ~Niels
>

Bug#894510: [debhelper-devel] Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Right. Missed it.

Thanks!

> 2018. 4. 11. 오후 2:13, Niels Thykier <ni...@thykier.net> 작성:
> 
> Seyeong Kim:
>> Please take a look this if you have time.
>> 
>> Thanks
>> 
>> [...]
> Hi Seyeong,
> 
> Please remember to Cc Felipe and Michael on this bug if you want them to
> see the follow ups. :)
> 
> Thanks,
> ~Niels

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Please take a look this if you have time.

Thanks

On Wed, 04 Apr 2018 17:47:00 + Niels Thykier <ni...@thykier.net> wrote:
> Hi,
> 
> @Michael/@Felipe: Could you have a look at this bug ?
> 
> On Sat, 31 Mar 2018 08:58:21 -0700 Seyeong Kim
> <seyeong@canonical.com> wrote:
> > Package: debhelper
> > Version: 9.20160115ubuntu3
> > Severity: normal
> > Tags: d-i
> > 
> > In autoscripts/postinst-init-tmpfiles, There is TMPFILE containing conf in 
> > systemd pkg only.
> > Then if there is 00rsyslog.conf from rsyslog pkg. and installing or 
> > upgrading systemd
> > 
> > /var/log's permission is 755(which is default) not 775(which is in 
> > 00rsyslog.conf)
> > overriding doesn't work when upgrading.
> > 
> > Please refer to below LP
> > ubuntu lp bug : 
> > https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1748147
> > 
> > removing TMPFILE from autoscripts/postinst-init-tmpfiles solves this issue.
> > e.g. change like below
> > systemd-tmpfiles --create #TMPFILES# >/dev/null || true
> > to
> > systemd-tmpfiles --create >/dev/null || true
> > 
> > and removing related code from dh_installinit maybe needed
> > e.g. below kind of part
> > if (compat(10) && !$dh{NOSCRIPTS}) {
> > # Include postinst-init-tmpfiles if the package ships any 
> > files
> > # in /usr/lib/tmpfiles.d or /etc/tmpfiles.d
> > my @tmpfiles;
> > find({
> > wanted => sub {
> > my $name = $File::Find::name;
> > return unless -f $name;
> > $name =~ s/^\Q$tmp\E//g;
> > if ($name =~ m,^/usr/lib/tmpfiles\.d/, ||
> > $name =~ m,^/etc/tmpfiles\.d/,) {
> > push @tmpfiles, $name;
> > }
> > },
> > no_chdir => 1,
> > }, $tmp);
> > if (@tmpfiles > 0) {
> > autoscript($package,"postinst", 
> > "postinst-init-tmpfiles",
> > "s,#TMPFILES#," . join(" ", sort 
> > @tmpfiles).",g");
> > }
> > }
> > 
> > Is there any reason that TMPFILE list is there? 
> > 
> > [...]
> 
> Thanks,
> ~Niels
> 
> 

Bug#894510: debhelper: Because it is listing tmpfiles in systemd's only, conf overriding is not working

[Seyeong Kim]

Package: debhelper
Version: 9.20160115ubuntu3
Severity: normal
Tags: d-i

In autoscripts/postinst-init-tmpfiles, There is TMPFILE containing conf in 
systemd pkg only.
Then if there is 00rsyslog.conf from rsyslog pkg. and installing or upgrading 
systemd

/var/log's permission is 755(which is default) not 775(which is in 
00rsyslog.conf)
overriding doesn't work when upgrading.

Please refer to below LP
ubuntu lp bug : https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1748147

removing TMPFILE from autoscripts/postinst-init-tmpfiles solves this issue.
e.g. change like below
systemd-tmpfiles --create #TMPFILES# >/dev/null || true
to
systemd-tmpfiles --create >/dev/null || true

and removing related code from dh_installinit maybe needed
e.g. below kind of part
if (compat(10) && !$dh{NOSCRIPTS}) {
# Include postinst-init-tmpfiles if the package ships any files
# in /usr/lib/tmpfiles.d or /etc/tmpfiles.d
my @tmpfiles;
find({
wanted => sub {
my $name = $File::Find::name;
return unless -f $name;
$name =~ s/^\Q$tmp\E//g;
if ($name =~ m,^/usr/lib/tmpfiles\.d/, ||
$name =~ m,^/etc/tmpfiles\.d/,) {
push @tmpfiles, $name;
}
},
no_chdir => 1,
}, $tmp);
if (@tmpfiles > 0) {
autoscript($package,"postinst", 
"postinst-init-tmpfiles",
"s,#TMPFILES#," . join(" ", sort 
@tmpfiles).",g");
}
}

Is there any reason that TMPFILE list is there? 


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-87-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=ko_KR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages debhelper depends on:
ii  autotools-dev20150820.1
ii  binutils 2.26.1-1ubuntu1~16.04.6
ii  dh-strip-nondeterminism  0.015-1
ii  dpkg 1.18.4ubuntu1.2
ii  dpkg-dev 1.18.4ubuntu1.4
ii  file 1:5.25-2ubuntu1
ii  libdpkg-perl 1.18.4ubuntu1.4
ii  man-db   2.7.5-1
ii  perl 5.22.1-9ubuntu0.2
ii  po-debconf   1.0.19

debhelper recommends no packages.

Versions of packages debhelper suggests:
pn  dh-make  

-- no debconf information

Bug#886732: Attachment

[Seyeong Kim]

diff -Nru apparmor-2.11.1/debian/changelog apparmor-2.11.1/debian/changelog
--- apparmor-2.11.1/debian/changelog2017-12-06 23:32:02.0 -0800
+++ apparmor-2.11.1/debian/changelog2018-01-09 03:25:45.0 -0800
@@ -1,3 +1,10 @@
+apparmor (2.11.1-5) unstable; urgency=medium
+
+  * Support PID more than 6 digits (Closes: #886732))
+- d/p/0001-Allow-seven-digit-pid.patch
+
+ -- Seyeong Kim <seyeong@canonical.com>  Tue, 09 Jan 2018 02:45:56 -0800
+
 apparmor (2.11.1-4) unstable; urgency=medium
 
   * Bump pinned feature set to linux-image-4.14.0-1's, version 4.14.2-1
diff -Nru apparmor-2.11.1/debian/patches/0001-Allow-seven-digit-pid.patch 
apparmor-2.11.1/debian/patches/0001-Allow-seven-digit-pid.patch
--- apparmor-2.11.1/debian/patches/0001-Allow-seven-digit-pid.patch 
1969-12-31 16:00:00.0 -0800
+++ apparmor-2.11.1/debian/patches/0001-Allow-seven-digit-pid.patch 
2018-01-09 02:33:18.0 -0800
@@ -0,0 +1,25 @@
+From 630cb2a981cdc731847e8fdaafc45bcd337fe747 Mon Sep 17 00:00:00 2001
+From: Vincas Dargis <vin...@gmail.com>
+Date: Sat, 30 Sep 2017 15:28:15 +0300
+Subject: [PATCH] Allow seven digit pid
+
+---
+ profiles/apparmor.d/tunables/kernelvars | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Origin: upstream, 
https://gitlab.com/apparmor/apparmor/commit/630cb2a981cdc731847e8fdaafc45bcd337fe747
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1717714
+
+Index: apparmor-2.11.1/profiles/apparmor.d/tunables/kernelvars
+===
+--- apparmor-2.11.1.orig/profiles/apparmor.d/tunables/kernelvars   
2018-01-09 02:31:59.545270685 -0800
 apparmor-2.11.1/profiles/apparmor.d/tunables/kernelvars2018-01-09 
02:31:59.545270685 -0800
+@@ -13,7 +13,7 @@
+ # and until the parser supports nested groupings like
+ #   @{pid}=[1-9]{[0-9]{[0-9]{[0-9]{[0-9]{[0-9],},},},},}
+ # use
+-@{pid}={[1-9],[1-9][0-9],[1-9][0-9][0-9],[1-9][0-9][0-9][0-9],[1-9][0-9][0-9][0-9][0-9],[1-9][0-9][0-9][0-9][0-9][0-9]}
++@{pid}={[1-9],[1-9][0-9],[1-9][0-9][0-9],[1-9][0-9][0-9][0-9],[1-9][0-9][0-9][0-9][0-9],[1-9][0-9][0-9][0-9][0-9][0-9],[1-4][0-9][0-9][0-9][0-9][0-9][0-9]}
+ 
+ #same pattern as @{pid} for now
+ @{tid}=@{pid}
diff -Nru apparmor-2.11.1/debian/patches/series 
apparmor-2.11.1/debian/patches/series
--- apparmor-2.11.1/debian/patches/series   2017-11-05 11:25:34.0 
-0800
+++ apparmor-2.11.1/debian/patches/series   2018-01-09 02:31:57.0 
-0800
@@ -41,3 +41,4 @@
 flatpak-exports.patch
 utils-logprof-python3.6.patch
 utils-keep-shebang.patch
+0001-Allow-seven-digit-pid.patch

Bug#886732: apparmor: @{pid} variable broken on systems with pid_max more than 6 digits

[Seyeong Kim]

Package: apparmor
Version: 2.11.1-4
Severity: normal

Dear Maintainer,

if PID is more than 6 digits, apparmor denies services.

the patch for this is in upstream [1]
Ubuntu bug LP [2]

[1] 
https://gitlab.com/apparmor/apparmor/commit/630cb2a981cdc731847e8fdaafc45bcd337fe747
[2] https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/1717714

Bug#671235: no news for this?

[Seyeong Kim]

no news for this bug?

i need to fix this...