Bug#918225: pasystray: prefer GtkStatusIcon over Appindicator
Hi Scott, Thanks for pointing out these issues that I wasn't aware of. I guess the best is to add support for these events in libayatana-appindicator, then. I already filed a bug there, I'll try to make a PR when I find some time. Best, Valentin On Tue, 2019-01-15 at 21:39 +1100, Scott Leggett wrote: > On 2019-01-04.13:36, Valentin Blot wrote: > > Current implementation of AppIndicator does not handle click events > > or > > modifiers. A middle click on the icon of pasystray is supposed to > > toggle mute, but this is not possible with the AppIndicator > > implementation. I filed a bug to AppIndicator but in the meantime > > it > > would be better to fallback to the GtkStatusIcon implementation, > > which > > is done with the attached patch. > > Hi Valentin, thanks for the bug report. > > Unfortunately this issue is not so simple to fix. > > I cannot switch back to GtkStatusIcon for the following reasons: > > * it has accessibility issues [0] > * it doesn't work in some modern desktop environments[1]; > AppIndicator > support is more widespread > * it is deprecated upstream [2] > > As I commented in the upstream bug report [3], I believe it is > possible > to handle middle-click using AppIndicators, but this is something > that > should be fixed upstream. > > I'm not sure how other click events and modifiers can be supported > using > AppIndicators. > > [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861387 > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827458 > [2] > https://developer.gnome.org/gtk3/stable/GtkStatusIcon.html#GtkStatusIcon.description > [3] > https://github.com/christophgysin/pasystray/issues/102#issuecomment-453489596 >
Bug#918225: pasystray: prefer GtkStatusIcon over Appindicator
Package: pasystray Version: 0.7.0-1 Severity: normal Tags: patch Current implementation of AppIndicator does not handle click events or modifiers. A middle click on the icon of pasystray is supposed to toggle mute, but this is not possible with the AppIndicator implementation. I filed a bug to AppIndicator but in the meantime it would be better to fallback to the GtkStatusIcon implementation, which is done with the attached patch. --- a/debian/rules 2018-10-29 13:29:50.0 +0100 +++ b/debian/rules 2019-01-04 13:22:58.932093829 +0100 @@ -2,5 +2,8 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all +override_dh_auto_configure: + dh_auto_configure -- --disable-appindicator + %: dh $@ --with autoreconf
Bug#917204: openbox: undecorated maximized windows have a top border
Package: openbox
Version: 3.6.1-7
Severity: normal
Tags: patch
When rc.xml contains yes, undecorated maximized
windows still have a top border. A comment in the source code (see
patch)
justifies this by the fact that the client menu needs to be accessible.
However, the client menu is inaccessible anyway when keepBorder is set
to "no".
Moreover, the left, right and bottom borders are hidden and it makes
more
sense to hide the top one as well. This top border is also annoying in
several
circumstances (e.g. in order to click on a tab in firefox you have to be
bellow
the top of the screen so you need to be precise with the mouse).Description: Removed top border on undecorated maximized windows
.
openbox (3.6.1-7custom) unstable; urgency=medium
.
* Removed top border on maximized undecorated windows.
Author: Val
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: ,
Bug:
Bug-Debian: https://bugs.debian.org/
Bug-Ubuntu: https://launchpad.net/bugs/
Forwarded:
Reviewed-By:
Last-Update: 2018-12-23
--- openbox-3.6.1.orig/openbox/frame.c
+++ openbox-3.6.1/openbox/frame.c
@@ -585,12 +585,6 @@ void frame_adjust_area(ObFrame *self, gb
if (self->decorations & OB_FRAME_DECOR_TITLEBAR)
self->size.top += ob_rr_theme->title_height + self->bwidth;
-else if (self->max_horz && self->max_vert) {
-/* A maximized and undecorated window needs a border on the
- top of the window to let the user still undecorate/unmaximize the
- window via the client menu. */
-self->size.top += self->bwidth;
-}
if (self->decorations & OB_FRAME_DECOR_HANDLE &&
ob_rr_theme->handle_height > 0)
Bug#901594: DE-agnostic agent
I don't use a DE. Maybe the "demo" agent should be renamed and enhanced into a "default" agent for all the people who don't use a DE?
Bug#901594: geoclue package should depend on an agent
Package: geoclue-2.0 Version: 2.4.10-1 Now that an agent is required for geoclue, the package should have a dependency on such an agent. Currently this agent can be either gnome's or the demo agent shipped in geoclue-2-demo.
Bug#900936: some info on this bug
I filled a bug upstream because the source of the problem is that the agent is started while geoclue is not running. see https://gitlab.freedesktop.org/geoclue/geoclue/issues/68
