Bug#355883: Same problem here
Hi Adam Adam Cécile (Le_Vert) wrote: Bastian Blank a écrit : On Tue, Aug 19, 2008 at 06:50:11PM +0200, Adam Cécile (Le_Vert) wrote: I can confirm this bug 2.6.26-1-amd64 and a slightly modified rebuild of the i386 flavour. My usb stick is unusable. I doubt that you see the same bug. Try #494800. Check reply by Kumar Appaiah (20080812). He re-opened this bug against kernel 2.6.26. I noticed severity has been dropped from important to normal. Any justification ? Someone which is not submitter or maintainer changed it. I'd rather say it's critical. Everybody needs usb sticks No. Many of my machines don't even have usb. No comment. Bastian I found the attached patch somewhere on lkml. It's targeted for kernel 2.6.27. I can confirm this patch fix the issue with my stick. This patch hasn`t taken to Linus`s tree yet but has been queued by Greg K-H, guess we`ll see it merged until 2.6.27. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#484501: grub: Really odd code in savedefault.diff
Hi Samuel The patch seems to be ok, I`m gonna give it a try and ask Robert Millan for commit. thanks Samuel Thibault escreveu: Package: grub Version: 0.97-39 Severity: normal Tags: patch Hello, I have to admit I fail to understand how the stage2.c part of savedefault.diff was supposed to work correctly. Here is a patch that makes it a lot simpler and actually properly working. Samuel -- Package-specific info: *** BEGIN /boot/grub/device.map (hd0) /dev/hda (hd1) /dev/hda6 *** END /boot/grub/device.map *** BEGIN /proc/mounts /dev/root / ext3 rw,noatime,errors=remount-ro,data=ordered 0 0 /dev/root /dev/.static/dev ext3 rw,errors=remount-ro,data=ordered 0 0 /dev/hda1 /mnt/win ntfs ro,uid=1000,gid=100,umask=0222,nls=iso8859-1,errors=continue,mft_zone_multiplier=1 0 0 /dev/hda5 /mnt/goinfre vfat rw,noatime,uid=1000,gid=100,fmask=0002,dmask=0002,codepage=cp850,iocharset=cp850 0 0 /dev/hda4 /mnt/dos vfat rw,fmask=0022,dmask=0022,codepage=cp850,iocharset=cp850 0 0 *** END /proc/mounts *** BEGIN /boot/grub/menu.lst # menu.lst - See: grub(8), info grub, update-grub(8) #grub-install(8), grub-floppy(8), #grub-md5-crypt, /usr/share/doc/grub #and /usr/share/doc/grub-doc/. #terminal --dumb console ## default num # Set the default entry to the entry number NUM. Numbering starts from 0, and # the entry number 0 is the default if the command is not used. # # You can specify 'saved' instead of a number. In this case, the default entry # is the entry saved with the command 'savedefault'. default 1 ## timeout sec # Set a timeout, in SEC seconds, before automatically booting the default entry # (normally the first entry defined). timeout 5 # Pretty colours color cyan/blue white/blue ### PASSWORD LINE REMOVED ### # If used in the first section of a menu file, disable all interactive editing # control (menu entry editor and command-line) and entries protected by the # command 'lock' ### PASSWORD LINE REMOVED ### ### PASSWORD LINE REMOVED ### ### PASSWORD LINE REMOVED ### # # examples # # title Windows 95/98/NT/2000 # root (hd0,0) # makeactive # chainloader +1 # # title Linux # root (hd0,1) # kernel/vmlinuz root=/dev/hda2 ro # # # Put static boot stanzas before and/or after AUTOMAGIC KERNEL LIST ### BEGIN AUTOMAGIC KERNELS LIST ## lines between the AUTOMAGIC KERNELS LIST markers will be modified ## by the debian update-grub script except for the default options below ## DO NOT UNCOMMENT THEM, Just edit them to your needs ## ## Start Default Options ## ## default kernel options ## default kernel options for automagic boot options ## If you want special options for specific kernels use kopt_x_y_z ## where x.y.z is kernel version. Minor versions can be omitted. ## e.g. kopt=root=/dev/hda1 ro ## kopt_2_6_8=root=/dev/hdc1 ro ## kopt_2_6_8_2_686=root=/dev/hdc2 ro # kopt=root=/dev/hda2 ro vga=extended lapic video=intelfb:1024x768 nmi_watchdog=0 keyboard.default_leds=2 ## default grub root device ## e.g. groot=(hd0,0) # groot=(hd0,1) ## should update-grub create alternative automagic boot options ## e.g. alternative=true ## alternative=false # alternative=true ## should update-grub lock alternative automagic boot options ## e.g. lockalternative=true ## lockalternative=false # lockalternative=false ## additional options to use with the default boot option, but not with the ## alternatives ## e.g. defoptions=vga=791 resume=/dev/hda5 # defoptions= ## should update-grub lock old automagic boot options ## e.g. lockold=false ## lockold=true # lockold=false ## Xen hypervisor options to use with the default Xen boot option # xenhopt=vga=text-80x50,keep ## Xen Linux kernel options to use with the default Xen boot option # xenkopt=console=tty0 4 ## altoption boot targets option ## multiple altoptions lines are allowed ## e.g. altoptions=(extra menu suffix) extra boot options ## altoptions=(single-user) single # altoptions=(recovery mode) single # altoptions=(emergency mode) emergency ## controls how many kernels should be put into the menu.lst ## only counts the first occurence of a kernel, not the ## alternative kernel options ## e.g. howmany=all ## howmany=7 # howmany=all ## should update-grub create memtest86 boot option ## e.g. memtest86=true ## memtest86=false # memtest86=true ## should update-grub adjust the value of the default booted system ## can be true or false # updatedefaultentry=false ## should update-grub add savedefault to the default options ## can be true or false # savedefault=false ## ## End Default Options ## title Xen 3.3 / Debian GNU/Linux, kernel 2.6.18.8 root(hd0,1) kernel /boot/xen-3.3.gz vga=text-80x50,keep module /boot/vmlinuz-2.6.18.8 root=/dev/hda2 ro vga=extended lapic video=intelfb:1024x768
Bug#254475: The bug is still there in 0.97-21
Hi Friedemann
Your changes has been applied to grub and is going to be present in the next
release. Thanks for your help on it.
--
Dorileo
On Sunday 28 January 2007 20:35, Friedemann Baitinger wrote:
sorry for the noise ... but I have to report additional findings as the
patch above really has some side-effects.
The previous version of my patch opened the /boot/grub/defaults file in
r+ mode so I could read the initial values, do a rewind(fp) and
write the new values. Unfortunately the grub-reboot script keeps to
append new comments and disclaimer lines, effectively making the file
grow and grow.
So the only thing that really works here is to open the file read-only,
read the initial values, then close it and reopen it in w mode which
truncates it to zero before we write to it. Now we write the new x:y
values and let the script to its job of adding comment lines and
disclaimers.
Also, the original code added a newline where grub-set-default didn't
have one. Not a big deal, shouldn't change the functionality but it
isn't the same layout as before anymore.
To make a long story short, here is a new patch which *should* do the
job now as expected:
--- builtins.c.orig 2007-01-28 16:46:18.0 +0100
+++ builtins.c 2007-01-28 21:25:29.0 +0100
@@ -3574,16 +3574,17 @@
default_file[i] = 0;
grub_strncat (default_file + i, default, DEFAULT_FILE_BUFLEN - i);
- if(!(fp = fopen(default_file,w)))
+ if(!(fp = fopen(default_file,r)))
{
errnum = ERR_READ;
goto fail;
}
- read(line, -1);
-
+ fgets(line, bytes, fp);
+ fclose(fp);
+
sscanf(line, %d:%d, curr_prev_default, curr_default);
-
+
if(curr_default != -1)
new_prev_default = curr_default;
else
@@ -3595,10 +3596,16 @@
}
if(once_only)
-sprintf(buf, %d:%d\n, new_prev_default, new_default);
+sprintf(buf, %d:%d, new_prev_default, new_default);
else
-sprintf(buf, %d\n, new_default);
-
+sprintf(buf, %d, new_default);
+
+ if(!(fp = fopen(default_file,w)))
+{
+ errnum = ERR_READ;
+ goto fail;
+}
+
fprintf(fp, buf);
fail:
--
Dorileo
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#412652: Etch: grub-reboot is working, but does not save the topmost menu.lst entry from being used
Hi Clemens I need to see all your menu.lst, could you attach it? Thanks -- Dorileo On Tuesday 27 February 2007 08:55, Clemens Perz wrote: Package: grub Version: 0.97-23 Entries in the list: title Debian GNU/Linux, kernel 2.6.18-3-686-bigmem root(hd0,1) kernel /boot/vmlinuz-2.6.18-3-686-bigmem root=/dev/sda2 ro initrd /boot/initrd.img-2.6.18-3-686-bigmem savedefault title Debian GNU/Linux, kernel 2.6.18-3-686-bigmem (single-user mode) root(hd0,1) kernel /boot/vmlinuz-2.6.18-3-686-bigmem root=/dev/sda2 ro single initrd /boot/initrd.img-2.6.18-3-686-bigmem savedefault title Debian GNU/Linux, kernel 2.6.18-3-686-bigmem (resq) root(hd1,0) kernel /boot/vmlinuz-2.6.18-3-686-bigmem root=/dev/sdb1 ro initrd /boot/initrd.img-2.6.18-3-686-bigmem savedefault run grub-reboot 2 and /boot/grub/default has this: 0:2 # # # # # # # # # # # WARNING: If you want to edit this file directly, do not remove any line # from this file, including this warning. Using `grub-set-default\' is # strongly recommended. Every thing looks fine, but the system will always boot entry 0 and ignore the wish for booting number 2. Cheers, Clemens ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#412334: update-grub does fail if grub is under /boot/boot/grub
Hi Jürgen
Could you try the attached patch? I think this is a better aproach and avoids
future problems.
Thanks
--
Dorileo
On Sunday 25 February 2007 14:29, jlueters wrote:
Package: grub
Version: 0.97-23
Severity: important
If grub is under /boot/boot/grub update grub fails because it does
call grub-set-default without parameter --root-directory.
grub-set-default fails because it has been provided with the wrong root
directory.
Possible fix:
line 400
replace
grub-set-default 0
with
if [ $grub_dir = /boot/boot/grub ]
then grub-set-default --root-directory=/boot 0
else grub-set-default --root-directory=/ 0
fi
Jürgen
-- System Information:
Debian Release: 4.0
APT prefers testing-proposed-updates
APT policy: (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages grub depends on:
ii libc6 2.3.6.ds1-11 GNU C Library: Shared
libraries ii libncurses5 5.5-5Shared libraries for
terminal hand
grub recommends no packages.
-- no debconf information
___
Pkg-grub-devel mailing list
[EMAIL PROTECTED]
http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel
--- grub-set-default 2007-02-13 16:50:53.0 +
+++ grub-set-default.changed 2007-02-27 15:18:07.0 +
@@ -74,18 +74,45 @@
exit 1
fi
+find_grub_dir ()
+{
+echo -n Searching for GRUB installation directory ... 2
+
+for d in $grub_dirs ; do
+if [ -d $d ] ; then
+grub_dir=$d
+break
+fi
+done
+
+if [ -z $grub_dir ] ; then
+abort No GRUB directory found.\n###
+else
+echo found: $grub_dir 2
+fi
+
+echo $grub_dir
+}
+
+grub_dirs=/boot/grub /boot/boot/grub
+
# Determine the GRUB directory. This is different among OSes.
-grubdir=${rootdir}/boot/grub
-if test -d ${grubdir}; then
+# if rootdir has been informed use it or find grubdir otherwise
+if [ -n ${rootdir} ]; then
+ grubdir=${rootdir}/boot/grub
+ if test -d ${grubdir}; then
:
-else
+ else
grubdir=${rootdir}/grub
if test -d ${grubdir}; then
- :
+:
else
- echo No GRUB directory found under ${rootdir}/ 12
- exit 1
+echo No GRUB directory found under ${rootdir}/ 12
+exit 1
fi
+ fi
+else
+ grubdir=$(find_grub_dir)
fi
file=${grubdir}/default
Bug#411109: update-grub/grub-set-default throws an error, if /grub dir does not exist
Hi Andreas
On Friday 16 February 2007 09:12, Andreas John wrote:
Package: grub
Version: sid
Severity: medium
Hi,
after dist-upgrading my sid, update-grub did not run successfully.
The reason for that was that it called indirectly 'grub-set-default',
which looked for a grub dir on / ! (not /boot or in my case /boot/boot
,as I run traditionally an own partition for /boot).
update-grub as far as I can see has actually a problem when calling
grub-set-default, it does not inform the root-directory parameter, please
take a look at bug #412334 for an example. It means that update-grub does not
try to find the root-directory and surely inform it, the script tries to find
the grub-root-directory not the root-directory so update-grub cant inform it
of course. My change is to make grub-set-default find the grub-root-directory
in another way if root-directory is not informed.
I attached a patch to the quoted bug and will attach it here again for tests,
could you apply the patch and see how it works?
Thanks
--
Dorileo
--- grub-set-default 2007-02-13 16:50:53.0 +
+++ grub-set-default.changed 2007-02-27 15:18:07.0 +
@@ -74,18 +74,45 @@
exit 1
fi
+find_grub_dir ()
+{
+echo -n Searching for GRUB installation directory ... 2
+
+for d in $grub_dirs ; do
+if [ -d $d ] ; then
+grub_dir=$d
+break
+fi
+done
+
+if [ -z $grub_dir ] ; then
+abort No GRUB directory found.\n###
+else
+echo found: $grub_dir 2
+fi
+
+echo $grub_dir
+}
+
+grub_dirs=/boot/grub /boot/boot/grub
+
# Determine the GRUB directory. This is different among OSes.
-grubdir=${rootdir}/boot/grub
-if test -d ${grubdir}; then
+# if rootdir has been informed use it or find grubdir otherwise
+if [ -n ${rootdir} ]; then
+ grubdir=${rootdir}/boot/grub
+ if test -d ${grubdir}; then
:
-else
+ else
grubdir=${rootdir}/grub
if test -d ${grubdir}; then
- :
+:
else
- echo No GRUB directory found under ${rootdir}/ 12
- exit 1
+echo No GRUB directory found under ${rootdir}/ 12
+exit 1
fi
+ fi
+else
+ grubdir=$(find_grub_dir)
fi
file=${grubdir}/default
Bug#411109: update-grub/grub-set-default throws an error, if /grub dir does not exist
Hi Otavio On Tuesday 27 February 2007 14:45, you wrote: dorileo [EMAIL PROTECTED] writes: Hi Andreas On Friday 16 February 2007 09:12, Andreas John wrote: Package: grub Version: sid Severity: medium Hi, after dist-upgrading my sid, update-grub did not run successfully. The reason for that was that it called indirectly 'grub-set-default', which looked for a grub dir on / ! (not /boot or in my case /boot/boot ,as I run traditionally an own partition for /boot). update-grub as far as I can see has actually a problem when calling grub-set-default, it does not inform the root-directory parameter, please take a look at bug #412334 for an example. It means that update-grub does not try to find the root-directory and surely inform it, the script tries to find the grub-root-directory not the root-directory so update-grub cant inform it of course. My change is to make grub-set-default find the grub-root-directory in another way if root-directory is not informed. I attached a patch to the quoted bug and will attach it here again for tests, could you apply the patch and see how it works? If the user confirm it's OK, could you apply this bug and check if there's any other trivial one to solve together and commit? Yeah, of course I can but, it`s going to wait until the end of the week, no problem for you? :D regards -- Dorileo -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#406068: grub: error 15 File not found
I`ll change update-grub to call grub-set-default 0, would it fix your problem? On Monday 08 January 2007 09:13, Thomas Stegbauer wrote: Package: grub Version: 0.97-20 Severity: important update-grub writes a save-default to each entry, while booting it is looking for the /boot/grub/default file which doesn't exist, until grub-set-default 0 is called. solution 1 (to boot the system): edit grub-config and delete the line save-default solution 2 (to make it permanent): run grub-set-default 0 when system is again running -- System Information: Debian Release: 4.0 APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.18-3-686 Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Versions of packages grub depends on: ii libc62.3.6.ds1-8 GNU C Library: Shared libraries ii libncurses5 5.5-5 Shared libraries for terminal hand grub recommends no packages. -- no debconf information ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#406068: grub: error 15 File not found
On Monday 08 January 2007 13:56, Otavio Salvador wrote: Thomas Stegbauer [EMAIL PROTECTED] writes: dorileo schrieb: I`ll change update-grub to call grub-set-default 0, would it fix your problem? yes, this would imho fix it, if it is done only the first time. Iif done when there's no default fine. Have you done it like this Leandro? no, I forgot to verify if the file exists, I`ll change it now. -- Dorileo -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#406068: grub: error 15 File not found
On Monday 08 January 2007 13:56, Otavio Salvador wrote: Thomas Stegbauer [EMAIL PROTECTED] writes: dorileo schrieb: I`ll change update-grub to call grub-set-default 0, would it fix your problem? yes, this would imho fix it, if it is done only the first time. Iif done when there's no default fine. Have you done it like this Leandro? done -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#403763: Error 23 on savedefault when using grub-reboot command
Hi Len Sorensen
Like you said things works a bit different in grub. grub-reboot is working
just fine in my systems I will try your patch and see if things keep working
here.
On Tuesday 19 December 2006 12:06, Len Sorensen wrote:
Package: grub
Version: 0.97-20
Severity: normal
Tags: patch
I am running with the current grub package compiled on a sarge system.
When I try to use the grub-reboot command to change the boot entry to
use on next boot as a one time choice, the /boot/grub/default is updated
to show 0:2 as expected. menu.lst has 'default saved'. When booting,
it correctly goes to entry 2, but when it hits savedefault (which should
restore the default file back to just '0', it gets an error 23 trying to
parse the value. I eventually with a lot of debuging determined that
the 'char *def' in the savedefault_helper is somehow now making it
through when passed to safe_parse_maxint(def, entryno); The following
patch fixes it for me however:
# This fixes some warnings about missing return on a function
@@ -3660,9 +3663,9 @@
{
#if !defined(SUPPORT_DISKLESS)
#if !defined(GRUB_UTIL)
- savedefault_helper(arg, flags);
+ return savedefault_helper(arg, flags);
#else
- savedefault_shell(arg, flags);
+ return savedefault_shell(arg, flags);
#endif
#else /* !SUPPORT_DISKLESS */
errnum = ERR_UNRECOGNIZED;
correct, however it`s not making any problem in stage2 it`ll not return
anything.
--
Dorileo
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#378243: grub-reboot does not work
Hi Chris Could you show me your menu.lst? thanks -- Dorileo On Monday 11 December 2006 12:14, Chris Purves wrote: Package: grub Version: 0.97-19 Followup-For: Bug #378243 I am having the same problem. savedefault --once appears to have no effect. When grub reboots it uses the default listed in menu.lst. -- System Information: Debian Release: 4.0 APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.18-3-686 Locale: LANG=en_CA, LC_CTYPE=en_CA (charmap=ISO-8859-1) Versions of packages grub depends on: ii libc62.3.6.ds1-8 GNU C Library: Shared libraries ii libncurses5 5.5-5 Shared libraries for terminal hand grub recommends no packages. -- no debconf information ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#378243: grub-reboot does not work
Could you also do the following? 1- answear no to the question: Do you want to reboot now? [y/N]; 2- take the /boot/grub/default file and send me by mail; 3- reboot your system; 4- send me the file /boot/grub/default again; thanks -- Dorileo On Monday 11 December 2006 12:14, Chris Purves wrote: Package: grub Version: 0.97-19 Followup-For: Bug #378243 I am having the same problem. savedefault --once appears to have no effect. When grub reboots it uses the default listed in menu.lst. -- System Information: Debian Release: 4.0 APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.18-3-686 Locale: LANG=en_CA, LC_CTYPE=en_CA (charmap=ISO-8859-1) Versions of packages grub depends on: ii libc62.3.6.ds1-8 GNU C Library: Shared libraries ii libncurses5 5.5-5 Shared libraries for terminal hand grub recommends no packages. -- no debconf information ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#367889: GRUB - grub-reboot corrupts mbr
Could you checkout the pkg-grub trunk in the svn repository, build it and give a try? On Thursday 18 May 2006 12:01, Marco Crociani - Tyrael wrote: Package: grub Version: 0.97-7.1 Debian Sid AMD64, if I run grub-install and then reboot it can't boot anything. Grub menu is displayed and I can select the varius options but when I continue (pressing Enter or waiting the timeout) it gives a disk read error press a key to continue and the after pressing the key it return to grub menu. To restore the system I run a live cd and then grub-install. Bye, -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#345931: A patch solving #345931
Hi Robert
On Monday 25 September 2006 10:17, Robert Millan wrote:
On Mon, Sep 11, 2006 at 06:26:37PM +0200, Mats Erik Andersson wrote:
Venerable Maintainers of Grub,
I offer you a patch that should close bug report
#345931.
The patch has been built on top of grub-0.97-13 with
success and it repaired with honours mbr-installs of
grub-0.97-1ubuntu1 on kubuntu 6.0.6
and
grub-0.95+cvs20040624-17sarge1 on Debian
Sarge.
Does your patch work with grub from debian sid?
Does GRUB 2 also exhibit this problem?
I don`t think so, I`m trying this patch and I think It`s a totally grub legacy
related problem. I just have few considerations on the proposed patch.
As you will see the coding is independent of any
Debian patches and contains a few lines of code for
the source file
grub-0.97/stage2/builtins.c
and thus would easily integrate in the upstream
version 0.97. I leave to you to decide whether the
author ought to be informed, since I am still a
novice in these matters.
Best regards
Mats Erik Andersson
[EMAIL PROTECTED]
Content-Description: 526972506-drive_correction.diff
diff -Naur grub-0.97.orig/stage2/builtins.c grub-0.97/stage2/builtins.c
--- grub-0.97.orig/stage2/builtins.c2006-09-11 16:08:32.261227280
+0200
+++ grub-0.97/stage2/builtins.c 2006-09-11 16:15:54.035067448 +0200
@@ -1953,13 +1953,30 @@
*((unsigned char *) (stage1_buffer + STAGE1_FORCE_LBA)) =
is_force_lba;
/* If DEST_DRIVE is a hard disk, enable the workaround, which is
- for buggy BIOSes which don't pass boot drive correctly. Instead,
- they pass 0x00 or 0x01 even when booted from 0x80. */
+ * for buggy BIOSes which don't pass boot drive correctly. Instead,
+ * they pass 0x00 or 0x01 even when booted from 0x80. */
if (dest_drive BIOS_FLAG_FIXED_DISK)
-/* Replace the jmp (2 bytes) with double nop's. */
-*((unsigned short *) (stage1_buffer + STAGE1_BOOT_DRIVE_CHECK))
- = 0x9090;
-
+ {
+if ( *((unsigned char *) (stage1_buffer + STAGE1_BOOT_DRIVE_CHECK))
== 0xeb ) +/* For version 0.97:
+* Replace the jmp (2 bytes) with double nop's. */
+ *((unsigned short *) (stage1_buffer + STAGE1_BOOT_DRIVE_CHECK))
+ = 0x9090;
What have changed here?
+else if ( *((unsigned char *) (stage1_buffer +
STAGE1_BOOT_DRIVE_CHECK)) == 0x80 ) + {
+/* For versions 0.94-96:
+* Set the boot drive mask. This is a workaround for buggy BIOSes
which +* don't pass boot drive correctly. Instead, they pass
0x00 even when +* booted from 0x80.
+* Rem: the old STAGE1_BOOT_DRIVE_MASK equals
STAGE1_BOOT_DRIVE_CHECK + 2 */ + *((unsigned char *)
(stage1_buffer + STAGE1_BOOT_DRIVE_CHECK + 2 )) + =
(dest_drive BIOS_FLAG_FIXED_DISK);
+ }
+else
+ /* The boot sector is older than version 0.94.
+ * Changing to a nop could make 0.92 and 0.93 acceptable. */
+ goto fail;
What about we set here the errnum with ERR_BAD_VERSION? or perhaps define a
new error with a new message - something like: you should run grub-install or
you will be unbootable - for this situation?
+ }
/* Read the first sector of Stage 2. */
disk_read_hook = disk_read_savesect_func;
if (grub_read (stage2_first_buffer, SECTOR_SIZE) != SECTOR_SIZE)
I`ll try this patch a bit more in the end of the week.
--
Dorileo
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#345931: If the problem is that the user doesn't know he won't be able to reboot...
Hi Jason On Wednesday 13 September 2006 18:26, Jason Thomas wrote: option C, we create a way to extract the version information from every grub file. So that the grub shell can check that its version matches the stage files and if not generate an ERROR message. I tryied to understand how to do this ~2 months ago but didnt have time to go deep on it. How do you think it should be done? I saw a patch[1] sent by Mats Erik Andersson and it seems to be ok(needs just little changes), I`m going to try it better. [1] http://lists.alioth.debian.org/pipermail/pkg-grub-devel/2006-September/001998.html -- Dorileo On Wed, Sep 13, 2006 at 11:05:38AM +0200, Marc Fargas wrote: Steve Langasek [EMAIL PROTECTED] writes: Surely this is still a bug in the grub shell for failing to notice that it had rendered the system unbootable? Grub shell is supposed to be used by experienced users, and if the big problem is that setup() doesn't copy those files to /boot/ there are two lines of action: a) On a call to setup() output a nice warning message that clearly says that the files MUST be manually copied by the user encouragin the use of grub-install b) On a call to setup() take care of copying the files. I'd vote for option a, with that warning in place the bug would be ok, right? I've never touched inside grub but I can try to patch it if you select A, and less maybe for B ;) [so, is option A ok for closing the bug? at least the user knows that he/she won't boot again... hehe] Cheers, Marc. -- The probability of failure of a (computer) system is exponentially proportional to the physical distance between it and the one who could fix it. -- Martin F. Krafft -- The probability of failure of a (computer) system is exponentially proportional to the physical distance between it and the one who could fix it. -- Martin F. Krafft ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#369868: Error 25 when using savedefault
Hi Martin Grub reads menu.lst to know a sort of informations for example to know if the selected boot entry is wanted to be saved as default(savedefault) :D, could you please send me your menu.lst? thanks -- Dorileo On Thursday 01 June 2006 14:31, martin f krafft wrote: Package: grub Version: 0.97-7.1 Severity: normal I've been doing funky stuff with my disks (RAID and all). Now, all of a sudden it fails to boot with error 25 Disk read error. The strange thing is that if I remove savedefault from the commands, it works just fine. I thought savedefault writes, not reads... Any ideas? I can reproduce at will. Which sucks. :) -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.16-2-amd64-k8 Locale: LANG=en_GB, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#367889: GRUB - grub-reboot corrupts mbr
Hi Marco I'm sure that your problem has nothing to do with mbr surely your mbr wasn't corrupted. Can you tell me what parameters you've used and where you have /grub installed? thanks -- Dorileo On Thursday 18 May 2006 09:01, Marco Crociani - Tyrael wrote: Package: grub Version: 0.97-7.1 Debian Sid AMD64, if I run grub-install and then reboot it can't boot anything. Grub menu is displayed and I can select the varius options but when I continue (pressing Enter or waiting the timeout) it gives a disk read error press a key to continue and the after pressing the key it return to grub menu. To restore the system I run a live cd and then grub-install. Bye, -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#120125: grub: update-grub could have an option to lock older kernels
Hi Gürkan What do you mean by lock older kernels? -- Dorileo On Thursday 01 June 2006 05:06, Gürkan Sengün wrote: /me dips grub into holy water and reads a blessed scroll of enchant armor please do it! ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel
Bug#344840: says No error reported. on Segmentation fault
Hi Ryan Could you try the latest version and tell me what happens? -- Dorileo
Bug#360041: savedefault makes grub segfault when /boot is in a separate partition
Hi Kiko Could you try the following and tell me what happens? /sbin/grub --config-file=/path_to_your_config_file grub savedefault --once --default=the_wanted_entry thanks On 3/30/06, Kiko Piris [EMAIL PROTECTED] wrote: Package: grub Version: 0.97-6 Severity: normal Hi, I have /boot in a separate partition, I wanted to use grub-reboot and the call to grub always segfaults with the savedefault command. I've strace'd it and found the following: open(/boot/grub/default, O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 ENOENT (No such file or directory) --- SIGSEGV (Segmentation fault) @ 0 (0) --- +++ killed by SIGSEGV +++ I thought it would accept --root-directory=/boot argument like grub-install does, but grub seems not to accept it. Thanks -- Kiko -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.16.1 Locale: LANG=es_ES.ISO-8859-15, LC_CTYPE=es_ES.ISO-8859-15 (charmap=ISO-8859-15) (ignored: LC_ALL set to [EMAIL PROTECTED]) Versions of packages grub depends on: ii libc6 2.3.6-4GNU C Library: Shared libraries an ii libncurses5 5.5-1 Shared libraries for terminal hand grub recommends no packages. -- no debconf information ___ Pkg-grub-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel -- Dorileo
