Bug#1033394: Bind v9.18.12+ unmarshall xml error

2024-07-29 Thread Nicolas Peugnet
On Fri, 24 Mar 2023 08:16:12 +0100 (CET) Benjamin Schönbach 
 wrote:

subject: prometheus-bind-exporter: Bind v9.18.12+ unmarshall xml error
Package: prometheus-bind-exporter
Version: 0.4.0+ds-1+b5
Severity: important

Dear Maintainer,

As a devops guy working on prometheus community stuff I would ask you to
upgrade the official debian 11 package for *prometheus-bind-exporter
(v0.4.0) *to latest stable release *v0.6.1*. It fixes a major bug that
blocks users working with bind v9.18.12+

What led up to the situation?
Upgrade to any bind version 9.18.12+ crashes every bind-exporter release below 
version 0.6.1.
The problem is an unmarshall value of negative xml files.

What exactly did you do (or not do) that was effective?
Upgrade to bind version v9.18.12+

What was the outcome of this action?
Unmarshall error of bind statistics channel output -> hence no valid metrics

What outcome did you expect instead?
Correct pars of bind xml output and output of metrics

For further information on fix, please check the project source of 
prometheus-exporter
https://github.com/prometheus-community/bind_exporter/releases/tag/v0.6.1


I am also affected by this bug on Debian bullseye (current old stable) 
since bind9 has been updated to 1:9.16.50-1~deb11u1 from bullseye-security.


Here is the error message a get:

juil. 29 23:11:24 club1.fr prometheus-bind-exporter[591]: 
level=error ts=2024-07-29T21:11:24.570Z caller=bind_exporter.go:427 
msg="Couldn't retrieve BIND stats" err="failed to unmarshal XML 
response: strconv.ParseUint: parsing \"-1\": invalid syntax"


--
Nicolas Peugnet



Bug#1077533: ITP: golang-github-tomasen-fcgi-client -- go fastcgi client with fcgi params support

2024-07-29 Thread Nicolas Peugnet
Package: wnpp
Severity: wishlist
Owner: Nicolas Peugnet 

* Package name: golang-github-tomasen-fcgi-client
  Version : 0.0~git20180423.2bb3d81-1
  Upstream Author : Shen Sheng
* URL : https://github.com/tomasen/fcgi_client
* License : BSD-3-clause
  Programming Lang: Go
  Description : go fastcgi client  with fcgi params support

 Go fastcgi client with fcgi params support

This is a dependency of prometheus-phpfpm-exporter (#1077531) that I
intend to package.
It is currently pushed on my own repo as I don't have yet access to the
Go Packaging Team group:
<https://salsa.debian.org/n-peugnet/golang-github-tomasen-fcgi-client>



Bug#1077531: ITP: prometheus-phpfpm-exporter -- Prometheus exporter for PHP-FPM.

2024-07-29 Thread Nicolas Peugnet
Package: wnpp
Severity: wishlist
Owner: Nicolas Peugnet 

* Package name: prometheus-phpfpm-exporter
  Version : 0.6.0-1
  Upstream Author : Pedro Gomes
* URL : https://github.com/Lusitaniae/phpfpm_exporter
* License : Apache-2.0
  Programming Lang: Go
  Description : Prometheus exporter for PHP-FPM.

 Prometheus Exporter for the PHP-FPM status page.
 .
 Metrics are scrapped via unix socket and made available on port 9253.
 .
 This exporter also provides a way for embedding the output of arbitrary
 PHP scripts into its metrics page, analogous to the node exporter's
 textfile collector. Scripts that are specified with the --phpfpm.script-
 collector-paths flag will be run through PHP-FPM. Any metrics printed by
 the PHP script will be merged into the metrics provided by this
 exported. An example use case includes printing metrics for PHP's
 opcache.

I like this exporter because it is able to monitor multiple PHP-FPM pools
at once by simply using the "--phpfpm.socket-directories" option.

I currently pushed this package on my own repo on Salsa as I don't have
access to the Go Packaging Team group yet:
<https://salsa.debian.org/n-peugnet/prometheus-phpfpm-exporter>

This is the first package that I create for Debian. If I understood
correctly, I will need to find a sponsor to be able to upload it.



Bug#1077519: xfce4-panel: Broken multiple application selection in taskbar

2024-07-29 Thread Nicolas Patrois
Package: xfce4-panel
Version: 4.18.6-1
Severity: normal
Tags: upstream

Dear Maintainer,

When two or more windows are stacked in the taskbar, I can’t select a window
with it.
The button continuously blink without selecting any window.
Only choosing the window that made blink the button (with the mouse or with
alt-tab) stops it blinking.

Yours,
nicolas


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages xfce4-panel depends on:
ii  exo-utils4.18.0-1+b2
ii  libatk1.0-0t64   2.52.0-1
ii  libc62.39-6
ii  libcairo21.18.0-3+b1
ii  libdbusmenu-gtk3-4   18.10.20180917~bzr492+repack1-3.1+b1
ii  libexo-2-0   4.18.0-1+b2
ii  libgarcon-1-04.18.1-1+b2
ii  libgarcon-gtk3-1-0   4.18.1-1+b2
ii  libgdk-pixbuf-2.0-0  2.42.12+dfsg-1
ii  libglib2.0-0t64  2.80.4-1
ii  libgtk-3-0t643.24.43-1
ii  libpango-1.0-0   1.54.0+ds-1
ii  libpangocairo-1.0-0  1.54.0+ds-1
ii  libwnck-3-0  43.0-3+b1
ii  libx11-6 2:1.8.7-1+b1
ii  libxext6 2:1.3.4-1+b1
ii  libxfce4panel-2.0-4  4.18.6-1
ii  libxfce4ui-2-0   4.18.6-1
ii  libxfce4util74.18.2-1
ii  libxfconf-0-34.18.3-2

xfce4-panel recommends no packages.

xfce4-panel suggests no packages.

-- no debconf information


Bug#1077005: CFLAGS+=foo etc stopped working

2024-07-26 Thread Nicolas Boulenguez
Michael has already replaced CFLAGS+=foo with DEB_CFLAGS_MAINT_APPEND:=foo
https://salsa.debian.org/samba-team/samba/-/commit/505e4ff2084280b09eb1ecea277de056ff62684a

Ironically, the debian/rules for samba contains the exact same
optimization we are talking about:
  # Fast version of dpkg/architecture.mk defining all vars in one go
  ifeq (${DEB_HOST_MULTIARCH},)
$(foreach d, $(shell dpkg-architecture | sed 's/=/?=/'), $(eval export $d))
  endif



Bug#1077005: CFLAGS+=foo etc stopped working

2024-07-26 Thread Nicolas Boulenguez
Hello.

> Hmm, at this point I'm starting to ponder whether to revert the
> optimization commit for the Makefile fragment files, because this
> is starting to feel like too much breakage, and then the fragment
> code is becoming too hard to debug, or even test.

This sentence seems a bit unfair.  The new implementation has come
with new regression tests, and does not increase the source
complexity.

> I've not yet looked into it, Nicolas if you can have a look please,
> otherwise I might do the revert and another upload later today or so.

I will investigate, but without much hope.  The difference is probably
caused by things like conflicting CFLAGS on the command line or in the
environment, from debian/rules or dpkg-buildpackage, for ./configure
or make, possibly kept by ./configure for make despite a now
conflicting environment…  This mess is probably one of the reasons why
DEB_CFLAGS_MAINT_APPEND was introduced and CFLAGS+= deprecated in both
the environment and debian/rules.
Moreover, I cannot connect to buildds either.

The fact that the previous lazy evaluation mechanism, in which the
$(evals VAR=$(VAR)) trick is already present, did what you expect in
some contexts does not make CFLAGS+= a supported interface, and your
code could break in other contexts.

Replacing
  CFLAGS+= foo
with
  DEB_CFLAGS_MAINT_APPEND := foo
in the broken packages seems more fruitful to me, and I would prefer
to help with that.

That would most probably fix this bug, does not hurt if the
optimization is reverted, and will actively help if dpkg-buildpackage
ever becomes the main entry point for package builds.



Bug#1077059: gettext: xgettext complains about missing charset header when using the exclude option

2024-07-25 Thread Nicolas Peugnet
Package: gettext
Version: 0.22.5-1
Severity: normal

Dear Maintainer,

After upgrading gettext to the latest version from testing (0.22.5-1) I
I can not use xgettext to extract messages from a .pot files in
conjuction with the exclude option. xgettext complains about a missing
header entry with charset specification, but is is there, and it worked
with the previous version from Debian stable (0.21-12).

Here is a demonstration of the problem:

   $ ls
   exclude.po  messages.po
   $ head -n30 *
   ==> exclude.po <==
   msgid ""
   msgstr ""
   "MIME-Version: 1.0\n"
   "Content-Type: text/plain; charset=UTF-8\n"
   "Content-Transfer-Encoding: 8bit\n"

   msgid "API"
   msgstr ""

   msgid "Atom"
   msgstr ""

   msgid "BibTeX"
   msgstr ""

   msgid "CLI"
   msgstr ""

   msgid "CalDAV"
   msgstr ""

   msgid "CardDAV"
   msgstr ""


   ==> messages.pot <==
   # SOME DESCRIPTIVE TITLE.
   # Copyright (C) 2022-2024, Membres de CLUB1
   # This file is distributed under the same license as the CLUB1 package.
   # FIRST AUTHOR , YEAR.
   #
   #, fuzzy
   msgid ""
   msgstr ""
   "Project-Id-Version: CLUB1 main\n"
   "Report-Msgid-Bugs-To: \n"
   "POT-Creation-Date: 2024-07-25 18:30+0200\n"
   "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
   "Last-Translator: FULL NAME \n"
   "Language-Team: LANGUAGE \n"
   "MIME-Version: 1.0\n"
   "Content-Type: text/plain; charset=UTF-8\n"
   "Content-Transfer-Encoding: 8bit\n"

   #: ../../_templates/404.html:2
   #: ../../_templates/404.html:5
   msgid "404 Non trouvé"
   msgstr ""

   #: ../../_templates/404.html:6
   msgid "La page demandée n'existe pas ou plus, elle a peut-être été renommée."
   msgstr ""

   #: ../../_templates/breadcrumbs.html:9
   msgid "Traduire sur Weblate"
   msgstr ""
   $ xgettext -x exclude.po messages.pot 
   Warning: program compiled against libxml 212 using older 209
   xgettext: messages.pot: input file doesn't contain a header entry with a 
charset specification

I tried to compile the upstream project from source in order to bisect
the issue, but I had to much problems compiling the example, which I
didn't even need.
It should probably be forwarded upstream.

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (600, 'testing'), (500, 'stable-security'), (500, 'stable'), 
(200, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.9.9-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gettext depends on:
ii  gettext-base   0.22.5-1
ii  libc6  2.39-4
ii  libgomp1   14-20240330-1
ii  libunistring5  1.2-1
ii  libxml22.9.14+dfsg-1.3+b3

Versions of packages gettext recommends:
ii  curl  8.8.0-4
ii  lynx  2.9.2-1
ii  wget  1.24.5-1

Versions of packages gettext suggests:
ii  autopoint 0.22.5-1
pn  gettext-doc   
pn  libasprintf-dev   
pn  libgettextpo-dev  

-- no debconf information


Bug#1068076: Time to upload?

2024-07-25 Thread Nicolas Mora

Hello Mattias,

My bad, I'm also working on migrating gdbm to 1.24 and I forgot about 
#1068076.


It's uploaded to unstable with the patch now.



Bug#1076863: dpkg-deb: Weird errors from dpkg-deb while building some packages

2024-07-25 Thread Nicolas Boulenguez
Hello.

> DEB_VERSION_UPSTREAM_REVISION not DEB_UPSTREAM_REVISION

Good catch!

> But it doesn't really matter anymore, once this part is removed.

The removed part implements lazy evaluation and does matter for
performances.  Thanks to your diagnostic, we may now restore it.
>From d713c8b47b16cee20e6bfe66aa5ba5b43d8129d6 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Thu, 25 Jul 2024 10:48:30 +0200
Subject: [PATCH 1/2] Revert "scripts/mk: Fix pkg-info.mk evaluation by adding
 new DEB_TIMESTAMP variable"

This reverts commit c05f82972018d182fa296ef38384a1adddf5b6eb.
---
 scripts/mk/pkg-info.mk   | 21 +
 scripts/t/mk/pkg-info.mk |  2 --
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/scripts/mk/pkg-info.mk b/scripts/mk/pkg-info.mk
index 37bf42299..ddda4f736 100644
--- a/scripts/mk/pkg-info.mk
+++ b/scripts/mk/pkg-info.mk
@@ -8,9 +8,6 @@
 #   DEB_VERSION_UPSTREAM: package's upstream version.
 #   DEB_DISTRIBUTION: distribution(s) listed in the current debian/changelog
 # entry.
-#   DEB_TIMESTAMP: source package release date as seconds since the epoch as
-# specified in the latest debian/changelog entry (since dpkg 1.22.9),
-# although you are probably looking for SOURCE_DATE_EPOCH instead.
 #
 #   SOURCE_DATE_EPOCH: source release date as seconds since the epoch, as
 # specified by <https://reproducible-builds.org/specs/source-date-epoch/>
@@ -29,12 +26,20 @@ dpkg_parsechangelog_run = $(eval $(shell dpkg-parsechangelog | sed -n '\
 $$(eval DEB_VERSION_EPOCH_UPSTREAM:=\1\2\4)\
 $$(eval DEB_VERSION_UPSTREAM_REVISION:=\2\3)\
 $$(eval DEB_VERSION_UPSTREAM:=\2\4)/p;\
-  s/^Timestamp: \(.*\)/$$(eval DEB_TIMESTAMP:=\1)/p'))
+  s/^Timestamp: \(.*\)/$$(eval SOURCE_DATE_EPOCH?=\1)/p'))
 
-# Compute all the values in one go.
-$(dpkg_parsechangelog_run)
-
-SOURCE_DATE_EPOCH ?= $(DEB_TIMESTAMP)
+ifdef SOURCE_DATE_EPOCH
+  dpkg_lazy_eval ?= $(eval $(1) = $(2)$$($(1)))
+  $(call dpkg_lazy_eval,DEB_DISTRIBUTION,$$(dpkg_parsechangelog_run))
+  $(call dpkg_lazy_eval,DEB_SOURCE,$$(dpkg_parsechangelog_run))
+  $(call dpkg_lazy_eval,DEB_VERSION,$$(dpkg_parsechangelog_run))
+  $(call dpkg_lazy_eval,DEB_VERSION_EPOCH_UPSTREAM,$$(dpkg_parsechangelog_run))
+  $(call dpkg_lazy_eval,DEB_VERSION_UPSTREAM,$$(dpkg_parsechangelog_run))
+  $(call dpkg_lazy_eval,DEB_UPSTREAM_REVISION,$$(dpkg_parsechangelog_run))
+else
+  # We need to compute the values right now.
+  $(dpkg_parsechangelog_run)
+endif
 export SOURCE_DATE_EPOCH
 
 endif # dpkg_pkg_info_mk_included
diff --git a/scripts/t/mk/pkg-info.mk b/scripts/t/mk/pkg-info.mk
index 6863ebb80..6eb37866d 100644
--- a/scripts/t/mk/pkg-info.mk
+++ b/scripts/t/mk/pkg-info.mk
@@ -6,7 +6,6 @@ TEST_DEB_VERSION_EPOCH_UPSTREAM = 1:2:3.4-5
 TEST_DEB_VERSION_UPSTREAM_REVISION = 2:3.4-5-6
 TEST_DEB_VERSION_UPSTREAM = 2:3.4-5
 TEST_DEB_DISTRIBUTION = suite
-TEST_DEB_TIMESTAMP = 1438697630
 
 test_vars := \
   DEB_SOURCE \
@@ -15,7 +14,6 @@ test_vars := \
   DEB_VERSION_UPSTREAM_REVISION \
   DEB_VERSION_UPSTREAM \
   DEB_DISTRIBUTION \
-  DEB_TIMESTAMP \
   SOURCE_DATE_EPOCH \
   # EOL
 
-- 
2.39.2

>From 6a334f57b6dd21a522258941fdd90d20c4d7197d Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Thu, 25 Jul 2024 10:50:43 +0200
Subject: [PATCH 2/2] scripts/mk: fix #1076863 DEB_VERSION_UPSTREAM_REVISION
 but keep lazy expansion

In e146a68a, the variables (list A) are assigned with a lazy expansion
wrapper, so that first expansion triggers dpkg-parsechangelog and
actually assigns the variables (list B) with their final values.

A mispelling of DEB_VERSION_UPSTREAM_REVISION in (A) causes #1076863
and its clones (thanks to Michael Tokarev ).

The issue was not detected by tests and hard to understand because (B)
was correct, hiding the bug after any other expansion.  For example,
variables expansions within recipes were less likely to be affected
because they happen long after plain assignments.

Testing this for regression would require a separate test for each
variable and does not seem worth the while.

Commit c05f8297 fixes the bug but runs dpkg-parsechangelog each time a
debian/rules including pkg-info.mk is parsed.

This fix preserves lazy expansion.
---
 scripts/mk/pkg-info.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/mk/pkg-info.mk b/scripts/mk/pkg-info.mk
index ddda4f736..a51dd88e4 100644
--- a/scripts/mk/pkg-info.mk
+++ b/scripts/mk/pkg-info.mk
@@ -35,7 +35,7 @@ ifdef SOURCE_DATE_EPOCH
   $(call dpkg_lazy_eval,DEB_VERSION,$$(dpkg_parsechangelog_run))
   $(call dpkg_lazy_eval,DEB_VERSION_EPOCH_UPSTREAM,$$(dpkg_parsechangelog_run))
   $(call dpkg_lazy_eval,DEB_VERSION_UPSTREAM,$$(dpkg_parsechangelog_run))
-  $(call dpkg_lazy_eval,DEB_UPSTREAM_REVISION,$$(dpkg_parsechangelog_run))
+  $(call dpkg_lazy_eval,DEB_VERSION_UPSTREAM_REVISION,$$(dpkg_parsechangelog_run))
 else
   # We need to compute the values right now.
   $(dpkg_parsechangelog_run)
-- 
2.39.2



Bug#1076718: (no subject)

2024-07-22 Thread Nicolas Schier
Package: makepkg
Version: 6.0.2-6+b1
Severity: important

Dear Ben,

if PACMAC environment variable is not set, 'makepkg' depends on 'pacman'
being available in PATH, but it does neither depend nor recommend
installation of 'pacman-package-manager'.  Installing 'makepkg' w/o
'pacman-package-manager' in a clean Debian system results in:

$ makepkg

==> ERROR: An unknown error has occurred. Exiting...
User defined signal 1
[exit code 138]

After installing pacman-package-manager, it renders a more useful error
message:

$ makepkg
==> ERROR: PKGBUILD does not exist.
[exit code 12]

Could you please consider adding a dependency or at least a recommendation for
'pacman-package-manager' to 'makepkg'?

(If 'makepkg' would catch a missing $PACMAN binary and show a proper
error message would also be a nice extension.)

Kind regards,
Nicolas


Link:   
https://lore.kernel.org/linux-kbuild/CAK7LNARj9fxm_3h=7g4plbldhxnuqrru8ioq4szdx8ag3ys...@mail.gmail.com/
 up to: 
https://lore.kernel.org/linux-kbuild/5db8b1e9-894b-4626-b635-420078df1...@t-8ch.de/


-- System Information:
Debian Release: trixie/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 
'oldstable-updates'), (500, 'oldstable-security'), (500, 'unstable'), (500, 
'testing'), (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.10.0+nsc (SMP w/24 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
C.UTF-8), LANGUAGE=C
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages makepkg depends on:
ii  debugedit 1:5.0-6
ii  fakeroot  1.35.1-1
ii  libalpm13t64  13.0.2-6+b1
ii  libc6 2.39-4
ii  patch 2.7.6-7
ii  perl  5.38.2-5
ii  pkgconf   1.8.1-3
ii  texinfo   7.1-3

Versions of packages makepkg recommends:
ii  build-essential  12.10

makepkg suggests no packages.

-- no debconf information



Bug#1076568: dpkg: no longer evaluates variables in DEB_CPPFLAGS_MAINT_APPEND

2024-07-19 Thread Nicolas Boulenguez
Hello.

Previous implementation was preventing one expansion with $(value),
but this quotation is now counter-productive.

Three commits are attached:
 2/ regression test
 3/ patch
 1/ an unrelated suggestion inspired by this bug
>From 67c012557c29edf884a6535d8b3120d36d6ebd85 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 19 Jul 2024 13:20:06 +0200
Subject: [PATCH 1/3] scripts/mk: ensure dpkg_datadir is computed once

dpkg_datadir ?= $(dir $(lastword $(MAKEFILE_LIST)))
is equivalent to
ifndef dpkg_datadir
  dpkg_datadir = $(..)
endif
$(..) is computed each time dpkg_datadir is expanded, so the result
will be wrong if MAKEFILE_LIST has grown meanwhile.

Assign with := so that the value is computed and never expanded again.
---
 scripts/mk/buildtools.mk | 4 +++-
 scripts/mk/vendor.mk | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/scripts/mk/buildtools.mk b/scripts/mk/buildtools.mk
index 1f63beede..def15c103 100644
--- a/scripts/mk/buildtools.mk
+++ b/scripts/mk/buildtools.mk
@@ -28,7 +28,9 @@
 ifndef dpkg_buildtools_mk_included
 dpkg_buildtools_mk_included = yes
 
-dpkg_datadir ?= $(dir $(lastword $(MAKEFILE_LIST)))
+ifndef dpkg_datadir
+  dpkg_datadir := $(dir $(lastword $(MAKEFILE_LIST)))
+endif
 include $(dpkg_datadir)/architecture.mk
 
 # We set the TOOL_FOR_BUILD variables to the specified value, and the TOOL
diff --git a/scripts/mk/vendor.mk b/scripts/mk/vendor.mk
index 43898d956..d257eddcb 100644
--- a/scripts/mk/vendor.mk
+++ b/scripts/mk/vendor.mk
@@ -36,7 +36,9 @@
 ifndef dpkg_vendor_mk_included
 dpkg_vendor_mk_included = yes
 
-dpkg_datadir ?= $(dir $(lastword $(MAKEFILE_LIST)))
+ifndef dpkg_datadir
+  dpkg_datadir := $(dir $(lastword $(MAKEFILE_LIST)))
+endif
 include $(dpkg_datadir)/buildapi.mk
 
 dpkg_lazy_eval ?= $(eval $(1) = $(2)$$($(1)))
-- 
2.39.2

>From 5360de48a1534b0d72229f5476fd4b2f65a237bc Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 19 Jul 2024 14:24:22 +0200
Subject: [PATCH 2/3] scripts/mk: test expansions passed to dpkg-buildflags

Regression test for #1076568.
---
 scripts/t/mk/buildflags.mk | 4 
 1 file changed, 4 insertions(+)

diff --git a/scripts/t/mk/buildflags.mk b/scripts/t/mk/buildflags.mk
index 74ccac04b..bc7e6a849 100644
--- a/scripts/t/mk/buildflags.mk
+++ b/scripts/t/mk/buildflags.mk
@@ -10,6 +10,10 @@ TEST_CXXFLAGS  := set-host
 DEB_CXXFLAGS_FOR_BUILD_MAINT_SET := set-build
 TEST_CXXFLAGS_FOR_BUILD  := set-build
 
+DEB_CFLAGS_MAINT_APPEND = -DTEST_MAKE_EXPANSION=$(expanded_on_demand)
+expanded_on_demand := contents
+TEST_CFLAGS += -DTEST_MAKE_EXPANSION=contents
+
 DPKG_EXPORT_BUILDFLAGS := 1
 
 include $(srcdir)/mk/buildflags.mk
-- 
2.39.2

>From 9ef54cf63a24e489802dcf8a814618b633c8308a Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 19 Jul 2024 14:08:10 +0200
Subject: [PATCH 3/3] scripts/mk: fix expansions passed to dpkg-buildflags.
 Closes: #1076568

---
 scripts/mk/buildflags.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/mk/buildflags.mk b/scripts/mk/buildflags.mk
index a8eac9e54..bc0448881 100644
--- a/scripts/mk/buildflags.mk
+++ b/scripts/mk/buildflags.mk
@@ -57,7 +57,7 @@ dpkg_buildflags_run = $(eval $(shell \
   $(foreach operation,SET STRIP APPEND PREPEND,\
 DEB_$(flag)_MAINT_$(operation))),\
 $(if $(value $(exported)),\
-  $(exported)="$(value $(exported))"))\
+  $(exported)="$($(exported))"))\
   dpkg-buildflags | sed 's/\([^=]*\)\(.*\)/$$(eval \1:\2)/'))
 
 ifdef DPKG_EXPORT_BUILDFLAGS
-- 
2.39.2



Bug#1076252: gcc-or1k-elf: Unused build-dependency on GNU autogen

2024-07-19 Thread Nicolas Boulenguez
Hello.
A commit removing the dependency will be part of next upload.
Thanks for spotting this.



Bug#1076019: font-manager: Upgrade error

2024-07-09 Thread Nicolas Patrois
Package: font-manager
Version: 0.9.0-1
Severity: minor

Dear Maintainer,

At the end of the upgrade, I see these lines (in French but I think that they
are quite readable as is in English):

Paramétrage de font-manager (0.9.0-1) ...
Erreur de l'analyseur AppArmor pour /etc/apparmor.d/font-manager in profile
/etc/apparmor.d/font-manager ? la ligne
 4 : Could not open 'abi/4.0': Aucun fichier ou dossier de ce type

Yours,
nicolas


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages font-manager depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.40.0-4+b2
ii  font-manager-common  0.9.0-1
ii  font-viewer  0.9.0-1
ii  gconf-gsettings-backend [gsettings-backend]  3.2.6-8
ii  libadwaita-1-0   1.5.2-1
ii  libc62.38-14
ii  libglib2.0-0t64  2.80.4-1
ii  libgtk-4-1   4.12.5+ds-6+b1
ii  libjson-glib-1.0-0   1.8.0-2+b1
ii  libpango-1.0-0   1.54.0+ds-1
ii  libsoup-3.0-03.4.4-5+b1
ii  libsqlite3-0 3.46.0-1
ii  libwebkitgtk-6.0-4   2.44.2-1+b2

font-manager recommends no packages.

Versions of packages font-manager suggests:
ii  file-roller44.3-1
pn  nemo-font-manager  
ii  yelp   42.2-1+b2

-- no debconf information


Bug#1007884: bullseye-pu: package glewlwyd/2.5.2-2+deb11u2

2024-07-08 Thread Nicolas Mora
Hello,

Thanks for the update, I will upload it next week if that's ok

/Nicolas

7 juill. 2024 14 h 55 min 41 s Jonathan Wiltshire :

> Control: tag -1 confirmed
> 
> Hi,
> 
> Sorry about the long delay; if this is still of interest, please go ahead.
> The next point release of bullseye will be the final.
> 
> Thanks,
> 
> -- 
> Jonathan Wiltshire  j...@debian.org
> Debian Developer http://people.debian.org/~jmw
> 
> 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
> ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1



Bug#1075940: xfce4-settings: Broken window manager settings

2024-07-08 Thread Nicolas Patrois
Package: xfce4-settings
Version: 4.18.3-1+b1
Severity: normal
Tags: upstream

Dear Maintainer,

The two window manager settings applications are broken.
If I click on their button, xfce4-settings does not move to the right
application, I just see the wait mouse cursor.
They are also broken from the main menu.

Yours,
nicolas


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages xfce4-settings depends on:
ii  exo-utils4.18.0-1+b2
ii  libatk1.0-0t64   2.52.0-1
ii  libc62.38-13
ii  libcairo-gobject21.18.0-3+b1
ii  libcairo21.18.0-3+b1
ii  libcolord2   1.4.7-1+b1
ii  libexo-2-0   4.18.0-1+b2
ii  libfontconfig1   2.15.0-1.1
ii  libgarcon-1-04.18.1-1+b2
ii  libgarcon-common 4.18.1-1
ii  libgdk-pixbuf-2.0-0  2.42.12+dfsg-1
ii  libglib2.0-0t64  2.80.3-1
ii  libgtk-3-0t643.24.42-1
ii  libnotify4   0.8.3-1+b1
ii  libpango-1.0-0   1.54.0+ds-1
ii  libpangocairo-1.0-0  1.54.0+ds-1
ii  libupower-glib3  1.90.3-1
ii  libx11-6 2:1.8.7-1+b1
ii  libxcursor1  1:1.2.2-1
ii  libxfce4ui-2-0   4.18.4-1+b1
ii  libxfce4util74.18.1-2+b1
ii  libxfconf-0-34.18.1-1+b2
ii  libxi6   2:1.8.1-1
ii  libxklavier165.4-5+b1
ii  libxrandr2   2:1.5.4-1
ii  xfce4-helpers4.18.3-1+b1
ii  xfconf   4.18.1-1+b2

Versions of packages xfce4-settings recommends:
ii  colord 1.4.7-1+b1
ii  x11-utils  7.7+6+b1
pn  xiccd  

xfce4-settings suggests no packages.

-- no debconf information



Bug#1075807: python3-bytecode: Can’t upgrade

2024-07-07 Thread nicolas
On 07/07/2024 14:44:16, Julian Gilbey wrote:

> dpkg -l python3-pydevd
> dpkg -l python3-debugpy
> ls -l /usr/lib/python3/dist-packages/debugpy/_vendored/pydevd

Sorry, I let apt remove this package.
You can close the bug if you want.

Yours,
nicolas



Bug#1075807: python3-bytecode: Can’t upgrade

2024-07-05 Thread Nicolas Patrois
Package: python3-bytecode
Version: 0.15.1-3
Severity: important

Dear Maintainer,

Since yesterday, I can’t upgrade python3-bytecode (and python3-pydevd).
There is a bug in debugpy but python3-bytecode (and python3-pydevd) are
qomewhat broken.

In apt upgrade:
[Errno 2] No such file or directory: '/usr/lib/python3/dist-
packages/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd
_trace_api.py'[Errno 2] No such file or directory: '/usr/lib/python3/dist-
packages/debugpy/_vendored/pydevd/_pydevd
_bundle/pydevd_trace_api.py'dpkg: erreur de traitement du paquet
python3-debugpy (--configure) :
 le sous-processus paquet python3-debugpy script post-installation installé a
renvoyé un état de sortie d'erreur 1
[…]
Des erreurs ont été rencontrées pendant l'exécution :
 python3-debugpy
Erreur : Le délai d’attente est dépassé
Error: Sub-process /usr/bin/dpkg returned an error code (1)

In apt autoremove:
REMOVING:
  python3-bytecode  python3-pydevd

Summary:
  Upgrading: 0, Installing: 0, Removing: 2, Not Upgrading: 11
  1 partiellement installés ou enlevés.
  Freed space: 6 470 kB

No, I don’t want to remove these packages.
Maybe the bug is from python3-debugpy?

Yours,
nicolas


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages python3-bytecode depends on:
ii  python3 [python3-supported-min]  3.12.2-1
ii  python3-typing-extensions4.12.2-1

python3-bytecode recommends no packages.

Versions of packages python3-bytecode suggests:
pn  python-bytecode-doc  

-- no debconf information


Bug#1074577: gnat ftbfs with glibc from experimental

2024-07-04 Thread Nicolas Boulenguez
Source: gcc-13
Followup-For: Bug #1074577

Matthias Klose:
> Simon Chopin came up with a conditional to work with both variants
[before and after glibc introduces __USE_TIME64_REDIRECTS]
> #if defined(__USE_TIME64_REDIRECTS) || (__TIMESIZE == 32 && __USE_TIME_BITS64)

I have forwarded this upstream as version 11.

This changes the libgnat-13 sources (System.OS_Constants).

Most Ada packages will require a bin-NMU after you upload gcc-13,
ideally before people start filling FTBS bug reports.

I take the opportunity to apply some postponed changes.
I do not commit them because I have tested no build,
but the only changes since the (tested) version 10 are
 * the line above, tested by Simon Chopin in Ubuntu
 * unapplying small style changes reviewed by upstream
From: Nicolas Boulenguez 
Subject: [PATCH] Ada: update patches for PR114065 (time_64) to v11

The fix 2bacf86d for #1074577 by Simon Chopin at
https://bugs.launchpad.net/ubuntu/+source/gcc-13/+bug/2071605 requires
a rebuild of all Ada libraries, so we might as well
* update all patches to version 11
* apply the parts fixing bugs, but not the style suggestions
---
 ...ersions-with-C-struct-timeval-from-GN.diff | 143 -
 ...ersions-with-C-struct-timespec-from-A.diff | 167 -
 ...ersions-with-C-time_t-from-System.OS_.diff |  79 ---
 ...imeval-and-timespec-definitions-and-c.diff | 604 ++
 ...-unneeded-x32-variant-of-System.Linux.diff | 146 -
 ...ed-posix2008-variant-of-System.Parame.diff | 229 ---
 ...ed-darwin-solaris-x32-variants-of-Sys.diff | 472 --
 ...sleep-from-System.OS_Primitives.Timed.diff |  74 ---
 ...its-time-functions-from-GNU-libc-when.diff |  74 ++-
 debian/rules.patch|   7 -
 10 files changed, 520 insertions(+), 1475 deletions(-)
 delete mode 100644 debian/patches/0001-Ada-remove-conversions-with-C-struct-timeval-from-GN.diff
 delete mode 100644 debian/patches/0002-Ada-remove-conversions-with-C-struct-timespec-from-A.diff
 delete mode 100644 debian/patches/0003-Ada-remove-conversions-with-C-time_t-from-System.OS_.diff
 delete mode 100644 debian/patches/0005-Ada-drop-unneeded-x32-variant-of-System.Linux.diff
 delete mode 100644 debian/patches/0006-Ada-drop-unneeded-posix2008-variant-of-System.Parame.diff
 delete mode 100644 debian/patches/0007-Ada-drop-unneeded-darwin-solaris-x32-variants-of-Sys.diff
 delete mode 100644 debian/patches/0008-Ada-import-nanosleep-from-System.OS_Primitives.Timed.diff

diff --git a/debian/patches/0001-Ada-remove-conversions-with-C-struct-timeval-from-GN.diff b/debian/patches/0001-Ada-remove-conversions-with-C-struct-timeval-from-GN.diff
deleted file mode 100644
index d57d7ec7..
--- a/debian/patches/0001-Ada-remove-conversions-with-C-struct-timeval-from-GN.diff
+++ /dev/null
@@ -1,143 +0,0 @@
-From bedb7553c420da59938eacb115fd9384e54ceae0 Mon Sep 17 00:00:00 2001
-From: Nicolas Boulenguez 
-Date: Fri, 5 Apr 2024 16:51:54 +0200
-Subject: [PATCH 1/9] Ada: remove conversions with C struct timeval from
- GNAT.Calendar
-

- gcc/ada/doc/gnat_rm/the_gnat_library.rst |  2 -
- gcc/ada/libgnat/g-calend.adb | 58 
- gcc/ada/libgnat/g-calend.ads | 18 
- 3 files changed, 78 deletions(-)
-
-diff --git a/src/gcc/ada/doc/gnat_rm/the_gnat_library.rst b/src/gcc/ada/doc/gnat_rm/the_gnat_library.rst
-index 3aae70a..bcec49f 100644
 a/src/gcc/ada/doc/gnat_rm/the_gnat_library.rst
-+++ b/src/gcc/ada/doc/gnat_rm/the_gnat_library.rst
-@@ -674,8 +674,6 @@ Machine-specific implementations are available in some cases.
- 
- Extends the facilities provided by ``Ada.Calendar`` to include handling
- of days of the week, an extended ``Split`` and ``Time_Of`` capability.
--Also provides conversion of ``Ada.Calendar.Time`` values to and from the
--C ``timeval`` format.
- 
- .. _`GNAT.Calendar.Time_IO_(g-catiio.ads)`:
- 
-diff --git a/src/gcc/ada/libgnat/g-calend.adb b/src/gcc/ada/libgnat/g-calend.adb
-index 0a98eb2..e0d34f5 100644
 a/src/gcc/ada/libgnat/g-calend.adb
-+++ b/src/gcc/ada/libgnat/g-calend.adb
-@@ -29,11 +29,8 @@
- --  --
- --
- 
--with Interfaces.C.Extensions;
--
- package body GNAT.Calendar is
-use Ada.Calendar;
--   use Interfaces;
- 
--
--- Day_In_Year --
-@@ -328,61 +325,6 @@ package body GNAT.Calendar is
-Time_Zone=> 0);
-end Time_Of_At_Locale;
- 
--   -
--   -- To_Duration --
--   -
--
--   function To_Duration (T : not null access timeval) return Duration is
--
--  procedure timeval_to_duration
--(T: not null access timeval;
-- sec  : not null access C.Extensions.long_long;
-- usec : not null access C.long);
--  pragma Import (C, timeval_to_duration, "__gnat_timeval_to_duration");
--
--

Bug#1072071: gcc-13: Please add libatomic for 32-bit SPARC for Ada

2024-07-04 Thread Nicolas Boulenguez
Source: gcc-13
Followup-For: Bug #1072071

Hello.

The attached suggestions are just ideas, not real commits. They are
hand-written and not tested at all, so probably contain typos.
Morever, they were written in a gcc-14 source tree.

For the context, commit e08cd8a2 disables Ada on sparc (bug #1072328).

If Adrian can check that 0001, 0002 and 0003 fix #1072071,
then I suggest to merge them into a single commit,
else
  if Matthias confirms that := was not deliberate
  then I suggest to apply 0001.
From: Nicolas Boulenguez 
Subject: [PATCH 1/3] probably fix a typo in e08cd8a2

--- a/debian/control
+++ b/debian/control
@@ -15,11 +15,11 @@ Build-Depends: debhelper (>= 11), dpkg-dev (>= 1.17.14), g++-multilib [amd64 i38
   gperf, bison, flex,
   gettext, nvptx-tools [amd64 arm64 ppc64el], amdgcn-tools-18 [amd64],
   texinfo, locales-all, sharutils,
-  procps, gnat-13:native [!sparc !loong64], g++-13:native [!loong64], gnat-14:native [loong64], g++-14:native [loong64], netbase, gdc-13:native [!arc !ia64 !m68k !sh4 !s390 !sparc64 !alpha !hurd-alpha !hurd-amd64 !hurd-i386], python3:any, cargo [!hppa !ia64 !m68k !sh4 !alpha !hurd-alpha],
+  procps, gnat-13:native [!arc !ia64 !sh3 !sh3eb !sh4eb !sparc !loong64], g++-13:native [!loong64], gnat-14:native [loong64], g++-14:native [loong64], netbase, gdc-13:native [!arc !ia64 !m68k !sh4 !s390 !sparc64 !alpha !hurd-alpha !hurd-amd64 !hurd-i386], python3:any, cargo [!hppa !ia64 !m68k !sh4 !alpha !hurd-alpha],
   libisl-dev (>= 0.20), libmpc-dev (>= 1.0), libmpfr-dev (>= 3.0.0-9~), libgmp-dev (>= 2:5.0.1~), lib32z1-dev [amd64], lib64z1-dev [i386], unzip ,
   dejagnu , coreutils, chrpath, lsb-release, quilt, time,
   pkg-config, libgc-dev,
-  g++-14-for-host , gobjc-14-for-host [!avr] , gfortran-14-for-host , gdc-14-for-host [!arc !ia64 !m68k !sh4 !s390 !sparc64 !alpha !hurd-alpha !hurd-amd64 !hurd-i386] , gccgo-14-for-host [!arc !avr !hppa !loong64 !m68k !sh4] , gnat-14-for-host [!sparc] , gm2-14-for-host [!powerpc !ppc64 !sh4] ,
+  g++-14-for-host , gobjc-14-for-host [!avr] , gfortran-14-for-host , gdc-14-for-host [!arc !ia64 !m68k !sh4 !s390 !sparc64 !alpha !hurd-alpha !hurd-amd64 !hurd-i386] , gccgo-14-for-host [!arc !avr !hppa !loong64 !m68k !sh4] , gnat-14-for-host [!arc !ia64 !sh3 !sh3eb !sh4eb !sparc] , gm2-14-for-host [!powerpc !ppc64 !sh4] ,
 Build-Depends-Indep: doxygen , graphviz , ghostscript , texlive-latex-base , xsltproc , libxml2-utils , docbook-xsl-ns ,
 Homepage: http://gcc.gnu.org/
 Vcs-Browser: https://salsa.debian.org/toolchain-team/gcc
--- a/debian/rules.defs
+++ b/debian/rules.defs
@@ -872,7 +872,7 @@ ifeq (,$(filter $(DEB_STAGE),stage1 stage2))
 # Ada 
 ada_no_cpus	:= arc ia64 sh3 sh3eb sh4eb
 #ada_no_cpus	+= armel # See Debian #1061370
-ada_no_cpus	:= sparc # See Debian #1072328
+ada_no_cpus	+= sparc # See Debian #1072328
 ada_no_systems	:= 
 ada_no_cross	:= no
 ada_no_snap	:= no
From: Nicolas Boulenguez 
Subject: [PATCH 2/3] untested fix for #1072071

--- a/debian/patches/ada-armel-libatomic.diff
+++ b/debian/patches/ada-armel-libatomic.diff
@@ -1,11 +1,14 @@
-Description: link libgnarl with libatomic on armel
+Description: link libgnarl with libatomic on armel and sparc
  On other architectures, the library is ignored thanks to --as-needed.
  .
- Seen with 14-20240429-1:
+ Seen with 14-20240429-1 on armel:
  cd rts; [bla]/./gcc/xgcc [bla] -shared [bla] -o libgnarl-14.so [bla]
  /usr/bin/arm-linux-gnueabi-ld: libgnat-14.so: undefined reference to `__atomic_compare_exchange_8'
  /usr/bin/arm-linux-gnueabi-ld: libgnat-14.so: undefined reference to `__atomic_load_8'
  .
+ Seen with 13.2.0-25 on sparc:
+ checking fp.h usability... /usr/sparc-linux-gnu/bin/ld: libgnat-13.so: undefined reference to `__atomic_compare_exchange_8'
+ .
  Libatomic becomes an artificial dependency for Ada in Makefile.def,
  so a better solution is welcome.
  .
@@ -22,6 +25,7 @@ Description: link libgnarl with libatomic on armel
  (ada-gnattools-cross.diff adds checking options to LDFLAGS,
   then adds LDFLAGS to the command line).
 Bug-Debian: https://bugs.debian.org/861734
+Bug-Debian: https://bugs.debian.org/1072071
 Author: Matthias Klose 
 Author: Nicolas Boulenguez 
 
@@ -35,6 +39,14 @@ Author: Nicolas Boulenguez 
LIBGNAT_TARGET_PAIRS = \
a-intnam.adsFrom: Nicolas Boulenguez 
Subject: [PATCH 3/3] revert e08cd8a2

--- a/debian/control
+++ b/debian/control
@@ -15,11 +15,11 @@ Build-Depends: debhelper (>= 11), dpkg-dev (>= 1.17.14), g++-multilib [amd64 i38
   gperf, bison, flex,
   gettext, nvptx-tools [amd64 arm64 ppc64el], amdgcn-tools-18 [amd64],
   texinfo, locales-all, sharutils,
-  procps, gnat-13:native [!arc !ia64 !sh3 !sh3eb !sh4eb !sparc !loong64], g++-13:native [!loong64], gnat-14:native [loong64], g++-14:native [loong64], netbase, gdc-13:native [!arc !ia64 !m68k !sh4 !s390 !sparc64 !alpha !hurd-alpha !hurd-amd64 !hurd-i386], python3:any, cargo [!hppa !ia64 !m68k !sh4 !alpha !hurd-alpha],
+  procps, gnat-13

Bug#1068076: Patch for bug 1068076

2024-07-04 Thread Nicolas Mora

Thanks Mattias!

Your patch has been submitted upstream, the PR [1] is now merged so I 
backported it as a debian patch [2]. I'll soon upload the new version if 
everything is fine.


/Nicolas

[1] https://github.com/libssh2/libssh2/pull/1415
[2] 
https://salsa.debian.org/debian/libssh2/-/blob/master/debian/patches/maxpathlen.patch?ref_type=heads




Bug#1036820: libsdl2-dev include headers not found by cmake since usr merge

2024-07-03 Thread Nicolas Otton
Hello,

I was able to reproduce this bug on a debian bookworm installed recently.
I have the same issue, cmake, libsdl2-dev and the other dependencies were
installed through apt, not compiled from source, and CMAKE_CURRENT_LIST_DIR
is set to /lib/x86_64-linux-gnu/cmake/SDL2 so the cmake of the projects
fails.

-- 
Nicolas OTTON

DevOps

Unissey
[image: emailAddress] nicolas.ot...@unissey.com
[image: website] unissey.com
[image: address] 4 rue du Caire, 75002 Paris
<https://unissey.com/request-a-demo/>

-- 
The content of this email is confidential and intended for the recipient 
specified in message only. It is strictly forbidden to share any part of 
this message with any third party, without a written consent of the sender. 
If you received this message by mistake, please reply to this message and 
follow with its deletion, so that we can ensure such a mistake does not 
occur in the future. Thank you for your cooperation and understanding.


Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-07-02 Thread Nicolas Boulenguez
Summary of inadvertently private mails:
mk-bsd-sed-quotation-mark.diff hopefully fixes the build on BSD.

Assuming this, and that I am not missing the point again,
mk-unhardcode-datadir.diff can be applied again.
The attachment improves its readability.

 * It replaces "ifndef ... := ... endif" with "?=".
   The variable will be searched for $ on each expansion, but the
   performance difference is probably quite small.

 * It removes the comment explaining where dpkg_datadir might already
   be defined.
   Anyone working on this will know about default.mk.

 * It replaces $(patsubst ...) with $(dir ...).
   This was the original suggestion.
   You once answered:
> to avoid changing all pathname concatenation I changed dpkg_datadir to
> «$(patsubst %/,%,$(dir $(lastword $(MAKEFILE_LIST».
   then I did suggest  $(patsubst %/current.mk/,%,$(lastword $(MAKEFILE_LIST))),
   but, thinking about it again, there seems to be no problem with a
   double path component separator.
>From 467d7aa41c95796f6d7ef43bb4c8fda925728791 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Tue, 2 Jul 2024 11:54:55 +0200
Subject: scripts/mk: Stop hard-coding dpkg_datadir

This path differ during tests and after installation.  Instead of
rewriting the file with a hardcoded path, compute it within Make.

diff --git a/build-aux/subst.am b/build-aux/subst.am
index 7785e4af7..9c96e5ce0 100644
--- a/build-aux/subst.am
+++ b/build-aux/subst.am
@@ -45,11 +45,3 @@ SUFFIXES += .pl
 	@test -d `dirname $@` || $(MKDIR_P) `dirname $@`
 	$(AM_V_GEN) $(subst_perl_filter) <$< >$@
 	$(AM_V_at) chmod +x $@
-
-# Makefile support.
-
-subst_make_rules = "\
-	s{dpkg_datadir\s*=\s*[^\s]*}{dpkg_datadir = $(pkgdatadir)}; \
-	"
-
-subst_make_file = $(PERL) -i -p -e $(subst_make_rules)
diff --git a/scripts/mk/Makefile.am b/scripts/mk/Makefile.am
index be6076b2c..6e85e17b9 100644
--- a/scripts/mk/Makefile.am
+++ b/scripts/mk/Makefile.am
@@ -10,13 +10,3 @@ dist_pkgdata_DATA = \
 	pkg-info.mk \
 	vendor.mk \
 	# EOL
-
-SUFFIXES =
-
-include $(top_srcdir)/build-aux/subst.am
-
-install-data-hook:
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/default.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/buildtools.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/pkg-info.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/vendor.mk
diff --git a/scripts/mk/buildtools.mk b/scripts/mk/buildtools.mk
index 6ce9642cd..1f63beede 100644
--- a/scripts/mk/buildtools.mk
+++ b/scripts/mk/buildtools.mk
@@ -28,7 +28,7 @@
 ifndef dpkg_buildtools_mk_included
 dpkg_buildtools_mk_included = yes
 
-dpkg_datadir = $(srcdir)/mk
+dpkg_datadir ?= $(dir $(lastword $(MAKEFILE_LIST)))
 include $(dpkg_datadir)/architecture.mk
 
 # We set the TOOL_FOR_BUILD variables to the specified value, and the TOOL
diff --git a/scripts/mk/default.mk b/scripts/mk/default.mk
index c4e408b01..14e5be0cd 100644
--- a/scripts/mk/default.mk
+++ b/scripts/mk/default.mk
@@ -4,7 +4,8 @@
 ifndef dpkg_default_mk_included
 dpkg_default_mk_included = yes
 
-dpkg_datadir = $(srcdir)/mk
+dpkg_datadir := $(dir $(lastword $(MAKEFILE_LIST)))
+
 include $(dpkg_datadir)/architecture.mk
 include $(dpkg_datadir)/buildapi.mk
 ifeq ($(call dpkg_build_api_ge,1),yes)
diff --git a/scripts/mk/vendor.mk b/scripts/mk/vendor.mk
index 746503a33..43898d956 100644
--- a/scripts/mk/vendor.mk
+++ b/scripts/mk/vendor.mk
@@ -36,7 +36,7 @@
 ifndef dpkg_vendor_mk_included
 dpkg_vendor_mk_included = yes
 
-dpkg_datadir = $(srcdir)/mk
+dpkg_datadir ?= $(dir $(lastword $(MAKEFILE_LIST)))
 include $(dpkg_datadir)/buildapi.mk
 
 dpkg_lazy_eval ?= $(eval $(1) = $(2)$$($(1)))
>From ca50a267435a14fddd8679771b1e3c1178160ee1 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Tue, 2 Jul 2024 10:44:20 +0200
Subject: scripts/mk: replace more GNU sed constructs with POSIX ones

This hopefully fixes tests with BSD sed.

diff --git a/scripts/mk/pkg-info.mk b/scripts/mk/pkg-info.mk
index cfd456af1..ddda4f736 100644
--- a/scripts/mk/pkg-info.mk
+++ b/scripts/mk/pkg-info.mk
@@ -21,7 +21,7 @@ dpkg_pkg_info_mk_included = yes
 dpkg_parsechangelog_run = $(eval $(shell dpkg-parsechangelog | sed -n '\
   s/^Distribution: \(.*\)/$$(eval DEB_DISTRIBUTION:=\1)/p;\
   s/^Source: \(.*\)/$$(eval DEB_SOURCE:=\1)/p;\
-  s/^Version: \([0-9]*:\)\?\([^-]*\)\(\(.*\)-[^-]*\)\?$$/\
+  s/^Version: \([0-9]*:\)\{0,1\}\([^-]*\)\(\(.*\)-[^-]*\)\{0,1\}$$/\
 $$(eval DEB_VERSION:=\1\2\3)\
 $$(eval DEB_VERSION_EPOCH_UPSTREAM:=\1\2\4)\
 $$(eval DEB_VERSION_UPSTREAM_REVISION:=\2\3)\


Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-06-24 Thread Nicolas Boulenguez
Package: dpkg-dev
Followup-For: Bug #872381

Hello again.
My last message was confusing.

I am suggesting to improve commit f1175056 with
0001-build-spare-an-unneeded-subst-handling-in-pkg-info.m.patch.

I have only quoted 0001-scripts-mk-stop-hard-coding-dpkg_datadir.patch
for context. Please ignore it.



Bug#1073971: RFS: golang-github-makenowjust-heredoc-v2/2.0.1-1 [ITP] -- Convert strings to here documents in Go (v2) (library)

2024-06-20 Thread Nicolas Schier
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package 
"golang-github-makenowjust-heredoc-v2":

 * Package name : golang-github-makenowjust-heredoc-v2
   Version  : 2.0.1-1
   Upstream contact : TSUYUSATO Kitsune 
 * URL  : https://github.com/MakeNowJust/heredoc
 * License  : MIT
 * Vcs  : 
https://salsa.debian.org/go-team/packages/golang-github-makenowjust-heredoc-v2
   Section  : golang

The source builds the following binary packages:

  golang-github-makenowjust-heredoc-v2-dev - Convert strings to here documents 
in Go (v2) (library)

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/golang-github-makenowjust-heredoc-v2/

Alternatively, you can download the package with 'dget' using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/g/golang-github-makenowjust-heredoc-v2/golang-github-makenowjust-heredoc-v2_2.0.1-1.dsc

Changes for the initial release:

 golang-github-makenowjust-heredoc-v2 (2.0.1-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1073934)

Regards,
Nicolas



Bug#1073934: ITP: golang-github-makenowjust-heredoc -- Convert strings to here documents in Go (v2) (library)

2024-06-20 Thread Nicolas Schier
Control: retitle -1 ITP: golang-github-makenowjust-heredoc-v2 -- Convert 
strings to here documents in Go (v2) (library)

I forgot to fix the package name: dh-make-golang stripped away the -v2
suffix, but I think it is required to not break
golang-github-cli-go-gh-dev which depends on the original
golang-github-makenowjust-heredoc-dev package.

On Thu, Jun 20, 2024 at 03:22:27PM +0200, Nicolas Schier wrote:
> Package: wnpp
> Severity: wishlist
> Owner: Nicolas Schier 
> 
> * Package name: golang-github-makenowjust-heredoc

 * Package name: golang-github-makenowjust-heredoc-2

>   Version : 2.0.1-1
>   Upstream Author : TSUYUSATO Kitsune
> * URL : https://github.com/MakeNowJust/heredoc
> * License : MIT
>   Programming Lang: Go
>   Description : Convert strings to here documents in Go (v2) (library)
>Here documents allow text files or other data to be embedded in source
>files.  The heredoc library implements the whitespace filtering and line
>break preservation since Go does not have any syntax allowing here
>documents natively.
>.
>This package contains version 2.x of heredoc.
> 
> heredoc/v2 package is a build-dependency for glab v1.42.0.

Kind regards,
Nicolas



Bug#1073934: ITP: golang-github-makenowjust-heredoc -- Convert strings to here documents in Go (v2) (library)

2024-06-20 Thread Nicolas Schier
Package: wnpp
Severity: wishlist
Owner: Nicolas Schier 

* Package name: golang-github-makenowjust-heredoc
  Version : 2.0.1-1
  Upstream Author : TSUYUSATO Kitsune
* URL : https://github.com/MakeNowJust/heredoc
* License : MIT
  Programming Lang: Go
  Description : Convert strings to here documents in Go (v2) (library)
   Here documents allow text files or other data to be embedded in source
   files.  The heredoc library implements the whitespace filtering and line
   break preservation since Go does not have any syntax allowing here
   documents natively.
   .
   This package contains version 2.x of heredoc.

heredoc/v2 package is a build-dependency for glab v1.42.0.



Bug#1050805: dhcpcd-base: DoS: zero-length packet cause eventual lease expiration

2024-06-20 Thread Nicolas Cavallari

On 18/06/2024 16:39, Martin-Éric Racine wrote:

ti 18. kesäk. 2024 klo 15.52 Nicolas Cavallari
(nicolas.cavall...@green-communications.fr) kirjoitti:


On 18/06/2024 13:14, Martin-Éric Racine wrote:

su 16. kesäk. 2024 klo 9.05 Martin-Éric Racine
(martin-eric.rac...@iki.fi) kirjoitti:


la 15. kesäk. 2024 klo 16.55 Nicolas Cavallari
(nicolas.cavall...@green-communications.fr) kirjoitti:


I didn't check if there were any adverse effect or if leases are still
renewed. I can't check on the production system before Monday.


Please let me know.


Any news on this?


My dedicated server receives leases of 86400s, it takes a while to check
if leases are renewed correctly.


Noted.


After two days and multiples renews, I can confirm that it works.

For Stable, this is what I would upload, once you've confirmed that
the 3 cherry-picks work:

dhcpcd5 (9.4.1-24~deb12u4) bookworm; urgency=medium
   * Add --no-stop-on-upgrade --no-restart-after-upgrade (Closes: #1057959).
   * Cherry-pick upstream backported fixes for RC bug (Closes: #1050805).
   * Update dhcpcd.preinst version check to match current one.

On the plus side, no attempt will be made to restart it, to prevent
connection loss. On the minus side, it means that the administrator
must restart manually or reboot.


Well, needrestart exists, so i don't have an issue with this.



Bug#1050805: dhcpcd-base: DoS: zero-length packet cause eventual lease expiration

2024-06-18 Thread Nicolas Cavallari

On 18/06/2024 13:14, Martin-Éric Racine wrote:

su 16. kesäk. 2024 klo 9.05 Martin-Éric Racine
(martin-eric.rac...@iki.fi) kirjoitti:


la 15. kesäk. 2024 klo 16.55 Nicolas Cavallari
(nicolas.cavall...@green-communications.fr) kirjoitti:


I didn't check if there were any adverse effect or if leases are still
renewed. I can't check on the production system before Monday.


Please let me know.


Any news on this?


My dedicated server receives leases of 86400s, it takes a while to check 
if leases are renewed correctly.


I installed it today. For some reason, dhcpcd was stopped when upgrading 
the 'dhcpcd' package but was not restarted afterward. Looking at the 
dhcpcd maintainer scripts, I see the deb-systemd-invoke stop in preinst 
but i don't see any start in postinst or anywhere else.




Bug#1050805: dhcpcd-base: DoS: zero-length packet cause eventual lease expiration

2024-06-16 Thread Nicolas Cavallari

On 16/06/2024 08:05, Martin-Éric Racine wrote:

la 15. kesäk. 2024 klo 16.55 Nicolas Cavallari
(nicolas.cavall...@green-communications.fr) kirjoitti:


On 15/06/2024 11:33, Martin-Éric Racine wrote:


Upstream got around releasing a backport of this for branch 9 as
commits 53e2f6de4ba87d0534c89cae674e6c1a48724ef0 and
6e127eac6903524d401b31893167e4529b8ab111 respectively.

You are hereby invited to test and report whether this fixes it for Stable.


I did some quick tests on a VM:

First, with 9.4.1-24~deb12u3 as present in debian stable:



Then I apt sourced dhcpcd, applied the two patches, rebuilt debian
packages and tested them.  The situation is now worse:



I then tested this patch from issue #283:

https://github.com/NetworkConfiguration/dhcpcd/commit/727c78f503d456875e2a3cee7609288b537d9d25.patch

And this time, it appears to fix the problem:


So you had to apply 3 patches to fix 9.4.1 in Stable? The 2
aforementioned ones and the one from upstream issue 283?


Yes, I applied 3 patches.



Bug#1050805: dhcpcd-base: DoS: zero-length packet cause eventual lease expiration

2024-06-15 Thread Nicolas Cavallari

On 15/06/2024 11:33, Martin-Éric Racine wrote:

On Tue, 29 Aug 2023 13:17:51 +0200 Nicolas Cavallari
 wrote:

Package: dhcpcd-base
Version: 9.4.1-22
Severity: critical
Tags: security
Justification: breaks unrelated software
X-Debbugs-Cc: Debian Security Team 

When the dhcpcd DHCPv4 client receives a zero-length UDP packet on port
68, the "network proxy" dhcpcd process exits with status 0.  dhcpcd then
stops all network activity:  It does not renew leases and eventually expires
the current lease (unless it has infinite duration) and removes the IP
address, leaving the system without networking.

This bug can be triggered remotely over the internet from any UDP port
and is critical on an internet-facing system that needs DHCP to get
an IP address, such as a gateway, a dedicated server or a VM.

This affects version 9.4.1-22 (stable) and 1:9.4.1-24~deb12u2
(stable proposed update) but not 1:10.0.2-4 (testing/unstable) as
upstream fixed it in 10.0.2:

Upstream Bug report: https://github.com/NetworkConfiguration/dhcpcd/issues/179
Upstream Fix: 
https://github.com/NetworkConfiguration/dhcpcd/commit/8b29c0ddf026c1c5647c3b8c6cfe21699c4056ae

This patch does not apply cleanly to 9.4.1 because the privsep
structure changed in 10.0.2.  It's likely that only the src/privsep.c
hunks about len == 0 and eloop_exit() needs to be backported, the other
changes are just here to avoid compiler warnings about unused
parameters.


Upstream got around releasing a backport of this for branch 9 as
commits 53e2f6de4ba87d0534c89cae674e6c1a48724ef0 and
6e127eac6903524d401b31893167e4529b8ab111 respectively.

You are hereby invited to test and report whether this fixes it for Stable.


I did some quick tests on a VM:

First, with 9.4.1-24~deb12u3 as present in debian stable:

# dhcpcd
dhcpcd-9.4.1 starting
dev: loaded udev
DUID 00:04:56:44:13:1b:34:73:40:28:95:70:ba:03:3b:94:d1:45
enp1s0: IAID 00:a5:5a:70
enp1s0: rebinding lease of 192.168.122.51
enp1s0: leased 192.168.122.51 for 3600 seconds
enp1s0: adding route to 192.168.122.0/24
enp1s0: adding default route via 192.168.122.1
forked to background, child pid 1211
# ps ax | grep dhcpcd
 1211 ?S  0:00 dhcpcd: [manager] [ip4] [ip6]
 1212 ?S  0:00 dhcpcd: [privileged proxy]
 1213 ?S  0:00 dhcpcd: [network proxy]
 1214 ?S  0:00 dhcpcd: [control proxy]
 1217 ?S  0:00 dhcpcd: [BPF ARP] enp1s0 192.168.122.51
 1235 pts/0S+ 0:00 grep dhcpcd
# python3 -c 'from socket import *; socket(AF_INET, 
SOCK_DGRAM).sendto(b"", ("127.0.0.1", 68))'

# ps ax | grep dhcpcd
 1211 ?S  0:00 dhcpcd: [manager] [ip4] [ip6]
 1212 ?S  0:00 dhcpcd: [privileged proxy]
 1214 ?S  0:00 dhcpcd: [control proxy]
 1217 ?S  0:00 dhcpcd: [BPF ARP] enp1s0 192.168.122.51
 1239 pts/0S+ 0:00 grep dhcpcd

The network proxy (1213) is gone.

Then I apt sourced dhcpcd, applied the two patches, rebuilt debian 
packages and tested them.  The situation is now worse:


# ps ax | grep dhcpcd
 1492 ?S  0:00 dhcpcd: [manager] [ip4] [ip6]
 1493 ?S  0:00 dhcpcd: [privileged proxy]
 1494 ?S  0:00 dhcpcd: [network proxy]
 1495 ?S  0:00 dhcpcd: [control proxy]
 1498 ?S  0:00 dhcpcd: [BPF ARP] enp1s0 192.168.122.51
 1516 pts/0S+ 0:00 grep dhcpcd
# python3 -c 'from socket import *; socket(AF_INET, 
SOCK_DGRAM).sendto(b"", ("127.0.0.1", 68))'
[ 1851.428513] dhcpcd[1492]: segfault at 4 ip 004eecd8 sp bf980af0 error 
4 in dhcpcd[4cd000+4] likely on CPU 2 (core 0, socket 2)
[ 1851.428523] Code: c4 20 83 c4 0c 5b 5e 5f 5d c3 8d b4 26 00 00 00 00 
90 55 89 d5 57 89 c7 56 53 e8 13 0c fe ff 81 c3 63 d0 03 00 83 ec 1c 8b 
00 <8b> 52 04 8b 80 78 01 00 00 8b 30 85 f6 0f 84 9c 00 00 00 8d 47 0c

# ps ax | grep dhcpcd
 1493 ?S  0:00 dhcpcd: [privileged proxy]
 1494 ?S  0:00 dhcpcd: [network proxy]
 1498 ?S  0:00 dhcpcd: [BPF ARP] enp1s0 192.168.122.51
 1521 pts/0S+ 0:00 grep dhcpcd

The network proxy survived, but the manager and control proxy didn't. 
And SIGTERM is not enough to kill the remaining processes.


I then tested this patch from issue #283:

https://github.com/NetworkConfiguration/dhcpcd/commit/727c78f503d456875e2a3cee7609288b537d9d25.patch

And this time, it appears to fix the problem:

# ps ax | grep dhcp
 3248 ?S  0:00 dhcpcd: [manager] [ip4] [ip6]
 3249 ?S  0:00 dhcpcd: [privileged proxy]
 3250 ?S  0:00 dhcpcd: [network proxy]
 3251 ?S  0:00 dhcpcd: [control proxy]
 3254 ?S  0:00 dhcpcd: [BPF ARP] enp1s0 192.168.122.51
 3272 pts/1S+ 0:00 grep dhcp
# python3 -c 'from socket import *; socket(AF_INET, 
SOCK_DGRAM).sendto(b"", ("127.0.0.1", 68))'

# ps ax | grep dhcp
 3248 ?S  0:00 dhcpcd: [manager] [ip4] [ip6]
 3249 ?S  0:00 dhcpcd: [privilege

Bug#1072907: /lib/modules/6.1.0-21-amd64/kernel/drivers/net/wireless/intel/iwlwifi/iwlwifi.ko: iwlwifi firmware didn't ACK the reset then fails to boot

2024-06-10 Thread Nicolas FORMICHELLA
Package: src:linux
Version: 6.1.90-1
Severity: important
File: 
/lib/modules/6.1.0-21-amd64/kernel/drivers/net/wireless/intel/iwlwifi/iwlwifi.ko

Dear Maintainer,


   * What led up to the situation?
 A kernel update
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   Blacklisting iwlwifi kernel module
   * What was the outcome of this action?
   It allowed me to boot
   * What outcome did you expect instead?
   It should not prevent booting

-- Package-specific info:
** Version:
Linux version 6.1.0-21-amd64 (debian-ker...@lists.debian.org) (gcc-12 (Debian 
12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40) #1 SMP 
PREEMPT_DYNAMIC Debian 6.1.90-1 (2024-05-03)

** Command line:
BOOT_IMAGE=/vmlinuz-6.1.0-21-amd64 root=/dev/mapper/nf--laptop--debian--vg-root 
ro iwlwifi.blacklist=yes

The blacklist is used to allow booting

** Not tainted

** Kernel log from the failure:
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: enabling device 
( -> 0002)
Jun 10 08:35:35 nf-laptop-debian kernel: usb 1-6: Found UVC 1.00 device 
Integrated_Webcam_FHD (0c45:674c)
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: firmware: 
direct-loading firmware iwlwifi-so-a0-gf-a0-72.ucode
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: api flags index 
2 larger than supported by driver
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: 
TLV_FW_FSEQ_VERSION: FSEQ Version: 0.0.2.36
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: firmware: failed 
to load iwl-debug-yoyo.bin (-2)
Jun 10 08:35:35 nf-laptop-debian kernel: firmware_class: See 
https://wiki.debian.org/Firmware for information about missing firmware
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: firmware: failed 
to load iwl-debug-yoyo.bin (-2)
Jun 10 08:35:35 nf-laptop-debian kernel: iwlwifi :00:14.3: loaded firmware 
version 72.daa05125.0 so-a0-gf-a0-72.ucode op_mode iwlmvm
Jun 10 08:35:35 nf-laptop-debian kernel: input: Integrated_Webcam_FHD: Integrat 
as /devices/pci:00/:00:14.0/usb1/1-6/1-6:1.0/input/input17
Jun 10 08:35:35 nf-laptop-debian kernel: usb 1-6: Found UVC 1.00 device 
Integrated_Webcam_FHD (0c45:674c)
Jun 10 08:35:36 nf-laptop-debian kernel: input: Integrated_Webcam_FHD: Integrat 
as /devices/pci:00/:00:14.0/usb1/1-6/1-6:1.2/input/input18
Jun 10 08:35:36 nf-laptop-debian kernel: usbcore: registered new interface 
driver uvcvideo
Jun 10 08:35:36 nf-laptop-debian kernel: AVX2 version of gcm_enc/dec engaged.
Jun 10 08:35:36 nf-laptop-debian kernel: AES CTR mode by8 optimization enabled
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_intel :00:1f.3: DSP 
detected with PCI class/subclass/prog-if info 0x040380
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_intel :00:1f.3: enabling 
device ( -> 0002)
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_intel :00:1f.3: bound 
:00:02.0 (ops i915_audio_component_bind_ops [i915])
Jun 10 08:35:36 nf-laptop-debian systemd[1]: Starting systemd-rfkill.service - 
Load/Save RF Kill Switch Status...
Jun 10 08:35:36 nf-laptop-debian kernel: Bluetooth: Core ver 2.22
Jun 10 08:35:36 nf-laptop-debian kernel: NET: Registered PF_BLUETOOTH protocol 
family
Jun 10 08:35:36 nf-laptop-debian kernel: Bluetooth: HCI device and connection 
manager initialized
Jun 10 08:35:36 nf-laptop-debian kernel: Bluetooth: HCI socket layer initialized
Jun 10 08:35:36 nf-laptop-debian kernel: Bluetooth: L2CAP socket layer 
initialized
Jun 10 08:35:36 nf-laptop-debian kernel: Bluetooth: SCO socket layer initialized
Jun 10 08:35:36 nf-laptop-debian kernel: iwlwifi :00:14.3: Detected 
Intel(R) Wi-Fi 6E AX211 160MHz, REV=0x370
Jun 10 08:35:36 nf-laptop-debian kernel: thermal thermal_zone10: failed to read 
out thermal zone (-61)
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0: 
autoconfig for ALC3204: line_outs=1 (0x14/0x0/0x0/0x0/0x0) type:speaker
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0:
speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0:
hp_outs=1 (0x21/0x0/0x0/0x0/0x0)
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0:
mono: mono_out=0x0
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0:
inputs:
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0: 
 Headset Mic=0x19
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0: 
 Headphone Mic=0x1a
Jun 10 08:35:36 nf-laptop-debian kernel: snd_hda_codec_realtek hdaudioC0D0: 
 Internal Mic=0x12
Jun 10 08:35:36 nf-laptop-debian kernel: dell_laptop: Using i8042 filter 
function for receiving events
Jun 10 08:35:36 nf-laptop-debian kernel: input: HDA Digital PCBeep as 
/devices/pci:00/:00:1f.3/sound/card0/input19
Jun 10 08:35:36 nf-laptop-debian kernel: input: HDA Intel PCH Headphone Mic as 

Bug#1031276: randomness on armel, armhf mipsel resulting in unreproducible man-db index.db files

2024-06-06 Thread Nicolas Mora

Hello,

Le 2024-06-05 à 17 h 05, Johannes Schauer Marin Rodrigues a écrit :


I applied your patch to gdbm from your packaging git (your pristine-tar branch
seems to be missing the delta for the latest upstream version) and executed the

Indeed, it should be fixed in salsa repo now.


tests from my initial bug report again. With your patch the problem is gone.


Good to know.

I'll upload a new package to unstable soon then.

/Nicolas



Bug#1031276: randomness on armel, armhf mipsel resulting in unreproducible man-db index.db files

2024-06-05 Thread Nicolas Mora

Hello,

Sergey from upstream sent me a patch that should fix the problem. The 
patch initializes allocated blocks with 0 to avoid pseudo-randomness in 
data.


Can you test this patch before I upload a new package to unstable? I 
could upload to experimental first for example.


Let me know what better suits you

/NicolasFrom 29daaae01975d849b015170cae51f57c254d8e42 Mon Sep 17 00:00:00 2001
From: Sergey Poznyakoff 
Date: Tue, 4 Jun 2024 18:09:55 +0300
Subject: [PATCH] Ensure any padding bytes in avail_elem are filled with 0.
Forwarded: not-needed

* src/gdbmdefs.h (avail_elem_init): New function.
* src/bucket.c: Use avail_elem_init to initialize local variables of
avail_elem type.
* src/falloc.c: Likewise.
---
 src/bucket.c   |  5 +++--
 src/falloc.c   | 16 +++-
 src/gdbmdefs.h |  9 +
 3 files changed, 19 insertions(+), 11 deletions(-)

--- a/src/bucket.c
+++ b/src/bucket.c
@@ -638,8 +638,9 @@
   dbf->bucket_dir = _gdbm_bucket_dir (dbf, next_insert);
   
   /* Invalidate old cache entry. */
-  old_bucket.av_adr  = dbf->cache_mru->ca_adr;
-  old_bucket.av_size = dbf->header->bucket_size;
+  avail_elem_init (_bucket,
+		   dbf->header->bucket_size,
+		   dbf->cache_mru->ca_adr);
   cache_elem_free (dbf, dbf->cache_mru);
   
   /* Set dbf->bucket to the proper bucket. */
--- a/src/falloc.c
+++ b/src/falloc.c
@@ -121,8 +121,7 @@
 return 0;
 
   /* Initialize the avail element. */
-  temp.av_size = num_bytes;
-  temp.av_adr = file_adr;
+  avail_elem_init (, num_bytes, file_adr);
 
   /* Is the freed space large or small? */
   if ((num_bytes >= dbf->header->block_size) || dbf->central_free)
@@ -189,9 +188,10 @@
 }
 
   /* Set up variables. */
-  new_el.av_adr = dbf->avail->next_block;
-  new_el.av_size = ( ( (dbf->avail->size * sizeof (avail_elem)) >> 1)
-			+ sizeof (avail_block));
+  avail_elem_init (_el,
+		   ( ( (dbf->avail->size * sizeof (avail_elem)) >> 1)
+		 + sizeof (avail_block)),
+		   dbf->avail->next_block);
 
   /* Allocate space for the block. */
   new_blk = malloc (new_el.av_size);
@@ -404,8 +404,7 @@
   avail_elem val;		/* The default return value. */
 
   /* Initialize default return value. */
-  val.av_adr = 0;
-  val.av_size = 0;
+  avail_elem_init (, 0, 0);
 
   /* Search for element.  List is sorted by size. */
   index = avail_lookup (size, av_table, *av_count);
@@ -480,8 +479,7 @@
   avail_elem val;
 
   /* Need at least one block. */
-  val.av_adr  = dbf->header->next_block;
-  val.av_size = dbf->header->block_size;
+  avail_elem_init (, dbf->header->block_size, dbf->header->next_block);
 
   /* Get enough blocks to fit the need. */
   while (val.av_size < size)
--- a/src/gdbmdefs.h
+++ b/src/gdbmdefs.h
@@ -72,6 +72,15 @@
   off_t  av_adr;/* The file address of the available block. */
 } avail_elem;
 
+static inline void
+avail_elem_init (avail_elem *elem, int size, off_t adr)
+{
+  /* Make sure any padding in elem is filled with 0. */
+  memset (elem, 0, sizeof (*elem));
+  elem->av_size = size;
+  elem->av_adr = adr;
+}
+
 /* This is the actual table. The in-memory images of the avail blocks are
allocated by malloc using a calculated size.  */
 typedef struct


Bug#1031276: randomness on armel, armhf mipsel resulting in unreproducible man-db index.db files

2024-06-04 Thread Nicolas Mora

Hello,

Le 2024-06-03 à 01 h 48, Johannes Schauer Marin Rodrigues a écrit :


more than one year later this is still a problem. Could you maybe have a look
or communicate this issue with upstream?


Sorry, I thought I already have sent a bug report, thanks for reminding.

I was able to reproduce the bug using a armv7 arch, and the bug is 
currently looking at by upstream.


/Nicolas



Bug#1071609: veusz: Buggy icon bar and main window

2024-05-22 Thread Nicolas Patrois
Package: veusz
Version: 3.6.2-1.1
Severity: important
Tags: upstream

Dear Maintainer,

Veusz’ main window is not really usable.
Look at the icons bar and the left part of the window, in the screenshot.

Yours,
Nicolas


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages veusz depends on:
ii  libjs-sphinxdoc  7.2.6-7
ii  python3  3.11.8-1
ii  python3-numpy1:1.26.4+ds-10
ii  python3-veusz3.6.2-1.1

veusz recommends no packages.

veusz suggests no packages.

-- no debconf information


Bug#1071323: libevent: FTBFS: dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file

2024-05-17 Thread Nicolas Mora

Hello,

Le 2024-05-17 à 16 h 38, Santiago Vila a écrit :

Package: src:libevent
Version: 2.1.12-stable-8.1
Severity: serious
Tags: ftbfs

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:



[...]

dpkg-gensymbols: error: some symbols or patterns disappeared in the 
symbols file: see diff output below
dpkg-gensymbols: warning: debian/libevent-2.1-7t64/DEBIAN/symbols 
doesn't match completely debian/libevent-2.1-7t64.symbols
--- debian/libevent-2.1-7t64.symbols 
(libevent-2.1-7t64_2.1.12-stable-8.1_amd64)

+++ dpkg-gensymbols7bd7o9    2024-05-17 17:36:32.466620408 +
@@ -365,7 +365,7 @@
   event_set_mem_functions@Base 2.1.8-stable
   event_sock_err@Base 2.1.8-stable
   event_sock_warn@Base 2.1.8-stable
- (arch=!musl-linux-any)event_strlcpy_@Base 2.1.8-stable
+#MISSING: 2.1.12-stable-8.1# (arch=!musl-linux-any)event_strlcpy_@Base 


Ah, looks like glibc 3.38 is in testing.

I'll apply the patch in experimental and reupload to unstable then, thanks!

/Nicolas



Bug#1070886: firefox: crashreporter crashes

2024-05-11 Thread Nicolas Patrois
Package: firefox
Version: 125.0.3-1+b1
Severity: minor
Tags: upstream

Dear Maintainer,

When I close firefox, it crashes and I see the crashreporter window.
When I send the crash report, it crashes too and I read this in the journal:

[…] kernel: crashreporter[8625]: segfault at acca6c80 ip acca6c80 sp ada0e10c
error 14 in libdbus-glib-1.so.2.3.5[ad099000+6000]
[…] kernel: Code: Unable to access opcode bytes at RIP 0xacca6c56.
[…]
[…] systemd[1]: Started systemd-coredump@8-8662-0.service - Process Core Dump
(PID 8662/UID 0).
[…]
[…] systemd-coredump[8689]: [] Process 8345 (crashreporter) of user 1000
dumped core.

 Module
libnss_myhostname.so.2 from deb systemd-255.5-1.i386
 Module libzstd.so.1 from
deb libzstd-1.5.5+dfsg2-2.i386
 Module libsystemd.so.0
from deb systemd-255.5-1.i386
 Module libblkid.so.1 from
deb util-linux-2.40-8.i386
 Module libmount.so.1 from
deb util-linux-2.40-8.i386
 Stack trace of thread
8625:
 #0  0xacca6c80 n/a
(n/a + 0x0)
 ELF object binary
architecture: Intel 80386
[…]
[…] systemd[1]: systemd-coredump@8-8662-0.service: Deactivated successfully.
[…] systemd[1]: systemd-coredump@8-8662-0.service: Consumed 2.106s CPU time.

I cut not important logs and information.

Yours,
nicolas patrois


-- Package-specific info:


-- Addons package information

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages firefox depends on:
ii  debianutils  5.17
ii  fontconfig   2.15.0-1.1
ii  libasound2t641.2.11-1+b1
ii  libatk1.0-0t64   2.52.0-1
ii  libc62.38-10
ii  libcairo-gobject21.18.0-3+b1
ii  libcairo21.18.0-3+b1
ii  libdbus-1-3  1.14.10-4+b1
ii  libevent-2.1-7t642.1.12-stable-8.1+b3
ii  libffi8  3.4.6-1
ii  libfontconfig1   2.15.0-1.1
ii  libfreetype6 2.13.2+dfsg-1+b4
ii  libgcc-s114-20240429-1
ii  libgdk-pixbuf-2.0-0  2.42.10+dfsg-3+b3
ii  libglib2.0-0t64  2.80.2-1
ii  libgtk-3-0t643.24.41-4
ii  libnspr4 2:4.35-1.1+b1
ii  libnss3  2:3.99-1
ii  libpango-1.0-0   1.52.2+ds-1
ii  libstdc++6   14-20240429-1
ii  libvpx9  1.14.0-2
ii  libx11-6 2:1.8.7-1+b1
ii  libx11-xcb1  2:1.8.7-1+b1
ii  libxcb-shm0  1.17.0-1
ii  libxcb1  1.17.0-1
ii  libxcomposite1   1:0.4.5-1+b1
ii  libxdamage1  1:1.1.6-1+b1
ii  libxext6 2:1.3.4-1+b1
ii  libxfixes3   1:6.0.0-2+b1
ii  libxrandr2   2:1.5.4-1
ii  procps   2:4.0.4-4
ii  zlib1g   1:1.3.dfsg+really1.3.1-1

Versions of packages firefox recommends:
ii  libavcodec53  7:0.10.3-dmo1
ii  libavcodec54  10:1.2.6-dmo4
ii  libavcodec55  10:2.3.3-dmo3
ii  libavcodec56  10:2.8.6-dmo2
ii  libavcodec57  10:3.4.2-dmo3
ii  libavcodec60  10:6.1.1-dmo5

Versions of packages firefox suggests:
ii  fonts-lmodern  2.005-1
ii  fonts-stix [otf-stix]  1.1.1-5
ii  libcanberra0   0.30-17
ii  libgssapi-krb5-2   1.20.1-6+b1
ii  otf-stix   1.1.1-1
ii  pulseaudio 16.1+dfsg1-5

-- no debconf information


Bug#568834: Bug#882872: First stab at functionality for copying files

2024-05-10 Thread Nicolas Schier
On Fri, May 10, 2024 at 10:52:07AM -0400, Benj. Mako Hill wrote:
> Greetings!
> 
> 
> > Your patch looks good to me and works as promised, thanks!  Before 
> > forwarding
> > it to upstream, we need an appropriate update of vidir documentation.  Are 
> > you
> > interested in preparing that?  (If not, I can do it.)
> 
> Sorry I lost track of this. Are we still waiting on documentation? If
> so, I'm happy to do this so that this can land.

yes, it would be great to have it as complete as possible, before contacting
upstream.  But please be warned that upstream ardly accepts patches that
introduce new features [1].

Kind reards,
Nicolas


[1]: https://joeyh.name/blog/entry/Volunteer_Responsibility_Amnesty_Day/


-- 
epost|xmpp: nico...@fjasle.eu  irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
 -- frykten for herren er opphav til kunnskap --


signature.asc
Description: PGP signature


Bug#1070742: firefox: No characters after ~ (0x7f) in text zones

2024-05-08 Thread Nicolas Patrois
Package: firefox
Version: 125.0.3-1
Followup-For: Bug #1070742

Dear Maintainer,

In fact, the bug is caused by the latest libglib2.0-* update.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1070736

Yours,
nicolas patrois


-- Package-specific info:


-- Addons package information

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages firefox depends on:
ii  debianutils  5.17
ii  fontconfig   2.15.0-1.1
ii  libasound2t641.2.11-1+b1
ii  libatk1.0-0t64   2.52.0-1
ii  libc62.38-8
ii  libcairo-gobject21.18.0-3+b1
ii  libcairo21.18.0-3+b1
ii  libdbus-1-3  1.14.10-4+b1
ii  libevent-2.1-7t642.1.12-stable-8.1+b3
ii  libffi8  3.4.6-1
ii  libfontconfig1   2.15.0-1.1
ii  libfreetype6 2.13.2+dfsg-1+b4
ii  libgcc-s114-20240429-1
ii  libgdk-pixbuf-2.0-0  2.42.10+dfsg-3+b3
ii  libglib2.0-0t64  2.80.0-10
ii  libgtk-3-0t643.24.41-4
ii  libnspr4 2:4.35-1.1+b1
ii  libnss3  2:3.99-1
ii  libpango-1.0-0   1.52.2+ds-1
ii  libstdc++6   14-20240429-1
ii  libvpx8  1.13.1-2+b1
ii  libx11-6 2:1.8.7-1+b1
ii  libx11-xcb1  2:1.8.7-1+b1
ii  libxcb-shm0  1.17.0-1
ii  libxcb1  1.17.0-1
ii  libxcomposite1   1:0.4.5-1+b1
ii  libxdamage1  1:1.1.6-1+b1
ii  libxext6 2:1.3.4-1+b1
ii  libxfixes3   1:6.0.0-2+b1
ii  libxrandr2   2:1.5.4-1
ii  procps   2:4.0.4-4
ii  zlib1g   1:1.3.dfsg-3.1

Versions of packages firefox recommends:
ii  libavcodec53  7:0.10.3-dmo1
ii  libavcodec54  10:1.2.6-dmo4
ii  libavcodec55  10:2.3.3-dmo3
ii  libavcodec56  10:2.8.6-dmo2
ii  libavcodec57  10:3.4.2-dmo3
ii  libavcodec60  10:6.1.1-dmo4

Versions of packages firefox suggests:
ii  fonts-lmodern  2.005-1
ii  fonts-stix [otf-stix]  1.1.1-5
ii  libcanberra0   0.30-17
ii  libgssapi-krb5-2   1.20.1-6+b1
ii  otf-stix   1.1.1-1
ii  pulseaudio 16.1+dfsg1-5

-- no debconf information



Bug#1070746: libplplotada-dev: breaks tests, must Depend: libplplot-dev

2024-05-08 Thread nicolas . boulenguez

Source: plplot
Severity: normal
Tags: patch
X-Debbugs-Cc: Graham Inggs 

Hello.
The autopkgtests are failing with
  ...gcc... -lplplotada -lplplot ...
  /usr/bin/ld: cannot find -lplplot: No such file or directory
The linker is searching for the /usr/lib/MULTIARCH/libplplot.so symbolic 
link,

but does not find it because libplplot-dev is not installed.
This was hidden before 
https://salsa.debian.org/science-team/plplot/-/commit/e62a3beaf7e3e7e6856dc4ca45f8d20df36a1671

because the test dependencies were not minimal.
So libplplotada-dev must
  Depend: libplplot-dev (= ${binary:Version})
instead of
  Depending: libplplot17 (= ${binary:Version})
  Recommending: libplplot-dev
All the best.



Bug#1070742: firefox: No characters after ~ (0x7f) in text zones

2024-05-08 Thread Nicolas Patrois
Package: firefox
Version: 125.0.3-1
Severity: important
Tags: upstream l10n

Dear Maintainer,

I restarted Firefox after a crash and now, in Firefox, I can’t write characters
whose code are > 127.
I suspect a third party library bug but as only Firefox is concerned…

Yours,
nicolas patrois

P.S.: Here are the last packages I upgraded.
# apt full-upgrade
Upgrading:
  gimplibcdio-cdda2 libglib2.0-doc
libtss2-tcti-spi-helper0t64
  gimp-data   libcdio-paranoia2 libtss2-esys-3.0.2-0t64
libtss2-tcti-swtpm0t64
  gir1.2-glib-2.0 libgimp2.0t64 libtss2-mu-4.0.1-0t64
libtss2-tctildr0t64
  gir1.2-glib-2.0-dev libgirepository-2.0-0 libtss2-rc0t64
mercurial
  gnome-shell libglib2.0-0t64   libtss2-sys1t64
mercurial-common
  gnome-shell-common  libglib2.0-binlibtss2-tcti-cmd0t64
xfsprogs
  gnome-shell-extension-prefs libglib2.0-data   libtss2-tcti-device0t64
  liballegro4.4t64libglib2.0-devlibtss2-tcti-libtpms0t64
  libass9 libglib2.0-dev-binlibtss2-tcti-mssim0t64

Installing dependencies:
  libunibreak6


-- Package-specific info:


-- Addons package information

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages firefox depends on:
ii  debianutils  5.17
ii  fontconfig   2.15.0-1.1
ii  libasound2t641.2.11-1+b1
ii  libatk1.0-0t64   2.52.0-1
ii  libc62.38-8
ii  libcairo-gobject21.18.0-3+b1
ii  libcairo21.18.0-3+b1
ii  libdbus-1-3  1.14.10-4+b1
ii  libevent-2.1-7t642.1.12-stable-8.1+b3
ii  libffi8  3.4.6-1
ii  libfontconfig1   2.15.0-1.1
ii  libfreetype6 2.13.2+dfsg-1+b4
ii  libgcc-s114-20240429-1
ii  libgdk-pixbuf-2.0-0  2.42.10+dfsg-3+b3
ii  libglib2.0-0t64  2.80.0-10
ii  libgtk-3-0t643.24.41-4
ii  libnspr4 2:4.35-1.1+b1
ii  libnss3  2:3.99-1
ii  libpango-1.0-0   1.52.2+ds-1
ii  libstdc++6   14-20240429-1
ii  libvpx8  1.13.1-2+b1
ii  libx11-6 2:1.8.7-1+b1
ii  libx11-xcb1  2:1.8.7-1+b1
ii  libxcb-shm0  1.17.0-1
ii  libxcb1  1.17.0-1
ii  libxcomposite1   1:0.4.5-1+b1
ii  libxdamage1  1:1.1.6-1+b1
ii  libxext6 2:1.3.4-1+b1
ii  libxfixes3   1:6.0.0-2+b1
ii  libxrandr2   2:1.5.4-1
ii  procps   2:4.0.4-4
ii  zlib1g   1:1.3.dfsg-3.1

Versions of packages firefox recommends:
ii  libavcodec53  7:0.10.3-dmo1
ii  libavcodec54  10:1.2.6-dmo4
ii  libavcodec55  10:2.3.3-dmo3
ii  libavcodec56  10:2.8.6-dmo2
ii  libavcodec57  10:3.4.2-dmo3
ii  libavcodec60  10:6.1.1-dmo4

Versions of packages firefox suggests:
ii  fonts-lmodern  2.005-1
ii  fonts-stix [otf-stix]  1.1.1-5
ii  libcanberra0   0.30-17
ii  libgssapi-krb5-2   1.20.1-6+b1
ii  otf-stix   1.1.1-1
ii  pulseaudio 16.1+dfsg1-5

-- no debconf information


Bug#1067285: whitakers-words in Debian, gnat-13 transition

2024-05-07 Thread Nicolas Boulenguez
Hello.
The package needs to build with gnat-13 in order to be part of next
Debian release.
Are you planning a new upload in the near future?
Else, are you OK with a non maintainer upload fixing this specific bug?



Bug#1070713: how-can-i-help: undefined local variable or method autorm_header_done

2024-05-07 Thread Nicolas Noirbent
Package: how-can-i-help
Version: 18
Severity: important
Tags: patch

Dear Maintainer,

Running how-can-i-help outputs nothing past the initial banner, due to an 
undefined variable:

```
# how-can-i-help
==  How can you help?  (doc: https://wiki.debian.org/how-can-i-help ) ==

/usr/bin/how-can-i-help:338:in `': undefined local variable or method 
`autorm_header_done' for main:Object (NameError)

autorm_header_done == 0
^^
Did you mean?  autorm_date
```

Looking at the code following it, this should probably be:

```
autorm_header_done = 0
```

Instead.

Regards,


-- System Information:
Debian Release: trixie/sid
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.7.12-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=en_US
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages how-can-i-help depends on:
ii  libruby3.1t64 [ruby-json]  3.1.2-8.3
ii  ruby   1:3.1+nmu1
ii  ruby-debian0.3.10+b10
ii  ruby-json  2.7.2+dfsg-1

how-can-i-help recommends no packages.

how-can-i-help suggests no packages.

-- no debconf information
--- /usr/bin/how-can-i-help.orig2024-05-07 19:30:22.689794285 +0200
+++ /usr/bin/how-can-i-help 2024-05-07 19:30:32.785627292 +0200
@@ -335,7 +335,7 @@
   autorm_date = Time.now.to_date + $autorm_days
   autorm = "until #{autorm_date.to_s} "
 end
-autorm_header_done == 0
+autorm_header_done = 0
 autoremoval.sort_by { |r| [r['source'], r['package']] }.each do |r|
   next if defined?($autorm_days) && Time.at(r['removal_time']).to_date > 
autorm_date
   if autorm_header_done == 0


Bug#916475: ghdl: various suggestions for the packaging

2024-05-07 Thread Nicolas Boulenguez
Source: ghdl
Followup-For: Bug #916475
Control: tags 1067446 patch
Control: tags 1067686 patch

Hello.

The attachment fixes several bugs including the release-critical one.
The build succeeds on ppc64el, although running
  neither dh_auto_test nor autopkgtests.
Debdiff only reports expected differences.

Lintian reports nothing new, but there were already two errors.
https://udd.debian.org/lintian/?packages=ghdl

0001-New-upstream-version-4.0.0-dfsg.patch
0002-New-upstream-version-4.1.0-dfsg.patch
are not attached because
* bugs.debian.org refuses heavy attachments,
* you can recreate them with
  # uscan --download-version=4.0.0
  # gbp import-orig ../ghdl_4.0.0+dfsg.orig.tar.xz
  # uscan --download-version=4.1.0
  # gbp import-orig ../ghdl_4.1.0+dfsg.orig.tar.xz
  You should get:
  Checksums-Sha1: 6f89acac3c926c9653e96e58aee6cb344ef26d4e 4862224 
ghdl_4.1.0+dfsg.orig.tar.xz
  Checksums-Sha256: 
d300c4078fa30af33cb614ff5e40f03d19e3b32eca71ca6cd1d6422c7dc40c06 4862224 
ghdl_4.1.0+dfsg.orig.tar.xz
  Files:  4da868cf483d095e014c3d3c5c7e3801 4862224 ghdl_4.1.0+dfsg.orig.tar.xz
* I have not reviewed the licenses of the new files in detail.

0003-Delegate-computation-of-Built-Using-to-dh-builtusing
0004-test-driver-move-error-reporting-to-a-separate-proce
are two commits remaining from #916475.

0006-Set-shared-object-version-to-4
0007-Build-using-GCC-13
0008-Build-using-default-LLVM-version
0010-Adapt-install-path-of-ghdl1-lib-libexec
0011-Refresh-patches-for-upstream-version-4
0012-Build-again-on-s390x-fixed-by-ghdl-4
0013-Disable-the-gcc-backend-on-risv64
0015-Apply-upstream-patch-to-fix-issues-2641-and-2642
are backported from Ubuntu.  I have split some commits, rebased, and
added information in the headers, especially the closed Debian bugs.

0005-Avoid-hardcoding-the-shared-object-version-several-t
0009-Stop-hardcoding-the-gcc-version-in-the-gcc-patches-s
0014-Standards-Version-4
0016-Add-license-paragraph-for-ghw
0017-Update-path-syntax-in-lintian-overrides
0018-Restrict-VHDL-sources-to-ASCII-encoding
0019-changelog-lintian-cleanup
0020-copyright-fix-typos-in-paths-lintian
are new suggestions. Most of them are cosmetic.

Ubuntu also ignores the build and run time tests for the llvm and
mcode backends, but as far as I understand this was only necessary
before debian/patches/fix-issue-264x.diff.


bug916475v08.tar.gz
Description: application/gzip


Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-05-07 Thread Nicolas Boulenguez
Package: dpkg-dev
Followup-For: Bug #872381

Hello.
It is good to see the main suggestion merged. Thanks!

You have not applied
  0001-scripts-mk-stop-hard-coding-dpkg_datadir.patch
probably because you prefer the related parts in
  f1175056 (build: Rework subst handling for built or installed artifacts).

Ironically, f1175056 seems to introduce the exact kind of human error
that dynamic generation would prevent.
0001-build-spare-an-unneeded-subst-handling-in-pkg-info.m.patch
>From 36e98fdd10b1896f8fa89733b5e0c1781c0cce4c Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Mon, 6 May 2024 10:52:49 +0200
Subject: [PATCH] build: spare an unneeded subst handling in pkg-info.mk

This commits follows f1175056.
---
 scripts/mk/Makefile.am | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/mk/Makefile.am b/scripts/mk/Makefile.am
index be6076b2c..5f086ef49 100644
--- a/scripts/mk/Makefile.am
+++ b/scripts/mk/Makefile.am
@@ -18,5 +18,4 @@ include $(top_srcdir)/build-aux/subst.am
 install-data-hook:
 	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/default.mk
 	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/buildtools.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/pkg-info.mk
 	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/vendor.mk
-- 
2.39.2

>From 7daa3aca068d997c6895757cb58ba91d66bd6842 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Mon, 6 May 2024 11:37:14 +0200
Subject: [PATCH] scripts/mk: stop hard-coding dpkg_datadir

This path differ during tests and after installation.  Instead of
rewriting the file with a hardcoded path, compute it within Make.
---
 build-aux/subst.am   |  8 
 scripts/mk/Makefile.am   | 10 --
 scripts/mk/buildtools.mk |  4 +++-
 scripts/mk/default.mk|  2 +-
 scripts/mk/vendor.mk |  4 +++-
 5 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/build-aux/subst.am b/build-aux/subst.am
index 7785e4af7..9c96e5ce0 100644
--- a/build-aux/subst.am
+++ b/build-aux/subst.am
@@ -45,11 +45,3 @@ SUFFIXES += .pl
 	@test -d `dirname $@` || $(MKDIR_P) `dirname $@`
 	$(AM_V_GEN) $(subst_perl_filter) <$< >$@
 	$(AM_V_at) chmod +x $@
-
-# Makefile support.
-
-subst_make_rules = "\
-	s{dpkg_datadir\s*=\s*[^\s]*}{dpkg_datadir = $(pkgdatadir)}; \
-	"
-
-subst_make_file = $(PERL) -i -p -e $(subst_make_rules)
diff --git a/scripts/mk/Makefile.am b/scripts/mk/Makefile.am
index be6076b2c..6e85e17b9 100644
--- a/scripts/mk/Makefile.am
+++ b/scripts/mk/Makefile.am
@@ -10,13 +10,3 @@ dist_pkgdata_DATA = \
 	pkg-info.mk \
 	vendor.mk \
 	# EOL
-
-SUFFIXES =
-
-include $(top_srcdir)/build-aux/subst.am
-
-install-data-hook:
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/default.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/buildtools.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/pkg-info.mk
-	$(subst_make_file) $(DESTDIR)$(pkgdatadir)/vendor.mk
diff --git a/scripts/mk/buildtools.mk b/scripts/mk/buildtools.mk
index 6ce9642cd..e93319e00 100644
--- a/scripts/mk/buildtools.mk
+++ b/scripts/mk/buildtools.mk
@@ -28,7 +28,9 @@
 ifndef dpkg_buildtools_mk_included
 dpkg_buildtools_mk_included = yes
 
-dpkg_datadir = $(srcdir)/mk
+ifndef dpkg_datadir
+  dpkg_datadir := $(patsubst %/buildtools.mk,%,$(lastword $(MAKEFILE_LIST)))
+endif
 include $(dpkg_datadir)/architecture.mk
 
 # We set the TOOL_FOR_BUILD variables to the specified value, and the TOOL
diff --git a/scripts/mk/default.mk b/scripts/mk/default.mk
index c4e408b01..e1b81 100644
--- a/scripts/mk/default.mk
+++ b/scripts/mk/default.mk
@@ -4,7 +4,7 @@
 ifndef dpkg_default_mk_included
 dpkg_default_mk_included = yes
 
-dpkg_datadir = $(srcdir)/mk
+dpkg_datadir := $(patsubst %/default.mk,%,$(lastword $(MAKEFILE_LIST)))
 include $(dpkg_datadir)/architecture.mk
 include $(dpkg_datadir)/buildapi.mk
 ifeq ($(call dpkg_build_api_ge,1),yes)
diff --git a/scripts/mk/vendor.mk b/scripts/mk/vendor.mk
index 746503a33..3cd1eed3e 100644
--- a/scripts/mk/vendor.mk
+++ b/scripts/mk/vendor.mk
@@ -36,7 +36,9 @@
 ifndef dpkg_vendor_mk_included
 dpkg_vendor_mk_included = yes
 
-dpkg_datadir = $(srcdir)/mk
+ifndef dpkg_datadir
+  dpkg_datadir := $(patsubst %/vendor.mk,%,$(lastword $(MAKEFILE_LIST)))
+endif
 include $(dpkg_datadir)/buildapi.mk
 
 dpkg_lazy_eval ?= $(eval $(1) = $(2)$$($(1)))
-- 
2.39.2



Bug#1067320: topal: FTBFS: debian/rules: debian_packaging.mk: No such file or directory

2024-05-04 Thread Nicolas Boulenguez
Source: topal
Followup-For: Bug #1067320
Control: tag -1 + patch

Hello.
Attachment 002 below fixes this bug.
Would you be OK with a non maintainer upload?

The other attachments are unrelated sugestions.
Would you be OK with a salsa.debian.org/debian/topal git repository?


PATH 1/10  updates the upstream part to version 82.


>From 31c2f14e91e2a01c75eb1309f17ea540ffb80571 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Sat, 3 Dec 2022 18:56:23 +0100
Subject: [PATCH 02/10] Switch to dh-ada-library >= 8.2 for packaging.mk

---
 debian/control | 1 +
 debian/rules   | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index be7984d..53206e5 100644
--- a/debian/control
+++ b/debian/control
@@ -4,6 +4,7 @@ Priority: optional
 Maintainer: Phil Brooke 
 Build-Depends:
  debhelper-compat (= 13),
+ dh-ada-library (>= 8.2),
  gnat (>= 11),
  libreadline-dev,
  texlive,
diff --git a/debian/rules b/debian/rules
index cdd07e4..d3e38d5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,8 +4,7 @@
 
 DEB_BUILD_MAINT_OPTIONS := hardening=+all
 include /usr/share/dpkg/buildflags.mk
-include /usr/share/dpkg/buildopts.mk
-include /usr/share/ada/debian_packaging.mk
+include /usr/share/ada/packaging.mk
 
 # Compile Ada and C with the same compiler.
 CC := gnatgcc
-- 
2.39.2


>From a9e088d51c8f95a9e7cd60bee7e31f9e167834ed Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Sat, 3 Dec 2022 18:57:35 +0100
Subject: [PATCH 03/10] Set CC from gnat version without the deprecated gnatgcc
 symbolic link

gcc-$MAJOR is also specific to Debian, but not to Ada.
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index d3e38d5..b29f0ea 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,7 +7,7 @@ include /usr/share/dpkg/buildflags.mk
 include /usr/share/ada/packaging.mk
 
 # Compile Ada and C with the same compiler.
-CC := gnatgcc
+CC := gcc-$(DEB_GNAT_VERSION)
 
 # Upstream Makefile insists on rebuilding everything everytime.
 # SOURCE_DATE_EPOCH (set by debhelper) and the -m gnatmake option may
-- 
2.39.2


>From 6a3416662d4142d461f6c59bdaca4c3e495f59ff Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Wed, 20 Jul 2022 14:56:41 +0200
Subject: [PATCH 04/10] Drop full texlive from build dependencies

It was now redundant with more specific dependencies.
---
 debian/control | 1 -
 1 file changed, 1 deletion(-)

diff --git a/debian/control b/debian/control
index 53206e5..5669b2f 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,6 @@ Build-Depends:
  dh-ada-library (>= 8.2),
  gnat (>= 11),
  libreadline-dev,
- texlive,
  texlive-latex-base,
  texlive-latex-extra,
  texlive-fonts-recommended,
-- 
2.39.2


>From 2946bec7938ae412ac7cf632a2f2982a6b79355d Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Wed, 20 Jul 2022 14:57:05 +0200
Subject: [PATCH 05/10] Sort build dependencies

Dpkg supports the extra comma exactly for this purpose.
---
 debian/control | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 5669b2f..00262aa 100644
--- a/debian/control
+++ b/debian/control
@@ -7,10 +7,10 @@ Build-Depends:
  dh-ada-library (>= 8.2),
  gnat (>= 11),
  libreadline-dev,
+ texlive-fonts-extra,
+ texlive-fonts-recommended,
  texlive-latex-base,
  texlive-latex-extra,
- texlive-fonts-recommended,
- texlive-fonts-extra
 Standards-Version: 4.6.1
 Rules-Requires-Root: no
 Homepage: https://www.zircon.org.uk/topal/
-- 
2.39.2


>From acb27a97b77357e5a17617c778119151161468de Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Sat, 3 Dec 2022 19:18:57 +0100
Subject: [PATCH 06/10] Remove some trailing whitespaces

---
 debian/changelog | 1 -
 debian/rules | 1 -
 2 files changed, 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 03c854b..ba63f7a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -290,4 +290,3 @@ topal (0.6.4-1) unstable; urgency=low
   * Initial Release (closes: #143319).
 
  -- Phil Brooke   Sun, 21 Apr 2002 14:29:05 +
-
diff --git a/debian/rules b/debian/rules
index b29f0ea..c8539a8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -37,4 +37,3 @@ override_dh_auto_install:
 .PHONY: override_dh_installchangelogs
 override_dh_installchangelogs:
dh_installchangelogs Changelog.html
-
-- 
2.39.2


>From 6934d431d7d4efde5a7a2e2095e879d6488a083d Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Sun, 27 Aug 2023 14:03:48 +0200
Subject: [PATCH 07/10] Bump Standards-Version

---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 00262aa..abc38ee 100644
--- a/debian/control
+++ b/debian/control
@@ -11,7 +11,7 @@ Build-Depends:
  texlive-fonts-recommended,
  texlive-latex-base,
  texlive-latex-extra,
-Standards-Version: 4.6.1
+Standards-Version: 4.7.0
 Rules-Requires-Root: no
 Ho

Bug#1069984: alire: Build-depends on NBS package libgnatcoll21-dev

2024-05-04 Thread Nicolas Boulenguez
Source: alire
Followup-For: Bug #1069984

Hello.

This bug is already fixed in 1.2.1-1.1.
The ideal way to close a bug is usually in debian/changelog, but this
bug was open after its fix has been uploaded to experimental,
so you should probably close it as described at
https://www.debian.org/Bugs/Developer#closing
with a mail to 1069984-d...@bugs.debian.org starting with
Version: 1.2.1-1.1

The 'debian/ 1.2.1-2' tag is only informative, it triggers no actual
upload.
However, its current contents are incorrect.
debian/changelog contains the same version twice.
Please fix this, then I will sponsor an upload and you will tag the
uploaded state as 'debian/1.2.1-2+really'.



Bug#1065309: transition: gnat (12 -> 13 + time_t64)

2024-05-04 Thread Nicolas Boulenguez
Package: release.debian.org
Followup-For: Bug #1065309

Hello.

For some reason, some rebuilds succeeded without a +b1 version.
Their reverse dependencies is dep-waiting on the +b1 version.
Please cancel three dep-wait restrictions.

gb libgnatcoll-db_23.0.0-6   . armel powerpc . -o
gb libgnatcoll-bindings_24.0.0-2 . armhf . -o



Bug#1067285: whitakers-words: FTBFS: make[2]: *** [Makefile:40: commands] Error 4

2024-05-03 Thread Nicolas Boulenguez
Source: whitakers-words
Followup-For: Bug #1067285

Hello.
This failure is caused by new compiler warnings, either because of the
switch to gnat-13 or because of changes in Debian options.
Anyway, I suggest to add the following two lines in debian/rules,
somewhere before the inclusion of /usr/share/*.mk.

# Disable the -gnatwe upstream flags during Debian builds.
DEB_ADAFLAGS_MAINT_APPEND := -gnatwn



Bug#1070161: ITS: ramond

2024-05-01 Thread Nicolas Dandrimont
On Wed, May 1, 2024, at 04:50, Boyuan Yang wrote:
> Source: ramond
> Version: 0.5-4.2
> Severity: important
> Tags: sid trixie
> X-Debbugs-CC: nicolas.dandrim...@crans.org
>
> Dear package ramond maintainer in Debian,
>
> After looking into the package you maintain (ramond, 
> https://tracker.debian.org/pkg/ramond), I found that this package
> received no maintainer updates in the past 12 years and is not in good
> shape. As a result, I am filing an ITS (Intent to Salvage) request
> against your package to take over package maintenance according to
> section 5.12 in Debian's Developers' Reference [1].
>
> [...]

Hi,

Thank you for picking up this package. You should feel free to go ahead with 
immediate adoption[1].

[1] https://wiki.debian.org/LowThresholdAdoption

In this day and age, most managed switches are able to block unwanted IPv6 
router advertisements, so before spending much effort on a project that, last I 
checked, was dormant upstream, you should assess whether ramond is still 
relevant.

Thanks again,
-- 
Nicolas Dandrimont



Bug#1065309: transition: gnat (12 -> 13 + time_t64)

2024-04-30 Thread Nicolas Boulenguez
Package: release.debian.org
Followup-For: Bug #1065309

Hello.

The time_t64 transition has triggered #1067453 in the Ada compiler,
which is now fixed by gcc-13/13.2.0-24.

The patch modifies the sources of the Ada standard library, so most
Ada packages need a rebuild in order to update their dependencies
(gnat-13  Provides: gnat-13-HASH
 each Ada library Provides: libFOO-dev-HASH
 and each consumer Depends: gnat-13-HASH, libFOO-HASH).

Please schedule the following rebuilds.

nmu adacgi_1.6-34 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067070.'
dw  adacgi_1.6-34 . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu adasockets_1.14-1 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.'
dw  adasockets_1.14-1 . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu ahven_2.8.9   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067224, #1069469.'
dw  ahven_2.8.9   . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu libaunit_24.0.0-2 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067071.'
dw  libaunit_24.0.0-2 . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu libgmpada_1.6-2   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.'
dw  libgmpada_1.6-2   . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu libncursesada_6.3.20211021-11 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067073.'
dw  libncursesada_6.3.20211021-11 . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu libtexttools_2.1.0-28 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1069476.'
dw  libtexttools_2.1.0-28 . ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu libxmlada_24.0.0-2. ANY . -m 'Rebuild with #1067453 fixed in 
gnat'
dw  libxmlada_24.0.0-2. ANY . -m 'gnat-13 (>= 13.2.0-24)'
nmu libxmlezout_1.06.2-14 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067220.'
dw  libxmlezout_1.06.2-14 . ANY . -m 'gnat-13 (>= 13.2.0-24)'

nmu liblog4ada_1.3.1.b6dafb49-13  . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067074.'
dw  liblog4ada_1.3.1.b6dafb49-13  . ANY . -m 'libxmezout-dev (>= 1.06.2-14+b1)'

nmu anet_0.5.0-3  . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1067353.'
dw  anet_0.5.0-3  . ANY . -m 'libahven-dev (>= 2.8.9+b1)'
nmu dbusada_0.6.2-6   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1069421.'
dw  dbusada_0.6-2-6   . ANY . -m 'libahven-dev (>= 2.8.9+b1)'
nmu libalog_0.6.2-5   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1069454.'
dw  libalog_0.6.2-5   . ANY . -m 'libahven-dev (>= 2.8.9+b1)'
nmu pcscada_0.7.7-6   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1069468.'
dw  pcscada_0.7.7-6   . ANY . -m 'libahven-dev (>= 2.8.9+b1)'

nmu libtemplates-parser_24.0.0-2  . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.'
dw  libtemplates-parser_24.0.0-2  . ANY . -m 'libxmlada-unicode-dev (>= 
24.0.0-2+b1)'
nmu gprbuild_2024.1.20231009-4. ANY . -m 'Rebuild with #1067453 fixed in 
gnat.  Closes: #1069467.'
dw  gprbuild_2024.1.20231009-4. ANY . -m 'libxmlada-unicode-dev (>= 
24.0.0-2+b1)'

nmu libgnatcoll_24.1.20230921-4   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.'
dw  libgnatcoll_24.1.20230921-4   . ANY . -m 'libgnatprj-dev (>= 
2024.1.20231009-4+b1)'

nmu libgnatcoll-bindings_24.0.0-2 . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.'
dw  libgnatcoll-bindings_24.0.0-2 . ANY . -m 'libgnatcoll-dev (>= 
24.1.20230921-4+b1)'

nmu libgnatcoll-db_23.0.0-6   . ANY . -m 'Rebuild with #1067453 fixed in 
gnat.'
dw  libgnatcoll-db_23.0.0-6   . ANY . -m 'libgnatcoll-iconv-dev (>= 
24.0.0-2+b1)'

The   alire libflorist libgtkada plplot   packages are also affected
but require a normal upload for other reasons anyway.

Thanks.



Bug#1067453: gnat: Ada.Calendar.Clock crashes on time_t64 architectures

2024-04-25 Thread Nicolas Boulenguez
Source: gcc-13
Followup-For: Bug #1067453

The gettimeofday import issue seems specific to the time_t 64
transition in Debian.

When building C on armhf, a #define replaces gettimeofday with
__gettimeofday64 so the linker finds the 64 bits version in the libc.

When linking Ada code, the linker searches for the gettimeofday symbol
and links with the 32 bits version, as demonstrated by the reproducer
script below.  Here is the output.

./c_part
 timeval size: 128
 tv_sec   offset: 0   size: 64   value: 662A7756
 tv_usec   offset: 8   size: 64   value: 1C54
 56 77 2A 66 00 00 00 00 54 1C 00 00 00 00 00 00
./ada_part
 timeval size: 128
  tv_sec offset: 0   size: 64   value:16#27A9662A7756#
  tv_usec offset: 8   size: 64 value:-16#80B1C0708345E00#
 56 77 2A 66 A9 27 00 00 00 A2 CB F7 F8 E3 F4 F7

Changing the External_Name from "gettimeofday" to "__gettimeofday64"
fixes the mismatch (except for the lower microseconds of course).

./c_part
 81 76 2A 66 00 00 00 00 0F E2 0C 00 00 00 00 00
./ada_part
 81 76 2A 66 00 00 00 00 CB EC 0C 00 00 00 00 00

So we have two possible work-arounds.

 * build a C source with a __gnat_gettimeofday wrapper.
   This option, implemented by my last commit, patches
 gcc/ada/Makefile.rtl
 gcc/ada/cal.c
 gcc/ada/gcc-interface/Makefile.in
 gcc/ada/libgnat-s-osprim__posix.adb
   and interfers with the previous commit.

 * simply patch gcc/ada/libgnat/s-osprim__posix.adb with
-  pragma Import (C, gettimeofday, "gettimeofday");
+  pragma Import (C, gettimeofday, "__gettimeofday64");
  This seems better, but must only be applied on targets affected by
  the t64 transition.

I do not know which one is the best, but at least the second one
explains why the first one did work.

Just in case, here is the reproducer script:

--
#!/bin/sh
set -efuv

cat > hexdump.h < hexdump.c <
#include "hexdump.h"
void hexdump(char* p, int length)
{
  while (length--)
  {
printf(" %02hhX", *p++);
  }
  printf("\n");
}
EOF

cat > c_part.c <
#include 
#include 
#include 
#include "hexdump.h"
int main(int argc, const char* argv[]) {
  struct timeval tv;
  if (argc == 1)
  {
printf(" gettimeofday returned %i\n", gettimeofday(, NULL));
printf(" timeval size: %lli\n", (long long int)( CHAR_BIT * sizeof(tv)));
printf(" tv_sec");
printf("   offset: %lli", (long long int)((char*)(&(tv.tv_sec)) - 
(char*)()));
printf("   size: %lli",   (long long int)(CHAR_BIT * sizeof(tv.tv_sec)));
printf("   value: %llX",  (long long int)tv.tv_sec);
printf("\n");
printf(" tv_usec");
printf("   offset: %lli", (long long int)((char*)(&(tv.tv_usec)) - 
(char*)()));
printf("   size: %lli",   (long long int)(CHAR_BIT * sizeof(tv.tv_usec)));
printf("   value: %llX",  (long long int)tv.tv_usec);
printf("\n");
hexdump((char*)(), sizeof(tv));
  }
  else
  {
printf("   time_t_bits  : constant := %lli;\n",
   (long long int)(CHAR_BIT * sizeof(tv.tv_sec)));
printf("   suseconds_t_bits : constant := %lli;\n",
   (long long int)( CHAR_BIT * sizeof(tv.tv_usec)));
  }
  return EXIT_SUCCESS;
}
EOF

cat > ada_part.adb < C;
   type suseconds_t is range -2**(suseconds_t_bits - 1) ..
  2**(suseconds_t_bits - 1) - 1
 with Convention => C;
   type timeval is record
  tv_sec  : time_t;
  tv_usec : suseconds_t;
   end record with Convention => C;
   function gettimeofday (tv : access timeval; tz : Address) return int
 with Import, Convention => C,
  External_Name => "gettimeofday"; --  Here
   Tv : aliased timeval;
   function Offset (A, B : Address) return String is
 (Long_Long_Integer'Image (Long_Long_Integer'Value (A'Img)
 - Long_Long_Integer'Value (B'Img)));
   I : constant int := gettimeofday(Tv'Access, Null_Address);
   procedure hexdump(p : Address; count : Integer)
 with Import, Convention => C, External_Name => "hexdump";
begin
  Put_Line (" gettimeofday returned" & I'Img);
  Put_Line (" timeval size:" & Integer'Image (Tv'Size));
  Put ("  tv_sec offset:" & Offset (Tv.tv_sec'Address, Tv'Address)
   & "   size:" & Integer'Image (Tv.tv_sec'Size)
   & "   value:");
  Put (Long_Long_Integer (Tv.tv_sec), Width => 0, Base => 16);
  New_Line;
  Put ("  tv_usec offset:" & Offset (Tv.tv_usec'Address, Tv'Address)
   & "   size:" & Integer'Image (Tv.tv_usec'Size)
   & " value:");
  Put (Long_Long_Integer (Tv.tv_usec), Width => 0, Base => 16);
  New_Line;
  hexdump (Tv'Address, Tv'Size / 8);
end Ada_Part;
EOF

gcc -c -Wall -Wextra hexdump.c -o hexdump.o
gcc -Wall -Wextra c_part.c hexdump.o -o c_part
gnatmake -gnat2022 -gnatwa -gnatya ada_part.adb -largs hexdump.o

./c_part
./ada_part



Bug#1069811: python-asyncssh: Please disable cryptography warnings during import

2024-04-25 Thread Nicolas Schier
Package: python3-asyncssh
Version: 2.10.1-2
Severity: minor

Dear Maintainer,

please backport upstream commit 40da3934ef7b041 ("Hide cryptography
37.0.0 deprecation warnings").

Importing asyncssh on a current trixie system results in warnings

$ python3 -c 'import asyncssh'
/usr/lib/python3/dist-packages/asyncssh/crypto/cipher.py:29: 
CryptographyDeprecationWarning: Blowfish has been deprecated and will be 
removed in a future release
  from cryptography.hazmat.primitives.ciphers.algorithms import Blowfish, 
CAST5
/usr/lib/python3/dist-packages/asyncssh/crypto/cipher.py:29: 
CryptographyDeprecationWarning: CAST5 has been deprecated and will be removed 
in a future release
  from cryptography.hazmat.primitives.ciphers.algorithms import Blowfish, 
CAST5
/usr/lib/python3/dist-packages/asyncssh/crypto/cipher.py:30: 
CryptographyDeprecationWarning: SEED has been deprecated and will be removed in 
a future release
  from cryptography.hazmat.primitives.ciphers.algorithms import SEED, 
TripleDES

Upstream has disabled the warnings in a newer version explicitly.  Can you
please add/backport the patch to the Debian package?

For convenience I am going to prepare a merge-request on salsa.

Thanks and kind regards,
Nicolas


-- System Information:
Debian Release: trixie/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 
'oldstable-updates'), (500, 'oldstable-security'), (500, 'unstable'), (500, 
'testing'), (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.15-amd64 (SMP w/24 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
C.UTF-8), LANGUAGE=C
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages python3-asyncssh depends on:
ii  python33.11.8-1
ii  python3-cryptography   42.0.5-2
ii  python3-typing-extensions  4.4.0-1

Versions of packages python3-asyncssh recommends:
ii  python-asyncssh-doc  2.10.1-2
ii  python3-bcrypt   3.2.2-1

python3-asyncssh suggests no packages.

-- no debconf information



Bug#1057107: bullseye-pu: package libssh2/1.9.0-2

2024-04-22 Thread Nicolas Mora

Le 2024-04-22 à 13 h 08, Jonathan Wiltshire a écrit :


Please go ahead.


Thanks, it's uploaded



Bug#632490: libevent-dev: namespace polution (#define-s _GNU_SOURCE)

2024-04-18 Thread Nicolas Mora

Hello,

I took over the package for libevent and I'm wondering if this bug is 
still relevant.


The bug hasn't received any update for more than 12 years so it may be 
outdated now.


https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632490

/Nicolas



Bug#638359: libevent-1.4-2: Add Hip-Hop patches

2024-04-18 Thread Nicolas Mora

Hello,

I'm digging up old bugs on this package to clear them if possible.

This one looks not relevant anymore:
- it's about an old version
- the last message was over 13 years ago

Unless someone objects, I'll simply close it in the next days/weeks

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638359

/Nicolas



Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-04-10 Thread Nicolas Boulenguez
The attached version
fixes the spacing issue in tests with a more readable trick,
splits the changes inside tests into small chunks,
replaces - with _ in Make variable names,
avoids non portable -r -E sed options.

Without -r, sed in {buildflags,pkg-info}.mk should cause no
regression.  It has been present in pkg-info.mk since 2011.
>From 5b3d75fb604dae497406f19073d03ea094da8d07 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Wed, 10 Apr 2024 00:41:42 +0200
Subject: [PATCH 01/10] scripts/t/mk/buildflags.mk: fix test of _MAINT_APPEND
 when TEST_ is empty

When TEST_CPPFLAGS is empty, the right hand side of the comparison
starts with a space character.
---
 scripts/t/mk/buildflags.mk | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/t/mk/buildflags.mk b/scripts/t/mk/buildflags.mk
index 94d85a7e0..7cf798f73 100644
--- a/scripts/t/mk/buildflags.mk
+++ b/scripts/t/mk/buildflags.mk
@@ -1,5 +1,8 @@
 DEB_CPPFLAGS_MAINT_APPEND = -DTEST_MK=test-host
+TEST_CPPFLAGS+= -DTEST_MK=test-host
+
 DEB_CPPFLAGS_FOR_BUILD_MAINT_APPEND = -DTEST_MK=test-build
+TEST_CPPFLAGS_FOR_BUILD+= -DTEST_MK=test-build
 
 include $(srcdir)/mk/buildflags.mk
 
@@ -8,8 +11,8 @@ test:
 	test "$(ASFLAGS_FOR_BUILD)" = "$(TEST_ASFLAGS_FOR_BUILD)"
 	test "$(CFLAGS)" = "$(TEST_CFLAGS)"
 	test "$(CFLAGS_FOR_BUILD)" = "$(TEST_CFLAGS_FOR_BUILD)"
-	test "$(CPPFLAGS)" = "$(TEST_CPPFLAGS) -DTEST_MK=test-host"
-	test "$(CPPFLAGS_FOR_BUILD)" = "$(TEST_CPPFLAGS_FOR_BUILD)-DTEST_MK=test-build"
+	test "$(CPPFLAGS)" = "$(TEST_CPPFLAGS)"
+	test "$(CPPFLAGS_FOR_BUILD)" = "$(TEST_CXXFLAGS_FOR_BUILD)"
 	test "$(CXXFLAGS)" = "$(TEST_CXXFLAGS)"
 	test "$(CXXFLAGS_FOR_BUILD)" = "$(TEST_CXXFLAGS_FOR_BUILD)"
 	test "$(DFLAGS)" = "$(TEST_DFLAGS)"
-- 
2.39.2

>From 53aeebafeb2af84369df3b7d81ff1cbcc1e13a9d Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Wed, 10 Apr 2024 00:09:43 +0200
Subject: [PATCH 02/10] scripts/t/mk: use loops instead of repetitions

---
 scripts/t/mk/architecture.mk | 54 +---
 scripts/t/mk/buildflags.mk   | 39 --
 scripts/t/mk/buildtools.mk   | 54 +++-
 3 files changed, 61 insertions(+), 86 deletions(-)

diff --git a/scripts/t/mk/architecture.mk b/scripts/t/mk/architecture.mk
index 2ac0222ca..b146f34b7 100644
--- a/scripts/t/mk/architecture.mk
+++ b/scripts/t/mk/architecture.mk
@@ -1,36 +1,22 @@
 include $(srcdir)/mk/architecture.mk
 
-test:
-	test "$(DEB_BUILD_ARCH)" = "$(TEST_DEB_BUILD_ARCH)"
-	test "$(DEB_BUILD_ARCH_ABI)" = "$(TEST_DEB_BUILD_ARCH_ABI)"
-	test "$(DEB_BUILD_ARCH_BITS)" = "$(TEST_DEB_BUILD_ARCH_BITS)"
-	test "$(DEB_BUILD_ARCH_CPU)" = "$(TEST_DEB_BUILD_ARCH_CPU)"
-	test "$(DEB_BUILD_ARCH_ENDIAN)" = "$(TEST_DEB_BUILD_ARCH_ENDIAN)"
-	test "$(DEB_BUILD_ARCH_LIBC)" = "$(TEST_DEB_BUILD_ARCH_LIBC)"
-	test "$(DEB_BUILD_ARCH_OS)" = "$(TEST_DEB_BUILD_ARCH_OS)"
-	test "$(DEB_BUILD_GNU_CPU)" = "$(TEST_DEB_BUILD_GNU_CPU)"
-	test "$(DEB_BUILD_GNU_SYSTEM)" = "$(TEST_DEB_BUILD_GNU_SYSTEM)"
-	test "$(DEB_BUILD_GNU_TYPE)" = "$(TEST_DEB_BUILD_GNU_TYPE)"
-	test "$(DEB_BUILD_MULTIARCH)" = "$(TEST_DEB_BUILD_MULTIARCH)"
-	test "$(DEB_HOST_ARCH)" = "$(TEST_DEB_HOST_ARCH)"
-	test "$(DEB_HOST_ARCH_ABI)" = "$(TEST_DEB_HOST_ARCH_ABI)"
-	test "$(DEB_HOST_ARCH_BITS)" = "$(TEST_DEB_HOST_ARCH_BITS)"
-	test "$(DEB_HOST_ARCH_CPU)" = "$(TEST_DEB_HOST_ARCH_CPU)"
-	test "$(DEB_HOST_ARCH_ENDIAN)" = "$(TEST_DEB_HOST_ARCH_ENDIAN)"
-	test "$(DEB_HOST_ARCH_LIBC)" = "$(TEST_DEB_HOST_ARCH_LIBC)"
-	test "$(DEB_HOST_ARCH_OS)" = "$(TEST_DEB_HOST_ARCH_OS)"
-	test "$(DEB_HOST_GNU_CPU)" = "$(TEST_DEB_HOST_GNU_CPU)"
-	test "$(DEB_HOST_GNU_SYSTEM)" = "$(TEST_DEB_HOST_GNU_SYSTEM)"
-	test "$(DEB_HOST_GNU_TYPE)" = "$(TEST_DEB_HOST_GNU_TYPE)"
-	test "$(DEB_HOST_MULTIARCH)" = "$(TEST_DEB_HOST_MULTIARCH)"
-	test "$(DEB_TARGET_ARCH)" = "$(TEST_DEB_TARGET_ARCH)"
-	test "$(DEB_TARGET_ARCH_ABI)" = "$(TEST_DEB_TARGET_ARCH_ABI)"
-	test "$(DEB_TARGET_ARCH_BITS)" = "$(TEST_DEB_TARGET_ARCH_BITS)"
-	test "$(DEB_TARGET_ARCH_CPU)" = "$(TEST_DEB_TARGET_ARCH_CPU)"
-	test "$(DEB_TARGET_ARCH_ENDIAN)" = "$(TEST_DEB_TARGET_ARCH_ENDIAN)"
-	test "$(DEB_TARGET_ARCH_LIBC)" = "$(TEST_DEB_TARGET_ARCH_LIBC)&q

Bug#1056936: bookworm-pu: package glewlwyd/2.7.5-3

2024-04-07 Thread Nicolas Mora

Le 2024-04-06 à 18 h 38, Jonathan Wiltshire a écrit :


Sorry for the delay; please go ahead.


Thanks, it's uploaded!

/Nicolas



Bug#1068076: libssh2: FTBFS on hurd-any

2024-04-07 Thread Nicolas Mora

Hello,

On Sat, 30 Mar 2024 09:55:07 +0100 Mattias Ellert 
 wrote:


The package fails to build on hurd due to the use of MAXPATHEN:

session_fixture.c:231:36: error: ‘MAXPATHLEN’ undeclared (first use in
this function)
  231 | static char filepath[NUMPATHS][MAXPATHLEN];
  |^~

PATH_MAX and MAXPATHLEN are on purpose not defined on hurd.



I think the best way is to forward to upstream.

Are there any alternatives to MAXPATHLEN on Hurd or any workaround you 
know of?


/Nicolas



Bug#1067453: gnat: Ada.Calendar.Clock crashes on time_t64 architectures

2024-04-06 Thread Nicolas Boulenguez
Source: gcc-13
Followup-For: Bug #1067453

Sorry for the poor summary. Here is what I have built and tested.
 * native build on ppc46el (not amd64)
 * gcc-source 13.2.0-19 from Debian
 * libgnat-timet64.diff unapplied
   (pr114065-proposed.diff should be unapplied for -20 and later)
 * commits 1/8 to 8/8 from bug114065attempt3.tar.gz applied
   (Debian only needs 1-3, 4-8 should only affect style).
 * ada-lib-info-source-date-epoch.diff adapted as described in #1067453
   (disabling it for a while is also an option)
 * debian/rules binary-arch

cat > demo.adb <

Bug#1067453: gnat: Ada.Calendar.Clock crashes on time_t64 architectures

2024-04-05 Thread Nicolas Boulenguez
Source: gcc-13
Followup-For: Bug #1067453

Hello.

In case anyone tries to build attempt3 at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114065
in Debian, please:
 * disable debian/patches/libgnat-time64.diff in debian/rules.patch
 * adapt the current ada-lib-info-source-date-epoch.diff

--- a/debian/patches/ada-lib-info-source-date-epoch.diff
+++ b/debian/patches/ada-lib-info-source-date-epoch.diff
@@ -62,24 +62,26 @@ Author: Nicolas Boulenguez 
 end File_Stamp;
  
 function File_Stamp (Name : Path_Name_Type) return Time_Stamp_Type is
-@@ -3261,4 +3276,28 @@ begin
+@@ -3261,4 +3276,30 @@ begin
Osint.Initialize;
 end Initialization;
  
 +   Set_Source_Date_Epoch : declare
++  --  See comments in OS_Time_To_GNAT_Time.
++  use type CRTL.int64;
++  function To_Ada is new Ada.Unchecked_Conversion (CRTL.int64, OS_Time);
 +  Env_Var : String_Access := Getenv ("SOURCE_DATE_EPOCH");
-+  Epoch   : time_t range 0 .. time_t'Last := 0;
-+  Digit   : time_t range 0 .. 9;
++  Epoch   : CRTL.int64 range 0 .. CRTL.int64'Last := 0;
++  Digit   : CRTL.int64 range 0 .. 9;
 +   begin
 +  if 0 < Env_Var.all'Length then
 + --  Calling System.Val_LLI breaks the bootstrap sequence.
-+ --  First convert to time_t because OS_Time is private.
 + for C of Env_Var.all loop
 +if C not in '0' .. '9' then
 +   goto Finally;
 +end if;
-+Digit := time_t (Character'Pos (C) - Character'Pos ('0'));
-+if (time_t'Last - Digit) / 10 < Epoch then
++Digit := CRTL.int64 (Character'Pos (C) - Character'Pos ('0'));
++if (CRTL.int64'Last - Digit) / 10 < Epoch then
 +   goto Finally;
 +end if;
 +Epoch := Epoch * 10 + Digit;



Bug#1067242: dh-builtusing: Broken "Built-Using" field with architecture-specific invocations

2024-03-29 Thread Nicolas Boulenguez
> > On armel, the control files correctly contain no Built-Using field.

> I have not noticed the issues on armel, just armhf (with 0.0.5 or 0.0.6)
> and arm64 (with 0.0.6).

I have tried again on an armhf porterbox, all works as expected.

> > Could you please describe your build environment?

> I use sbuild with unshare chroot mode...

Thanks for the explanations.  If I understand correctly, sbuild needs
root permissions at least to create the chroot, so I cannot run it on
a porterbox.

Can you please try
# dh_builtusing -v
# cat debian/*.substvars
This should work in a clean source tree,  without spending time building.
(arm64 or armhf, the symptoms differ but the cause seems the same)

The expected output on armhf is:
In package u-boot-sunxi, substvar dh-builtusing:arm-trusted-firmware += 
disabled-by-restriction
In package u-boot-sunxi, substvar dh-builtusing:crust-firmware += 
disabled-by-restriction
In package u-boot-rockchip, substvar dh-builtusing:arm-trusted-firmware 
+= disabled-by-restriction
dh-builtusing:arm-trusted-firmware=disabled-by-restriction (= 0)
dh-builtusing:arm-trusted-firmware=disabled-by-restriction (= 0)
dh-builtusing:crust-firmware=disabled-by-restriction (= 0)



Bug#1067242: dh-builtusing: Broken "Built-Using" field with architecture-specific invocations

2024-03-24 Thread nicolas . boulenguez

Hello.
I failed to reproduce the issue on a porterbox.

On arm64:
# dpkg-source -x u-boot_2024.01+dfsg-3.dsc
# cd u-boot_2024.01+dfsg
# patch -p1 < ../b8d394100d6f858c0e80786f7087f96c11d698c3.diff
# DEB_BUILD_PROFILES='pkg.uboot.notools 
pkg.uboot.platform.a64-olinuxino' fake\

root debian/rules binary-arch
dpkg-gencontrol writes no warning
debian/u-boot-{rockchip,sunxi}/DEBIAN/control contain the expected 
Built-Using\

 fields

On armel, the control files correctly contain no Built-Using field.

Could you please describe your build environment?

Bug#1051098: suggestion: dh-builtusing may simplify the packaging

2024-03-21 Thread Nicolas Boulenguez
Hello.

> About to upload a version reverting this change to fix build failure on
> armhf.
> 
> Removing the patch flag, as the patch does not quite work correctly.
> 
> Also filed a bug on dh-builtusing about this:
> 
>   https://bugs.debian.org/1067242
> 
> I look forward to an improved dh-builtusing and patch for u-boot! :)

Thanks for reporting.

Dh-builtusing/0.0.6 adds a regression test reporting this bug, and
fixes it.

Variables disabled by a restriction now receive a dummy but valid
value, so that dpkg-gencontrol can parse the expansion (then ignore
the dummy value).

For u-boot, no patch is necessary.  Just revert the reversal :-)



Bug#1067453: gnat: Ada.Calendar.Clock crashes on time_t64 architectures

2024-03-21 Thread Nicolas Boulenguez
Package: gnat-13
Version: 13.2.0-19
Severity: normal
X-Debbugs-Cc: lbre...@debian.org
Control: affects -1 pcscada libalog dbusada anet ahven libgmpada libgtkada 
libgnatcoll-db libncursesada libaunit adacgi liblog4ada libtexttools 
libtemplates-parser libxmlezout libgnatcoll-bindings libgnatcoll gprbuild

Hello.

Most Ada packages randomly FTBFS on 32 bit architectures with
gprbuild: raised CONSTRAINT_ERROR : a-calend.adb:371 overflow check failed

The problem originates in the gcc-13 switch to time_t64.
gcc/ada/libgnat/s-os_prim__posix.adb is affected by two apparently
distinct issues.

* s-os_prim.adb allocates 3Long_Integer=3void*=3*32 bits for the
  timeval C struct, while 2*64bits = 2Long_Long_Integer are now needed.

  This issue affects other files, but is easy to find and fix.

* The switch breaks the call from Ada to the C gettimeofday function.

  Can anyone explain this, and ideally provide a real fix instead of
  the ugly work-around below?

cat > mycal.c <
int mygettimeofday(struct timeval *restrict tv,
   struct timezone *restrict tz) {
  return gettimeofday(tv, tz);
}
EOF

cat > foo.adb <

Bug#1065309: transition: gnat 12 -> 13 + time_t64

2024-03-14 Thread nicolas . boulenguez

Hello.

Version 2 seems OK.

Thanks.

Bug#1065309: transition: gnat (12 -> 13 + time_t64)

2024-03-13 Thread nicolas . boulenguez

Hello.

A bug affects the Ada tests during the build of the gcc-12 source 
package.


https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066052

Such error messages happen on each (uncoordinated) change in the sources 
of an Ada library.  Some sources for the standard library built by GCC 
are generated from C headers, so, as Matthias wrote in the bug report, 
this is without doubt caused by the t64 transition (especially taking 
into account that Ada.Calendar defines types for time representation).


All/most Ada packages will probably soon FTBFS with a similar message.

All/most Ada libraries need small manual changes and a passage through 
NEW in order to fix this (Ada -dev packages built with gcc-12 and 
earlier carry a version, in addition to the SO version carried by 
library packages).


I agree with Matthias that we should instead start the gcc-13 transition 
in unstable. All packages are ready in experimental, with all library 
packages already renamed through NEW. But unfortunately also with 
intrusive unrelated changes, for example new upstream versions and a new 
Ada workflow removing the version from -dev package names.


This will fix the issue quickly (only a new changelog entry for each 
package), but I would like a formal approval by the release managers 
before starting the gnat-13 transition.


As described above in #1065309, all precautions have been taken in 
experimental, and all is needed is a rebuild in unstable with a new 
changelog entry. The FTBFSs in experimental reported by the salsa CI 
pipeline can be ignored, they are caused by the difficulty to resolve 
build dependencies in a context mixing unstable and experimental.


For the record, some unrelated changes in the gnat-12 sources were 
already causing similar bugs (#1061631,  [1]#1061633,  [2]#1064745 [3]), 
that will also be fixed by the gnat-13 transition.  These bugs are less 
important because they affect a few Ada packages, not GCC.




Links:
--
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061631
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061633
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064745

Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-03-10 Thread Nicolas Boulenguez
Package: dpkg-dev
Followup-For: Bug #872381

Hello.

Please consider this new patch queue instead of the old or untested
ones.  With this one applied on 279c6ccb, the package builds and
passes all tests.

* scripts/mk: only use ASCII characters
  Cosmetic independent suggestion.

* scripts/mk: protect files against double inclusion
  The variables are renamed as you have recommended.
  The test is fixed (ifdef fails on a defined but empty variable).

* scripts/mk: stop hard-coding dpkg_datadir
  Already discussed.

* scripts/mk/buildopts.mk: search once for parallel= in DEB_BUILD_OPTIONS

> > [...DEB_BUILD_OPTION_PARALLEL empty instead of undefined
> > when parallel= is missing...]
> [kind of an API change].

I have changed my patch and updated the comment.
However..
The policy only describes 'parallel=N' when N is a positive integer.
I think we should assume that the option is either missing or valid.
For me, 'parallel=' is as incorrect as 'parallel=foo'.

> I think it might perhaps make more sense to fallback to setting it
> to 1 if it's missing, but I need to ponder about possible
> consequences/fallout, etc.

I doubt any sensible default exist.
* 1 is safe/produces readable logs and $max_available_processors is fast.
* the policy/debhelper/... have found no one-size-fits-all solution.

* scripts/buildflags.mk: add missing GCJFLAGS
  Fixes a bug.

* scripts/buildflags.mk: generate the _FOR_BUILD variant of each variable
* scripts/buildflags.mk: sort the flag list
  These changes hopefully prevent new missing flags in the future (the
  output of dpkg-buildflags is sorted).

* scripts/*.mk: reduce the number of subprocesses
* scripts/t: use loops instead of repetitions, check exports and overrides
  * all four combinations of existing/new scripts/mk/*.mk pass the
existing/new tests in scripts/t/mk/*.mk.
  * comparing the time taken by tests gives a rough idea of the speed
gain
architecture.mk 30 times faster (probably no gain under dpkg-buildpackage)
buildflags.mk   20 times faster
pkg-info.mk  4 times faster
buildtools.mk20% faster

Guillem Jover
> I've left this one out for now. I'm not entirely satisfied with the
> sed usage here. If we keep using sed, then I think it needs to be
> set via a SED variable, substituted from the value found at

In which context do you expect GNU Make but a non recent sed?
Should I rewrite the regular expressions without -r/-E?

> configure time. But then, I've been pondering whether we can have
> better export formats, that might make the sed usage not
> necessary. I started with a make-eval export mode for buildflags,
> but perhaps it would be better a more generic formatting mode where
> the caller can specify how the output should look like, akin
> «dpkg-query --showformat». Will ponder about this.

A generic format would be more maintainable in the long term.
Something like that would be convenient for the makefiles.

dpkg-architecture --print-format='${Dollar}(eval export ${key} ?= ${value})'
dpkg-buildflags --print-format='${Dollar}(eval ${key}:=${value})'
dpkg-parsechangelog --print-format='${Dollar}(eval DEB_SOURCE:=${Source}) 
${Dollar}(eval export SOURCE_DATE_EPOCH?=${Timestamp}) ..'
dpkg-vendor --print-format'${Dollar}(eval DEB_VENDOR:=${Vendor}) ${Dollar}(eval 
DEB_PARENT_VENDOR:=${Parent})'

* scripts/buildtools.mk: style suggestions
  This arguably improves the readability, and fixes a minor issue
  ($(findstring nostrip,...) unwantedly matches arduinostrip).

* scripts/t/mk/buildflags.mk: fix test of _MAINT_APPEND when TEST_ is empty
  This fixes a minor issue. During a test with
  DEB_BUILD_OPTIONS=noopt, TEST_CXXFLAGS was empty and caused the test
  of DEB_CXXFLAGS_MAINT_APPEND to fail because the correct result is
  not a concatenation, Make strips a space.  This issue can also be
  seen with 1.22.5.
>From 37f1089c450fca16d06d586cf390a05642af25f0 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Mon, 4 Mar 2024 13:23:56 +0100
Subject: [PATCH 01/11] scripts/mk: only use ASCII characters

The policy recommends english, so french parenthesis must be replaced.
More generally, prudence recommends ASCII in Make scripts.
---
 scripts/mk/buildtools.mk | 2 +-
 scripts/mk/vendor.mk | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/mk/buildtools.mk b/scripts/mk/buildtools.mk
index 933fdcfaa..7c6732210 100644
--- a/scripts/mk/buildtools.mk
+++ b/scripts/mk/buildtools.mk
@@ -20,7 +20,7 @@
 #   QMAKE: Qt build system generator (since dpkg 1.20.0).
 #
 # All the above variables have a counterpart variable for the build tool,
-# as in CC → CC_FOR_BUILD.
+# as in CC -> CC_FOR_BUILD.
 #
 # The variables are not exported by default. This can be changed by
 # defining DPKG_EXPORT_BUILDTOOLS.
diff --git a/scripts/mk/vendor.mk b/scripts/mk/vendor.mk
index f3241a57b..8bdaa235a 100644
--- a/scripts/mk/vendor.mk
+++ b/scripts/mk/vendor

Bug#1065668: google-android-build-tools-30.0.2-installer: Cannot install multiple "build-tools" versions side by side

2024-03-08 Thread Nicolas Peugnet
Package: google-android-build-tools-30.0.2-installer
Version: 30.0.2+1707406511
Severity: normal

Dear Maintainer,

Since I made the switch to testing packages for google-android-*
packages, I can no longer install multiple versions of the "build tools"
side by side.

Here is the log of when I try to install two of them:

$ sudo apt install -t testing google-android-build-tools-30.0.3-installer 
google-android-build-tools-30.0.2-installer 
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
google-android-build-tools-30.0.2-installer is already the newest version 
(30.0.2+1707406511).
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 google-android-build-tools-30.0.2-installer : Conflicts: aapt
   Conflicts: aidl
   Conflicts: apksigner
   Conflicts: dexdump
   Conflicts: split-select
   Conflicts: zipalign
 google-android-build-tools-30.0.3-installer : Conflicts: aapt
   Conflicts: aidl
   Conflicts: apksigner
   Conflicts: dexdump
   Conflicts: split-select
   Conflicts: zipalign
E: Unable to correct problems, you have held broken packages.

And here is the result of apt depends, which feels strange to me:

$ apt depends google-android-build-tools-30.0.2-installer
google-android-build-tools-30.0.2-installer
  Depends: google-android-licenses (= 1707406511)
  Depends: libstdc++6
  Depends: zlib1g
  Depends: wget
 |Depends: make
make-guile
 |Depends: build-essential
  Depends: dpkg-dev
  Depends: unzip
  Depends: ca-certificates
  Depends: debconf
  Depends: po-debconf
 |Depends: debconf (>= 0.5)
  Depends: 
cdebconf
debconf
  Conflicts: aapt
google-android-build-tools-19.1.0-installer
google-android-build-tools-20.0.0-installer
google-android-build-tools-21.1.2-installer
google-android-build-tools-22.0.1-installer
google-android-build-tools-23.0.1-installer
google-android-build-tools-23.0.2-installer
google-android-build-tools-23.0.3-installer
google-android-build-tools-24.0.0-installer
google-android-build-tools-24.0.1-installer
google-android-build-tools-24.0.2-installer
google-android-build-tools-24.0.3-installer
google-android-build-tools-25.0.0-installer
google-android-build-tools-25.0.1-installer
google-android-build-tools-25.0.2-installer
google-android-build-tools-25.0.3-installer
google-android-build-tools-26.0.0-installer
google-android-build-tools-26.0.1-installer
google-android-build-tools-26.0.2-installer
google-android-build-tools-26.0.3-installer
google-android-build-tools-27.0.0-installer
google-android-build-tools-27.0.1-installer
google-android-build-tools-27.0.2-installer
google-android-build-tools-27.0.3-installer
google-android-build-tools-28.0.0-installer
google-android-build-tools-28.0.1-installer
google-android-build-tools-28.0.2-installer
google-android-build-tools-28.0.3-installer
google-android-build-tools-29.0.0-installer
google-android-build-tools-29.0.1-installer
google-android-build-tools-29.0.2-installer
google-android-build-tools-29.0.3-installer
google-android-build-tools-30.0.0-installer
google-android-build-tools-30.0.1-installer
google-android-build-tools-30.0.3-installer
google-android-build-tools-31.0.0-installer
google-android-build-tools-32.0.0-installer
google-android-build-tools-33.0.0-installer
google-android-build-tools-33.0.1-installer
google-android-build-tools-33.0.2-installer
google-android-build-tools-33.0.3-installer
google-android-build-tools-34.0.0-installer
google-android-build-tools-installer
  Conflicts: aidl
google-android-build-tools-19.1.0-installer
google-android-build-tools-20.0.0-installer
google-android-build-tools-21.1.2-installer
google-android-build-tools-22.0.1-installer
google-android-build-tools-23.0.1-installer
google-android-build-tools-23.0.2-installer
google-android-build-tools-23.0.3-installer
google-android-build-tools-24.0.0-installer
google-android-build-tools-24.0.1-installer
google-android-build-tools-24.0.2-installer
google-android-build-tools-24.0.3-installer
google-android-build-tools-25.0.0-installer

Bug#916475: ghdl: various suggestions to simplify the packaging

2024-03-04 Thread Nicolas Boulenguez
Source: ghdl
Followup-For: Bug #916475

Hello.
0001 is unchanged.
0002 is stripped from unwanted spaces<->tabulations changes.
>From 93ac475b1389fb875094c14a4977f64d8c1f74fd Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Sun, 1 Oct 2023 01:14:25 +0200
Subject: [PATCH 1/2] Delegate computation of Built-Using to dh-builtusing

---
 debian/control | 7 ---
 debian/rules   | 9 -
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/debian/control b/debian/control
index 585ee55e..545c44b4 100644
--- a/debian/control
+++ b/debian/control
@@ -5,6 +5,7 @@ Maintainer: Debian Electronics Team 
 Build-Depends: debhelper-compat (= 13),
dh-ada-library (>= 8.1),
+   dh-sequence-builtusing,
gnat-12, gcc-12, g++-12,
gcc-12-source ,
libisl-dev (>= 0.14) ,
@@ -80,7 +81,7 @@ Description: VHDL compiler/simulator (mcode backend)
 Package: ghdl-gcc
 Architecture: any
 Build-Profiles: 
-Built-Using: ${Built-Using-GCC}
+Built-Using: ${dh-builtusing:gcc-S-source}
 Depends: ghdl-common (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends},
 	gcc, zlib1g-dev
 Description: VHDL compiler/simulator (GCC backend)
@@ -122,7 +123,7 @@ Description: VHDL compiler/simulator (tools)
 
 Package: libghdl-3-0-0
 Architecture: any
-Built-Using: ${Built-Using-GCC}
+Built-Using: ${dh-builtusing:gcc-S-source} 
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Multi-Arch: same
 Description: VHDL compiler/simulator (shared library)
@@ -135,7 +136,7 @@ Description: VHDL compiler/simulator (shared library)
 
 Package: libghdl-dev
 Architecture: any
-Built-Using: ${Built-Using-GCC}
+Built-Using: ${dh-builtusing:gcc-S-source} 
 Depends: libghdl-3-0-0 (= ${binary:Version}), ${misc:Depends}
 Multi-Arch: same
 Description: VHDL compiler/simulator (library development files)
diff --git a/debian/rules b/debian/rules
index 5821f85d..138b8581 100755
--- a/debian/rules
+++ b/debian/rules
@@ -95,15 +95,6 @@ override_dh_strip:
 	dh_strip -N libghdl-3-0-0
 	dh_strip -p libghdl-3-0-0 --dbgsym-migration='libghdl-2-0-0'
 
-override_dh_gencontrol:
-ifneq ($(filter gcc,$(BACKENDS)),)
-	dh_gencontrol -- -VBuilt-Using-GCC="$(shell dpkg-query -f '$${Source} (= $${Version})' -W gcc-$(DEB_GNAT_VERSION)-source)"
-else
-	dh_gencontrol
-endif
-
-
-
 configure-llvm-stamp configure-mcode-stamp: configure-%-stamp:
 	$(announce)
 	mkdir -p $(BUILDDIR)/$*
-- 
2.39.2

>From 9fd880fea151ef73266938f65f423003f9d8f36b Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Thu, 5 Oct 2023 14:39:35 +0200
Subject: [PATCH 2/2] test driver: move error reporting to a separate procedure

---
 debian/tests/ghdl-tests | 16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/debian/tests/ghdl-tests b/debian/tests/ghdl-tests
index 871d594b..9ef0a66d 100755
--- a/debian/tests/ghdl-tests
+++ b/debian/tests/ghdl-tests
@@ -6,15 +6,19 @@ set -C -e -f -u
 # Debian yet.
 TESTS="sanity gna vests synth vpi vhpi"
 
-test $# = 2
+error() {
+echo >&2 "$0: $1"
+exit 1
+}
+
+test $# = 2 || error "bad argument count: $#"
 
 case "$2" in
 gcc|llvm|mcode)
 	BACKEND=$2
 	;;
 *)
-	echo >&2 "Invalid backend specification"
-	exit 1
+	error "invalid backend specification: $2"
 esac
 
 case "$1" in
@@ -27,8 +31,7 @@ case "$1" in
 	GHDL=/usr/bin/ghdl-$BACKEND
 	;;
 *)
-	echo >&2 "Invalid test environment specification"
-	exit 1
+	error "invalid test environment specification: $1"
 esac
 
 # Copy testsuite into $RUNDIR to execute there, so that no cleanup is necessary
@@ -50,6 +53,5 @@ if ./testsuite.sh $TESTS -- --keep-going; then
 elif test $BACKEND = llvm; then
 echo "Tests for backend llvm failed (but ignored for now)."
 else
-echo >&2 "Tests for backend $BACKEND failed."
-exit 1
+error "tests for backend $BACKEND failed."
 fi
-- 
2.39.2



Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-03-04 Thread Nicolas Boulenguez
Package: dpkg-dev
Followup-For: Bug #872381

This new version, based on c881a5a8,
* splits protection from double inclusion and dpkg_datadir generation
  into separate commits
* fixes an error in DEB_BUILD_OPTION_PARALLEL
* removes a few dubious optimizations (like checking if dpkg_datadir
  is already computed in default.mk).
* removes non-ASCII characters from comments
>From e29be20064687eee52fa9b6c1ee1cb722867d590 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 01/10] scripts/mk: protect scripts from double inclusion

Two such double inclusions already happen when default.mk is parsed.
---
 scripts/mk/architecture.mk | 5 +
 scripts/mk/buildapi.mk | 5 +
 scripts/mk/buildflags.mk   | 6 ++
 scripts/mk/buildopts.mk| 5 +
 scripts/mk/buildtools.mk   | 5 +
 scripts/mk/default.mk  | 5 +
 scripts/mk/pkg-info.mk | 5 +
 scripts/mk/vendor.mk   | 5 +
 8 files changed, 41 insertions(+)

diff --git a/scripts/mk/architecture.mk b/scripts/mk/architecture.mk
index c11cada16..2ffcee287 100644
--- a/scripts/mk/architecture.mk
+++ b/scripts/mk/architecture.mk
@@ -2,6 +2,9 @@
 # DEB_BUILD_* variables that dpkg-architecture can return. Existing values
 # of those variables are preserved as per policy.
 
+ifndef dpkg_architecture.mk_included
+dpkg_architecture.mk_included :=
+
 dpkg_lazy_eval ?= $$(or $$(value DPKG_CACHE_$(1)),$$(eval DPKG_CACHE_$(1) := $$(shell $(2)))$$(value DPKG_CACHE_$(1)))
 
 dpkg_architecture_setvar = export $(1) ?= $(call dpkg_lazy_eval,$(1),dpkg-architecture -q$(1))
@@ -9,3 +12,5 @@ dpkg_architecture_setvar = export $(1) ?= $(call dpkg_lazy_eval,$(1),dpkg-archit
 $(foreach machine,BUILD HOST TARGET,\
   $(foreach var,ARCH ARCH_ABI ARCH_LIBC ARCH_OS ARCH_CPU ARCH_BITS ARCH_ENDIAN GNU_CPU GNU_SYSTEM GNU_TYPE MULTIARCH,\
 $(eval $(call dpkg_architecture_setvar,DEB_$(machine)_$(var)
+
+endif
diff --git a/scripts/mk/buildapi.mk b/scripts/mk/buildapi.mk
index 668e325c8..ba6b43543 100644
--- a/scripts/mk/buildapi.mk
+++ b/scripts/mk/buildapi.mk
@@ -1,5 +1,8 @@
 # This Makefile fragment (since dpkg 1.22.0) handles the build API.
 
+ifndef dpkg_buildapi.mk_included
+dpkg_buildapi.mk_included :=
+
 # Default API level when not set.
 DPKG_BUILD_API ?= $(shell dpkg-buildapi)
 
@@ -7,3 +10,5 @@ DPKG_BUILD_API ?= $(shell dpkg-buildapi)
 # complexity given no integer operators, given that we currently have to
 # fetch the build API level anyway.
 dpkg_build_api_ge = $(shell test "$(DPKG_BUILD_API)" -ge "$(1)" && echo yes)
+
+endif
diff --git a/scripts/mk/buildflags.mk b/scripts/mk/buildflags.mk
index 4b8a3d8c4..02baa53f2 100644
--- a/scripts/mk/buildflags.mk
+++ b/scripts/mk/buildflags.mk
@@ -28,6 +28,10 @@
 # You can also export them in the environment by setting
 # DPKG_EXPORT_BUILDFLAGS to a non-empty value.
 #
+
+ifndef dpkg_buildflags.mk_included
+dpkg_buildflags.mk_included :=
+
 # This list is kept in sync with the default set of flags returned
 # by dpkg-buildflags.
 
@@ -77,3 +81,5 @@ $(foreach flag,$(DPKG_BUILDFLAGS_LIST),\
 ifdef DPKG_EXPORT_BUILDFLAGS
   export $(DPKG_BUILDFLAGS_LIST)
 endif
+
+endif
diff --git a/scripts/mk/buildopts.mk b/scripts/mk/buildopts.mk
index c9519..6787da76f 100644
--- a/scripts/mk/buildopts.mk
+++ b/scripts/mk/buildopts.mk
@@ -5,6 +5,11 @@
 #
 #   DEB_BUILD_OPTION_PARALLEL: the argument for the parallel=N option.
 
+ifndef dpkg_buildopts.mk_included
+dpkg_buildopts.mk_included :=
+
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
   DEB_BUILD_OPTION_PARALLEL = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 endif
+
+endif
diff --git a/scripts/mk/buildtools.mk b/scripts/mk/buildtools.mk
index 933fdcfaa..08914c463 100644
--- a/scripts/mk/buildtools.mk
+++ b/scripts/mk/buildtools.mk
@@ -25,6 +25,9 @@
 # The variables are not exported by default. This can be changed by
 # defining DPKG_EXPORT_BUILDTOOLS.
 
+ifndef dpkg_buildtools.mk_included
+dpkg_buildtools.mk_included :=
+
 dpkg_datadir = $(srcdir)/mk
 include $(dpkg_datadir)/architecture.mk
 
@@ -74,3 +77,5 @@ $(eval $(call dpkg_buildtool_setvar,AR,ar))
 $(eval $(call dpkg_buildtool_setvar,RANLIB,ranlib))
 $(eval $(call dpkg_buildtool_setvar,PKG_CONFIG,pkgconf))
 $(eval $(call dpkg_buildtool_setvar,QMAKE,qmake))
+
+endif
diff --git a/scripts/mk/default.mk b/scripts/mk/default.mk
index 0b2fd4aca..b791f98a5 100644
--- a/scripts/mk/default.mk
+++ b/scripts/mk/default.mk
@@ -1,6 +1,9 @@
 # This Makefile fragment (since dpkg 1.16.1) includes all the Makefile
 # fragments that define variables that can be useful within debian/rules.
 
+ifndef dpkg_default.mk_included
+dpkg_default.mk_included :=
+
 dpkg_datadir = $(srcdir)/mk
 include $(dpkg_datadir)/architecture.mk
 include $(dpkg_datadir)/buildapi.mk
@@ -11,3 +14,5 @@ include $(dpkg_datadir)/buildflags.mk
 include $(dpkg_datadir)/buildopts.mk
 include $(dpkg_datadir)/pkg-info.mk
 include $(dpkg_datadir

Bug#1064840: dh-ada-library: Tests will fail after glibc DEP17 migration

2024-03-04 Thread Nicolas Boulenguez
Source: dh-ada-library
Followup-For: Bug #1064840
Control: tags -1 + pending

Hello.
A fix is committed [1] and will be part of the pending t64/gnat-13
transition.
[1] 
https://salsa.debian.org/debian/dh_ada_library/-/commit/d40951e34b40f8e9c63e961546a8a4093746857d
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065309



Bug#1065309: transition: gnat 12 -> 13 + time_t64

2024-03-03 Thread Nicolas Boulenguez
Package: release.debian.org
X-Debbugs-Cc: debian-...@lists.debian.org

Hello.
In addition to the information in https://bugs.debian.org/1065309,
here is the usual summary preparing a gnat transition.

--

This bug requests a green light for a transition of Ada packages from
gnat-12 to gnat-13 in unstable.

The gcc-V source package builds the Ada compiler (gnat-V) and
companion library (libgnat-V).
The default Ada compiler is selected by the gnat package.
In unstable and testing, gnat Depends: gnat-12.
In experimental, gnat Depends: gnat-13.

This transition breaks the ABI of Ada libraries.  Each Ada library has
been uploaded to experimental with a new Shared Object version in the
library package name (and hence, a passage through NEW).

This is unrelated with gnat-13, but this transition also introduces a
new naming scheme for Ada -dev packages in Debian.  They stop carrying
a version identifying the API, and instead provide a versioned virtual
package instead.  The effect is the same, an API break in an Ada
library (this includes libgnat-V) requires a transition, but the NEW
queue will not be involved anymore.

Ben file:

title = "gnat-13";
is_affected = .depends ~ "libgnat-8/libgnat-9/libgnat-10/libgnat-11/libgnat-12" 
| .depends ~ "libgnat-13";
is_good = .depends ~ "libgnat-13";
is_bad = .depends ~ "libgnat-8/libgnat-9/libgnat-10/libgnat-11/libgnat-12";

These packages provide a library and are ready in experimental.
 adacgi
 adasockets
 ahven
 anet
 dbusada
 gprbuild
 libalog
 libaunit
 libflorist
 libgmpada
 libgnatcoll  The transition closes #1061631.
 libgnatcoll-db   The transition closes #1064745.
 libgnatcoll-bindings
 libgtkada
 liblog4ada
 libncursesada
 libtemplates-parser  The transition closes #1061633.
 libtexttools
 libxmlada
 libxmlezout
 pcscada
 plplot   The reupload must merge 5.15.0+dfsg2-7+deb13u2/unstable
  and 5.15.0+dfsg2-8/experimental. The changes are small
  and unrelated with Ada.

These packages, although not Ada libraries, are part of the transition.
They are ready in experimental and need a rebuild in unstable.
 alire
 dh-ada-library
 gnat

These packages produce no library. They need a bin-NMU.
nmu music123_16.6-6  . ANY . -m 'Rebuild with gnat-13'
dw  music123_16.6-6  . ANY . -m 'gnat (>= 13.1)'
nmu phcpack_2.4.89+dfsg-1. ANY . -m 'Rebuild with gnat-13'
dw  phcpack_2.4.89+dfsg-1. ANY . -m 'gnat (>= 13.1)'
nmu topal_81-2   . ANY . -m 'Rebuild with gnat-13'
dw  topal_81-2   . ANY . -m 'gnat (>= 13.1)'
nmu whitakers-words_0.2020.10.27-1.3 . ANY . -m 'Rebuild with gnat-13'
dw  whitakers-words_0.2020.10.27-1.3 . ANY . -m 'gnat (>= 13.1)'

ada-reference-manual only requires gnat at build time.
It should not be affected.

ghdl build-depends on an explicit gnat version for reasons unrelated
with the normal Ada policy.
It should not be affected.

These packages have been removed from testing for a while because of
unrelated RC bugs.
 adabrowse
 adacontrol
 asis
 gnat-gps
 libaws



Bug#1043828: astroid: Fails to build source after successful build

2024-03-03 Thread Nicolas Boulenguez
Source: astroid
Followup-For: Bug #1043828
Control: tags -1 + patch

Hello.
A trivial patch is available as a salsa merge request at
https://salsa.debian.org/python-team/packages/astroid/-/merge_requests/5



Bug#1007940: ITP: matrix-conduit -- lighweight homeserver for the Matrix protocol

2024-03-03 Thread Nicolas Peugnet

On Tue, 23 Jan 2024 19:39:22 +0100 Jonas Smedegaard  wrote:

0.6.0 draft 2 needs embedding 45 crates (21 missing, 1 broken, 12 ahead, 11 
unreleased); cannot build due to unsatisfied build-dependency on 
librust-axum-0.6+form-dev

Main task now is packaging remaining missing Rust crates.

Here's how you can help:

As user running Debian, you can test this draft package: Either build it
yourself from source or tell (by posting to this bugreport) if you
prefer testing the binary that I've built - then I will share that.


I tried to build the package from salsa but had the following error:

cp: cannot stat 'debian/Cargo.toml': No such file or directory

Here is the full log:

$ gbp buildpackage
gbp:info: Creating /home/nicolas/debian/matrix-conduit_0.6.0.orig.tar.bz2
gbp:info: Performing the build
 dpkg-buildpackage -us -uc -ui -i -I
dpkg-buildpackage: info: source package matrix-conduit
dpkg-buildpackage: info: source version 0.6.0-0~draft2
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Jonas Smedegaard 
 dpkg-source -i -I --before-build .
dpkg-buildpackage: info: host architecture amd64
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 1001_directories.patch
dpkg-source: info: applying 1001_heed.patch
dpkg-source: info: applying 1001_reqwest.patch
dpkg-source: info: applying 1001_ring.patch
dpkg-source: info: applying 1001_sha1.patch
dpkg-source: info: applying 2001_crossbeam.patch
dpkg-source: info: applying 2001_serde_yaml.patch
dpkg-source: info: applying 2001_thread_local.patch
dpkg-source: info: applying 2003_no_telemetry.patch
dpkg-source: info: applying 2004_system-shared_libs.patch
 debian/rules clean
dh clean --buildsystem cargo
   dh_auto_clean -O--buildsystem=cargo
debian cargo wrapper: WARNING: falling back to simply calling upstream 
cargo, because CARGO_HOME does not end with debian/cargo_home:
Use of uninitialized value in concatenation (.) or string at 
/home/nicolas/debian/matrix-conduit/debian/dh-cargo/lib/Debian/Debhelper/Buildsystem/cargo.pm 
line 359,  line 2.
	env DEB_BUILDDIR= 
/home/nicolas/debian/matrix-conduit/debian/dh-cargo/bin/cargo clean
debian cargo wrapper: options, profiles, parallel, lto: ['parallel=4'] 
[] ['-j4'] 0
debian cargo wrapper: rust_type, gnu_type: x86_64-unknown-linux-gnu, 
x86_64-linux-gnu
debian cargo wrapper: running subprocess (['env', 'RUST_BACKTRACE=1', 
'/usr/bin/cargo', 'clean', '--verbose', '--verbose'],) {'check': True}

   debian/rules execute_after_dh_auto_clean
make[1]: Entering directory '/home/nicolas/debian/matrix-conduit'
[ ! -f Cargo.toml.orig ] || mv -f Cargo.toml.orig Cargo.toml
[ ! -f Cargo.lock.orig ] || mv -f Cargo.lock.orig Cargo.lock
make[1]: Leaving directory '/home/nicolas/debian/matrix-conduit'
   dh_autoreconf_clean -O--buildsystem=cargo
   dh_clean -O--buildsystem=cargo
 dpkg-source -i -I -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building matrix-conduit using existing 
./matrix-conduit_0.6.0.orig.tar.bz2

dpkg-source: info: using patch list from debian/patches/series
dpkg-source: warning: ignoring deletion of file .gitlab-ci.yml, use 
--include-removal to override

dpkg-source: warning: ignoring deletion of directory .github
dpkg-source: warning: ignoring deletion of directory .github/ISSUE_TEMPLATE
dpkg-source: warning: ignoring deletion of file 
.github/ISSUE_TEMPLATE/Issue.md, use --include-removal to override

dpkg-source: warning: ignoring deletion of directory .gitlab
dpkg-source: warning: ignoring deletion of file .gitlab/CODEOWNERS, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file 
.gitlab/setup-buildx-remote-builders.sh, use --include-removal to override

dpkg-source: warning: ignoring deletion of directory .gitlab/issue_templates
dpkg-source: warning: ignoring deletion of file 
.gitlab/issue_templates/Feature Request.md, use --include-removal to 
override
dpkg-source: warning: ignoring deletion of file 
.gitlab/issue_templates/Bug Report.md, use --include-removal to override
dpkg-source: warning: ignoring deletion of directory 
.gitlab/merge_request_templates
dpkg-source: warning: ignoring deletion of file 
.gitlab/merge_request_templates/MR.md, use --include-removal to override

dpkg-source: warning: ignoring deletion of directory .gitea
dpkg-source: warning: ignoring deletion of file 
.gitea/PULL_REQUEST_TEMPLATE.md, use --include-removal to override
dpkg-source: info: building matrix-conduit in 
matrix-conduit_0.6.0-0~draft2.debian.tar.xz
dpkg-source: info: building matrix-conduit in 
matrix-conduit_0.6.0-0~draft2.dsc

 debian/rules binary
dh binary --buildsystem cargo
   dh_update_autotools_config -O--buildsystem=cargo
   dh_autoreconf -O--buildsystem=cargo
   debian/rules execute_before_dh_auto_configure
make[1]: Entering directory '/home/nicolas/debian/matrix-conduit'
[ -f Cargo.toml.orig ] || cp Cargo.toml Cargo.toml.orig
cp -f debian/Cargo.toml

Bug#947078: git-buildpackage: Need to make gbp clone pseudo protocols confgirable

2024-03-01 Thread Nicolas Boulenguez
Package: git-buildpackage
Followup-For: Bug #947078

Hello.
For me, this bug can be closed.
Does anyone object?



Bug#1051098: suggestion: dh-builtusing may simplify the packaging

2024-03-01 Thread Nicolas Boulenguez
Source: u-boot
Followup-For: Bug #1051098

Hello.
Here is an updated version rebased on a609e1d2:

>From 27ec150b506234e1a3e24688ed400627133ab5e2 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Sat, 2 Sep 2023 23:24:10 +0200
Subject: Delegate the Built-Using field to the dh-builtusing debhelper tool


diff --git a/debian/control b/debian/control
index 7a6bbc31cc..c6aec92cf6 100644
--- a/debian/control
+++ b/debian/control
@@ -7,6 +7,7 @@ Build-Depends:
  bc,
  bison,
  debhelper-compat (= 13),
+ dh-sequence-builtusing,
  flex,
  libpython3-dev:native [linux-any],
  libssl-dev,
@@ -186,7 +187,8 @@ Description: A boot loader for omap systems
 Package: u-boot-sunxi
 Architecture: armhf arm64
 Multi-Arch: same
-Built-Using: ${u-boot-sunxi:Built-Using}
+Built-Using: ${dh-builtusing:arm-trusted-firmware} [arm64],
+ ${dh-builtusing:crust-firmware} [arm64],
 Depends: ${misc:Depends}
 Recommends: u-boot-tools [arm64]
 Suggests: arm-trusted-firmware [arm64]
@@ -240,7 +242,7 @@ Description: A boot loader for marvell systems
 Package: u-boot-rockchip
 Architecture: armhf arm64
 Multi-Arch: same
-Built-Using: ${u-boot-rockchip:Built-Using}
+Built-Using: ${dh-builtusing:arm-trusted-firmware} [arm64]
 Depends: ${misc:Depends}
 Recommends: python3, u-boot-tools [arm64]
 Suggests: arm-trusted-firmware [arm64]
@@ -294,7 +296,7 @@ Package: u-boot-sifive
 Architecture: riscv64
 Multi-Arch: same
 Depends: ${misc:Depends}
-Built-Using: ${u-boot-sifive:Built-Using}
+Built-Using: ${dh-builtusing:opensbi}
 Description: A boot loader for SiFive systems
  Das U-Boot is a cross-platform bootloader for embedded systems,
  used as the default boot loader by several board vendors.  It is
@@ -312,7 +314,7 @@ Package: u-boot-starfive
 Architecture: riscv64
 Multi-Arch: same
 Depends: ${misc:Depends}
-Built-Using: ${u-boot-starfive:Built-Using}
+Built-Using: ${dh-builtusing:opensbi}
 Description: A boot loader for Starfive systems
  Das U-Boot is a cross-platform bootloader for embedded systems,
  used as the default boot loader by several board vendors.  It is
diff --git a/debian/rules b/debian/rules
index fc7c8e54d4..9cc8ee3e52 100755
--- a/debian/rules
+++ b/debian/rules
@@ -159,6 +159,6 @@ override_dh_clean:
find . -type d -name __pycache__ -delete
 
 override_dh_gencontrol:
-   dh_gencontrol -- $(dpkg-gencontrol_args) $(foreach package,\
+   dh_gencontrol -- $(foreach package,\
  u-boot-qemu $(subarchs),\
  '-V$(package):platforms=$(subst $() 
,$${Newline},$($(package)_platforms))')
diff --git a/debian/targets.mk b/debian/targets.mk
index 12eb78b9b8..f7e10d2ea0 100644
--- a/debian/targets.mk
+++ b/debian/targets.mk
@@ -51,9 +51,6 @@ ifeq (${DEB_HOST_ARCH},arm64)
 
 # u-boot-rockchip
 
-  dpkg-gencontrol_args += "-Vu-boot-rockchip:Built-Using=$(shell dpkg-query 
-Wf \
-'$${source:Package} (= $${source:Version})' arm-trusted-firmware)"
-
   # Vagrant Cascadian 
   u-boot-rockchip_platforms += firefly-rk3399
   firefly-rk3399_assigns := BL31=/usr/lib/arm-trusted-firmware/rk3399/bl31.elf
@@ -145,9 +142,6 @@ ifeq (${DEB_HOST_ARCH},arm64)
   u-boot-sunxi_assigns = \
 SCP=$(or $(wildcard /usr/lib/crust-firmware/$(platform).bin),/dev/null)
 
-  dpkg-gencontrol_args += "-Vu-boot-sunxi:Built-Using=$(shell dpkg-query -Wf \
-'$${source:Package} (= $${source:Version})' arm-trusted-firmware)"
-
   u-boot-sunxi_platforms += a64-olinuxino
   a64-olinuxino_assigns := 
BL31=/usr/lib/arm-trusted-firmware/sun50i_a64/bl31.bin
   a64-olinuxino_targets := arch/arm/dts/sun50i-a64-olinuxino.dtb \
@@ -386,9 +380,6 @@ else ifeq (${DEB_HOST_ARCH},armhf)
 
 # u-boot-rockchip
 
-  # Silent a debhelper warning about an unused substvar.
-  dpkg-gencontrol_args += -Vu-boot-rockchip:Built-Using=
-
   # Vagrant Cascadian , 2GB and 4GB variants
   u-boot-rockchip_platforms += firefly-rk3288
   firefly-rk3288_targets := idbloader.img spl/u-boot-spl.bin u-boot.bin \
@@ -423,9 +414,6 @@ else ifeq (${DEB_HOST_ARCH},armhf)
 
 # u-boot-sunxi
 
-  # Silent a debhelper warning about an unused substvar.
-  dpkg-gencontrol_args += -Vu-boot-sunxi:Built-Using=
-
   # Christian Kastner 
   u-boot-sunxi_platforms += A10-OLinuXino-Lime
   A10-OLinuXino-Lime_targets := u-boot-sunxi-with-spl.bin uboot.elf
@@ -544,9 +532,6 @@ else ifeq (${DEB_HOST_ARCH},riscv64)
 
 # u-boot-sifive
 
-  dpkg-gencontrol_args += "-Vu-boot-sifive:Built-Using=$(shell dpkg-query -Wf \
-'$${source:Package} (= $${source:Version})' opensbi)"
-
   # Hector Oron 
   u-boot-sifive_platforms += sifive_unleashed
   sifive_unleashed_targets := u-boot.bin uboot.elf spl/u-boot-spl.bin 
u-boot.itb
@@ -559,9 +544,6 @@ else ifeq (${DEB_HOST_ARCH},riscv64)
 
 # u-boot-starfive
 
-  dpkg-gencontrol_args += "-Vu-boot-starfive:Built-Using=$(shell dpkg-query 
-Wf \
-'$${source:Package} (= $${source:Version})' opensbi)"
-
   # Anatoliy Gunya 
   u-boot-starfive_platforms += starfive_visionfive2
   starfive_visionfive2_

Bug#990824: debian/rules: Filter packages and platforms without build profiles

2024-03-01 Thread Nicolas Boulenguez
Source: u-boot
Followup-For: Bug #990824

Hello.
This version is (trivially) rebased on a609e1d2.


>From 39ea68aadb043a3f38143bb41ad929cbeb11b5c9 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Thu, 8 Jul 2021 17:11:19 +0200
Subject: debian/rules: Filter packages and platforms without build profiles

This idea has been discussed since #979296, but the initial
implementation was incompatible with dpkg-buildpackage.

All three variants should now work:

debian/rules package_filter=u-boot/%rockchip/%sunxi 
platform_filter=%-rk3399/a64-olinuxino%
dpkg-buildpackage '--rules-file=debian/rules package_filter=...'
sbuild '--debbuildopt=--rules-file=debian/rules package_filter=...'

diff --git a/debian/rules b/debian/rules
index fc7c8e54d4..f1ac900bb9 100755
--- a/debian/rules
+++ b/debian/rules
@@ -34,22 +34,20 @@ notools := $(filter pkg.uboot.notools,$(DEB_BUILD_PROFILES))
 
 subarchs := $(shell dh_listpackages --arch --no-package=u-boot-tools)
 
-# Each .deb P in subarch contains $(P_platforms).
-# These profiles remove values from $(P_platforms) for debugging.
-
-# DEB_BUILD_PROFILES='pkg.uboot.subarch.P1 pkg.uboot.subarch.P2'
-# removes all platforms but in packages u-boot-P1 u-boot-P2.
-only_subarchs := $(patsubst pkg.uboot.subarch.%,u-boot-%,\
-   $(filter pkg.uboot.subarch.%,$(DEB_BUILD_PROFILES)))
+# For debugging purposes, some filters may restrict the actually built
+# platforms.  The expected contents are Make patterns (with at most
+# one % wildcard), separated by / (because spaces are difficult to
+# escape from dpkg-buildpackage --rules-file).
+#   package_filter=u-boot/%amlogic/%mvebu
+#   platform_filter=khadas-vim%
+
+only_subarchs := $(subst /, ,$(package_filter))
 ifneq (,$(only_subarchs))
   $(foreach pkg,$(filter-out $(only_subarchs),$(subarchs)),$(eval \
 $(pkg)_platforms :=))
 endif
 
-# DEB_BUILD_PROFILES='pkg.uboot.platform.P1 pkg.uboot.platform.P2'
-# removes all platforms but P1 P2.
-only_platforms := $(patsubst pkg.uboot.platform.%,%,\
-$(filter pkg.uboot.platform.%,$(DEB_BUILD_PROFILES)))
+only_platforms := $(subst /, ,$(platform_filter))
 ifneq (,$(only_platforms))
   $(foreach pkg,$(subarchs),$(eval \
 $(pkg)_platforms := $(filter $(only_platforms),$($(pkg)_platforms



Bug#1010751: clone: handle -b optional branch specification in VCS-Git

2024-03-01 Thread Nicolas Boulenguez
Package: git-buildpackage
Followup-For: Bug #1010751

Ping?



Bug#1065211: ITP: ada-bar-codes -- Bar or QR code formatter for the Ada programming language

2024-03-01 Thread Nicolas Boulenguez
Package: wnpp
Severity: wishlist
Owner: Nicolas Boulenguez 
X-Debbugs-Cc: debian-de...@lists.debian.org

* Package name: ada-bar-codes
  Version : 002.20240219
  Upstream Contact: Gautier de Montmollin 
* URL : https://sourceforge.net/projects/ada-bar-codes/
* License : Expat-MIT
  Programming Lang: Ada
  Description : Bar or QR code formatter for the Ada programming language

This Ada library generates various bar or QR codes, on different
output formats such as PDF, SVG or bitmaps.

The package is ready, I intend to upload it to NEW after the gnat-13
transition.



Bug#1063690: nftables: Segfault on named set or map definition in second table specification

2024-03-01 Thread Woltmann, Nicolas
We also ran into some variation of this issue using 0.9.8-3.1+deb11u2.

Using the following script `nft -f step1.nft`(it does not matter if map1 has 
some elements or not):
```step1.nft
table inet filter {
  map map1 {
type ifname : verdict
  }
}
```

Then if we later want to modify map1 and create another map in the same file, 
we get the segmentation fault. The minimum needed to trigger the error is the 
following:

```step2.nft
flush map inet filter map1

table inet filter {
  map map2 {
type ifname : verdict
  }
}
```

Here is a backtrace:

```
Program received signal SIGSEGV, Segmentation fault.
table_free (table=table@entry=0x5556c060) at rule.c:1358
(gdb) bt
#0  table_free (table=table@entry=0x5556c060) at rule.c:1358
#1  0x77f29c47 in table_free (table=0x5556c060) at rule.c:1347
#2  cmd_free (cmd=0x5556c6d0) at rule.c:1680
#3  0x77f5b4c8 in nft_run_cmd_from_filename (nft=0xd2a0, 
filename=filename@entry=0x7fffee10 "test.nft") at libnftables.c:544
#4  0x69f6 in main (argc=3, argv=0x7fffebc8) at main.c:491
```


Bug#1065049: soundconverter: Converts but files are not created

2024-02-29 Thread Nicolas Patrois
Package: soundconverter
Version: 4.0.4-1
Severity: important
Tags: upstream

Dear Maintainer,

Soundconverter works, converts files but the files are not created.

Yours,
n.


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages soundconverter depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.40.0-4+b1
ii  gconf-gsettings-backend [gsettings-backend]  3.2.6-8
ii  gir1.2-glib-2.0  1.78.1-15
ii  gir1.2-gst-plugins-base-1.0  1.22.10-dmo1
ii  gir1.2-gstreamer-1.0 1.22.10-1
ii  gir1.2-gtk-3.0   3.24.41-1
ii  gstreamer1.0-plugins-base1.22.10-dmo1
ii  gstreamer1.0-plugins-good1.22.10-dmo1
ii  python3  3.11.6-1
ii  python3-gi   3.47.0-3

Versions of packages soundconverter recommends:
ii  gir1.2-notify-0.7  0.8.3-1
ii  gstreamer1.0-libav 1:1.22.6-dmo1
ii  gstreamer1.0-plugins-ugly  1:1.22.10-dmo1

soundconverter suggests no packages.

-- no debconf information



Bug#1064620: firmware-nonfree: suggestions for the packaging, gencontrol.py and debian/rules

2024-02-24 Thread Nicolas Boulenguez
Source: firmware-nonfree
Version: 20230210-5
Severity: wishlist
Tags: patch

Hello.

The source package builds with the attached changes (2 to 10), and
debdiff finds no difference in the resulting debs for
firmware-{linux,linux-nonfree,qcom-media} (testing do_extra in gencontrol.py)
firmware-realtek (testing an example of do_main in gencontrol.py)

Commit 2 to 9 are cosmetic.

Commit 10 simplifies the build system in my opinion, and may improve
the handling of spaces in file names (1#1035505).

This is a complex package and I miss context, so I may of course split
10 in separate commits or revert parts of it depending on your answer.
>From 798e5b247db70dc24ce6736a4eba7b5ae17ca41d Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 23 Feb 2024 17:10:17 +0100
Subject: [PATCH 02/10] d/README.Debian: typo

---
 debian/README.source | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/README.source b/debian/README.source
index 15c11bf..43e897a 100644
--- a/debian/README.source
+++ b/debian/README.source
@@ -85,7 +85,7 @@ Optional per-file metadata:
 
 [_base] desc: One-line description for this file, used in
 package description
-[_base] version: Verson number for this file, used in package
+[_base] version: Version number for this file, used in package
description
 
 To re-generate debian/control (and other files) based on these
-- 
2.39.2

>From c525da983a782b3d58e7ba4f793930e197fc05d7 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 23 Feb 2024 17:11:31 +0100
Subject: [PATCH 03/10] d/clean: instead of complexity in d/rules

---
 debian/clean | 2 ++
 debian/rules | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 debian/clean

diff --git a/debian/clean b/debian/clean
new file mode 100644
index 000..b0bff90
--- /dev/null
+++ b/debian/clean
@@ -0,0 +1,2 @@
+debian/build/
+debian/lib/python/__pycache__/
diff --git a/debian/rules b/debian/rules
index 5867d9f..ccd41a7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,7 +15,6 @@ build-indep build-arch build: debian/control
 
 clean: debian/control
 	dh_testdir
-	rm -rf debian/build debian/lib/python/__pycache__
 	dh_clean
 
 binary-indep: build-indep
-- 
2.39.2

>From d193cb90f02e2c669c1ad2fb91759f4d9c3591e8 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 23 Feb 2024 17:28:04 +0100
Subject: [PATCH 04/10] d/rules: use dpkg pkg-info.mk snippet instead of
 reinventing it

---
 debian/rules | 15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/debian/rules b/debian/rules
index ccd41a7..d9a2d38 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,10 +1,9 @@
 #!/usr/bin/make -f
 SHELL := sh -e
-SOURCE := $(shell dpkg-parsechangelog -SSource)
-VERSION := $(shell dpkg-parsechangelog -SVersion)
-VERSION_UPSTREAM := $(shell echo "$(VERSION)" | sed -e 's,-[^-]*$$,,')
-VERSION_BINNMU := $(shell echo "$(VERSION)" | sed -rne 's,.*\+b([0-9]+)$$,\1,p')
-VERSION_SOURCE := $(patsubst %+b$(VERSION_BINNMU),%,$(VERSION))
+
+include /usr/share/dpkg/pkg-info.mk
+VERSION_BINNMU := $(shell echo "$(DEB_VERSION)" | sed -rne 's,.*\+b([0-9]+)$$,\1,p')
+VERSION_SOURCE := $(patsubst %+b$(VERSION_BINNMU),%,$(DEB_VERSION))
 
 include debian/rules.defs
 
@@ -35,7 +34,7 @@ CONTROL_FILES += debian/bin/gencontrol.py debian/config/defines $(wildcard debia
 # in the checksum.
 debian/build/version-info: debian/changelog
 	mkdir -p $(@D)
-	printf >$@ 'Source: %s\nVersion: %s\n' $(SOURCE) $(VERSION_SOURCE)
+	printf >$@ 'Source: %s\nVersion: %s\n' $(DEB_SOURCE) $(VERSION_SOURCE)
 
 debian/control debian/rules.gen: $(GENCONTROL) $(CONTROL_FILES)
 ifeq ($(wildcard debian/control.md5sum),)
@@ -59,8 +58,8 @@ debian/control-real: $(GENCONTROL) $(CONTROL_FILES)
 	@echo
 	exit 1
 
-DIR_ORIG = ../orig/$(SOURCE)-$(VERSION_UPSTREAM)
-TAR_ORIG_NAME = $(SOURCE)_$(VERSION_UPSTREAM).orig.tar.xz
+DIR_ORIG = ../orig/$(DEB_SOURCE)-$(DEB_VERSION_UPSTREAM)
+TAR_ORIG_NAME = $(DEB_SOURCE)_$(DEB_VERSION_UPSTREAM).orig.tar.xz
 TAR_ORIG = $(firstword $(wildcard ../$(TAR_ORIG_NAME)) $(wildcard ../orig/$(TAR_ORIG_NAME)))
 
 orig: $(DIR_ORIG)
-- 
2.39.2

>From 1327a9f8e15b602e7f3df768758f478b548dbd50 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 23 Feb 2024 17:28:38 +0100
Subject: [PATCH 05/10] d/rules: expand GENCONTROL instead of duplicating its
 contents

---
 debian/rules | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index d9a2d38..f455e5e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -26,9 +26,9 @@ binary-arch: build-arch
 binary:	binary-indep binary-arch
 
 CONTROL_FILES = debian/build/version-info $(wildcard debian/templates/*.in)
-CONTROL_FILES += debian/bin/gencontrol.py debian/config/defines $(wildcard debian/config/*/defines) debian/modinfo.json
+CONTROL_FILES += $(GENCONTROL) debian/config/defines $(wildcard debian/config/*/defines) d

Bug#1064618: firmware-realtek: please install rtlwifi/rtl8188fufw.bin

2024-02-24 Thread Nicolas Boulenguez
Package: firmware-realtek
Severity: wishlist
Tags: patch

Hello.
It seems that rtlwifi/rtl8188fufw.bin is now part of the Linux
firmwares repository.
The attachment attempts to spare you some time, and builds on Debian,
but is not tested on actual hardware yet.
>From 3a37cc18ee2709e807ff1f330bdc05a8db63efa0 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Fri, 23 Feb 2024 17:12:57 +0100
Subject: [PATCH 01/10] realtek: Add RTL8188fufw firmware

---
 debian/config/realtek/defines | 5 +
 debian/copyright  | 2 +-
 debian/modinfo.json   | 1 +
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/debian/config/realtek/defines b/debian/config/realtek/defines
index a68029b..9f600bd 100644
--- a/debian/config/realtek/defines
+++ b/debian/config/realtek/defines
@@ -70,6 +70,7 @@ files:
  rtl_nic/rtl8411-2.fw
  rtlwifi/rtl8188efw.bin
  rtlwifi/rtl8188eufw.bin
+ rtlwifi/rtl8188fufw.bin
  rtlwifi/rtl8192cfw.bin
  rtlwifi/rtl8192cfwU_B.bin
  rtlwifi/rtl8192cfwU.bin
@@ -340,6 +341,10 @@ desc: Realtek RTL8188EE firmware
 desc: Realtek RTL8188EU firmware
 version: 28.0
 
+[rtlwifi/rtl8188fufw.bin_base]
+desc: Realtek RTL8188FU firmware
+version: 4.3.23.6_20964.20170110
+
 [rtlwifi/rtl8192cfw.bin_base]
 desc: Realtek RTL8192CE/RTL8188CE firmware
 
diff --git a/debian/copyright b/debian/copyright
index 809b65d..0f1f247 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -4265,7 +4265,7 @@ License: binary-redist-Realtek-permissive
  notice is accompanying it.
 
 Files: RTL8192E/* rtlwifi/* rtw88/*
-Copyright: 2009-2010, Realtek Semiconductor Corporation
+Copyright: 2009-2017, Realtek Semiconductor Corporation
 License: binary-redist-Realtek-restrictive
  All rights reserved.
  .
diff --git a/debian/modinfo.json b/debian/modinfo.json
index ffee46a..333bc30 100644
--- a/debian/modinfo.json
+++ b/debian/modinfo.json
@@ -7000,6 +7000,7 @@
   "rtlwifi/rtl8192cufw_B.bin",
   "rtlwifi/rtl8192cufw_A.bin",
   "rtlwifi/rtl8188eufw.bin",
+  "rtlwifi/rtl8188fufw.bin",
   "rtlwifi/rtl8723aufw_B_NoBT.bin",
   "rtlwifi/rtl8723aufw_B.bin",
   "rtlwifi/rtl8723aufw_A.bin"
-- 
2.39.2



Bug#1052606: python3-pyroute2: pyroute2.__version__ is "unknown"

2024-02-22 Thread Nicolas Schier
Hi,

I prepared a merge-request for fixing it (and adding a test to check
against bug revival):


https://salsa.debian.org/openstack-team/third-party/pyroute2/-/merge_requests/1

Might someone take a look at it?
Shall I set someone specific as reviewer on the MR?

Kind regards,
Nicolas



Bug#1064225: linux-headers-6.6.15-686-pae: dkms autoinstall on 6.6.15-686-pae/i686 failed for virtualbox

2024-02-18 Thread Nicolas Patrois
Package: linux-headers-6.6.15-686-pae
Version: 6.6.15-2
Severity: normal

Dear Maintainer,

dkms can’t build virtualbox, but acpi-call nvidia-legacy-390xx openrazer-driver
are OK.
Here are the logs from /var/lib/dkms/virtualbox/6.0.14/build/make.log:

DKMS make.log for virtualbox-6.0.14 for kernel 6.6.15-686-pae (i686)
dim. 18 févr. 2024 19:43:38 CET
make : on entre dans le répertoire « /usr/src/linux-headers-6.6.15-686-pae »
  CC [M]  /var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/linux/SUPDrv-linux.o
  CC [M]  /var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrv.o
  CC [M]  /var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrvGip.o
In file included from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/iprt/types.h:34,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/VBox/types.h:33,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/linux/../SUPDrvInternal.h:38,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/linux/SUPDrv-linux.c:32:
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/iprt/stdarg.h:47:12:
fatal error: stdarg.h: Aucun fichier ou dossier de ce type
   47 | #  include 
  |^~
compilation terminated.
make[3]: *** [/usr/src/linux-headers-6.6.15-common/scripts/Makefile.build:248 :
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/linux/SUPDrv-linux.o] Erreur 1
make[3]: *** Attente des tâches non terminées
In file included from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/iprt/types.h:34,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/VBox/types.h:33,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrvInternal.h:38,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrv.c:33:
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/iprt/stdarg.h:47:12:
fatal error: stdarg.h: Aucun fichier ou dossier de ce type
   47 | #  include 
  |^~
compilation terminated.
make[3]: *** [/usr/src/linux-headers-6.6.15-common/scripts/Makefile.build:248 :
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrv.o] Erreur 1
In file included from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/iprt/types.h:34,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/VBox/types.h:33,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrvInternal.h:38,
 from
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrvGip.c:33:
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/include/iprt/stdarg.h:47:12:
fatal error: stdarg.h: Aucun fichier ou dossier de ce type
   47 | #  include 
  |^~
compilation terminated.
make[3]: *** [/usr/src/linux-headers-6.6.15-common/scripts/Makefile.build:248 :
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv/SUPDrvGip.o] Erreur 1
make[2]: *** [/usr/src/linux-headers-6.6.15-common/scripts/Makefile.build:485 :
/var/lib/dkms/virtualbox/6.0.14/build/vboxdrv] Erreur 2
make[1]: *** [/usr/src/linux-headers-6.6.15-common/Makefile:1938 :
/var/lib/dkms/virtualbox/6.0.14/build] Erreur 2
make: *** [/usr/src/linux-headers-6.6.15-common/Makefile:246 : __sub-make]
Erreur 2
make : on quitte le répertoire « /usr/src/linux-headers-6.6.15-686-pae »

Yours,
n.


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages linux-headers-6.6.15-686-pae depends on:
ii  gcc-13   13.2.0-13
ii  linux-headers-6.6.15-common  6.6.15-2
ii  linux-image-6.6.15-686-pae   6.6.15-2
ii  linux-kbuild-6.6.15  6.6.15-2

linux-headers-6.6.15-686-pae recommends no packages.

linux-headers-6.6.15-686-pae suggests no packages.

-- no debconf information


Bug#1064196: tracker-extract: Repeatedly coredumps

2024-02-18 Thread Nicolas Patrois
Package: tracker-extract
Version: 3.4.6-3
Severity: important
Tags: upstream

Dear Maintainer,

tracker got installed automatically, why not.
But this morning, tracker-extract coredumps systematically: my old machine was
unusable.
Here is an example of systemd-coredump’s output in the logs:

févr. 18 09:52:56 [mymachine] systemd-coredump[28563]: [] Process 28551
(tracker-extract) of user 65534 dumped core.

 Module libnvidia-
fatbinaryloader.so.390.157 without build-id.
 Module libcuda.so.1
without build-id.
 Module libsystemd.so.0
from deb systemd-255.3-2.i386
 Module
libarchive.so.13 from deb libarchive-3.7.2-1.i386
 Module libzstd.so.1
from deb libzstd-1.5.5+dfsg2-2.i386
 Module libudev.so.1
from deb systemd-255.3-2.i386
 Stack trace of thread
28551:
 #0  0xb7fa5577
__kernel_rt_sigreturn (linux-gate.so.1 + 0x577)
 #1  0xa1947e5e
n/a (libnvidia-fatbinaryloader.so.390.157 + 0x2e5e)
 ELF object binary
architecture: Intel 80386

I won’t send send a coredump here (about 20 MB) but if you want one, just ask.
For example there are 43 coredumps in /var/lib/systemd/coredump/, like:
core.tracker-
extract.65534.68bda4c586434f3d9e89df19e3f88eae.28551.170824633700.zst

Yours,
n.


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 5.16.0-6-686-pae (SMP w/3 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages tracker-extract depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.40.0-4+b1
ii  gconf-gsettings-backend [gsettings-backend]  3.2.6-8
ii  libblkid12.39.3-6
ii  libc62.37-15
ii  libcue2  2.3.0-dmo1
ii  libexempi8   2.6.5-1
ii  libexif120.6.24-1+b1
ii  libgexiv2-2  0.14.2-2+b1
ii  libgif7  5.2.1-2.5+b1
ii  libglib2.0-0 2.78.4-1
ii  libgsf-1-114 1.14.51-2
ii  libgstreamer-plugins-base1.0-0   1.22.10-dmo1
ii  libgstreamer1.0-01.22.10-1
ii  libgxps2 0.3.2-3
ii  libicu72 72.1-4+b1
ii  libiptcdata0 1.0.5-2.3
ii  libjpeg62-turbo  1:2.1.5-2+b2
ii  libnm0   1.44.2-7
ii  libosinfo-1.0-0  1.11.0-2
ii  libpng16-16  1.6.42-1
ii  libpoppler-glib8 22.12.0-2+b1
ii  libseccomp2  2.5.5-1
ii  libtiff6 4.5.1+git230720-4
ii  libtotem-plparser18  3.26.6-1+b1
ii  libtracker-sparql-3.0-0  3.4.2-3
ii  libxml2  2.9.14+dfsg-1.3+b2
ii  tracker  3.4.2-3

tracker-extract recommends no packages.

tracker-extract suggests no packages.

-- no debconf information


Bug#1063991: RFS: pyroute2/0.7.7-2.1 [NMU] -- Python3 Netlink library - full package

2024-02-15 Thread Nicolas Schier
oh, I'm sorry, I forgot to Cc the pyroute2 uploaders in the initial RFS 
mail.

On Thu 15 Feb 2024 11:56:09 GMT, Nicolas Schier wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "pyroute2":
> 
>  * Package name : pyroute2
>Version  : 0.7.7-2.1
>Upstream contact : Peter V. Saveliev 
>  * URL  : https://github.com/svinota/pyroute2
>  * License  : GPL-3+-and-Apache-2.0, BSD-2-clause, Expat, GPL-3+
>  * Vcs  : https://salsa.debian.org/openstack/third-party/pyroute2
>Section  : python
> 
> The source builds the following binary packages:
> 
>   python-pyroute2-doc - netlink and Linux network configuration library 
> (documentation)
>   python3-pyroute2 - Python3 Netlink library - full package
> 
> To access further information about this package, please visit the following 
> URL:
> 
>   https://mentors.debian.net/package/pyroute2/
> 
> Alternatively, you can download the package with 'dget' using this command:
> 
>   dget -x 
> https://mentors.debian.net/debian/pool/main/p/pyroute2/pyroute2_0.7.7-2.1.dsc
> 
> Changes since the last upload:
> 
>  pyroute2 (0.7.7-2.1) unstable; urgency=medium
>  .
>* Non-maintainer upload.
>* Add test against unknown version
>* Auto-gen pyroute2's version number during build (Closes: #1052606)
> 
> Actually, pyroute2 is team-maintained (openstack), but its Vcs is 
> currently marked as private (cp. #1052605).
> 
> Regards,
> -- 
>   Nicolas Schier



-- 
Nicolas Schier
 
epost|xmpp: nico...@fjasle.eu  irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
 -- frykten for herren er opphav til kunnskap --


signature.asc
Description: PGP signature


Bug#1063991: RFS: pyroute2/0.7.7-2.1 [NMU] -- Python3 Netlink library - full package

2024-02-15 Thread Nicolas Schier
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "pyroute2":

 * Package name : pyroute2
   Version  : 0.7.7-2.1
   Upstream contact : Peter V. Saveliev 
 * URL  : https://github.com/svinota/pyroute2
 * License  : GPL-3+-and-Apache-2.0, BSD-2-clause, Expat, GPL-3+
 * Vcs  : https://salsa.debian.org/openstack/third-party/pyroute2
   Section  : python

The source builds the following binary packages:

  python-pyroute2-doc - netlink and Linux network configuration library 
(documentation)
  python3-pyroute2 - Python3 Netlink library - full package

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/pyroute2/

Alternatively, you can download the package with 'dget' using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/p/pyroute2/pyroute2_0.7.7-2.1.dsc

Changes since the last upload:

 pyroute2 (0.7.7-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Add test against unknown version
   * Auto-gen pyroute2's version number during build (Closes: #1052606)

Actually, pyroute2 is team-maintained (openstack), but its Vcs is 
currently marked as private (cp. #1052605).

Regards,
-- 
  Nicolas Schier


signature.asc
Description: PGP signature


Bug#1056936: bookworm-pu: package glewlwyd/2.7.5-3

2024-02-14 Thread Nicolas Mora

Hello,

I've updated the debdiff to add a fix for CVE-2024-25715

/Nicolasdiff -Nru glewlwyd-2.7.5/debian/changelog glewlwyd-2.7.5/debian/changelog
--- glewlwyd-2.7.5/debian/changelog	2023-05-04 07:21:27.0 -0400
+++ glewlwyd-2.7.5/debian/changelog	2023-11-23 17:12:13.0 -0500
@@ -1,3 +1,12 @@
+glewlwyd (2.7.5-3+deb12u1) bookworm; urgency=medium
+
+  * d/patches: Fix CVE-2023-49208
+possible buffer overflow during FIDO2 credentials validation
+  * d/patches: Fix CVE-2024-25715
+open redirection via redirect_uri
+
+ -- Nicolas Mora   Thu, 23 Nov 2023 17:12:13 -0500
+
 glewlwyd (2.7.5-3) unstable; urgency=medium
 
   * Install config.json as config-2.7.json (Closes: #1035503)
diff -Nru glewlwyd-2.7.5/debian/patches/CVE-2023-49208.patch glewlwyd-2.7.5/debian/patches/CVE-2023-49208.patch
--- glewlwyd-2.7.5/debian/patches/CVE-2023-49208.patch	1969-12-31 19:00:00.0 -0500
+++ glewlwyd-2.7.5/debian/patches/CVE-2023-49208.patch	2023-11-23 17:12:13.0 -0500
@@ -0,0 +1,21 @@
+Description: Fix CVE-2023-49208 for bookworm
+Author: Nicolas Mora 
+Forwarded: not-needed
+--- a/src/scheme/webauthn.c
 b/src/scheme/webauthn.c
+@@ -2260,13 +2260,13 @@
+ for (i=0; i
+Forwarded: not-needed
+--- a/src/plugin/protocol_oauth2.c
 b/src/plugin/protocol_oauth2.c
+@@ -696,7 +696,7 @@
+ 
+ static json_t * check_client_valid(struct _oauth2_config * config, const char * client_id, const char * client_header_login, const char * client_header_password, const char * redirect_uri, unsigned short authorization_type, int implicit_flow, const char * ip_source) {
+   json_t * j_client, * j_element = NULL, * j_return;
+-  int uri_found, authorization_type_enabled;
++  int uri_found = 0, authorization_type_enabled;
+   size_t index = 0;
+   
+   if (client_id == NULL) {
+@@ -707,20 +707,17 @@
+ return json_pack("{si}", "result", G_ERROR_PARAM);
+   }
+   j_client = config->glewlwyd_config->glewlwyd_callback_check_client_valid(config->glewlwyd_config, client_id, client_header_password);
+-  if (check_result_value(j_client, G_OK)) {
++  if (check_result_value(j_client, G_OK) && json_object_get(json_object_get(j_client, "client"), "enabled") == json_true()) {
+ if (!implicit_flow && client_header_password == NULL && json_object_get(json_object_get(j_client, "client"), "confidential") == json_true()) {
+   y_log_message(Y_LOG_LEVEL_DEBUG, "check_client_valid - oauth2 - Error, confidential client must be authentified with its password, origin: %s", ip_source);
+   j_return = json_pack("{si}", "result", G_ERROR_UNAUTHORIZED);
+ } else {
+   if (redirect_uri != NULL) {
+-uri_found = 0;
+ json_array_foreach(json_object_get(json_object_get(j_client, "client"), "redirect_uri"), index, j_element) {
+   if (0 == o_strcmp(json_string_value(j_element), redirect_uri)) {
+ uri_found = 1;
+   }
+ }
+-  } else {
+-uri_found = 1;
+   }
+   
+   authorization_type_enabled = 0;
+@@ -2444,8 +2441,8 @@
+   // Check if client is allowed to perform this request
+   if (check_result_value(j_client, G_OK)) {
+ // Client is allowed to use auth_code grant with this redirection_uri
+-if (u_map_has_key(request->map_url, "g_continue")) {
+-  if (!o_strnullempty(u_map_get(request->map_url, "scope"))) {
++if (!o_strnullempty(u_map_get(request->map_url, "scope"))) {
++  if (u_map_has_key(request->map_url, "g_continue")) {
+ j_session = validate_session_client_scope(config, request, u_map_get(request->map_url, "client_id"), u_map_get(request->map_url, "scope"));
+ if (check_result_value(j_session, G_OK)) {
+   if (json_object_get(json_object_get(j_session, "session"), "authorization_required") == json_false()) {
+@@ -2526,26 +2523,20 @@
+ }
+ json_decref(j_session);
+   } else {
+-// Scope is not allowed for this user
+-y_log_message(Y_LOG_LEVEL_DEBUG, "check_auth_type_auth_code_grant - oauth2 - scope list is missing or empty, origin: %s", ip_source);
+-response->status = 302;
+-redirect_url = msprintf("%s%serror=invalid_scope%s", u_map_get(request->map_url, "redirect_uri"), (o_strchr(u_map_get(request->map_url, "redirect_uri"), '?')!=NULL?"&":"?"), state_param);
++// Redirect to login page
++redirect_url = get_login_url(config, request, "auth", u_map_get(request->map_url, "client_id"), u_map_get(request->map_url, "scope"), NULL);
+ ulfius_add_header_to_response(response, "Location", redirect_url);
+ o_free(redirect_url);
++respons

Bug#1057107: bullseye-pu: package libssh2/1.9.0-2

2024-02-06 Thread Nicolas Mora

Control: tag +1 moreinfo

Thanks,



Bug#1057107: bullseye-pu: package libssh2/1.9.0-2

2024-02-06 Thread Nicolas Mora

Control: tag -1 moreinfo

Thanks,



Bug#1057107: bullseye-pu: package libssh2/1.9.0-2

2024-02-06 Thread Nicolas Mora

Control: tag - moreinfo

Thanks,

Sorry, it seems that I'm not very well aware of the BTS process, 
according to [1] this is how I should untag the bug.


[1] https://www.debian.org/Bugs/server-control



Bug#1061956: [Pkg-nagios-devel] Bug#1061956: monitoring-plugins-basic: check_http --no-body fails when Transfer-Encoding: chunked

2024-01-31 Thread Cyprien Nicolas
Hi Jan,

> Le 31 Jan 24, à 12:03, Jan Wagner w...@cyconet.org a écrit :
>
> Hi Cyprien,
> 
> Am 30.01.24 um 14:27 schrieb Cyprien Nicolas:
> 
>> Would it be possible to get a fix in current stable? In next
>> point-release maybe?
> 
> I opened #1062063 for this.

Thank you very much.

>> 1. https://github.com/monitoring-plugins/monitoring-plugins/pull/1901
> 
> Maybe as in
> https://github.com/monitoring-plugins/monitoring-plugins/pull/1901#issuecomment-1771021923
> suggested you might want to migrate over to check_curl?

Thanks for the suggestion, it was quicker for us to remove the --no-body 
argument :)

Regards,
-- 
Cyprien



Bug#1061956: monitoring-plugins-basic: check_http --no-body fails when Transfer-Encoding: chunked

2024-01-30 Thread Cyprien Nicolas
Package: monitoring-plugins-basic
Version: 2.3.3-5+deb12u1
Severity: normal

Dear Maintainer,

After upgrading a monitoring server to bookworm, almost all http
checks failed.

This issue is related to `check_http` failing to handle the --no-body
or -N argument when a server sends the Transfer-Encoding: chunked
header.

We use this argument for checking only the HTTP status code, as we
don't need the full body of the response.

The issue is already fixed upstream since 2.3.4 [1] and I can't
reproduce the issue with 2.3.5-1 from testing.

To reproduce, using 2.3.3-5+deb12u1:

cyprien $ /usr/lib/nagios/plugins/check_http --ssl --sni -H wiki.debian.org
HTTP OK: HTTP/1.1 200 OK - 24108 octets en 1,476 secondes de temps de réponse 
|time=1,475541s;;;0,00;10,00 size=24108B;;;0;

cyprien $ /usr/lib/nagios/plugins/check_http --ssl --sni -H wiki.debian.org 
--no-body
HTTP UNKNOWN: Failed to unchunk message body

Would it be possible to get a fix in current stable? In next
point-release maybe?

1. https://github.com/monitoring-plugins/monitoring-plugins/pull/1901

-- System Information:
Debian Release: 12.4
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable'), (400, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-17-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages monitoring-plugins-basic depends on:
ii  iputils-ping   3:20221126-1
ii  libc6  2.36-9+deb12u3
ii  libssl33.0.11-1~deb12u2
ii  monitoring-plugins-common  2.3.3-5+deb12u1
ii  procps 2:4.0.2-3
ii  ucf3.0043+nmu1

Versions of packages monitoring-plugins-basic recommends:
ii  libcap2-bin  1:2.66-4

Versions of packages monitoring-plugins-basic suggests:
pn  icinga2  

-- no debconf information
-- 
Cyprien



Bug#1056764: grub-efi-amd64: can't boot with GRUB 2.12~rc1-12

2024-01-25 Thread Nicolas Haller

Hello Mate,

As per Jeremy suggestion, I switched to BIOS/grub-pc and I'm now able to 
boot my system. I guess this is not super ideal so I'll let you decide 
if you want to keep this bug open or not.


If you need a tester for your idea, I can revert my system to UEFI and 
give it a try whenever it's ready.


Thanks,

--
Nicolas Haller


On 2024-01-25 03:22, Mate Kukri wrote:

Hello all,

An idea for a workaround I have on such machines is to add an
environment variable (or some other option) to GRUB that let's GRUB
use the legacy-x86 kernel entry point even if the EFI stub appears
supported (of course only with UEFI Secure Boot disabled).

Based on previous discussion, it unfortunately seems that this isn't
strictly a GRUB issue, and the problem comes from GRUB switching
to booting the kernel using the method now preferred by upstream.

Mate

On Thu, Jan 25, 2024 at 2:21 AM Nicolas Haller  wrote:


On 2024-01-23 08:15, Julian Andres Klode wrote:

Control: severity -1 important

On Sat, Nov 25, 2023 at 05:36:41PM -0500, Nicolas Haller wrote:

Package: grub-efi-amd64
Version: 2.06-13
Severity: critical
Justification: breaks the whole system

Dear Maintainer,

My old laptop (Lenovo 11e) runs Sid and all was right before I updated
it the other day (I don't do that very often). After that upgrade, GRUB
wasn't able to load any kernel with the pretty much generic error
"Error: can't load image". The version of GRUB was 2.12~rc1-12.
If I try to boot again, GRUB tells me that I need to load the image
first (I guess it somehow ignores the linux command and sends that when
trying to load the initrd).


I'm downgrading this bug severity, as a single system regressing in
boot ability is not release critical. It is not possible for us to
ensure that grub continues working on every single device out there,
this grub will work for more hardware than previous grubs, and blocking
the transition to testing because it doesn't work on your 11e is not
helping anyone.

We have now also uploaded 2.12-1 and of course we welcome any patches,
but an old Lenovo 11e is not a priority, and we don't have any to test
ourselves.
--
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer  i speak de, en



Hello Julian,

I'm not sure why the aggressive tone here, I was asked if this bug
breaks my system and it does. How you want to handle this is up to you.
I think GRUB is a critical piece of a Linux system and I thought it was
worth to report the issue I encounter.

As I mentioned, my Lenovo isn't the newest one but it's not an esoteric
hardware either. It's a pretty regular amd64 laptop.

To be honest, I'm a bit concerned that GRUB failed where it wasn't
before (I would called that a regression) but also that it fails without
giving any error message or any kind of clue that could help to debug this.

I'm not a debian or ubuntu core developer and I don't know the first
thing about how to develop or debug a boot loader. Asking me for patches
isn't helping anyone.

If you have any suggestion in order to fix or just to diagnose the
issue, feel free to share that with me. Meanwhile, I'll try 2.12.1 and
look for an upgrade as Jeremy suggested.

Have a nice day,

--
Nicolas Haller

___
Pkg-grub-devel mailing list
pkg-grub-de...@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-grub-devel






Bug#1056764: grub-efi-amd64: can't boot with GRUB 2.12~rc1-12

2024-01-25 Thread Nicolas Haller

Hi Jeremy,

Thanks for the suggestions.
I was able to update my BIOS/UEFI but it didn't solve the issue 
unfortunately.


So I change the type of my UEFI partition to BIOS boot partition, 
install grub-pc 2.12-1, run a grub-install and change the BIOS setting 
to "legacy BIOS only" as you mentioned and I'm able to boot now.


I'm not sure of the consequences of switching from UEFI to BIOS, but at 
least, I have a GRUB I don't need to pin to 2.06. :-)


Thanks again for your help.

--
Nicolas Haller

On 2024-01-24 00:49, Jeremy Davis wrote:

Hi Nicolas,

It might be worth double checking you have the latest BIOS/UEFI? If it's 
not the latest, then updating is worth a try IMO.


FWIW I recently updated mine to resolve some (completely unrelated) 
issues on my Lenovo Gen 1 X1 Carbon on Bookworm. With no optical drive 
and no Windows, it initially seemed like a PITA, but ended up pretty easy.


Process went something like this:

- download relevant BIOS/UEFI update ISO specific to your model from
   Lenovo
- extract IMG from ISO (using 'geteltorito' tool in 'genisoimage' pkg)
- write IMG to USB (e.g. using 'dd')
- boot from USB
- update...! :)

If you are already running latest, updating doesn't help, or you want to 
try a workaround, perhaps try disabling UEFI (i.e. disable secure boot 
and enable "legacy BIOS only" mode) and install the non-uefi grub (i.e. 
'grub-pc')?


Good luck.

Cheers,
Jeremy




Bug#1054124: dh-ada-library: dh_ada_library output causes /usr/share/ada/packaging.mk:81: *** missing separator error

2024-01-25 Thread Nicolas Boulenguez
Hello.

> debhelper  13.11.4
> dh-ada-library 8.6
> gnat-1010.2.1-6

> $ dh_ada_library --export-versions
> DEB_GNAT_VERSION:=GNATMAKE 10.2.1 20210110

I failed to reproduce your issue with
 debhelper  13.11.10
 dh-ada-library 8.6
 gnat-1010.5.0-2
That is, the output is
 DEB_GNAT_VERSION:=10

Can you reproduce the issue?
Which version of the 'gnat' package is involved, if any?

Also, in which source tree/commit are you executing dh_ada_library?
One could imagine a problem while parsing debian/control.



Bug#1056764: grub-efi-amd64: can't boot with GRUB 2.12~rc1-12

2024-01-24 Thread Nicolas Haller

On 2024-01-23 08:15, Julian Andres Klode wrote:

Control: severity -1 important

On Sat, Nov 25, 2023 at 05:36:41PM -0500, Nicolas Haller wrote:

Package: grub-efi-amd64
Version: 2.06-13
Severity: critical
Justification: breaks the whole system

Dear Maintainer,

My old laptop (Lenovo 11e) runs Sid and all was right before I updated
it the other day (I don't do that very often). After that upgrade, GRUB
wasn't able to load any kernel with the pretty much generic error
"Error: can't load image". The version of GRUB was 2.12~rc1-12.
If I try to boot again, GRUB tells me that I need to load the image
first (I guess it somehow ignores the linux command and sends that when
trying to load the initrd).


I'm downgrading this bug severity, as a single system regressing in
boot ability is not release critical. It is not possible for us to
ensure that grub continues working on every single device out there,
this grub will work for more hardware than previous grubs, and blocking
the transition to testing because it doesn't work on your 11e is not
helping anyone.

We have now also uploaded 2.12-1 and of course we welcome any patches,
but an old Lenovo 11e is not a priority, and we don't have any to test
ourselves.
--
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer  i speak de, en



Hello Julian,

I'm not sure why the aggressive tone here, I was asked if this bug 
breaks my system and it does. How you want to handle this is up to you.
I think GRUB is a critical piece of a Linux system and I thought it was 
worth to report the issue I encounter.


As I mentioned, my Lenovo isn't the newest one but it's not an esoteric 
hardware either. It's a pretty regular amd64 laptop.


To be honest, I'm a bit concerned that GRUB failed where it wasn't 
before (I would called that a regression) but also that it fails without 
giving any error message or any kind of clue that could help to debug this.


I'm not a debian or ubuntu core developer and I don't know the first 
thing about how to develop or debug a boot loader. Asking me for patches 
isn't helping anyone.


If you have any suggestion in order to fix or just to diagnose the 
issue, feel free to share that with me. Meanwhile, I'll try 2.12.1 and 
look for an upgrade as Jeremy suggested.


Have a nice day,

--
Nicolas Haller



Bug#1061253: libreoffice-math: Keyboard only is a pain

2024-01-21 Thread Nicolas Patrois
Package: libreoffice-math
Version: 4:24.2.0~rc2-2
Severity: wishlist
Tags: upstream

Dear Maintainer,

With I create an equation, the keyboard focus is not in the below entry zone
but in the equation itself.
It creates truckloads of curly brackets, I don’t know why.
I must click in the entry zone below (as usual in version 7) to remove them and
to be able to edit the equation correctly.
Maybe the new equation editor’s paint is not dry yet?

Yours,
Nicolas


-- Package-specific info:
Configuration filePackage Exists Changed
/etc/libreoffice/registry/math.xcdlibreoffice-mathYes No
All deployed bundled extensions:

Identifier: com.sun.star.comp.Calc.NLPSolver
  Version: 0.9
  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/nlpsolver
  is registered: yes
  Media-Type: application/vnd.sun.star.package-bundle
  Description: Cette extension s'int\xe8gre \xe0 Calc et offre de nouveaux 
moteurs de solveur \xe0 utiliser pour optimiser les mod\xe8les de programmation 
non lin\xe9aires.

  bundled Packages: {
  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/nlpsolver/help
  is registered: yes
  Media-Type: application/vnd.sun.star.help
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/nlpsolver/components.rdb
  is registered: yes
  Media-Type: application/vnd.sun.star.uno-components
  Description: 

  }

Identifier: Dmaths
  Version: 4.4.0.0
  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths
  is registered: yes
  Media-Type: application/vnd.sun.star.package-bundle
  Description: DmathsAddon 
Copyright Didier Dorange-Pattoret (c) 2001-2017
Le logiciel Dmaths version 4.4.0.0

Apr\xe8s une premi\xe8re installation, FERMEZ et RELANCEZ compl\xe9tement 
LO/AOOo 
(apr\xe8s avoir ferm\xe9 le lanceur rapide).


Apr\xe8s une mise \xe0 jour,
\xe9crivez une formule 2/5 puis F10 (ou F8).

 

  bundled Packages: {
  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/DmInstall/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/CmathOOo/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: 
vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/OOoAHmath3D/OOoAHmath3D/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/OOoGdmath/OOoGdmath/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/Dmaths2/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/DmathsBup/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/Dmaths/
  is registered: yes
  Media-Type: application/vnd.sun.star.basic-library
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/Addons.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/OOoAHmath3D/Addons.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/OOoGdmath/addon.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/Paths.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/Accelerators.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/WriterWindowState.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/DrawWindowState.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/dmaths/ImpressWindowState.xcu
  is registered: yes
  Media-Type: application/vnd.sun.star.configuration-data
  Description: 

  }

Identifier: org.openoffice.da.writer2xhtml.oxt
  Version: 1.4
  URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/writer2xhtml
  is registered: yes
  Media-Type: application/vnd.sun.star.package-bundle
  Description: Writer2xhtml permet d'exporter les documents Writer et Calc vers 
XHTML et XHTML+MathML
  bundled Packages: {
  URL: vnd.sun.star.expand

  1   2   3   4   5   6   7   8   9   10   >