Bug#1000970: RFS: heaptrace -- helps visualize heap operations for pwn and debugging

2021-12-02 Thread Bastian Germann

Control: tags -1 moreinfo

On Thu, 2 Dec 2021 11:42:10 -0800 "Esau, Aaron"  wrote:

> The Vcs-* fields in debian/control should point to the repo where you 
maintain your debian directory.
> If you do not put it in source control directly, please remove the fields.

I'm assuming by this you meant I should only include Vcs-* if the
debian/ directory is in a separate repository? Please let me know if
not, but for now I removed these


The typical way in Debian to maintain a package via git is using 
git-buildpackage.
That uses one branch for upstream source (without debian/) and one branch for 
the changes in debian/,
merging upstream code on new releases. And usually, the packages are maintained 
in Debian's salsa Gitlab instance.
It is preferrable to maintain it that way but you can keep your current 
workflow if you like.

There is one very important tool for packaging that is called lintian. Please 
run it on your package.
Please fix at least the following lintian messages:

E: heaptrace source: source-is-missing test/double_free2
E: heaptrace source: source-is-missing test/double_free2-stripped
E: heaptrace source: source-is-missing test/double_free3
E: heaptrace source: source-is-missing test/double_free4
E: heaptrace source: source-is-missing test/double_free5
E: heaptrace source: source-is-missing test/ls
E: heaptrace source: source-is-missing test/memleak-stripped
W: heaptrace: description-starts-with-leading-spaces
W: heaptrace: initial-upload-closes-no-bugs
W: heaptrace: wrong-manual-section usr/share/man/man1/heaptrace.1.gz:3 1 != 8
I: heaptrace source: debian-watch-file-is-missing
I: heaptrace: typo-in-manual-page usr/share/man/man1/heaptrace.1.gz detatch 
detach

Also, debian/files must not be included in the git tree.



Bug#1000970: RFS: heaptrace -- helps visualize heap operations for pwn and debugging

2021-12-02 Thread Esau, Aaron
Control: tags -1 - moreinfo

On Thu, 2 Dec 2021 18:26:48 +0100 Bastian Germann  wrote:
> ...
>
> Hi Aaron,
>
> You have to target unstable or experimental with your package.
> This is Debian, not Ubuntu.
>
> Please do not ship .EX files in your debian directory.
>
> Your debian/README* files do not contain usefule info.
> Please remove them and make heaptrace-docs.docs include upstream's README.md 
> instead.
>
> The Vcs-* fields in debian/control should point to the repo where you 
> maintain your debian directory.
> If you do not put it in source control directly, please remove the fields.

I'm assuming by this you meant I should only include Vcs-* if the
debian/ directory is in a separate repository? Please let me know if
not, but for now I removed these

>
> Please use debhelper-compat to get rid of the debian/compat file.
>
> This is not a native package, so please edit debian/source/format to say "3.0 
> (quilt)" and edit the version in
> debian/changelog to end with the Debian revision "-1".
>
> Please remove unnecessary comments like at the bottom of d/copyright and in 
> d/rules.
>

Thanks for the helpful info. I made all of the changes you requested.
See: https://github.com/Arinerron/heaptrace/tree/main/debian

Updated .dsc, .changes, and source available at
https://github.com/Arinerron/heaptrace-packaging-output

> When you are done and have provided a new upload, please untag moreinfo on 
> this bug.

- Aaron



Bug#1000970: RFS: heaptrace -- helps visualize heap operations for pwn and debugging

2021-12-02 Thread Bastian Germann

Control: tags -1 moreinfo

On Wed, 1 Dec 2021 11:44:34 -0800 "Esau, Aaron"  wrote:

* Package name: heaptrace
  Version : 2.2.8
* URL : https://github.com/Arinerron/heaptrace
  Source Package  :
https://github.com/Arinerron/heaptrace-ppa/raw/main/heaptrace_2.2.8.tar.xz

https://raw.githubusercontent.com/Arinerron/heaptrace-ppa/main/heaptrace_2.2.8_source.changes

https://github.com/Arinerron/heaptrace-ppa/raw/main/heaptrace_2.2.8.dsc
  Binary Package  :
https://github.com/Arinerron/heaptrace/releases/download/2.2.8/heaptrace_2.2.8-0_x86_64.deb
* License : BSD-3-Clause
  Programming Lang: C
  Description : helps visualize heap operations for pwn and debugging

heaptrace is a heap debugger for tracking glibc heap operations in
ELF64 (x86_64) binaries. Its purpose is to help visualize heap
operations when debugging binaries or doing heap pwn.

* ITP available at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000907
* PPA package (uploading right now):
https://launchpad.net/~arinerron/+archive/ubuntu/heaptrace

I've linked to the source package and a binary package above.


Hi Aaron,

You have to target unstable or experimental with your package.
This is Debian, not Ubuntu.

Please do not ship .EX files in your debian directory.

Your debian/README* files do not contain usefule info.
Please remove them and make heaptrace-docs.docs include upstream's README.md 
instead.

The Vcs-* fields in debian/control should point to the repo where you maintain 
your debian directory.
If you do not put it in source control directly, please remove the fields.

Please use debhelper-compat to get rid of the debian/compat file.

This is not a native package, so please edit debian/source/format to say "3.0 (quilt)" and edit the version in 
debian/changelog to end with the Debian revision "-1".


Please remove unnecessary comments like at the bottom of d/copyright and in 
d/rules.

When you are done and have provided a new upload, please untag moreinfo on this 
bug.


Please let me know if there is any action I need to take--this is my
first time following this process. I'm happy to provide support, make
changes to the package or software, etc.

- Aaron






Bug#1000970: RFS: heaptrace -- helps visualize heap operations for pwn and debugging

2021-12-01 Thread Esau, Aaron
Package: wnpp
Severity: wishlist

* Package name: heaptrace
  Version : 2.2.8
* URL : https://github.com/Arinerron/heaptrace
  Source Package  :
https://github.com/Arinerron/heaptrace-ppa/raw/main/heaptrace_2.2.8.tar.xz

https://raw.githubusercontent.com/Arinerron/heaptrace-ppa/main/heaptrace_2.2.8_source.changes

https://github.com/Arinerron/heaptrace-ppa/raw/main/heaptrace_2.2.8.dsc
  Binary Package  :
https://github.com/Arinerron/heaptrace/releases/download/2.2.8/heaptrace_2.2.8-0_x86_64.deb
* License : BSD-3-Clause
  Programming Lang: C
  Description : helps visualize heap operations for pwn and debugging

heaptrace is a heap debugger for tracking glibc heap operations in
ELF64 (x86_64) binaries. Its purpose is to help visualize heap
operations when debugging binaries or doing heap pwn.

* ITP available at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000907
* PPA package (uploading right now):
https://launchpad.net/~arinerron/+archive/ubuntu/heaptrace

I've linked to the source package and a binary package above.

Please let me know if there is any action I need to take--this is my
first time following this process. I'm happy to provide support, make
changes to the package or software, etc.

- Aaron