Bug#1001853: nanomsg: reproducible-builds: BuildId differences triggered by RPATH

2023-01-10 Thread Chris Lamb
tags 1001853 + pending patch
thanks

I've just RE-uploaded nanomsg 1.1.5+dfsg-1.1 to DELAYED/10:

  nanomsg (1.1.5+dfsg-1.1) unstable; urgency=medium

* Non-maintainer upload.
* Apply a patch by Vagrant Cascadian to address Build-Id differences in
  binaries caused by a difference in RPATH. (Closes: #1001853)

This was because the previous upload did not include the
actual/required change to debian/rules. The full debdiff, which
reflects this, is attached. Thanks, Vagrant!


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diffstat for nanomsg-1.1.5+dfsg nanomsg-1.1.5+dfsg

 changelog |8 
 rules |3 +++
 2 files changed, 11 insertions(+)

diff -Nru nanomsg-1.1.5+dfsg/debian/changelog 
nanomsg-1.1.5+dfsg/debian/changelog
--- nanomsg-1.1.5+dfsg/debian/changelog 2018-10-22 01:17:21.0 +0100
+++ nanomsg-1.1.5+dfsg/debian/changelog 2023-01-10 16:33:43.0 +
@@ -1,3 +1,11 @@
+nanomsg (1.1.5+dfsg-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Apply a patch by Vagrant Cascadian to address Build-Id differences in
+binaries caused by a difference in RPATH. (Closes: #1001853)
+
+ -- Chris Lamb   Tue, 10 Jan 2023 16:33:43 +
+
 nanomsg (1.1.5+dfsg-1) unstable; urgency=medium
 
   * New watch file.
diff -Nru nanomsg-1.1.5+dfsg/debian/rules nanomsg-1.1.5+dfsg/debian/rules
--- nanomsg-1.1.5+dfsg/debian/rules 2018-10-22 00:09:34.0 +0100
+++ nanomsg-1.1.5+dfsg/debian/rules 2023-01-10 16:33:43.0 +
@@ -3,3 +3,6 @@
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 %:
dh $@ --buildsystem=cmake
+
+override_dh_auto_configure:
+   dh_auto_configure -- -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON


Bug#1001853: nanomsg: reproducible-builds: BuildId differences triggered by RPATH

2023-01-10 Thread Chris Lamb
Vagrant Cascadian wrote:

> This seems to be missing some diff other than the debian/changelog...
> does the upload contain the patch?

Great spot; I will fix this right away.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-



Bug#1001853: nanomsg: reproducible-builds: BuildId differences triggered by RPATH

2023-01-10 Thread Vagrant Cascadian
On 2023-01-10, Chris Lamb wrote:
> I've just uploaded nanomsg 1.1.5+dfsg-1.1 to DELAYED/10:
...
> The full debdiff is attached.
...
> diffstat for nanomsg-1.1.5+dfsg nanomsg-1.1.5+dfsg
>
>  changelog |8 
>  1 file changed, 8 insertions(+)
>
> diff -Nru nanomsg-1.1.5+dfsg/debian/changelog 
> nanomsg-1.1.5+dfsg/debian/changelog
> --- nanomsg-1.1.5+dfsg/debian/changelog   2018-10-22 01:17:21.0 
> +0100
> +++ nanomsg-1.1.5+dfsg/debian/changelog   2023-01-10 16:33:43.0 
> +
> @@ -1,3 +1,11 @@
> +nanomsg (1.1.5+dfsg-1.1) unstable; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Apply a patch by Vagrant Cascadian to address Build-Id differences in
> +binaries caused by a difference in RPATH. (Closes: #1001853)
> +
> + -- Chris Lamb   Tue, 10 Jan 2023 16:33:43 +
> +
>  nanomsg (1.1.5+dfsg-1) unstable; urgency=medium
>  
>* New watch file.

This seems to be missing some diff other than the debian/changelog...
does the upload contain the patch?

live well,
  vagrant


signature.asc
Description: PGP signature


Bug#1001853: nanomsg: reproducible-builds: BuildId differences triggered by RPATH

2023-01-10 Thread Chris Lamb
tags 1001853 + pending patch
thanks

I've just uploaded nanomsg 1.1.5+dfsg-1.1 to DELAYED/10:
  
  nanomsg (1.1.5+dfsg-1.1) unstable; urgency=medium
  .
* Non-maintainer upload.
* Apply a patch by Vagrant Cascadian to address Build-Id differences in
  binaries caused by a difference in RPATH. (Closes: #1001853)

The full debdiff is attached.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diffstat for nanomsg-1.1.5+dfsg nanomsg-1.1.5+dfsg

 changelog |8 
 1 file changed, 8 insertions(+)

diff -Nru nanomsg-1.1.5+dfsg/debian/changelog 
nanomsg-1.1.5+dfsg/debian/changelog
--- nanomsg-1.1.5+dfsg/debian/changelog 2018-10-22 01:17:21.0 +0100
+++ nanomsg-1.1.5+dfsg/debian/changelog 2023-01-10 16:33:43.0 +
@@ -1,3 +1,11 @@
+nanomsg (1.1.5+dfsg-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Apply a patch by Vagrant Cascadian to address Build-Id differences in
+binaries caused by a difference in RPATH. (Closes: #1001853)
+
+ -- Chris Lamb   Tue, 10 Jan 2023 16:33:43 +
+
 nanomsg (1.1.5+dfsg-1) unstable; urgency=medium
 
   * New watch file.


Bug#1001853: nanomsg: reproducible-builds: BuildId differences triggered by RPATH

2021-12-17 Thread Vagrant Cascadian
Source: nanomsg
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/nanomsg.html

The attached patch to debian/rules passes
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
which should use a relative path for RPATH.

With this patch applied, nanomsg should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining nanomsg!


live well,
  vagrant
From 0f6ae01660591007bcd9ca199aca23c2b3cad2c1 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian 
Date: Fri, 17 Dec 2021 19:59:47 +
Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure override.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/build_id_differences_only_issue.html
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index a856ca4..f0974c6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,3 +3,6 @@
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 %:
 	dh $@ --buildsystem=cmake
+
+override_dh_auto_configure:
+	dh_auto_configure -- -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON
-- 
2.34.1



signature.asc
Description: PGP signature