Bug#1003298: vim-gtk3: Wrong colors and font in terminal in 2:8.2.3995-1

2022-01-08 Thread Håvard Moen
On Sunday, January 9th, 2022 at 8:05 AM, James McCoy  
wrote:
> There were a couple of issues in Vim that led to this change in
>
> behavior, due to wanting the terminal running Vim's normal colors to be
>
> used if Vim's highlight groups didn't specify any colors.
>
> -   https://github.com/vim/vim/issues/2361
>
> -   https://github.com/vim/vim/issues/9058
>
> However, the documentation also looks like this is intended behavior.
>
> From “:help terminal-size-color”:
>
> For a color terminal the 'background' option is used to decide whether the
>
> terminal window will start with a white or black background.
>
> To use a different color the Terminal highlight group can be used, for
>
> example: >
>
>   hi Terminal ctermbg=lightgrey ctermfg=blue guibg=lightgrey 
> guifg=blue
>
>
>
> Does adding “au ColorScheme * hi link Terminal Normal” to your vimrc
>
> behave more like you're expecting?
>
> If not, maybe the changes for terminal Vim and an adverse effect on GUI

Hi

"au ColorScheme * hi link Terminal Normal" in vimrc did not work, but just "hi 
link Terminal Normal" worked and everything is correct again.

Thanks so much for the help.

Regards
Håvard



Bug#1003298: vim-gtk3: Wrong colors and font in terminal in 2:8.2.3995-1

2022-01-08 Thread James McCoy
On Sun, Jan 09, 2022 at 03:47:40AM +, Håvard Moen wrote:
> On Sunday, January 9th, 2022 at 2:30 AM, James McCoy  
> wrote:
>  
> 
> > Some more details about how things differ would be useful. Maybe even
> > 
> 
> > screen shots.
> 
> Attaching screenshots showing the difference. I also see that popups as used 
> for instance by https://github.com/junegunn/fzf.vim also has the wrong colors.
> Another thing I now see and which is show in the screenshots, is that when 
> going to normal mode in the terminal, the part of the terminal without text 
> get the right color.

There were a couple of issues in Vim that led to this change in
behavior, due to wanting the terminal running Vim's normal colors to be
used if Vim's highlight groups didn't specify any colors.

* https://github.com/vim/vim/issues/2361
* https://github.com/vim/vim/issues/9058

However, the documentation also looks like this is intended behavior.
From “:help terminal-size-color”:

For a color terminal the 'background' option is used to decide whether 
the
terminal window will start with a white or black background.

To use a different color the Terminal highlight group can be used, for
example: >
hi Terminal ctermbg=lightgrey ctermfg=blue guibg=lightgrey 
guifg=blue

Does adding “au ColorScheme * hi link Terminal Normal” to your vimrc
behave more like you're expecting?

If not, maybe the changes for terminal Vim and an adverse effect on GUI
Vim.

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB


signature.asc
Description: PGP signature


Bug#1003298: vim-gtk3: Wrong colors and font in terminal in 2:8.2.3995-1

2022-01-08 Thread James McCoy
Control: found -1 2:8.2.3995-1
Control: notfound -1 2:8.2.2434-3+deb11u1

On Fri, Jan 07, 2022 at 07:30:35PM +0100, Håvard Moen wrote:
> I upgraded vim-gtk3 to version 2:8.2.3995-1 that is in unstable, but
> noticed that the colors and font in the terminal (:terminal) is not
> set from my configuration. In the version in testing
> (2:8.2.2434-3+deb11u1) it works as it should.

Note, that is stable, not testing.  Adjusting found/notfound values
according to your description.

Some more details about how things differ would be useful.  Maybe even
screen shots.

There /was/ a bug fix in Vim in regard to the handling of
g:terminal_ansi_colors, but that was to fix an issue where it was
showing incorrect colors before and now shows the correct colors.  So,
are you sure the colors you're seeing now are /wrong/ or just different
than you're used to?

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB