Bug#1003497: who-uploads don't show u...@debian.org email default
Hi Lin,
在 2022/1/13 21:06, Lance Lin 写道:
Hi Mattia, Xiao Sheng Wen,
looking, it has this:
249 »UPLOADER=$($GPG $GPG_OPTIONS \
250 » "${GPG_DEFAULT_KEYRINGS[@]}" "${GPG_KEYRINGS[@]}" \
251 » --list-key --with-colons --fixed-list-mode $GPG_ID
2>/dev/null |
252 » awk -F: '/@debian\.org>/ { a = $10; exit} /^uid/ { a = $10;
exit} END { print a }' )
So it already has something to handle what you ask, that is clearly not
working.
Probably somebody should try to debug those few lines.
(and don't be ... bothered ... by the way it gather that data… scraping
web pages was a good idea 15 years ago)
I believe have a fix for the issue. I made a merge request on salsa for your
review.
Yes, your MR partly fix this question in code.
One suggestion is:
It's check the string "@debian.org" is enough, not need tailer >
awk -F: '/@debian\.org>/ >
awk -F: '/@debian\.org/
As some DD's public key not use entry, only has
u...@debian.org entry.
The issue is that the code above parses the key, however, this will only check
the first email address on the key. If this first uid is a debian.org email, it
will use it. Otherwise, this will pull the first uid email (non-debian). It
seems the assumption is the first email uid on the key will always be
@debian.org.
For the fix, I searched the entire key for @debian.org. If that is not found,
search for a non-debian uid email to report back.
If DD's public key don't has the @debian.org entry, who-uploads still
reply other email address.
A few test cases were the packages 'ucf' and 'tcsh'. The current version will
not return a debian.org email for Thomas Lange (tcsh) or Manoj Srivastava
(ucf). My version will return their @debian.org emails.
Please take a look and let me know your thoughts!
Lance Lin
GPG Fingerprint: 8CAD 1250 8EE0 3A41 7223 03EC 7096 F91E D75D 028F
BTW:
Your MR in line 256, has one trailing-whitespace , please delete it.
https://salsa.debian.org/debian/devscripts/-/merge_requests/260/diffs#ae7a6fd5b69ead4ea3e2f56f706397082357ad17_253_256
If you use vim, put the following in your .vimrc :
highlight RedundantSpaces ctermbg=red guibg=red
match RedundantSpaces /\s\+$/
You'll see the trailing-whitespace easy, :-)
Thanks!
--
肖盛文 xiao sheng wen Faris Xiao
微信(wechat)：atzlinux
《铜豌豆 Linux》https://www.atzlinux.com
基于 Debian 的 Linux 中文 桌面 操作系统
Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com
GnuPG Public Key: 0x00186602339240CB
OpenPGP_0x00186602339240CB.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
Bug#1003497: who-uploads don't show u...@debian.org email default
also send to debian-keyr...@packages.debian.org 在 2022/1/13 00:31, Mattia Rizzolo 写道: On Wed, Jan 12, 2022 at 12:35:36PM +0800, xiao sheng wen wrote: I think it's not a bug of who-uploads itself, but also the public key of DD. If the public key of DD has not set one uid entry formated as: Name who-uploads will not show u...@debian.org email. Is need forward this bug to debian-keyring package? If that's the case (note that I didn't look at this at all, besides looking up where the relevant code was), then it's not something we can fix at all, and debian-keyring also can't do anything about it. I'm not know the process of make debian-keyring package. If debian-keyring can do this check will also better. The UIDs of a GPG key can only be changed by the key owner, so at most you'd have to privately tell each people to add such UIDs, and in the end it also remains that they might not agree. Is there any rules about DD uploader's gpg public key used in keyring.debian.org? It's only has "Name " uid entry in keyring.debian.org's key is enough. It's not need upload this public key to other public keyserver. Thanks! -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_0x00186602339240CB.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Bug#1003497: who-uploads don't show u...@debian.org email default
On Wed, Jan 12, 2022 at 12:35:36PM +0800, xiao sheng wen wrote: > I think it's not a bug of who-uploads itself, but also the public key of DD. > > If the public key of DD has not set one uid entry formated as: > > Name > > who-uploads will not show u...@debian.org email. > > > Is need forward this bug to debian-keyring package? If that's the case (note that I didn't look at this at all, besides looking up where the relevant code was), then it's not something we can fix at all, and debian-keyring also can't do anything about it. The UIDs of a GPG key can only be changed by the key owner, so at most you'd have to privately tell each people to add such UIDs, and in the end it also remains that they might not agree. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Bug#1003497: who-uploads don't show u...@debian.org email default
Hi Mattia,
Thanks for your reply.
在 2022/1/11 19:39, Mattia Rizzolo 写道:
Control: tag -1 newcomer
On Tue, Jan 11, 2022 at 11:49:06AM +0800, xiao sheng wen wrote:
The DD's gpg key may has many uid email address.
I hope that who-uploads respond the official u...@debian.org email default.
who-uploads is a simple shell script, parsing the output of gpg.
looking, it has this:
249 »UPLOADER=$($GPG $GPG_OPTIONS \
250 » "${GPG_DEFAULT_KEYRINGS[@]}" "${GPG_KEYRINGS[@]}" \
251 » --list-key --with-colons --fixed-list-mode $GPG_ID
2>/dev/null |
252 » awk -F: '/@debian\.org>/ { a = $10; exit} /^uid/ { a = $10;
exit} END { print a }' )
So it already has something to handle what you ask, that is clearly not
working.
Probably somebody should try to debug those few lines.
I think it's not a bug of who-uploads itself, but also the public key of DD.
If the public key of DD has not set one uid entry formated as:
Name
who-uploads will not show u...@debian.org email.
Is need forward this bug to debian-keyring package?
(and don't be ... bothered ... by the way it gather that data… scraping
web pages was a good idea 15 years ago)
--
肖盛文 xiao sheng wen Faris Xiao
微信(wechat)：atzlinux
《铜豌豆 Linux》https://www.atzlinux.com
基于 Debian 的 Linux 中文 桌面 操作系统
Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com
GnuPG Public Key: 0x00186602339240CB
OpenPGP_0x00186602339240CB.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
Bug#1003497: who-uploads don't show u...@debian.org email default
Control: tag -1 newcomer
On Tue, Jan 11, 2022 at 11:49:06AM +0800, xiao sheng wen wrote:
> The DD's gpg key may has many uid email address.
> I hope that who-uploads respond the official u...@debian.org email default.
who-uploads is a simple shell script, parsing the output of gpg.
looking, it has this:
249 »UPLOADER=$($GPG $GPG_OPTIONS \
250 » "${GPG_DEFAULT_KEYRINGS[@]}" "${GPG_KEYRINGS[@]}" \
251 » --list-key --with-colons --fixed-list-mode $GPG_ID
2>/dev/null |
252 » awk -F: '/@debian\.org>/ { a = $10; exit} /^uid/ { a = $10;
exit} END { print a }' )
So it already has something to handle what you ask, that is clearly not
working.
Probably somebody should try to debug those few lines.
(and don't be ... bothered ... by the way it gather that data… scraping
web pages was a good idea 15 years ago)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
Bug#1003497: who-uploads don't show u...@debian.org email default
Package: devscripts Version: 2.21.7 Severity: wishlist X-Debbugs-Cc: atzli...@sina.com, b...@debian.org Hi, The DD's gpg key may has many uid email address. I hope that who-uploads respond the official u...@debian.org email default. Thanks! -- Package-specific info: --- /etc/devscripts.conf --- Empty. --- ~/.devscripts --- DEBSIGN_ALWAYS_RESIGN=yes DEBSIGN_KEYID="740D7FE2AB3143E86C8FD12300186602339240CB" -- System Information: Debian Release: 11.2 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'proposed-updates'), (500, 'unstable'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.10.0-10-amd64 (SMP w/4 CPU threads) Locale: LANG=zh_CN.UTF-8, LC_CTYPE=zh_CN.UTF-8 (charmap=[proxychains] DLL init: proxychains-ng 4.14 [proxychains] DLL init: proxychains-ng 4.14 UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages devscripts depends on: ii dpkg-dev 1.20.9 ii fakeroot 1.25.3-1.1 ii file 1:5.39-3 ii gnupg 2.3.1-1 ii gpgv 2.3.1-1 ii libc6 2.33-1 ii libfile-dirlist-perl 0.05-2 ii libfile-homedir-perl 1.006-1 ii libfile-touch-perl0.11-1 ii libfile-which-perl1.23-1 ii libipc-run-perl 20200505.0-1 ii libmoo-perl 2.004004-1 ii libwww-perl 6.52-1 ii patchutils0.4.2-1 ii perl 5.32.1-4+deb11u2 ii python3 3.9.2-3 ii sensible-utils0.0.14 ii wdiff 1.2.2-2+b1 Versions of packages devscripts recommends: ii apt 2.2.4 ii curl7.74.0-1.3+deb11u1 ii dctrl-tools 2.24-3+b1 ii debian-keyring 2021.09.25 ii dput1.1.0 ii dupload 2.9.7 pn equivs ii libdistro-info-perl 1.0 ii libdpkg-perl1.20.9 ii libencode-locale-perl 1.05-1.1 pn libgit-wrapper-perl pn libgitlab-api-v4-perl ii liblist-compare-perl0.55-1 ii liblwp-protocol-https-perl 6.10-1 ii libsoap-lite-perl 1.27-1 pn libstring-shellquote-perl ii libtry-tiny-perl0.30-1 ii liburi-perl 5.08-1 ii licensecheck3.2.11-1 ii lintian 2.114.0 ii man-db 2.9.4-2 ii patch 2.7.6-7 ii pristine-tar1.49 ii python3-apt 2.2.1 ii python3-debian 0.1.39 ii python3-magic 2:0.4.20-3 ii python3-requests2.25.1+dfsg-2 pn python3-unidiff ii python3-xdg 0.27-2 ii strace 5.10-1 ii unzip 6.0-26ubuntu1 ii wget1.21-1+deb11u1 ii xz-utils5.2.5-2 Versions of packages devscripts suggests: pn adequate pn at pn autopkgtest ii bls-standalone 0.20151231+b1 pn bsd-mailx | mailx ii build-essential 12.9 pn check-all-the-things pn cvs-buildpackage ii debhelper13.5.2 ii diffoscope 196 ii disorderfs 0.5.11-2 pn dose-extra pn duck pn elpa-devscripts ii faketime 0.9.8-9 pn gnuplot pn how-can-i-help ii libauthen-sasl-perl 2.1600-1.1 pn libdbd-pg-perl ii libfile-desktopentry-perl0.22-2 pn libnet-smtps-perl pn libterm-size-perl ii libtimedate-perl 2.3300-2 pn libyaml-syck-perl pn mmdebstrap pn mozilla-devscripts pn mutt ii openssh-client [ssh-client] 1:8.4p1-5 pn piuparts pn postgresql-client pn pristine-lfs ii quilt0.66-2.1 pn ratt ii reprotest0.7.19 pn svn-buildpackage ii w3m 0.5.3+git20210102-6 -- debconf information excluded -- debsums errors found: [proxychains] DLL init: proxychains-ng 4.14 [proxychains] DLL init: proxychains-ng 4.14 [proxychains] DLL init: proxychains-ng 4.14 [proxychains] DLL init: proxychains-ng 4.14 [proxychains] DLL init: proxychains-ng 4.14 [proxychains] DLL init: proxychains-ng 4.14
