Bug#1007051: libao: please consider upgrading to 3.0 source format

2024-02-21 Thread Bastian Germann

I am uploading a NMU to DELAYED/10 in order to fix this.
Please find the debdiff attached.diff -Nru libao-1.2.2+20180113/configure libao-1.2.2+20180113/configure
--- libao-1.2.2+20180113/configure  2024-02-21 13:07:19.0 +
+++ libao-1.2.2+20180113/configure  2018-01-13 09:49:20.0 +
@@ -13010,6 +13010,18 @@
 
 
 have_roar="no";
+for ac_header in libroar/config.h
+do :
+  ac_fn_c_check_header_mongrel "$LINENO" "libroar/config.h" 
"ac_cv_header_libroar_config_h" "$ac_includes_default"
+if test "x$ac_cv_header_libroar_config_h" = xyes; then :
+  cat >>confdefs.h <<_ACEOF
+#define HAVE_LIBROAR_CONFIG_H 1
+_ACEOF
+ have_roar=yes
+fi
+
+done
+
 if test "x$have_roar" = "xyes"; then
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking if SLP lookup can be 
disabled in libroar" >&5
 $as_echo_n "checking if SLP lookup can be disabled in libroar... " >&6; }
diff -Nru libao-1.2.2+20180113/configure.ac libao-1.2.2+20180113/configure.ac
--- libao-1.2.2+20180113/configure.ac   2024-02-21 13:07:19.0 +
+++ libao-1.2.2+20180113/configure.ac   2018-01-13 09:49:20.0 +
@@ -327,7 +327,7 @@
 dnl Check for roaraudio
 
 have_roar="no";
-dnl AC_CHECK_HEADERS(libroar/config.h, have_roar=yes)
+AC_CHECK_HEADERS(libroar/config.h, have_roar=yes)
 if test "x$have_roar" = "xyes"; then
AC_MSG_CHECKING([if SLP lookup can be disabled in libroar])
AC_COMPILE_IFELSE([AC_LANG_SOURCE([
diff -Nru libao-1.2.2+20180113/debian/changelog 
libao-1.2.2+20180113/debian/changelog
--- libao-1.2.2+20180113/debian/changelog   2024-02-21 13:07:19.0 
+
+++ libao-1.2.2+20180113/debian/changelog   2024-02-21 12:57:19.0 
+
@@ -1,3 +1,13 @@
+libao (1.2.2+20180113-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Convert to source format 3.0 (quilt).  Closes: #1007051
+
+  [ Helmut Grohne ]
+  * Drop unused Build-Depends: libxt-dev.  Closes: #981657
+
+ -- Bastian Germann   Wed, 21 Feb 2024 12:57:19 +
+
 libao (1.2.2+20180113-1.1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff -Nru libao-1.2.2+20180113/debian/control 
libao-1.2.2+20180113/debian/control
--- libao-1.2.2+20180113/debian/control 2024-02-21 13:07:19.0 +
+++ libao-1.2.2+20180113/debian/control 2024-02-21 12:57:19.0 +
@@ -5,7 +5,7 @@
 Uploaders: John Francesco Ferlito 
 Build-Depends: autotools-dev, debhelper (>= 9),
   libasound2-dev [linux-any],
-  libaudio-dev, libpulse-dev, libxt-dev, libxau-dev, libsndio-dev
+  libaudio-dev, libpulse-dev, libxau-dev, libsndio-dev
 Standards-Version: 4.1.3.0
 Homepage: http://www.xiph.org/ao/
 Vcs-Git: git://git.debian.org/users/ron/libao.git
diff -Nru libao-1.2.2+20180113/debian/patches/roar.patch 
libao-1.2.2+20180113/debian/patches/roar.patch
--- libao-1.2.2+20180113/debian/patches/roar.patch  1970-01-01 
00:00:00.0 +
+++ libao-1.2.2+20180113/debian/patches/roar.patch  2024-02-21 
12:57:19.0 +
@@ -0,0 +1,43 @@
+Description: Remove libroar
+---
+--- libao-1.2.2+20180113.orig/configure.ac
 libao-1.2.2+20180113/configure.ac
+@@ -327,7 +327,7 @@ AM_CONDITIONAL(HAVE_SNDIO_AUDIO,test "${
+ dnl Check for roaraudio
+ 
+ have_roar="no";
+-AC_CHECK_HEADERS(libroar/config.h, have_roar=yes)
++dnl AC_CHECK_HEADERS(libroar/config.h, have_roar=yes)
+ if test "x$have_roar" = "xyes"; then
+AC_MSG_CHECKING([if SLP lookup can be disabled in libroar])
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([
+--- libao-1.2.2+20180113.orig/libao.conf.5
 libao-1.2.2+20180113/libao.conf.5
+@@ -48,7 +48,7 @@ may be used as well as those keys.
+ .IP default_driver
+ The short name of the driver libao should use by default.  Valid values
+ include (not all are available on every platform): pulse, oss, esd, arts, 
alsa,
+-nas, irix, sun, roar and sndio.  Note that "sun" is used on many BSD
++nas, irix, sun, and sndio.  Note that "sun" is used on many BSD
+ systems as well as Solaris.
+ .IP "debug (Value optional/ignored)"
+ Sets all the drivers as well as AO itself into debugging output mode.
+--- libao-1.2.2+20180113.orig/src/plugins/Makefile.am
 libao-1.2.2+20180113/src/plugins/Makefile.am
+@@ -1,4 +1,4 @@
+ ## Process this file with automake to produce Makefile.in
+ 
+ AUTOMAKE_OPTIONS = foreign
+-SUBDIRS = oss esd arts alsa sun irix macosx nas pulse sndio roar
++SUBDIRS = oss esd arts alsa sun irix macosx nas pulse sndio
+--- libao-1.2.2+20180113.orig/src/plugins/Makefile.in
 libao-1.2.2+20180113/src/plugins/Makefile.in
+@@ -320,7 +320,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ AUTOMAKE_OPTIONS = foreign
+-SUBDIRS = oss esd arts alsa sun irix macosx nas pulse sndio roar
++SUBDIRS = oss esd arts alsa sun irix macosx nas pulse sndio
+ all: all-recursive
+ 
+ .SUFFIXES:
diff -Nru libao-1.2.2+20180113/debian/patches/series 
libao-1.2.2+20180113/debian/patches/series
--- libao-1.2.2+20180113/debian/patches/series  

Bug#1007051: libao: please consider upgrading to 3.0 source format

2022-03-10 Thread Lucas Nussbaum
Source: libao
Version: 1.2.2+20180113-1.1
Severity: wishlist
Tags: bookworm sid
Usertags: format1.0 format1.0-kp-nv

Dear maintainer,

This package is among the few (1.9%) that still use source format 1.0 in
bookworm.  Please upgrade it to source format 3.0, as (1) this format has many
advantages, as documented in https://wiki.debian.org/Projects/DebSrc3.0 ; (2)
this contributes to standardization of packaging practices.

Please note that this is also a sign that the packaging of this software
could maybe benefit from a refresh. It might be a good opportunity to
look at other aspects as well.

This mass bug filing was discussed on debian-devel@:
https://lists.debian.org/debian-devel/2022/03/msg00074.html

Thanks

Lucas