Bug#1007274: asmail: please consider upgrading to 3.0 source format

2023-10-02 Thread Bastian Germann

I am uploading a NMU to DELAYED/10 in order to fix this.
Please find the debdiff attached.diff -Nru asmail-2.1/asmail.c asmail-2.1/asmail.c
--- asmail-2.1/asmail.c 2023-10-02 22:56:43.0 +0200
+++ asmail-2.1/asmail.c 2007-04-09 09:46:38.0 +0200
@@ -70,10 +70,6 @@
  * Set up the defaults that cannot be determined at compile time.
  */
 void defaults() {
-   if (getenv("HOME") == NULL) {
-   fprintf(stderr, "missing HOME variable\n");
-   exit(1);
-   }
strncpy(config_file_name, (char *) getenv("HOME"), MAX_INPUT_LENGTH);
strncat(config_file_name, "/", 
MAX_INPUT_LENGTH-strlen(config_file_name));
strncat(config_file_name, RCFILE, 
MAX_INPUT_LENGTH-strlen(config_file_name));
diff -Nru asmail-2.1/asmailrc.sample asmail-2.1/asmailrc.sample
--- asmail-2.1/asmailrc.sample  2023-10-02 22:56:43.0 +0200
+++ asmail-2.1/asmailrc.sample  2007-02-27 19:19:38.0 +0100
@@ -38,8 +38,8 @@
# animation refresh rate in 1/100 sec
refresh 10
# xpm picture files
-   frame none
-   #frame 
/usr/local/share/afterstep/desktop/icons/16bpp/ASBBlockTransparent.xpm
+   #frame none
+   frame 
/usr/local/share/afterstep/desktop/icons/16bpp/ASBBlockTransparent.xpm
nomail /usr/local/share/asmail/pixmaps/e-no.xpm
old /usr/local/share/asmail/pixmaps/e0.xpm
new /usr/local/share/asmail/pixmaps/e1.xpm
diff -Nru asmail-2.1/autoconf/config.h.in asmail-2.1/autoconf/config.h.in
--- asmail-2.1/autoconf/config.h.in 2023-10-02 22:56:43.0 +0200
+++ asmail-2.1/autoconf/config.h.in 2003-06-23 06:44:04.0 +0200
@@ -13,7 +13,7 @@
 #undef HAVE_MACHINE_SOUNDCARD_H
 
 /* Define if you have the  header file.  */
-//#undef HAVE_OPENSSL_SSL_H
+#undef HAVE_OPENSSL_SSL_H
 
 /* Define if you have the  header file.  */
 #undef HAVE_PTHREAD_H
diff -Nru asmail-2.1/configure asmail-2.1/configure
--- asmail-2.1/configure2023-10-02 22:56:43.0 +0200
+++ asmail-2.1/configure2007-04-09 09:50:33.0 +0200
@@ -2000,7 +2000,7 @@
   echo $ac_n "(cached) $ac_c" 1>&6
 else
   ac_save_LIBS="$LIBS"
-#LIBS="-lICE $X_EXTRA_LIBS $LIBS"
+LIBS="-lICE $X_EXTRA_LIBS $LIBS"
 cat > conftest.$ac_ext <&6
-#  X_PRE_LIBS="$X_PRE_LIBS -lSM -lICE"
+  X_PRE_LIBS="$X_PRE_LIBS -lSM -lICE"
 else
   echo "$ac_t""no" 1>&6
 fi
@@ -2745,7 +2745,7 @@
 fi
 if eval "test \"`echo '$ac_cv_lib_'$ac_lib_var`\" = yes"; then
   echo "$ac_t""yes" 1>&6
-#  SSL_LIB="-lssl" HAVESSL="-lssl"
+  SSL_LIB="-lssl" HAVESSL="-lssl"
 else
   echo "$ac_t""no" 1>&6
 fi
diff -Nru asmail-2.1/debian/changelog asmail-2.1/debian/changelog
--- asmail-2.1/debian/changelog 2023-10-02 22:56:43.0 +0200
+++ asmail-2.1/debian/changelog 2023-10-02 22:53:08.0 +0200
@@ -1,3 +1,10 @@
+asmail (2.1-5.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * Convert to source format 3.0 (closes: #1007274)
+
+ -- Bastian Germann   Mon, 02 Oct 2023 22:53:08 +0200
+
 asmail (2.1-5) unstable; urgency=medium
 
   * Fix FTCBFS: Export a suitable CC for ./configure. (closes: #928322)
diff -Nru asmail-2.1/debian/patches/debian.patch 
asmail-2.1/debian/patches/debian.patch
--- asmail-2.1/debian/patches/debian.patch  1970-01-01 01:00:00.0 
+0100
+++ asmail-2.1/debian/patches/debian.patch  2023-10-02 22:53:08.0 
+0200
@@ -0,0 +1,86 @@
+--- asmail-2.1.orig/asmail.c
 asmail-2.1/asmail.c
+@@ -70,6 +70,10 @@ static void err_printf(char const *tmpl,
+  * Set up the defaults that cannot be determined at compile time.
+  */
+ void defaults() {
++  if (getenv("HOME") == NULL) {
++  fprintf(stderr, "missing HOME variable\n");
++  exit(1);
++  }
+   strncpy(config_file_name, (char *) getenv("HOME"), MAX_INPUT_LENGTH);
+   strncat(config_file_name, "/", 
MAX_INPUT_LENGTH-strlen(config_file_name));
+   strncat(config_file_name, RCFILE, 
MAX_INPUT_LENGTH-strlen(config_file_name));
+--- asmail-2.1.orig/asmailrc.sample
 asmail-2.1/asmailrc.sample
+@@ -38,8 +38,8 @@ x11 {
+   # animation refresh rate in 1/100 sec
+   refresh 10
+   # xpm picture files
+-  #frame none
+-  frame 
/usr/local/share/afterstep/desktop/icons/16bpp/ASBBlockTransparent.xpm
++  frame none
++  #frame 
/usr/local/share/afterstep/desktop/icons/16bpp/ASBBlockTransparent.xpm
+   nomail /usr/local/share/asmail/pixmaps/e-no.xpm
+   old /usr/local/share/asmail/pixmaps/e0.xpm
+   new /usr/local/share/asmail/pixmaps/e1.xpm
+--- asmail-2.1.orig/autoconf/config.h.in
 asmail-2.1/autoconf/config.h.in
+@@ -13,7 +13,7 @@
+ #undef HAVE_MACHINE_SOUNDCARD_H
+ 
+ /* Define if you have the  header file.  */
+-#undef HAVE_OPENSSL_SSL_H
++//#undef HAVE_OPENSSL_SSL_H
+ 
+ /* Define if you have the  header file.  */
+ #undef 

Bug#1007274: asmail: please consider upgrading to 3.0 source format

2023-08-16 Thread Bastian Germann
If you do not want to move to format 3.0, please at least specify 1.0 
format so that dpkg-source can move to default 3.0 format.




Bug#1007274: asmail: please consider upgrading to 3.0 source format

2022-03-15 Thread Lucas Nussbaum
Source: asmail
Version: 2.1-5
Severity: wishlist
Tags: bookworm sid
Usertags: format1.0 format1.0-nkp-nv

Dear maintainer,

This package is among the few (1.9%) that still use source format 1.0 in
bookworm.  Please upgrade it to source format 3.0, as (1) this format has many
advantages, as documented in https://wiki.debian.org/Projects/DebSrc3.0 ; (2)
this contributes to standardization of packaging practices.

Please note that this is also a sign that the packaging of this software
could maybe benefit from a refresh. It might be a good opportunity to
look at other aspects as well.

It was noticed in https://lists.debian.org/debian-devel/2022/03/msg00096.html
that the conversion for this package is likely trivial, and builds bit-by-bit
identical binary packages.


This mass bug filing was discussed on debian-devel@:
https://lists.debian.org/debian-devel/2022/03/msg00074.html

Thanks

Lucas