Bug#1007546: d52: please consider upgrading to 3.0 source format

2024-03-24 Thread Bastian Germann

I am uploading a NMU to DELAYED/10 in order to fix this.
The debdiff is attached.diff -Nru d52-3.4.1/debian/changelog d52-3.4.1/debian/changelog
--- d52-3.4.1/debian/changelog  2024-03-24 20:20:10.0 +
+++ d52-3.4.1/debian/changelog  2024-03-24 20:03:49.0 +
@@ -1,3 +1,11 @@
+d52 (3.4.1-1.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Convert to source format 3.0. (Closes: #1007546)
+  * d/copyright: Convert to machine-readable format. (Closes: #898214, #977211)
+
+ -- Bastian Germann   Sun, 24 Mar 2024 20:03:49 +
+
 d52 (3.4.1-1.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru d52-3.4.1/debian/control d52-3.4.1/debian/control
--- d52-3.4.1/debian/control2024-03-24 20:20:10.0 +
+++ d52-3.4.1/debian/control2024-03-24 20:03:49.0 +
@@ -4,7 +4,7 @@
 Maintainer: Uwe Hermann 
 Build-Depends: cdbs, debhelper (>= 5)
 Standards-Version: 3.7.3
-Homepage: http://home.pacbell.net/theposts
+Homepage: https://github.com/jblang/d52
 
 Package: d52
 Architecture: any
@@ -16,4 +16,3 @@
   - d52: a disassembler for 8052 code,
   - d48: a disassembler for 8048/8041 code,
   - dz80: a disassembler for Z80/8080/8085 code.
-
diff -Nru d52-3.4.1/debian/copyright d52-3.4.1/debian/copyright
--- d52-3.4.1/debian/copyright  2024-03-24 20:20:10.0 +
+++ d52-3.4.1/debian/copyright  2024-03-24 20:03:49.0 +
@@ -1,28 +1,20 @@
-This package was debianized by Uwe Hermann  on
-Sat, 16 Feb 2008 15:45:54 +0100.
-
-It was downloaded from:
-
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Comment:
+This package was debianized by Uwe Hermann  on
+Sat, 16 Feb 2008 15:45:54 +0100.
+Source:
 http://home.pacbell.net/theposts
-
-Upstream Author:
-
+Upstream-Contact:
 Jeff Post 
 

-
 Files: *
 Copyright: © 1995-2007 Jeff Post 
 License: GPL-3+
-
-On Debian systems, the complete text of the GNU General
-Public License can be found in `/usr/share/common-licenses/GPL-3'.
-

+ On Debian systems, the complete text of the GNU General
+ Public License can be found in `/usr/share/common-licenses/GPL-3'.
 
 Files: debian/*
 Copyright: © 2008 Uwe Hermann 
 License: GPL-2+
 The Debian packaging is (C) 2008, Uwe Hermann  and
 is licensed under the GPL (version 2 or later), see above.
-
diff -Nru d52-3.4.1/debian/patches/10_honor_nostrip.patch 
d52-3.4.1/debian/patches/10_honor_nostrip.patch
--- d52-3.4.1/debian/patches/10_honor_nostrip.patch 2024-03-24 
20:20:10.0 +
+++ d52-3.4.1/debian/patches/10_honor_nostrip.patch 2024-03-24 
20:03:49.0 +
@@ -1,5 +1,5 @@
 Makefile.orig  2008-02-16 16:13:55.0 +0100
-+++ Makefile   2008-02-16 16:14:32.0 +0100
+--- a/Makefile.orig2008-02-16 16:13:55.0 +0100
 b/Makefile 2008-02-16 16:14:32.0 +0100
 @@ -27,15 +27,12 @@
  
  d52: $(D52OBJS)
diff -Nru d52-3.4.1/debian/patches/series d52-3.4.1/debian/patches/series
--- d52-3.4.1/debian/patches/series 1970-01-01 00:00:00.0 +
+++ d52-3.4.1/debian/patches/series 2024-03-24 20:03:49.0 +
@@ -0,0 +1,2 @@
+10_honor_nostrip.patch
+20-fix-format-security-error.patch
diff -Nru d52-3.4.1/debian/rules d52-3.4.1/debian/rules
--- d52-3.4.1/debian/rules  2024-03-24 20:20:10.0 +
+++ d52-3.4.1/debian/rules  2024-03-24 20:03:49.0 +
@@ -4,7 +4,6 @@
 
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/makefile.mk
-include /usr/share/cdbs/1/rules/simple-patchsys.mk
 
 install/d52::
install d52 debian/d52/usr/bin
diff -Nru d52-3.4.1/debian/source/format d52-3.4.1/debian/source/format
--- d52-3.4.1/debian/source/format  1970-01-01 00:00:00.0 +
+++ d52-3.4.1/debian/source/format  2024-03-24 20:03:49.0 +
@@ -0,0 +1 @@
+3.0 (quilt)


Bug#1007546: d52: please consider upgrading to 3.0 source format

2022-03-15 Thread Lucas Nussbaum
Source: d52
Version: 3.4.1-1.1
Severity: wishlist
Tags: bookworm sid
Usertags: format1.0 format1.0-nkp-nv

Dear maintainer,

This package is among the few (1.9%) that still use source format 1.0 in
bookworm.  Please upgrade it to source format 3.0, as (1) this format has many
advantages, as documented in https://wiki.debian.org/Projects/DebSrc3.0 ; (2)
this contributes to standardization of packaging practices.

Please note that this is also a sign that the packaging of this software
could maybe benefit from a refresh. It might be a good opportunity to
look at other aspects as well.


This mass bug filing was discussed on debian-devel@:
https://lists.debian.org/debian-devel/2022/03/msg00074.html

Thanks

Lucas