Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Bastian, 在 2022/5/27 16:55, Bastian Germann 写道: Hi Xiao, Please remove the debian/links file. We do not need the README in /etc. Ok, removed. What about those public gnb index nodes? Is the list published somewhere except for this package? These public gnb index nodes is published in upstream github repo, https://github.com/gnbdev/opengnb/blob/master/README_EN.md The IP of public index nodes perhaps will change in the further, the upstream author also will update them. If the upstream new version release and public index nodes update, I'll also update them when I do new package. Let I added some notes for it in debian/etc/opengnb/default/address.conf # These public gnb index nodes may change, please visit # https://github.com/gnbdev/opengnb/blob/master/README_EN.md to get the newest # public gnb index nodes infos. # OpenGNB will take affect at lease one of these nodes exist when you don't # setup your own public index node. Is this OK? Uploaded the package to mentors.d.n https://mentors.debian.net/package/opengnb/ Thanks! -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Xiao, Please remove the debian/links file. We do not need the README in /etc. What about those public gnb index nodes? Is the list published somewhere except for this package? Thanks, Bastian
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
在 2022/5/27 01:03, xiao sheng wen(肖盛文) 写道: > Hi Bastian, > > Thanks for your investigate for murmurhash license. > > 在 2022/5/26 22:23, Bastian Germann 写道: >> Plus points: File a bug on Debian's nginx pkg which notifies them that >> src/core/ngx_murmurhash.c and >> debian/modules/http-ndk/src/hash/murmurhash2.c >> are actually public domain and misrepresented in their d/copyright. > I'll bugreport in tomorrow. reported. please see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011936 > > > Thanks! > -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Bastian, Thanks for your investigate for murmurhash license. 在 2022/5/26 22:23, Bastian Germann 写道: > > https://github.com/nginx/nginx/commit/42f1e1cb96b510d1fa1abad99a5294a37b750d99 > > introduced this. There is no license info attached to it. > > The Debian package most probably just thought it inherits nginx's > license. > That might be wrong. Therefore, I suggested to find the original, > which should be some other place than nginx. > > https://github.com/aappleby/smhasher/blob/master/src/MurmurHash2.cpp > has some versions of this hash, and > https://github.com/aappleby/smhasher/blob/master/README.md > says "All MurmurHash versions are public domain software, and the > author disclaims all copyright to their code." > > You can cite that in the comment and mark it public-domain again. Yes, updated. Files: libs/hash/murmurhash.c Copyright: Austin Appleby License: Public-Domain Comment: https://github.com/aappleby/smhasher/blob/master/README.md says "All MurmurHash versions are public domain software, and the author disclaims all copyright to their code." Uploaded to: https://mentors.debian.net/package/opengnb/ > > Plus points: File a bug on Debian's nginx pkg which notifies them that > src/core/ngx_murmurhash.c and > debian/modules/http-ndk/src/hash/murmurhash2.c > are actually public domain and misrepresented in their d/copyright. I'll bugreport in tomorrow. Thanks! -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Am 26.05.22 um 13:28 schrieb xiao sheng wen(肖盛文): For murmurhash, you would have to find the original version to really know that it is public-domain. The nginx version has a copyright statement but I could find murmurhash v2 implementations that are public domain. However, I did not find the nginx version elsewhere quickly. I use apt source nginx to get the source code in sid, I find the original version. I compared the libs/hash/murmurhash.c and nginx-1.20.2/src/core/ngx_murmurhash.c, only the function name is different. This file use BSD-2-clause, it said by nginx d/copyright. I update the infos for this file: Files: libs/hash/murmurhash.c Copyright: Copyright (C) Austin Appleby License: BSD-2-clause Comment: original comes from nginx-1.20.2/src/core/ngx_murmurhash.c only rename the function name by the upstream author. https://github.com/nginx/nginx/commit/42f1e1cb96b510d1fa1abad99a5294a37b750d99 introduced this. There is no license info attached to it. The Debian package most probably just thought it inherits nginx's license. That might be wrong. Therefore, I suggested to find the original, which should be some other place than nginx. https://github.com/aappleby/smhasher/blob/master/src/MurmurHash2.cpp has some versions of this hash, and https://github.com/aappleby/smhasher/blob/master/README.md says "All MurmurHash versions are public domain software, and the author disclaims all copyright to their code." You can cite that in the comment and mark it public-domain again. Plus points: File a bug on Debian's nginx pkg which notifies them that src/core/ngx_murmurhash.c and debian/modules/http-ndk/src/hash/murmurhash2.c are actually public domain and misrepresented in their d/copyright.
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Bastian, Thanks for your quick reply. 在 2022/5/26 17:26, Bastian Germann 写道: > > Please change the last comment to say: > struct iphdr comes from FreeBSD and is modified by the upstream author. > The other parts of this file is written by the upstream author. > > Otherwise this looks good. Updated. > > ed25519's license name "Expat" is misleading. Please rename it to "zlib". Renamed. > > For murmurhash, you would have to find the original version to really > know > that it is public-domain. The nginx version has a copyright statement > but I > could find murmurhash v2 implementations that are public domain. > However, I > did not find the nginx version elsewhere quickly. I use apt source nginx to get the source code in sid, I find the original version. I compared the libs/hash/murmurhash.c and nginx-1.20.2/src/core/ngx_murmurhash.c, only the function name is different. This file use BSD-2-clause, it said by nginx d/copyright. I update the infos for this file: Files: libs/hash/murmurhash.c Copyright: Copyright (C) Austin Appleby License: BSD-2-clause Comment: original comes from nginx-1.20.2/src/core/ngx_murmurhash.c only rename the function name by the upstream author. > > Here is my suggestion: > > Description: P2P de-centralized layer 3 VPN > OpenGNB is a de-centralized virtual private network (VPN) to set-up a > layer 3 network via P2P with the capability of NAT traversal. > . > OpenGNB can add many nodes and LANs together into one big VPN. > OpenGNB supports public index nodes to forward net packages. > . > opengnb support the following platforms: > Linux, FreeBSD, OpenBSD, and macOS. > . > OpenGNB uses UDP by default. With the software gnb_udp_over_tcp > installed it can also use TCP. > Updated. Uploaded to: https://mentors.debian.net/package/opengnb/ Thanks! -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Am 26.05.22 um 06:05 schrieb xiao sheng wen(肖盛文): Files: libs/protocol/network_protocol.h Copyright:1995, 1996, 1997, and 1998 WIDE Project. 1982, 1986, 1993 The Regents of the University of California. License: BSD-3-clause Comment: The upstream distribution does not contain an explicit statement of copyright ownership. . struct ip6_hdr come from FreeBSD: src/sys/netinet/ip6.h /* $FreeBSD: src/sys/netinet/ip6.h,v 1.5 2001/06/11 12:39:00 ume Exp $ */ /* $KAME: ip6.h,v 1.18 2001/03/29 05:34:30 itojun Exp $ */ . struct iphdr come from BSD, modified by upstream author. The other parts of this file is write by upstream author. Is this acceptable? Please change the last comment to say: struct iphdr comes from FreeBSD and is modified by the upstream author. The other parts of this file is written by the upstream author. Otherwise this looks good. ed25519's license name "Expat" is misleading. Please rename it to "zlib". For murmurhash, you would have to find the original version to really know that it is public-domain. The nginx version has a copyright statement but I could find murmurhash v2 implementations that are public domain. However, I did not find the nginx version elsewhere quickly. Your comment "It is assumed that all content is copyright by its respective authors unless otherwise stated" actually contradicts the idea of public domain, which to get rid of copyright explicitly for some copyrightable work. If you do not find the original, please consider replacing this file. There is at least the package libmurmurhash available (but I do not know if it is an equivalent version). I also minor update the d/control file for the package description's grammar. Here is my suggestion: Description: P2P de-centralized layer 3 VPN OpenGNB is a de-centralized virtual private network (VPN) to set-up a layer 3 network via P2P with the capability of NAT traversal. . OpenGNB can add many nodes and LANs together into one big VPN. OpenGNB supports public index nodes to forward net packages. . opengnb support the following platforms: Linux, FreeBSD, OpenBSD, and macOS. . OpenGNB uses UDP by default. With the software gnb_udp_over_tcp installed it can also use TCP.
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Bastian, Thanks for your detail review d/copyright. I'd added the copyright infos as your suggestions. The libs/protocol/network_protocol.h is mixed the third-party file and upstream author's modify. I add some comments on it: Files: libs/protocol/network_protocol.h Copyright:1995, 1996, 1997, and 1998 WIDE Project. 1982, 1986, 1993 The Regents of the University of California. License: BSD-3-clause Comment: The upstream distribution does not contain an explicit statement of copyright ownership. . struct ip6_hdr come from FreeBSD: src/sys/netinet/ip6.h /* $FreeBSD: src/sys/netinet/ip6.h,v 1.5 2001/06/11 12:39:00 ume Exp $ */ /* $KAME: ip6.h,v 1.18 2001/03/29 05:34:30 itojun Exp $ */ . struct iphdr come from BSD, modified by upstream author. The other parts of this file is write by upstream author. Is this acceptable? I also minor update the d/control file for the package description's grammar. I uploaded the new package to: https://mentors.debian.net/package/opengnb/ The attachment is orig ip.h file come from FreeBSD. Thanks! xiao sheng wen 在 2022/5/24 00:50, Bastian Germann 写道: > Hi Xiao, > > On Wed, 27 Apr 2022 08:14:51 +0800 wrote: >> Changes for the initial release: >> >> opengnb (1.2.8.7-1) unstable; urgency=low >> . >> [ xiao sheng wen(肖盛文) ] >> * Initial release (Closes: #1003101) > > I have had a first look at d/copyright. There are some problems: > > * license shortname has to be GPL-3+ as the "or later" clause is used > * missing tap-windows.h license (has to be included even if not compiled) > => It is GPL-3+ incompatible GPL-2 licensed but okay as it is not > compiled. > * missing murmurhash license (might be public domain but has to be > documented) > * missing ed25519 license > * missing miniupnpc license. The license has to be included even > though its deb pkg is used. > > Where does libs/protocol/network_protocol.h come from? It looks like a > third-party file. > This might be a copyright violation. > > d/control: Please have a look at the package description's grammar > again, especially simple present singular-s is missing at some places. > > Thanks, > Bastian > > -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB /* $FreeBSD: src/sys/netinet/ip6.h,v 1.5 2001/06/11 12:39:00 ume Exp $ */ /* $KAME: ip6.h,v 1.18 2001/03/29 05:34:30 itojun Exp $ */ /* * Copyright (C) 1995, 1996, 1997, and 1998 WIDE Project. * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. * 2. Redistributions in binary form must reproduce the above copyright *notice, this list of conditions and the following disclaimer in the *documentation and/or other materials provided with the distribution. * 3. Neither the name of the project nor the names of its contributors *may be used to endorse or promote products derived from this software *without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE PROJECT AND CONTRIBUTORS ``AS IS'' AND * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL THE PROJECT OR CONTRIBUTORS BE LIABLE * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. */ /* * Copyright (c) 1982, 1986, 1993 * The Regents of the University of California. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. * 2. Redistributions in binary form must reproduce the above copyright *notice, this list of conditions and the following disclaimer in the *documentation and/or other materials provided with the distribution. * 3. Neither the name of the University nor the names of its contributors *may be used to endorse or promote products derived from this software *without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Hi Xiao, On Wed, 27 Apr 2022 08:14:51 +0800 wrote: Changes for the initial release: opengnb (1.2.8.7-1) unstable; urgency=low . [ xiao sheng wen(肖盛文) ] * Initial release (Closes: #1003101) I have had a first look at d/copyright. There are some problems: * license shortname has to be GPL-3+ as the "or later" clause is used * missing tap-windows.h license (has to be included even if not compiled) => It is GPL-3+ incompatible GPL-2 licensed but okay as it is not compiled. * missing murmurhash license (might be public domain but has to be documented) * missing ed25519 license * missing miniupnpc license. The license has to be included even though its deb pkg is used. Where does libs/protocol/network_protocol.h come from? It looks like a third-party file. This might be a copyright violation. d/control: Please have a look at the package description's grammar again, especially simple present singular-s is missing at some places. Thanks, Bastian
Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "opengnb": * Package name : opengnb Version : 1.2.8.7-1 Upstream Author : gnbdev * URL : https://github.com/gnbdev/opengnb * License : GPL-3 * Vcs : https://salsa.debian.org/atzlinux-guest/opengnb Section : net The source builds the following binary packages: opengnb - via P2P to setup de-centralized layer3 network VPN To access further information about this package, please visit the following URL: https://mentors.debian.net/package/opengnb/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/o/opengnb/opengnb_1.2.8.7-1.dsc Changes for the initial release: opengnb (1.2.8.7-1) unstable; urgency=low . [ xiao sheng wen(肖盛文) ] * Initial release (Closes: #1003101) Regards, -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》https://www.atzlinux.com 基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x00186602339240CB OpenPGP_signature Description: OpenPGP digital signature
