Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Andres Salomon]

Control: tags -1 pending

https://salsa.debian.org/chromium-team/chromium/-/commit/727873cc6feddfca06e3708869ee5780e26e4d4f


On Thu, Jan 19 2023 at 10:50:53 AM +0100, Bastian Germann 
 wrote:

Am 18.01.23 um 19:16 schrieb Andres Salomon:
Ah great, I hadn't noticed!  If the build works, let me know and 
I'll reenable v4l2.


The build runs successfully on arm64 with v4l2 enabled and vaapi 
disabled (like in the original change).

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Bastian Germann]

Am 18.01.23 um 19:16 schrieb Andres Salomon:

Ah great, I hadn't noticed!  If the build works, let me know and I'll reenable 
v4l2.


The build runs successfully on arm64 with v4l2 enabled and vaapi disabled (like 
in the original change).

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Andres Salomon]

On Wed, Jan 18 2023 at 06:40:25 PM +0100, Bastian Germann 
 wrote:

Am 18.01.23 um 17:29 schrieb Andres Salomon:

Thanks for reopening!

Unfortunately it fails to build on all arm architectures including 
arm64:


https://buildd.debian.org/status/fetch.php?pkg=chromium&arch=arm64&ver=107.0.5304.68-1&stamp=1666793161&raw=0

linux/media/av1-ctrls.h is some weirdo header that's only available 
in a chromeos environment. Since upstream only builds arm on that, 
they don't seem to have noticed. Someone needs to test a build on 
arm* with that inclusion removed; I suspect they also included 
stuff from that header.


The current Debian source has moved the inclusion of the failing 
files to a place protected by
if (is_chromeos): 
https://chromium-review.googlesource.com/c/chromium/src/+/3982602


I am going to run a test build.



Ah great, I hadn't noticed!  If the build works, let me know and I'll 
reenable v4l2.

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Bastian Germann]

Am 18.01.23 um 17:29 schrieb Andres Salomon:

Thanks for reopening!

Unfortunately it fails to build on all arm architectures including arm64:

https://buildd.debian.org/status/fetch.php?pkg=chromium&arch=arm64&ver=107.0.5304.68-1&stamp=1666793161&raw=0

linux/media/av1-ctrls.h is some weirdo header that's only available in a chromeos environment. Since upstream only 
builds arm on that, they don't seem to have noticed. Someone needs to test a build on arm* with that inclusion removed; 
I suspect they also included stuff from that header.


The current Debian source has moved the inclusion of the failing files to a 
place protected by
if (is_chromeos): 
https://chromium-review.googlesource.com/c/chromium/src/+/3982602

I am going to run a test build.

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Andres Salomon]

Thanks for reopening!

Unfortunately it fails to build on all arm architectures including 
arm64:


https://buildd.debian.org/status/fetch.php?pkg=chromium&arch=arm64&ver=107.0.5304.68-1&stamp=1666793161&raw=0

linux/media/av1-ctrls.h is some weirdo header that's only available in 
a chromeos environment. Since upstream only builds arm on that, they 
don't seem to have noticed. Someone needs to test a build on arm* with 
that inclusion removed; I suspect they also included stuff from that 
header.


For my reference, the commit that added that header is this one - 
bbde6817bd3105d7fffa29f704cb0a8a4185317c

https://chromium-review.googlesource.com/c/chromium/src/+/3880774

On Wed, Jan 18 2023 at 04:14:38 PM +0100, Bastian Germann 
 wrote:

Control: found -1 107.0.5304.87-1

On Tue, 06 Sep 2022 16:47:13 -0400 Andres Salomon wrote:

This is enabled in 105.0.5195.102-1.
This was disabled again. Can we reenable it at least for arm64 if it 
only fails on armel/armhf?

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Bastian Germann]

Control: found -1 107.0.5304.87-1

On Tue, 06 Sep 2022 16:47:13 -0400 Andres Salomon wrote:

This is enabled in 105.0.5195.102-1.

This was disabled again. Can we reenable it at least for arm64 if it only fails 
on armel/armhf?

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Eschenbacher . Stefan]

I just wanted to test chromium 105 with v4l2 hw decoding but I have not found 
an entry in chromium 105 debian package changelog . Do you have any plans to 
add the patch for sid?

Best regards
Stefan Eschenbacher


Thanks for the patch!

The merged upstream patch is in chromium v105, but it's not in v104 (which is 
what we're currently on). v105 is slated for release on Aug 30th.

I'll will try including your patch in the v105 upload, at least for sid. Since 
it depends on kernel 5.17 headers, I'm not yet sure what to do about bullseye.
On 8/12/22 02:57, Eschenbacher.Stefan wrote:
On June 24 the Linux Mainline V4L2 stateless patch was merged.
media/gpu/v4l2: Split upstream compatible and ChromeOS specific code 
(Iff3c2a53) · Gerrit Code Review 
(googlesource.com)

-Without this patch there was only v4l2 stateless support for Chrome OS
-“use_vaapi=true” and “use_v4l2_codec=true” cannot be enabled at the same time. 
According to patch author Chen-Yu Tsai VA-API is for x86 platforms and v4l2 is 
for arm platforms.


The file “rules” must be patched to enable v4l2 and disable vaapi for arm 
devices:

--- /home/stefan/rules.old 2022-08-12 08:50:21.527565964 +0200
+++ /home/stefan/rules.new 2022-08-12 08:51:18.733269432 +0200
@@ -52,10 +52,10 @@
defines+=host_cpu=\"x64\" use_vaapi=true
endif
ifeq (arm64,$(DEB_HOST_ARCH))
-defines+=host_cpu=\"arm64\" use_vaapi=true
+defines+=host_cpu=\"arm64\" use_v4l2_codec=true use_vaapi=false
endif
ifeq (armhf,$(DEB_HOST_ARCH))
-defines+=host_cpu=\"arm\" use_vaapi=false arm_use_neon=false
+defines+=host_cpu=\"arm\" use_v4l2_codec=true use_vaapi=false 
arm_use_neon=false
endif
 # disabled features

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Andres Salomon]

Thanks for the patch!

The merged upstream patch is in chromium v105, but it's not in v104 
(which is what we're currently on). v105 is slated for release on Aug 30th.


I'll will try including your patch in the v105 upload, at least for sid. 
Since it depends on kernel 5.17 headers, I'm not yet sure what to do 
about bullseye.


On 8/12/22 02:57, Eschenbacher.Stefan wrote:


On June 24 the Linux Mainline V4L2 stateless patch was merged.

media/gpu/v4l2: Split upstream compatible and ChromeOS specific code 
(Iff3c2a53) · Gerrit Code Review (googlesource.com) 



-Without this patch there was only v4l2 stateless support for Chrome OS

-“use_vaapi=true” and “use_v4l2_codec=true” cannot be enabled at the 
same time. According to patch author Chen-Yu Tsai VA-API is for x86 
platforms and v4l2 is for arm platforms.


The file “rules” must be patched to enable v4l2 and disable vaapi for 
arm devices:


--- /home/stefan/rules.old 2022-08-12 08:50:21.527565964 +0200

+++ /home/stefan/rules.new 2022-08-12 08:51:18.733269432 +0200

@@ -52,10 +52,10 @@

defines+=host_cpu=\"x64\" use_vaapi=true

endif

ifeq (arm64,$(DEB_HOST_ARCH))

-defines+=host_cpu=\"arm64\" use_vaapi=true

+defines+=host_cpu=\"arm64\" use_v4l2_codec=true use_vaapi=false

endif

ifeq (armhf,$(DEB_HOST_ARCH))

-defines+=host_cpu=\"arm\" use_vaapi=false arm_use_neon=false

+defines+=host_cpu=\"arm\" use_v4l2_codec=true use_vaapi=false 
arm_use_neon=false


endif

 # disabled features

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Bastian Germann]

I second this request.

Bug#1011346: Enabling V4L2 Driver in Chromium Builds

[Andres Salomon]

Package: chromium
Severity: wishlist

On Fri, May 20, 2022 at 06:42, Eschenbacher.Stefan 
 wrote:

Dear Debian Chromium Team,



I am testing Debian Testing/Bookworm ARM64 with a NXP i.MX8MM board 
and Kernel 5.17. I try to use the new stateless v4l2 Linux API for 
video acceleration. The i.MX8MM has ha Hantro G1 and G2 stateless 
VPU. The VPU runs nice with Gstreamer 1.20 from Debian Testing 
/Bookworm if I use the following syntax:


gst-launch-1.0 filesrc 
location=~/Downloads/mixkit_night_tour_through_the_streets_of_a_big_city_40747_1_c18d1a09b3.mp4 
! parsebin ! v4l2slh264dec ! waylandsink




According to this link Chromium supports the new v4l2 request API for 
stateless VPUs as well:


Enabling V4L2 Driver in Chromium Builds (google.com) 





The following build flag must be set to enable it:

“use_v4l2_codec=true”



I have taken a look into “rules” file of 
http://deb.debian.org/debian/pool/main/c/chromium/chromium_101.0.4951.64-1.debian.tar.xz 
. 
There is no “use_v4l2_codec=true” entry. Is this flag set in 
another location? If I run Chromium 101 from Debian Testing with 
“--enable-features=VaapiVideoDecoder”chrome://gpu shows “Video 
decode=hardware accelerated” but CPU usage is still high. Could you 
add this flag in the future?




Mit freundlichen Grüßen / Kind Regards

* *

*Stefan Eschenbacher*–Test Engineer





Scheidt & Bachmann GmbH
Quality Assurance
 Breite Straße 132 – 41238 Mönchengladbach – Germany
 Phone: +49 2166 266-1199
eschenbacher.ste...@scheidt-bachmann.de 



www.scheidt-bachmann.com 





*Follow us:*

* *

 
 
 
 
  







Court of Record: HRB 2125 Registergericht Mönchengladbach, VAT ID 
No: DE 120830018 | SK 4120154764, WEEE No: DE

 Chairman of supervisory board: Andreas Schmitz
Managing Directors: Dr.-Ing.Norbert Miller (CEO), Dipl.-Ing. Heinrich 
Laumen, Dipl.-Ing. Matthias Augustyniak,
 Martin Kammler, Dipl.-Oec. Uwe Brünner,Dipl.-Ing. Jörg M. 
Heilingbrunner, Dr.-Ing. Michael Lenders




Please see our data privacy policy: 

Important Notice:This E-Mail and any files attached are confidential 
and may contain privileged information. If you are not the intended 
recipient, do not forward or disclose this E-Mail, open any 
attachments, make any copies or save this E-Mail anywhere. Please 
delete this E-Mail from your system and notify the sender (as 
applicable also by phone +49 2166 266-0). Thank you very much.




Please consider the environment - do you really need to print this 
email?