Bug#1012196: buglist
Thank you!
Bug#1012196: buglist
Control: tags -1 -moreinfo Now I named (hopefully) all. But how shall I name the Free Software Foundation?
Bug#1012196: buglist
Is there an easier way to obtain all used licenses? Actually I use `licensecheck --check '.py|js|html|rst|sh' --recursive --deb-machine --merge-licenses --lines 0 *` Or can I use just its output?
Bug#1012196: buglist
Control: tags -1 -moreinfo I did not receive the bts email. > No. Please check the copyright format description for the "with" keyword. > Also, please try to present the copyright info in a more consice way. When two file groups have the same copyright > holders please merge them (combining the years to a year enumeration or year range). I'm not sure if I understand correct but tried to merge groups with same copyright holders and licence. > I have already given you a hint that > "plugins/ipconsole/ipython_view.py by IBM Corporation is licensed under another variant of the BSD-3-Clause." > So, please do not use Michael Bostock's version for that file match but add a BSD-3-clause-IBM variant. > You should also remove his copyright line from the License: section because that is already in the Copyright: section. Thinking this is fixed now. > You have not explained "override_dh_usrlocal:". Removed. This was legacy code.
Bug#1012196: buglist
Control: tags -1 moreinfo
On Sun, 2 Oct 2022 18:02:38 + wrote:
Control: tags -1 -moreinfo
> d/copyright
> ===
>
> Some GPL-2+ licensed files have the following additional exception:
> # The developers of the Exaile media player hereby grant permission
> # for non-GPL compatible GStreamer and Exaile plugins to be used and
> # distributed together with GStreamer and Exaile. This permission is
> # above and beyond the permissions granted by the GPL license by which
> # Exaile is covered. If you modify this code, you may extend this
> # exception to your version of the code, but you are not obligated to
> # do so. If you do not wish to do so, delete this exception statement
> # from your version.
I reworked the copyright file based on
https://sources.debian.org/src/exaile/3.4.0.2-1/debian/copyright/
Is the extension represented correct?
No. Please check the copyright format description for the "with" keyword.
Also, please try to present the copyright info in a more consice way. When two file groups have the same copyright
holders please merge them (combining the years to a year enumeration or year range).
You can also use broader wildcards in Files: and override parts of the matches
with a later Files: match.
I have already given you a hint that
"plugins/ipconsole/ipython_view.py by IBM Corporation is licensed under another
variant of the BSD-3-Clause."
So, please do not use Michael Bostock's version for that file match but add a
BSD-3-clause-IBM variant.
You should also remove his copyright line from the License: section because
that is already in the Copyright: section.
> d/rules
> ===
>
> Please remove or explain the lines:
>
> dh_auto_clean
> make manpage
> make completion
> ...
> #override_dh_installdocs:
> # dh_installdocs readme
> override_dh_usrlocal:
>
> Please think of a different method instead of calling dh_auto_clean
during install time to get rid of __pycache__ if
> that is the reason for it. Maybe just copy the Makefile line '-find .
-name "__pycache__" -exec rm -rf {} \;' ?
The point was to remove __pychache__.
Now I prevent dh_auto_build to do `make compile`
You have not explained "override_dh_usrlocal:".
Bug#1012196: buglist
Control: tags -1 -moreinfo
> d/copyright
> ===
>
> Some GPL-2+ licensed files have the following additional exception:
> # The developers of the Exaile media player hereby grant permission
> # for non-GPL compatible GStreamer and Exaile plugins to be used and
> # distributed together with GStreamer and Exaile. This permission is
> # above and beyond the permissions granted by the GPL license by which
> # Exaile is covered. If you modify this code, you may extend this
> # exception to your version of the code, but you are not obligated to
> # do so. If you do not wish to do so, delete this exception statement
> # from your version.
I reworked the copyright file based on
https://sources.debian.org/src/exaile/3.4.0.2-1/debian/copyright/
Is the extension represented correct?
> d/rules
> ===
>
> Please remove or explain the lines:
>
> dh_auto_clean
> make manpage
> make completion
> ...
> #override_dh_installdocs:
> # dh_installdocs readme
> override_dh_usrlocal:
>
> Please think of a different method instead of calling dh_auto_clean
during install time to get rid of __pycache__ if
> that is the reason for it. Maybe just copy the Makefile line '-find .
-name "__pycache__" -exec rm -rf {} \;' ?
The point was to remove __pychache__.
Now I prevent dh_auto_build to do `make compile`
Bug#1012196: buglist
On Thu, 15 Sep 2022 00:27:15 +0200 Bastian Germann wrote: > On Tue, 13 Sep 2022 17:09:42 + =?UTF-8?B?QW5kcsOp?= wrote: > > > > > No, you have not got it. But maybe this is because of a change in the > > GitHub release page: > > > > > > $ uscan --download-current-version > > > uscan warn: In debian/watch no matching hrefs for version 4.1.2 in > > watch line > > > https://github.com/exaile/exaile/releases .*/?(\d\.\d.\d*)\.tar\.gz > > Works if use the tags page instead of releases. > > That would be okay but it also changes the file content. Got a working version. Seems to be related to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019696 > You need to repack. This involves adding a +dfsg suffix to the upstream version number. > You need to change this in d/changelog. For automatic renaming add a repacksuffix in d/watch. > List the files in the d/copyright field Files-Excluded (in the header paragraph) for automatic removal. > Done.
Bug#1012196: buglist
> No, you have not got it. But maybe this is because of a change in the GitHub release page: > > $ uscan --download-current-version > uscan warn: In debian/watch no matching hrefs for version 4.1.2 in watch line > https://github.com/exaile/exaile/releases .*/?(\d\.\d.\d*)\.tar\.gz Works if use the tags page instead of releases. > Hm... very-long-line-length-in-source-file is sometimes a good hint for non-source files. > Are the tagged files source files? What is their copyright status? Do the tests/data/music/delerium/chimera/05 - Truly* > files stem from a Delerium-copyrighted file? If so, is that song DFSG-free licensed? Else, you have to remove the files > from the Debian package. > This are only test files. How can I remove the files just in the debian package?
Bug#1012196: buglist
Control: tags -1 -moreinfo > You have NOT tested the file with the given command. Please remove the orig tarball to test it. > Hint: You are currently requesting a *-*.tar.gz file which worked for the beta but does not for the regular release. Now I got it. Thanks for the hint. > > > One question: > > How should I use lintian locally? > > If I run it with the .changes-file or with the .deb it just outputs > > nothing. I'm running it on Debian unstable. > Maybe you do not have warnings/errors anymore? Just build the package and from the source dir run lintian -IE --pedantic > to see come more messages. So I get the same messages as on m.d.n. Should I handle the pedantic messages?
Bug#1012196: buglist
Control: tags -1 moreinfo On Mon, 22 Aug 2022 20:48:47 + =?UTF-8?Q?Andr=c3=a9_Flechs?= wrote: Control: tags -1 -moreinfo > Hm... You did not answer where you have got the original from. > This file seems to be very different from d3.js in https://github.com/d3/d3/releases/download/v3.4.9/d3.zip I was quite sure to use exactly the file from this source. May be it was broken after the automatic reformating. However, I reformatted the original file by hand. > Also, plugins/playlistanalyzer/ext/LICENSE (BSD-3-clause) needs to be copyied to d/copyright. Please also match the file in debian/missing-sources for that license. > CC0-1.0 is availabe in /usr/share/common-licenses/CC0-1.0, so please reference this file instead of copying it verbosely > to d/copyright. Done > Please remove debian/readme as it does not contain additional info. How can I remove it? For now I just use an empty file, because without readme it won't build. You have to delete it from debian/docs also, obviously. > There are two problems with d/changelog: > > Please use the luzip665 name/email for the signature lines > because exaile is obviously not a natural person. > > The "Beta release" description is not true anymore. > Please just write "Reintroduce package (Closes: #785897)". Done Please also close #1012202 (the ITP) with the changelog again, which got lost on the way. > Your d/watch file does not work. You want to scan GitHub releases and not tags and fix the version regex. > Also, your orig tarball does not fit the released tar.gz because it has differences in pt.po. > Please test the download via uscan --download-current-version. Done You have NOT tested the file with the given command. Please remove the orig tarball to test it. Hint: You are currently requesting a *-*.tar.gz file which worked for the beta but does not for the regular release. One question: How should I use lintian locally? If I run it with the .changes-file or with the .deb it just outputs nothing. I'm running it on Debian unstable. Maybe you do not have warnings/errors anymore? Just build the package and from the source dir run lintian -IE --pedantic to see come more messages.
Bug#1012196: buglist
Control: tags -1 -moreinfo > Hm... You did not answer where you have got the original from. > This file seems to be very different from d3.js in https://github.com/d3/d3/releases/download/v3.4.9/d3.zip I was quite sure to use exactly the file from this source. May be it was broken after the automatic reformating. However, I reformatted the original file by hand. > Also, plugins/playlistanalyzer/ext/LICENSE (BSD-3-clause) needs to be copyied to d/copyright. > > CC0-1.0 is availabe in /usr/share/common-licenses/CC0-1.0, so please reference this file instead of copying it verbosely > to d/copyright. Done > Please remove debian/readme as it does not contain additional info. How can I remove it? For now I just use an empty file, because without readme it won't build. > There are two problems with d/changelog: > > Please use the luzip665 name/email for the signature lines > because exaile is obviously not a natural person. > > The "Beta release" description is not true anymore. > Please just write "Reintroduce package (Closes: #785897)". Done > Your d/watch file does not work. You want to scan GitHub releases and not tags and fix the version regex. > Also, your orig tarball does not fit the released tar.gz because it has differences in pt.po. > Please test the download via uscan --download-current-version. Done One question: How should I use lintian locally? If I run it with the .changes-file or with the .deb it just outputs nothing. I'm running it on Debian unstable.
Bug#1012196: buglist
Control: tags -1 moreinfo Your d/watch file does not work. You want to scan GitHub releases and not tags and fix the version regex. Also, your orig tarball does not fit the released tar.gz because it has differences in pt.po. Please test the download via uscan --download-current-version.
Bug#1012196: buglist
Control: tags -1 -moreinfo Did it by reformating. Shall I also handle warnings?
Bug#1012196: buglist
Got it so far. But there is one lintian error I have no idea about. There is an error about missing source of d3.js. For this I added (I hope) the source file to missing sources. But the error does not dissappear. I think it's because of one very long line 7796. How can I handle this? Just reformat?
Bug#1012196: buglist
As you have closed #672574 and #726559 via BTS already for a different version please remove them from the changelog. On Thu, 16 Jun 2022 05:10:41 + andre-fle...@posteo.de wrote: I had a look at all issues. That three bugs you mentioned are either fixed (#785897) or unreproducible (#726559, #672574). Same with the other bugs on https://bugs.debian.org/cgi-bin/pkgreport.cgi?repeatmerged=no=exaile How should I write the changelog to close unreproducible or fixed bugs? Am 11.06.22 um 10:24 schrieb Bastian Germann: > On Tue, 7 Jun 2022 16:32:40 + andre-fle...@posteo.de wrote: >> I added all issues to changelog as Closes. > > Have you really had a look at them? You do not just close them with no > comment in your changelog. > When you have verified the three bugs that I mentioned, please have > them in the line: > > * Beta release for Exaile 4.1.2 (Closes: #785897, #726559, #672574) > > For the others: Please only add them when you are sure they are resolved. > If you are not sure or you do not have the time for them, please leave > them untouched.
Bug#1012196: buglist
Control: tags -1 -moreinfo Hi Bastian, I updated the package and send mails to almost all bugs. There is only one issue left in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=706983. How should I handle this? Thanks again to David for the explanations. Kind regards, André
Bug#1012196: buglist
Hi, On Thu, Jun 16, 2022 at 05:10:41AM +, André Flechs wrote: > > For the others: Please only add them when you are sure they are resolved. > > If you are not sure or you do not have the time for them, please leave > > them untouched. > > How should I write the changelog to close unreproducible or fixed bugs? You don't. Closing a bug via the changelog is only for bugs which are resolved by this changelog entry. Ideally you have verified this yourself rather than relying on (educated) guess work. For the "fixed" one that is true with your upload I suppose? If not, but in an earlier version you would write a mail to -done@b.d.o with a Version pseudo-header and some free-form text saying something like "This bug was fixed in version 42-1 with the change hence I am closing as done. Feel free to reopen if this remained unresolved for you". The unreproducible ones you could close the same way without a Version header and some friendly free-form text saying something like "Closing as it is unreproducible (for years) and no more information could be acquired. Feel free to reopen if this still happens for you with more information so we can hopefully find and fix the issue". How friendly (or not) you want to be is your choice of course, both are just condensed examples of what I tend to do. Have a look at the developer-reference which has the entire chapter 5.8 dedicated to "Handling bugs" explaining how to deal with these and many other 'buggy situations' (SCNR). It also explains and points to further documentation about our BTS so that you will know what I mean above with pseudo-headers and -done without me repeating it here. Best regards David Kalnischkies signature.asc Description: PGP signature
Bug#1012196: buglist
Am 07.06.2022 um 18:32 teilte André Flechs mit: I added all issues to changelog as Closes. How can I remove the tag? https://www.debian.org/Bugs/server-control Hilmar -- sigfault OpenPGP_signature Description: OpenPGP digital signature
Bug#1012196: buglist
I added all issues to changelog as Closes. How can I remove the tag?
