Bug#1012354: Please add support for systemd-binfmt
Hello, On Sat 18 Jun 2022 at 10:37AM +02, Michael Biebl wrote: > Am 14.06.22 um 21:59 schrieb Michael Biebl: >> Am 14.06.22 um 21:50 schrieb Sean Whitton: >>> Hello, >>> >>> On Tue 14 Jun 2022 at 09:39PM +02, Michael Biebl wrote: >>> Hi Sean Am 13.06.22 um 03:14 schrieb Sean Whitton: > Thanks for the patch. I take it you got the sbcl.conf from the > binfmt-conf package? So systemd-binfmt means that these config files > get stored in packages rather than all stored in binfmt-conf? I'm confused. What's the "binfmt-conf" package? >>> >>> Sorry, I meant binfmt-support. >> >> Ok, then that's a no. >> >> I looked at that kind of binfmt configuration the sbcl package ships >> (i.e. debian/binfmt) and created sbcl.conf from that information. > > Maybe that was a bit misleading. > What I meant to say is that the information in sbcl.conf is not coming > from the binfmt-support package but from the binfmt config file shipped > in sbcl as debian/binfmt. > And in the same way, sbcl.conf should be shipped in the sbcl package. Cool, thank you. -- Sean Whitton signature.asc Description: PGP signature
Bug#1012354: Please add support for systemd-binfmt
Am 14.06.22 um 21:59 schrieb Michael Biebl: Am 14.06.22 um 21:50 schrieb Sean Whitton: Hello, On Tue 14 Jun 2022 at 09:39PM +02, Michael Biebl wrote: Hi Sean Am 13.06.22 um 03:14 schrieb Sean Whitton: Thanks for the patch. I take it you got the sbcl.conf from the binfmt-conf package? So systemd-binfmt means that these config files get stored in packages rather than all stored in binfmt-conf? I'm confused. What's the "binfmt-conf" package? Sorry, I meant binfmt-support. Ok, then that's a no. I looked at that kind of binfmt configuration the sbcl package ships (i.e. debian/binfmt) and created sbcl.conf from that information. Maybe that was a bit misleading. What I meant to say is that the information in sbcl.conf is not coming from the binfmt-support package but from the binfmt config file shipped in sbcl as debian/binfmt. And in the same way, sbcl.conf should be shipped in the sbcl package. Regards, Michael OpenPGP_signature Description: OpenPGP digital signature
Bug#1012354: Please add support for systemd-binfmt
Am 14.06.22 um 21:50 schrieb Sean Whitton: Hello, On Tue 14 Jun 2022 at 09:39PM +02, Michael Biebl wrote: Hi Sean Am 13.06.22 um 03:14 schrieb Sean Whitton: Thanks for the patch. I take it you got the sbcl.conf from the binfmt-conf package? So systemd-binfmt means that these config files get stored in packages rather than all stored in binfmt-conf? I'm confused. What's the "binfmt-conf" package? Sorry, I meant binfmt-support. Ok, then that's a no. I looked at that kind of binfmt configuration the sbcl package ships (i.e. debian/binfmt) and created sbcl.conf from that information. Michael OpenPGP_signature Description: OpenPGP digital signature
Bug#1012354: Please add support for systemd-binfmt
Hello, On Tue 14 Jun 2022 at 09:39PM +02, Michael Biebl wrote: > Hi Sean > > Am 13.06.22 um 03:14 schrieb Sean Whitton: >> Thanks for the patch. I take it you got the sbcl.conf from the >> binfmt-conf package? So systemd-binfmt means that these config files >> get stored in packages rather than all stored in binfmt-conf? > > I'm confused. What's the "binfmt-conf" package? Sorry, I meant binfmt-support. -- Sean Whitton signature.asc Description: PGP signature
Bug#1012354: Please add support for systemd-binfmt
Hi Sean Am 13.06.22 um 03:14 schrieb Sean Whitton: Thanks for the patch. I take it you got the sbcl.conf from the binfmt-conf package? So systemd-binfmt means that these config files get stored in packages rather than all stored in binfmt-conf? I'm confused. What's the "binfmt-conf" package? OpenPGP_signature Description: OpenPGP digital signature
Bug#1012354: Please add support for systemd-binfmt
Hello Michael, On Sun 05 Jun 2022 at 04:09PM +02, Michael Biebl wrote: > Package: sbcl > Version: 2:2.2.3-1 > Severity: wishlist > Tags: patch > User: pkg-systemd-maintain...@lists.alioth.debian.org > Usertags: systemd-binfmt > > Hi, > > your package sbcl declares a dependency (Recommends) on binfmt-support > and ships binfmt-support configuration files in /usr/share/binfmt/. > > systemd provides a builtin, cross-distro facility named systemd-binfmt to > register binary formats. > > You can read more about it at > https://www.freedesktop.org/software/systemd/man/systemd-binfmt.html > https://www.freedesktop.org/software/systemd/man/binfmt.d.html > https://www.kernel.org/doc/html/latest/admin-guide/binfmt-misc.html > > The systemd package provides a dpkg file trigger so it is sufficient to > simply install configuration files in /usr/lib/binfmt.d/, no > modifications in the maintainer scripts are necessary. > > The attached patch adds support for systemd-binfmt and adjusts the > dependency on binfmt-support accordingly, so binfmt-support is no longer > installed automatically if systemd is already installed. Thanks for the patch. I take it you got the sbcl.conf from the binfmt-conf package? So systemd-binfmt means that these config files get stored in packages rather than all stored in binfmt-conf? -- Sean Whitton signature.asc Description: PGP signature
Bug#1012354: Please add support for systemd-binfmt
Package: sbcl
Version: 2:2.2.3-1
Severity: wishlist
Tags: patch
User: pkg-systemd-maintain...@lists.alioth.debian.org
Usertags: systemd-binfmt
Hi,
your package sbcl declares a dependency (Recommends) on binfmt-support
and ships binfmt-support configuration files in /usr/share/binfmt/.
systemd provides a builtin, cross-distro facility named systemd-binfmt to
register binary formats.
You can read more about it at
https://www.freedesktop.org/software/systemd/man/systemd-binfmt.html
https://www.freedesktop.org/software/systemd/man/binfmt.d.html
https://www.kernel.org/doc/html/latest/admin-guide/binfmt-misc.html
The systemd package provides a dpkg file trigger so it is sufficient to
simply install configuration files in /usr/lib/binfmt.d/, no
modifications in the maintainer scripts are necessary.
The attached patch adds support for systemd-binfmt and adjusts the
dependency on binfmt-support accordingly, so binfmt-support is no longer
installed automatically if systemd is already installed.
Regards,
Michael
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.17.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages sbcl depends on:
ii libc6 2.33-7
ii zlib1g 1:1.2.11.dfsg-4
Versions of packages sbcl recommends:
ii binfmt-support 2.2.2-1
Versions of packages sbcl suggests:
pn sbcl-doc
ii sbcl-source 2:2.2.3-1
pn slime
-- no debconf information
diff -Nru sbcl-2.2.3/debian/changelog sbcl-2.2.3/debian/changelog
--- sbcl-2.2.3/debian/changelog 2022-04-26 10:33:33.0 +0200
+++ sbcl-2.2.3/debian/changelog 2022-06-05 15:37:33.0 +0200
@@ -1,3 +1,9 @@
+sbcl (2:2.2.3-1.1) UNRELEASED; urgency=medium
+
+ * Add support for systemd-binfmt
+
+ -- Michael Biebl Sun, 05 Jun 2022 15:37:33 +0200
+
sbcl (2:2.2.3-1) unstable; urgency=medium
* New upstream release.
diff -Nru sbcl-2.2.3/debian/control sbcl-2.2.3/debian/control
--- sbcl-2.2.3/debian/control 2022-04-01 08:49:20.0 +0200
+++ sbcl-2.2.3/debian/control 2022-06-05 15:37:20.0 +0200
@@ -36,7 +36,7 @@
Architecture: any
Depends: ${shlibs:Depends},
${misc:Depends}
-Recommends: binfmt-support
+Recommends: binfmt-support | systemd
Suggests: sbcl-doc,
sbcl-source,
slime
diff -Nru sbcl-2.2.3/debian/sbcl.conf sbcl-2.2.3/debian/sbcl.conf
--- sbcl-2.2.3/debian/sbcl.conf 1970-01-01 01:00:00.0 +0100
+++ sbcl-2.2.3/debian/sbcl.conf 2022-06-05 15:36:30.0 +0200
@@ -0,0 +1 @@
+:binfmt:M::# FASL\x0a::/usr/lib/sbcl/sbcl-run:
diff -Nru sbcl-2.2.3/debian/sbcl.install sbcl-2.2.3/debian/sbcl.install
--- sbcl-2.2.3/debian/sbcl.install 2022-04-01 08:49:06.0 +0200
+++ sbcl-2.2.3/debian/sbcl.install 2022-06-05 15:37:05.0 +0200
@@ -3,3 +3,4 @@
usr/share/man/man1/sbcl.1
debian/sbclrc /etc
debian/sbcl-run /usr/lib/sbcl
+debian/sbcl.conf /usr/lib/binfmt.d
