Bug#1012572: android-platform-frameworks-base: FTBFS with protobuf 3.20.1+

[Roger Shimizu]

Dear Mattia,

Thanks for the remind!
I'll upload the patch to sid soon.

Cheers,
Roger

On Sun, Dec 4, 2022 at 8:49 PM Mattia Rizzolo  wrote:

> Hello Roger,
>
> On Fri, Jun 10, 2022 at 09:48:06PM +0900, Roger Shimizu wrote:
> > I tried your patch by installing protobuf in experimental
> > and confirmed it builds well, and all tests are also OK.
> > Will upload after protobuf 3.20 (or later) hits unstable.
> > Thanks for your support!
>
> You uploaded this patch to experimental, however I see no sign of v13 to
> be uploaded to unstable anytime soon.
>
> Can you please apply this same patch also in unstable?
>
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
> More about me:  https://mapreri.org : :'  :
> Launchpad user: https://launchpad.net/~mapreri  `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
>

Bug#1012572: android-platform-frameworks-base: FTBFS with protobuf 3.20.1+

[Mattia Rizzolo]

Hello Roger,

On Fri, Jun 10, 2022 at 09:48:06PM +0900, Roger Shimizu wrote:
> I tried your patch by installing protobuf in experimental
> and confirmed it builds well, and all tests are also OK.
> Will upload after protobuf 3.20 (or later) hits unstable.
> Thanks for your support!

You uploaded this patch to experimental, however I see no sign of v13 to
be uploaded to unstable anytime soon.

Can you please apply this same patch also in unstable?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#1012572: android-platform-frameworks-base: FTBFS with protobuf 3.20.1+

[Roger Shimizu]

control: tags -1 pending

Dear GCS,

I tried your patch by installing protobuf in experimental
and confirmed it builds well, and all tests are also OK.
Will upload after protobuf 3.20 (or later) hits unstable.
Thanks for your support!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#1012572: android-platform-frameworks-base: FTBFS with protobuf 3.20.1+

[GCS]

Source: android-platform-frameworks-base
Version: 1:10.0.0+r36-5
Severity: important
Usertags: protobuf3_20
Tags: ftbfs upstream bookworm sid patch

Hi,

I would like to start the Protobuf 3.20.1 transition in a few days.
Your package is currently FTBFS for a simple reason. The function
SetTotalBytesLimit doesn't have a second argument for long (protobuf
3.6) and it was ignored previously. Now it's finally removed and hence
your package doesn't build anymore.
As it was ignored for a long time, the fix is easy, just remove that
argument when calling the mentioned function. Patch is attached,
please apply it soon.

Thanks,
Laszlo/GCS
Description: fix Protobuf FTBFS
 SetTotalBytesLimit no longer has second argument.
Author: Laszlo Boszormenyi (GCS) 
Forwarded: no
Last-Update: 2022-06-06

---

--- android-platform-frameworks-base-10.0.0+r36.orig/tools/aapt2/io/Util.h
+++ android-platform-frameworks-base-10.0.0+r36/tools/aapt2/io/Util.h
@@ -131,8 +131,7 @@ class ProtoInputStreamReader {
   template  bool ReadMessage(T *message_lite) {
 ZeroCopyInputAdaptor adapter(in_);
 google::protobuf::io::CodedInputStream coded_stream();
-coded_stream.SetTotalBytesLimit(std::numeric_limits::max(),
-coded_stream.BytesUntilTotalBytesLimit());
+coded_stream.SetTotalBytesLimit(std::numeric_limits::max());
 return message_lite->ParseFromCodedStream(_stream);
   }